On Dec. 6, 2011, 6:39 p.m., Commit Hook wrote:
This review has been submitted with commit
08325ba32b72326030004cc28430431193d82fc2 by Thomas Lübking to branch
KDE/4.7.
This commit causes systemsettings to go into endless recursion, see
http://privatepaste.com/0e43ad214c
zemo on
The new endless loop (causing a stack overflow here when I resize
systemsettings view) this time is in:
QListView::resizeEvent(QResizeEvent *e)
that calls QAbstractItemView::resizeEvent(e);
QAbstractItemView::resizeEvent(QResizeEvent *event)
that calls KCategorizedView::updateGeometries();
On Wednesday 23 November 2011 00:28:07 Pau Garcia i Quiles wrote:
1) Changes to ui_standards.rc
This is a high-risk change. It affects every application that uses
XMLGUI and KParts plugins. I did quite a lot of work in this area in
KDE 3.x and I know that changes to this file could have
On Dec. 6, 2011, 6:39 p.m., Commit Hook wrote:
This review has been submitted with commit
08325ba32b72326030004cc28430431193d82fc2 by Thomas Lübking to branch
KDE/4.7.
Christoph Feck wrote:
This commit causes systemsettings to go into endless recursion, see
On Thu, Dec 8, 2011 at 2:33 AM, Thomas Lübking thomas.luebk...@web.dewrote:
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103335/
On December 6th, 2011, 6:39 p.m., *Commit Hook* wrote:
This review has been submitted with commit
Am Thu, 8 Dec 2011 07:59:43 -0800
schrieb Tomaz Canabrava tcanabr...@kde.org:
What about jaime patch?
yeah, static policies work - we know that ;-)
This one is quite different (recursion, not race - though maybe both),
from the first rough look there seem two recursions, one direct (easy
to
Aaron J. Seigo wrote:
yes, i skipped the details. done properly it should be linking
libkactivities. this is an acceptable short term work-around given it's in
a branch, while doing it right requires the modularization to be
complete for at least libkactivities dependencies.
Or it'd require
Aaron J. Seigo wrote:
yes, i skipped the details. done properly it should be linking
libkactivities. this is an acceptable short term work-around given it's in
a branch, while doing it right requires the modularization to be
complete for at least libkactivities dependencies.
Or it'd require
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103335/#review8802
---
- Thomas Lübking
On Dec. 8, 2011, 6:04 p.m., Thomas Lübking
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103335/#review8803
---
kdeui/itemviews/kcategorizedview.cpp
On Monday 21 November 2011 20:27:28 Andriy Rysin wrote:
In regards to defect below, what's the right location for some xml files
I use in keyboard daemon tests? Currently the files I have is to test
the code for parsing /usr/share/X11/xkb/rules/evdev.xml but some others
could be added later...
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103199/#review8804
---
Ship it!
Ship It!
- David Faure
On Nov. 21, 2011, 8:11
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102986/#review8808
---
Thx, looks better. Just one comment for code readability, feel
On Nov. 17, 2011, 2:33 p.m., David Faure wrote:
David Faure wrote:
Cyril, can you rebase your changes on top of the kdelibs frameworks
branch, compile, and commit there?
Cyril Oblikov wrote:
Hi David.
I'm currently working on this dialog together with Björn
On Thursday 08 December 2011 17.12.05 Kevin Kofler wrote:
Aaron J. Seigo wrote:
yes, i skipped the details. done properly it should be linking
libkactivities. this is an acceptable short term work-around given it's
in a branch, while doing it right requires the modularization to be
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103335/
---
(Updated Dec. 8, 2011, 6:04 p.m.)
Review request for kdelibs, Rafael
On Thursday 08 December 2011 16:56:16 David Faure wrote:
khelpmenu seems to have been ported from qt3 without much thinking, the
actions in menu() could just use kstandardaction too, instead of
duplicating the action details... but that's for frameworks 5 :)
Hmm, actually that's just
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103360/
---
Review request for kdelibs and David Faure.
Description
---
Cut the
18 matches
Mail list logo
