mimetype for files with a wrong extension?

2012-04-09 Thread Boudewijn Rempt
I'm trying to figure out why kmimetype returns image/jpeg for a png file that was renamed to have a jpg extension (which apparently happens a lot for real users). In the dox for KMimeType::findByUrl it's said that if only the filename is used to determine the mimetype, accuracy is set to 80 --

Re: Setting up a Quality Team within KDE

2012-04-09 Thread Andreas Pakulat
On 09.04.12 12:58:02, Alexander Neundorf wrote: On Friday 06 April 2012, Anne-Marie Mahfouf wrote: On 04/06/2012 02:23 PM, Aleix Pol wrote: On Thu, Apr 5, 2012 at 1:42 PM, Anne-Marie Mahfouf annemarie.mahf...@free.fr wrote: Hi, We would like to setup a Quality Testing Team

Re: Re: Setting up a Quality Team within KDE

2012-04-09 Thread Martin Gräßlin
On Monday 09 April 2012 13:15:26 Andreas Pakulat wrote: There is not only Jenkins, but also CDash, which integrates nicely with our cmake-based build system. I was trying to set up nightly builds for the KDE modules two years ago or so (hosted on http://my.cdash.org, some of our

Re: Setting up a Quality Team within KDE

2012-04-09 Thread Michael Jansen
On Monday, April 09, 2012 02:05:28 PM Martin Gräßlin wrote: On Monday 09 April 2012 13:15:26 Andreas Pakulat wrote: There is not only Jenkins, but also CDash, which integrates nicely with our cmake-based build system. I was trying to set up nightly builds for the KDE modules two

Re: Question about unittesting

2012-04-09 Thread Albert Astals Cid
El Diumenge, 8 d'abril de 2012, a les 21:45:34, Giorgos Tsiapaliwkas va escriure: Hello, Why we don't have in KDE a macro like, if (application_is_in_debug_mode) { //do some testing } Because then you are not testing your real code anymore. Albert Why we need a macro like that?

Re: Setting up a Quality Team within KDE

2012-04-09 Thread Andreas Pakulat
On 09.04.12 13:28:31, Anne-Marie Mahfouf wrote: On 04/09/2012 01:15 PM, Andreas Pakulat wrote: On 09.04.12 12:58:02, Alexander Neundorf wrote: On Friday 06 April 2012, Anne-Marie Mahfouf wrote: On 04/06/2012 02:23 PM, Aleix Pol wrote: On Thu, Apr 5, 2012 at 1:42 PM, Anne-Marie Mahfouf

Re: Setting up a Quality Team within KDE

2012-04-09 Thread Andreas Pakulat
On 09.04.12 14:29:27, Michael Jansen wrote: On Monday, April 09, 2012 02:05:28 PM Martin Gräßlin wrote: On Monday 09 April 2012 13:15:26 Andreas Pakulat wrote: There is not only Jenkins, but also CDash, which integrates nicely with our cmake-based build system. I was trying

Re: Setting up a Quality Team within KDE

2012-04-09 Thread Andreas Pakulat
On 09.04.12 16:27:17, Laszlo Papp wrote: Well, I'd say jenkins has a lot more to offer than cdash. Its also a lot simpler to use, setup and understand for newcomers in my opinion. With jenkins I can have a shell-script job which runs cmake make make test and be done. Setting up a build

Re: Review Request: KJS: Implement Object.GetOwnPropertyDescriptor Object.DefineProperty

2012-04-09 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104515/ --- (Updated April 9, 2012, 8:23 p.m.) Review request for kdelibs. Changes

Re: Setting up a Quality Team within KDE

2012-04-09 Thread Laszlo Papp
Hmm, that may work if your project has usually no warnings, but I find this for warnings to be too much noise. We have also had many warnings back then. :-) The CI mails should immediately tell me if CI is considered broken (and warnings are often not considered that) or not and if its

Re: Setting up a Quality Team within KDE

2012-04-09 Thread Andreas Pakulat
On 09.04.12 23:29:17, Laszlo Papp wrote: I will also try out this Jenkins in the future once I find the time for that, but I have been a happy CDash user for about ten months by now. :-) build.kde.org can give you a pretty good idea of how jenkins looks and can be used to do CI. I

Review Request: Make nepomuk runner remove undesired matches

2012-04-09 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104526/ --- Review request for KDE Runtime. Description --- Nepomuk runner

Re: Review Request: Copy files instead of moving if parent dir is not writable

2012-04-09 Thread Lamarque Vieira Souza
On March 30, 2012, 8:18 p.m., Thomas Lübking wrote: Any more questions about this patch? Can I push it? - Lamarque Vieira --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request: Add cmake config for kdeclarative library.

2012-04-09 Thread Lamarque Vieira Souza
On March 5, 2012, 8:51 p.m., Alexander Neundorf wrote: experimental/libkdeclarative/KDeclarativeConfig.cmake.in, line 14 http://git.reviewboard.kde.org/r/104140/diff/1/?file=51648#file51648line14 I didn't check, but how is INCLUDE_INSTALL_DIR set ? Is it done by via

Re: Review Request: KJS: Implement Object.prototypeOf, Object.keys, Object.getOwnPropertyNames

2012-04-09 Thread Maks Orlovich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104511/#review12281 --- kjs/function.cpp

Re: Review Request: KJS: Implement Object.GetOwnPropertyDescriptor Object.DefineProperty

2012-04-09 Thread Maks Orlovich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104515/#review12282 --- I think I need a bit of higher-level info from here; plus I

Re: Setting up a Quality Team within KDE

2012-04-09 Thread Laszlo Papp
Also IIRC there was a blog-post inviting people to submit requests for the addition of their projects. I believe, I missed that. I also don't see any KDE playground apps on my.cdash.org :) http://my.cdash.org/index.php?project=Gluon http://my.cdash.org/index.php?project=QtOpenAL (You do

Re: Setting up a Quality Team within KDE

2012-04-09 Thread Laszlo Papp
I also don't see any KDE playground apps on my.cdash.org :) http://my.cdash.org/index.php?project=Gluon http://my.cdash.org/index.php?project=QtOpenAL (You do not find it in playground since it was deleted 1-2 days ago after migrating to Qt Playground, but it has been hosted there). Ah yes,

Review Request: fix kio_sftp login after pressing cancel in the retry dialog

2012-04-09 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104529/ --- Review request for KDE Runtime and Andreas Schneider. Description ---