Re: Review Request 110563: Crash fix: hide symbols from static lib QtUitools.a (generically by new macro KDE4_HIDE_SYMBOLS_FROM_STATIC_LIBS)

> On May 22, 2013, 6:28 p.m., Alexander Neundorf wrote: > > The documentation for the macro should be at the top of > > FindKDE4Internal.cmake, where all the documentation is. > > > > For the technical side: this flag is new to me. Is it the only possible > > solution ? Thiago ? > > Thomas Lü

Re: Review Request 110563: Crash fix: hide symbols from static lib QtUitools.a (generically by new macro KDE4_HIDE_SYMBOLS_FROM_STATIC_LIBS)

> On May 22, 2013, 6:28 p.m., Alexander Neundorf wrote: > > The documentation for the macro should be at the top of > > FindKDE4Internal.cmake, where all the documentation is. > > > > For the technical side: this flag is new to me. Is it the only possible > > solution ? Thiago ? > > Thomas Lü

Re: Review Request 110084: Make ftp error messages prettier

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110084/#review33249 --- kioslave/ftp/ftp.cpp

Re: Review Request 109611: Add option to show "Recently Installed" apps in kickoff plasmoid

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109611/#review33248 --- Ship it! Looks ok to me, just minor style issues. I don't main

Re: KDE Workspace broken due to upstream CMake changes

On Monday 27 May 2013, Ben Cooksley wrote: > On Tue, May 28, 2013 at 7:37 AM, Alexander Neundorf wrote: > > On Monday 27 May 2013, Rolf Eike Beer wrote: > >> Am 27.05.2013 09:13, schrieb Ben Cooksley: > >> > Hi all, > >> > > >> > It seems that a recent upstream change in CMake has now broken the

Re: KDE Workspace broken due to upstream CMake changes

On Tue, May 28, 2013 at 12:51 AM, Rolf Eike Beer wrote: > Am 27.05.2013 09:13, schrieb Ben Cooksley: > >> Hi all, >> >> It seems that a recent upstream change in CMake has now broken the >> build of KDE Workspace. Can someone please fix or prod CMake upstream >> into revising their policies? >> >>

Re: KDE Workspace broken due to upstream CMake changes

On Tue, May 28, 2013 at 7:37 AM, Alexander Neundorf wrote: > On Monday 27 May 2013, Rolf Eike Beer wrote: >> Am 27.05.2013 09:13, schrieb Ben Cooksley: >> > Hi all, >> > >> > It seems that a recent upstream change in CMake has now broken the >> > build of KDE Workspace. Can someone please fix or p

Re: KDE Workspace broken due to upstream CMake changes

On Monday 27 May 2013, Rolf Eike Beer wrote: > Am 27.05.2013 09:13, schrieb Ben Cooksley: > > Hi all, > > > > It seems that a recent upstream change in CMake has now broken the > > build of KDE Workspace. Can someone please fix or prod CMake upstream > > into revising their policies? > > > > The

Review Request 110673: Fixed problems in opening files with unicode space character in its path.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110673/ --- Review request for kdelibs. Description --- Fixed Bug 268771. The isS

Re: Review Request 107983: Fix KWindowSystem::compositingChanged signal

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/#review33239 --- This review has been submitted with commit 73fa526cd5541e74c3e

Re: Review Request 107983: Fix KWindowSystem::compositingChanged signal

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/ --- (Updated May 27, 2013, 6:14 p.m.) Status -- This change has been mark

Re: Review Request 110670: fixes for qml import paths order

> On May 27, 2013, 1:25 p.m., Lamarque Souza wrote: > > ksmserver/shutdowndlg.cpp, line 235 > > > > > > What is exactly the bug this patch is trying to solve? Is there any bug > > entry in bugzilla for it (or the

Re: KDE Workspace broken due to upstream CMake changes

Am 27.05.2013 09:13, schrieb Ben Cooksley: Hi all, It seems that a recent upstream change in CMake has now broken the build of KDE Workspace. Can someone please fix or prod CMake upstream into revising their policies? The lack of warning here concerning the change is a little irritating. -- Lo

Re: Review Request 110670: fixes for qml import paths order

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110670/#review33217 --- ksmserver/shutdowndlg.cpp

Re: Review Request 110670: fixes for qml import paths order

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110670/ --- (Updated May 27, 2013, 1:14 p.m.) Review request for kde-workspace, kwin a

Review Request 110670: fixes for qml import paths order

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110670/ --- Review request for kde-workspace, kwin and Plasma. Description --- QD

Re: Review Request 110663: Don't save state of running activities unless asked to by the session manager

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110663/#review33215 --- src/service/Activities.cpp

Re: Review Request 110390: Do not set Phonon KCM as changed at startup when using PulseAudio

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110390/#review33212 --- This review has been submitted with commit 625b40da4fea11b6a20

Re: Review Request 110390: Do not set Phonon KCM as changed at startup when using PulseAudio

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110390/ --- (Updated May 27, 2013, 11:24 a.m.) Status -- This change has been mar

Re: Review Request 110390: Do not set Phonon KCM as changed at startup when using PulseAudio

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110390/#review33211 --- This review has been submitted with commit 7f5a51e38df0bf43248

Re: Review Request 110390: Do not set Phonon KCM as changed at startup when using PulseAudio

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110390/#review33209 --- Ship it! Ship It! - Casian Andrei On May 13, 2013, 8:10 a.m

Review Request 110663: Don't save state of running activities unless asked to by the session manager

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110663/ --- Review request for kde-workspace and Ivan Čukić. Description --- Only

Review Request 110662: Add dbus signal to ksmserver, used for requesting session saving from services.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110662/ --- Review request for kde-workspace, Aaron J. Seigo, Kevin Ottens, Ivan Čukić,

Re: Review Request 110462: Call new Instance dbus method on Windows when a KUniqueApplication is already running

> On May 27, 2013, 9:05 a.m., Patrick Spendrin wrote: > > kdeui/kernel/kuniqueapplication.cpp, line 181 > > > > > > Why do we still fail this function (exit(255)), even if we actually are > > still doing a meanin

Re: Review Request 110462: Call new Instance dbus method on Windows when a KUniqueApplication is already running

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110462/#review33192 --- kdeui/kernel/kuniqueapplication.cpp

KDE Workspace broken due to upstream CMake changes

Hi all, It seems that a recent upstream change in CMake has now broken the build of KDE Workspace. Can someone please fix or prod CMake upstream into revising their policies? The lack of warning here concerning the change is a little irritating. -- Looking for XkbLockModifiers in X11 CMake Error