not
duplicating work. Especially if he has written any useful profiling
tools.
David Edmundson
http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Kde-soc-mentor mailing list
kde-soc-men...@kde.org
https://mail.kde.org/mailman
of cool stuff and future
proofing. Wayland support is already on the cards, Plymouth integrates
and works. All the little bugs will be fixed before too long, and it
will match KDM in stability/features within a few months. Does KDM
still run the greeters as root?
David Edmundson
David Edmunson
/diff
Testing
---
Thanks,
David Edmundson
2012/2/7 Martin Klapetek martin.klape...@gmail.com:
On Mon, Feb 6, 2012 at 08:12, Jos Poortvliet j...@opensuse.org wrote:
On Sunday, January 08, 2012 09:46:37 Daniele E. Domenichelli wrote:
snip stuff from aeons ago
Heya,
Ladies and gents - the reminder I promised to send: this weekend
On Fri, Feb 24, 2012 at 8:44 AM, Andras Mantia aman...@kde.org wrote:
On Thursday, February 23, 2012 04:57:16 PM David Edmundson wrote:
First of all, the bugzilla is supposed to be a communication tool between
the user and the developer.
Or is it?
If I understand Martin correctly, he wants
In KDE Telepathy one the tasks I'm currently doing is certificate
handling. We get the certificate from telepathy and have to prompt the
user if they want to accept an invalid certificate.
All the normal SSL work is done in this telepathy component shared by
gnome, but any user prompts have to go
On Fri, Apr 6, 2012 at 12:36 AM, Thiago Macieira thi...@kde.org wrote:
On quinta-feira, 5 de abril de 2012 21.41.00, David Edmundson wrote:
In KDE Telepathy one the tasks I'm currently doing is certificate
handling. We get the certificate from telepathy and have to prompt the
user if they want
or making a release. This has been
discussed on their mailing list. [5].
Thanks in advance
David Edmundson
[1] https://projects.kde.org/projects/kdereview/ktp-call-ui
[2] http://gkiagia.wordpress.com/2012/03/29/video-calls-in-kde-telepathy/
[3]
http://community.kde.org/Real
On Sun, Apr 29, 2012 at 2:42 PM, Kevin Krammer kram...@kde.org wrote:
On Sunday, 2012-04-29, Martin Klapetek wrote:
On Sat, Apr 28, 2012 at 22:44, Kevin Krammer kram...@kde.org wrote:
On Saturday, 2012-04-28, George Kiagiadakis wrote:
No, the classes that wrap GObjects do not need a
On May 9, 2012, 6:30 p.m., Mark Gaiser wrote:
Ehh optional perhaps?
I've seen forms behave like this before and back then when i first saw it i
tried to delete the text.. Which obviously didn't happen. The text just
disappears as soon as i start typing. I kinda dislike that behavior.
a race condition, I don't quite understand your
reservation, Mark?
David Edmundson wrote:
No it doesn't. Currently if you give an item focus you hide the
placeholder text. In this patch it only hides placeholder text after you
start typing.
^ That reply was at Sebastian where he says
On Sun, Jun 3, 2012 at 10:45 PM, Albert Astals Cid aa...@kde.org wrote:
El Dijous, 31 de maig de 2012, a les 20:10:08, David Edmundson va escriure:
On Mon, Apr 30, 2012 at 11:28 PM, David Edmundson
da...@davidedmundson.co.uk wrote:
On Sun, Apr 29, 2012 at 2:42 PM, Kevin Krammer kram
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105590/#review15954
---
Ship it!
Ship It!
- David Edmundson
On July 16, 2012, 11
On Fri, Jul 20, 2012 at 4:58 PM, Martin Gräßlin mgraess...@kde.org wrote:
Hi all,
the problems around review request #105628 and getting KWallet's Password
dialog properly raised above the window it is asking the password for just
triggered a thought process.
The main problem here is that
On Fri, Jul 20, 2012 at 7:46 PM, Martin Gräßlin mgraess...@kde.org wrote:
On Friday 20 July 2012 18:25:15 David Edmundson wrote:
On Fri, Jul 20, 2012 at 4:58 PM, Martin Gräßlin mgraess...@kde.org wrote:
Hi all,
the problems around review request #105628 and getting KWallet's Password
://www.sharpley.org.uk/lightdm-google-authentication,
http://www.sharpley.org.uk/blog/an-update-on-lightdm-kde
[4] http://static.davidedmundson.co.uk/lightdm_design_rationale.html
Regards
David Edmundson
On Wed, Aug 22, 2012 at 9:50 PM, Albert Astals Cid aa...@kde.org wrote:
El Dimecres, 22 d'agost de 2012, a les 13:58:57, David Edmundson va escriure:
As you're all probably aware I've been working on a new login manager
for KDE [1]. Currently known as LightDM-KDE, named as it is based
On Wed, Aug 22, 2012 at 3:56 PM, Yuri Chornoivan yurc...@ukr.net wrote:
написане Wed, 22 Aug 2012 15:58:57 +0300, David Edmundson
da...@davidedmundson.co.uk:
As you're all probably aware I've been working on a new login manager
for KDE [1]. Currently known as LightDM-KDE, named
On Thu, Aug 23, 2012 at 8:41 AM, Andras Mantia aman...@kde.org wrote:
On Wednesday, August 22, 2012 01:58:57 PM David Edmundson wrote:
- a big refactor (see branch big_refactor)
Without going into other details: what would be the reason to merge LightDM
*now*, if you have a big refactoring
On Wed, Aug 22, 2012 at 11:53 PM, Matthias Klumpp matth...@tenstral.net wrote:
2012/8/22 Albert Astals Cid aa...@kde.org:
El Dimecres, 22 d'agost de 2012, a les 13:58:57, David Edmundson va escriure:
As you're all probably aware I've been working on a new login manager
for KDE [1]. Currently
On Wed, Aug 29, 2012 at 9:17 PM, Thomas Lübking
thomas.luebk...@gmail.com wrote:
Am 29.08.2012, 03:21 Uhr, schrieb Harald Sitter sit...@kde.org:
On Wed, Aug 29, 2012 at 2:59 AM, Thomas Lübking
thomas.luebk...@gmail.com wrote:
but I'm willing to
be enlightened about the striking advances of
, push for this change to happen. As far
as I can tell from Google searching this is a fairly small technical
change, but needs pushing to happen.
Regards
David Edmundson
on behalf of Martin Gräßlin, Janek Bevendorff , Myriam Schweingruber et al.
On Mon, Sep 3, 2012 at 7:50 AM, Martin Klapetek
martin.klape...@gmail.com wrote:
On Sun, Sep 2, 2012 at 11:07 PM, David Edmundson
da...@davidedmundson.co.uk wrote:
However, when a KDE developer files a bug this step is skipped and the
bug is automatically marked as NEW.
I may be wrong
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106782/#review20150
---
Ship it!
Looks good to me.
- David Edmundson
On Oct. 10
).toString() == text/x-html)
should be
== QLatin1String(text/x-html);
(this is in many places)
--
David Edmundson
KArchive.
Therefore by setting the rootDir twice either implicitly or explicitly (which
this assert is designed to avoid) you risk leaking the first KArchiveDirectory
object.
I think you need something more involved than just removing the checks.
- David Edmundson
On Nov. 5, 2012, 2:47 p.m
side of message widget
lining up with the frame below.
Also opened in Kate, KMail, Bluetooth KCM, ktp-accounts-kcm. All instances
lined up.
Screenshots
---
Original KMessageWidget (left) and improved KMessageWidget (right)
http://git.reviewboard.kde.org/r/107332/s/833/
Thanks,
David
. To reply, visit:
http://git.reviewboard.kde.org/r/107332/#review22024
---
On Nov. 15, 2012, 6:40 a.m., David Edmundson wrote:
---
This is an automatically generated e-mail. To reply, visit
) and improved KMessageWidget (right)
http://git.reviewboard.kde.org/r/107332/s/833/
Thanks,
David Edmundson
On Dec. 12, 2012, 6:43 p.m., Laszlo Papp wrote:
It did not get a ship it back then for the plasma components, but I would
not like to block the rediscussion, just saying what happened earlier. :-)
https://git.reviewboard.kde.org/r/104895/
One of the key arguments people had then was
On Thu, Jan 3, 2013 at 4:43 PM, Daniel Nicoletti dantt...@gmail.com wrote:
It's a known issue, we ha random code running on the same thread.. A work
around is to put the code on a thread, and make sure all your call are non
blocking.
I'm planing on doing a prof of concept to change the way
---
Emitted notifications which were known to trigger the bug.
Thanks,
David Edmundson
Summary:
Few minor comments. Nothing particularly exciting.
All in all I was fairly impressed with the code, it's neat and tidy
and you've had 2 releases which is the right approach to getting in
Extragear
Assuming you've addressed Albert's comments, +1 from me on this.
Comments
---
unstable. Have you
made these releases elsewhere? If so can you provide a link.
Thanks
David Edmundson
On Fri, May 10, 2013 at 3:38 PM, LucaTringali tringalinv...@libero.it wrote:
The fact is that, before releasing the first binary package, I would like to
be
sure the code respects KDE guidelines. Otherwise, I would need to create a
second package just to adjust the code for KDE.
Luca
SONAME so the release 1.1 will have 1.1 set as SONAME.
Also, the krazy issues are fixed as well, alongwith support for
translation with lot of help :)
On Mon, Apr 22, 2013 at 5:05 PM, David Edmundson
da...@davidedmundson.co.uk wrote:
Summary:
Few minor comments. Nothing particularly exciting
()
then display an error message
There was an error setting the image: /home/david/.icon which is a bit
misleading.
- David Edmundson
On June 7, 2013, 9:33 p.m., Greg T wrote:
---
This is an automatically generated e-mail
Code wise, things looks pretty good.
Minor comments:
- the library is GPL, not LGPL which is the norm for libraries.
Is this deliberate?
- Inside kscreen you have a copy of the metadata.desktop file twice.
Just have the one and install it to the two places.
You might also want to use the
created whilst we're running,
we won't connect to it.
plasma/generic/applets/activitybar/package/contents/ui/main.qml
http://git.reviewboard.kde.org/r/111992/#comment27709
Remove this :)
- David Edmundson
On Aug. 10, 2013, 4:39 p.m., Bhushan Shah wrote
it!
- David Edmundson
On Aug. 13, 2013, 4:11 a.m., Bhushan Shah wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111992
catch it.
reviewboard-am
http://git.reviewboard.kde.org/r/112081/#comment27963
I've had this fail several times; bad review numbers, dodgy internet
connection etc.
A try+catch may make the output a lot less intimidating than the current
exception backtraces.
- David Edmundson
Aug. 14, 2013, 3:26 p.m.)
Review request for kdelibs and David Edmundson.
Description
---
Add reviewboard-am, a tool to apply patches from KDE reviewboard.
(subscribing the kdelibs group to this request because there seems to be no
kde-dev-scripts group)
Diffs
/
---
(Updated Aug. 14, 2013, 3:26 p.m.)
Review request for kdelibs and David Edmundson.
Description
---
Add reviewboard-am, a tool to apply patches from KDE reviewboard.
(subscribing the kdelibs group to this request because there seems to be no
kde-dev-scripts group
Where do you use KRun?
Remove this line and see if it still compiles. I think it will.
- David Edmundson
On Aug. 26, 2013, 11:09 a.m., Bhushan Shah wrote:
---
This is an automatically generated e-mail. To reply, visit:
http
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112326/#review38791
---
Ship it!
Ship It!
- David Edmundson
On Aug. 28, 2013, 11
, but there is a new replacement
that it should be ported to.
see
http://api.kde.org/frameworks/kdelibs-apidocs/tier2/ki18n/html/prg_guide.html#link_cat
i.e
#define TRANSLATION_DOMAIN ksgrd
#include KLocalizedString
- David Edmundson
On Oct. 3, 2013, 5:50 a.m
This has been in kdereview for over 3 months now. It is probably safe
to move, though I would still like a reply to my comments
We should not be recommending to packagers to ship code that is in
playground, it defeats the point of the playground separation where a
lot of code is not ship-abble.
The whole discussion of whether gnome excludes apps without app-data
will improve the quality of those listed is sort of a moot topic.
We could do with this having this sort of metadata available for all KDE apps;
and in fact we already maintain this sort of data to build the pages
at
Spec comments:
- The spec says to link to a .desktop file for the application.
This is typically installed with the application (or it is in KDE apps
anyway), I'm confused as to how this is intended to work.
- I would include project icon and project license in the file format.
Maybe this is
Attached is an appdata xml file for every kde project.
http://static.davidedmundson.co.uk/kde_appdata.zip (note, I have not
tested these in anything)
and the script to generate it
http://static.davidedmundson.co.uk/appdata_generator.txt
(requires an svn checkout
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114123/#review45305
---
Ship it!
Ship It!
- David Edmundson
On Nov. 25, 2013, 8:45
On 24 Dec 2013 18:57, Thomas Lübking thomas.luebk...@gmail.com wrote:
On Dienstag, 24. Dezember 2013 19:29:11 CEST, Vishesh Handa wrote:
On Tuesday 24 Dec 2013 13:06:55 Christoph Feck wrote:
How does Baloo cooperate with Nepomuk? Note that we have ABI
guarantees, so if the metadata is not
On Tue, Dec 24, 2013 at 11:32 PM, Thomas Lübking
thomas.luebk...@gmail.com wrote:
On Dienstag, 24. Dezember 2013 22:03:28 CEST, Àlex Fiestas wrote:
On Tuesday 24 December 2013 21:25:37 Ivan Čukić wrote:
The point is, that you virtually cannot make a release that breaks half the
former
Vishesh,
Review of the folder core
itemtype.h is useless.
- it is not namespaced and it doesn't do anything.
datastore.h
- it's public, so should use a d-pointer.
query.cpp
- you don't delete d ?
- there's a few things still TODO
result.h
does it make sense to use Baloo::Item::Id
On Wed, Dec 25, 2013 at 10:15 PM, Thomas Lübking
thomas.luebk...@gmail.com wrote:
On Mittwoch, 25. Dezember 2013 21:06:56 CEST, David Edmundson wrote:
With the planned slow transition of apps from kdelibs4 to frameworks
we are going to have a point where we have apps on either side.
I expect
Code Review of baloo/file/lib
==file.cpp
Should it override type() from Item and set it to File ?
==filemodifyjob.cpp.
The code won't unset a rating, comments or tags on multiple files.
You update Xapian ok, but you're not calling fsetxattr().
The d pointer leaks?
==DB.cpp
SQLITE3- SQLITE
This doesn't need to be be in the first release but I would like an
exposed Qt interface to fsetxattrs and xgetxattrs.
Ideally this would be exposed in the File object, maybe with some sort
of QVariantMap userProperties() method.
FileFetchJob would then load all the properties in the same way
Add COPYING file
ExtractorPluginManager::fetchExtractors seems odd to me.
If it can't find any plugins it searches for all plugins that start
the same prefix.
I assume it's designed so I can have a plugin with the mimetype audio/
that will still match the file mimetype audio/mp3
But this
https://git.reviewboard.kde.org/r/115260/#comment34078
Use units
plasma/desktop/qmlpackages/lookandfeel/contents/osd/Osd.qml
https://git.reviewboard.kde.org/r/115260/#comment34079
use parent.height instead of writing 200 again, otherwise it will break
when you update it.
- David
There is an existing page about slitting runtime here:
http://community.kde.org/Frameworks/Epics/New_Runtime_Organization
linked to from http://community.kde.org/Frameworks/Epics
Alex's wiki page looks far more populated.
We should make sure we avoid wiki duplication.
David
.
The goal is to have a second keyboard that locks the screen. Applications that
monitor activeChanged will be able to tell if the screen was locked
specifically because this second shortcut was pressed as opposed to any other
lock cause.
- David Edmundson
On Jan. 24, 2014, 9:08 a.m., James Smith
the typo in your commit message.
Deafult - Default
Execute the wallet - Execute the walletManager
- David Edmundson
On Feb. 13, 2014, 5:13 p.m., Àlex Fiestas wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115728/#review49756
---
Ship it!
Ship It!
- David Edmundson
On Feb. 13, 2014, 5
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115726/#review50061
---
Ship it!
- David Edmundson
On Feb. 13, 2014, 5:13 p.m
-desktop.defaultPanel/contents/layout.js
https://git.reviewboard.kde.org/r/116117/#comment36210
numberOfPanelsOnScreen might be a clearer variable name, as the number of
panels is clearly panelIds.length
- David Edmundson
On March 1, 2014, 11:47 a.m., Jan Grulich wrote
We can add a CC list to the bugzilla product.
Pardon my ignorance, but does Gtk impose CSD on all apps, or just
those apps that opt-in to using it?
GTK apps can opt out (by not using a GTKHeader widget)
I can't imagine the Gimp adopting that design anytime soon. They're
already quite far from Gnome HIG.
I patched GTK here:
keeps the URL
scheme.
- David Edmundson
On June 7, 2014, 4:43 p.m., Victor Dodon wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118604
?
- David Edmundson
On Feb. 13, 2014, 5:13 p.m., Àlex Fiestas wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115727
do much without
it. Sorry.
- David Edmundson
On July 29, 2014, 9:43 a.m., TOM Harrison wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118180
On 12 Sep 2014 22:53, Marco Martin notm...@gmail.com wrote:
On Tuesday, September 9, 2014, Jan Kundrát j...@flaska.net wrote:
If you would like all plasma to go, just give me a list of repos and I
can make it happen.
No, definitely not yet
In my opinion, the purpose of this test is
http://qt-project.org/doc/qt-5/qwidget.html#windowModified-prop
And then digikam will stop using their own copy?
If so this change makes complete sense to me.
You could also consider making it a framework in the future if you think it
would have wider usage outside kdegraphics apps.
Please make sure to add license headers on all files in libkface before
release. There seem to be a lot missing.
On Sat, Sep 27, 2014 at 1:39 PM, Gilles Caulier caulier.gil...@gmail.com
wrote:
2014-09-27 12:59 GMT+02:00 David Edmundson da...@davidedmundson.co.uk:
Please make sure to add license headers on all files in libkface before
release. There seem to be a lot missing.
Hum, which one ?
My bad
On Tue, Sep 30, 2014 at 11:38 AM, Gilles Caulier caulier.gil...@gmail.com
wrote:
2014-09-30 11:28 GMT+02:00 Martin Klapetek martin.klape...@gmail.com:
On Tue, Sep 30, 2014 at 7:44 AM, Gilles Caulier
caulier.gil...@gmail.com
wrote:
2014-09-30 3:06 GMT+02:00 Vishesh Handa m...@vhanda.in:
Hey all,
I want to merge SDDM-KCM [1] into Plasma for 5.2. It's in kdereview now
starting the mandatory review period.
It's a config module for configuring SDDM, the Display Manager. Mostly
themes and autologin, plus some misc options.
The final destination will be workspace.
Application
On Thu, Oct 9, 2014 at 12:56 AM, Jeremy Whiting jpwhit...@kde.org wrote:
David,
I cloned the git repo here, and built it and installed it next to my
other kf5 stuff. (The README still mentions kde4-config, that probably
should be updated btw).
It runs ok here, but doesn't work :) Maybe I
outranks everyone
else combined.
- David Edmundson
On Nov. 6, 2014, 9:06 p.m., Thomas Lübking wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121021
http://projects.bitergia.com/kde/browser/ has stats on regular contributors
vs casual.
I'm not quite sure what those terms actually mean, but it seems very much
like what you might want?
David
I meant to send this message to kde-core-devel, forwarding here.
Sorry if you see this as a duplicate
-- Forwarded message --
From: David Edmundson da...@davidedmundson.co.uk
Date: Fri, Nov 28, 2014 at 3:19 PM
Subject: Moving polkit-kde-agent-1 to kde/workspace
To: kde-de
The binary is called kpackagetool. Given the complications we've had with
frameworks co-installability does it make sense to call it kpackagetool5?
The class name in kpackagetool/kpackagetool.cpp should probably be renamed
Documentation at the top of PackageLoader should avoid saying Plasma
No objections from me
On Thu, Jan 1, 2015 at 4:56 PM, Albert Astals Cid aa...@kde.org wrote:
El Dimarts, 23 de desembre de 2014, a les 13:17:46, Daniel Vrátil va
escriure:
On Friday, December 19, 2014 06:46:11 PM Luigi Toscano wrote:
Jonathan Riddell ha scritto:
Plasma 5.2 is due out next month and there's
On Thu, Jan 1, 2015 at 4:50 PM, Albert Astals Cid aa...@kde.org wrote:
El Divendres, 19 de desembre de 2014, a les 17:27:01, Jonathan Riddell va
escriure:
Touchpad KCM, ported to KF5 by Rajeesh K Nambiar
https://projects.kde.org/projects/playground/utils/kcm-touchpad
This is not a kcm,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121831/#review76201
---
Ship it!
- David Edmundson
On Feb. 15, 2015, 4:35 p.m
On Thu, Jan 8, 2015 at 5:54 PM, Luigi Toscano luigi.tosc...@tiscali.it
wrote:
Jonathan Riddell ha scritto:
On Thu, Jan 08, 2015 at 07:33:58AM -0200, Lamarque Souza wrote:
Regarding ModemManagerQt, libbluedevil, libkscreen and baloo, they
are
supposed to be frameworks stuff (not sure
Moreover we can't build debugging symbols on most archs due to the enormous
amount of RAM+swap it involves in the linking process (more than 8GB last
time
I checked). This is at least the same as QtWebKit, but seems to be getting
worse.
gold linker seems to handle this a /lot/ better than
We've had it marked as hard requirement for a long time in
https://techbase.kde.org/Policies/Application_Lifecycle
But it's true that Plasma has been specially good in not following the
rule.
Plasma is not an application.
David
Repo contains GTK 2 and GTK 3 themes which are similar to Breeze.
The target is to move to kde/workspace for Plasma 5.5.
Full discussion here:
https://forum.kde.org/viewtopic.php?f=285=125246=60
Most work done by ScionicSpectre and dirruk1.
Things I'm not sure of:
i18n - I've not set
https://bugs.kde.org/buglist.cgi?list_id=1303835=Spectacle
Done.
/127073/ ?
- David Edmundson
On Feb. 17, 2016, 4:23 p.m., Daniel Faust wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
(line 554)
<https://git.reviewboard.kde.org/r/127102/#comment63073>
rather than looping, can we use FontMetric's maximumCharacterWidth
* numChars.
Then we could kill sizeHelper competely (FontMetric's didn't exist when
this was written)
- David Edmundson
On Feb. 17
Sorry, I meant we should change the config that calls init-repository, not
init-repository itself.
It's in ci-builder-tools, I've made a patch.
David
From 3cc4c72b70d79b9132e4d7e31b09d5e14d916824 Mon Sep 17 00:00:00 2001
From: David Edmundson <k...@davidedmundson.co.uk>
Date: Thu, 21 Apr 2
QtWebkit isn't being developed, but it does still build and work. There's
even a qt5.6 tag in the qtwebkit repo.
>From the Qt5 output
https://build.kde.org/job/qt5%205.6%20kf5-qt5/PLATFORM=Linux,compiler=gcc/lastBuild/consoleText
it looks like we're not building qtwebkit.
I guess it's no longer
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129917/#review102571
---
Ship it!
Ship It!
- David Edmundson
On Feb. 7, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128949/#review99427
---
Ship it!
Do you have commit access?
- David Edmundson
.
If it still applies to current Plasma please reopen this review request. Thanks
- David Edmundson
On Jan. 16, 2013, 2:37 p.m., Yichao Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
.
If it still applies to current Plasma please reopen this review request. Thanks
- David Edmundson
On July 19, 2014, 6:43 p.m., Vadim Zhukov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
> For the record, I also asked Yichao to have a look at a comment one of
our
This issue has been resolved.
At which point, I think we're good to move? Any final objections?
1 - 100 of 132 matches
Mail list logo
