Re: KDE and Google Summer of Code 2018

2018-01-15 Thread Nate Graham
I've submitted an idea for System Settings: Improve handling for touchpads and mice with Libinput https://community.kde.org/GSoC/2018/Ideas#Improve_handling_for_touchpads_and_mice_with_Libinput This is pretty important going forward since most distros are shipping with Libinput now, but our

Re: CI system maintainability

2019-03-28 Thread Nate Graham
With regards to the discussion about mandatory code review, I think it's important to avoid immediately rushing to create new policy as a result of a particular event or abuse. It's always tempting to try to put in place a rule that would have avoided the problem if it had existed and was being

Re: Review Request: plasma-thunderbolt

2019-05-15 Thread Nate Graham
+1 from me; the original was good and this looks good too. One minor thing that I don't think should be a blocker: Could we copy FindBolt.cmake into ECM with an eye towards not needing it here in a future release? Nate On 5/15/19 7:27 AM, Daniel Vrátil wrote: Hi all, plasma-thunderbolt

Re: ksnapshot to unmaintained

2019-05-15 Thread Nate Graham
+1, clearly it is unmaintained, and in fact development has been abandoned given Spectacle's existence. Nate On 5/9/19 5:06 PM, Jonathan Riddell wrote: One would think so, but one would be wrong, at least on the labelling :) https://projects.kde.org/api/v1/projects/extragear/graphics

Re: What means having an application in "KDE Applications"

2019-06-19 Thread Nate Graham
On 6/16/19 3:41 PM, Luigi Toscano wrote: Jonathan Riddell ha scritto: On Fri, Jun 07, 2019 at 12:09:27AM +0200, Albert Astals Cid wrote: Can we please discuss what being in KDE Applications is first? You're telling apps they can join KDE Applications if they want, so to you it's just

Re: What means having an application in "KDE Applications"

2019-06-21 Thread Nate Graham
On 6/19/19 3:57 PM, Luigi Toscano wrote: My point is that that if the main driver for the inclusion is raising the awareness about a certain project and attracting new developers, given that no data support this correlation, then maybe the inclusion itself should be questioned. While I agree

Re: kaudiocreator to unmaintained

2019-05-21 Thread Nate Graham
On 5/21/19 10:48 AM, Kevin Ottens wrote: I'd like it to be part of KDE Applications. Unlike Zanshin I'd rather have this one tied to the Applications release cycle. That being said, it's been eons since I had anything in the regular applications collection. Could someone refresh me on what it

Re: Tipping the apple cart?

2019-07-10 Thread Nate Graham
Am 01.07.19 um 15:37 schrieb James Ramsay: Is it primarily the previous discussions so that you can better respond directly via email? If so, this proposal to include entire discussion thread in email notifications (https://gitlab.com/gitlab-org/gitlab-ce/issues/40557) which Zsolt is

Re: Tipping the apple cart?

2019-07-04 Thread Nate Graham
On 7/2/19 3:53 PM, Valorie Zimmerman wrote: Please lets keep in mind that this is not a thread to complain about Gitlab. No platform is perfect, and we're not yet on production machines. This thread is about how to make our review process great for both newbies and experienced developers,

Re: rekonq to unmaintained

2019-09-13 Thread Nate Graham
On 9/12/19 3:55 PM, Kevin Kofler wrote: Harald Sitter wrote: Its master branch is still kdelibs4, the frameworks branch hasn't seen any progress in 21 months. Hasn't had a release in years. Very unmaintained all in all. And there is also a working, maintained successor (Falkon).

Re: Quick Charts in KDE Review

2019-11-08 Thread Nate Graham
On 11/7/19 7:34 AM, Friedrich W. H. Kossebau wrote: Am Montag, 21. Oktober 2019, 15:22:23 CET schrieb Arjen Hiemstra: Hi, Quick Charts has been moved to KDE review. The intent is to make it a Tier 1 framework. Any chance the official name can be "KQuickCharts"? "Quick Charts" is a generic

Re: KIOFuse in kdereview

2019-11-05 Thread Nate Graham
+1, this is great stuff. Nate On 11/4/19 3:08 PM, Alexander Saoutkin wrote: Hi everyone, KIOFuse (https://invent.kde.org/kde/kio-fuse) has been moved to kdereview. KIOFuse is a project started by Fabian Vogt that allows the possibility to mount KIO filesystems in the local system;

Re: Update on Status of Gitlab Migration

2020-04-14 Thread Nate Graham
On 4/13/20 6:59 PM, Ben Cooksley wrote: Why do we need to mimic them? If you Google "KDE Gitlab" then the first hit is invent.kde.org . To flip it around: why do we need to do something different? I don't think it's about mimicking anyone else, but rather using the

Re: Update on Status of Gitlab Migration

2020-04-14 Thread Nate Graham
On 4/13/20 4:44 AM, Albert Vaca Cintora wrote: Regarding this: is the subdomain going to stay invent.kde.org once we have officially moved? I find it's a bit confusing to use that instead of gitlab.kde.org I agree. gitlab.kde.org would make more sense to me, mirroring phabricator.kde.org.

Re: Information regarding upcoming Gitlab Migration

2020-04-27 Thread Nate Graham
On 4/27/20 7:52 AM, Nate Graham wrote: On 4/27/20 7:46 AM, Ingo Klöcker wrote: On Montag, 27. April 2020 14:10:55 CEST Bhushan Shah wrote: This is something which can be easily solved by Gitlab, Gitlab offers a solution where project can be shared with another group. So e.g. sharing

Re: Information regarding upcoming Gitlab Migration

2020-04-27 Thread Nate Graham
On 4/27/20 4:38 AM, Aleix Pol wrote: Does this mean that to clone it we'll have to go "git clone kde:games/knetwalk" or something along the lines? If that's the case I'd much prefer if we didn't do this, at the moment it's already uncomfortable for me to remember the URL for some of the

Re: Information regarding upcoming Gitlab Migration

2020-04-27 Thread Nate Graham
On 4/27/20 7:46 AM, Ingo Klöcker wrote: On Montag, 27. April 2020 14:10:55 CEST Bhushan Shah wrote: This is something which can be easily solved by Gitlab, Gitlab offers a solution where project can be shared with another group. So e.g. sharing kcontacts with kdepim should be possible, then

Re: Information regarding upcoming Gitlab Migration: clarifications

2020-04-30 Thread Nate Graham
On 4/30/20 11:43 AM, Aleix Pol wrote: IMHO needing tools ad-hoc to KDE development can be a barrier of entrance. I feel like these things make us look distant, it's important that people's skills translate automatically when they want to get started. True, but if you're a new contributor,

Re: Information regarding upcoming Gitlab Migration: clarifications

2020-04-30 Thread Nate Graham
On 4/30/20 5:59 PM, Aleix Pol wrote: El jue., 30 de abr. de 2020 a la(s) 18:15, Albert Astals Cid Am I the only person that just has all the repos on the same folder? I thought it was the common thing to do :? I do too Same here. kdesrc-build's default settings do this, and download all

Re: Information regarding upcoming Gitlab Migration: clarifications

2020-05-01 Thread Nate Graham
On 4/30/20 11:17 PM, Ben Cooksley wrote: Not necessarily. Git allows you to override the name that the local folder is called when cloning, so there is no reason why we can't specify something in the metadata to override the local name that the folder gets called in your local checkout

Re: Information regarding upcoming Gitlab Migration

2020-05-01 Thread Nate Graham
Thanks for the clarifications, Ben. Then I think the original proposal is perfectly reasonable and I fully support it. Nate

Re: Information regarding upcoming Gitlab Migration

2020-04-30 Thread Nate Graham
If I'm understanding things, we have solutions to most or all of the objections raised so far: - Projects will be allowed to live in--or at least appear in--multiple top-level groups (e.g. plasma-framework could appear in both the Frameworks top-level group and also the Plasma top-level

Re: Information regarding upcoming Gitlab Migration

2020-05-01 Thread Nate Graham
On 5/1/20 2:09 PM, Ben Cooksley wrote: Unfortunately sharing of projects/repositories across groups does not impact on tasks and reviews. This means that merge requests for Planet (which is currently shared with "KDE") do not show up in the list of merge requests for "KDE". Sharing repositories

Re: Information regarding upcoming Gitlab Migration: clarifications

2020-05-01 Thread Nate Graham
On 5/1/20 9:02 AM, Johan Ouwerkerk wrote: No, that is not the default. Actually, it is: https://invent.kde.org/kde/kdesrc-build/-/blob/master/kdesrc-build-setup#L389 and download all repos into ~/kde/src without any of the levels of hierarchy. But it is sufficiently common that there

Re: Windows CI Updated to Qt 5.15 - Temporarily KO due to Breeze Icons Breakage

2020-10-06 Thread Nate Graham
We are trying to fix the test failure. See https://invent.kde.org/frameworks/breeze-icons/-/commit/8fce580335ef86f19df2238f00270820ac74c9f4#note_115164 for the current status. Or was the regression caused by something else? Nate On 10/6/20 3:59 AM, Ben Cooksley wrote: Hi all, This

Re: Windows CI Updated to Qt 5.15 - Temporarily KO due to Breeze Icons Breakage

2020-10-06 Thread Nate Graham
Noah, could yo take a look? Seems related to porting the autogenerated 24px icon script to Python. Nate On 10/6/20 11:26 AM, Ben Cooksley wrote: On Wed, Oct 7, 2020 at 4:49 AM Nate Graham <mailto:n...@kde.org>> wrote: We are trying to fix the test failure. See

Re: Git merge workflow: reverse it?

2020-08-14 Thread Nate Graham
FWIW I'm a +1 too. Having done both, I solidly prefer the cherry-pick workflow. It's so much less error-prone, and you don't need to deal with the hassle of switching branch targets and rebasing prior to merging. Nate On 8/14/20 2:31 PM, Johan Ouwerkerk wrote: On Mon, Aug 3, 2020 at 11:50

Re: Announcing MyKDE

2020-10-03 Thread Nate Graham
Super cool stuff! Great work, Carl. Nate On 10/3/20 3:56 AM, Carl Schwan wrote: Hello folks, I'm happy to announce the successful deployment of the new identity system in KDE, codename MyKDE. The new identity system is now available in https://my.kde.org. You should be able to login into the

Re: KDEReview for Kontrast

2020-08-03 Thread Nate Graham
On 8/2/20 8:29 PM, Carl Schwan wrote: Le dimanche, août 2, 2020 2:58 PM, Nate Graham a écrit : Hello Carl, This looks very useful! Overall I'd say the UI is good. One thing I find myself missing while playing around is the ability to test system colorschemes though. That would be a really

Re: KDEReview for Kontrast

2020-08-02 Thread Nate Graham
Hello Carl, This looks very useful! Overall I'd say the UI is good. One thing I find myself missing while playing around is the ability to test system colorschemes though. That would be a really nice addition. Nate On 7/30/20 3:16 AM, Carl Schwan wrote: Hi, I would like to move Kontrast, a

Re: Gitlab Turn-off Issues

2020-06-28 Thread Nate Graham
On 6/28/20 2:29 PM, Nicolás Alvarez wrote: > El dom., 28 de jun. de 2020 a la(s) 16:47, Nate Graham (n...@kde.org) > escribió: >> >> On 6/28/20 12:28 PM, Ben Cooksley wrote: >>> On Mon, Jun 29, 2020 at 4:28 AM Allen Winter wrote: >>>> >>>> Can

Re: Gitlab Turn-off Issues

2020-06-28 Thread Nate Graham
On 6/28/20 12:28 PM, Ben Cooksley wrote: On Mon, Jun 29, 2020 at 4:28 AM Allen Winter wrote: Can we remove the Issues feature on all invent projects? We're starting to see more and more people adding Issues. For KOrganizer, bshah replaced Issues with Bugzilla. I very much doubt we want or

Re: Move Koko to KDEReview

2020-06-10 Thread Nate Graham
+1, I've been using Koko and find it quite pleasant. Nate On 6/9/20 5:30 AM, Carl Schwan wrote: Hi, I would like to move Koko, a convergent image viewer, to KDEReview. Koko is already shipped in the base Plasma mobile image and I was surprised that it was still in playground. The current

Re: Retiring

2021-01-13 Thread Nate Graham
On 1/13/21 1:57 PM, Christoph Feck wrote: Hello developers, my personal situation allows for much less time for KDE related work, at least during the Corona times. I would like to retire as soon as possible from these responsibilities: - bug triaging - release service - KIconTheme

Re: Is there (going to be) an auto-retracer service for KDE?

2021-04-25 Thread Nate Graham
Hello Lyubomir, Automatic symbolication services are great, but they need to be run by distros, because distros are the ones who build their own binaries. The problem with apport is that it reports bugs to Ubuntu, not to us. Some of these bug reports get forwarded to us, but most don't. As a

Re: Kirigami Addons in KDEReview

2021-04-30 Thread Nate Graham
On 4/30/21 7:51 AM, Carl Schwan wrote: Hello folks, I would like to put request a KDE review on the Kirigami Addons project. This repository contains for the moment 2 plugins: * A TreeView for QML: this is maintained by Marco and provides a QML tree view using

Re: Koko in KDEReview

2021-05-03 Thread Nate Graham
On 5/3/21 4:21 PM, Albert Astals Cid wrote: El dimarts, 4 de maig de 2021, a les 0:07:19 (CEST), Carl Schwan va escriure: Le lundi, mai 3, 2021 4:35 PM, Harald Sitter a écrit : On 23.04.21 01:00, Carl Schwan wrote: Would you be open to an MR adding GitLab support to DrKonqi? We don't use

Re: Koko in KDEReview

2021-05-04 Thread Nate Graham
On 5/4/21 1:23 PM, Ben Cooksley wrote: Side note here: It is actually possible to disable issues on Gitlab projects. Given that developers generally need a way to collaborate amongst themselves (as Phabricator tasks are used for) we leave the feature enabled however and generally don't

Re: Koko in KDEReview

2021-05-04 Thread Nate Graham
On 5/4/21 12:57 PM, Alexander Semke wrote: Jira can do all of this, except of the tight integration with GitLab out of the box maybe, and even more. I'm heavily using Jira at work on the daily base and it's a very reliable and feature-rich tool for project management and issue tracking. Many

Re: Koko in KDEReview

2021-05-05 Thread Nate Graham
On 5/5/21 6:41 AM, Harald Sitter wrote: On 04.05.21 17:53, Carl Schwan wrote: Side note: this isn't a special need TBH ;) Pretty much everyone has that need. So much so that I kind of have a general game plan that there ought to be a kbugreport utility which is able to gobble up all the very

Re: Koko in KDEReview

2021-05-03 Thread Nate Graham
On 5/3/21 4:44 PM, Albert Astals Cid wrote: El dimarts, 4 de maig de 2021, a les 0:36:57 (CEST), Carl Schwan va escriure: "The project stays true to established practices" The established practice in KDE is clearly using bugzilla for bugs. Sure, but if we never investigated alternatives and

Re: Koko in KDEReview

2021-05-04 Thread Nate Graham
On 5/4/21 1:16 AM, Harald Sitter wrote: Every time the bugz vs gitlab schism comes up I eventually tune out with the distinct feeling that there is strong opposition to moving. What I, what we all, do not want is to end up with two systems that require us to maintain two client libraries with

Re: Koko in KDEReview

2021-05-04 Thread Nate Graham
On 5/4/21 8:10 AM, Harald Sitter wrote:> Sure, I suppose, I mean, not this conservation, this conversation was about koko and how it needs crash tracking because quite clearly there's opportunity for crashing. The reality right here right now is that drkonqi only sports bugz support and will not

Re: Koko in KDEReview

2021-05-04 Thread Nate Graham
On 5/4/21 7:50 AM, Halla Rempt wrote: On Tuesday, 4 May 2021 15:28:30 CEST Nate Graham wrote: I don't see anyone really trying to argue otherwise. I have certainly made that argument many times. Since only developers can add tags, it will be impossible for ordinary users to provide enough

Re: Koko in KDEReview

2021-05-04 Thread Nate Graham
On 5/4/21 8:54 AM, Halla Rempt wrote: On Tuesday, 4 May 2021 16:26:22 CEST Nate Graham wrote: Again, my point was not that everything about GLI is universally better than everything about BZ. Just that most things are mostly better in most ways that most of us care about. List them? I cannot

Re: Koko in KDEReview

2021-03-13 Thread Nate Graham
On 3/13/21 4:22 PM, Albert Astals Cid wrote: I would really like if we had a kxmlgui equivalent for QtQuick that gave me the "configure shortcuts" and stuff functionality, but that's unrelated to koko :) +100 See also https://phabricator.kde.org/T13770 Nate

Re: KInit - how to contribute patches

2021-09-13 Thread Nate Graham
Hello Sandeep, Thank you for wanting to contribute! See https://community.kde.org/Infrastructure/GitLab to learn how to submit merge requests. Nate On 9/13/21 5:53 AM, Sandeep wrote: Hello, I found some bugs in kinit , for which I'd like to contribute a patch. I tried using

Re: Towards Excellent Defect Management

2021-09-14 Thread Nate Graham
On 9/14/21 11:43, Julian / xyquadrat wrote: Most of Sentry is licensed under the BSL (Business Source License), which prohibits using the software to create your own commercial service providing "Application Monitoring Services" (https://github.com/getsentry/sentry/blob/master/LICENSE). This

Re: State of server-side retrace of KDE crashes?

2021-12-19 Thread Nate Graham
For what it's worth, I don't think server-wise retracing is solely a workaround for distro-specific issues. Even for distros that ship debug symbols, I often find in my bug triaging that it can be a challenge to get users to actually use them. The DrKonqi auto-symbol-downloader sometimes

Re: Reviewing the process for giving people commit rights

2022-04-01 Thread Nate Graham
On 4/1/22 09:36, Nicolas Fella wrote: I think this case shows more a lack of communication towards the person in question what rights and responsibilities come with commit access rather than a problem with the current review process. In other words, other reviewers would likely not have

Re: Reviewing the process for giving people commit rights

2022-04-01 Thread Nate Graham
On 4/1/22 09:52, Ivan Čukić wrote: On Friday, 1 April 2022 17:36:50 CEST Nicolas Fella wrote: To summarize: I don't see a need to change how applications are +1 One of the things I saw as a mark of a welcoming and trusting community when I joined KDE was that everyone had direct push access

Reviewing the process for giving people commit rights

2022-04-01 Thread Nate Graham
Hello folks, When someone is proposed to get commit access, currently a sponsor proposes it, the intended recipient contacts sysadmin, sysadmin reviews, and then asks the sponsor if it's okay. This process essentially only allows for sysadmin review, since the sponsor has already implicitly

Re: KDE Review: Hash-o-Matic

2023-10-02 Thread Nate Graham
On 10/2/23 13:53, Albert Astals Cid wrote: El diumenge, 1 d’octubre de 2023, a les 21:49:36 (CEST), Carl Schwan va Who checked all those marks? There's no way to know. If you scroll down to "Activity", it says who checked them after the issue was opened. I agree that the person who opened

Retroactive kdereview: ocean-sound-theme

2023-10-23 Thread Nate Graham
Hello kde-core-devel folks, We did the KDE Review process for ocean-sound-theme a bit wrong and forgot to email this mailing list before moving it to its final home. So I'm retroactively submitting it for review in case folks see anything wrong that needs to be corrected. See

Re: drkonqi's many debuggers

2023-08-28 Thread Nate Graham
On 8/28/23 22:25, Thiago Macieira wrote: It does because it might be missing in the system far more often than gdb. We'd get more backtraces and therefore more data if we focused on gdb Another point is that Linux distributions have been shipping gdb with debuginfod support for a year or two.

Re: Eloquens now on KDEREVIEW

2022-06-21 Thread Nate Graham
On 6/21/22 13:24, Harald Sitter wrote: some desktop file validation: (the last point is because SingleMainWindow isn't actually a valid key, you should remove it I guess) org.kde.eloquens.desktop: hint: value "Qt;KDE;Development;Utility;" for key "Categories" in group "Desktop Entry" contains

Telemetry in Plasma and Discover

2022-07-11 Thread Nate Graham
Hello all, It's come to my attention that Plasma and Discover implemented support for opt-in-telemetry without complying with the requirements listed at https://community.kde.org/Policies/Telemetry_Policy#Compliance. The Request for review was done solely in a merge request, not also on these

Re: Telemetry in Plasma and Discover

2022-07-12 Thread Nate Graham
/091049.html Aleix On Tue, Jul 12, 2022 at 1:53 AM Nate Graham wrote: Hello all, It's come to my attention that Plasma and Discover implemented support for opt-in-telemetry without complying with the requirements listed at https://community.kde.org/Policies/Telemetry_Policy#Compliance. The Request

Re: Git merge workflow: reverse it?

2022-05-10 Thread Nate Graham
On 5/10/22 04:15, Ingo Klöcker wrote: https://manifesto.kde.org/commitments/ I don't see anything in there that would force the same merge workflow on all KDE projects. In my view the merge workflow is comparable to the coding style. Regards, Ingo I don't think anyone is trying to force

Re: Plasma Welcome Center on KDEReview

2022-10-19 Thread Nate Graham
On 10/19/22 10:03, Albert Astals Cid wrote: El dimecres, 19 d’octubre de 2022, a les 5:22:09 (CEST), Nate Graham va escriure: Ping; if there are no objections I'd consider it approved. I can't still see the toolbar :/ Thanks to Albert's https://invent.kde.org/plasma/plasma-welcome

Re: Plasma Welcome Center on KDEReview

2022-10-24 Thread Nate Graham
OK great, thanks! Good to notify people when doing it. :) Where does that YAML file live? Nate On 10/24/22 11:54, Ben Cooksley wrote: On Tue, Oct 25, 2022 at 4:30 AM Nate Graham <mailto:n...@kde.org>> wrote: Since it seems there are no more objections, I'd like to consider

Re: Plasma Welcome Center on KDEReview

2022-10-24 Thread Nate Graham
Well that's embarrassing. Looks like my email was slow today, and I just now got the message from Jonathan which even lists the commit that changed it! Thanks everyone. Nate On 10/24/22 11:54, Ben Cooksley wrote: On Tue, Oct 25, 2022 at 4:30 AM Nate Graham <mailto:n...@kde.org>&

Re: Plasma Welcome Center on KDEReview

2022-10-24 Thread Nate Graham
Since it seems there are no more objections, I'd like to consider plasma-welcome to have graduated form kdereview. Sysadmins, can we get it moved out of Playground and into Plasma? Nate On 10/21/22 12:19, Nate Graham wrote: Any more concerns or objections? Nate On 10/19/22 11:56, Nate

Re: New repo in kdereview: KRecorder

2022-10-26 Thread Nate Graham
Pretty nice app. The app should have a Bugzilla component and its "Report a bug" button should take users there, as we have been migrating towards for other mobile apps recently. Some UI review now: When I open the app for the first time on the desktop, I get a mobile-specific floating

Re: Plasma Welcome Center on KDEReview

2022-10-25 Thread Nate Graham
I know about that page, but I haven't memorized every detail of it, or been able to always recall it as the location for the exact piece of information I was looking for. If you have, I'm impressed! Nate On 10/25/22 02:01, Ingo Klöcker wrote: On Montag, 24. Oktober 2022 23:16:50 CEST Nate

Re: Plasma Welcome Center on KDEReview

2022-10-21 Thread Nate Graham
Any more concerns or objections? Nate On 10/19/22 11:56, Nate Graham wrote: On 10/19/22 10:03, Albert Astals Cid wrote: El dimecres, 19 d’octubre de 2022, a les 5:22:09 (CEST), Nate Graham va escriure: Ping; if there are no objections I'd consider it approved. I can't still see

Re: Plasma Welcome Center on KDEReview

2022-09-19 Thread Nate Graham
On 9/19/22 01:42, Ingo Klöcker wrote: Please try to keep in mind that there are people who cannot see screenshots. They may not need captions, but they do need a textual description of the screenshot. That's an excellent point, and thanks for the reminder. Captions added. Nate

Plasma Welcome Center on KDEReview

2022-09-16 Thread Nate Graham
Hello folks! I've been working with Aleix on an onboarding wizard for Plasma, based on work originally started by Felipe Kinoshita last year. You can see some screenshots at https://invent.kde.org/websites/product-screenshots/-/commit/e300be66e62263c63d8a85ba391bbcc1de691148. I'd like to

Re: Plasma Welcome Center on KDEReview

2022-09-17 Thread Nate Graham
On 9/17/22 02:16, Albert Astals Cid wrote: Understanding that this is a standalone app and none of its contents are reused to be shown in other apps a KLocalizedString::setApplicationDomain("welcomecenter"); call in its main.cpp will do. Sidenote, given the name of the app is plasma-welcome

Re: Plasma Welcome Center on KDEReview

2022-09-16 Thread Nate Graham
On 9/16/22 15:31, Albert Astals Cid wrote: Those screenshots show me the Wayland icon, please fix. Sure, how do I fix that exactly? I see the app has a Messages.sh but I remain unconvinced that the generated welcomecenter.po generated file is used. Is there something that needs to be

Re: Plasma Welcome Center on KDEReview

2022-09-16 Thread Nate Graham
On 9/16/22 15:46, Nicolas Fella wrote: Am 16.09.22 um 23:40 schrieb Nate Graham: On 9/16/22 15:31, Albert Astals Cid wrote: Those screenshots show me the Wayland icon, please fix. Sure, how do I fix that exactly? Either - Fix the first argument to KAboutData to be the same as the base

Re: KDE Goal Project specific issue: Automate and systematize internal processes

2022-09-16 Thread Nate Graham
[Apologies for the delayed reply; your email was erroneously sorted into my spam folder and I missed it until now.] All of these proposals are just proposals. Nothing mandatory, required, or burdened with rules. Just something that overall, would probably improve thing such that I would hope

Re: Plasma Welcome Center on KDEReview

2022-09-18 Thread Nate Graham
On 9/18/22 11:44, Nicolas Fella wrote: Hi, - I'd suggest to rename the repository to plasma-welcome to be consistent with the internal name and also other Plasma repos Requested with https://phabricator.kde.org/T15840 - The version number in KAboutData says "1.0", this should follow the

Re: Plasma Welcome Center on KDEReview

2022-09-23 Thread Nate Graham
, Sep 16, 2022 at 6:00 PM Nate Graham wrote: Hello folks! I've been working with Aleix on an onboarding wizard for Plasma, based on work originally started by Felipe Kinoshita last year. You can see some screenshots at https://invent.kde.org/websites/product-screenshots/-/commit

Re: Plasma Welcome Center on KDEReview

2022-09-19 Thread Nate Graham
On 9/18/22 11:03, Harald Sitter wrote: Not all code is licensing policy compliant (e.g. appdata is missing spdx tags). I'd suggest enabling the reuse linter pipeline. How do I do this? Is there an example I can copy from elsewhere (which in case people haven't noticed, is basically how I do

Re: Plasma Welcome Center on KDEReview

2022-10-06 Thread Nate Graham
There have been no additional comments or objections for two weeks; can everything brought up in this thread be considered resolved now? Nate On 9/23/22 23:34, Nate Graham wrote: Thanks for your help, everyone. Fixed now with https://invent.kde.org/plasma/plasma-welcome/-/merge_requests/12

Re: New repo in kdereview: KRecorder

2022-12-07 Thread Nate Graham
of Kirigami.Units.GridUnit, which hopefully should be easy to fix. I've changed it to be based on gridUnit. On Mon, Dec 5, 2022 at 4:55 PM Nate Graham wrote: On 12/4/22 16:47, Devin wrote: I can reproduce it in the following way on Desktop: Hmm, I'm on Kirigami from master and still can't reproduce it, see

Re: New repo in kdereview: KRecorder

2022-12-05 Thread Nate Graham
On 12/4/22 16:47, Devin wrote: I can reproduce it in the following way on Desktop: Hmm, I'm on Kirigami from master and still can't reproduce it, see the attached video. I think I found the problem; I use 11pt Noto Sans font. I can't reproduce the issue with the default 10pt. This probably

Re: New repo in kdereview: KRecorder

2022-11-28 Thread Nate Graham
ts header. Added On Mon, Nov 14, 2022 at 7:22 PM Nate Graham wrote: Much better! Most issues are fixed now. I feel like we're close. See a few remaining comments: The left pane's placeholder message is off-center with narrow windows. Fixed. I can still see this: https://i.imgur.c

Re: New repo in kdereview: KWeather

2022-11-29 Thread Nate Graham
This happens on X11 when using QtDialogs for reasons I don't understand. See https://invent.kde.org/frameworks/knewstuff/-/commit/ea19fa6e824650f3257e8047d6f90e01899b2e03. Nate On 11/29/22 16:48, Devin wrote: Hmm, I have no idea why the behaviour is different for you, but I get:

Re: New repo in kdereview: KRecorder

2022-11-14 Thread Nate Graham
Much better! Most issues are fixed now. I feel like we're close. See a few remaining comments: The left pane's placeholder message is off-center with narrow windows. Fixed. I can still see this: https://i.imgur.com/MrrwyAo.jpg On the recording page, the "stop recording" button is red

Re: New repo in kdereview: KWeather

2022-11-14 Thread Nate Graham
Really great app. I have just a few minor UX comments, in order of how strongly I feel about them: The main page has no scrollbars, so it's not obvious that the view is scrollable, especially because with various window sizes, nothing looks visibly cut off on the bottom to suggest

Re: Proposal for using gitlab for kdereview process

2023-02-22 Thread Nate Graham
Overall I think it makes sense. The key players are all already on GitLab and it's where we do code review for established projects. Nate On 2/22/23 00:59, David Redondo wrote: Am Samstag, 18. Februar 2023, 12:02:38 CET schrieben Sie: I'm not convinced more paper work is going to help us

Re: Question about the source code

2023-02-10 Thread Nate Graham
Hello Matthieu, This behavior comes from Qt, not any KDE code. You might try looking at the source code for QMenu. Good luck! Nate On 2/10/23 06:00, rubisetcie wrote: Hello KDE core developer team, I hope you're having a good day. I have a question about the KDE source code : I would

Re: Question about the source code

2023-02-13 Thread Nate Graham
you a good continuation for your amazing work. Regards, Matthieu 'Rubisetcie' Carteron Le ven. 10 févr. 2023 à 21:27, Nate Graham <mailto:n...@kde.org>> a écrit : Hello Matthieu, This behavior comes from Qt, not any KDE code. You might try looking at the source code for QM

Re: New repo in kdereview: kclock

2023-02-03 Thread Nate Graham
I'm happy with KClock now, FWIW. I'm going to start sending merge requests for some of the little tiny UI things I notice that I don't think are worth prolonging KDEReview over. Nate On 2/2/23 21:11, Devin wrote: Hi everyone, Is there any feedback left for KClock? If not, I will consider

Re: sentry evaluation

2023-06-01 Thread Nate Graham
To be honest, I haven't found Sentry to be that useful in its current implementation. The primary issue is that it represents a second source of truth for where crash reports live. As a result, developers who already struggle to notice Bugzilla-based crash reports have to look in a second

Re: KSvg in kdereview

2023-06-21 Thread Nate Graham
FWIW the code itself is almost entirely just moved verbatim from plasma-framework, which is already a framework. Nate On 6/21/23 12:41, Friedrich W. H. Kossebau wrote: Am Mittwoch, 21. Juni 2023, 12:23:55 CEST schrieb Ben Cooksley: On Wed, Jun 21, 2023 at 10:12 PM Harald Sitter wrote:

Re: per-issue notifications from sentry

2023-11-26 Thread Nate Graham
I have personally disabled this functionality for my account already as I found them useless. Nate On 11/26/23 07:38, Harald Sitter wrote: does anyone else find the emails from sentry when a new issue appears to be rather useless? they are very noisy and often times not interesting since a