he fact that 9/10 it is
> more complete than whatever the license headers proclaim to be the
> case.
Although copyright only applies to non-trivial changes, so the actual set of
copyright holders is likely to lie somewhere between the authors list in the
headers and the full list provided from git commits.
--
David Jarvie
KAlarm author, KDE developer
wants to review...
I agree. Mandatory reviews might work if there is a team of active people
working on a project, but if there is only one person with real knowledge of
the code, or there is nobody else with much time to spare, who is going to do
the review? It is likely to just sit waiting indefinitely. If getting code
reviewed is too difficult, the developer may have to give up and abandon the
project.
Mandatory reviewing could only work if individual projects can decide whether
to adopt it or not.
--
David Jarvie
KAlarm author, KDE developer
http://www.astrojar.org.uk/kalarm
marked as submitted.
Review request for kdelibs.
Changes
---
Submitted with commit af320ed5599cb0737c0601e26126c39e64780de0 by David Jarvie
to branch master.
Bugs: 336738
https://bugs.kde.org/show_bug.cgi?id=336738
Repository: kdelibs4support
Description
---
KDateTime::isValid
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127629/#review95193
---
Can I commit this?
- David Jarvie
On April 10, 2016, 6:43
/kdatetimetest.cpp a8e7749
src/kdecore/kdatetime.cpp c530db1
Diff: https://git.reviewboard.kde.org/r/127629/diff/
Testing
---
Test added to kdatetimetest, all tests pass.
Thanks,
David Jarvie
zone therefore defines UTC offsets for summer and winter and the
dates and times in each year when the transitions between winter and
summer time take place. I.e. a time zone is essentially what you refer to
as human time.
--
David Jarvie.
KDE developer.
KAlarm author - http://www.astrojar.org.uk
On Monday 03 Aug 2015 14:29:41 Dāvis Mosāns wrote:
2015-08-03 15:26 GMT+03:00 David Jarvie djar...@kde.org:
On Monday 03 Aug 2015 12:59:59 you wrote:
2015-08-02 21:32 GMT+03:00 David Jarvie djar...@kde.org:
Date-only KDateTime instances are not only used for Event start/end
On Monday 03 Aug 2015 18:22:28 you wrote:
2015-08-03 17:33 GMT+03:00 David Jarvie djar...@kde.org:
On Monday 03 Aug 2015 14:29:41 Dāvis Mosāns wrote:
2015-08-03 15:26 GMT+03:00 David Jarvie djar...@kde.org:
On Monday 03 Aug 2015 12:59:59 you wrote:
2015-08-02 21:32 GMT+03:00
On Monday 03 Aug 2015 19:49:52 Thomas Lübking wrote:
On Sonntag, 2. August 2015 20:32:43 CEST, David Jarvie wrote:
Having a date-only attribute in KDateTime is very useful
because it allows both date-time and date-only values to be
encapsulated in a single class. This avoids having
On Monday 03 Aug 2015 12:59:59 you wrote:
2015-08-02 21:32 GMT+03:00 David Jarvie djar...@kde.org:
Date-only KDateTime instances are not only used for Event start/end
timestamps. In KAlarm they are also used among other things for alarm snooze
times (independently of whether the event
.
--
David Jarvie.
KDE developer.
KAlarm author -- http://www.astrojar.org.uk/kalarm
.
--
David Jarvie.
KDE developer.
KAlarm author - http://www.astrojar.org.uk/kalarm
a date-time value falls within that
date-only value. For example, 2015-02-27T00:30 in an Australian time zone
is during 2015-02-26 for a European time zone; it is earlier than
2015-02-27 in a European time zone.
--
David Jarvie.
KDE developer.
KAlarm author - http://www.astrojar.org.uk/kalarm
contributors.
--
David Jarvie.
KDE developer.
KAlarm author - http://www.astrojar.org.uk/kalarm
numbers, so it's impossible to know
what code some of the issues refer to. I seem to remember that the web
interface doesn't have that problem.
--
David Jarvie.
KDE developer.
KAlarm author - http://www.astrojar.org.uk/kalarm
fail too, although it seems a relatively unimportant issue.
Cheers,
David.
--
David Jarvie.
KDE developer.
KAlarm author - http://www.astrojar.org.uk/kalarm
as in the apidox.
Diffs
-
kio/kio/kdbusservicestarter.cpp 90624fb
Diff: https://git.reviewboard.kde.org/r/116951/diff/
Testing
---
Tested this scenario, and it now returns the error string.
Thanks,
David Jarvie
,
David Jarvie
as in the apidox.
Diffs (updated)
-
kio/kio/kdbusservicestarter.cpp 90624fb
Diff: https://git.reviewboard.kde.org/r/116951/diff/
Testing
---
Tested this scenario, and it now returns the error string.
Thanks,
David Jarvie
and the
country
name and get a correct QDateTime; heck, for most countries, the
abbreviation
could be ignored entirely, it only matters for huge countries such as the
USA or Russia)?
They can't just be ignored for small countries, since they may contain a
daylight savings time indication.
--
David Jarvie
://git.reviewboard.kde.org/r/116951/diff/
Testing
---
Tested this scenario, and it now returns the error string.
Thanks,
David Jarvie
/kdbusservicestarter.cpp 90624fb
Diff: https://git.reviewboard.kde.org/r/116951/diff/
Testing
---
Tested this scenario, and it now returns the error string.
Thanks,
David Jarvie
.
Diffs (updated)
-
kio/kio/kdbusservicestarter.cpp 90624fb
Diff: https://git.reviewboard.kde.org/r/116951/diff/
Testing
---
Tested this scenario, and it now returns the error string.
Thanks,
David Jarvie
On March 13, 2014, 5:30 p.m., David Jarvie wrote:
The handling of return values from KDateTime::toTime_t() in the existing
kio_http code is not correct, because the return value's type is implicitly
cast to other types before being checked. For example, in one place it is
cast
/116784/#comment37258
Need to convert to UTC first, since it will produce the wrong value if it's
in some random time zone:
dt.toUtc().dateTime()
- David Jarvie
On March 13, 2014, 12:49 p.m., Dawit Alemayehu wrote
be fixed instead of changing
code elsewhere, since kio_http is unlikely to be the only module that will have
trouble if that is happening.
- David Jarvie
On March 13, 2014, 12:49 p.m., Dawit Alemayehu wrote:
---
This is an automatically
On Monday 15 Jul 2013 09:46:49 Aaron J. Seigo wrote:
On Friday, July 12, 2013 17:48:50 David Jarvie wrote:
best of intentions) for old habits to take over and to accidentally use
master again. This happened to me more than once.
So how can we make that clearer for people and hard
it because of being very busy) and continued to build the old stuff
for months without problems.
I agree. I'm sure that this must have caught out innocent people more
often than willful miscreants.
--
David Jarvie.
KDE developer.
KAlarm author - http://www.astrojar.org.uk/kalarm
who don't use kdesrc-build, knowing which branch to use does
matter. kdesrc-buildrc and blogging are fine, but there needs to be an
simple way later on to know which branch to use, without having to search
through config files which you don't have a copy of, or past blogs.
--
David Jarvie.
KDE
, I think it might be worth adding the following comment
where the patch sets mLocalIdFile:
If under BSD it is possible for /etc/localtime to be missing but created later,
we should also watch for its creation.
- David Jarvie
On Feb. 3, 2013, 4:30 a.m., Kevin Kofler wrote
are kept.
I must say that the split between community.kde.org and techbase.kde.org
isn't very satisfactory because the boundaries are blurred, and it's easy
to miss information if it's in the other one from what you expect it to be
in.
--
David Jarvie.
KDE developer.
KAlarm author - http
the original local time zone
if (originalZone.isEmpty())
The patches look good to commit. However, can you please move the new tests in
kdatetimetest.cpp to start at line 3740, before the existing group of tests for
UTC offsets. This will keep related tests grouped together.
--
David Jarvie.
KDE
compatibility to
applications.
--
David Jarvie.
KDE developer.
KAlarm author - http://www.astrojar.org.uk/kalarm
will not ship 4.10 in any form, and from my experience, people
who use debian on the desktop, and care about having latest kde packages, use
testing or sid. (myself included)
Not in all cases - I use Debian stable (although I'll probably update to
testing quite soon).
--
David Jarvie.
KDE
and investigate. So
from an application developer's point of view, the fewer variants the
better. I'd rather see a rule that we keep to a uniform release schedule,
but perhaps allow individual ad-hoc exceptions if there is a really good
reason.
--
David Jarvie.
KDE developer.
KAlarm author - http
, especially when it just refers to a block
of text.
- David Jarvie
On May 13, 2012, 10:08 p.m., Aurélien Gâteau wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104934
in fact they are optional?
--
David Jarvie.
KDE developer.
KAlarm author - http://www.astrojar.org.uk/kalarm
On Tue, May 8, 2012 1:07 pm, Allen Winter wrote:
On Tuesday 08 May 2012 6:55:01 AM David Jarvie wrote:
On Mon, May 7, 2012 4:36 pm, Allen Winter wrote:
Howdy,
I started putting the list of package dependences (arranged by module)
onto Techbase.
http://techbase.kde.org/Getting_Started
On Thu, March 22, 2012 5:47 pm, Chusslove Illich wrote:
[: David Jarvie :]
I understand from your email that you are only proposing to remove KUIT
semantic tags, not KUIT context markers. Can you confirm this?
I confirm. They are used much more than tags, and have no problems on
their own
text. This means that current KUIT
users who would like to continue to use it, would have to do some manual
checking and modification in existing code.)
I understand from your email that you are only proposing to remove KUIT
semantic tags, not KUIT context markers. Can you confirm this?
--
David
but the theme needs polishing
imo. I also renders the footer strange using Chrome,
but I hope someone is still working on this... :D
Yes, the header fields waste a _lot_ of space. The old theme was far
better in that respect.
--
David Jarvie.
KDE developer.
KAlarm author - http://www.astrojar.org.uk
the user-intelligible
feedback which Niko is proposing. In this case, of course, there would
need to be a link between any crashes.kde.org and bugs.kde.org.
--
David Jarvie.
KDE developer.
KAlarm author - http://www.astrojar.org.uk/kalarm
discussed at the KDEPIM meeting.
Diffs
-
kdeui/widgets/kdatecombobox.cpp 74b54f2
Diff: http://git.reviewboard.kde.org/r/104198/diff/
Testing
---
Tested using KAlarm for minimum date of today or later.
Thanks,
David Jarvie
/notifications/kstatusnotifieritem.cpp aecb81c
Diff: http://git.reviewboard.kde.org/r/103425/diff/diff
Testing
---
Tested switching setIconByPixmap()/setIconByName() in KAlarm.
Thanks,
David Jarvie
this patch on 30th
November to meet the 4.7.4 deadline.
- David Jarvie
On Nov. 14, 2011, 10:58 p.m., David Jarvie wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103133
/#review8351
---
On Nov. 10, 2011, 12:36 a.m., David Jarvie wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103103
fc239bc
Diff: http://git.reviewboard.kde.org/r/103133/diff/diff
Testing
---
Tested successfully in KAlarm's alarm edit dialog.
Thanks,
David Jarvie
in KAlarm.
Thanks,
David Jarvie
.
Let's just say I disagree.
This change was for 4.7, but it was reverted and added to 4.8, giving you
well
over ONE YEAR to adapt.
Only for those who knew about it a year ago. Many people will probably only
find out when things don't work with 4.8.
--
David Jarvie.
KDE developer.
KAlarm
have running, and select
presentation mode, not restart the browser in another activity to view the
video. Or perhaps I have misunderstood your proposal?
--
David Jarvie.
KDE developer.
KAlarm author -- http://www.astrojar.org.uk/kalarm
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102246/
---
(Updated Aug. 9, 2011, 8:39 a.m.)
Review request for kdelibs.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102246/
---
Review request for kdelibs.
Summary
---
According to the apidocs,
?)
--
David Jarvie.
KDE developer.
KAlarm author - http://www.astrojar.org.uk/kalarm
On Mon, July 25, 2011 8:08 pm, Nicolas Alvarez wrote:
David Jarvie wrote:
On Mon, July 25, 2011 12:50 pm, Ambroz Bizjak wrote:
Hi Mark,
have you seen my proposed improvement on your suggestion?
http://lists.kde.org/?l=kde-core-develm=131149560119520w=2
I suggest that you consider
that it won't matter which system
settings application they use. Applications with more specialist needs,
i.e. settings which aren't (yet) interoperable, would need to provide
configuration of those settings from within the application.
--
David Jarvie.
KDE developer.
KAlarm author - http
=131159889604990w=2.
--
David Jarvie.
KDE developer.
KAlarm author - http://www.astrojar.org.uk/kalarm
possible to commit bug fixes to
stable first and then merge to master. Only master can be committed to, so
presumably we'll have to continue to commit to master and cherry-pick later
once the freeze ends. Either that or change the policy on freezes.
--
David Jarvie.
KDE developer.
KAlarm author
On Mon, July 18, 2011 8:48 pm, Alexander Neundorf wrote:
On Monday 18 July 2011, David Jarvie wrote:
On Wednesday 13 July 2011 20:16:58 Alexander Neundorf wrote:
...
What do you think of this ?
More wishes ?
Should it do it in a different way ?
Something else which would be useful would
the cmake module to work out the files it's looking for,
in order to then be able to do a package search for my distro to find which
package to install.
--
David Jarvie.
KDE developer.
KAlarm author -- http://www.astrojar.org.uk/kalarm
of days. Even if the Qt class doesn't do
this itself, it needs to make the appropriate methods virtual to allow us to
override them.
--
David Jarvie.
KDE developer.
KAlarm author -- http://www.astrojar.org.uk/kalarm
signature.asc
Description: This is a digitally signed message part.
On Wednesday 06 July 2011 19:52:50 Thiago Macieira wrote:
Em Wednesday, 6 de July de 2011, às 18:54:37, David Jarvie escreveu:
On Wednesday 06 July 2011 18:26:16 Sean Harmer wrote:
Hi,
On 29/06/2011 20:54, John Layt wrote:
Duration: A number of Qt community members have a merge
) I was paid for it. I would be willing
to review other people's code, though.
Cheers,
--
David Jarvie.
KDE developer.
KAlarm author -- http://www.astrojar.org.uk/kalarm
signature.asc
Description: This is a digitally signed message part.
instead in order to
qualify for Tier 1, and an additional Tier 2 class could provide the message
texts which relate to the error codes.
--
David Jarvie.
KDE developer.
KAlarm author -- http://www.astrojar.org.uk/kalarm
signature.asc
Description: This is a digitally signed message part.
that they will be widely used by developers. In one way,
that's a good thing, since there should be less bugs encountered by those
not directly involved. But the overall effect could be to slow down bug
fixing of new features.
--
David Jarvie.
KDE developer.
KAlarm author - http://www.astrojar.org.uk/kalarm
integration branches.
--
David Jarvie.
KDE developer.
KAlarm author - http://www.astrojar.org.uk/kalarm
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101314/
---
Review request for kdelibs and Dario Freddi.
Summary
---
the previous version of kdepimlibs?
--
David Jarvie.
KDE developer.
KAlarm author - http://www.astrojar.org.uk/kalarm
to public libraries must be approved by
kde-core-devel. Shouldn't kdepimlibs changes be approved on the kde-pim list
instead?
--
David Jarvie.
KDE developer.
KAlarm author -- http://www.astrojar.org.uk/kalarm
signature.asc
Description: This is a digitally signed message part.
developers have to check all the time which classes are
safe to use and which aren't - and currently, that isn't even documented
clearly. That puts up a big barrier to others using our library.
--
David Jarvie.
KDE developer.
KAlarm author - http://www.astrojar.org.uk/kalarm
/QtMerge , feel free to add stuff there.
David Jarvie, could you add something to the KDateTime entry?
Done. I hope it contains enough explanation - if you think it needs more,
please say so.
--
David Jarvie.
KDE developer.
KAlarm author - http://www.astrojar.org.uk/kalarm
hooks run on EVERY commit anyway? what's wrong with the example
wrong commit, which did change one source line (not just metadata)?
--
David Jarvie.
KDE developer.
KAlarm author - http://www.astrojar.org.uk/kalarm
' once you are ready to push to
the remote. That way, your local master always mirrors the remote, and you
can choose exactly when and which commits to push.
--
David Jarvie.
KDE developer.
KAlarm author - http://www.astrojar.org.uk/kalarm
the changes won't be applicable there.
--
David Jarvie.
KDE developer.
KAlarm author - http://www.astrojar.org.uk/kalarm
On Tue, December 14, 2010 2:52 pm, Ingo Klöcker wrote:
On Tuesday 14 December 2010, David Jarvie wrote:
On Monday 13 December 2010 20:32:30 Albert Astals Cid wrote:
5. There is no space to show the shortcut (i.e. Ctrl+C for Copy)
IMO, this is a very important drawback. There would
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6014/#review9054
---
The code is based on an old version of KDateEdit - the feature in
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5775/#review8523
---
/trunk/KDE/kdelibs/kdecore/date/ktimezone.cpp
76 matches
Mail list logo
