https://git.reviewboard.kde.org/media/uploaded/files/2014/11/10/797589bb-56fd-4ee0-a45a-4a9694db1e88__test_qsslcertificate_import.cpp
Thanks,
Dawit Alemayehu
-4a9694db1e88__test_qsslcertificate_import.cpp
Thanks,
Dawit Alemayehu
://git.reviewboard.kde.org/r/120975/diff/
Testing
---
File Attachments
Accept dialog with cancel button
https://git.reviewboard.kde.org/media/uploaded/files/2014/11/04/bb4e2153-f6b3-4ca9-9645-1783578143a3__ssl_cert_accept_dialog.png
Thanks,
Dawit Alemayehu
with cancel button
https://git.reviewboard.kde.org/media/uploaded/files/2014/11/04/bb4e2153-f6b3-4ca9-9645-1783578143a3__ssl_cert_accept_dialog.png
Thanks,
Dawit Alemayehu
that was first defined under SSL/TLS protocol SSLv3.
2014-10-21 10:35 GMT-04:00 Thomas Lübking thomas.luebk...@gmail.com:
On Montag, 20. Oktober 2014 01:13:35 CEST, Thiago Macieira wrote:
On Sunday 19 October 2014 18:14:36 Thomas Lübking wrote:
On Sonntag, 19. Oktober 2014 16:35:35 CEST, Dawit
Both the protocol and protocolString methods in QSslCipher return a
different value than what is expected. For example, in Qt 4.8 if you set
the protocol in QSslSocket to QSsl::TlsV1 and connect to blog.mozilla.org
port 443, you get the following output from QSslCipher:
QSslSocket Information:
I personally think QUrl should remove the password by default when
converting to string and force caller of the API to explicitly request the
inclusion of the password say by changing the modifier option to a
QUrl::IncludePassword. It is better to be safer out of the box.
On Thu, Oct 16, 2014 at
,
Dawit Alemayehu
server.
Thanks,
Dawit Alemayehu
/r/120418/diff/
Testing
---
Copy file from local directory to a webdav server.
Thanks,
Dawit Alemayehu
apache to refuse any further requests.
Diffs
-
kioslave/http/http.cpp 7e2bca7
Diff: https://git.reviewboard.kde.org/r/120439/diff/
Testing
---
Tested on own local apache + mod_dav server.
Thanks,
Dawit Alemayehu
.
Thanks,
Dawit Alemayehu
kioslave/http/http.cpp 7e2bca7
kioslave/http/webdav.protocol c0fbd11
Diff: https://git.reviewboard.kde.org/r/120418/diff/
Testing
---
Copy file from local directory to a webdav server.
Thanks,
Dawit Alemayehu
1068eb0e7780dd02f3af284e5d1ba932c06f4e1f
Diff: https://git.reviewboard.kde.org/r/120178/diff/
Testing
---
Thanks,
Dawit Alemayehu
On Sept. 19, 2014, 7:03 p.m., Andrea Iacovitti wrote:
I don't know this code but David's proposed patch differs from the one
committed
if (m_asMethod || !fileInfo.exists()) {
vs
if (m_asMethod !fileInfo.exists()) {
It is a typo on my part. I will fix it.
- Dawit
On Sept. 16, 2014, 3:39 p.m., David Faure wrote:
better idea, testing for KDiskFreeSpaceInfo's success.
http://www.davidfaure.fr/2014/copyjob.cpp.diff
That works as well.
- Dawit
---
This is an automatically generated e-mail
)
-
kio/kio/copyjob.cpp 713255b
Diff: https://git.reviewboard.kde.org/r/120182/diff/
Testing
---
Mounted Andriod filesystem through sshfs and attempted to copy files through
sftp.
Thanks,
Dawit Alemayehu
or not the
stat'ing the directory succeeded. I will remove that call.
- Dawit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120182/#review66775
)
-
kio/kio/copyjob.cpp 713255b
Diff: https://git.reviewboard.kde.org/r/120182/diff/
Testing
---
Mounted Andriod filesystem through sshfs and attempted to copy files through
sftp.
Thanks,
Dawit Alemayehu
/show_bug.cgi?id=337198
Repository: kdelibs
Description
---
The attached patch sets the HTTP responsecode metadata on error.
Diffs
-
kioslave/http/http.cpp 1068eb0e7780dd02f3af284e5d1ba932c06f4e1f
Diff: https://git.reviewboard.kde.org/r/120178/diff/
Testing
---
Thanks,
Dawit
/120182/diff/
Testing
---
Mounted Andriod filesystem through sshfs and attempted to copy files through
sftp.
Thanks,
Dawit Alemayehu
command if it is ever reused again.
Diffs
-
kio/kio/connection.cpp 99aea0b
Diff: https://git.reviewboard.kde.org/r/119211/diff/
Testing
---
Run the steps given in the bug report before and after the fix.
Thanks,
Dawit Alemayehu
,
Dawit Alemayehu
Diff: https://git.reviewboard.kde.org/r/119211/diff/
Testing
---
Run the steps given in the bug report before and after the fix.
Thanks,
Dawit Alemayehu
to this patch.
Anyways, this is the reason why I did what I did. I knew it would probably be
safe to send the reparse configuration request when the ioslave is resumed, but
I was not sure that was the case for all other commands.
- Dawit
I cannot compile and test the
fix myself yet.
Diffs
-
src/klauncher/klauncher.cpp 31498e0
Diff: https://git.reviewboard.kde.org/r/119021/diff/
Testing
---
Thanks,
Dawit Alemayehu
the
fix myself yet.
Diffs
-
src/klauncher/klauncher.cpp 31498e0
Diff: https://git.reviewboard.kde.org/r/119021/diff/
Testing
---
Thanks,
Dawit Alemayehu
cannot compile and test the
fix myself yet.
Diffs (updated)
-
src/widgets/krun.cpp 77708a0
Diff: https://git.reviewboard.kde.org/r/119020/diff/
Testing
---
Thanks,
Dawit Alemayehu
this because I cannot compile and test the
fix myself yet.
Diffs (updated)
-
src/klauncher/klauncher.cpp 31498e0
Diff: https://git.reviewboard.kde.org/r/119021/diff/
Testing
---
Thanks,
Dawit Alemayehu
---
Tested with the example provided in the bug report. Verified the output of the
compile process is in the current working directory instead of $HOME.
Thanks,
Dawit Alemayehu
/
Testing
---
Thanks,
Dawit Alemayehu
: https://git.reviewboard.kde.org/r/119020/diff/
Testing
---
Thanks,
Dawit Alemayehu
be:
if !service.path.isEmpty
use that
else if !urls.isEmpty
use first url
D'oh. That was dumb. Fixed.
- Dawit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r
/
Testing
---
Tested with the example provided in the bug report. Verified the output of the
compile process is in the current working directory instead of $HOME.
Thanks,
Dawit Alemayehu
---
Tested with the example provided in the bug report. Verified the output of the
compile process is in the current working directory instead of $HOME.
Thanks,
Dawit Alemayehu
directory instead of $HOME.
Thanks,
Dawit Alemayehu
compile KDE on
rolling release based distros like ArchLinux without this patch.
- Dawit Alemayehu
On June 18, 2014, 11:40 a.m., Milian Wolff wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
combobox.
Diffs (updated)
-
konqueror/src/konqmainwindow.h 4ad4c4f
konqueror/src/konqmainwindow.cpp da8c82e
Diff: https://git.reviewboard.kde.org/r/118749/diff/
Testing
---
Thanks,
Dawit Alemayehu
in Konqueror's URL combobox.
Diffs
-
konqueror/src/konqmainwindow.h 4ad4c4f
konqueror/src/konqmainwindow.cpp da8c82e
Diff: https://git.reviewboard.kde.org/r/118749/diff/
Testing
---
Thanks,
Dawit Alemayehu
/konqmainwindow.cpp da8c82e
Diff: https://git.reviewboard.kde.org/r/118749/diff/
Testing
---
Thanks,
Dawit Alemayehu
should be reverted because it caused a
regression.
- Dawit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117044/#review58143
suggested?
- Dawit Alemayehu
On March 4, 2014, 9:43 p.m., Andrea Iacovitti wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116602
about the other suggestion I
made.
- Dawit Alemayehu
On March 4, 2014, 9:43 p.m., Andrea Iacovitti wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116602
variables to 64 bits so they can
accomodates dates beyond Feb 7, 2106.
Diffs
-
kioslave/http/http.h dd85622
kioslave/http/http.cpp e4f1eba
Diff: https://git.reviewboard.kde.org/r/116784/diff/
Testing
---
Thanks,
Dawit Alemayehu
ftp server listed in the bug report.
Diffs
-
kioslave/ftp/ftp.h cbcd096
kioslave/ftp/ftp.cpp b9d90e6
Diff: https://git.reviewboard.kde.org/r/116783/diff/
Testing
---
Rerun all the tests run for 116524.
Thanks,
Dawit Alemayehu
/http.h dd85622
kioslave/http/http.cpp e4f1eba
Diff: https://git.reviewboard.kde.org/r/116784/diff/
Testing
---
Thanks,
Dawit Alemayehu
existing method names for
consistency)
Ok. I will rename it ftpSendSizeCmd for consistency and adjust the spaces to 2
for this branches and correct it properly for the frameworks branch.
- Dawit
---
This is an automatically generated e-mail
for 116524.
Thanks,
Dawit Alemayehu
for 116524.
Thanks,
Dawit Alemayehu
it correctly by hand :-)
I will use the tool you mentioned for frameworks, but for this one I have tried
to fix all the glaring ones you mentioned
- Dawit
---
This is an automatically generated e-mail. To reply, visit:
https
() function
can not and does not return a literal -1, which is exactly what the code in
kio_http assumes! Of course that is clearly wrong. Anyhow, this patch is
specifically intended to fix that issue and nothing else.
- Dawit
the tests run for 116524.
Thanks,
Dawit Alemayehu
On March 4, 2014, 7:42 p.m., David Faure wrote:
I don't get it. What's the problem with sending a mimetype for empty files?
I would think this is actually expected - for all files, including empty
ones. Why does this fix the bug?
Dawit Alemayehu wrote:
It fails and ends up
,
Dawit Alemayehu
on an Android device and run tests.
Thanks,
Dawit Alemayehu
,
Dawit Alemayehu
to a remote destination, e.g.
sftp server.
Thanks,
Dawit Alemayehu
message
that states the file could not be opened.
Diffs (updated)
-
kioslave/ftp/ftp.cpp ddc6eaf
Diff: https://git.reviewboard.kde.org/r/116523/diff/
Testing
---
Attempt to copy an empty file from any ftp server to a remote destination, e.g.
sftp server.
Thanks,
Dawit Alemayehu
happen. The FTP
server does not respond correctly to the SIZE command and the size of the file
we are trying to retrieve is actually 0, but I am sure that is a rare server
like the one reported in the very old bug report #168011.
- Dawit
,
Dawit Alemayehu
on an Android device and run tests.
Thanks,
Dawit Alemayehu
it might work better on android (if it doesn't support
absolute paths, maybe it doesn't support ../../foo/bar.txt either?).
Dawit Alemayehu wrote:
I have not been able to test whether it supported ../../foo/bar.txt yet.
However, making the code relative to m_currentPath seems to work just
On March 4, 2014, 7:42 p.m., David Faure wrote:
I don't get it. What's the problem with sending a mimetype for empty files?
I would think this is actually expected - for all files, including empty
ones. Why does this fix the bug?
Dawit Alemayehu wrote:
It fails and ends up
slash added, redirection is correctly followed.
From my part it is a ship for this one (Diff r3).
Sorry I posted the wrong patch!! Will post the correct one. It is the same as
Diff r3 except it adds a trailing slash to the directory URL before sending it
to the http ioslave.
- Dawit
/http/http.cpp b4d64d4
Diff: https://git.reviewboard.kde.org/r/116122/diff/
Testing
---
For HTTP delete:
http://greenbytes.de/tech/tc/httpredirects/t301methods.html
For WebDAV delete:
http://boonfaya.com/sites/webdavapps.com/#targets
Thanks,
Dawit Alemayehu
/http.cpp b4d64d4
Diff: https://git.reviewboard.kde.org/r/116122/diff/
Testing
---
For HTTP delete:
http://greenbytes.de/tech/tc/httpredirects/t301methods.html
For WebDAV delete:
http://boonfaya.com/sites/webdavapps.com/#targets
Thanks,
Dawit Alemayehu
On March 6, 2014, 9:10 p.m., Andrea Iacovitti wrote:
I tested your patch, no trailing slash is added whether the request refers
to a collection or resource (as it was before commit 58294ac).
Dawit Alemayehu wrote:
Right, but now the webdav server should redirect to the right
File Attachments
POST redirection confirm dialog
https://git.reviewboard.kde.org/media/uploaded/files/2014/03/07/e77dd03e-cb37-49bb-8554-cca991c8c546__post_redirection_confirmation.png
Thanks,
Dawit Alemayehu
to call ftpFolder and hence sending a cwd request.
- Dawit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116524/#review52013
.
- Dawit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116523/#review51922
---
On March 2, 2014, 2:20 p.m., Dawit Alemayehu wrote
://boonfaya.com/sites/webdavapps.com/#targets
Thanks,
Dawit Alemayehu
a webdav folder before this patch and
I can afterwards. Are you sure you killed all existing kio_http processes
before you run tests with the patched version?
- Dawit
---
This is an automatically generated e-mail. To reply, visit:
https
On March 4, 2014, 2:51 p.m., Andrea Iacovitti wrote:
Still broken for webdav protocol (tested using konq/dolphin), can't delete
file.
isFile is always false whether you try to delete a file or folder so a
trailing slash is always added.
Dawit Alemayehu wrote:
Well it works
/http/http.cpp 9eba5d1
Diff: https://git.reviewboard.kde.org/r/116122/diff/
Testing (updated)
---
For HTTP delete:
http://greenbytes.de/tech/tc/httpredirects/t301methods.html
For WebDAV delete:
http://boonfaya.com/sites/webdavapps.com/#targets
Thanks,
Dawit Alemayehu
, e.g.
sftp server.
Thanks,
Dawit Alemayehu
On March 2, 2014, 12:14 a.m., Dawit Alemayehu wrote:
I am curious if stripping the leading / and sending a relative path with
the SIZE command would work for every FTP server?
David Faure wrote:
It's worth a try. I took at look at the very old svn history, and it has
just always
://git.reviewboard.kde.org/r/116524/diff/
Testing
---
Installed Ftp server from bug report on an Android device and run tests.
Thanks,
Dawit Alemayehu
a relative path with the
SIZE command would work for every FTP server?
- Dawit Alemayehu
On March 2, 2014, 12:12 a.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r
/httpredirects/t308methods.html
http://www.w3.org/People/Bos/Test/redirect307.html
Thanks,
Dawit Alemayehu
. It ensures that the fix is only
applicable to webdav and the addition of the trailing slash is communicated to
the client application.
Diffs
-
Diff: https://git.reviewboard.kde.org/r/116122/diff/
Testing
---
Thanks,
Dawit Alemayehu
://www.w3.org/People/Bos/Test/redirect307.html
Thanks,
Dawit Alemayehu
/t308methods.html
http://www.w3.org/People/Bos/Test/redirect307.html
Thanks,
Dawit Alemayehu
/t307methods.html
http://greenbytes.de/tech/tc/httpredirects/t308methods.html
Thanks,
Dawit Alemayehu
POST redirection
behavior to do POST by default and that override that through the use of the
new redirect-to-get meta-data.
- Dawit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116017
kio/kio/job.h aeaffa2
kio/kio/job.cpp edc5fed
Diff: https://git.reviewboard.kde.org/r/116017/diff/
Testing
---
http://greenbytes.de/tech/tc/httpredirects/t307methods.html
http://greenbytes.de/tech/tc/httpredirects/t308methods.html
Thanks,
Dawit Alemayehu
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116048/#review50896
---
Ship it!
Ship It!
- Dawit Alemayehu
On Feb. 25, 2014, 4
in the bug report to create a symlink to a file whose
path or name contains characters that are not allowed in a URL.
Thanks,
Dawit Alemayehu
code).
I just committed a unittest extension to kurltest.cpp in KDE/4.12 which
proves all this :)
Great! Always fan of unit testing to prove stuff out. I will change the patch
to use QUrl(kurl).toString() then.
- Dawit
://git.reviewboard.kde.org/r/116073/diff/
Testing
---
Follow the steps outlined in the bug report to create a symlink to a file whose
path or name contains characters that are not allowed in a URL.
Thanks,
Dawit Alemayehu
---
http://greenbytes.de/tech/tc/httpredirects/t307methods.html
http://greenbytes.de/tech/tc/httpredirects/t308methods.html
Thanks,
Dawit Alemayehu
as they do make XHR requests with no body
data.
Fixed. It would actually help if the QBuffer was opened before attempting to
read from it. :(
- Dawit
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115864/#review50296
---
Ship it!
- Dawit Alemayehu
On Feb. 19, 2014, 9:50 p.m
/115864/#comment35291
I think 301 can simply do the setMetaData call and pass on through 302
instead of duplicating the same exact code.
- Dawit Alemayehu
On Feb. 18, 2014, 9:36 a.m., Andrea Iacovitti wrote
?
- Dawit Alemayehu
On Feb. 18, 2014, 9:36 a.m., Andrea Iacovitti wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115864
---
Tested HEAD redirection with http://greenbytes.de/tech/tc/httpredirects/
Thanks,
Dawit Alemayehu
. DELETE?
Anyhow, I do not want to cause regression ; so I will roll back this patch to
the way things were. However, those POST-POST redirection tests it seems to
pass are wrong because it never sends the entity-body to the redirected
resource.
- Dawit
---
Tested HEAD redirection with http://greenbytes.de/tech/tc/httpredirects/
Thanks,
Dawit Alemayehu
/tech/tc/httpredirects/
Thanks,
Dawit Alemayehu
1351119
kio/kio/accessmanager.cpp 7a806e8
kio/kio/job.cpp 13107c2
kioslave/http/http.cpp b13eed1
Diff: https://git.reviewboard.kde.org/r/115689/diff/
Testing
---
Tested HEAD redirection with http://greenbytes.de/tech/tc/httpredirects/
Thanks,
Dawit Alemayehu
/http.cpp b13eed1
Diff: https://git.reviewboard.kde.org/r/115651/diff/
Testing
---
Run tests at
http://greenbytes.de/tech/tc/httpredirects/t301methods.html
http://greenbytes.de/tech/tc/httpredirects/t302methods.html
http://greenbytes.de/tech/tc/httpredirects/t303methods.html
Thanks,
Dawit
1 - 100 of 686 matches
Mail list logo
