Re: c++11 and workspace

2017-08-17 Thread Hugo Pereira Da Costa
On 08/17/2017 10:09 PM, Thiago Macieira wrote: On Thursday, 17 August 2017 08:52:21 PDT Martin Flöser wrote: Am 2017-08-17 16:48, schrieb Hugo Pereira Da Costa: Hi, Quick question on the status of c++11 features that I can include in breeze. Are std::function allowed ? In workspace you can

c++11 and workspace

2017-08-17 Thread Hugo Pereira Da Costa
Hi, Quick question on the status of c++11 features that I can include in breeze. Are std::function allowed ? Thanks in advance, Hugo

Re: Review Request 127866: Oxygen: Fix QCache usage

2017-02-25 Thread Hugo Pereira Da Costa
> On May 30, 2016, 11:34 a.m., Hugo Pereira Da Costa wrote: > > Ship It! > > Hugo Pereira Da Costa wrote: > err. Wait ... > There are rendering issues here once the patch is applied. > See http://wstaw.org/m/2016/05/30/plasma-desktopY12228.png >

Re: Review Request 127866: Oxygen: Fix QCache usage

2016-06-06 Thread Hugo Pereira Da Costa
> On May 30, 2016, 11:34 a.m., Hugo Pereira Da Costa wrote: > > Ship It! > > Hugo Pereira Da Costa wrote: > err. Wait ... > There are rendering issues here once the patch is applied. > See http://wstaw.org/m/2016/05/30/plasma-desktopY12228.png >

Re: Review Request 127866: Oxygen: Fix QCache usage

2016-05-30 Thread Hugo Pereira Da Costa
> On May 30, 2016, 11:34 a.m., Hugo Pereira Da Costa wrote: > > Ship It! > > Hugo Pereira Da Costa wrote: > err. Wait ... > There are rendering issues here once the patch is applied. > See http://wstaw.org/m/2016/05/30/plasma-desktopY12228.png >

Re: Review Request 127866: Oxygen: Fix QCache usage

2016-05-30 Thread Hugo Pereira Da Costa
> On May 30, 2016, 11:34 a.m., Hugo Pereira Da Costa wrote: > > Ship It! err. Wait ... There are rendering issues here once the patch is applied. See http://wstaw.org/m/2016/05/30/plasma-desktopY12228.png (left is "before", right is "after"). So something se

Re: Review Request 127866: Oxygen: Fix QCache usage

2016-05-30 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127866/#review96029 --- Ship it! Ship It! - Hugo Pereira Da Costa On May 22

Re: Review Request 127866: Oxygen: Fix QCache usage

2016-05-15 Thread Hugo Pereira Da Costa
e insertion stage is too much of a pain to handle) ? Or just commit and wait for bug reports about freezes ? (but with a happy coverty) ? - Hugo Pereira Da Costa On May 8, 2016, 5:03 a.m., Michael Pyne wrote: > > --- > This is an a

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-21 Thread Hugo Pereira Da Costa
é, QPushButton::SizeHint already include the size of the icon to be drawn in the size it calculates and passes to QStyle::sizeFromContents. So that you would need to either "undo" the size calculated by QPushButton in the sizeHint method (which sounds quite fragile I think), or indeed, patch QPushButton in some way ... Comments welcome (especially i

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-11 Thread Hugo Pereira Da Costa
gt; > > "Fixing" that in deprecated KPushButton doesn't really fix anything. We'll > > face the mix we had, just that users of QPushButton were far less prone to > > pass them an icon in pre-KF5 times. > > > > Please also attach Hugo Pereira Da Costa. > >

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-11 Thread Hugo Pereira Da Costa
gt; > > "Fixing" that in deprecated KPushButton doesn't really fix anything. We'll > > face the mix we had, just that users of QPushButton were far less prone to > > pass them an icon in pre-KF5 times. > > > > Please also attach Hugo Pereira Da Costa. > >

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-11 Thread Hugo Pereira Da Costa
gt; > > "Fixing" that in deprecated KPushButton doesn't really fix anything. We'll > > face the mix we had, just that users of QPushButton were far less prone to > > pass them an icon in pre-KF5 times. > > > > Please also attach Hugo Pereira Da Costa. > >

Re: KScreenGenie moved to KDE Review

2015-06-28 Thread Hugo Pereira Da Costa
On 06/28/2015 06:40 PM, Hugo Pereira Da Costa wrote: On 06/28/2015 10:58 AM, Martin Koller wrote: On Thursday 18 June 2015 15:03:27 Boudhayan Gupta wrote: Here's an Imgur album with some more screenshots, including how Rectangle Selection works: http://imgur.com/a/1peZa I miss the copy

Re: KScreenGenie moved to KDE Review

2015-06-28 Thread Hugo Pereira Da Costa
On 06/28/2015 10:58 AM, Martin Koller wrote: On Thursday 18 June 2015 15:03:27 Boudhayan Gupta wrote: Here's an Imgur album with some more screenshots, including how Rectangle Selection works: http://imgur.com/a/1peZa I miss the copy button to be able to copy the captured image to the

Re: Review Request 121083: Replace manual export files with CMake's generate_export_header

2014-11-23 Thread Hugo Pereira Da Costa
On Nov. 22, 2014, 12:18 a.m., Harald Sitter wrote: This breaks the kde4 build as ECM is not being used there and generate_export_header is not available without ECM. Andrius da Costa Ribas wrote: generate_export_header isn't in ECM, but in cmake itself

Re: KF5 tab style issues

2014-09-16 Thread Hugo Pereira Da Costa
On 09/15/2014 10:42 PM, Michal Humpula wrote: Hi there, I've encountered strange issue with the style of kf5 kdevelop tabs. Specifically the close button takes more space then anything else. It seems to be drawn by QCommonStyle class, which is inherited by KStyle. What I'm not sure, where is

Re: Review Request 118763: Remove find_package(XCB) call as it is handled already by the top-level cmake file

2014-08-18 Thread Hugo Pereira Da Costa
On June 26, 2014, 11:49 a.m., Hugo Pereira Da Costa wrote: Ship It! Ping ? Should I commit this myself ? - Hugo --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118763/#review61017

Re: Review Request 118763: Remove find_package(XCB) call as it is handled already by the top-level cmake file

2014-06-26 Thread Hugo Pereira Da Costa
On June 16, 2014, 6:57 a.m., Martin Gräßlin wrote: looks good to me, +1. Please add Hugo Pereira Da Costa to the Review Request, though. The review request made me wonder whether we still need to find XLib in Oxygen, though. The parts shown only use XCB, so maybe we could just go

Re: Review Request 118763: Remove find_package(XCB) call as it is handled already by the top-level cmake file

2014-06-26 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118763/#review61017 --- Ship it! Ship It! - Hugo Pereira Da Costa On June 16

Re: Review Request 115964: Oxygen: avoid calls to reparseConfiguration() on startup.

2014-02-25 Thread Hugo Pereira Da Costa
::self()-sharedConfig() ) ), Does this review depend on some pending changes in kconfig ? - Hugo Pereira Da Costa On Feb. 23, 2014, 12:08 p.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 115964: Oxygen: avoid calls to reparseConfiguration() on startup.

2014-02-25 Thread Hugo Pereira Da Costa
/ --- (Updated Feb. 25, 2014, 12:02 p.m.) Review request for kde-workspace and Hugo Pereira Da Costa. Repository: kde-workspace Description --- Oxygen: avoid calls to reparseConfiguration() on startup. strace -e open kate | grep -v NOENT | grep oxygenrc | wc -l went from 8 to 4

Re: Review Request 115515: [oxygen] Check whether we are on platform X11 before calling into xcb

2014-02-07 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115515/#review49179 --- Ship it! ship it, again :) - Hugo Pereira Da Costa On Feb

Re: Review Request 112335: In oxygen: Use the iconSize from mainToolbar

2014-01-07 Thread Hugo Pereira Da Costa
/ --- (Updated Aug. 28, 2013, 5:09 p.m.) Review request for kde-workspace and Hugo Pereira Da Costa. Repository: kde-workspace Description --- In the qplatformplugin we use information from MainToolbar (which makes sense) but in the styles we use

Re: Review Request 114537: Fix progressbar's busy animation with QtQuickControls

2013-12-19 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114537/#review45932 --- Ship it! Ship It! - Hugo Pereira Da Costa On Dec. 19, 2013

Review Request 114328: re-add customstyleelement suite to kstyle

2013-12-06 Thread Hugo Pereira Da Costa
: will be used when moving oxygen from qcommonstyle back to kstyle (right now we have a fork of some of the said methods) Thanks, Hugo Pereira Da Costa

projects page dead ?

2013-11-29 Thread Hugo Pereira Da Costa
https://projects.kde.org/projects/ gives 'bad gateway'. Is it just me ? A known (hopefully temporary) issue ? Has the page moved ? Thanks in advance, Hugo

kde-workspace git broken ?

2013-11-11 Thread Hugo Pereira Da Costa
Hello, I think commits 9f70241d57f3ba1013b9f28650478c8bbb1233e0 137dd285bdf821fd2c8a5c17e30dc9c1a6eca87b 09ea308ab55505efe7aeaebcd4aef6292cd884e6 seriously broke kde-workspace At least several changes in oxygen where reverted in the process. (below is a diff of oxygenstyle.h between

Re: kde-workspace git broken ?

2013-11-11 Thread Hugo Pereira Da Costa
On 11/11/2013 02:13 PM, Martin Gräßlin wrote: On Monday 11 November 2013 13:29:32 Hugo Pereira Da Costa wrote: Hello, I think commits 9f70241d57f3ba1013b9f28650478c8bbb1233e0 137dd285bdf821fd2c8a5c17e30dc9c1a6eca87b 09ea308ab55505efe7aeaebcd4aef6292cd884e6 seriously broke kde-workspace yes

please delete kde-workspace master-xcb remote branch

2013-10-24 Thread Hugo Pereira Da Costa
Hi, could someone with proper credentials delete the kde-workspace remote branch called master-xcb, I just created it *by mistake* while pushing some changes to master ? Thanks in advance, Hugo

Re: Review Request: make folderview icons translucent if composite is enabled

2012-05-03 Thread Hugo Pereira Da Costa
have also implemented alpha channel for Window tabbing dnd icons, in oxygen-decoration, to test the above. See: http://wstaw.org/m/2012/05/03/dnd1.png) I believe this review request can therefore be discarder. - Hugo Pereira Da Costa On April 19, 2012, 11:29 p.m., Mathias Stephan Panzenböck

Re: Review Request: make folderview icons translucent if composite is enabled

2012-05-03 Thread Hugo Pereira Da Costa
On May 29, 2011, 1:05 p.m., Thomas Lübking wrote: Not sure wheher it's really worth it (though using ARGB over XShape might actually bring better performance) but I assume the style (oxygen) can deal this more efficiently (via polishment) and also globally (not only for the

Re: Using KColorScheme in style only (Was: fix frameworks-kactions compile error)

2012-04-19 Thread Hugo Pereira Da Costa
On 04/19/2012 11:27 AM, Stephen Kelly wrote: Hi, can anyone who knows about styles/KColorScheme comment on this? Thanks, Stephen Kelly wrote: Kevin Ottens wrote: On Wednesday 11 April 2012 23:34:18 Stephen Kelly wrote: [...] At the center of the questions of what to do with KUrlLabel and

Re: Binary compatiblity for liboxygenstyle.so

2012-03-06 Thread Hugo Pereira Da Costa
Adding Ralf in CC, since he is experiencing the same issues. -- This starts to get off-topic, but I see the same with zsh, as in I started zsh from bash and run the above tests, with : ending it works, without it doesn't. There's either

Re: Binary compatiblity for liboxygenstyle.so

2012-02-25 Thread Hugo Pereira Da Costa
On 02/24/12 19:38, Andras Mantia wrote: On Friday, February 24, 2012 05:48:36 PM Sune Vuorela wrote: On 2012-02-24, Hugo Pereira Da Costah...@oxygen-icons.org wrote: I understand that. The point I was trying to make, is that you would still get the old pluggin, admittingly without crashing,

Re: Binary compatiblity for liboxygenstyle.so

2012-02-24 Thread Hugo Pereira Da Costa
Hi Andras, no there is no guarantee for liboxygenstyle.so.4, and I don't plan to guarantee it. It is all internal to kde-workspace, and has no public api. the fact that oxygen gets broken for kde installed from source due to incorrect plugin path is an issue with Qt installantion, and/or with

Re: Binary compatiblity for liboxygenstyle.so

2012-02-24 Thread Hugo Pereira Da Costa
On 02/24/2012 11:21 AM, Hugo Pereira Da Costa wrote: Hi Andras, no there is no guarantee for liboxygenstyle.so.4, and I don't plan to guarantee it. It is all internal to kde-workspace, and has no public api. the fact that oxygen gets broken for kde installed from source due to incorrect

Re: Binary compatiblity for liboxygenstyle.so

2012-02-24 Thread Hugo Pereira Da Costa
On 02/24/2012 11:25 AM, Hugo Pereira Da Costa wrote: On 02/24/2012 11:21 AM, Hugo Pereira Da Costa wrote: Hi Andras, no there is no guarantee for liboxygenstyle.so.4, and I don't plan to guarantee it. It is all internal to kde-workspace, and has no public api. the fact that oxygen gets

Re: Binary compatiblity for liboxygenstyle.so

2012-02-24 Thread Hugo Pereira Da Costa
On 02/24/2012 11:43 AM, Pino Toscano wrote: Alle venerdì 24 febbraio 2012, Hugo Pereira Da Costa ha scritto: no there is no guarantee for liboxygenstyle.so.4, and I don't plan to guarantee it. It is all internal to kde-workspace, and has no public api. Then please correctly bump its SONAME

Re: Binary compatiblity for liboxygenstyle.so

2012-02-24 Thread Hugo Pereira Da Costa
On 02/24/2012 11:51 AM, Thiago Macieira wrote: On sexta-feira, 24 de fevereiro de 2012 11.49.44, Hugo Pereira Da Costa wrote: despite the fact that you have a local kde build, the pluggins that gets loaded by Qt when running a KDE or Qt application are not the ones you compiled. An old one

Re: Binary compatiblity for liboxygenstyle.so

2012-02-24 Thread Hugo Pereira Da Costa
On 02/24/2012 11:56 AM, Andras Mantia wrote: On Friday, February 24, 2012 11:51:51 AM Thiago Macieira wrote: Correct. Make sure that your new KDE's installation is found by the Qt plugin system, either by setting QT_PLUGIN_PATH or by editing Trolltech.conf. I have this: printenv

Re: Review Request: #include fixx11h.h

2012-01-15 Thread Hugo Pereira Da Costa
/ --- (Updated Jan. 15, 2012, 12:53 p.m.) Review request for KDE Base Apps and Hugo Pereira Da Costa. Description --- Add #include fixx11h.h in some places where it was missing. This improves buildability. Diffs - kcminit/main.cpp 68bfb05 kcontrol/access/kaccess.h c364b25

Re: Review Request: fix the rect passed to kcapacitybar paint method

2012-01-12 Thread Hugo Pereira Da Costa
. http://bugs.kde.org/show_bug.cgi?id=290879 Diffs (updated) - kdeui/widgets/kcapacitybar.cpp 6e63c3f Diff: http://git.reviewboard.kde.org/r/103669/diff/diff Testing --- Fixes bug above. No regression with other styles. Thanks, Hugo Pereira Da Costa

Re: hard-dep for Qt 4.8

2012-01-12 Thread Hugo Pereira Da Costa
Personally, I think making Qt4.8 mandatory for KDE4.8 without strong reasons to do so raises the barrier a bit too high for casual contributors willing to fix bugs. I personally find Qt harder to compile than kde and am quite reluctant to update, just to be able to still fix bugs in oxygen.

Re: hard-dep for Qt 4.8

2012-01-12 Thread Hugo Pereira Da Costa
On 01/13/2012 12:12 AM, Hugo Pereira Da Costa wrote: Personally, I think making Qt4.8 mandatory for KDE4.8 without strong reasons to do so raises the barrier a bit too high for casual contributors willing to fix bugs. I personally find Qt harder to compile than kde and am quite reluctant

Re: Review Request: fix the rect passed to kcapacitybar paint method

2012-01-10 Thread Hugo Pereira Da Costa
:)). - Hugo --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103669/#review9716 --- On Jan. 10, 2012, 5:06 p.m., Hugo Pereira Da Costa wrote

Re: Building kde-workspace with latest checkout

2011-09-21 Thread Hugo Pereira Da Costa
Adding kde-core-devel, which is better suited for these kind of emails. Seems to me that trunk is actually not up to date for kdelibs, and that accessor to resizeMethodHint is missing from plasma/wallpaper.h / .cpp See patch attached. (can someone fix/commit this ?) At least it made

Expert advice needed on problems with oxygen + alpha channel

2011-08-09 Thread Hugo Pereira Da Costa
Hello, I'm facing a bug with oxygen and KToolBar when compositing is active that I need expert advice on. The issue: when you detach (unlock and move out of the window) a KToolbar from a main window, oxygen gives it the translucent background flag, and uses it to draw nice beveled corner on

Re: Review Request: Fix logic with clear-button animation in klineedit (notably at first try) and address bug 268898.

2011-07-27 Thread Hugo Pereira Da Costa
-wideEnoughForClear text.length() 0); Nicolas Alvarez wrote: I think the original is clearer, to be honest. Hugo Pereira Da Costa wrote: I agree with Nicolas. I have nothing against putting boolean test inside the method call, *in principle*, but I believe it's convenient only

Re: KMainWindow unit test crash, caused by recent Oxygen commit

2011-06-27 Thread Hugo Pereira Da Costa
I could reproduce the issue with both kxmlgui_unittest and kmainwindow_unittest Oxygen was the curlpit indeed. (there was a real flaw in the code, thanks to Thomas for pointing it out). Should be fixed with http://commits.kde.org/kde-workspace/68dbf302f2cb7bb011bdbd52e8dda04902a1dae5 Sorry

Re: Help on .desktop files for oxygen

2011-05-06 Thread Hugo Pereira Da Costa
Pereira Da Costa a écrit : Le 04/28/2011 02:52 PM, Harald Sitter a écrit : On Thursday 28 April 2011 11:54:13 Hugo Pereira Da Costa wrote: Having all the configuration featurs of oxygen-settings in systemsettings is simply not an option (it has been discussed at length among oxygen devs). It does

Re: QPixmap::handle(): Pixmap is not an X11 class pixmap

2011-05-02 Thread Hugo Pereira Da Costa
Le 05/02/2011 04:33 PM, Christoph Feck a écrit : On Monday 02 May 2011 16:15:42 Wolfgang Rohdewald wrote: since updating to kubuntu 11.04 I am getting this message while KApplication is created, but only if I use raster or opengl as graphics system: kpat --graphicssystem raster

Re: Review Request: Add KMessageWidget, an alternative to KMessageBox

2011-05-02 Thread Hugo Pereira Da Costa
On May 1, 2011, 10:14 a.m., Hugo Pereira Da Costa wrote: Hello Aurelien, Though I have nothing to say against the current design of your kmessagebox widget, something I miss in your implementation is the possibility for a widget style to override/replace your rendering. I can

Re: Review Request: Add KMessageWidget, an alternative to KMessageBox

2011-05-01 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101249/#review3003 --- Also, I wanted to add that Gtk already has a widget similar to

Re: Review Request: Add KMessageWidget, an alternative to KMessageBox

2011-05-01 Thread Hugo Pereira Da Costa
On May 1, 2011, 10:14 a.m., Hugo Pereira Da Costa wrote: Hello Aurelien, Though I have nothing to say against the current design of your kmessagebox widget, something I miss in your implementation is the possibility for a widget style to override/replace your rendering. I can

Help on .desktop files for oxygen

2011-04-28 Thread Hugo Pereira Da Costa
Hi, For a couple of releases, oxygen widget and decoration style comes with an advanced configuration tool, called oxygen-settings [1], and accessible (so far) only from terminal (or krunner). For the record: there are already 'basic' configuration tools available at the usual places in

Re: Help on .desktop files for oxygen

2011-04-28 Thread Hugo Pereira Da Costa
Harald, David, Thanks for the feedback. Obviously too much careless copy/paste on my side. Harald: Having all the configuration featurs of oxygen-settings in systemsettings is simply not an option (it has been discussed at length among oxygen devs). So the available solutions are either: 1/

Re: OpenPrinting Summit - Print Dialog and Colour Management

2011-03-16 Thread Hugo Pereira Da Costa
On Wednesday 16 March 2011 19:55:48 todd rme wrote: On Wed, Mar 16, 2011 at 1:44 PM, John Layt johnl...@googlemail.com wrote: Hi, I'll be attending the OpenPrinting Summit [1] to discuss how to complete the Common Printing Dialog [2] and integrate it into KDE and Qt. I'm looking for

Re: OpenPrinting Summit - Print Dialog and Colour Management

2011-03-16 Thread Hugo Pereira Da Costa
On Wednesday 16 March 2011 19:55:48 todd rme wrote: On Wed, Mar 16, 2011 at 1:44 PM, John Layt johnl...@googlemail.com wrote: Hi, I'll be attending the OpenPrinting Summit [1] to discuss how to complete the Common Printing Dialog [2] and integrate it into KDE and Qt. I'm looking for

Re: Merge or Cherry-Pick?

2011-02-03 Thread Hugo Pereira Da Costa
On Thursday 03 February 2011 13:04:18 Johannes Sixt wrote: Am 2/3/2011 12:15, schrieb Hugo Pereira Da Costa: So I git cloned KDE/4.6 into some local branch (git checkout KDE/4.6; git checkout -b toolbuttons), then fix, then test. Now I want to merge to the KDE/4.6 branch; thats easy

RESOLVED vs CLOSED

2011-01-15 Thread Hugo Pereira Da Costa
Hello all, sorry for this newbye question. I was pointed out that RESOLVED bugs on bugs.kde.org can be further tagged as CLOSED. ... which I did not know. Right now, there are 432 bug reports related to oxygen which are RESOLVED, but not CLOSED. What exactly is the policy on tagging them as

Re: system-settings color change vs Qt (non-kde) apps

2011-01-04 Thread Hugo Pereira Da Costa
On Tuesday, January 04, 2011 09:05:13 pm Albert Astals Cid wrote: A Dimarts, 4 de gener de 2011, Hugo Pereira Da Costa va escriure: Hello all, Here, when I change the color scheme in kde's system-settings, the change is propagated properly to KDE apps, but not to Qt (non-kde