Re: liquidshell in kdereview

2017-12-02 Thread Sebastian Kügler
On Sat, 02 Dec 2017 10:27:16 +0100 Albert Astals Cid <aa...@kde.org> wrote: > El divendres, 1 de desembre de 2017, a les 14:05:19 CET, Sebastian > Kügler va escriure: > > On Thu, 30 Nov 2017 18:41:28 +0100 > > > > Martin Koller <kol...@aon.at> wrote: > >

Re: liquidshell in kdereview

2017-12-01 Thread Sebastian Kügler
On Thu, 30 Nov 2017 18:41:28 +0100 Martin Koller <kol...@aon.at> wrote: > On Donnerstag, 30. November 2017 10:04:51 CET Sebastian Kügler wrote: > > On woensdag 29 november 2017 21:23:15 CET Martin Koller wrote: > > > On Freitag, 3. November 2017 21:30:19

Re: liquidshell in kdereview

2017-11-30 Thread Sebastian Kügler
On woensdag 29 november 2017 21:23:15 CET Martin Koller wrote: > On Freitag, 3. November 2017 21:30:19 CET Martin Koller wrote: > > > > Hi all, > > > > I'd like to announce an application I've implemented over the last few > > weeks - liquidshell > since more than 3 weeks have passed, I

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-07 Thread Sebastian Kügler
(line 52) <https://git.reviewboard.kde.org/r/129917/#comment68316> I think it's overkill to enable this by default, given it's only interesting to a limited group of users, and others probably won't understand it, or its utility. - Sebastian Kügler On Feb. 6, 2017, 8:05 p.m.,

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-06 Thread Sebastian Kügler
? This is important for us to review the visual impact your patch has. Thanks already for your work on this! I think it's a useful addition. - Sebastian Kügler On Feb. 5, 2017, 6:11 p.m., Pascal VITOUX wrote: > > --- > This is an auto

Re: Review Request 114437: Add right click contextmenu for Plasma Components TextField

2017-01-23 Thread Sebastian Kügler
> On Jan. 22, 2017, 10:20 p.m., Albert Astals Cid wrote: > > Sebas should I commited this? After 3 years i'm not sure kde-runtime is the > > best thing to update in it's almost frozen state. > > Sebastian Kügler wrote: > I'd just discard it. I don't think anybody

Re: Review Request 114437: Add right click contextmenu for Plasma Components TextField

2017-01-23 Thread Sebastian Kügler
> On Jan. 22, 2017, 10:20 p.m., Albert Astals Cid wrote: > > Sebas should I commited this? After 3 years i'm not sure kde-runtime is the > > best thing to update in it's almost frozen state. I'd just discard it. I don't think anybody is releasing kde-runtime anyway, and the proper way to fix

Re: Review Request 128749: Backport karchive fix for out of directory files

2016-09-29 Thread Sebastian Kügler
> On Sept. 7, 2016, 9:49 a.m., Sebastian Kügler wrote: > > This patch seems to have caused a regression when installing some wallpaper > > packages, Marco fixed it in the knewstuff frameworks with > > 39b33ddd1e21c017b. We may have a problem now -- we'll

Re: Snappy sprint reporty musing

2016-07-26 Thread Sebastian Kügler
On Tuesday, July 26, 2016 2:27:34 PM CEST Aleix Pol wrote: > > Could you expand on the distribution mechanism? > > I don't understand the question. That's what you already did with your email, so thanks. :-) -- sebas http://www.kde.org | http://vizZzion.org

Re: Snappy sprint reporty musing

2016-07-26 Thread Sebastian Kügler
On Tuesday, July 26, 2016 1:08:28 PM CEST Harald Sitter wrote: > - a store REST API (of which the reference version is the ubuntu store) So something like this exists for flatpaks as well, and it's open source? For snappy, we'd either have to use the ubuntu store (non-free, right?) or write our

Re: web server for appstream metadata screenshots

2016-06-16 Thread Sebastian Kügler
On dinsdag 14 juni 2016 01:03:39 CEST Albert Astals Cid wrote: > El dimarts, 14 de juny de 2016, a les 0:54:06 CEST, Matthias Klumpp va > > escriure: > > 2016-06-14 0:34 GMT+02:00 Albert Astals Cid : > > > [...] > > > > > > You can not have all of these three: > > > * Free commit

Re: web server for appstream metadata screenshots

2016-06-13 Thread Sebastian Kügler
Thanks all for the input! On woensdag 8 juni 2016 13:46:17 CEST Burkhard Lück wrote: > > I've been adding appstream metadata to one of the apps I maintain, among > > that are also screenshots, in the form of a URL. That means that I have to > > put the screenshots on a webserver. > > > > Do we

web server for appstream metadata screenshots

2016-06-08 Thread Sebastian Kügler
people hosting them on imgur, their private webserver or their router-behind-a-dsl-line. :) Cheers, -- sebas Sebastian Kügler•http://vizZzion.org•http://www.kde.org

Re: remove khelpcenter from next Plasma release?

2016-04-01 Thread Sebastian Kügler
Hi Yuri, On Wednesday, March 09, 2016 06:37:09 PM Yuri Chornoivan wrote: > Yes. That's what I meant. > > But generally, I cannot say that I like the way the things are going. The > UserBase project does not have significant updates on applications pages > (although it was claimed that users

Re: remove khelpcenter from next Plasma release?

2016-03-19 Thread Sebastian Kügler
On Tuesday, March 15, 2016 05:52:55 PM Jeremy Whiting wrote: > As an application developer I agree it makes sense to have khelpcenter > released with KDE Applications. I also agree with Albert's point that > having online documentation isn't the best since it could be newer > than what's actually

Re: remove khelpcenter from next Plasma release?

2016-03-09 Thread Sebastian Kügler
us quo but with maintainer), that would already be an improvement of course. The question mark was honest, we haven't made a decision on it, but different people do have expressed a preference for not shipping it (as or by default in Plasma releases). We may have missed important points, and we do

Re: remove khelpcenter from next Plasma release?

2016-03-09 Thread Sebastian Kügler
anks in advance for your answer. Yuri, this is an discussion between developers, and your email doesn't meet the requirement of being constructive or respectful. Please change your attitude or refrain from further commenting. If you're unsure, read https://www.kde.org/code-of-conduct/ -- sebas S

Re: remove khelpcenter from next Plasma release?

2016-03-09 Thread Sebastian Kügler
hat pretty clear. We do think that disconnected systems are rather a fringe case, and that our time and effort is better spent on other things. -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org

remove khelpcenter from next Plasma release?

2016-03-09 Thread Sebastian Kügler
-bent on keeping it, this person should consider maintaining it as well. Unmaintained code in Plasma is not cool, and so far nobody seems to care enough to step up. Cheers, -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org

Re: Google Summer of Code 2016 - C# bindings for Qt

2016-03-03 Thread Sebastian Kügler
SoC admins on the mailinglist kde- s...@kde.org , they can answer your questions and get you set up to mentor. > On Thu, Mar 3, 2016 at 5:58 PM, Sebastian Kügler <se...@kde.org> wrote: > > On Thursday, March 03, 2016 06:20:49 PM Arno Rehn wrote: > > > having worked with Dimitar

Re: KDE file dialog

2016-03-01 Thread Sebastian Kügler
On Tuesday, March 01, 2016 06:45:14 PM Martin Koller wrote: > On Monday 29 February 2016 21:34:13 Luigi Toscano wrote: > > > Should a KF5 app (with frameworksintegration) not also use the settings > > > from a still used KDE4 desktop ?> > > > > > > frameworksintegration is going to be part of

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

2016-01-07 Thread Sebastian Kügler
> On Jan. 7, 2016, 3:31 p.m., Sebastian Kügler wrote: > > src/kpackage/packageloader.cpp, line 190 > > <https://git.reviewboard.kde.org/r/126660/diff/1/?file=428735#file428735line190> > > > > What does the category have to do with this? We should only be goin

Re: Change to Mail Infrastructure - SPF and DKIM verification will now be enforced

2015-12-07 Thread Sebastian Kügler
On Friday, December 04, 2015 11:28:03 AM Jan Kundrát wrote: > On Friday, 4 December 2015 10:56:42 CET, Ben Cooksley wrote: > > Note that in the long run with DMARC looming you will need to switch > > to #2 anyway, and keeping your current behaviour will likely lead to > > mail from people who use

Re: [kde-community] Phabricator: Make it happen already!

2015-08-27 Thread Sebastian Kügler
On Wednesday, August 26, 2015 20:57:25 Jaroslaw Staniek wrote: +1 (I am using it as if it was official) Same here. The Plasma team is in the process of migrating to phaaab! already. -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9

Re: Modular startkde proof of concept

2015-08-20 Thread Sebastian Kügler
On Thursday, August 20, 2015 11:31:57 Helio Chissini de Castro wrote: We ( aka's distros ) been patching startkde for years due obvious particular things oriented to the specific distro. Believe or not, is always an issue, since systems changes, and changed a lot in this years. So, in a

Re: Plasma Applet for Audio Volume for kdereview

2015-08-17 Thread Sebastian Kügler
I think we should be peachy now. Can plasma-pa be moved from kdereview to kde/workspace? On Wednesday, August 05, 2015 12:45:01 Jonathan Riddell wrote: plasma-pa is a new volume manager and is intended to be a replacement for KMix in Plasma. We plan to ship it as a beta in Plasma 5.4 and

Re: Documentation (was Re: Plasma Applet for Audio Volume for kdereview)

2015-08-12 Thread Sebastian Kügler
On Wednesday, August 12, 2015 12:20:29 Luigi Toscano wrote: On Wednesday 12 of August 2015 10:05:34 Sebastian Kügler wrote: Also, the Evolve survey was pretty clear that we utterly suck in the documentation arena. Playing with words doesn't solve that, writing documentation and maintaining

Re: Plasma Applet for Audio Volume for kdereview

2015-08-12 Thread Sebastian Kügler
On Wednesday, August 12, 2015 21:49:43 Ben Cooksley wrote: On Wed, Aug 12, 2015 at 12:02 PM, David Edmundson da...@davidedmundson.co.uk wrote: We've had it marked as hard requirement for a long time in https://techbase.kde.org/Policies/Application_Lifecycle But it's true that Plasma

Re: Plasma Applet for Audio Volume for kdereview

2015-08-11 Thread Sebastian Kügler
On Monday, August 10, 2015 19:40:34 Sebastian Kügler wrote: On Monday, August 10, 2015 20:37:26 Albert Astals Cid wrote: El Dilluns, 10 d'agost de 2015, a les 10:35:48, Sebastian Kügler va escriure: On Thursday, August 06, 2015 22:56:09 Luigi Toscano wrote: Is this a hard requirement

Re: Plasma Applet for Audio Volume for kdereview

2015-08-10 Thread Sebastian Kügler
On Thursday, August 06, 2015 12:25:32 Burkhard Lück wrote: Am Donnerstag, 6. August 2015, 00:40:41 schrieb Albert Astals Cid: Missing or not so good i18n ./src/kcm/package/contents/ui/VolumeSlider.qml:84:text: Math.floor(slider.value / slider.maximumValue * 100.0) + %

Re: Plasma Applet for Audio Volume for kdereview

2015-08-10 Thread Sebastian Kügler
On Sunday, August 09, 2015 14:59:59 Dāvis Mosāns wrote: 2015-08-05 15:45 GMT+03:00 Jonathan Riddell j...@jriddell.org: plasma-pa is a new volume manager and is intended to be a replacement for KMix in Plasma. We plan to ship it as a beta in Plasma 5.4 and it's currently in kdereview for

Re: Plasma Applet for Audio Volume for kdereview

2015-08-10 Thread Sebastian Kügler
On Thursday, August 06, 2015 22:56:09 Luigi Toscano wrote: Jonathan Riddell ha scritto: plasma-pa is a new volume manager and is intended to be a replacement for KMix in Plasma. We plan to ship it as a beta in Plasma 5.4 and it's currently in kdereview for your reviewing attention.

Re: Plasma Applet for Audio Volume for kdereview

2015-08-06 Thread Sebastian Kügler
On Thursday, August 06, 2015 00:40:41 Albert Astals Cid wrote: Missing or not so good i18n ./src/kcm/package/contents/ui/VolumeSlider.qml:84:text: Math.floor(slider.value / slider.maximumValue * 100.0) + % ./src/kcm/package/contents/ui/VolumeSlider.qml:90:text: 100%

Re: KScreenGenie moved to KDE Review

2015-06-17 Thread Sebastian Kügler
prettier with some help from the VDG. Since not everybody is able to, or has the time to compile kscreengenie's sources, screenshots would be really helpful. Cheers, -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org

Re: KSyCoca, Thread safety, and Cache invalidation

2015-06-12 Thread Sebastian Kügler
of using KSycoca. [...] I'm not quite sure on how to go about this. Do you have any suggestions? I'm leaning towards (3), but the locking code is scary. 7. the gui thread listens to dbus and sends a signal to the other threads? -- sebas Sebastian Kügler|http://vizZzion.org| http

Re: KF5-QT5 branchgroup - jobs that need developeer attention

2015-04-15 Thread Sebastian Kügler
Sebastian Kügler|http://vizZzion.org| http://kde.org

Re: The Future or KDE PIM Releases

2015-04-13 Thread Sebastian Kügler
Hey PIMsters, On Sunday, April 12, 2015 11:31:26 Daniel Vrátil wrote: Greetings from Toulouse! We've been discussing the plans for releases of Akonadi(Next) and KDE PIM as a whole on the PIM sprint, because the current situation is kinda unclear and harmful for the project. Now that we

Re: Warning: KPluginInfo::property(X-KDE-PluginInfo-Name) is deprecated

2015-02-21 Thread Sebastian Kügler
burying any useful information during the startup of Plasmashell. I think the warning is rather useless, and I'd just remove it, so 2). Cheers, -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

2015-02-21 Thread Sebastian Kügler
On Feb. 21, 2015, 2:46 a.m., Hrvoje Senjan wrote: can you check what needs to be adjusted in plasma-workspace? it fails to build with your change: [ 451s] /home/abuild/rpmbuild/BUILD/plasma-workspace-5.2.90git/libtaskmanager/taskitem.cpp:471:43: error:

Re: Warning: KPluginInfo::property(X-KDE-PluginInfo-Name) is deprecated

2015-02-21 Thread Sebastian Kügler
. That's completely fine. We're not too much in a hurry, it's not a showstopper by any means, just some janitorial work to make Plasma a bit easier to debug. Currently, about 2/3 of its console output consists of these messages. Thanks, Alex! -- sebas Sebastian Kügler|http://vizZzion.org

Re: [Kde-pim] Problems with infrastructure

2014-12-23 Thread Sebastian Kügler
On Friday, December 19, 2014 23:26:15 Albert Astals Cid wrote: El Dijous, 18 de desembre de 2014, a les 14:52:12, Sebastian Kügler va On Wednesday, December 17, 2014 08:47:09 Jeff Mitchell wrote: I understood that to be the case -- I'm really meaning for a general, KDE-wide solution

Re: Changes to branch management

2014-12-23 Thread Sebastian Kügler
On Wednesday, December 24, 2014 00:04:22 Ben Cooksley wrote: The first seems the least contentious: allowing all developers to delete branches on our mainline repositories, except for certain protected branches (like master and KDE/* for instance). I'd add frameworks to that, it has a status

Re: Plasma 5.2 bits for kdereview

2014-12-23 Thread Sebastian Kügler
On Friday, December 19, 2014 18:46:11 Luigi Toscano wrote: kscreen and libkscreen maintained by Dan Vrátil. libkscreen is already released with Plasma but isn't in kde/workspace. https://projects.kde.org/projects/extragear/libs/libkscreen

Re: Changes to branch management

2014-12-23 Thread Sebastian Kügler
On Tuesday, December 23, 2014 06:27:01 Albert Astals Cid wrote: El Dimarts, 23 de desembre de 2014, a les 14:48:21, Sebastian Kügler va escriure: On Wednesday, December 24, 2014 00:04:22 Ben Cooksley wrote: The first seems the least contentious: allowing all developers to delete

Re: Changes to branch management

2014-12-23 Thread Sebastian Kügler
On Tuesday, December 23, 2014 17:29:05 Ivan Čukić wrote: I'd add Applications/* and Plasma/* to this. Would it be possible to add the Calligra/* release branches to that Seems that release branches are starting with capital letters. Would that be possible and sufficient for the

Re: [Kde-pim] Problems with infrastructure

2014-12-19 Thread Sebastian Kügler
On Tuesday, December 16, 2014 16:12:05 Ben Cooksley wrote: For deleting branches, I think we can allow this - given some protection for certain branches (like the KDE/* branches for instance). Note that courtesy of the backup functionality in our hooks, no branch or tag is ever truly deleted

Re: [Kde-pim] Problems with infrastructure

2014-12-18 Thread Sebastian Kügler
On Wednesday, December 17, 2014 08:47:09 Jeff Mitchell wrote: I understood that to be the case -- I'm really meaning for a general, KDE-wide solution. Personally I don't have an issue with volunteers taking care of non-official systems if it helps their productivity. If Gerrit wasn't

Re: New framework to review: KPackage

2014-12-15 Thread Sebastian Kügler
On Monday, December 15, 2014 10:31:04 David Edmundson wrote: On Mon, Dec 15, 2014 at 10:25 AM, Marco Martin notm...@gmail.com wrote: On Thursday 11 December 2014, Kevin Kofler wrote: Marco Martin wrote: In the past weeks I have been working on a new framework, called KPackage.

Re: [Kde-pim] Problems with infrastructure

2014-12-10 Thread Sebastian Kügler
[I love our infrastructure, just this bit triggered my reply-to-email reflex] On Wednesday, December 10, 2014 10:28:59 Christian Mollekopf wrote: * deleting branches: This is the only major gripe I have with the kde infrastructure. I think everyone should be able to delete branches (except

Re: Review Request 121361: DeviceAutomounter Settings ui texts are misleading, if not plain wrong.

2014-12-08 Thread Sebastian Kügler
/121361/#comment49907 Well, with this change, the whatsthis and I suppose the function of this checkbox does the exact opposite of its name. automountUnknownDevices now means only automount know devices. - Sebastian Kügler On Dec. 5, 2014, 7:06 p.m., Frank Schütte wrote

Re: desktoptojson and list properties / i18n of JSON files

2014-12-02 Thread Sebastian Kügler
On Thursday, November 20, 2014 20:18:29 Burkhard Lück wrote: Am Donnerstag, 20. November 2014, 20:05:19 schrieb Sebastian Kügler: On Thursday, November 20, 2014 19:57:54 Burkhard Lück wrote: 2.2 is easier (if possible to change the code in 1 to do it) since it does not involve

Re: Review Request for KDecoration

2014-11-28 Thread Sebastian Kügler
On Friday, November 28, 2014 12:00:43 Martin Gräßlin wrote: Given that you call it fundamental, I suggest to allow qreal here. A millimeter is really small, and if you only allow integer values, the precision might be too coarse. The documentation is copied from Plasma. I don't know

Re: Review Request for KDecoration

2014-11-28 Thread Sebastian Kügler
On Friday, November 28, 2014 14:16:38 Martin Gräßlin wrote: On Friday 28 November 2014 13:53:07 Sebastian Kügler wrote: On Friday, November 28, 2014 12:00:43 Martin Gräßlin wrote: The documentation is copied from Plasma. I don't know anything about high DPI, so maybe sebas can

Re: [owncloud-devel] research question

2014-11-20 Thread Sebastian Kügler
exactly this. Talk to him! -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org

Re: desktoptojson and list properties / i18n of JSON files

2014-11-20 Thread Sebastian Kügler
in the .desktop file, the json file would not be translated. This is the root of the problem. Cheers, -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org

Re: desktoptojson and list properties / i18n of JSON files

2014-11-20 Thread Sebastian Kügler
. :/ Cheers, -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org

Re: desktoptojson and list properties / i18n of JSON files

2014-11-20 Thread Sebastian Kügler
data into one json structure anyway. Cheers, -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org

Re: desktoptojson and list properties / i18n of JSON files

2014-11-20 Thread Sebastian Kügler
, -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org

Re: desktoptojson and list properties / i18n of JSON files

2014-11-20 Thread Sebastian Kügler
data into one json structure anyway. Cheers, -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org

Re: Review Request 121084: Rename libmolletnetwork to avoid conflict with KDE4

2014-11-18 Thread Sebastian Kügler
. Thanks! - Sebastian Kügler On Nov. 9, 2014, 4:10 p.m., Armin K. wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121084

Re: desktoptojson and list properties

2014-11-18 Thread Sebastian Kügler
On Monday, November 17, 2014 18:50:04 Milian Wolff wrote: Or can we nowadays write the .json files directly, i.e. can scripty/ki18n cope with them nowadays? So, any chance we can use .json directly here? That should be possible, you can just drop the json file in there, and

Re: Review Request 121086: Rename jpegcreatorsettings.kcfg to avoid conflicts with KDE4

2014-11-18 Thread Sebastian Kügler
/121086/#comment49407 whitespace What I'm missing is migration of the setting, is that relevant, any other reason why it's missing? - Sebastian Kügler On Nov. 9, 2014, 4:09 p.m., Armin K. wrote: --- This is an automatically

Re: desktoptojson and list properties

2014-11-17 Thread Sebastian Kügler
On Monday, November 17, 2014 02:04:51 Aleix Pol wrote: On Mon, Nov 17, 2014 at 12:24 AM, Milian Wolff m...@milianw.de wrote: On Sunday 16 November 2014 23:52:25 Milian Wolff wrote: KDevelop is currently bitten hard by a bug/limitation in desktoptojson. It does not actually understand the

Re: Review Request 120535: attica: Add const to getter methods.

2014-10-09 Thread Sebastian Kügler
On Oct. 8, 2014, 9:22 p.m., Albert Astals Cid wrote: According to https://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++ changing the const/volatile qualifiers of the function is BIC Now the thing is if we allow BIC changes in frameworks like attica or not is for

Re: Location of Dr Konqi in Frameworks/KF 5

2014-09-08 Thread Sebastian Kügler
Hi Ian, On Friday, September 05, 2014 16:36:25 Ian Wadham wrote: I have heard that Dr Konqi source code for Frameworks/KF 5 has been placed in plasma-workspace. Please could you consider keeping it in some location that is common to all platforms? This includes both Linux platforms and

Re: Killing kdelibs master branch

2014-08-12 Thread Sebastian Kügler
On Monday, August 11, 2014 00:23:15 Albert Astals Cid wrote: Hi there, I'm sending this e-mail to propose removing the master branch of kdelibs. We kind of already tried that when we froze it, but i am proposing to actually delete it (and enforce with hooks it doesn't come back) from git.

Re: [kde-community] Closing the kde-core-devel mailing list

2014-08-12 Thread Sebastian Kügler
On Tuesday, August 05, 2014 21:28:14 Kevin Krammer wrote: On Tuesday, 2014-08-05, 20:29:05, Albert Astals Cid wrote: El Dilluns, 4 d'agost de 2014, a les 20:36:44, Vishesh Handa va escriure: Random Idea: How about we close the k-c-d mailing list? It's main purpose used to be to

Re: Review Request 118180: slideshow BUG patch fix

2014-07-21 Thread Sebastian Kügler
On July 21, 2014, 12:39 p.m., Martin Gräßlin wrote: TOM Harrison wrote: what kind of issue? tab and space different ? Yes, don't use tabs at all for code indentation, use 4 spaces. It should look consistent with the surrounding code after that. - Sebastian

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-24 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118898/#review60887 --- Ship it! Cool, this looks much less intrusive. - Sebastian

Re: Review Request 118366: Porting keyboard module to Framework5

2014-06-23 Thread Sebastian Kügler
uploaded contains intermediate changes, and makes it really hard to read. We're just interested in the difference between current version and your result. - Sebastian Kügler On June 20, 2014, 9:24 p.m., shivam makkar wrote

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Sebastian Kügler
KCM is dead in Plasma 5 (not really a reason to not fix it in 4.x, but the feature will be lost again Again, not super-privvy of the whole picture, but isn't color correction the correct solution here? - Sebastian Kügler On June 23, 2014, 1:06 p.m., Wolfgang Bauer wrote

Re: Review Request 118763: Remove find_package(XCB) call as it is handled already by the top-level cmake file

2014-06-16 Thread Sebastian Kügler
On Sunday, June 15, 2014 12:47:57 Bernd Steinhauser wrote: No idea if kde-workspace is still the right group, if not, please change. You can use plasma as group. -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9

Re: Moving plasma-nm to extragear

2014-05-30 Thread Sebastian Kügler
On Friday, May 30, 2014 10:31:37 Lamarque Souza wrote: I agree that Plasma NM should go to kde/workspace. In the past the only thing that prevented that was the fact that we needed to change translatable strings from time to time, which obviously does not comply with the string freeze. Now

Re: Review Request 117957: kcm_fonts: correctly restore default configuration values

2014-05-19 Thread Sebastian Kügler
there has moved to the plasma-desktop repo, under kcms/fonts. - Sebastian Kügler On May 18, 2014, 12:38 a.m., Andrea Iacovitti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117957

Re: Compatibility problems with latest GTK+ applications

2014-05-08 Thread Sebastian Kügler
On Thursday, May 08, 2014 14:39:49 Matthias Klumpp wrote: However, to support the cross-desktop efforts, the GNOME people should maybe make a few compromises (e.g. make GTK+ behave differently on other DEs), especially since GTK+ is not just for GNOME but also used by other projects. This is

Re: Review Request 117044: Avoid unnecessary automounting in KDiskFreeSpaceInfo::freeSpaceInfo

2014-05-07 Thread Sebastian Kügler
Next, it needs forward-porting. - Sebastian Kügler On May 6, 2014, 8:01 p.m., Tomáš Trnka wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117044

Re: KDE Frameworks Release Cycle

2014-05-07 Thread Sebastian Kügler
On Monday, May 05, 2014 11:11:53 Martin Klapetek wrote: However this highly depends on the distro policies - if some of the big distros say we will not update KF5 every month because our policies, then the 6 months buffer is just moved elsewhere, at the distro level because they will update

Re: Review Request 117174: Fix installing and removing desktop plasma theme packages.

2014-04-24 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117174/#review56363 --- Ship it! Looks good to me. - Sebastian Kügler On April 23

Re: Review Request 117174: Fix installing and removing desktop plasma theme packages.

2014-03-31 Thread Sebastian Kügler
then -- perhaps not what you want. If it's random anyway, why parse all, and not just pick the first one? - Sebastian Kügler On March 30, 2014, 1:14 p.m., Andrei Amuraritei wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 117174: Fix installing and removing desktop plasma theme packages.

2014-03-31 Thread Sebastian Kügler
On March 31, 2014, 4:04 p.m., Sebastian Kügler wrote: plasma/packagestructure.cpp, line 653 https://git.reviewboard.kde.org/r/117174/diff/2/?file=258228#file258228line653 { go on the next line (here and elsewhere) Andrei Amuraritei wrote: Sorry don't get what you mean here

Re: Review Request 109792: Update 'dim display' algorithm.

2014-03-16 Thread Sebastian Kügler
or update otherwise. Thanks... - Sebastian Kügler On April 13, 2013, noon, Danny Baumann wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109792

Re: Review Request 116077: KRunner patch so it detects Iceweasel bookmarks

2014-02-26 Thread Sebastian Kügler
at KDE? - Sebastian Kügler On Feb. 26, 2014, 10:48 a.m., Maximiliano Curia wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116077

Re: Moving Baloo forward

2014-02-21 Thread Sebastian Kügler
On Thursday, February 20, 2014 08:58:48 GEO wrote: Maybe a strange idea, but it would resolve the privacy problem: Baloo could optionally encrypt all the attributes using a user defined password, meaning baloo stores encrypted strings as file attributes. I have no experience with file

Plasma Next Release Plans

2014-02-19 Thread Sebastian Kügler
Hi all, The Plasma team has settled on a release schedule for the first stable released based on Qt5 and KF5. You can find the schedule here: http://techbase.kde.org/Schedules/Plasma/2014.6_Release_Schedule For those too lazy to click: We'll release .0 on 17th June, two alphas, a beta and an

Re: Moving Baloo forward

2014-01-24 Thread Sebastian Kügler
On Friday, January 24, 2014 01:24:54 Vadim Zhukov wrote: in the best case you'll have two totally different codepaths that you'll have to manage. This should be worst case, I think. In the best case, there's xattr support, meaning another code path isn't needed. Cheers, -- sebas

Re: Review Request 115260: Add default OSD to lookfeel package (screenshot included)

2014-01-24 Thread Sebastian Kügler
/#comment34087 ; at the end in scripts - Sebastian Kügler On Jan. 24, 2014, 11:42 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115260

Re: Splitting kde-workspace and kde-runtime proposal

2014-01-21 Thread Sebastian Kügler
On Tuesday, January 21, 2014 11:03:57 Bhushan Shah wrote: On Tue, Jan 21, 2014 at 1:19 AM, Àlex Fiestas afies...@kde.org wrote: In the plasma sprint we have done a session to plan what we are going to do with kde-workspace/kde-runtime repositories, here is the proposal we came with.

Re: Qt 5.3 to log all debug/warning/error messages to journald on systemd systems

2014-01-21 Thread Sebastian Kügler
On Monday, January 20, 2014 14:40:17 Thiago Macieira wrote: See subject. We're trying to decide whether we should enable journald by default on Linux distributions that carry it. If we do, it means any application that is not launched from a terminal would automatically write to journald

Re: Review Request 115056: rename knotifications StatusNotifierItem dbus interface in kde-workspace

2014-01-16 Thread Sebastian Kügler
-it say. Thanks for the patch! - Sebastian Kügler On Jan. 16, 2014, 5:02 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115056

Re: Moving Baloo and Baloo-widgets into KDE SC

2014-01-10 Thread Sebastian Kügler
Hey, On Friday, January 10, 2014 11:02:22 Mario Fux KDE ML wrote: Am Donnerstag, 09. Januar 2014, 23.26:01 schrieb Àlex Fiestas: If the breakage is minimal (which I know it is, but I will let vHanda reply to that) I vote to replace it even if we make a bit worse the experience using

Re: Review Request 114437: Add right click contextmenu for Plasma Components TextField

2013-12-14 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114437/#review45699 --- Ship it! Looks good. - Sebastian Kügler On Dec. 13, 2013

Re: Review Request 114437: Add right click contextmenu for Plasma Components TextField

2013-12-13 Thread Sebastian Kügler
/plasmacomponents/qml/TextField.qml http://git.reviewboard.kde.org/r/114437/#comment32612 Use i18n() here plasma/declarativeimports/plasmacomponents/qml/TextField.qml http://git.reviewboard.kde.org/r/114437/#comment32613 i18n() here as well - Sebastian Kügler On Dec. 13, 2013, 3:01 p.m., Leszek

Re: KMountPoint::probablySlow and cifs mount points

2013-11-25 Thread Sebastian Kügler
On Sunday, November 24, 2013 19:42:25 Mark Gaiser wrote: /** * Checks if the filesystem that is probably slow (network mounts). * @return true if the filesystem is probably slow */ and adding cifs to the list of mounttypes that are probablySlow? It's not my place

Re: Review Request 113853: port kcm icons to KF5

2013-11-14 Thread Sebastian Kügler
/#comment31380 ws - Sebastian Kügler On Nov. 14, 2013, 11:15 a.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113853

Re: Review Request 113853: port kcm icons to KF5

2013-11-14 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113853/#review43685 --- Ship it! Ship It! - Sebastian Kügler On Nov. 14, 2013, 4

Re: Review Request 113841: kcm locale: use kcmshell5

2013-11-13 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113841/#review43595 --- Ship it! Ship It! - Sebastian Kügler On Nov. 13, 2013, 2

Re: Review Request 113630: Port the original KDE4 ksplash theme to QML

2013-11-06 Thread Sebastian Kügler
. ksplash/ksplashqml/themes/Classic/FadeIn.qml http://git.reviewboard.kde.org/r/113630/#comment31096 license missing - Sebastian Kügler On Nov. 6, 2013, 9:14 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail

Re: Review Request 113630: Port the original KDE4 ksplash theme to QML

2013-11-05 Thread Sebastian Kügler
/ksplashqml/themes/Classic/main.qml http://git.reviewboard.kde.org/r/113630/#comment31055 This looks odd? - Sebastian Kügler On Nov. 5, 2013, 10:42 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 113630: Port the original KDE4 ksplash theme to QML

2013-11-05 Thread Sebastian Kügler
On Nov. 5, 2013, 1:07 p.m., Sebastian Kügler wrote: ksplash/ksplashqml/themes/Classic/main.qml, line 95 http://git.reviewboard.kde.org/r/113630/diff/2/?file=209134#file209134line95 Encapsulate the NumberAnimation into its own file. It should be easy to change. Martin Klapetek

Re: Review Request 113504: Fix krunner calculator letter check

2013-10-30 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113504/#review42695 --- Ship it! Ship It! - Sebastian Kügler On Oct. 30, 2013, 12

  1   2   3   >