QtCurve is now in kdereview with the intention of being in extragear/base
---
Compiled, pager and icontasks shows minimized windows correctly.
Also tested on openbox (+plasma's pager) by "Xuetian Weng".
Thanks,
Yichao Yu
tps://git.reviewboard.kde.org/r/126304/#comment61891>
trailing white space
- Yichao Yu
On 十二月 10, 2015, 12:12 p.m., René J.V. Bertin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboar
for the delay. I'm checking my email for the review requests but maybe
I'm not using the right filter or not subscribing to the right list.
- Yichao Yu
On 十二月 10, 2015, 12:12 p.m., René J.V. Bertin wrote:
>
> ---
> This is an auto
tps://git.reviewboard.kde.org/r/126304/#comment61892>
Also here
- Yichao Yu
On 十二月 10, 2015, 12:12 p.m., René J.V. Bertin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboar
://git.reviewboard.kde.org/r/121390/
---
(Updated 十二月 8, 2014, 4:59 p.m.)
Review request for KDE Frameworks, Qt KDE and Yichao Yu.
Repository: qtcurve
Description
---
Yesterday's patches for OS X building broke the build of the Qt5
expensive when X11 is the only
platform that provides a certain functionality ... :)
(I do seem to recall that using function pointers instead of normal
functions was hardly more expensive on x86)
Yichao Yu wrote:
Sorry somehow my filter missed this review request and I've just seen
expensive when X11 is the only
platform that provides a certain functionality ... :)
(I do seem to recall that using function pointers instead of normal
functions was hardly more expensive on x86)
Yichao Yu wrote:
Sorry somehow my filter missed this review request and I've just seen
.
Tested with systemsettings in the following conditions:
1. single row in each category.
2. multiple rows in each category.
3. scrollbar not at the top.
Thanks,
Yichao Yu
://git.reviewboard.kde.org/r/113969/#review55062
---
On April 22, 2014, 6:13 a.m., Yichao Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
conditions:
1. single row in each category.
2. multiple rows in each category.
3. scrollbar not at the top.
Thanks,
Yichao Yu
On Nov. 20, 2013, 5:27 p.m., Christoph Feck wrote:
I love people who report bugs, and one year later come up with a patch :P
Anyway, nice analysis, and this probably also fixes bug 290971, but have
not tested it yet.
Yichao Yu wrote:
Unfortunately I think I can still reproduce
---
On Nov. 30, 2013, 2:55 p.m., Yichao Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114219
changes).
Diffs
-
kcontrol/krdb/krdb.cpp 92d84e9
Diff: http://git.reviewboard.kde.org/r/114219/diff/
Testing
---
Compiles.
Fixes the problem here.
Also fixes the problem for the reporter.
Thanks,
Yichao Yu
Diff: http://git.reviewboard.kde.org/r/114219/diff/
Testing (updated)
---
Compiles.
Fixes the problem here.
Also fixes the problem for the reporter.
Thanks,
Yichao Yu
://git.reviewboard.kde.org/r/114219/diff/
Testing
---
Compiles.
Waiting for bug reporter's test.
Thanks,
Yichao Yu
: classified
#8: classified
#9: classified
#a: classified
Yichao Yu wrote:
encodeName/toLocal8Bit is used to encode a unicode string to a
c-string/byte-array representation and decodeName/fromLocal8Bit does the
reverse.
The proper decoding is already done in QFile
/itemviews/kcategorizedview.cpp 010bcbc
Diff: http://git.reviewboard.kde.org/r/113985/diff/
Testing
---
It compiles.
(It compiles when just adding const to the QRect, proving they are indeed
no-op's).
Thanks,
Yichao Yu
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113985/#review44451
---
On Nov. 21, 2013, 8:34 p.m., Yichao Yu wrote:
---
This is an automatically
conditions:
1. single row in each category.
2. multiple rows in each category.
3. scrollbar not at the top.
Thanks,
Yichao Yu
. multiple rows in each category.
3. scrollbar not at the top.
Thanks,
Yichao Yu
, proving they are indeed
no-op's).
Thanks,
Yichao Yu
conditions:
1. single row in each category.
2. multiple rows in each category.
3. scrollbar not at the top.
Thanks,
Yichao Yu
conditions:
1. single row in each category.
2. multiple rows in each category.
3. scrollbar not at the top.
Thanks,
Yichao Yu
, 2013, 4:47 p.m., Yichao Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113969/
---
(Updated Nov. 20, 2013, 4:47 p.m
::ActionReply)),
lambda reply: callback(reply.succeeded()))
action.setExecutesAsync(True)
reply = action.execute()
if reply.failed():
return False
return True
Thanks,
Yichao Yu
()))
action.setExecutesAsync(True)
reply = action.execute()
if reply.failed():
return False
return True
Thanks,
Yichao Yu
Weng.
Thanks,
Yichao Yu
Lübking, Chao Feng,
and Yichao Yu.
Description
---
Set minimum width for system settings icon view item depending on font. Since
KFileItemDelegate doesn't provides setMinimumSize, we make a sub-class that
can have a minimumSize. (Maybe should be add to kdelibs in the future
/desktop/applets/pager/pager.cpp 70d1b55
Diff: http://git.reviewboard.kde.org/r/108340/diff/
Testing
---
Compiled and see screen shots.
Screenshots
---
Before
http://git.reviewboard.kde.org/r/108340/s/1024/
After
http://git.reviewboard.kde.org/r/108340/s/1025/
Thanks,
Yichao Yu
, pager and icontasks shows minimized windows correctly.
Thanks,
Yichao Yu
minimized windows correctly.
Thanks,
Yichao Yu
Weng.
Thanks,
Yichao Yu
On Jan. 9, 2013, 10:09 a.m., Ben Cooksley wrote:
systemsettings/icons/IconMode.cpp, line 183
http://git.reviewboard.kde.org/r/108285/diff/1/?file=106110#file106110line183
Not sure I like the idea of a hardcoded list of languages... is there a
better way of determining if a
if a language is CJK?
Christoph Feck wrote:
CJK is actually naming the languages which use CJK, so the list is
hardcoded by definition.
Yichao Yu wrote:
I guess the question is not which languages are CJK but which
languages have this problem.
Plus, there may be english text even when
/windowmanagement/kwindowinfo_x11.cpp d983c9a
Diff: http://git.reviewboard.kde.org/r/108308/diff/
Testing
---
Compiled, pager and icontasks shows minimized windows correctly.
Thanks,
Yichao Yu
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108308/#review25103
---
On Jan. 9, 2013, 9:06 p.m., Yichao Yu wrote
13497bf
Diff: http://git.reviewboard.kde.org/r/107829/diff/
Testing
---
Compiled kdelibs as well as program that has problem (kontact) and the signal
is triggered correctly.
Thanks,
Yichao Yu
Diff: http://git.reviewboard.kde.org/r/107829/diff/
Testing
---
Compiled kdelibs as well as program that has problem (kontact) and the signal
is triggered correctly.
Thanks,
Yichao Yu
is triggered correctly.
Thanks,
Yichao Yu
---
Compiled kdelibs as well as program that has problem (kontact) and the signal
is triggered correctly.
Thanks,
Yichao Yu
41 matches
Mail list logo
