Re: Review Request 122471: Enable Compilation of about Protocol

2015-02-08 Thread David Faure
On Feb. 8, 2015, 9:19 a.m., Laurent Montel wrote: about/kio_about.cpp, line 59 https://git.reviewboard.kde.org/r/122471/diff/1/?file=347423#file347423line59 QApplication app(argc, argv); app.setApplicationName(QLatin1String(kio_about)); = you remove

Re: Review Request 122471: Enable Compilation of about Protocol

2015-02-08 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122471/#review75584 --- about/kio_about.cpp

Re: Review Request 122471: Enable Compilation of about Protocol

2015-02-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122471/#review75586 --- What Laurent said, plus a bug in the commit log: you ported

Re: Review Request 122471: Enable Compilation of about Protocol

2015-02-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122471/#review75619 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 7, 2015,

Re: Review Request 122471: Enable Compilation of about Protocol

2015-02-08 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122471/ --- (Updated Feb. 9, 2015, 6:03 a.m.) Review request for kde-workspace and

Re: Review Request 122471: Enable Compilation of about Protocol

2015-02-08 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122471/#review75657 --- Seems good. Did you changed commit message as David told you

Review Request 122471: Enable Compilation of about Protocol

2015-02-07 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122471/ --- Review request for kde-workspace and David Faure. Repository: kio-extras