Re: splitting up kdebase in git

2011-02-13 Thread Luigi Toscano
Tom Albers wrote: - Original Message - On Saturday, February 12, 2011 19:12:41 Tom Albers wrote: - Original Message - Hi, Our default wallpapers used to be part of kdebase/workspace, but during the git migration they've been removed from workspace due the size of that

Review Request: Add missing dependency to xmllint

2011-06-20 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101707/ --- Review request for kdelibs and Sune Vuorela. Summary --- This patch

Re: Review Request: Add missing dependency to xmllint

2011-06-21 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101707/ --- (Updated June 21, 2011, 7:21 p.m.) Review request for Build System,

Review Request: Fix docs generation with docbook-xslt = 1.76

2011-06-27 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101791/ --- Review request for kdelibs, Burkhard Lück, Rex Dieter, and Albert Astals

Re: Use of bin versus libexec

2012-09-20 Thread Luigi Toscano
David Faure wrote: On Thursday 20 September 2012 19:36:39 Sune Vuorela wrote: On 2012-09-20, Kevin Krammer kram...@kde.org wrote: Do you mean $PREFIX/libexec, where $PREFIX will often be /usr (for=20 distribution packages)? that only works in redhat/fedora land. In other distributiotns, like

Re: [RFC] Solution for duplicated or false review/bug notifications

2012-11-02 Thread Luigi Toscano
Jaroslaw Staniek wrote: tl;dr I propose to treat public KDE git branches (for all repos) having '-work' suffix in a special way: ignore REVIEW and BUG/CCBUG lines. When commit hits a public KDE git branch without -work suffix, current behaviour is preserved. ** The problem: Whenever

Re: [Kde-pim] Boost vs cmake 2.8.8 vs kdepimlibs master

2012-12-16 Thread Luigi Toscano
Albert Astals Cid wrote: El Diumenge, 16 de desembre de 2012, a les 23:53:23, Antonis Tsiapaliokas va escriure: Hello, Attached, can somebody give it a try ? Alex I have test the attached patch with 2.8.8 cmake and it doesn't work. With the 2.8.9 cmake, the issues is solved, without the

Re: New lockscreen

2013-01-11 Thread Luigi Toscano
On Friday 11 of January 2013 10:28:22 Martin Gräßlin wrote: the implementation has been kept there AFAIK because people complain that we wanted to remove it. It would be nice if the people who want to have the old screen savers would step up to support the maintenance. Yes it would have been

Re: Plans for SVN infrastructure shutdown

2013-01-20 Thread Luigi Toscano
Ben Cooksley wrote: On Sat, Jan 5, 2013 at 10:45 AM, Oswald Buddenhagen o...@kde.org wrote: On Wed, Jan 02, 2013 at 06:52:32PM -0300, Nicolás Alvarez wrote: http://community.kde.org/Sysadmin/SVNInfrastructureShutdown Hi Oswald, this whole thing ignores that svn is still simply the better

Re: Plans for SVN infrastructure shutdown

2013-01-20 Thread Luigi Toscano
Ben Cooksley wrote: On Sat, Jan 12, 2013 at 2:28 AM, Oliver Henshaw oliver.hens...@gmail.com wrote: On 4 January 2013 10:31, David Faure fa...@kde.org wrote: The plan seems OK, except for the very last step, final shutdown. Please keep svn.kde.org around, readonly. [...] so if we could just

Re: Password strengh meter in KNewPasswordDialog

2013-04-03 Thread Luigi Toscano
Rolf Eike Beer wrote: So, yes, you are absolutely right. Suggestions about how to improve that absolutely welcome. Have you seen this? https://fedorahosted.org/libpwquality/ https://fedoraproject.org/wiki/Features/PasswordQualityChecking Ciao -- Luigi

Re: Password strengh meter in KNewPasswordDialog

2013-04-10 Thread Luigi Toscano
On Thursday 04 of April 2013 11:52:09 Martin Sandsmark wrote: On Thu, Apr 04, 2013 at 01:02:21AM +0200, Luigi Toscano wrote: Have you seen this? https://fedorahosted.org/libpwquality/ https://fedoraproject.org/wiki/Features/PasswordQualityChecking It doesn't contain any docs about how

Re: Techbase: schedules for playground and extragear

2013-06-05 Thread Luigi Toscano
Albert Astals Cid wrote: El Dimarts, 4 de juny de 2013, a les 23:35:17, Sven Brauch va escriure: If there are no objections, I'd remove the two pages mentioned above by the end of the week. What do you think? I think I found those pages recently too, and I'm all for deleting them. They will

Re: Review Request 111054: allow imageobjectco to be used in KDE Documentation

2013-06-17 Thread Luigi Toscano
in DocBook 4.x, can be included by mediaobjectco, which is not ignored but required for the maps. The patch removes the imageobjectco.module from the set of ignored modules, so go for it. Is it for master? - Luigi Toscano On June 17, 2013, 2:12 a.m., T.C. Hollingsworth wrote

Re: Review Request 111054: allow imageobjectco to be used in KDE Documentation

2013-06-17 Thread Luigi Toscano
On June 17, 2013, 9:24 p.m., Luigi Toscano wrote: imageobjectco, supported since the Paleolitic age in DocBook 4.x, can be included by mediaobjectco, which is not ignored but required for the maps. The patch removes the imageobjectco.module from the set of ignored modules, so go

Re: Review Request 111054: allow imageobjectco to be used in KDE Documentation

2013-06-17 Thread Luigi Toscano
On June 17, 2013, 9:24 p.m., Luigi Toscano wrote: imageobjectco, supported since the Paleolitic age in DocBook 4.x, can be included by mediaobjectco, which is not ignored but required for the maps. The patch removes the imageobjectco.module from the set of ignored modules, so go

Re: Releases in 3 months

2013-07-08 Thread Luigi Toscano
On Monday 08 of July 2013 15:04:40 Àlex Fiestas wrote: Now that kde-workspace and kdelibs are going to be frozen (which in theory means less work for everybody) I'd like to propose a new release schedule to be applied starting with 4.12. Basically the idea is to cut testing time and

Re: Releases in 3 months

2013-07-08 Thread Luigi Toscano
On Monday 08 of July 2013 18:09:44 Àlex Fiestas wrote: On Monday 08 July 2013 17:45:10 Philip Muskovac wrote: I understand that we can have additional point releases if people still find issues that need to be fixed, but with so many short release cycles I expect that the attention for the

Re: Releases in 3 months

2013-07-10 Thread Luigi Toscano
On Wednesday 10 of July 2013 18:08:04 Àlex Fiestas wrote: On Wednesday 10 July 2013 13:22:20 Sune Vuorela wrote: On 2013-07-09, Sune Vuorela nos...@vuorela.dk wrote: So. first one. Second one Release frequency. We have a giant quality problem. Distros won't ship a .0 release

Re: Releases in 3 months

2013-07-10 Thread Luigi Toscano
On Wednesday 10 of July 2013 17:43:38 Àlex Fiestas wrote: On Tuesday 09 July 2013 21:57:51 Alexander Neundorf wrote: On Tuesday 09 July 2013, Sven Brauch wrote: I think Nuno's point is very interesting and worth thinking about. To stick with the firefox example, since they started

Re: Releases in 3 months

2013-07-10 Thread Luigi Toscano
On Wednesday 10 of July 2013 19:17:37 Luigi Toscano wrote: The more you go down in the stack, the more you need stability, and no, it's not true that with short release time the features will be smaller with less bugs, because a feature could have been in development for a long time, so it's

Re: Releases in 3 months

2013-07-16 Thread Luigi Toscano
Aaron J. Seigo wrote: translations .. this will require some time spent with the translation maintainers to figure out what will work well for those efforts. The risk here is that when branches which have been in preparation for a long time are merged, or simply many branches are merged, the

Review Request 113218: Enable translation functions for js script loaded through Kross

2013-10-12 Thread Luigi Toscano
--- It compiles, and qsTr is recognized when loading the scripts in kmail. Thanks, Luigi Toscano

Re: Review Request 113218: Enable translation functions for js script loaded through Kross

2013-10-14 Thread Luigi Toscano
/main.cpp 041c306 Diff: http://git.reviewboard.kde.org/r/113218/diff/ Testing --- It compiles, and qsTr is recognized when loading the scripts in kmail. Thanks, Luigi Toscano

Re: Moving KScreen and libkscreen to extragear

2013-11-13 Thread Luigi Toscano
Ben Cooksley wrote: Hi all, Based on Alex's request, I have now moved libkscreen and kscreen to their relevant locations in Extragear. If there are any objections, please let me know. Translations moved as well: http://websvn.kde.org/?view=revisionrevision=1369681 Ciao -- Luigi

Re: KF5 Update Meeting Minutes 2014-w4

2014-01-21 Thread Luigi Toscano
On Tuesday 21 of January 2014 16:42:42 Kevin Ottens wrote: * tosky found out that the validity of the qtoptions and kdeoptions man pages is in need of review; * he's also working with the doc team toward a switch to docbook 4.2; Quick patch: to docbook 4.5 (our documentation is based on 4.2

Review Request 116604: Allow directories with . as output for meinproc

2014-03-04 Thread Luigi Toscano
) with -o /something/with/a/.dotdir/myfile.txt (the directory must exist), no error anymore and the file is generated. Thanks, Luigi Toscano

Re: Review Request 116604: Allow directories with . as output for meinproc

2014-03-06 Thread Luigi Toscano
: https://git.reviewboard.kde.org/r/116604/#review52091 --- On March 5, 2014, 1:06 a.m., Luigi Toscano wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 116604: Allow directories with . as output for meinproc

2014-03-08 Thread Luigi Toscano
Diff: https://git.reviewboard.kde.org/r/116604/diff/ Testing --- Run meinproc5 (and 4) with -o /something/with/a/.dotdir/myfile.txt (the directory must exist), no error anymore and the file is generated. Thanks, Luigi Toscano

Re: Final kde-runtime splitting plan

2014-03-25 Thread Luigi Toscano
Àlex Fiestas ha scritto: Hi there Today Aleix and I are starting to split kde-runtime so we have gone through all the components again making sure that everything has a suitable destination. The result is this [1] wiki. Please, check that you are ok with the destination of each

Re: KDE Frameworks Release Cycle

2014-05-04 Thread Luigi Toscano
Kevin Ottens ha scritto: So, we had a team discussion here with Albert, Aleix, Alex, Alex, Aurélien, David, Rohan and myself. We juggled with several options, trying to address the following constraints: * We don't have many contributors; * We don't have enough testing in the stable

Re: Pushing AppStream upstream metadata to KDE repositories...?

2014-05-10 Thread Luigi Toscano
Matthias Klumpp ha scritto: Therefore, I would like to ask for feedback on the following proposal: * We announce the availability of the new metadata somewhere, so that the individual maintainers know that the data is coming, and that they may want to take a look at it when it landed in their

Review Request 118270: [doc] explicitly load external entities (after CVE-2014-0191)

2014-05-22 Thread Luigi Toscano
a7265ca Diff: https://git.reviewboard.kde.org/r/118270/diff/ Testing --- meinproc4 works again Thanks, Luigi Toscano

Re: Review Request 118270: [doc] explicitly load external entities (after CVE-2014-0191)

2014-05-23 Thread Luigi Toscano
, and if possible with KF5 as well? Diffs - kdoctools/meinproc.cpp 0894d63 kdoctools/xslt.cpp a7265ca Diff: https://git.reviewboard.kde.org/r/118270/diff/ Testing --- meinproc4 works again Thanks, Luigi Toscano

Re: Review Request 118270: [doc] explicitly load external entities (after CVE-2014-0191)

2014-05-30 Thread Luigi Toscano
://git.reviewboard.kde.org/r/118270/diff/ Testing --- meinproc4 works again Thanks, Luigi Toscano

Re: Review Request 118270: [doc] explicitly load external entities (after CVE-2014-0191)

2014-06-03 Thread Luigi Toscano
it with a fixed libxml and without, and if possible with KF5 as well? Diffs - kdoctools/meinproc.cpp 0894d63 kdoctools/xslt.cpp a7265ca Diff: https://git.reviewboard.kde.org/r/118270/diff/ Testing --- meinproc4 works again Thanks, Luigi Toscano

Re: Review Request 118270: [doc] explicitly load external entities (after CVE-2014-0191)

2014-06-04 Thread Luigi Toscano
libxml and without, and if possible with KF5 as well? Diffs - kdoctools/meinproc.cpp 0894d63 kdoctools/xslt.cpp a7265ca Diff: https://git.reviewboard.kde.org/r/118270/diff/ Testing --- meinproc4 works again Thanks, Luigi Toscano

Re: Fwd: Re: Duplicate nm translations into SVN repo

2014-06-14 Thread Luigi Toscano
Hi all, I was trying to figure out where to move translations of plasma-nm (the new one) now that it's out of kdereview, and I realized that it should land in two different namespace for the kf5 version (already in kde/workspace) and kdelibs4 (where kde/workspace is not available). A bit of

Re: Review Request 119363: Patch for kde-baseapps to make it build on the OSX/CI system

2014-07-19 Thread Luigi Toscano
in the other lines, as this is not real a fix but a workaround). - Luigi Toscano On Lug. 19, 2014, 2:09 p.m., Marko Käning wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119363

Review Request 119446: Add a simple test for meinproc

2014-07-23 Thread Luigi Toscano
: https://git.reviewboard.kde.org/r/119446/diff/ Testing --- Compilation of kdelibs and few modules with documentation. Thanks, Luigi Toscano

Review Request 119447: meinproc: check both result of parsing and validation

2014-07-23 Thread Luigi Toscano
, Luigi Toscano

Re: Review Request 119446: Add a simple test for meinproc

2014-07-24 Thread Luigi Toscano
to KDocTools/KF5. Diffs (updated) - kdoctools/CMakeLists.txt 4dc6d8a kdoctools/tests/CMakeLists.txt PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119446/diff/ Testing --- Compilation of kdelibs and few modules with documentation. Thanks, Luigi Toscano

Re: Review Request 119447: meinproc: check both result of parsing and validation

2014-07-24 Thread Luigi Toscano
/diff/ Testing --- Compilation of kdelibs and few modules with documentation. Thanks, Luigi Toscano

Re: Review Request 119446: Add a simple test for meinproc

2014-07-24 Thread Luigi Toscano
- kdoctools/CMakeLists.txt 4dc6d8a kdoctools/tests/CMakeLists.txt PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119446/diff/ Testing --- Compilation of kdelibs and few modules with documentation. Thanks, Luigi Toscano

Re: Review Request 119363: Port kde-baseapps to use docbook 4.5

2014-08-24 Thread Luigi Toscano
://git.reviewboard.kde.org/r/119363/ --- (Updated Lug. 20, 2014, 12:08 a.m.) Review request for KDE Base Apps, Luigi Toscano and Nicolás Alvarez. Repository: kde-baseapps Description --- This suggests to upgrade the docbook

Re: Review Request 119363: Port kde-baseapps to use docbook 4.5

2014-08-24 Thread Luigi Toscano
then, but he had some arguments against it at the time. Let's see what he thinks now, as I don't want to override him there. Luigi Toscano wrote: I don't find the discussion but I think I wrote something on the line of: let's see if it can be made working without this, because

Re: Review Request 119363: Port kde-baseapps to use docbook 4.5

2014-09-04 Thread Luigi Toscano
then, but he had some arguments against it at the time. Let's see what he thinks now, as I don't want to override him there. Luigi Toscano wrote: I don't find the discussion but I think I wrote something on the line of: let's see if it can be made working without this, because

Re: Review Request 119363: Port kde-baseapps to use docbook 4.5

2014-09-06 Thread Luigi Toscano
then, but he had some arguments against it at the time. Let's see what he thinks now, as I don't want to override him there. Luigi Toscano wrote: I don't find the discussion but I think I wrote something on the line of: let's see if it can be made working without this, because

Re: Review Request 120281: Use the correct locale

2014-09-19 Thread Luigi Toscano
of distributions support it, but not all: https://bugzilla.redhat.com/show_bug.cgi?id=902094 https://sourceware.org/bugzilla/show_bug.cgi?id=17318 - Luigi Toscano On Set. 19, 2014, 1:18 p.m., Maximiliano Curia wrote

Re: Muon and kde-gtk-config moved to kde/workspace - was - Re: Moving repositories in the module structure

2014-10-08 Thread Luigi Toscano
Aleix Pol ha scritto: On Wed, Oct 8, 2014 at 9:59 PM, Albert Astals Cid aa...@kde.org mailto:aa...@kde.org wrote: El Dimecres, 8 d'octubre de 2014, a les 21:02:32, Aleix Pol va escriure: On Tue, Oct 7, 2014 at 3:13 PM, Thomas Pfeiffer thomas.pfeif...@kde.org

Re: kdelibs coding style.

2014-10-09 Thread Luigi Toscano
Jeremy Whiting ha scritto: Are we suggesting the opposite for that section at least? Should we put together a Frameworks coding policy (since kdelibs coding policy is what is documented there, but frameworks aren't kdelibs) or update that page to what we suggest for frameworks coding policy?

Re: Review Request 120210: kdoctools: style images more elegantly

2014-10-22 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120210/#review68920 --- Ship it! Ship It! - Luigi Toscano On Sept. 16, 2014, 3:15

Re: Review Request 120154: Equal entries implies existing directory

2014-11-23 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120154/#review70820 --- Which branch has the patch been submitted to? - Luigi

Re: [Kde-pim] Problems with infrastructure

2014-12-10 Thread Luigi Toscano
Albert Astals Cid ha scritto: I see some problems with gerrit: [...] D) There's no way to create a review without using relatively unfriendly gerrit process [...] D is really important to me since it makes it harder to contribute to non hardcore git users; it took me days to

Re: kdepimlibs splitting done

2014-12-12 Thread Luigi Toscano
Il 12 dicembre 2014 05:19:00 CET, Aleix Pol aleix...@kde.org ha scritto: Hi, I have performed the first round of kdepimlibs splitting tonight, as we agreed. Below you can see the for reference how the splitting was performed. Dan, Laurent, can you give me the ok? Then we can proceed to

Re: kruler master is now based on KF5

2014-12-17 Thread Luigi Toscano
Christoph Feck ha scritto: frameworks branch can be deleted. Please rewire CI, translations or whatever else is needed. (cc for kde-i18n-doc@) i18n hopefully fixed (please check): http://websvn.kde.org/?view=revisionrevision=1409082 Ciao -- Luigi

Re: Plasma 5.2 bits for kdereview

2014-12-19 Thread Luigi Toscano
Jonathan Riddell ha scritto: Plasma 5.2 is due out next month and there's a few KDE projects which would be good to be included. Please review these for inclusion in kde/workspace.. Bluedevil frameworks branch by David Rosca https://projects.kde.org/projects/extragear/base/bluedevil

Re: Plasma 5.2 bits for kdereview

2014-12-23 Thread Luigi Toscano
Daniel Vrátil ha scritto: On Friday, December 19, 2014 06:46:11 PM Luigi Toscano wrote: Jonathan Riddell ha scritto: Plasma 5.2 is due out next month and there's a few KDE projects which would be good to be included. Please review these for inclusion in kde/workspace.. kscreen

Re: Plasma 5.2 bits for kdereview

2014-12-23 Thread Luigi Toscano
Sebastian Kügler ha scritto: On Friday, December 19, 2014 18:46:11 Luigi Toscano wrote: kscreen and libkscreen maintained by Dan Vrátil. libkscreen is already released with Plasma but isn't in kde/workspace. https://projects.kde.org/projects/extragear/libs/libkscreen https

Re: Plasma 5.2 bits for kdereview

2015-01-01 Thread Luigi Toscano
Jonathan Riddell ha scritto: polkit-kde already requested on this list http://thread.gmane.org/gmane.comp.kde.devel.general/68224/focus=85357 This has been moved, but master is still kdelibs4-based. - Is it going to change? - Is there a final kdelibs4-based branch that can be tracked for the

Re: LibRingClient has moved to extragear/network

2015-02-04 Thread Luigi Toscano
Elv1313 . ha scritto: Hi, After going through kdereview for the last few weeks, libringclient (formerly the sflphone-kde client logic library) is now moving to KDE extragear. I am currently starting to remove the legacy Qt4 support still required by the KDE4 client (and porting it to kf5)

Re: [kcalc][kcharselect][kcron] Merged frameworks branch to master, now KF5 based

2015-01-27 Thread Luigi Toscano
Christoph Feck ha scritto: Hi, I just merged the frameworks KF5 porting branches of the following applications to master branch: - kcalc - kcharselect - kcron These applications will be released as KF5 applications for the KDE Applications 15.03 release. Please check if

Re: Plasma 5.2 bits for kdereview

2015-01-06 Thread Luigi Toscano
Jonathan Riddell ha scritto: Updates on this.. I plan to ask for Bluedevil and libbluedevil, libkscreen and kscreen, libmm-qt and ksshaskpass to be moved. I see some comments that the libraries may be used outside of Plasma but there's no problem with that happening, they don't quality for

Re: Plasma 5.2 bits for kdereview

2015-01-08 Thread Luigi Toscano
David Edmundson ha scritto: On Thu, Jan 8, 2015 at 5:54 PM, Luigi Toscano luigi.tosc...@tiscali.it mailto:luigi.tosc...@tiscali.it wrote: Jonathan Riddell ha scritto: On Thu, Jan 08, 2015 at 07:33:58AM -0200, Lamarque Souza wrote: Regarding ModemManagerQt, libbluedevil

Re: Plasma 5.2 bits for kdereview

2015-01-08 Thread Luigi Toscano
Jonathan Riddell ha scritto: On Thu, Jan 08, 2015 at 07:33:58AM -0200, Lamarque Souza wrote: Regarding ModemManagerQt, libbluedevil, libkscreen and baloo, they are supposed to be frameworks stuff (not sure about baloo) but they are not ready yet. Why not created a frameworks-next

Re: Fwd: Plasma 5.2 bits for kdereview

2015-01-07 Thread Luigi Toscano
Jonathan Riddell ha scritto: On 6 January 2015 at 15:23, Luigi Toscano luigi.tosc...@tiscali.it mailto:luigi.tosc...@tiscali.it wrote: Jonathan Riddell ha scritto: Updates on this.. I plan to ask for Bluedevil and libbluedevil, libkscreen and kscreen, libmm-qt

Re: Review Request 122652: Use correct default value when UDS_ACCESS/UDS_FILE_TYPE is not set

2015-03-16 Thread Luigi Toscano
://quickgit.kde.org/?p=kio.git Luigi Toscano wrote: kdelibs 4.14 still receives fixes and it's released with KDE Applications (at least as long as we have kdelibs4-based applications). So, if it fixes a bug, it can go in. Of course it should be forward-ported to KIO Framework

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

2015-03-17 Thread Luigi Toscano
if this is still relevant for the Sonnet framework? - Luigi Toscano On March 17, 2015, 1:22 p.m., Eugene Shalygin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122987

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

2015-03-17 Thread Luigi Toscano
On March 17, 2015, 1:41 p.m., Luigi Toscano wrote: (not entitled to give a ship it, but) have you checked if this is still relevant for the Sonnet framework? Ups, this review is for sonnet; I was confused by the group (please use kdeframeworks instead of kdelibs for Frameworks-related

Re: Review Request 119363: Port kde-baseapps to use docbook 4.5

2015-02-28 Thread Luigi Toscano
time. The encoding issue has been addressed in the following two reviews: * kdoctools: https://git.reviewboard.kde.org/r/120648/ * kdelibs4support: https://git.reviewboard.kde.org/r/120649/ which are now pushed and closed. So this review can be closed. - Luigi Toscano On Aug. 24, 2014, 6:33

Re: Review Request 122812: Fix BIC introduced in kdelibs 4

2015-03-04 Thread Luigi Toscano
On March 4, 2015, 10:19 p.m., Albert Astals Cid wrote: Given the BIC change is already part of 4.14.6 i'd say we just ignore it, it's not like anyone cares for that symbol, right? Is it already out? If not, no way to skip 4.14.6 or mark it as don't use it for distributions (or tell them

Re: Review Request 122812: Fix BIC introduced in kdelibs 4

2015-03-04 Thread Luigi Toscano
On March 4, 2015, 10:19 p.m., Albert Astals Cid wrote: Given the BIC change is already part of 4.14.6 i'd say we just ignore it, it's not like anyone cares for that symbol, right? Luigi Toscano wrote: Is it already out? If not, no way to skip 4.14.6 or mark it as don't use

Re: Review Request 122652: Use correct default value when UDS_ACCESS/UDS_FILE_TYPE is not set

2015-02-25 Thread Luigi Toscano
On Feb. 25, 2015, 6:57 p.m., Mark Gaiser wrote: I think this is OK, but just don't know. Anyway, your diff is for kdelibs (KDE SC 4.xx). I don't know if that gets another release. Either way, KIO frameworks [1] is where this should be applied to when you get a ship it. [1]

Re: Distros and QtWebEngine

2015-04-20 Thread Luigi Toscano
Milian Wolff ha scritto: I'm not a KDE PIM maintainer, but with my KDevelop hat on (that uses a web view to display documentation pages, currently QtWebKit), kio_man uses khtml (why don't you use it)? But anyway, also khtml is deprecated. On the other side, the html for manpages is pretty

Re: kwallet-query moved to kdereview

2015-04-23 Thread Luigi Toscano
Valentin Rusu ha scritto: * Allen Winter allen.d.win...@gmail.com [2015-04-23 17:32:32 -0400]: On Thursday, April 23, 2015 10:25:20 PM Valentin Rusu wrote: This is a rather simple script and I think it should go to kde-utils. I'd like to write a manpage for it, buy AFAICT that's not the KDE

Re: Distros and QtWebEngine

2015-04-20 Thread Luigi Toscano
Albert Astals Cid ha scritto: El Dilluns, 20 d'abril de 2015, a les 15:52:12, Lisandro Damián Nicanor Pérez Meyer va escriure: I could also say that Fedora+Debian+Debian derivatives (Ubuntu is mostly in the same position as us) is also a large userbase for KDE to loose. But *it's not

Re: Review Request 123458: Improvements to the handling of font weights and styles

2015-04-21 Thread Luigi Toscano
On April 22, 2015, 12:40 a.m., Luigi Toscano wrote: I think this should go to Qt (I think it's quite difficult they will accept it, as Qt4 is in hard freeze mode), and they will probably ask to see if it applies to Qt5 as well. We just mirror Qt... not sure how to handle this. Yes, I

Re: Review Request 123458: Improvements to the handling of font weights and styles

2015-04-21 Thread Luigi Toscano
they will accept it, as Qt4 is in hard freeze mode), and they will probably ask to see if it applies to Qt5 as well. We just mirror Qt... not sure how to handle this. - Luigi Toscano On April 22, 2015, 12:06 a.m., René J.V. Bertin wrote

Re: Distros and QtWebEngine

2015-04-20 Thread Luigi Toscano
Jan Kundrát ha scritto: On Monday, 20 April 2015 21:14:51 CEST, Sune Vuorela wrote: And Red Hat is following Fedora. RHEL might not be a good example here because they are a rather a strange beast. RHEL has actually never shipped QtWebKit (!) and they also aren't shipping Qt5 so far. Just

Re: Moving KDots to KDE Review

2015-04-05 Thread Luigi Toscano
Minh Ngo ha scritto: Hi folks, I would like to move my project [1] to KDE Reviews and receive some feedback to make it become a part of the KDEGames project in prospect. According to the wiki article [2] I have to contact with sysadmins and post this message in this mail list. Few points

Re: Frameworks compiler and Qt requirements after Qt 5.7?

2015-06-26 Thread Luigi Toscano
On Friday 26 of June 2015 16:24:50 Mark Gaiser wrote: Hi, If Qt's plans progress according to what they post on the mailinglist then Qt 5.6 will be LTS, 5.7 will up the compiler requirements to the following: GCC 4.7 Clang 3.2 MSVC 2012 Framework currently requires: GCC 4.5 Clang

Re: kwallet-query moved to kdereview

2015-06-14 Thread Luigi Toscano
Valentin Rusu ha scritto: The kwallet-query tool is now part of KF5::Wallet. I'll now request kdereview/kwallet-query repository removal. src/runtime/kwallet-query/src/querydriver.cpp:153:47: error: ‘class QByteArray’ has no member named ‘toStdString’ std::cout

Review Request 124657: Show URL again in bookmarks view and URL texbox

2015-08-07 Thread Luigi Toscano
e949469 Diff: https://git.reviewboard.kde.org/r/124657/diff/ Testing --- Compiled, executed the bookmark editor. Added and changed few bookmarks, the URL is correctly updated. Thanks, Luigi Toscano

Re: Review Request 124657: Show URL again in bookmarks view and URL texbox

2015-08-07 Thread Luigi Toscano
) - keditbookmarks/bookmarkinfowidget.cpp 98ce303 keditbookmarks/kbookmarkmodel/model.cpp e949469 Diff: https://git.reviewboard.kde.org/r/124657/diff/ Testing --- Compiled, executed the bookmark editor. Added and changed few bookmarks, the URL is correctly updated. Thanks, Luigi

Re: Review Request 124657: Show URL again in bookmarks view and URL texbox

2015-08-08 Thread Luigi Toscano
marked as submitted. Review request for KDE Base Apps and David Faure. Changes --- Submitted with commit 64e8b30cf24623c52595efca3f57bc776c5ca188 by Luigi Toscano to branch frameworks. Repository: kde-baseapps Description --- Fix two KUrl porting TODO items. Thanks to the porting

Re: Using nullptr instead of Q_NULLPTR

2015-08-13 Thread Luigi Toscano
On Thursday 13 of August 2015 12:59:01 Ivan Čukić wrote: I prefer the first option, it's the way forward and if someone was using I'd say that requiring a newer gcc just like that would go against the nature of the KF5 project. I don't really see why it is against the nature of KF5. It

Re: Using nullptr instead of Q_NULLPTR

2015-08-13 Thread Luigi Toscano
On Thursday 13 of August 2015 15:01:16 Ivan Čukić wrote: What I don't like in this story is that we set up a rule, an promise with users, which was broken and now it's like it does not matter. Yes, we did set up the rule requirements for gcc 4.5 and MSVC10 back in 2013. Since then, we

Re: Bringing back rsibreak from unmaintained

2015-08-18 Thread Luigi Toscano
Jan Kundrát ha scritto: On Monday, 17 August 2015 20:04:04 CEST, Albert Astals Cid wrote: Other comments? Nice, happy to see it -- it builds here, with a bunch of warnings: [2/29] Generating index.cache.bz2 index.docbook:2: element para: validity error : ID gnu-fdl already defined

Re: kdesudo in git

2015-08-20 Thread Luigi Toscano
On Thursday 20 of August 2015 11:48:25 Jonathan Riddell wrote: On Thu, Aug 20, 2015 at 01:34:42PM +0200, Luigi Toscano wrote: On Thursday 20 of August 2015 12:16:55 Jonathan Riddell wrote: I've just moved kdesudo into playground playground/utils/kdesudo it has a bunch

Re: kdesudo in git

2015-08-20 Thread Luigi Toscano
On Thursday 20 of August 2015 12:16:55 Jonathan Riddell wrote: I've just moved kdesudo into playground playground/utils/kdesudo it has a bunch of translations from its previous home on Launchpad. Could these be imported into KDE please? Do we really need it? I thought that kdesu can

Re: [kde-doc-english] The new data dirs and kf5 docs

2015-08-20 Thread Luigi Toscano
On Thursday 20 of August 2015 14:46:45 Yuri Chornoivan wrote: Hi, Hi, CC: kde-core-devel@ for some help (see below). As it was pointed by Burkhard [1], the paths in kf5 docs should be updated/fixed to the new configuration. The list is rather big now: fundamentals/config.docbook

Re: Review Request 124824: [OS X] FindKDE4Internal.cmake : reintroduce a cmake_minimum_required statement

2015-08-21 Thread Luigi Toscano
On Ago. 19, 2015, 8:06 p.m., Stephen Kelly wrote: This patch is not correct. What repo were you trying to build? Add cmake_minimum_required(VERSION 2.8.9) there. Stephen Kelly wrote: Why did this review go quiet? Did you pull and realize that line was already there in

Notes from the Phabricator BoF

2015-07-30 Thread Luigi Toscano
Hi all, thanks to Victor Blazquez, here are the notes from the Phabricator BoF. Feel free to add your comments and corrections. Feedback on Phabricator gathered outside the BoF from people who could not attend: -

Re: Notes from the Phabricator BoF

2015-07-30 Thread Luigi Toscano
Il 30 luglio 2015 22:42:44 CEST, Kevin Kofler kevin.kof...@chello.at ha scritto: Luigi Toscano wrote: Feedback on Phabricator gathered outside the BoF from people who could not attend: Were there no complaints about the fact that you can still not view anything at all without logging

Re: Plasma Applet for Audio Volume for kdereview

2015-08-06 Thread Luigi Toscano
Jonathan Riddell ha scritto: plasma-pa is a new volume manager and is intended to be a replacement for KMix in Plasma. We plan to ship it as a beta in Plasma 5.4 and it's currently in kdereview for your reviewing attention. https://projects.kde.org/projects/kdereview/plasma-pa Please

Re: Updating our tools

2015-08-09 Thread Luigi Toscano
Michael Pyne ha scritto: On Sun, August 9, 2015 09:58:26 Allen Winter wrote: On Sunday, August 09, 2015 09:35:06 PM Ben Cooksley wrote: On Sun, Aug 9, 2015 at 3:15 AM, Allen Winter win...@kde.org wrote: On Saturday, August 08, 2015 04:59:49 PM Elvis Angelaccio wrote: Sorry to bump this old

Re: Review Request 122556: Bump Qt version to 5.4

2015-08-09 Thread Luigi Toscano
On Ago. 9, 2015, 3:33 p.m., Nikita Skovoroda wrote: What's the status of this? Dolphin (and maybe some other apps) already depends on 5.4. Nikita Skovoroda wrote: Plasma and Kwin require Qt 5.4 since Plasma 5.3.0 release, btw. Plasma (and Kwin, which is part of Plasma) are not

Documentation (was Re: Plasma Applet for Audio Volume for kdereview)

2015-08-12 Thread Luigi Toscano
On Wednesday 12 of August 2015 10:05:34 Sebastian Kügler wrote: Also, the Evolve survey was pretty clear that we utterly suck in the documentation arena. Playing with words doesn't solve that, writing documentation and maintaining it does. We may change the rules, and that's perhaps what we

Re: Moving akonadi from kdesupport and akonadi-search from playground

2015-07-21 Thread Luigi Toscano
laurent Montel ha scritto: Le Monday 20 July 2015, 22:58:39 Luigi Toscano a écrit : Daniel Vrátil ha scritto: Hi all, we (the KDE PIM team) kinda screwed up when we forgot to communicate our intentions about next KDE PIM release with the release team and we ended up in a situation that we

Re: Moving akonadi from kdesupport and akonadi-search from playground

2015-07-20 Thread Luigi Toscano
Daniel Vrátil ha scritto: Hi all, we (the KDE PIM team) kinda screwed up when we forgot to communicate our intentions about next KDE PIM release with the release team and we ended up in a situation that we have some repositories in modules from which they cannot be released as part of KDE

  1   2   >