Re: AtCore on KDE Review

Atcore is a kde framework library So we used the KF5 prefix. If this is still incorrect then I can remove it On Jul 16, 2017 9:51 AM, "Luigi Toscano" wrote: > Lays Rodrigues ha scritto: > > Well, choosed to maintain the translation. > > Diff with the script merged: > >

Re: AtCore on KDE Review

Thank you for clarifying that as I did misunderstand. I should hopefully have a patch for this today . I will tag you for review. On Jul 16, 2017 11:31 AM, "Luigi Toscano" wrote: sithlord48 ha scritto: > Atcore is a kde framework library So we used the KF5 prefix. If

Re: AtCore on KDE Review

sithlord48 ha scritto: > Atcore is a kde framework library So we used the KF5 prefix. If this is still > incorrect then I can remove it I think that there is a misunderstanding: AtCore is a library based on Qt and ECM. Even if it used some libraries from Frameworks, it would not make it part of

Re: AtCore on KDE Review

Lays Rodrigues ha scritto: > Well, choosed to maintain the translation. > Diff with the script merged: > https://phabricator.kde.org/D6692 > That's solved, but there is another issue that I noticed now: atcore uses the same pattern as Frameworks libraries, and this should be fixed. For example,

Re: AtCore on KDE Review

On Wed, Jul 12, 2017 at 9:30 AM, Luigi Toscano wrote: > On Wednesday, 12 July 2017 14:19:29 CEST you wrote: > > I don't see the importance to add a translation to AtCore Test Client > since > > Atelier should be the main client (in one month or two). > > The test client

Re: AtCore on KDE Review

I don't see the importance to add a translation to AtCore Test Client since Atelier should be the main client (in one month or two). The test client is only for testing. Cheers, On Mon, Jul 10, 2017 at 7:07 PM, Albert Astals Cid wrote: > El divendres, 7 de juliol de 2017, a les

Re: AtCore on KDE Review

On Wednesday, 12 July 2017 14:19:29 CEST you wrote: > I don't see the importance to add a translation to AtCore Test Client since > Atelier should be the main client (in one month or two). > The test client is only for testing. There are ::tr calls also in src/gcodecommands.cpp: and one inside

Re: AtCore on KDE Review

El divendres, 7 de juliol de 2017, a les 15:05:38 CEST, Luigi Toscano va escriure: > On Friday, 7 July 2017 15:02:21 CEST you wrote: > > On Thu, Jul 6, 2017 at 2:03 PM, Luigi Toscano > > > > > > -> Luigui > > > > "In addition to Albert's comment, I noticed now

Re: AtCore on KDE Review

On Friday, 7 July 2017 15:02:21 CEST you wrote: > On Thu, Jul 6, 2017 at 2:03 PM, Luigi Toscano > > > > > -> Luigui > > > "In addition to Albert's comment, I noticed now (still going through > > > > the > > > > > backlog after vacation) that atcore use

Re: AtCore on KDE Review

On Thu, Jul 6, 2017 at 2:03 PM, Luigi Toscano wrote: > Lays Rodrigues ha scritto: > > Hi guys of kde-core. > > > > Any new review of AtCore? =D > > I think that there were questions open on your side. Did you address the > two > issues, namely: > > > On Fri, Jun 23,

Re: AtCore on KDE Review

Lays Rodrigues ha scritto: > Hi guys of kde-core. > > Any new review of AtCore? =D I think that there were questions open on your side. Did you address the two issues, namely: > On Fri, Jun 23, 2017 at 11:19 PM, Lays Rodrigues wrote: > -> aacid > > "Partially, i personally still

Re: AtCore on KDE Review

Hi guys of kde-core. Any new review of AtCore? =D Cheers, On Fri, Jun 23, 2017 at 11:19 PM, Lays Rodrigues < laysrodriguessi...@gmail.com> wrote: > Yay, now we are on track again. This will be the right thread for the > review. > I will address here the issues that aacid and Luigui opened on