Re: AtCore on KDE Review

[sithlord48]

Atcore is a kde framework library So we used the KF5 prefix. If this is
still incorrect then I can remove it

On Jul 16, 2017 9:51 AM, "Luigi Toscano"  wrote:

> Lays Rodrigues ha scritto:
> > Well, choosed to maintain the translation.
> > Diff with the script merged:
> > https://phabricator.kde.org/D6692
> >
>
> That's solved, but there is another issue that I noticed now: atcore uses
> the
> same pattern as Frameworks libraries, and this should be fixed.
> For example, see the following files installed:
>
> /lib/x86_64-linux-gnu/cmake/KF5AtCore/KF5AtCoreConfig.cmake
> ...
> /include/KF5/atcore_version.h
> /lib/x86_64-linux-gnu/libKF5AtCore.so.16.08.0
> /lib/x86_64-linux-gnu/libKF5AtCore.so.1
> /lib/x86_64-linux-gnu/libKF5AtCore.so
>
> The prefix KF5 should go away.
>
> Ciao
> --
> Luigi
>

Re: AtCore on KDE Review

[sithlord48]

Thank you for clarifying that as I did misunderstand. I should hopefully
have a patch for this today . I will tag you for review.

On Jul 16, 2017 11:31 AM, "Luigi Toscano"  wrote:

sithlord48 ha scritto:
> Atcore is a kde framework library So we used the KF5 prefix. If this is
still
> incorrect then I can remove it

I think that there is a misunderstanding: AtCore is a library based on Qt
and
ECM. Even if it used some libraries from Frameworks, it would not make it
part
of "KDE Frameworks", but a library *based on* KDE Frameworks.
The only libraries which are part of KDE Frameworks are, well, the ones
shipped with KDE Frameworks:
https://api.kde.org/frameworks/index.html
https://download.kde.org/stable/frameworks/5.36/

--
Luigi

Re: AtCore on KDE Review

[Luigi Toscano]

sithlord48 ha scritto:
> Atcore is a kde framework library So we used the KF5 prefix. If this is still
> incorrect then I can remove it

I think that there is a misunderstanding: AtCore is a library based on Qt and
ECM. Even if it used some libraries from Frameworks, it would not make it part
of "KDE Frameworks", but a library *based on* KDE Frameworks.
The only libraries which are part of KDE Frameworks are, well, the ones
shipped with KDE Frameworks:
https://api.kde.org/frameworks/index.html
https://download.kde.org/stable/frameworks/5.36/

-- 
Luigi

Re: AtCore on KDE Review

[Luigi Toscano]

Lays Rodrigues ha scritto:
> Well, choosed to maintain the translation.
> Diff with the script merged:
> https://phabricator.kde.org/D6692
> 

That's solved, but there is another issue that I noticed now: atcore uses the
same pattern as Frameworks libraries, and this should be fixed.
For example, see the following files installed:

/lib/x86_64-linux-gnu/cmake/KF5AtCore/KF5AtCoreConfig.cmake
...
/include/KF5/atcore_version.h
/lib/x86_64-linux-gnu/libKF5AtCore.so.16.08.0
/lib/x86_64-linux-gnu/libKF5AtCore.so.1
/lib/x86_64-linux-gnu/libKF5AtCore.so

The prefix KF5 should go away.

Ciao
-- 
Luigi

Re: AtCore on KDE Review

[Lays Rodrigues]

On Wed, Jul 12, 2017 at 9:30 AM, Luigi Toscano 
wrote:

> On Wednesday, 12 July 2017 14:19:29 CEST you wrote:
> > I don't see the importance to add a translation to AtCore Test Client
> since
> > Atelier should be the main client (in one month or two).
> > The test client is only for testing.
>
> There are ::tr calls also in
> src/gcodecommands.cpp:
>
> and one inside src/atcore.cpp, but it's in a qCDebug and should most
> likely be
> removed.
>
​Diff opened to solve this:
https://phabricator.kde.org/D6651​


>
> --
> Luigi
>



-- 
*Lays Rodrigues*
*Software Developer at KDE*
*Intern at Rede Globo*
*Computer Science student at Federal Fluminense University*
*laysrodriguesdev.wordpress.com *
*Telegram: @lays147*
*IRC: lays147*
*Phone: +55 22 981520012*

Re: AtCore on KDE Review

[Lays Rodrigues]

I don't see the importance to add a translation to AtCore Test Client since
Atelier should be the main client (in one month or two).
The test client is only for testing.
Cheers,

On Mon, Jul 10, 2017 at 7:07 PM, Albert Astals Cid  wrote:

> El divendres, 7 de juliol de 2017, a les 15:05:38 CEST, Luigi Toscano va
> escriure:
> > On Friday, 7 July 2017 15:02:21 CEST you wrote:
> > > On Thu, Jul 6, 2017 at 2:03 PM, Luigi Toscano <
> luigi.tosc...@tiscali.it>
> > >
> > > > > -> Luigui
> > > > > "In addition to Albert's comment, I noticed now (still going
> > > > > through
> > > >
> > > > the
> > > >
> > > > > backlog after vacation) that atcore use tr() for messages, but
> > > > > there
> > > >
> > > > is no
> > > >
> > > > > Messages.sh file to extract the strings (which should be called
> > > >
> > > > atcore_qt,
> > > >
> > > > > check the similar files in step or marble or in tier1
> > > > > frameworks)."​
> > > >
> > > > I don't think that this has been addressed
> > >
> > > It was not, and it's my fault.
> > > I was looking on marble sources but I didn't understood how the
> > > Messages.sh
> > > works,
> > > I'm reading and will update that as soon as I can.
> >
> > Or tier1 Frameworks.
> >
> > https://cgit.kde.org/kuserfeedback.git/tree/src/provider/Messages.sh
> >
> > To test it:
> >
> > http://tsdgeos.blogspot.cz/2010/08/how-to-run-messagessh-
> file-to-create.html
>
> Or the actual wiki page that should contain kind of updated contents
> hopefully
>
> https://techbase.kde.org/Development/Tutorials/Localization/
> i18n_Build_Systems#Writing_a_Messages.sh_script
>
> Cheers,
>   Albert
>
> >
> > Ciao
>
>
>


-- 
*Lays Rodrigues*
*Software Developer at KDE*
*Intern at Rede Globo*
*Computer Science student at Federal Fluminense University*
*laysrodriguesdev.wordpress.com *
*Telegram: @lays147*
*IRC: lays147*
*Phone: +55 22 981520012*

Re: AtCore on KDE Review

[Luigi Toscano]

On Wednesday, 12 July 2017 14:19:29 CEST you wrote:
> I don't see the importance to add a translation to AtCore Test Client since
> Atelier should be the main client (in one month or two).
> The test client is only for testing.

There are ::tr calls also in
src/gcodecommands.cpp:

and one inside src/atcore.cpp, but it's in a qCDebug and should most likely be 
removed.

-- 
Luigi

Re: AtCore on KDE Review

[Albert Astals Cid]

El divendres, 7 de juliol de 2017, a les 15:05:38 CEST, Luigi Toscano va 
escriure:
> On Friday, 7 July 2017 15:02:21 CEST you wrote:
> > On Thu, Jul 6, 2017 at 2:03 PM, Luigi Toscano 
> > 
> > > > -> Luigui
> > > > "In addition to Albert's comment, I noticed now (still going
> > > > through
> > > 
> > > the
> > > 
> > > > backlog after vacation) that atcore use tr() for messages, but
> > > > there
> > > 
> > > is no
> > > 
> > > > Messages.sh file to extract the strings (which should be called
> > > 
> > > atcore_qt,
> > > 
> > > > check the similar files in step or marble or in tier1
> > > > frameworks)."​
> > > 
> > > I don't think that this has been addressed
> > 
> > It was not, and it's my fault.
> > I was looking on marble sources but I didn't understood how the
> > Messages.sh
> > works,
> > I'm reading and will update that as soon as I can.
> 
> Or tier1 Frameworks.
> 
> https://cgit.kde.org/kuserfeedback.git/tree/src/provider/Messages.sh
> 
> To test it:
> 
> http://tsdgeos.blogspot.cz/2010/08/how-to-run-messagessh-file-to-create.html

Or the actual wiki page that should contain kind of updated contents hopefully

https://techbase.kde.org/Development/Tutorials/Localization/
i18n_Build_Systems#Writing_a_Messages.sh_script

Cheers,
  Albert

> 
> Ciao

Re: AtCore on KDE Review

[Luigi Toscano]

On Friday, 7 July 2017 15:02:21 CEST you wrote:
> On Thu, Jul 6, 2017 at 2:03 PM, Luigi Toscano 
> > 
> > > -> Luigui
> > > "In addition to Albert's comment, I noticed now (still going through
> > 
> > the
> > 
> > > backlog after vacation) that atcore use tr() for messages, but there
> > 
> > is no
> > 
> > > Messages.sh file to extract the strings (which should be called
> > 
> > atcore_qt,
> > 
> > > check the similar files in step or marble or in tier1 frameworks)."​
> > 
> > I don't think that this has been addressed
> 
> It was not, and it's my fault.
> I was looking on marble sources but I didn't understood how the Messages.sh
> works,
> I'm reading and will update that as soon as I can.

Or tier1 Frameworks.

https://cgit.kde.org/kuserfeedback.git/tree/src/provider/Messages.sh

To test it:

http://tsdgeos.blogspot.cz/2010/08/how-to-run-messagessh-file-to-create.html

Ciao
-- 
Luigi

Re: AtCore on KDE Review

[Tomaz Canabrava]

On Thu, Jul 6, 2017 at 2:03 PM, Luigi Toscano 
wrote:

> Lays Rodrigues ha scritto:
> > Hi guys of kde-core.
> >
> > Any new review of AtCore? =D
>
> I think that there were questions open on your side. Did you address the
> two
> issues, namely:
>
> > On Fri, Jun 23, 2017 at 11:19 PM, Lays Rodrigues  wrote:
>
> > -> aacid
> >
> > "Partially, i personally still think it'd be better if you move the
> > PrinterState AXIS and MeasuramentUnits enums inside AtCore (or make
> them C++11
> > "enum class").
> >
> > Also note how PrinterState AXIS MeasuramentUnits is not consistent
> naming
> > "
> >
> > For that, I think this is the diff: https://phabricator.kde.org/
> D6363
> > 
>
> This seems to be merged; Albert, does it address your concern?
>
>
> >
> > -> Luigui
> > "In addition to Albert's comment, I noticed now (still going through
> the
> > backlog after vacation) that atcore use tr() for messages, but there
> is no
> > Messages.sh file to extract the strings (which should be called
> atcore_qt,
> > check the similar files in step or marble or in tier1 frameworks)."​
>
> I don't think that this has been addressed
>

It was not, and it's my fault.
I was looking on marble sources but I didn't understood how the Messages.sh
works,
I'm reading and will update that as soon as I can.


>
> --
> Luigi
>

Re: AtCore on KDE Review

[Luigi Toscano]

Lays Rodrigues ha scritto:
> Hi guys of kde-core.
> 
> Any new review of AtCore? =D

I think that there were questions open on your side. Did you address the two
issues, namely:

> On Fri, Jun 23, 2017 at 11:19 PM, Lays Rodrigues  wrote:

> -> aacid
> 
> "Partially, i personally still think it'd be better if you move the
> PrinterState AXIS and MeasuramentUnits enums inside AtCore (or make them 
> C++11
> "enum class").
> 
> Also note how PrinterState AXIS MeasuramentUnits is not consistent naming
> "
> 
> For that, I think this is the diff: https://phabricator.kde.org/D6363
> 

This seems to be merged; Albert, does it address your concern?


> 
> -> Luigui
> "In addition to Albert's comment, I noticed now (still going through the
> backlog after vacation) that atcore use tr() for messages, but there is no
> Messages.sh file to extract the strings (which should be called atcore_qt,
> check the similar files in step or marble or in tier1 frameworks)."​

I don't think that this has been addressed

-- 
Luigi

Re: AtCore on KDE Review

[Lays Rodrigues]

Hi guys of kde-core.

Any new review of AtCore? =D

Cheers,

On Fri, Jun 23, 2017 at 11:19 PM, Lays Rodrigues <
laysrodriguessi...@gmail.com> wrote:

> Yay, now we are on track again. This will be the right thread for the
> review.
> I will address here the issues that aacid and Luigui opened on the
> previous thread and allow the others AtCore devels answer it.
>
> -> aacid
>
> "Partially, i personally still think it'd be better if you move the
> PrinterState AXIS and MeasuramentUnits enums inside AtCore (or make them
> C++11
> "enum class").
>
> Also note how PrinterState AXIS MeasuramentUnits is not consistent naming
> "
>
> For that, I think this is the diff: https://phabricator.kde.org/D6363
>
> -> Luigui
> "In addition to Albert's comment, I noticed now (still going through the
> backlog after vacation) that atcore use tr() for messages, but there is no
> Messages.sh file to extract the strings (which should be called atcore_qt,
> check the similar files in step or marble or in tier1 frameworks)."​
>
> Cheers,
> --
> *Lays Rodrigues*
> *Software Developer at KDE*
> *Intern at Rede Globo*
> *Computer Science student at Federal Fluminense University*
> *laysrodriguesdev.wordpress.com *
> *Telegram: @lays147*
> *IRC: lays147*
> *Phone: +55 22 981520012 <+55%2022%2098152-0012>*
>



-- 
*Lays Rodrigues*
*Software Developer at KDE*
*Intern at Rede Globo*
*Computer Science student at Federal Fluminense University*
*laysrodriguesdev.wordpress.com *
*Telegram: @lays147*
*IRC: lays147*
*Phone: +55 22 981520012*