arichardson added a comment.
Looks good to me. Using a regex engine for this seems like overkill but I
guess compared to the I/O overhead of reading the desktop file it shouldn't
matter.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D7170
To: mpyne,
dfaure added inline comments.
INLINE COMMENTS
> simplejob.cpp:346
> +bool confirmed = tryAskPrivilegeOpConfirmation();
> +m_slave->send(MSG_PRIVILEGE_EXEC, QByteArray(confirmed ? "1" : "0"));
> +}
Check that this is consistent with SlaveBase...
REVISION DETAIL
dfaure added a comment.
If you agree that showing an error message after hitting Cancel on the kauth
prompt is suboptimal (I didn't actually test it), then it seems to me that a
simple solution to turn `bool isPrivilegeOperationAllowed()` into a method that
returns an enum? (same for
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Looks OK to me now (just minor things)
INLINE COMMENTS
> copyjob.cpp:267
>
> +KIO::JobFlag privilegeExecFlag() { return m_privilegeExecutionEnabled ?
> PrivilegeExecution :
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
You wrote: "For the case you mentioned kauth prompt will always be triggered
during opening of file for writing."
I disagree. My example case is a FAT permission where the
dfaure accepted this revision.
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6829
To: chinmoyr, dfaure, #frameworks
Cc: #frameworks
chinmoyr updated this revision to Diff 18019.
chinmoyr added a comment.
- Add PrivilegeExecution flag to subjobs
- Removed the default case from CopyJob
- Initially I didn't add checks for PrivilegeExecution flag in SimpleJob as
most of them don't take it as argument. Now added checks for
apol added a comment.
In https://phabricator.kde.org/D7253#134653, @elvisangelaccio wrote:
> Main reason is having a simple way to run flatpak-builder with the proper
arguments. Otherwise you have to copy-paste the command from somewhere (which
could be error-prone).
> One usually
chinmoyr updated this revision to Diff 18018.
chinmoyr added a comment.
- Fixed the issues pointed out.
- Check for UnitTesting key in metadata while showing the confirmation dialog.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6832?vs=17222=18018
BRANCH
master
REVISION
chinmoyr added a comment.
> what happens if the user cancels the root-password prompt? He will then get
another msg box with "cannot create directory?" even though he/she purposefully
canceled the operation? When that happens the slave should use
error(KIO::ERR_USER_CANCELED) instead (which
chinmoyr updated this revision to Diff 18016.
chinmoyr added a comment.
- Fixed error handling logic in FileProtocol::chmod.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6831?vs=17019=18016
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6831
AFFECTED FILES
chinmoyr updated this revision to Diff 18015.
chinmoyr added a comment.
Minor changes
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6830?vs=17782=18015
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6830
AFFECTED FILES
src/ioslaves/file/file_unix.cpp
To:
chinmoyr added a comment.
For the case you mentioned kauth prompt will always be triggered during
opening of file for writing. Operations like chmod, chown, utime will work (and
then fail) without showing any prompt.
REVISION DETAIL
https://phabricator.kde.org/D6830
To: chinmoyr, dfaure,
chinmoyr updated this revision to Diff 18014.
chinmoyr added a comment.
- added @since 5.38
- rearranged code-blocks in execWithElevatedPrivilege() method. Now the
prompt is also tested in unit test mode.\ https://phabricator.kde.org/D6832
will add relevant code for testing confirmation.
chinmoyr updated this revision to Diff 18012.
chinmoyr added a comment.
Improved error checking in helper.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6197?vs=17780=18012
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6197
AFFECTED FILES
elvisangelaccio added a comment.
Main reason is having a simple way to run flatpak-builder with the proper
arguments. Otherwise you have to copy-paste the command from somewhere (which
could be error-prone).
One usually already has a build folder around, so the idea is you change some
apol added a comment.
Interesting feature.
I'm not opposed to it, but I have the feeling that it belongs to a different
layer, so this means creating a build directory to call flatpak to call cmake.
:P
Also the arguments one passes to cmake won't have any effect on the flatpak.
elvisangelaccio added reviewers: apol, Frameworks.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D7253
To: elvisangelaccio, apol, #frameworks
Cc: #frameworks, #build_system
elvisangelaccio created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
REVISION SUMMARY
If there is a `org.kde.*.json` file in the git repository of the cmake
project, we assume is a flatpak
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/44/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Fri, 11 Aug 2017 16:05:56 +
Build duration:
1 min 18 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/40/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Fri, 11 Aug 2017 16:05:56 +
Build duration:
54 sec and counting
JUnit Tests
cfeck added a comment.
The commit still says "size != oldSize". Is this correct?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D7127
To: mart, #plasma, davidedmundson
Cc: cfeck, davidedmundson, broulik, plasma-devel, #frameworks, ZrenBot,
fvogt closed this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D7250
To: fvogt, #plasma, mart
Cc: #frameworks
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7250
To: fvogt, #plasma, mart
Cc: #frameworks
fvogt added a reviewer: Plasma.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D7250
To: fvogt, #plasma
Cc: #frameworks
fvogt updated this revision to Diff 18004.
fvogt added a comment.
Forgot a check
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7250?vs=18003=18004
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7250
AFFECTED FILES
fvogt created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
imagePath can be an absolute path into an iconTheme
-> Do not try to find it in the Plasma theme
imagePath can be empty
-> Do not try
broulik created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Qt just returns a 16px pixmap by default leading to blurry results when
larger icon sizes for small icons are configured by the user.
TEST
rjvbb added a comment.
In https://phabricator.kde.org/D7237#134438, @dfaure wrote:
> Forgot to git add kiod_agent.mm?
In fact, I see I have a comparable patch for kioslave, but simpler because
AFAICT it won't ever put up a GUI itself.
What would be an appropriate place in
rjvbb updated this revision to Diff 17997.
rjvbb edited the summary of this revision.
rjvbb added a comment.
Forgot a `git add` indeed, as well as a final bit of proofreading.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7237?vs=17981=17997
REVISION DETAIL
rjvbb set the repository for this revision to R241 KIO.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7237
To: rjvbb, #frameworks, dfaure
Cc: kde-mac, dfaure, #frameworks
Hola!
As per [1] the release management suite releaseme creates tarballs
which rely on kdoctools to process a directory with docbooks inside.
Previously releaseme manually constructed CMakeLists suitable for the
documentation lineup at hand. This required an excessive amount of
fairly poorly
dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.
In general ok, but there are two issues to be fixed
1. Remove spaces around items as noted in the comment
2. Please extend / add a highlighting test case in
This revision was automatically updated to reflect the committed changes.
Closed by commit R278:32526718eae9: KKeyServer: fix handling of KeypadModifier.
(authored by dfaure).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6233?vs=15522=17994#toc
REPOSITORY
R278 KWindowSystem
CHANGES
34 matches
Mail list logo
