D11569: Improve consistency of "Open With" UI by always showing top app inline

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio Cc: mmustac, davidedmundson, broulik, dfaure, elvisangelaccio, anthonyfieroni, abetts, michaelh,

D11569: Improve consistency of "Open With" UI by always showing top app inline

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio Cc: mmustac, davidedmundson, broulik, dfaure, elvisangelaccio, anthonyfieroni, abetts, michaelh,

D11569: Improve consistency of "Open With" UI by always showing top app inline

ngraham updated this revision to Diff 30584. ngraham added a comment. Remove excessive wordiness REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11569?vs=30233=30584 BRANCH open-with-usability (branched from master) REVISION DETAIL

D11705: Highlight selected items when showing parent folder from the open/save dialog

ngraham created this revision. ngraham added a reviewer: Frameworks. Restricted Application added a project: Frameworks. ngraham requested review of this revision. REVISION SUMMARY For the open/save dialogs' Open File Manager context menu item, this patch adopts `KIO::highlightInFileManager()`

D11529: Balooctl: Deindex unfound files with check command.

smithjd updated this revision to Diff 30575. smithjd added a comment. - Fix a threading issue. - Fix check operation order. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11529?vs=30573=30575 BRANCH master-filedeindexer REVISION DETAIL

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

dmitrio updated this revision to Diff 30570. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10663?vs=27582=30570 REVISION DETAIL https://phabricator.kde.org/D10663 AFFECTED FILES src/core/filecopyjob.cpp src/core/filecopyjob.h To: dmitrio, #frameworks,

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

dmitrio reclaimed this revision. dmitrio added a comment. This revision now requires changes to proceed. Well, sorry, I did not expect you waiting for me. I had some new version of this patch, but thought about working on unit tests for it and never finished them. I'll upload now what I have

D11529: Balooctl: Deindex unfound files with check command.

smithjd added inline comments. INLINE COMMENTS > michaelh wrote in fileindexscheduler.h:83 > Nitpick: We're removing db entries not files. Also every file is deindexable. > Maybe 'purgeStaleEntries', 'removeLostEntries' or so would be a better name > to describe what's going on. This is doing

D11529: Balooctl: Deindex unfound files with check command.

smithjd updated this revision to Diff 30573. smithjd marked 9 inline comments as done. smithjd added a comment. - Review changes. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11529?vs=30466=30573 BRANCH master-filedeindexer REVISION DETAIL

D11529: Balooctl: Deindex unfound files with check command.

smithjd added a comment. In D11529#233550 , @michaelh wrote: > Under the premise that I still have to learn about baloo's inner workings, here are some concerns: > > - I'm not convinced, that index cleaning should be part of the dbus

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.10/35/ Project: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 Date of build: Sun, 25 Mar 2018 22:22:38 + Build duration: 8 min 50 sec and counting JUnit

KDE CI: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.9/27/ Project: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 25 Mar 2018 22:22:38 + Build duration: 6 min 26 sec and counting

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.9 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.9/10/ Project: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.9 Date of build: Sun, 25 Mar 2018 22:22:38 + Build duration: 4 min 38 sec and counting JUnit

D11677: ktooltipwidget: Prevent offscreen display

This revision was automatically updated to reflect the committed changes. Closed by commit R236:6b88b7c1eafe: ktooltipwidget: Prevent offscreen display (authored by michaelh). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11677?vs=30491=30566

D11677: ktooltipwidget: Prevent offscreen display

cfeck accepted this revision. cfeck added a comment. This revision is now accepted and ready to land. I did not test, but this seems the correct fix for sizes > screen width. If this does not fix the autotest, there is still time to further investigate. REPOSITORY R236 KWidgetsAddons

Re: Falkon in kdereview

On Sat, Mar 24, 2018 at 7:58 PM, Dr.-Ing. Christoph Cullmann wrote: > Hi, > > no objections from my side, > > just a note that we need to take care of the last remaining things on > > https://community.kde.org/Incubator/Projects/Falkon > > for the final incubation to be done.

D10739: Remove deprecated cmake code

This revision was automatically updated to reflect the committed changes. Closed by commit R246:8e51cbc03f72: Remove deprecated cmake code (authored by vonreth). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10739?vs=27773=30563 REVISION DETAIL

D5865: Add missing KDE_ENABLE_NAMED_OPERATORS function

rjvbb added a comment. That's because of the MSVC remarks you made inline? I don't have a way to test with MSVC, so I could do with some suggestions how to resolve the flagged issues. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5865 To: rjvbb,

D11204: Support NTFS hidden files

markg resigned from this revision. markg added a comment. This revision is now accepted and ready to land. In D11204#233997 , @dfaure wrote: > Thanks ! > > Do you have a contributor account for pushing the commit, or do you need someone else

D11685: Implement single click on line number to select line of text

rkron updated this revision to Diff 30560. rkron added a comment. - Update revision per review comments. Removed the config option to enable and disable the single-click behavior. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11685?vs=30517=30560

D10739: Remove deprecated cmake code

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D10739 To: vonreth, kfunk, dfaure, vkrause, mlaurent Cc: apol, #frameworks, michaelh, ngraham

D11685: Implement single click on line number to select line of text

rkron added a comment. @ngraham Qt Designer made those changes when I added the checkbox. They will be gone with the update. The four files concerning the config option will be as they were before this revision. REPOSITORY R39 KTextEditor REVISION DETAIL

D5865: Add missing KDE_ENABLE_NAMED_OPERATORS function

kfunk requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5865 To: rjvbb, #frameworks, #build_system, cgilles, kfunk Cc: thiago, kfunk, michaelh, ngraham

D11685: Implement single click on line number to select line of text

ngraham added a comment. @richardbowen, this isn't a support forum, it's for patch review. Please only leave comments related to the patch itself. Thanks! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham

D11685: Implement single click on line number to select line of text

ngraham added inline comments. INLINE COMMENTS > navigationconfigwidget.ui:43 > > - Autocenter cursor: > + Autocenter cursor: > Unrelated change? > navigationconfigwidget.ui:92 > > - Text selection mode: > + Text

D11685: Implement single click on line number to select line of text

richardbowen added a comment. In D11685#234040 , @rkron wrote: > And actually, if you have the line modification marker border turned on, clicking in it will just move the cursor without selecting the line. Not sure what the line

D11685: Implement single click on line number to select line of text

rkron added a comment. And actually, if you have the line modification marker border turned on, clicking in it will just move the cursor without selecting the line. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate,

D11685: Implement single click on line number to select line of text

richardbowen added a comment. With the double click option, it allows for two different functionality (place at home row, and highlight) as opposed to one if there was only 1 click to highlight. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron,

D11685: Implement single click on line number to select line of text

rkron added a comment. @ngraham I agree. Single-click is pretty much standard. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham Cc: richardbowen, ngraham, #ktexteditor, #kate, #frameworks, michaelh,

D11685: Implement single click on line number to select line of text

ngraham added a comment. In D11685#234009 , @richardbowen wrote: > How about double click to highlight instead of tripple click? I think consistency with the common interaction method is important here: other text editors implement this

D11610: clang-tidy: modernize-use-default-member-init run

kfunk added a comment. I'll wait until v5.45 got branched off. No need to hurry with this. REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D11610 To: kfunk, dhaumann Cc: dhaumann, #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann,

D11685: Implement single click on line number to select line of text

richardbowen added a comment. How about double click to highlight instead of tripple click? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham Cc: richardbowen, ngraham, #ktexteditor, #kate, #frameworks,

Re: Review Request 129025: Enable cross compilation support for packages depending on normally installed kdoctools tools.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129025/#review103873 --- (I just wanted to add a comment, but reviewboard reopened

D11685: Implement single click on line number to select line of text

rkron added a comment. OK. I will remove the option and update the revision. Thanks for the input! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham Cc: ngraham, #ktexteditor, #kate, #frameworks, michaelh,

D11685: Implement single click on line number to select line of text

ngraham added a comment. IMHO, a mouse-based workflow for selecting large blocks of text makes sense, which is why this should be made at least the default setting. But using the mouse to go to the first column makes less sense, since you're probably about to do something with the text,

D11204: Support NTFS hidden files

dfaure accepted this revision. dfaure added a comment. Thanks ! Do you have a contributor account for pushing the commit, or do you need someone else to do it? INLINE COMMENTS > markg wrote in file_unix.cpp:546-550 > I "think" it belongs in createUDSEntry, but i'm not sure either. It

D11685: Implement single click on line number to select line of text

rkron added a comment. If you think it should be on by default, that's easily done. I know what you mean, that nobody would ever find it. When I first started using Kate, I thought the triple-clicking was very annoying. But I got used to it and now it's automatic for me. It also became

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

ngraham added a comment. @dmitrio, are you still planning to work on this patch, or a new version of it? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10663 To: dmitrio, #frameworks, dfaure Cc: elvisangelaccio, ngraham, anthonyfieroni, meven, #frameworks, michaelh

D10292: change 32px icons for playlist shuffle and repeat

bcooksley added a comment. It is currently pending on @andreask reviewing it, as they have previously requested changes. It also needs @andreaska to review it (not sure if this is correct?) Phabricator only considers something ready for landing once all reviewers have approved it.

D11685: Implement single click on line number to select line of text

ngraham added a comment. Gave it a whirl; this is very nice! I don't think making it optional and off by default is the best choice, though. Nobody will ever find it. I would support making this enabled by default at the very least, and possibly even not turn-off-able with an option.

D11365: also test for value types in taglibextractortest and fix errors

astippich added a comment. It's just testing each file for all available properties, one after another. This revision just adds missing bits to the existing test. Refactoring should be done separately imho INLINE COMMENTS > michaelh wrote in propertyinfo.cpp:98 > Looks unrelated to me.

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 - Build # 33 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.9/33/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 25 Mar 2018 17:18:42 + Build duration: 11 min and counting JUnit Tests

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/8/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Sun, 25 Mar 2018 17:18:42 + Build duration: 11 min and counting JUnit Tests Name:

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 37 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/37/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Sun, 25 Mar 2018 17:18:42 + Build duration: 8 min 56 sec and counting JUnit Tests

D1231: Add Remote Access interface to KWayland

Kanedias added a comment. - squashed before pushing - fixed all versions to 5.45 Thanks gentlemen, it's was 1 day more for the second birthday of this patch :) REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson,

D1231: Add Remote Access interface to KWayland

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R127:5116fe0c6345: Add Remote Access interface to KWayland (authored by Kanedias). CHANGED PRIOR TO COMMIT

D1231: Add Remote Access interface to KWayland

davidedmundson accepted this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson, romangg Cc: jtamate, jgrulich, romangg, ngraham, alexeymin, #frameworks, davidedmundson, plasma-devel, ragreen, schernikov, michaelh,

D1231: Add Remote Access interface to KWayland

romangg accepted this revision. romangg added a comment. Looks fine to me. Tested compilation as well as runtime with KWin's DRM+EGL backend. - Please change in comments the frameworks version number these changes are landing in. - I would like to have @davidedmundson look over this

D11204: Support NTFS hidden files

markg added inline comments. INLINE COMMENTS > rominf wrote in file_unix.cpp:546-550 > The logic behind this is that `getxattr` exists only on Linux > (https://www.gnu.org/software/gnulib/manual/html_node/getxattr.html#getxattr) > and `file_unix.cpp` is more Linux-y than `file.cpp`. If you

D11642: Fix the rcc binary package generation

davidedmundson added a comment. Edit. Installation works, which is better. However it still doesn't work properly. make && install Add a file to applets/digital-clock/contents/ui/Foo.qml with some valid QML and then use it from main.qml make && install I get an

Re: GSoC2018 - Panel Improvement Proposal Idea

Hi, On 03/25/18 14:11, Furkan Tokaç wrote: > For GSoC2018, as a long-term KDE user/lover, I want to make 2 important > improvements on KDE / Plasma-Workspace / Panel that will increase user > experience. Both things sound like worthwhile fixes, but are not suitable as-is for a GSoC propsal.

D11685: Implement single click on line number to select line of text

rkron edited the test plan for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham Cc: ngraham, #ktexteditor, #kate, #frameworks, michaelh, kevinapavew, demsking, cullmann, sars, dhaumann

D11685: Implement single click on line number to select line of text

rkron created this revision. rkron added reviewers: Frameworks, Kate, KTextEditor, ngraham. Restricted Application added projects: Kate, Frameworks. rkron requested review of this revision. REVISION SUMMARY Implements selecting entire line of text with a single click on line number.

D11683: Make it possible to request a plugin configuration module programatically

apol added a comment. The usage of the API: https://phabricator.kde.org/D11684 REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D11683 To: apol, #frameworks, #kde_connect Cc: michaelh, ngraham

D11683: Make it possible to request a plugin configuration module programatically

apol added a dependent revision: D11684: Show the KCM with the run commands open when a setup packet is received. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D11683 To: apol, #frameworks, #kde_connect Cc: michaelh, ngraham

D11452: sanitizer: Improve device listing

michaelh updated this revision to Diff 30514. michaelh added a comment. - Remove trailing whitespace REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11452?vs=29981=30514 BRANCH sanitize-devices (branched from master) REVISION DETAIL

D11683: Make it possible to request a plugin configuration module programatically

apol created this revision. apol added reviewers: Frameworks, KDE Connect. Restricted Application added a project: Frameworks. apol requested review of this revision. REVISION SUMMARY In KDE Connect we want to show a specific configuration module in some occasions, having this new API would

GSoC2018 - Panel Improvement Proposal Idea

Hi KDE Devs, For GSoC2018, as a long-term KDE user/lover, I want to make 2 important improvements on KDE / Plasma-Workspace / Panel that will increase user experience. By this mail, I'll just talk about the improvements without any technical details. In the proposal, I'll tell about my plan

KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.9 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.9/17/ Project: Frameworks kservice kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 25 Mar 2018 13:09:16 + Build duration: 3 min 43 sec and counting JUnit Tests

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/22/ Project: Frameworks kservice kf5-qt5 SUSEQt5.10 Date of build: Sun, 25 Mar 2018 13:09:16 + Build duration: 2 min 25 sec and counting JUnit Tests

Re: Review Request 130228: Mingw32 compile fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130228/ --- (Updated March 25, 2018, 3:09 p.m.) Status -- This change has been

Re: Review Request 130228: Mingw32 compile fix

> On Aug. 17, 2017, 10:14 a.m., David Faure wrote: > > Looks OK. Nice code duplication, but ok, this is kdelibs4support, not worth > > refactoring. > > > > > > PS: Please use phabricator, we're told reviewboard is on the way out. superseeded by https://phabricator.kde.org/D9386 - Ralf

Re: Review Request 129025: Enable cross compilation support for packages depending on normally installed kdoctools tools.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129025/ --- (Updated March 25, 2018, 3:07 p.m.) Status -- This change has been

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/34/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sun, 25 Mar 2018 12:33:06 + Build duration: 30 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kpeople kf5-qt5 WindowsMSVCQt5.10 - Build # 8 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kpeople%20kf5-qt5%20WindowsMSVCQt5.10/8/ Project: Frameworks kpeople kf5-qt5 WindowsMSVCQt5.10 Date of build: Sun, 25 Mar 2018 12:48:36 + Build duration: 4 min 5 sec and counting JUnit

D11365: also test for value types in taglibextractortest and fix errors

michaelh added a comment. It is very hard for me understand what you are actually testing. Please (re-)consider to organize like below (or similar). It would be closer to consumer's point of view. What do I get when I ask `kfilemetadata` for the artist of `test.m4a`? void

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 163 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/163/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 25 Mar 2018 12:33:06 + Build duration: 12 min and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 184 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/184/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sun, 25 Mar 2018 12:33:06 + Build duration: 8 min 9 sec and counting JUnit Tests Name:

D11677: ktooltipwidget: Prevent offscreen display

michaelh created this revision. michaelh added a reviewer: elvisangelaccio. michaelh added a project: Frameworks. Restricted Application added a subscriber: Frameworks. michaelh requested review of this revision. REVISION SUMMARY Try to fix test failure in CI

D11365: also test for value types in taglibextractortest and fix errors

astippich added a comment. any feedback on this? I would like to land this and then get going with D10803 again REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D11365 To: astippich, #frameworks, #baloo, mgallien, michaelh

D11675: use KDE_INSTALL_DATADIR instead of FULL_DATADIR

kossebau added a comment. While myself I have never made use of it, the idea of using a relative path & not an absolute path with the DESTINATION argument is to allow overriding the install prefix at install time. Or in words of https://cmake.org/cmake/help/v3.0/command/install.html sa

D11529: Balooctl: Deindex unfound files with check command.

michaelh added a subscriber: mgallien. michaelh added a comment. Under the premise that I still have to learn about baloo's inner workings, here are some concerns: - I'm not convinced, that index cleaning should be part of the dbus interface. Why should cleaning be done out of process?

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/38/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.10 Date of build: Sun, 25 Mar 2018 11:10:51 + Build duration: 4 min 41 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.9 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.9/15/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.9 Date of build: Sun, 25 Mar 2018 11:10:51 + Build duration: 2 min 46 sec and counting JUnit Tests

D11642: Fix the rcc binary package generation

bshah marked 2 inline comments as done. bshah added a comment. opened PR for KDE_INSTALL_DATADIR : https://phabricator.kde.org/D11675 REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D11642 To: bshah, mart, davidedmundson, apol Cc: kossebau, #frameworks, michaelh,

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 32 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/32/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 25 Mar 2018 11:10:51 + Build duration: 1 min 49 sec and counting JUnit Tests

D11675: use KDE_INSTALL_DATADIR instead of FULL_DATADIR

bshah created this revision. bshah added a reviewer: kossebau. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. bshah requested review of this revision. REVISION SUMMARY This is inline with other install statements REPOSITORY R290

D11642: Fix the rcc binary package generation

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R290:b69866996e7e: Fix the rcc binary package generation (authored by bshah). REPOSITORY R290 KPackage CHANGES SINCE

D11642: Fix the rcc binary package generation

bshah added inline comments. INLINE COMMENTS > kossebau wrote in KF5PackageMacros.cmake:164 > Does a plain `${KDE_INSTALL_DATADIR}` not also work? The non-FULL variable > variants are the ones used usually with `install()`. Not exactly sure why > they are, but doing here as well would be

D10292: change 32px icons for playlist shuffle and repeat

astippich added a comment. Can I land this? phabricator doesn't show it as accepted though REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10292 To: astippich, #breeze, #vdg, andreaska, andreask, ngraham Cc: andreask, ngraham, #frameworks, michaelh

D11461: rename 64 px icons added for elisa

astippich added a comment. any feedback here? would be great to resolve this for frameworks 5.45 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11461 To: astippich, #breeze, #vdg, andreask Cc: #frameworks, michaelh, ngraham

D11204: Support NTFS hidden files

rominf updated this revision to Diff 30474. rominf added a comment. - Consider criticism - Split multiple statements to put one statement on a line REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11204?vs=30468=30474 BRANCH ntfs-hidden (branched from

Re: baloo needs to be notified of fuse mounts.

Hi, qt and/or kdelibs should provide a class providing info about a filesystem, and it's encrypted or not. At the application level (I think developing baloo is) you should not worry about this. So you should not hack the mounts and /proc/mounts yourself, but look at for example in

D11204: Support NTFS hidden files

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > file_unix.cpp:418 > +constexpr auto attrName = "system.ntfs_attrib_be"; > +const auto filenameEncoded = QFile::encodeName(filename).data(); > +

D11204: Support NTFS hidden files

rominf added inline comments. INLINE COMMENTS > dfaure wrote in file_unix.cpp:422 > Doesn't this need to be static, for the next line to be standards compliant? > Not 100% sure. No, it's enough for array length to be `constexpr`. > dfaure wrote in file_unix.cpp:431 > QVarLengthArray might be

D11204: Support NTFS hidden files

rominf updated this revision to Diff 30468. rominf marked 4 inline comments as done. rominf added a comment. - Consider criticism REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11204?vs=29475=30468 BRANCH ntfs-hidden (branched from master) REVISION DETAIL