Re: Review Request 129839: KFileMetaData: add a new property DiscNumber for audio files from multi-disc albums

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129839/#review102415 --- Ship it! Ship It! - David Faure On Feb. 5, 2017, 2:16

Re: Review Request 129839: KFileMetaData: add a new property DiscNumber for audio files from multi-disc albums

> On Feb. 5, 2017, 1:09 p.m., David Faure wrote: > > src/properties.h, line 264 > > <https://git.reviewboard.kde.org/r/129839/diff/2/?file=491008#file491008line264> > > > > Count is supposed to be the count, and Last to be the last. Any reason > >

Re: Review Request 129839: KFileMetaData: add a new property DiscNumber for audio files from multi-disc albums

ties.h (line 264) <https://git.reviewboard.kde.org/r/129839/#comment68305> Count is supposed to be the count, and Last to be the last. Any reason why you're not moving DiscNumber to be before PropertyCount, as intended by this code? (remove the "= ..." value) - David

Re: Review Request 129798: add more audio formats to automatic test and fix one problem with Musepack

> On Feb. 5, 2017, 9:45 a.m., David Faure wrote: > > Patch looks ok to me, although I don't know much about all this. > > > > The real problem isn't tooling, but lack of active maintainership for > > kfilemetadata. Are you interested in taking over? >

Re: Review Request 129798: add more audio formats to automatic test and fix one problem with Musepack

know much about all this. The real problem isn't tooling, but lack of active maintainership for kfilemetadata. Are you interested in taking over? - David Faure On Jan. 15, 2017, 3:03 p.m., Matthieu Gallien wrote: > >

Re: Review Request 129839: KFileMetaData: add a new property DiscNumber for audio files from multi-disc albums

/taglibextractor.cpp (line 110) <https://git.reviewboard.kde.org/r/129839/#comment68303> Shouldn't this variable be initialized? (e.g. to 0 or -1). Clearly it's not set in every codepath. - David Faure On Jan. 15, 2017, 3:01 p.m., Matthi

KDE Frameworks 5.30.0 released

rovements, too long to list here python syntax: added f-literals and improved string handling Security information The released code has been GPG-signed using the following key: pub rsa2048/58D0EE648A48B3BB 2016-09-05 David Faure Primary key fingerprint: 53E6 B47B 45CE A3E0 D5B7 4577 58D0 EE6

KDE Frameworks 5.29.0 released

finitions from ktexteditor Fix folding region merging Security information The released code has been GPG-signed using the following key: pub rsa2048/58D0EE648A48B3BB 2016-09-05 David Faure Primary key fingerprint: 53E6 B47B 45CE A3E0 D5B7 4577 58D0 EE64 8A48 B3BB http://kde.org/

KDE Frameworks 5.28.0 released

date applet alternatives menu entry visibility on demand Solid Fix unstable ordering of query results yet again Add a CMake option to switch between HAL and UDisks managers on FreeBSD Make UDisks2 backend compile on FreeBSD (and, possibly, other UNIXes) Windows: Don't display error dialogs

Re: Review Request 129379: [baloo] Remove unused functions

ewboard.kde.org/r/129379/ > --- > > (Updated Nov. 11, 2016, 5:09 p.m.) > > > Review request for Baloo and David Faure. > > > Repository: baloo > > > Description > --- > > As discussed in REVIEW 129186 there is a lot of bit rotting in coding.cpp/.h. >

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

> On Nov. 6, 2016, 7:36 p.m., David Faure wrote: > > src/codecs/coding.cpp, line 177 > > <https://git.reviewboard.kde.org/r/129186/diff/2/?file=484178#file484178line177> > > > > remove space before auto; make it "const auto" while at it? ignore

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

) <https://git.reviewboard.kde.org/r/129186/#comment67587> remove space before auto; make it "const auto" while at it? - David Faure On Nov. 6, 2016, 12:58 p.m., Christian Ehrlicher wrote: > > --- > This is an

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

and code would be overall simpler (no first-item special case, which also means no empty-list special case, the for loop would just be skipped if values.isEmpty()). - David Faure On Nov. 5, 2016, 11:39 p.m., Christian Ehrlicher wrote: > > -

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

> On Nov. 6, 2016, 5:40 a.m., Michael Stemle wrote: > > src/codecs/coding.cpp, line 186 > > > > > > PEDANTIC QUESTION: Why do we `resize()` rather than just using > > `QByteArray((values.size() + 1) * 5, '\0')`?

KDE Frameworks 5.27.0 released

ze the view just after setting the containment Avoid creating a KPluginInfo from a KPluginMetaData instance running tasks must have some indicator task bar lines according to RR 128802 marco give the ship it [AppletQuickItem] Break from loop when we found a layout Security information Th

KDE Frameworks 5.26.0 released

as the correct amount of trigrams for each language http://kde.org/announcements/kde-frameworks-5.26.0.php -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

KDE Frameworks 5.25.0 released

KWindowSystem API Solid Always update the Predicate parser from yacc/lex sources Sonnet hunspell: Clean up code for searching for dictionaries, add XDG dirs (bug 361409) Try to fix language filter usage of language detection a bit http://kde.org/announcements/kde-frameworks-5.25.0.php

KDE Frameworks 5.24.0 released

ep QMenu on screen for multiscreen layouts New containment type for the systray Solid Fix check that CPU is valid Handle reading /proc/cpuinfo for Arm processors Find CPUs by subsystem rather than driver Sonnet Mark helper exe as non-gui app Allow nsspellcheck to be compiled on mac per default http://kde.org/announcements/kde-frameworks-5.24.0.php -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Review Request 128183: Ignore malformed Queries which have a binary operator without first argument

etected the issue below :-) src/lib/advancedqueryparser.cpp (line 156) <https://git.reviewboard.kde.org/r/128183/#comment65197> No need for a space after the ':', qDebug adds spaces between arguments. - David Faure On June 14, 2016, 6

Re: Review Request 128183: Ignore malformed Queries which have a binary operator without first argument

t; ? Otherwise we get a generic debug statement with no context as to why it's shown. src/lib/advancedqueryparser.cpp (line 159) <https://git.reviewboard.kde.org/r/128183/#comment65167> use 'property' here, to avoid calling .value().toString() again - Dav

Re: Review Request 128176: Remove ifdef'd code needed for Qt version < 5.4.0

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128176/#review96433 --- Ship it! Yeah, sure, delete my code :-) - David Faure

KDE Frameworks 5.23.0 released

theme icons from KDE4 Reload selected color scheme on colors changed http://kde.org/announcements/kde-frameworks-5.23.0.php -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

KDE Frameworks 5.22.0 released

fix saving when ignore words updated Fix failed to save ignore word issue (bug 355973) http://kde.org/announcements/kde-frameworks-5.22.0.php -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

KDE Frameworks 5.21.0 released

dependency Header of plasmaquick_export.h is in plasmaquick folder Install some plasmaquick headers http://kde.org/announcements/kde-frameworks-5.21.0.php -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

KDE Frameworks 5.20.0 released

ack/forward buttons and a "Today" button (bugs 336124, 348362, 358536) Sonnet Don't disable language detection just because a language is set Disable automatic disabling of automatic spelling by default Fix TextBreaks Fix Hunspell dictionary search paths missing '/' (

KDE Frameworks 5.19.0 released

the button is compose-over-borders paintedWidth/paintedheight for IconItem http://kde.org/announcements/kde-frameworks-5.19.0.php -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: libkonq release? I'm missing the favicons interface

ere FavIconRequestJob stores icons. Please port tellico to FavIconRequestJob and report any problems to me (or on the kde-frameworks-devel list, or in bugzilla). I'm interested in your feedback about it (but I guarantee it's good quality to start with, I wrote extensive unit tests for it).

Re: KDE Frameworks 5.18.0 released

tion, won't happen again. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

KDE Frameworks 5.18.0 released

l applet (bug 356428) [Containment Interface] Fix erratic high precision scrolling Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist [Window Thumbnails] Don't crash if Composite is disabled Let containments override CompactApplet.qml http://kde.org/announcements

KDE Frameworks 5.17.0 released

nnecting or disconnecting (bug 354751) [plasmaquick] Don't link OpenGL explicitly [plasmaquick] Drop XCB::COMPOSITE and DAMAGE dependency http://kde.org/announcements/kde-frameworks-5.17.0.php -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 >> Visit

Re: Review Request 125762: External extractor plugin support for KFileMetaData

#comment61012> const QString &extractor src/extractors/externalextractor.cpp (line 94) <https://git.reviewboard.kde.org/r/125762/#comment61011> maybe with a timeout? + error handling? - David Faure On Oct. 24, 2

KDE Frameworks 5.16.0 released

Touchpad to 22x22px size Breeze Icon: add widget icon to notes A script to replace hardcoded colors with stylesheets Apply SkipTaskbar on ExposeEvent Don't set SkipTaskbar on every event http://kde.org/announcements/kde-frameworks-5.16.0.php -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 125762: External extractor plugin support for KFileMetaData

t container, it makes a deep copy. So the rule is simple: * Q_FOREACH on Qt containers * range-for on STL containers (*) (*) after ensuring that all supported compilers can handle it; I thought this was the case btw, but I didn't check that wiki page. - David Faure

KDE Frameworks 5.15.0 released

support static compilation on windows, add windows libreoffice hunspell dict path Do not assume UTF-8 encoded Hunspell dictionaries. (bug 353133) fix Highlighter::setCurrentLanguage() for the case when previous language was invalid (bug 349151) support /usr/share/hunspell as dict location NSSpellCheck

Re: Icons installed by apps

ists consider that these icons should be themeable... BTW did you look into the xdg icon spec? I guess it's not there? On the other hand it doesn't prevent doing it since it's not about sharing icons; it's just harder to convince Qt to look there :) (I think qiconengine and kic

KDE Frameworks 5.14.0 released

ly text cursor fix parenting and popping up policy declare __editMenu add missing cursot handles delegates rewrite the EditMenu implementation use the mobile menu only conditionally reparent the menu to root http://kde.org/announcements/kde-frameworks-5.14.0.php -- David Faure, fa...

Re: Review Request 125130: Use actual method calls in mainadaptor instead of QMetaObject::invokeMethod

code you mean. I would just replace the awful #include which includes also all of QtCore, and replace it with the #include , but other than that, the rest looks useful to me. - David Faure On Sept. 10, 2015, 7:30 a.m., Pinak Ahuja wrote

Re: KF5 with qmake problems

On Thursday 10 September 2015 07:57:11 Oswald Buddenhagen wrote: > On Sun, Sep 06, 2015 at 11:10:29AM +0200, David Faure wrote: > > This seems to be a bug in Qt. > > The code in qtAddModules (qtbase/mkspecs/features/qt_functions.prf ) > > turns "core gui KParts" int

Re: Review Request 125125: Fix D-Bus API breaking compatibility with baloo KCM

> On Sept. 10, 2015, 6:38 a.m., David Faure wrote: > > src/file/mainadaptor.cpp, line 45 > > <https://git.reviewboard.kde.org/r/125125/diff/1/?file=402421#file402421line45> > > > > This could be a real method call instead, so that it doesn't b

Re: Review Request 125125: Fix D-Bus API breaking compatibility with baloo KCM

fic type as parent instead of QObject*) - David Faure On Sept. 10, 2015, 5:28 a.m., Pinak Ahuja wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.revie

Re: Review Request 125124: Install a fake org.kde.baloo.file.indexer.xml to fix compilation of plasma-desktop 5.4

marked as submitted. Review request for Baloo. Changes --- Submitted with commit 5cb3e97675370aab3d49c7b9b8381c3233177f0f by David Faure to branch master. Repository: baloo Description --- Install a fake org.kde.baloo.file.indexer.xml to fix compilation of plasma-desktop 5.4

Re: Review Request 124919: Re-organize D-Bus interfaces

with an empty > file. Since they are not public API they ought not be installed so we'll > eliminate this source of SIC headache for the future, and since plasma > doesn't actively use the file it references, a stub place holder ought to > prevent that from exploding. >

Review Request 125124: Install a fake org.kde.baloo.file.indexer.xml to fix compilation of plasma-desktop 5.4

://git.reviewboard.kde.org/r/125124/diff/ Testing --- plasma-desktop/kcms/baloo compiles after reverting 4b3e8c53b872397b06d19f0176527aaf7ececa36. Thanks, David Faure >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 125098: Fix date string displayed in timeline:/ address bar due to porting to QDate

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125098/#review84993 --- Ship it! Oops :-) - David Faure On Sept. 8, 2015, 12:13

Re: Review Request 124919: Re-organize D-Bus interfaces

> On Aug. 31, 2015, 8:45 a.m., Hrvoje Senjan wrote: > > src/dbus/CMakeLists.txt, line 26 > > > > > > This looks like a SiC change to me, no? e.g. plasma-desktop won't build > > with this commit > > Harald Sitter

Re: Love for Konqueror

Of course the smallest course of action we can take is keep status quo by porting konqueror to KF5 (thanks to Stefano Crocco for his help with that) (what's still missing is migration of kde4 data using the helper classes in KCoreAddons), but the outdated crammed GUI, the uncertain future of Qt-based web engines and the possible issues with KIO integration will still remain Input welcome :) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: KF5 with qmake problems

h all include path of KParts > dependencies are added to the command line... This seems to be a bug in Qt. The code in qtAddModules (qtbase/mkspecs/features/qt_functions.prf ) turns "core gui KParts" into "core gui + all the deps from KParts". But KParts itself is missing.

Re: Accessing KIO from kdelibs4 from two different threads

ections to request a kio operation in the main thread and to receive the result in the secondary thread later. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 124733: Fix build on FreeBSD

? - David Faure On Aug. 14, 2015, 5:03 a.m., Tobias Berner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

KDE Frameworks 5.13.0 released

::findLookAndFeelPackage() Rename software-updates.svgz to software.svgz Sonnet Add in CMake bits to enable building of Voikko plugin. Implement Sonnet::Client factory for Voikko spell chekers. Implement Voikko based spell checker (Sonnet::SpellerPlugin) http://kde.org/announcements/kde-f

Re: Review Request 124602: baloo (kio_timeline) : port away from kdelibs4support

marked as submitted. Review request for Baloo and Vishesh Handa. Changes --- Submitted with commit fa702593d52c84b1a06788ec89810c1ff58ceb64 by David Faure to branch master. Repository: baloo Description --- REVIEW: 124602 Diffs - src/kioslaves/timeline/CMakeLists.txt

Re: Review Request 124602: baloo (kio_timeline) : port away from kdelibs4support

s/timeline/kio_timeline.cpp 11fc8c79ba32cdcfb3508067d3ce15c009442a1f src/kioslaves/timeline/timelinetools.cpp ea5c9fd3171428190a3acada263632adbb9b06a6 Diff: https://git.reviewboard.kde.org/r/124602/diff/ Testing (updated) --- it compiles. Thanks, David Faure >> Visit htt

Review Request 124602: baloo (kio_timeline) : port away from kdelibs4support

863605aefb3c27fff3ba4e9597dde9d93ba88811 Diff: https://git.reviewboard.kde.org/r/124602/diff/ Testing --- it compiles. But please check that the date format (MM , i.e. 01 2015) is the one you wanted. Thanks, David Faure >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#un

Re: Review Request 124597: KFileMetaData: update CMakeLists to match other frameworks

marked as submitted. Review request for Baloo and Vishesh Handa. Changes --- Submitted with commit 07eda6433d62e1d0eed60b27ec2657cf56b395a3 by David Faure to branch master. Repository: kfilemetadata Description --- Use proper KF5 versioning Use KDEFrameworkCompilerSettings which

Review Request 124597: KFileMetaData: update CMakeLists to match other frameworks

/ Testing --- Compiles Thanks, David Faure >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

KDE Frameworks 5.12.0 released

(bug 348154) Whitelist applets/versions for separate engine Introduce a new class ContainmentView Sonnet Allow to use highlight spellchecking in a QPainTextEdit http://kde.org/announcements/kde-frameworks-5.12.0.php -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE F

KDE Frameworks 5.11.0 released

away save() calls by calling it once at the end if needed. http://kde.org/announcements/kde-frameworks-5.11.0.php -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Baloo Widgets and its future

taWidget in 28f714cd6f04d59636c4257bcd9d2d1356c716e4 (kdelibs.git) Feel free to re-instate rename-dialog-plugins. It will help keeping dependencies small. KPropertiesDialog has plugins already. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

KDE Frameworks 5.10.0 released

opened with open() or show() with parent were not opened at all. http://kde.org/announcements/kde-frameworks-5.10.0.php -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

KDE Frameworks 5.7.0 released

14th February 2015. KDE today announces the release of KDE Frameworks 5.7.0. KDE Frameworks are 60 addon libraries to Qt which provide a wide variety of commonly needed functionality in mature, peer reviewed and well tested libraries with friendly licensing terms. For an introduction see the Fr

KDE Frameworks 5.6.0 released

hing for version 1 of a library doesn't give you version 2, for example. Fix ECMQueryQmake when Qt5Core is missing. Frameworkintegration Fix handling of palette change events (bug 336813) http://kde.org/announcements/kde-frameworks-5.6.0.php -- David Faure, fa...@kde.org, http://www.david

Re: KService / KRun / kioexec cannot be started

bug Clearly not related, that's a crash in libbluedevil. (which is used in a kded module). Outside my area of expertise :) -- at least, until I get the same crash here ;) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 >> Visit http://mail.kde.or

Re: kded5

eal apps, as you saw. > I added a Wiki section in the Troubleshooting section: > https://community.kde.org/Frameworks/Building#Couldn.27t_start_kded5_.28KDE4 > .29 OK, thanks. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 >> Visit http://ma

Re: KService / KRun / kioexec cannot be started

Open delete the file right away, i.e. it returns a path to a file that doesn't exist anymore. No wonder kio can't find it. > Update 23:57pm: did you just revert the change? Now, it's again not working. You mean until step 3, launching the app? No I didn't revert anything.

Re: kded5

x27;t visible to your running dbus daemon. One solution is to do what the above wiki page recommends for "running unit tests". This was written before there were real apps to run too :-) eval `dbus-launch` kdeinit5 -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: KService / KRun / kioexec cannot be started

empFiles, > > and then I'll fix it :-) > > Great. :-) Fixed, my unittest works. Turns out it wasn't a command-line parsing problem, at least not the way I thought. These arguments were meant for gwenview, not for kioexec. Can you try again after updating kio? -- David Fau

Re: KService / KRun / kioexec cannot be started

empFiles, and then I'll fix it :-) > > And why is kded5 not running? It's not installed? > > I thought this is maybe normal when developing under KDE4, isn't it? Not really, no. It can run in parallel with kded4, and you need that, for a number of things in KF

Re: KService / KRun / kioexec cannot be started

t; > >> what is the current state of the KService in frameworks branch? > >> > >> I ask because ksnapshot's SendTo menu invokes a KService method to start > >> the chosen application. When I click a menu item the launch indicator > >> appears next

Re: Problems with KItemModels 5.2 and Windows

On Sunday 09 November 2014 23:35:16 Luiz Romário Santana Rios wrote: > Problem solved. I just had to set CMAKE_MODULE_PATH as > $INSTDIR\share\ECM\find-modules. The more usual solution is to set CMAKE_PREFIX_PATH to $INSTDIR. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Work

KDE Frameworks 5.4.0 released

ol and ecm_add_qtwayland_server_protocol Frameworkintegration implement support for setting custom labels in file dialogs http://kde.org/announcements/kde-frameworks-5.4.0.php -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

KF 5.3.0 changelog

kintegration * Fixed for compilation with Qt 5.4 * Fixed a few standard shortcuts -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Problems with KItemModels 5.2 and Windows

ually > couldn't find a more recent version than that. > > What am I missing? Forget about kf5umbrella, it's dead. Instead use FindKF5.cmake from ECM, by writing find_package(KF5 REQUIRED COMPONENTS ItemModels) note: do NOT use CONFIG or NO_MODULE in that line. -- David Fau

KDE Frameworks 5.2.0 release

for relative libexec dir. ### Frameworkintegration * the file dialog now remembers its size correctly, and works better with remote URLs. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Is Konqueror still a live project?

as backend. No they don't. Webkit is the default renderer for konqueror, and rekonq only uses webkit. > (Actually rekonq might even be linked to a newer version of QtWebkit in his > distro and whatnot) Do distros really ship multiple versions of QtWebkit? That would be surprising.

Re: KUrl porting questions

Qt which does this without constructing a full > QUrl or is this still the best approach? Well, there's QDir/QFileInfo for local files, but yeah, I would still recommend using QUrl for the generic case. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Is Konqueror still a live project?

as well as ideas for how the GUI could be improved / re-thought. https://blogs.kde.org/2014/08/16/konqueror-looking-maintainer Thanks for reminding me to finally do this :) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 >> Visit http://mail.k

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

> On Aug. 5, 2014, 6:20 a.m., David Faure wrote: > > Looks good to me. I hope the commit log isn't the same as the reviewboard > > description though - it should be about what the patch does, instead. > > Laurent Navet wrote: > The commit log is : > --

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

t the same as the reviewboard description though - it should be about what the patch does, instead. - David Faure On Aug. 4, 2014, 8:51 p.m., Laurent Navet wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

tps://git.reviewboard.kde.org/r/114933/#comment38106> Use setPlaceHolderText() instead. - David Faure On Jan. 16, 2014, 7:30 p.m., Laurent Navet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.r

Re: WebDAV issues with Konqueror 4.10 (Windows)

e it ignores redirection to the same URL and the comparison it > performs ignores the trailing slash in the redirect to URL? Yes, KDirLister and friends tend to ignore trailing slashes, on purpose. Only WebDav seems to consider it differently. -- David Faure, fa...@kde.org, http://www.davidfaur

Re: WebDAV issues with Konqueror 4.10 (Windows)

gt; I have a few test servers listed on > https://www.pixi.me/webdav.php#targets ready for anyone who has some > spare time to help reproduce my issues. Does a patch like this fix the issue? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Framewo

Re: Any use for uri/* and all/* MIME types?

ext-menu .desktop file, then it could simply be associated with application/octet-stream + inode/directory. Send patches my way :) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: KGlobal::locale() replacement

as to move somewhere then we can do that. I don't have technical answers for this KLocale question, I'm only reacting to "I don't want to link to kde4attic" -- nobody does, but the point is to fix it at the kdelibs level first ;) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Stuck on session restore

splash screens myself - always obscuring things at the wrong > moment. Anyone mind if I just remove it? It's indeed not very common in KDE applications. I wouldn't mind if it went away. You even found a technical reason to do that :-) -- David Faure, fa...@kde.org, http://www.davidfau

Re: kde svn GUIs

w the git repository (converted by Christophe Giboudeaux - thanks!) is at kde:scratch/cgiboudeaux/kdesvn -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: QWidget or QML

is it > recommended to port/create to/in QML? These things are widget-based, use widgets. QML doesn't replace widgets. Different use case. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: KDE/Qt + emacs in Kubuntu

ly KDE/Qt > code deos not have it. Checkout the git module kde-dev-scripts, its subdirectory kde-emacs has everything you need (and more). -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: kde svn GUIs

Le vendredi 21 juin 2013 20:22:39 Albert Astals Cid a écrit : > El Divendres, 21 de juny de 2013, a les 12:14:24, David Faure va escriure: > > I recently discussed with the kdesvn author, Rajko Albrecht, about the > > fact > > that kdesvn is currently unmaintained (and is on

kde svn GUIs

ion and we should therefore ensure that it doesn't disappear? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Nepomuk Tags kioslave - Please Review

On Thursday 22 November 2012 00:24:12 Albert Astals Cid wrote: > El Dimecres, 21 de novembre de 2012, a les 16:15:01, David Faure va escriure: > > On Wednesday 07 November 2012 02:27:17 Albert Astals Cid wrote: > > > Ahh, you mean copying from file: to tags: > > Moving fro

Re: Nepomuk Tags kioslave - Please Review

ts the job done. If we agree about this on principle, then the next step to make it generic could be to add another field in .protocol files, say forceDropAction=(copy|move) The fact that kio_trash needs forceDropAction=move shows that this might make sense, we already have two users for this

Re: Help your marketing team!

rator, x/y selector, ... a lot more coming) XMLGUI, for user-configurable desktop GUIs (menus/toolbars/shortcuts). And a lot more > Please add explanations and links to documentation where possible. Not sure you want links to the code... but right now there isn't much more (like per-fra

Re: Using libk3b to burn an ISO

t; job->setCopies( 1 ); > job->setWritingApp( K3b::WritingAppAuto ); > > qDebug()< job->start(); What's the next line after that (here or probably in the caller, i.e. main(), I guess)? return 0, or return app.exec()? :-) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5 >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Get the source size from KIOSlave

On Tuesday 31 July 2012 10:23:11 Philipp Schmidt wrote: > Hi, > > Am Dienstag, 17. Juli 2012, 13:30:53 schrieb David Faure: > > On Tuesday 17 July 2012 13:16:56 David Faure wrote: > > > kdelibs patch attached, please test. > > > > And now with a new feature:

Re: KDirWatch emits created signal twice

orked, see attached patch. Please compare the situation in the unittest with the situation you're seeing in kdevelop+kate. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5 diff --git a/kdecore/tests/kdirwatch_unittest.cpp b/kdecor

Re: Adding new data members to classes without d-pointer

On Thursday 26 July 2012 07:59:35 Carlos Ernesto Alies Fuentes wrote: > { > FooPrivate* ret = d_func()->value( foo, 0 ); > ///delete is called without validating the pointer > delete ret; That part is OK. Delete NULL is valid C++ (and does nothing). -- David Faure, fa..

Re: Register new user dialog in KDE.

On Thursday 19 July 2012 13:33:20 Thomas Lübking wrote: > Am 19.07.2012, 13:27 Uhr, schrieb David Faure : > > On Thursday 19 July 2012 14:43:49 Dmitry Chernov wrote: > >> Unfortunately KPasswordDialog have no confirm password option ( enter > >> password tw

Re: Register new user dialog in KDE.

On Thursday 19 July 2012 14:43:49 Dmitry Chernov wrote: > Unfortunately KPasswordDialog have no confirm password option ( enter > password two times ). No, but KNewPasswordDialog does. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, inc

Re: Get the source size from KIOSlave

On Tuesday 17 July 2012 13:16:56 David Faure wrote: > kdelibs patch attached, please test. And now with a new feature: compiling. Sorry, doing too many things at the same time :-) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. KDE Framework

Re: Get the source size from KIOSlave

uld be added. kdelibs patch attached, please test. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5 diff --git a/kio/DESIGN.metadata b/kio/DESIGN.metadata index f97b251..0d442d0 100644 --- a/kio/DESIGN.metadata +++ b/kio/DESIGN.m

<    1   2   3   >