D29802: Require out-of-source builds

filipf accepted this revision. REPOSITORY R266 Breeze Icons BRANCH require-in-source-build (branched from master) REVISION DETAIL https://phabricator.kde.org/D29802 To: ngraham, #frameworks, #vdg, ognarb, davidre, apol, nicolasfella, ndavis, tfella, filipf Cc: ltoscano, davidre,

D29740: [PC3 Button] Don't remain in a pressed state after press

filipf added a comment. The more I think about this the more it feels like a workaround. Presuming QQC2's behavior of leaving a pressed button focused after press is correct, perhaps we are at fault for providing the same svg for `focus-background` and `pressed`. REPOSITORY R242 Plasma

D29740: [PC3 Button] Don't remain in a pressed state after press

filipf added a dependent revision: D29741: [Logout] Port to QQC2 and PC3. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29740 To: filipf, davidedmundson, mart, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29740: [PC3 Button] Don't remain in a pressed state after press

filipf edited the summary of this revision. filipf edited the test plan for this revision. filipf added reviewers: davidedmundson, mart, Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29740 To: filipf, davidedmundson, mart, #plasma Cc:

D29740: [PC3 Button] Don't remain in a pressed state after press

filipf created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. filipf requested review of this revision. REVISION SUMMARY We have two interfering button background items right now: - surfaceNormal when it has activeFocus and is using

Re: Adding a patch to 5.70

Thank you, David! On Sun, May 3, 2020 at 7:08 PM David Faure wrote: > On Sunday, May 3, 2020 6:31:44 PM CEST Filip Fila wrote: > > Dear Frameworks maintainers, > > > > Would it be possible to add this (https://phabricator.kde.org/D29352) > patch > > to the 5.

Adding a patch to 5.70

Dear Frameworks maintainers, Would it be possible to add this (https://phabricator.kde.org/D29352) patch to the 5.70 release? The change concerns not breaking third-party Plasma themes, and as Nate explained "If this doesn't land in Frameworks 5.70, Plasma 5.19 users run the risk of being hit by

D29352: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme

This revision was automatically updated to reflect the committed changes. Closed by commit R242:1b1018e68703: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme (authored by filipf). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D29352: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme

filipf edited the test plan for this revision. filipf added reviewers: VDG, Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29352 To: filipf, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29352: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme

filipf created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. filipf requested review of this revision. REVISION SUMMARY We're the only theme with the appropriate heading svgs that make the headers and footers look as they should. All

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

filipf added a comment. LGTM REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D27299: Vertically center tooltip icon/image

filipf accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH vertically-center-tooltip-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D27299 To: ngraham, #vdg, #plasma, filipf Cc:

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

filipf added a comment. Right, I also noticed the color-aware theme now has somewhat more pronounced discrepancy between the panel and the popups when dark color schemes are used. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To:

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

filipf added a comment. Arcpatched and compiled and I was getting an overly transparent Breeze Dark: F8094138: image.png It was only when I turned Contrast Effect off and then on again that I was seeing what's in the test plan. We should

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

filipf added a comment. I really like this all in all, and the light version looks ready to go. The transparency in the dark one if fine IMO, it's just that the Breeze Dark color scheme should be somewhat darker and then the Plasma theme would also be darker. What's more important

D25015: Update breeze theme shadows

This revision was automatically updated to reflect the committed changes. Closed by commit R242:35351ba3f299: Update breeze theme shadows (authored by niccolove, committed by filipf). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D25999: Add optional subtitle to grid delegate

filipf added a comment. ^ No, it seems to be GridDelegate actually. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25999 To: ngraham, #vdg, #plasma, davidedmundson Cc: filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25999: Add optional subtitle to grid delegate

filipf added a comment. In D25999#577780 , @ngraham wrote: > It does, because we can't know in advance whether or not any delegates will set a subtitle. Actually... can we know this? Yeah if we could it wouldn't be bad to add a

D25999: Add optional subtitle to grid delegate

filipf added a comment. Thanks, I'll tweak my patch to use this. Does the implementation increase the horizontal spacing between delegates even if there are no subtitles present? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25999 To: ngraham, #vdg,

D25999: Add optional subtitle to grid delegate

filipf added a dependent revision: D25785: [Plasma Style KCM] Add a color-wheel sign denoting the theme supports the system color scheme. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25999 To: ngraham, #vdg, #plasma, davidedmundson Cc: kde-frameworks-devel,

D25927: [PC3] Complete plasma progress bar animation

filipf accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D25927 To: davidedmundson, filipf Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25926: [PC3] Only show progress bar indicator when the ends won't overlap

filipf accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D25926 To: davidedmundson, #plasma, filipf Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

filipf added a comment. In D25699#576444 , @fvogt wrote: > This fixed the button label, but the menu itself is unsuable due to a black text on dark background: https://openqa.opensuse.org/tests/1110939#step/start_wayland_plasma5/21

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

filipf added a comment. Let's track the arrow issue in: https://bugs.kde.org/show_bug.cgi?id=415049 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25699 To: filipf, #plasma, ngraham, davidedmundson Cc: mart, davidedmundson, fvogt,

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

This revision was automatically updated to reflect the committed changes. Closed by commit R242:e4e1613b0fe7: [PC3 ToolButton] Have the label take into account complementary color schemes (authored by filipf). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

filipf edited the summary of this revision. filipf edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH ok-text-colo (branched from master) REVISION DETAIL https://phabricator.kde.org/D25699 To: filipf, #plasma, ngraham, davidedmundson Cc: mart,

D25814: [KColorScheme] Add SeparatorColor

filipf added a comment. In D25814#574389 , @ngraham wrote: > In D25814#574380 , @ndavis wrote: > > > FWIW, Adwaita Dark uses dark separators, but GNOME doesn't use nearly as many icons as we do.

D25822: Add manual test for changing colorscope in components

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. Thanks again :) REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D25822 To: davidedmundson, filipf Cc: ngraham,

D25822: Add manual test for changing colorscope in components

filipf added a comment. In D25822#574271 , @ngraham wrote: > Nice. Does this fix or obsolete D25699 ? No, this just for easier testing of all the components with the complementary theme. REPOSITORY

D25822: Add manual test for changing colorscope in components

filipf added a comment. Thanks! It will be easier to test now. I noticed some issues with certain tests, although most seem to have already existed: - busyindicator3.qml -> loads, but complains about a binding loop detected for `implicitHeight` - button3.qml -> doesn't load, says

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

filipf added subscribers: davidedmundson, mart. filipf added a comment. Yeah, PC2 ToolButton has this so it loads the arrow: https://github.com/KDE/plasma-framework/blob/master/src/declarativeimports/plasmastyle/ToolButtonStyle.qml#L110 For PC3 I guess we would have to hack it in in the

D25820: SimpleScreenRecorder icon added

filipf added a comment. I agree, I think brighter and slightly less saturated colors would look nice. Thank you for adding this btw, the old icon doesn't fit in. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25820 To: vinzenzv, #vdg, ndavis Cc: filipf,

D25814: [KColorScheme] Add SeparatorColor

filipf added a comment. I think this is useful. Every once in a while we get opinionated people who think light separators are awful in the Breeze Dark scheme (I would hate dark ones on the other hand) or even some ricer people who want to turn off separators (which they could do now by

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

filipf added a comment. In D25699#573713 , @fvogt wrote: > The check for the prefix was added in `bf1d1cc6b2ad37cb586f44b56fa2438ed3a5dbfc`, while the `control.flat` one got added much earlier. > > The labels are visible again with just the

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

filipf edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH ok-text-colo (branched from master) REVISION DETAIL https://phabricator.kde.org/D25699 To: filipf, #plasma, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

filipf added a comment. In D25340#563400 , @ndavis wrote: > This diff is against commit 467d721cc96258b54048c0dd1508d16e03c0cd55, which isn't in git master. Do I actually need that commit for this patch to work? A similar issue still

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

filipf edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25699 To: filipf, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

filipf edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25699 To: filipf, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

filipf edited the test plan for this revision. filipf added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25699 To: filipf, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

filipf created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. filipf requested review of this revision. REVISION SUMMARY We've ported the SDDM theme to PC3 and now have black labels in PC3 ToolButtons (keyboard and session button). The

D25015: Update breeze theme shadows

filipf added a comment. My impression is that the rounding is currently just faked by the shadow. So when the shadow gets lighter, it becomes more obvious that the object itself isn't really rounded. F7787609: image.png REPOSITORY R242 Plasma

D25015: Update breeze theme shadows

filipf added a comment. +1 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25015 To: niccolove, #vdg Cc: cblack, ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25015: Update breeze theme shadows

filipf added a comment. Before: F7746042: Screenshot_20191107_083508.png After: F7746044: Screenshot_20191107_083534.png REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D25015: Update breeze theme shadows

filipf added a comment. There's definitely a difference, whereas the shadows are now rough and dark this is subtler. I'd suggest testing this patch with a light color scheme and then switching to the unpatched theme plus testing against light backgrounds to notice the changes.

D25015: Update breeze theme shadows

filipf added a comment. I'd prefer the shadows to have equal strength all around, I couldn't get used to weaker shadows in the corners. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25015 To: niccolove, #vdg Cc: manueljlin, ngraham, filipf,

D25015: Update breeze theme shadows

filipf added a comment. Testing it. Usability wise the strength is perfectly fine; the shadows still do their job. Visually it's a definitive improvement for me. Only thing I'm not sure of is the weaker strength in the corners, but I'm going to keep testing to see if it's just a

D24593: Modified breeze shadows

filipf added a comment. > b) radial gradients instead of linear on the four sides to make the center darker than the angles. Other than this, they look great to me. I think they should be uniformly dispersed. One of the things with shadows is that the user shouldn't really notice

D23627: Make notification icons use outline style

filipf added a comment. +1, looks good, thanks for centering the clapper as well REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23627 To: ndavis, #vdg, #plasma Cc: filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23286: Prevent dragging SimpleKCM contents outside view

filipf added a comment. +1 visually If the behavior is important on mobile let's keep it there of course, but on desktop it feel out of place. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D23286 To: GB_2, #plasma, #frameworks, #vdg Cc: filipf, broulik,

D23285: Prevent dragging QQC2 ComboBox contents outside menu

filipf accepted this revision. This revision is now accepted and ready to land. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH prevent-dragging-qqc2-combobox-contents-outside-menu (branched from master) REVISION DETAIL https://phabricator.kde.org/D23285 To: GB_2, #plasma,

D22822: Add "users-other" icon

filipf added a reviewer: ndavis. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22822 To: GB_2, #vdg, ndavis Cc: kde-frameworks-devel, #vdg, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22827: Scrollview - Don't fill the parent with the view

filipf added a comment. Also fixes the Virtual Desktops KCM fwiw F7120294: image.png F7120298: image.png REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22827 To: davidre,

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

filipf accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH grid-delegate-rectangle (branched from master) REVISION DETAIL https://phabricator.kde.org/D20140 To: ndavis, #plasma, #vdg, filipf Cc: filipf, GB_2, ngraham,

D22108: [TabBar] Remove exterior margins

This revision was automatically updated to reflect the committed changes. Closed by commit R242:97272465a8b4: [TabBar] Remove exterior margins (authored by filipf). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22108?vs=60704=60896

D21813: RFC: Consider adding more padding to the desktop theme

filipf added a comment. friendly ping @ndavis would you be willing to give it a go at making a proper patch for this (i.e. editing the Breeze svg)? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21813 To: filipf, #plasma, #vdg, ngraham,

D22108: [TabBar] Remove exterior margins

filipf added a comment. In D22108#487218 , @ndavis wrote: > 1+ visually. How does it look with a vertical panel? Still not gliding on the line, but that should be resolved in Kickoff somehow: F6938487: image.png

D22108: [TabBar] Remove exterior margins

filipf added a comment. In D22108#487140 , @apol wrote: > Makes sense to me, but why are the computer icons different? ^^' Some bug in Kickoff or with the icon, sometimes (maybe after you change a desktop theme) it shows the laptop icon,

D22108: [TabBar] Remove exterior margins

filipf edited the test plan for this revision. filipf added reviewers: VDG, Plasma, ngraham. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D22108 To: filipf, #vdg, #plasma, ngraham Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22108: [TabBar] Remove exterior margins

filipf created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. filipf requested review of this revision. REVISION SUMMARY This allows us to glide active tabbar indicators on lines, which we cannot do now in Kickoff due to this limitation in

D22102: Implement apply-on-double-click for all grid view KCM delegates

filipf added a comment. Generally +1, but let's disable it for destructive kcms. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22102 To: ngraham, #plasma, #vdg, mart, broulik Cc: filipf, mglb, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21907: Show feedback inline when creating new files or folders

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. Looks good from a visual and usability POV. REPOSITORY R241 KIO BRANCH better-new-file-folder-info (branched from master) REVISION DETAIL https://phabricator.kde.org/D21907 To:

D21919: Change joystick settings icon to game controller

filipf accepted this revision. REPOSITORY R266 Breeze Icons BRANCH joystick-settings (branched from master) REVISION DETAIL https://phabricator.kde.org/D21919 To: ndavis, #vdg, ngraham, filipf Cc: usta, davidedmundson, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21813: RFC: Consider adding more padding to the desktop theme

filipf added a comment. In D21813#481152 , @martinsotirov wrote: > I think Plasma needs a whole lot more padding all over the place, not just in the notifications, but I guess there must be some kind of compromise with all the people who like

D21813: RFC: Consider adding more padding to the desktop theme

filipf added a comment. In D21813#479950 , @ndavis wrote: > Besides the notifications, where does this add padding? OSDs as far as I can tell, which are also actually not that roomy: F6890931: Screenshot_20190615_021457.png

D21813: RFC: Consider adding more padding to the desktop theme

filipf edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21813 To: filipf, #plasma, #vdg, ngraham, broulik Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21813: RFC: Consider adding more padding to the desktop theme

filipf edited the test plan for this revision. filipf added reviewers: Plasma, VDG, ngraham, broulik. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21813 To: filipf, #plasma, #vdg, ngraham, broulik Cc: kde-frameworks-devel, LeGast00n, michaelh,

D21813: RFC: Consider adding more padding to the desktop theme

filipf created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. filipf requested review of this revision. REVISION SUMMARY Instead of tweaking every plasmoid, add a bit more padding to the desktop theme. This would be an alternative

D21415: Fix the alignment of the label of the toolbutton

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. This is indeed not working as in PC2 so the change seems to be OK. I used the following code to test in qmlscene import QtQuick 2.12 import org.kde.plasma.components 3.0 as

D21523: Add 22px notifications icons

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. Looks good, but also just a few words to the description about why we need this. REPOSITORY R266 Breeze Icons BRANCH notifications-22px (branched from master) REVISION DETAIL

D21521: Make Breeze Dark use same Kolourpaint icon as Breeze

filipf accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH kolourpaint-app (branched from master) REVISION DETAIL https://phabricator.kde.org/D21521 To: ndavis, #vdg, filipf Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21378: Make Breeze Light/Dark use more system colors

filipf added a comment. In D21378#469611 , @ndavis wrote: > In D21378#469607 , @filipf wrote: > > > So I have a light widget color scheme, but I want to be using a dark Plasma theme. My color scheme

D21378: Make Breeze Light/Dark use more system colors

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. So I have a light widget color scheme, but I want to be using a dark Plasma theme. My color scheme is a bit funky and when I use Breeze Dark it doesn't respect my colors. So this is a good

D15814: show all borders for pop up windows in a dock

filipf added a reviewer: VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15814 To: mvourlakos, #plasma, broulik, davidedmundson, kossebau, #vdg Cc: kossebau, abetts, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D20977: [KeySequenceItem] Make the clear button have the same height as shortcut button

This revision was automatically updated to reflect the committed changes. Closed by commit R296:a2e42b49: [KeySequenceItem] Make the clear button have the same height as shortcut button (authored by filipf). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE

D20977: [KeySequenceItem] Make the clear button have the same height as shortcut button

filipf edited the summary of this revision. filipf edited the test plan for this revision. filipf added reviewers: VDG, ngraham, Frameworks. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D20977 To: filipf, #vdg, ngraham, #frameworks Cc: kde-frameworks-devel,

D20977: [KeySequenceItem] Make the clear button have the same height as shortcut button

filipf created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. filipf requested review of this revision. REVISION SUMMARY Because the shortcut button has text inside it, its height is increased, which leaves the clear button shorter. We want

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

filipf added a comment. Which still leaves you with fixing the gaps when there's not thumbnail. I'd suggest to do: `radius: thumbnailAvailable ? 0 : Kirigami.Units.smallSpacing / 2` and call it a day :P REPOSITORY R296 KDeclarative REVISION DETAIL

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

filipf added a comment. You can fix the rounding bleeding into image previews by doing the following at line 116: `radius: thumbnailAvailable ? 0 : Kirigami.Units.smallSpacing` F6800947: image.png REPOSITORY R296 KDeclarative REVISION

D19812: Add a web page to view and compare icons of different sizes

filipf added a comment. In D19812#456848 , @ngraham wrote: > What is this giant javascript file with no whitespace that you're adding? I really don't like how it's formatted in such a way that makes the code practically impossible to read. This

D20672: Add an icon for Thunderbolt KCM

filipf added a comment. In D20672#452757 , @ngraham wrote: > Even better! I think that gradient ends up a bit too light on top though. Let's make it a bit more subtle. +1 REPOSITORY R266 Breeze Icons REVISION DETAIL

D20673: [Properties dialog] Use the string "Free space" instead of "Disk usage"

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. Makes more sense. REPOSITORY R241 KIO BRANCH improve-free-space-string (branched from master) REVISION DETAIL https://phabricator.kde.org/D20673 To: ngraham, #vdg, filipf Cc:

D20392: Use more appropriate "Alternatives" icon and text

filipf accepted this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH use-new-alternatives-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D20392 To: ngraham, #vdg, #plasma, GB_2, filipf Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20342: Update KDE logo to be closer to original

filipf accepted this revision as: filipf. filipf added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY R266 Breeze Icons BRANCH update-kde-logo-to-be-closer-to-original (branched from master) REVISION DETAIL https://phabricator.kde.org/D20342

D20342: Update KDE logo to be closer to original

filipf added a comment. So what I'm seeing is that the gradient has been toned down, which also results in a slight color change in general. FWIW I like the older version more because the new one seems flat(ter) in comparison. Not to long ago someone in VDG actually remarked that the

D15872: Fix Oxygen background gradient for QML modules

filipf added a reviewer: Plasma. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D15872 To: hwti, mart, #vdg, #plasma Cc: filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15872: Fix Oxygen background gradient for QML modules

filipf added a comment. Ping. Is this actually what's been causing the following problem? F6753947: image.png REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D15872 To: hwti, mart, #vdg Cc: filipf,

D20063: Sublime Merge Icon.

filipf added a comment. Looks good. Since it's a proprietary program just check if they have any restrictions about having to use their icons. And yep, the xmlerrors file should be removed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20063 To: otavva,

D17469: Give applications-games and input-gaming more contrast with Breeze Dark

filipf accepted this revision. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D17469 (branched from master) REVISION DETAIL https://phabricator.kde.org/D17469 To: ndavis, #breeze, #vdg, guoyunhe, ngraham, rooty, filipf Cc: rooty, abetts, ngraham, pstefan, ndavis, kde-frameworks-devel,

D19530: Avoid fractionals in GridDelegate sizes and alignments

filipf added a comment. In D19530#424922 , @rooty wrote: > A lot easier on the eyes now, really nice fix > > This'll be landing in 5.16? KF 5.57 as far as I can tell. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL

D19530: Avoid fractionals in GridDelegate sizes and alignments

filipf added a comment. David this really does fix it! Previews are nice and sharp everywhere now. See before: F6657490: Screenshot_20190304_173527.png And after: F6657492: Screenshot_20190304_231358.png

D18986: [breeze-icons] Add video camera icons

filipf added a comment. It's perhaps not the most used video camera design, but I'm cool with this. I too wouldn't use the Plasma icon; it makes more sense to put some multimedia icon there. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18986 To: rooty,

D19020: [breeze-icons] Revamp system.svgz

filipf added a comment. I think the current revision is quite nice. We could always pick apart details and other potential solutions, but the icons get the point across and look good. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To:

D19047: [GridDelegate] Fix long labels blending into each other

filipf edited the summary of this revision. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D19047 To: filipf, #frameworks, ngraham, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19047: [GridDelegate] Fix long labels blending into each other

filipf added a comment. In D19047#413025 , @ngraham wrote: > +1, definitely the correct fix. > > Let's land this now and then we can work on the UI improvement of enabling multi-line strings in another patch. Okay! :) REPOSITORY

D19047: [GridDelegate] Fix long labels blending into each other

filipf created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. filipf requested review of this revision. REVISION SUMMARY This patch anchors the GridDelegate's label width and height to the thumbnail, as opposed to the parent. NOTE: I'm

D19047: [GridDelegate] Fix long labels blending into each other

filipf edited the summary of this revision. filipf edited the test plan for this revision. filipf added reviewers: Frameworks, ngraham, VDG. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D19047 To: filipf, #frameworks, ngraham, #vdg Cc: kde-frameworks-devel,

D18940: Add battery icons

filipf added a comment. Nice. Shouldn't the plug here be green, same as everywhere else? F6611280: image.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18940 To: ndavis, #vdg, hein Cc: filipf, trickyricky26,

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

filipf added a comment. Round buttons looked nice, but the square buttons fit in a lot more with Breeze. As for the color, in a vacuum I think the dark buttons look better, but contextually they feel weird to me as well. We're used to everything following the color scheme. Inline

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

filipf added a comment. ^ I agree, I really like that emblems solution now that I've seen it. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18649 To: ngraham, #vdg, #plasma, broulik Cc: andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, ngraham,

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

filipf added a comment. There's definitely a legibility issue here. I do, however, think the gradient is a sleeker solution. The problem for me has actually been with the icons themselves. They're too scrawny and become more legible when thicker: F6582065: Screenshot_20190202_001342.png

  1   2   >