Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-25 Thread Harald Sitter
have to revert this before release. [1] https://aur.archlinux.org/packages/plasma-desktop-git/ Harald Sitter wrote: I tried it this morning and it seemed to work. Now I try it again and it fails I suppose this is the point where we call for a revert hammer? :P from

Review Request 124916: also make kwindowsystem a module rather than a shared lib

2015-08-25 Thread Harald Sitter
Diff: https://git.reviewboard.kde.org/r/124916/diff/ Testing --- make make install Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-25 Thread Harald Sitter
Frameworks, Plasma, and Harald Sitter. Bugs: 342962 https://bugs.kde.org/show_bug.cgi?id=342962 Repository: kdeclarative Description --- The kdeclarative plugins (draganddropplugin, kcoreaddonsplugin, kio, kquickcontrolsprivateplugin, and kquickcontrolsaddonsplugin

Re: kdesudo in git

2015-08-20 Thread Harald Sitter
On Thu, Aug 20, 2015 at 3:28 PM, Jonathan Riddell j...@jriddell.org wrote: On Thu, Aug 20, 2015 at 02:01:58PM +0200, Luigi Toscano wrote: Maybe it's possible to change kdesu to expose a please cache this property between backend and frontend (in a secure way). Better than keeping two programs

Re: Review Request 124610: do not install namelink for private library

2015-08-12 Thread Harald Sitter
marked as submitted. Review request for Baloo, Build System and KDE Frameworks. Changes --- Submitted with commit 9807ff7416f651a0daf289b7bd024a7bb9952f99 by Harald Sitter to branch master. Repository: baloo Description --- please note that the private target is appearing

Re: Review Request 124610: do not install namelink for private library

2015-08-04 Thread Harald Sitter
--- On Aug. 4, 2015, 8:04 a.m., Harald Sitter wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124610/ --- (Updated Aug. 4

Review Request 124611: do not install namelink for private library

2015-08-04 Thread Harald Sitter
installed Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 124610: do not install namelink for private library

2015-08-04 Thread Harald Sitter
installed made sure there is no symlink on the system and rebuilt gwenview: gwenview builds just fine Thanks, Harald Sitter Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe

Re: Help wanted to evolve KDEs music players

2015-08-01 Thread Harald Sitter
Ahoy ahoy, ramblings ahead! On Thu, Jul 30, 2015 at 12:42 PM, Stefan Derkits ste...@derkits.at wrote: This music player should not replace Amarok or other great Qt-based music players like Tomahawk or Clementine, as their feature set is much bigger than this new music player should ever have.

Re: Review Request 124357: ditch shebang as it is worthless when not installing with +x

2015-07-27 Thread Harald Sitter
marked as submitted. Review request for Baloo. Changes --- Submitted with commit 1a304c9f08eaf09267a64984b5941c1c977d6729 by Harald Sitter to branch master. Repository: baloo Description --- ditch shebang as it is worthless when not installing with +x Diffs - src/tools

Review Request 124357: ditch shebang as it is worthless when not installing with +x

2015-07-15 Thread Harald Sitter
shebang as it is worthless when not installing with +x Diffs - src/tools/baloo-monitor/org.kde.baloo-monitor.desktop fe8a2b88788687ea24c77ee8d3b6ffcd001a17a8 Diff: https://git.reviewboard.kde.org/r/124357/diff/ Testing --- Thanks, Harald Sitter Visit http://mail.kde.org

Re: Review Request 124208: Fallback for componentFriendlyForAction name resolving

2015-06-29 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124208/#review81855 --- Ship it! Ship It! - Harald Sitter On June 29, 2015, 9:18

Re: Review Request 124138: Install kconfig_compiler into libexec

2015-06-22 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124138/#review81690 --- Ship it! Ship It! - Harald Sitter On June 21, 2015, 4:15

Re: Review Request 124104: Make it possible to use kconfig_compiler from different sources

2015-06-17 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124104/#review81545 --- Ship it! Ship It! - Harald Sitter On June 18, 2015, 1:19

Re: bluez qt bic sic - soversion regression

2015-06-04 Thread Harald Sitter
thanks, confirmed fixed :) On Thu, Jun 4, 2015 at 9:41 AM, David Rosca now...@gmail.com wrote: Fixed now, sorry about that. David On Thu, Jun 4, 2015 at 6:24 PM, Harald Sitter sit...@kde.org wrote: alohas this commit http://quickgit.kde.org/?p=bluez-qt.gita=commith

bluez qt bic sic - soversion regression

2015-06-04 Thread Harald Sitter
alohas this commit http://quickgit.kde.org/?p=bluez-qt.gita=commith=7e05a4a4fae19550b1dcc11e5a363a0884b5f8d8 removed the soversion6 which is needed as the present API is incompatible with the one released as 5.3.x needs to be brought back. kthxbai

Re: Qt -fPIC building suggestion

2015-05-22 Thread Harald Sitter
On Fri, May 22, 2015 at 7:48 PM, Jeremy Whiting jpwhit...@kde.org wrote: I also tried adding SET(CMAKE_POSITION_INDEPENDENT_CODE ON) to phonon's CMakeLists.txt, with the same result. that feature only sets PIE on actual executable targets and PIC on library targets. relevant RR:

Re: Review Request 123768: port to new ecm_add_test PROPERTIES argument

2015-05-15 Thread Harald Sitter
marked as submitted. Review request for KDE Frameworks and Network Management. Changes --- Submitted with commit 38fe9333d5ae052c04ef0a65258ce4edbf3287dd by Harald Sitter to branch master. Repository: modemmanager-qt Description --- port to new ecm_add_test PROPERTIES argument

purpose bugzilla product

2015-05-15 Thread Harald Sitter
could someone please create a bugzilla product for purpose tia HS ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 123768: port to new ecm_add_test PROPERTIES argument

2015-05-13 Thread Harald Sitter
Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

kconfiggui symbol retraction

2015-05-12 Thread Harald Sitter
not quite sure how it got lost - _ZN10KConfigGui17sessionConfigNameEv@Base 4.97.0 + _ZN10KConfigGui16setSessionConfigERK7QStringS2_@Base 5.9.0+git20150512.0743+15.04-0 +#MISSING: 5.9.0+git20150512.0743+15.04-0# _ZN10KConfigGui17sessionConfigNameEv@Base 4.97.0

Re: kconfiggui symbol retraction

2015-05-12 Thread Harald Sitter
On Tue, May 12, 2015 at 12:51 PM, David Faure fa...@kde.org wrote: On Tuesday 12 May 2015 11:57:44 Harald Sitter wrote: not quite sure how it got lost - _ZN10KConfigGui17sessionConfigNameEv@Base 4.97.0 + _ZN10KConfigGui16setSessionConfigERK7QStringS2_@Base 5.9.0+git20150512.0743+15.04-0

dragon: merged frameworks to master

2015-04-09 Thread Harald Sitter
I just merged the frameworks branch of dragon into master. Master is now using kf5 and will be released in the next major KDE Applications release. HS Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe

Re: cmake CMP0028 missing targets - what does one do about it?

2015-04-02 Thread Harald Sitter
On Wed, Apr 1, 2015 at 10:41 PM, Alex Merry alex.me...@kde.org wrote: On Wednesday 01 April 2015 21:39:45 Alex Merry wrote: This appears to be a regression with the 3.0 branch of CMake. 2.8.12 doesn't have an issue, and neither does 3.1.3. For reference:

Re: cmake CMP0028 missing targets - what does one do about it?

2015-04-01 Thread Harald Sitter
On Tue, Mar 31, 2015 at 9:29 PM, Alex Merry alex.me...@kde.org wrote: On Thursday 19 March 2015 14:16:35 Harald Sitter wrote: Problem tldr: target A links library B, A doesn't get the includes of link libraries of B by default. e.g. A links B, B links karchive, A doesn't have access

releasme kdelibs4 now in a branch, master releases kf5 software

2015-03-24 Thread Harald Sitter
おはよう kde:releasme the ever so fancy release script has its branches moved around. master: releases kf5 software, new commands, quite a bit smarter [1] kdelibs4: releases kdelibs4 software, previous master (the previous rewrite branch is abandoned now) [1]

Re: [Kde-hardware-devel] Review Request 123047: explicitly find and use kdbusaddons

2015-03-19 Thread Harald Sitter
marked as submitted. Review request for Plasma and Solid. Changes --- Submitted with commit f82a0196dbc5623c137c14e3a7105afb799f77eb by Harald Sitter to branch Plasma/5.2. Repository: powerdevil Description --- the kded module needs the KDEDModule header which is provided

cmake CMP0028 missing targets - what does one do about it?

2015-03-19 Thread Harald Sitter
alohas While investigating a wall of build failures in the kubuntu ci this morning I stumbled upon a very interesting problem. Problem tldr: target A links library B, A doesn't get the includes of link libraries of B by default. e.g. A links B, B links karchive, A doesn't have access to the

Re: Review Request 122812: Fix BIC introduced in kdelibs 4

2015-03-05 Thread Harald Sitter
at this point. - Harald Sitter On March 4, 2015, 5:26 p.m., Andrea Iacovitti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122812

KHTML binary incompatible change

2015-03-04 Thread Harald Sitter
Ahoy, As of 2015-03-03 KHTML has a commit that renames a public function of the DOMString class introduced in KF5.5 last year. This constitutes a binary and source incompatible change that should either be revisited to be made compatible or the libKF5KHtml.so version needs to be increased to 6

Re: KHTML binary incompatible change

2015-03-04 Thread Harald Sitter
On Wed, Mar 4, 2015 at 9:55 AM, Luigi Toscano luigi.tosc...@tiscali.it wrote: Il 04 marzo 2015 09:50:32 CET, Harald Sitter sit...@kde.org ha scritto: Ahoy, As of 2015-03-03 KHTML has a commit that renames a public function of the DOMString class introduced in KF5.5 last year. This constitutes

Re: Kdenlive joining KDE Applications (in kdemultimedia?)

2015-02-18 Thread Harald Sitter
On Fri, Feb 13, 2015 at 5:31 PM, Vincent Pinon vpi...@kde.org wrote: So this mail is to get your feedback and prepare the move, if OK for you. It appears to me that at least once there is an mkpath call missing before trying to write a file http://i.imgur.com/QkDMTiC.jpg Also all buttons in the

Re: Kdenlive joining KDE Applications (in kdemultimedia?)

2015-02-18 Thread Harald Sitter
On Wed, Feb 18, 2015 at 3:23 PM, Vincent Pinon vpi...@kde.org wrote: Le mercredi 18 février 2015, 10:03:28 Harald Sitter a écrit : MLT not having had a release worries me a bit though. That is pretty much a show-stopper. Do we have an approximate date for when they intend to release? Release

Re: New framework: KXmlRpcClient

2015-02-13 Thread Harald Sitter
On Thu, Feb 12, 2015 at 8:25 PM, Albert Astals Cid aa...@kde.org wrote: El Dijous, 12 de febrer de 2015, a les 12:31:14, Daniel Vrátil va escriure: On Friday, January 30, 2015 09:12:01 AM David Faure wrote: On Wednesday 28 January 2015 17:12:04 Daniel Vrátil wrote: I guess I should update

Re: Review Request 122404: [OS X]: draft support for audio in the IOKit backend

2015-02-03 Thread Harald Sitter
in turn is pulseaudio listing || backend listing). So, enabling VLC to expose this information through the libvlc_audio_output_device enumerable would be the best course of action. If the VLC devs don't want that or whatever, then putting it in Phonon seems the most useful approach. - Harald

Re: [Kde-hardware-devel] Review Request 122404: [OS X]: draft support for audio in the IOKit backend

2015-02-03 Thread Harald Sitter
in turn is pulseaudio listing || backend listing). So, enabling VLC to expose this information through the libvlc_audio_output_device enumerable would be the best course of action. If the VLC devs don't want that or whatever, then putting it in Phonon seems the most useful approach. - Harald

Re: backwards compatibility how namespacing might help or not

2015-01-28 Thread Harald Sitter
On Wed, Jan 28, 2015 at 1:56 AM, Vishesh Handa m...@vhanda.in wrote: On Tue, Jan 27, 2015 at 10:28 AM, Harald Sitter sit...@kde.org wrote: So yes, a better way of moving thing arounds is needed, or maybe we just need the dust to settle a bit so that we realize where each thing really

Re: backwards compatibility how namespacing might help or not

2015-01-27 Thread Harald Sitter
On Mon, Jan 26, 2015 at 10:01 PM, Albert Astals Cid aa...@kde.org wrote: Yeah, i don't think that what you suggest really helps much, otherwise you'd end up with two kglobalaccels running at the same time, which is probably a very bad thing. It's dbus invoked, so in the kglobaccel case

backwards compatibility how namespacing might help or not

2015-01-26 Thread Harald Sitter
ahoy ahoy so... kf5.7 will contain kglobalacceld5 plasma5.2 will also contain kglobalacceld5 if it was built with kf5.6 this poses a binary conflict which makes kf5.7 not a simple drop-in replacement for kf5.6 without recompiling plasma, which effectively makes this new construct just like the

Re: kio-extras

2015-01-23 Thread Harald Sitter
On Thu, Jan 22, 2015 at 11:42 AM, Jonathan Riddell j...@jriddell.org wrote: kio-extras is currently released part of Plasma 5. It's need said that it would be better to be part of applications because they're plugins used by applications and typically not by the desktop. They are plugins used

qca-qt5 2.1.0.1

2015-01-08 Thread Harald Sitter
お早う As some of you might know qca's qt5/qt4 co-installability is a bit of an issue with the maintainer not wanting to force a unified suffix for qt5 builds so here is a grand unified version with a forced qt5 suffix:

Review Request 121833: add reviewboardrc, targets kdeframeworks and plasma groups

2015-01-04 Thread Harald Sitter
Description --- add reviewbaordrc, targets kdeframeworks and plasma groups Diffs - .reviewboardrc PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121833/diff/ Testing --- made this here review request Thanks, Harald Sitter

Review Request 121834: rename kpackagetool manpage to kpackagetool5

2015-01-04 Thread Harald Sitter
8f6fe5a198329528692d3edf30ea5d4e36932872 Diff: https://git.reviewboard.kde.org/r/121834/diff/ Testing --- make install make test man kpackagetool5; all good Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 121833: add reviewboardrc, targets kdeframeworks and plasma groups

2015-01-04 Thread Harald Sitter
this here review request Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121836: remove autotests/dynamictreemodel.h

2015-01-04 Thread Harald Sitter
://git.reviewboard.kde.org/r/121836/diff/ Testing --- make install test; all good Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121836: remove autotests/dynamictreemodel.h

2015-01-04 Thread Harald Sitter
/dynamictreemodel.h 283d6ed3f938c5d7d69504ced36e11e437d2aaad Diff: https://git.reviewboard.kde.org/r/121836/diff/ Testing --- make install test; all good Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 121834: rename kpackagetool manpage to kpackagetool5

2015-01-04 Thread Harald Sitter
docs/kpackagetool/man-kpackagetool.1.docbook 8f6fe5a198329528692d3edf30ea5d4e36932872 Diff: https://git.reviewboard.kde.org/r/121834/diff/ Testing --- make install make test man kpackagetool5; all good Thanks, Harald Sitter ___ Kde

Re: Review Request 121834: rename kpackagetool manpage to kpackagetool5

2015-01-04 Thread Harald Sitter
346982d97340e94846a7c9ddebddb260a694b40a docs/kpackagetool/man-kpackagetool.1.docbook 8f6fe5a198329528692d3edf30ea5d4e36932872 Diff: https://git.reviewboard.kde.org/r/121834/diff/ Testing --- make install make test man kpackagetool5; all good Thanks, Harald Sitter

Re: qca-qt5 package name

2014-12-27 Thread Harald Sitter
On Wed, Dec 24, 2014 at 11:47 AM, David Edmundson da...@davidedmundson.co.uk wrote: On Wed, Dec 17, 2014 at 12:47 PM, Harald Sitter sit...@kde.org wrote: alohas. recently the QCA maintainer and I got into a discussion [1] whether a qca-qt5 library should be a different config inside

Re: qca-qt5 package name

2014-12-27 Thread Harald Sitter
On Sat, Dec 27, 2014 at 1:47 PM, Alex Merry alex.me...@kde.org wrote: On Saturday 27 December 2014 12:24:25 Harald Sitter wrote: I think(tm) the way to fix this properly (which I have not ever seen done by us :P) is fiddling with the find_package related variables (supposedly

Re: Review Request 121266: fix build/test by making translation properties testable

2014-12-18 Thread Harald Sitter
that an observent developer adding a new entry also needs to add it in the fromName function. Diffs (updated) - src/propertyinfo.cpp 751f969eb9b71885323d5456ec7135874657db78 Diff: https://git.reviewboard.kde.org/r/121266/diff/ Testing --- make test Thanks, Harald Sitter Visit

Re: Review Request 121266: fix build/test by making translation properties testable

2014-12-18 Thread Harald Sitter
pointing out that an observent developer adding a new entry also needs to add it in the fromName function. Diffs - src/propertyinfo.cpp 751f969eb9b71885323d5456ec7135874657db78 Diff: https://git.reviewboard.kde.org/r/121266/diff/ Testing --- make test Thanks, Harald Sitter

qca-qt5 package name

2014-12-17 Thread Harald Sitter
alohas. recently the QCA maintainer and I got into a discussion [1] whether a qca-qt5 library should be a different config inside the same cmake package or an independent one (detailed discussion in the longest comment thread of the review). find_package(Qca NAMES Qca-qt5 Qca-QT5 Qca-5 Qca

Re: Re: pkexec vs kdesu

2014-12-11 Thread Harald Sitter
On Mon, Nov 24, 2014 at 10:31 AM, Martin Gräßlin mgraess...@kde.org wrote: On Sunday 23 November 2014 17:14:02 Harald Sitter wrote: On Sun, Nov 23, 2014 at 4:50 PM, David Edmundson da...@davidedmundson.co.uk wrote: You will probably get massively different behaviour regarding your env

Re: pkexec vs kdesu

2014-12-11 Thread Harald Sitter
On Sun, Nov 23, 2014 at 4:50 PM, David Edmundson da...@davidedmundson.co.uk wrote: That said, polkit is totally the way forward and anything using kdesu should be ported. I think the biggest concern is our custom desktop entry allowing *any* third party developer to leverage the power of kdesu

Re: Re: Re: pkexec vs kdesu

2014-12-11 Thread Harald Sitter
On Thu, Dec 11, 2014 at 2:29 PM, Martin Gräßlin mgraess...@kde.org wrote: On Thursday 11 December 2014 14:06:59 Harald Sitter wrote: On Mon, Nov 24, 2014 at 10:31 AM, Martin Gräßlin mgraess...@kde.org wrote: On Sunday 23 November 2014 17:14:02 Harald Sitter wrote: On Sun, Nov 23, 2014 at 4

FYI: watch out for Q_GADGET with cmake2.8

2014-12-04 Thread Harald Sitter
alohas Qt has a magic macro Q_GADGET which according to a websearch falls slightly short of magic. It apparently allows non-QObject classes to grow a metaobject such that one can use properties/enums/invokables. Now the problem with that is that Q_GADGET is not supported by the cmake2.8 automoc

Re: Review Request 121266: fix build/test by making translation properties testable

2014-12-02 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121266/#review71007 --- On Nov. 27, 2014, 9:27 a.m., Harald Sitter wrote

Re: Review Request 121262: make kservice_desktop_to_json warning an author_warning

2014-11-27 Thread Harald Sitter
dcb7cce6fc2e57b1b7b863da500c88b61e447ef5 Diff: https://git.reviewboard.kde.org/r/121262/diff/ Testing --- Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: OSX/CI: phonon fails to INSTALL on branch master

2014-11-27 Thread Harald Sitter
On Thu, Nov 27, 2014 at 8:59 AM, Marko Käning mk-li...@email.de wrote: Phonon built fine, but failed to install for some reason, as a file must be missing: I think that needs some more investigation. I can not reproduce this nor can I even think of how that would happen :/ HS

Review Request 121266: fix build/test by making translation properties testable

2014-11-27 Thread Harald Sitter
function. Diffs - src/propertyinfo.cpp 751f969eb9b71885323d5456ec7135874657db78 Diff: https://git.reviewboard.kde.org/r/121266/diff/ Testing --- make test Thanks, Harald Sitter Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe

Review Request 121262: make kservice_desktop_to_json warning an author_warning

2014-11-26 Thread Harald Sitter
--- Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

pkexec vs kdesu

2014-11-23 Thread Harald Sitter
hola! how about we replace all of our kdesu usage with pkexec. pkexec has a lovely nice dialog, is backed by polkit, very secure, very nice, totally cool. also, absolutely sufficient. thoughts? HS ___ Kde-frameworks-devel mailing list

Re: pkexec vs kdesu

2014-11-23 Thread Harald Sitter
On Sun, Nov 23, 2014 at 4:50 PM, David Edmundson da...@davidedmundson.co.uk wrote: You will probably get massively different behaviour regarding your env. pkexec won't copy anything, sudo will. Without $DISPLAY graphical apps are out. Surely not an unsolvable problem. Clearly wayland fixes

Re: Review Request 121083: Replace manual export files with CMake's generate_export_header

2014-11-22 Thread Harald Sitter
On Nov. 22, 2014, 12:18 a.m., Harald Sitter wrote: This breaks the kde4 build as ECM is not being used there and generate_export_header is not available without ECM. Andrius da Costa Ribas wrote: generate_export_header isn't in ECM, but in cmake itself (http://www.cmake.org/cmake

Re: Review Request 121083: Replace manual export files with CMake's generate_export_header

2014-11-22 Thread Harald Sitter
On Nov. 22, 2014, 12:18 a.m., Harald Sitter wrote: This breaks the kde4 build as ECM is not being used there and generate_export_header is not available without ECM. Andrius da Costa Ribas wrote: generate_export_header isn't in ECM, but in cmake itself (http://www.cmake.org/cmake

Re: Review Request 121083: Replace manual export files with CMake's generate_export_header

2014-11-21 Thread Harald Sitter
there and generate_export_header is not available without ECM. - Harald Sitter On Nov. 21, 2014, 10:47 p.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121083

frameworks' cmake configs looking for other things

2014-10-10 Thread Harald Sitter
Alohas as described in [1] I think there is a bit of a problem how we track inter-dependencies in cmake configs right now (that is: the configs frameworks install to be found by 3rd party bits). If I write a 3rd party software that does this: find_package(KF5Runner) it will eventually trigger

Re: SDDM-KCM In Review

2014-10-06 Thread Harald Sitter
On Mon, Oct 6, 2014 at 11:48 PM, Albert Astals Cid aa...@kde.org wrote: There is no COPYING file (not sure if this one is mandatory or not, ask Riddell) Mandatory it is. At least for just about all GNU licenses as they even explicitly mention that a full copy needs to accompany the source. HS

Review Request 120362: align the so versions

2014-09-25 Thread Harald Sitter
.5.0.95 libKF5FileMetaData.so.2 - libKF5FileMetaData.so.5.0.95 Diffs - CMakeLists.txt c52845e86b7c92aa9a8a055c3869020b7e69240c src/CMakeLists.txt 37528388d6e5d6b38388b4070b7e6a99934be9c2 Diff: https://git.reviewboard.kde.org/r/120362/diff/ Testing --- Thanks, Harald Sitter

Re: Review Request 120362: align the so versions

2014-09-25 Thread Harald Sitter
://git.reviewboard.kde.org/r/120362/diff/ Testing --- Thanks, Harald Sitter Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe

Re: Review Request 120040: Install kdesu under bin

2014-09-16 Thread Harald Sitter
On Sept. 2, 2014, 6:54 p.m., Hrvoje Senjan wrote: in kde4 kdesu was installed under bin it was actually also in libexec. just that KStandardDirs::findExe() looked in libexec paths, QStandardPaths doesn't... Marco Martin wrote: right, it seems on both places here, but is

Re: There's no proper replacement for KIcon

2014-09-03 Thread Harald Sitter
On Wed, Sep 3, 2014 at 10:26 PM, Eike Hein h...@kde.org wrote: I think the fd.o spec pro- scribes the hicolor theme then? ^ this In that case it would be up to the distro to make sure this works out. That wouldn't help the original issue that we previously had a hardcoded fallback to

Re: Review Request 120040: Install kdesu under bin

2014-09-02 Thread Harald Sitter
a krunner replacement that doesn't depend/ispartof plasma workspace one would still run into the broken behavior so long as kde-cli-tools are not installed - Harald Sitter On Sept. 2, 2014, 6:27 p.m., Marco Martin wrote

Re: SIC in KIO master

2014-08-31 Thread Harald Sitter
On Fri, Aug 29, 2014 at 8:26 PM, David Faure fa...@kde.org wrote: On Tuesday 26 August 2014 16:29:23 Harald Sitter wrote: alohas, it would appear to me that a recent change in kio [1] was rather, very, entirely source incompatible (one could argue binary but let's not go there). Say I had

Re: SIC in KIO master

2014-08-29 Thread Harald Sitter
On Tue, Aug 26, 2014 at 4:29 PM, Harald Sitter sit...@kde.org wrote: alohas, it would appear to me that a recent change in kio [1] was rather, very, entirely source incompatible (one could argue binary but let's not go there). Say I had the following in my application using kio 5.0/1

Re: Review Request 119977: Mark setProgramIconName() as deprecated, it did not do anything

2014-08-28 Thread Harald Sitter
implementing the qapp property in qt (which would probably be pointless since we get nothing out of setting the data via kaboutdata to begin with) - Harald Sitter On Aug. 28, 2014, 4:39 p.m., Jonathan Riddell wrote

Re: Review Request 119798: Generating PkgConig files from ECM

2014-08-14 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119798/#review64581 --- +1 - Harald Sitter On Aug. 14, 2014, 11:10 p.m., Aleix Pol

Re: Review Request 119540: don't construct bogus KAuthAction objects

2014-08-01 Thread Harald Sitter
- src/kcmodule.cpp 92e5427c121491e4ebf289addda040cc117cdd68 Diff: https://git.reviewboard.kde.org/r/119540/diff/ Testing --- tested with clock kcm, succesfully can talk with the helper app if the bogus actionid wasn't used intermediately Thanks, Harald Sitter

Re: Review Request 119563: Ship plasma_workspace.notifyrc with frameworkintegration

2014-08-01 Thread Harald Sitter
: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119563/ --- (Updated Aug. 1, 2014, 2:29 p.m.) Review request for KDE Frameworks and Harald Sitter. Repository: frameworkintegration

Re: Review Request 119542: create qapplication before using dbus

2014-07-30 Thread Harald Sitter
Diffs - src/kauthhelpersupport.cpp 99868803fdfaf99283d65a8ab61e7a32fb22e708 Diff: https://git.reviewboard.kde.org/r/119542/diff/ Testing --- Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 119540: don't construct bogus KAuthAction objects

2014-07-30 Thread Harald Sitter
://git.reviewboard.kde.org/r/119540/#review63509 --- On Juli 30, 2014, 12:32 vorm., Harald Sitter wrote: --- This is an automatically generated e-mail. To reply, visit: https

Review Request 119542: create qapplication before using dbus

2014-07-29 Thread Harald Sitter
://git.reviewboard.kde.org/r/119542/diff/ Testing --- Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Translations in frameworks released tarballs

2014-07-09 Thread Harald Sitter
On Wed, Jul 9, 2014 at 11:27 AM, Alexander Potashev aspotas...@gmail.com wrote: 2014-07-09 2:38 GMT+04:00 David Faure fa...@kde.org: On Tuesday 08 July 2014 23:24:36 Christoph Feck wrote: Is it possible to strip them before the archives are packed? Or can they even be stripped in the

Re: Translations in frameworks released tarballs

2014-07-09 Thread Harald Sitter
On Wed, Jul 9, 2014 at 8:32 PM, Albert Astals Cid aa...@kde.org wrote: El Dimecres, 9 de juliol de 2014, a les 22:25:29, Albert Astals Cid va escriure: El Dimecres, 9 de juliol de 2014, a les 11:59:01, Harald Sitter va escriure: On Wed, Jul 9, 2014 at 11:27 AM, Alexander Potashev aspotas

Re: KIconLoader problem with KFontInst

2014-06-30 Thread Harald Sitter
On Mon, Jun 30, 2014 at 12:02 PM, Martin Klapetek martin.klape...@gmail.com wrote: ...or have the icons installed properly (hicolor?) and remove the custom addAppDir call altogether? Not that I grasp the issue, but if it is a general problem that could have impact on every application using

Re: KAuth and KF5

2014-06-25 Thread Harald Sitter
On Wed, Jun 25, 2014 at 9:40 AM, Milian Wolff m...@milianw.de wrote: On Tuesday 24 June 2014 23:44:12 Luca Beltrame wrote: Hello, currently, the KF5 version of KAuth is not quite usable as any helper used by KAuth segfaults: the most notable is backlighthelper, which always crashes at login.

Re: Review Request 118846: Turn KLauncher into a QGuiApplication

2014-06-20 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118846/#review60591 --- Ship it! looks good to me - Harald Sitter On June 20

Re: KDE Frameworks Release Cycle

2014-05-05 Thread Harald Sitter
On Mon, May 5, 2014 at 11:11 AM, Martin Klapetek martin.klape...@gmail.com wrote: On Sun, May 4, 2014 at 6:36 PM, David Faure fa...@kde.org wrote: [Cross posting against my will...] On Sunday 04 May 2014 16:27:44 Luigi Toscano wrote: I understand that the big concern was about the testing:

kubuntu 14.04 and 4.13rc/final

2014-04-08 Thread Harald Sitter
salut, Kubuntu 14.04 is due for release on April 17 and since that is very close to 4.13 final tagging/release it is going to be a tight squeeze to get the final on the release ISO. While landing the final is very much the intended course of action there is a chance that we won't be able to make

kubuntu 14.04 and 4.13rc/final

2014-04-08 Thread Harald Sitter
salut, Kubuntu 14.04 is due for release on April 17 and since that is very close to 4.13 final tagging/release it is going to be a tight squeeze to get the final on the release ISO. While landing the final is very much the intended course of action there is a chance that we won't be able to make

Q: kconfig without kaboutdata behavior

2014-04-03 Thread Harald Sitter
ahoy, I just wanted to ask whether it is still mandatory to have a KAboutData instance set to have classes such as KConfigShared work in a convenient fashion (e.g. KConfigShared::openConfig() will open the applications config as long as qapp::applicationName is set). In my particular case the

Re: Q: kconfig without kaboutdata behavior

2014-04-03 Thread Harald Sitter
On Thu, Apr 3, 2014 at 12:30 PM, Alex Merry alex.me...@kde.org wrote: On 03/04/14 09:34, Harald Sitter wrote: ahoy, I just wanted to ask whether it is still mandatory to have a KAboutData instance set to have classes such as KConfigShared work in a convenient fashion (e.g. KConfigShared

Re: Plasma Next - Translations KCM - What Languages?

2014-03-17 Thread Harald Sitter
On Fri, Mar 14, 2014 at 2:31 PM, John Layt jl...@kde.org wrote: Hi, I'm doing some more work on the new KCM for Translations, i.e. the KCM in Plasma Next to configure the LANGUAGE env var that startkde will export for all apps running under Plasma Next to use, including Gtk as well as Qt

Re: Plasma Next - Translations KCM - What Languages?

2014-03-17 Thread Harald Sitter
On Mon, Mar 17, 2014 at 1:03 PM, Chusslove Illich caslav.i...@gmx.net wrote: [: Harald Sitter :] What we need is some plugin awesomeness (or equally fancy mechanism) to allow the distribution to put everything into context. The KCM wants to know what translations are available - try asking

ECM uninstall target

2014-03-13 Thread Harald Sitter
alohas, I just ported phonon/five to ECM and noticed that apparently ECM does not have an include or something to introduce an uninstall target. Are there plans to introduce such a thing or am I simply blind and not seeing the already existing include? HS

Re: KDM + ConsoleKit + Logind

2014-02-18 Thread Harald Sitter
On Tue, Feb 18, 2014 at 2:30 AM, Rex Dieter rdie...@math.unl.edu wrote: Harald Sitter wrote: Right, but short of patching KDM to gain proper logind support, should one build with or without CK, build without it. i.e. does CK add anything useful if the rest of the system is not using

KDM + ConsoleKit + Logind

2014-02-17 Thread Harald Sitter
Ahoys I was looking for some input on KDM+CK in a Logind world. When a system is using Logind I guess KDM+CK doesn't do much useful, so the question arose whether distributions with such a lineup should build without CK support. In short: If the rest of the system uses Logind, should KDM be

Re: KDM + ConsoleKit + Logind

2014-02-17 Thread Harald Sitter
On Mon, Feb 17, 2014 at 2:09 PM, Matthias Klumpp matth...@tenstral.net wrote: 2014-02-17 13:55 GMT+01:00 Lukáš Tinkl lti...@redhat.com: Dne 17.2.2014 11:51, Harald Sitter napsal(a): Ahoys I was looking for some input on KDM+CK in a Logind world. When a system is using Logind I guess KDM+CK

Re: frameworks build instructions wrong / won't work with kubuntu 14.04

2013-12-20 Thread Harald Sitter
On Thu, Dec 19, 2013 at 7:45 PM, Dimitri John Ledkov dimitri.led...@surgut.co.uk wrote: So I was very clueless why Harald brought up that failing to build from source in his PPA build to a such a wide audience, when it was entirely unwarranted. And also in such a hasty manner, minutes after

<    7   8   9   10   11   12   13   >