D28463: do not install testengine

sitter created this revision. sitter added a reviewer: mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY by default users have to opt out of BUILD_TESTING meaning everyone would by default

D28129: Read the new message string after rather than before

sitter accepted this revision. sitter added a comment. Mind the comment about the +2 please. Other than that looks reasonable. INLINE COMMENTS > backtraceparsergdb.cpp:215 > +case BacktraceLine::Info: > +d->m_infoLines << line.toString().mid(KCRASH_INFO_MESSAGE.size() + >

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

sitter added a comment. In D28161#634951 , @ahmadsamir wrote: > > Please don't touch kdsoap-ws-discovery-client though. It's not maintained here -> https://gitlab.com/caspermeijn/kdsoap-ws-discovery-client > > That's confusing; but OK, I'll

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

sitter added a comment. Looks good to me, not that this means much with regular expressions. The lack of tests on this stuff makes me sad :(( Please don't touch kdsoap-ws-discovery-client though. It's not maintained here -> https://gitlab.com/caspermeijn/kdsoap-ws-discovery-client

D27902: smb: figure out the best host to use for the UDS_URL

sitter added a comment. I've actually had a better idea! Well kinda and it may be trickier to do. We could move the resolution dance to actual resolution time so it stops having impact on discovery. i.e. we just always use `"smb://" + m_prettyName + ".local"` as UDS_URL for discovery.

D27873: sftp: do not show creation time when we do not know it

This revision was automatically updated to reflect the committed changes. Closed by commit R320:b13449a13b00: sftp: do not show creation time when we do not know it (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27873?vs=78352=78444

D27872: sftp: fix partial transfer resuming when copying to local

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R320:8a04e1009130: sftp: fix partial transfer resuming when copying to local (authored by sitter). CHANGED PRIOR TO

D27873: sftp: do not show creation time when we do not know it

sitter updated this revision to Diff 78352. sitter added a comment. . REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27873?vs=77080=78352 BRANCH sftp-ctime REVISION DETAIL https://phabricator.kde.org/D27873 AFFECTED FILES sftp/kio_sftp.cpp To:

D27504: smb faster copy to local

sitter added a comment. Any opinions on landing this for 20.04 still? It is technically a bugfix. It is also practically a whole lot of risky code, making me rather uneasy about putting it in past beta. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27504 To:

D28129: Read the new message string after rather than before

sitter added a comment. Mh. Not quite what I had in mind but I suppose it makes sense this way. I think we need a test case for the highlighter though :| It totally blows up in my face when I trace a running dolphin because toskip isn't quite right. INLINE COMMENTS >

D28188: breeze-icons autotests: skip symlinks in the builddir

sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D28188 To: dfaure, sitter, bshah, lbeltrame Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27927: Use more flexible shebang

This revision was automatically updated to reflect the committed changes. Closed by commit R266:485e7be3b7ef: Use more flexible shebang (authored by tcberner, committed by sitter). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27927?vs=77198=78011

D28129: Read the new message string after rather than before

sitter added a comment. Quick recap from what we talked about on telegram: putting the print after the bt is most definitely going to throw off the backtrace parsing logic, so doing it this way would require extensive changes there, which is a dangerous place to make extensive changes. Or

D18878: Force NT1 protocol when listing smb:// network [work in progress]

sitter removed a reviewer: sitter. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18878 To: mikhailnov, #dolphin, #frameworks, broulik Cc: sitter, ngraham, acrouthamel, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas,

D25984: Load translations

sitter removed a reviewer: sitter. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami, #frameworks, kossebau, aacid Cc: mart, davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra

D27871: sftp: fix seekPos + file resuming when part file is of size 11

This revision was automatically updated to reflect the committed changes. Closed by commit R320:d8cf85ec2f0f: sftp: fix seekPos + file resuming when part file is of size 11 (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D28078: guard against duplicated service discoveries

This revision was automatically updated to reflect the committed changes. Closed by commit R320:ba96d3b93a96: smb: guard against duplicated service discoveries (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28078?vs=77737=77990

D28123: move setErrorMessage definition out of the linux ifdef

This revision was automatically updated to reflect the committed changes. Closed by commit R285:91129f291efd: move setErrorMessage definition out of the linux ifdef (authored by sitter). REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28123?vs=77910=77913

D28123: move setErrorMessage definition out of the linux ifdef

sitter created this revision. sitter added a reviewer: apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY rather obvious in retrospect. the definition is OS-independent, the declaration

D28121: Use libcanberra as primary means of previewing the sound

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Your `if(` style is now inconsistent with the `endif(`. Code LGTM REPOSITORY R305 KNotifyConfig REVISION DETAIL https://phabricator.kde.org/D28121 To: broulik, #frameworks, sitter

D28095: Bump required version of KF5 to 5.69.0

sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R871 DrKonqi BRANCH l-kcrash (branched from master) REVISION DETAIL https://phabricator.kde.org/D28095 To: ahmadsamir, #frameworks, dfaure, apol, sitter Cc: kde-frameworks-devel, plasma-devel,

D28078: guard against duplicated service discoveries

sitter added a comment. FTR: this could technically still dupe with smbc native NT1 listing, except smbc would list workgroups while we list services, so this should generally not be duplicative information. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28078

D28078: guard against duplicated service discoveries

sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY if both dnssd and wsdiscovery have the same server on offer we'd

D27804: smb: add hack to support spaces in workgroup names

sitter added a comment. Yep. I'm 100% certain of this. The library in fact has no API that returns a complete URL or anything near a complete URL. It's using dirent-inspired API to let us iterate/stat paths and only ever returns paths relative to whatever input it got, from those paths we

D27520: add readdirplus2 support for samba>=4.12

This revision was automatically updated to reflect the committed changes. Closed by commit R320:ec40cd6ef3f4: add readdirplus2 support for samba=4.12 (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27520?vs=76048=77717#toc REPOSITORY R320 KIO Extras CHANGES SINCE

D27872: sftp: fix partial transfer resuming when copying to local

sitter added a comment. ping REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27872 To: sitter, ngraham, feverfew, bruns Cc: bruns, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela,

D27873: sftp: do not show creation time when we do not know it

sitter added a comment. ping REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27873 To: sitter, ngraham, bruns Cc: bruns, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew,

D27902: smb: figure out the best host to use for the UDS_URL

sitter added a comment. ping REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27902 To: sitter, ngraham, dfaure Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven,

D27804: smb: add hack to support spaces in workgroup names

sitter added a comment. In D27804#621988 , @sitter wrote: > In D27804#621970 , @thiago wrote: > > > Still want to see that round-trip. > > > But why? Converting an smbcUrl to a QUrl would

D28014: smb: do not double finish

This revision was automatically updated to reflect the committed changes. Closed by commit R320:8252861157a2: smb: do not double finish (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28014?vs=77502=77714 REVISION DETAIL

D28061: Reduce unneeded dependencies

sitter accepted this revision. REPOSITORY R871 DrKonqi BRANCH master REVISION DETAIL https://phabricator.kde.org/D28061 To: apol, #frameworks, davidedmundson, sitter Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

D21466: Recommend rebooting after installing Samba

sitter edited the summary of this revision. REPOSITORY R432 File Sharing (Samba) integration BRANCH recommend-rebooting (branched from master) REVISION DETAIL https://phabricator.kde.org/D21466 To: ngraham, #vdg, #frameworks, #dolphin, apol, sitter Cc: anthonyfieroni, sitter, bruns

D27986: Allow providing an error message from the application

sitter added a comment. Looks alright to me now.  REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D27986 To: apol, #frameworks, sitter, dfaure Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27986: Allow providing an error message from the application

sitter added inline comments. INLINE COMMENTS > kcrash.cpp:107 > + > +static char *s_kcrashErrorMessage; > Q_GLOBAL_STATIC(KCrash::CoreConfig, s_coreConfig) Still needs to be set to nullptr. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D27986 To: apol, #frameworks,

D27986: Allow providing an error message from the application

sitter added inline comments. INLINE COMMENTS > kcrash.cpp:107 > + > +static char* s_kcrashErrorMessage; > Q_GLOBAL_STATIC(KCrash::CoreConfig, s_coreConfig) - on wrong side of space needs defining to nullptr > kcrash.cpp:994 > +{ > +s_kcrashErrorMessage =

D28014: smb: do not double finish

sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY finish() must not be called twice yet previously the case branches

D21466: Recommend rebooting after installing Samba

sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R432 File Sharing (Samba) integration BRANCH recommend-rebooting (branched from master) REVISION DETAIL https://phabricator.kde.org/D21466 To: ngraham, #vdg, #frameworks, #dolphin, apol, sitter Cc:

D27985: Include s_kcrashErrorMessage in our traces

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. LGTM for when the kcrash diff is ready. REPOSITORY R871 DrKonqi BRANCH master REVISION DETAIL https://phabricator.kde.org/D27985 To: apol, #frameworks, sitter Cc: plasma-devel,

D27986: Allow providing an error message from the application

sitter added a reviewer: dfaure. sitter added a subscriber: dfaure. sitter added a comment. Paging @dfaure for expert input. Is that global static qbytearray safe? Should we make it a q_global_static to comply with our library policy? Any objections to the diff? REPOSITORY R285 KCrash

D21466: Recommend rebooting after installing Samba

sitter added a comment. In D21466#625834 , @apol wrote: > So yes, Discover will notify about updates. That doesn't mean it should be shown here too. To clarify: are you -1 this diff? > If anything, we should be pushing for such

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

sitter added a subscriber: feverfew. sitter added a comment. Tested fuse and it works as expected. Code looks reasonable, but I have little expertise with this class. @feverfew probably ought to comment as well since he introduced the fuse code. REPOSITORY R241 KIO REVISION DETAIL

D27986: Allow providing an error message from the application

sitter added a comment. Unit test? (: I also wonder if maybe this should be lazy allocated. The vast majority of applications probably will never set it, so allocating the memory on first use should be better for the great majority of applications while making no difference for the gdb

D27985: Include s_kcrashErrorMessage in our traces

sitter added a comment. Probably should also get added to one of the parser tests to make sure it doesn't fall on the face. Talking about parser, I feel like this might benefit from highlighting somehow, currently it's very squished in with the random stuff in the header. That'll make

D26841: hardware tool: define syntax via syntax arg

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R245:8dfb727dd105: hardware tool: define syntax via syntax arg (authored by sitter). REPOSITORY R245 Solid CHANGES

D27871: sftp: fix seekPos + file resuming when part file is of size 11

sitter added inline comments. INLINE COMMENTS > bruns wrote in kio_sftp.cpp:1687 > Essentially, apply the change from the man page example to the code here: > > if (pos != sbPart->size) { > int errsv = errno; > qCDebug(KIO_SFTP_LOG) << "Failed to seek to" << sbPart->size << "bytes

D26969: fix type namespace requirement

This revision was automatically updated to reflect the committed changes. Closed by commit R283:e6877dfa4fe6: fix type namespace requirement (authored by sitter). REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26969?vs=77262=77344 REVISION DETAIL

D27504: smb faster copy to local

sitter edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27504 To: sitter, ngraham, cfeck Cc: hallas, anthonyfieroni, asturmlechner, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe,

D27504: smb faster copy to local

sitter retitled this revision from "WIP: RFC: smb faster copy to local" to "smb faster copy to local". REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27504 To: sitter, ngraham, cfeck Cc: hallas, anthonyfieroni, asturmlechner, kde-frameworks-devel, kfm-devel,

D27504: WIP: RFC: smb faster copy to local

sitter updated this revision to Diff 77343. sitter added a comment. - rebase - move transfer impls to cpp - new unpop function to make the ring usage more consistent and make sure neither thread can overtake the other - new test for transfer tech. notably simulating imbalance in

D27871: sftp: fix seekPos + file resuming when part file is of size 11

sitter added inline comments. INLINE COMMENTS > bruns wrote in kio_sftp.cpp:1687 > Which part of > > > A common mistake is to do > > did you miss? Oh, I'm sorry. My reading comprehension isn't so good. I am not sure what you are asking of me though. errno access in qdebug streaming is used

D26969: fix type namespace requirement

sitter updated this revision to Diff 77262. sitter added a comment. switch to indexOfMethod, also construct a signature from the slotname. indexOf requires a normalized signature (e.g. `save(QVariantMap)`) REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE

D27871: sftp: fix seekPos + file resuming when part file is of size 11

sitter added a comment. In D27871#623593 , @bruns wrote: > In D27871#623542 , @sitter wrote: > > > In D27871#622933 , @bruns wrote: > > > > > Can you

D27873: sftp: do not show creation time when we do not know it

sitter added a comment. In D27873#623582 , @bruns wrote: > Please correct the comment in the code - it depends on the server SFTP implementation. Birth time does not depend on the file system? REPOSITORY R320 KIO Extras REVISION

D27872: sftp: fix partial transfer resuming when copying to local

sitter added inline comments. INLINE COMMENTS > bruns wrote in kio_sftp.cpp:1935 > Dependent on the file system, this will no longer catch `partFile.isDir()`. > stat.st_size is only defined for regular files and symlinks, for all other > types it is implementation defined. E.g. XFS and Btrfs

D27927: Use more flexible shebang

sitter accepted this revision. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27927 To: tcberner, #freebsd, sitter, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27871: sftp: fix seekPos + file resuming when part file is of size 11

sitter added inline comments. INLINE COMMENTS > bruns wrote in kio_sftp.cpp:1687 > You should save errno immediately after QT_LSEEK, otherwise any function may > overwrite it. See `man 3 errno`: > > > A common mistake is to do > > > > if (somecall() == -1) { > > printf("somecall()

D27871: sftp: fix seekPos + file resuming when part file is of size 11

sitter added a comment. In D27871#622933 , @bruns wrote: > Can you also mention why errno == EGAIN does not have to be handled ("EAGAIN could only happen iff the file where opened with O_NONBLOCK. All other seek errors are fatal."). I

D27901: smb: do not leak pbsd resolvers

This revision was automatically updated to reflect the committed changes. Closed by commit R320:1eacae5267e3: smb: do not leak pbsd resolvers (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27901?vs=77113=77126 REVISION DETAIL

D27900: smb: fix wsdiscovery unknown device fallback string

This revision was automatically updated to reflect the committed changes. Closed by commit R320:6557c6b4793d: smb: fix wsdiscovery unknown device fallback string (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27900?vs=77112=77127

D27801: smb: add a unit test for smburl

This revision was automatically updated to reflect the committed changes. Closed by commit R320:d8d92670372a: smb: add a unit test for smburl (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27801?vs=76935=77119 REVISION DETAIL

D27802: smb: fix ipv6 support

This revision was automatically updated to reflect the committed changes. Closed by commit R320:bb83a071e0da: smb: fix ipv6 support (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27802?vs=76915=77120 REVISION DETAIL

D27835: sftp: fix free space query for urls with empty path

This revision was automatically updated to reflect the committed changes. Closed by commit R320:5cfd852a975e: sftp: fix free space query for urls with empty path (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27835?vs=76940=77117#toc REPOSITORY R320 KIO Extras

D27800: smb: split module into two targets of which one is a static lib

This revision was automatically updated to reflect the committed changes. Closed by commit R320:d101d916e324: smb: split module into two targets of which one is a static lib (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D27902: smb: figure out the best host to use for the UDS_URL

sitter created this revision. sitter added reviewers: ngraham, dfaure. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY previously we simply used the ip address. this is fairly

D27901: smb: do not leak pbsd resolvers

sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY parent them to the discoverer. discoverer lives on the stack and is

D27900: smb: fix wsdiscovery unknown device fallback string

sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY wasn't using xi18n so wasn't parsed as markup but rather used

D27873: sftp: do not show creation time when we do not know it

sitter updated this revision to Diff 77080. sitter added a comment. use flaggy REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27873?vs=77039=77080 BRANCH sftp-ctime REVISION DETAIL https://phabricator.kde.org/D27873 AFFECTED FILES

D27872: sftp: fix partial transfer resuming when copying to local

sitter updated this revision to Diff 77076. sitter added a comment. . REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27872?vs=77037=77076 BRANCH sftp-resume-to-local REVISION DETAIL https://phabricator.kde.org/D27872 AFFECTED FILES

D27557: Auto-generate 24px monochrome icons

sitter added a comment. It's doable in cmake but it'd be awkward and needlessly complex I think, you are much better served putting the actual processing into a script. ki18n's cmake/ macros have function with very similar tech. In fact, KI18N_INSTALL probably is super close in the

D27802: smb: fix ipv6 support

sitter added a comment. Ah sorry for the unnecessary wait. I wasn't planning on 19.12. Thanks for asking though :) REPOSITORY R320 KIO Extras BRANCH smb-smburl-static-autotest-ipv6 REVISION DETAIL https://phabricator.kde.org/D27802 To: sitter, ngraham Cc: cfeck, thiago,

D27873: sftp: do not show creation time when we do not know it

sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY creation time (aka birth time) is file system dependent, if the fs

D27872: sftp: fix partial transfer resuming when copying to local

sitter created this revision. sitter added reviewers: ngraham, feverfew. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY the previous condition checked if the final target path size

D27871: sftp: fix seekPos + file resuming when part file is of size 11

sitter created this revision. sitter added reviewers: ngraham, feverfew. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY previously seekPos would loop over offset==EAGAIN. the

D27804: smb: add hack to support spaces in workgroup names

sitter added a comment. In D27804#621970 , @thiago wrote: > Still want to see that round-trip. But why? Converting an smbcUrl to a QUrl would literally be useless code. REPOSITORY R320 KIO Extras REVISION DETAIL

D27835: sftp: fix free space query for urls with empty path

sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY e.g. `sftp://localhost` has an empty path fall back to assume it

D27801: smb: add a unit test for smburl

sitter updated this revision to Diff 76935. sitter added a comment. make cdup void REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27801?vs=76861=76935 BRANCH smb-smburl-static-autotest REVISION DETAIL https://phabricator.kde.org/D27801 AFFECTED

D27804: smb: add hack to support spaces in workgroup names

sitter updated this revision to Diff 76934. sitter added a comment. extend test coverage to % character in wg and umlaut in wg. I've also changed the construction in browse.cpp to use QUrlQuery so it does not trip over potential hash or question marks in the workgroup libsmbc is

D27802: smb: fix ipv6 support

sitter updated this revision to Diff 76915. sitter added a comment. guard against ending in dash also move to front() and back() for ease of reading REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27802?vs=76838=76915 BRANCH

D27810: Correctly disable UDS_ACCESS being set

sitter added a comment. Yeah, can't find anything either, I may be thinking of the numberValue query in CopyJob, so entirely unrelated. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27810 To: davidedmundson, sitter, feverfew Cc: kde-frameworks-devel,

D27810: Correctly disable UDS_ACCESS being set

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. I am pretty sure I picked that up somewhere, might be worth asking lxr for possible other places we set ACCESS to -1 REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL

D27504: WIP: RFC: smb faster copy to local

sitter updated this revision to Diff 76865. sitter added a comment. - refine code a bit - extend to ::get works same as smbCopyGet. in fact I feel like the two functions should be merged. at their hearts they both could read into QIODevices (QFile/QBuffer(QBA)) - use segment class for

D27801: smb: add a unit test for smburl

sitter updated this revision to Diff 76861. sitter added a comment. follow Aleix' suggestion and change cd() to cdUp() seeing as it now only cds up REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27801?vs=76832=76861 BRANCH smb-smburl-static-autotest

D27800: smb: split module into two targets of which one is a static lib

sitter added a comment. used in D27801 REPOSITORY R320 KIO Extras BRANCH smb-smburl-static REVISION DETAIL https://phabricator.kde.org/D27800 To: sitter, ngraham, apol Cc: apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice,

D27804: smb: add hack to support spaces in workgroup names

sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY workgroup names are as best I can tell always still netbios names

D27802: smb: fix ipv6 support

sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY libsmbc doesn't presently support smb://[ABCD::DCBA]/ uris because it

D27801: smb: add a unit test for smburl

sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY only tests some of the obvious scenarios I can see right now.

D27800: smb: split module into two targets of which one is a static lib

sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY this allows us to use the intermediate static target for unit testing

D27676: smb: ecm clang-format the entire code base

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R320:a1775f44b8fb: smb: ecm clang-format the entire code base (authored by sitter). REPOSITORY R320 KIO Extras CHANGES

D21795: [KAuth] Add support for action details in Polkit1 backend.

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Much better. Since nobody has input on the deprecations I guess they must be alright. Do have a look into using QDBusError::InvalidArgs before landing though. INLINE COMMENTS >

D27676: smb: ecm clang-format the entire code base

sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY over the past 20 years smb has gathered a whole bunch of different

D27647: throw out the windows variant of the smb slave

This revision was automatically updated to reflect the committed changes. Closed by commit R320:60c9ac5a089a: smb: throw out the windows variant of the slave (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27647?vs=76357=76450

D27153: port sftp to Result system to force serialization of error/finish condition

This revision was automatically updated to reflect the committed changes. Closed by commit R320:74850eb21654: sftp: port to Result system to force serialization of error/finish condition (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D27644: do not hide enum warnings via switch default label

This revision was automatically updated to reflect the committed changes. Closed by commit R320:d0e16b8326d4: smb: do not hide enum warnings via switch default label (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27644?vs=76352=76449

D27646: smb: apply a whole bunch of static analyzer improvements

This revision was automatically updated to reflect the committed changes. Closed by commit R320:70f2dc8521ff: smb: apply a whole bunch of static analyzer improvements (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27646?vs=76354=76451

D17205: Build kio_nfs against standalone libtirpc

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Fine by me to land as-is, it can't be worse than what the current state of afairs in master is... which is to say in master nothing is working for me :'< REPOSITORY R320 KIO Extras

D21795: [KAuth] Add support for action details in Polkit1 backend.

sitter requested changes to this revision. sitter added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > Polkit1Backend.cpp:4 > * Copyright (C) 2009 Radek Novacek > * Copyright (C) 2009-2010 Dario Freddi > * According to the diff of the diff you seem to

D27647: throw out the windows variant of the smb slave

sitter added a reviewer: Windows. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27647 To: sitter, ngraham, #windows Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven,

D27647: throw out the windows variant of the smb slave

sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY it hasn't been built in ages because the top level cmakelists

D27646: smb: apply a whole bunch of static analyzer improvements

sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY among other things: - {} initialize the posix structs -

D27644: do not hide enum warnings via switch default label

sitter added a reviewer: ngraham. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27644 To: sitter, ngraham Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh,

<    1   2   3   4   5   6   7   8   9   10   >