D5352: Add a test for _repository_name() a function added for fetch-translations

sitter added inline comments. INLINE COMMENTS > CMakeLists.txt:25 > + > +if(NOT TARGET fetch-translations AND NOT EXISTS > "${CMAKE_CURRENT_SOURCE_DIR}/../../po") > +message(FATAL_ERROR "should have a fetch-translations target") `AND NOT EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/../../po"` is

D5352: Add a test for _repository_name() a function added for fetch-translations

sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D5352 To: apol, sitter, aacid Cc: #frameworks, #build_system

D5167: Move .po and .ts files look-up to build-time

sitter added a comment. The code currently isn't working for po/ in source dir and you are losing a public function. See inline comments. (Why there are no autotests for a complicated, involved, and important function like ki18n_install is entirely beyond my appreciation. How in the

D5143: Introduce fetch-translations build command

sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D5143 To: apol, #frameworks, #build_system, kfunk, ltoscano, aacid, ilic, sitter Cc: sitter

D5143: Introduce fetch-translations build command

sitter added a comment. needs a version bump in the docs now  beyond that LGTM INLINE COMMENTS > KDECMakeSettings.cmake:86 > +# > +# Since 5.33.0 > 5.34 now > KDECMakeSettings.cmake:323 > +COMMAND ruby "${CMAKE_BINARY_DIR}/releaseme/fetchpo.rb" --origin >

kioslave nogui

Hola, I am tyring to run filelight on windows and encountered a really strange behavior in KIO. I am building KIO with KIO_FORK_SLAVES=ON as that seems to make the most sense on Windows. That will fork the kioslave helper binary to run the slaves rather than going through kdeinit. The problem is

D5218: explicitly set NO_CMAKE_FIND_ROOT_PATH

This revision was automatically updated to reflect the committed changes. Closed by commit R237:4468076a41f9: explicitly set NO_CMAKE_FIND_ROOT_PATH (authored by sitter). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5218?vs=12914=12976 REVISION DETAIL

D5217: explicitly set NO_CMAKE_FIND_ROOT_PATH

This revision was automatically updated to reflect the committed changes. Closed by commit R244:3e9993625cf3: explicitly set NO_CMAKE_FIND_ROOT_PATH (authored by sitter). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5217?vs=12913=12915 REVISION DETAIL

D5218: explicitly set NO_CMAKE_FIND_ROOT_PATH

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY When using a toolchain file one often would want to set a CMAKE_FIND_ROOT_PATH to "re-root" lookups into a staging area to prevent native

D5217: explicitly set NO_CMAKE_FIND_ROOT_PATH

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY When using a toolchain file one often would want to set a CMAKE_FIND_ROOT_PATH to "re-root" lookups into a staging area to prevent native

D5212: support building against a qt without a11y enabled

This revision was automatically updated to reflect the committed changes. Closed by commit R236:9dac68ab5b64: support building against a qt without a11y enabled (authored by sitter). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5212?vs=12902=12906

D5212: support building against a qt without a11y enabled

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D5212 AFFECTED FILES src/kcollapsiblegroupbox.cpp To:

D5143: Introduce fetch-translations build command

sitter added a comment. Oh! OTOH, given fetch-translations pulls it into bin_dir while normally we'd have it in src_dir this may well be awkward in implementation. e.g. https://phabricator.kde.org/D5197 effectively ought to be ki18n_install("${CMAKE_SOURCE_DIR}/po")

D5143: Introduce fetch-translations build command

sitter added a comment. In https://phabricator.kde.org/D5143#97985, @apol wrote: > In https://phabricator.kde.org/D5143#97847, @aacid wrote: > > > That creates a dependency for ki18n for frameworks that only use .ts files, no? > > > One thing we can do is remove the

D5195: don't add the autotests dir when test building is disabled

This revision was automatically updated to reflect the committed changes. Closed by commit R249:16750048daf7: don't add the autotests dir when test building is disabled (authored by sitter). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5195?vs=12859=12894

D5143: Introduce fetch-translations build command

sitter added a comment. The way I understand it the use case here is during development, so I am not sure the ki18n circular dep is particularly concerning. Avoiding it seems fairly difficult as find_package needs to happen at configure-time, fetch-translations at build-time, and so we only

D5195: don't add the autotests dir when test building is disabled

sitter added a reviewer: ilic. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D5195 To: sitter, ilic Cc: #frameworks

D5195: don't add the autotests dir when test building is disabled

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY autotests need qt5qml which is other than that not needed for ki18n REPOSITORY R249 KI18n BRANCH master REVISION DETAIL

D5143: Introduce fetch-translations build command

sitter added a comment. A couple of things I am not sure about - defaults to stable translations, I'd say it should default to trunk. e.g. playground and kdereview don't even have stable - considering one has to enable this feature in the cmakecache I think it should be made a

D5143: Introduce fetch-translations build command

sitter added inline comments. INLINE COMMENTS > KDECMakeSettings.cmake:74 > # - ``APPLE_SUPPRESS_X11_WARNING`` option since 5.14.0 > > > #= Needs documentation for the l10n awesomeness. >

D5133: Introduce fetchpo.rb

sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R572 releaseme BRANCH master REVISION DETAIL https://phabricator.kde.org/D5133 To: apol, #frameworks, sitter

D5133: Introduce fetchpo.rb

sitter requested changes to this revision. sitter added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > l10n.rb:217 > > -def get(srcdir) > - # FIXME: this is later used as destination for the weirdest of > reasons... > - target = "#{srcdir}/po/"

D5133: Introduce fetchpo.rb

sitter requested changes to this revision. sitter added a comment. This revision now requires changes to proceed. I really think this should have a simple test case. In particular, the allow_edit behavior should be asserted somewhere. Also some style nitpicks. INLINE COMMENTS >

D5079: debug when disabling kcrash due to env vars

This revision was automatically updated to reflect the committed changes. Closed by commit R285:c916d7b8f3a2: debug when disabling kcrash due to env vars (authored by sitter). REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5079?vs=12553=12631 REVISION DETAIL

D5079: debug when disabling kcrash due to env vars

sitter added a reviewer: dfaure. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D5079 To: sitter, dfaure Cc: #frameworks

D5079: debug when disabling kcrash due to env vars

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY otherwise it's fairly inobvious why drkonqi doesn't kick in REPOSITORY R285 KCrash BRANCH master REVISION DETAIL

Re: Automatic Tests and Continuous Integration

you need to drill down into the 'default' configuration http://i.imgur.com/D4Asuaa.png On Wed, Mar 15, 2017 at 10:10 AM, Matthieu Gallien wrote: > Hello, > > I am a bit lost when looking at both KFileMetaData projects under > build.kde.org. I am not able to get any

D5032: drop examples dir

sitter added a comment. Not interesting enough to me. If someone finds it interesting, sure. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D5032 To: sitter, broulik Cc: ltoscano, #frameworks

D5032: drop examples dir

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY - it does not build on its own (doesn't find_package anything) - it is not wired into the overall build (so you can't build it as part of

Re: We need to enable auto close in github pull requests

http://nopullrequests.com/ On Mon, Mar 13, 2017 at 12:31 AM, Albert Astals Cid wrote: > Looking at https://github.com/pulls?q=is%3Apr+org%3Akde+is%3Aopen makes me > very sad seeing how there's people that want to contribute but will never get > an answer. > > Even if you click to

Re: Can anyone that cares about appdata please fix all these files?

FWIW, that's not true I fear. When there is no summary *and* the desktop file has no Comment (which ours usually do not do) then appstream-generator (the distro-level aggregation tool for appstream data) will reject the data with the error that there is no summary. In appstream-generator there's

D4925: actually delete old theme caches

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. lgtm REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D4925 REVISION DETAIL https://phabricator.kde.org/D4925 To: mart, #plasma, sitter Cc: sitter, apol, plasma-devel,

[Differential] [Accepted] D4448: Don't use tier3 frameworks in unit tests

sitter accepted this revision. sitter added a comment. Ah! I hadn't even thought of QSettings. Love the change. FWIW if you fancy more work: seeing as the test now has its own enums you could align the Context enum values' names with their string representation allowing `parseContext`

Re: Phabricator: All repositories registered - upcoming workflow changes

On Thu, Feb 2, 2017 at 6:17 PM, Ben Cooksley <bcooks...@kde.org> wrote: > On Thu, Feb 2, 2017 at 11:51 PM, Harald Sitter <sit...@kde.org> wrote: >> On Thu, Feb 2, 2017 at 10:31 AM, Ben Cooksley <bcooks...@kde.org> wrote: >>> On Thu, Feb 2, 2017 at 10:23 PM, Lui

Re: breeze-icons and the symlink business

On Thu, Feb 2, 2017 at 12:24 PM, Jaroslaw Staniek <stan...@kde.org> wrote: > > > On 2 February 2017 at 00:49, Harald Sitter <sit...@kde.org> wrote: >> >> hola >> >> breeze-icons uses lots of symlinks. Unfortunately, ever so often our >> ico

Re: Phabricator: All repositories registered - upcoming workflow changes

On Thu, Feb 2, 2017 at 10:31 AM, Ben Cooksley wrote: > On Thu, Feb 2, 2017 at 10:23 PM, Luigi Toscano > wrote: >> Il 02.02.2017 10:09 Ben Cooksley ha scritto: >> >>> Hi all, >>> >>> As a starting point: keeping the software itself running is a >>>

breeze-icons and the symlink business

hola breeze-icons uses lots of symlinks. Unfortunately, ever so often our icon designers make a mistake and create a bad symlink. To mitigate this I added a bunch of tests making sure everything is nice and dandy. In the mean parts of the build were changed to not tolerate broken symlinks. While

[Differential] [Closed] D4254: add new test for scalable exposure

This revision was automatically updated to reflect the committed changes. Closed by commit R266:7d01f3d8b5c0: add new test for scalable exposure (authored by sitter). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4254?vs=10460=10757 REVISION DETAIL

[Differential] [Closed] D4268: deprecate the security class

This revision was automatically updated to reflect the committed changes. Closed by commit R304:0dc151ae2c8b: deprecate the security class (authored by sitter). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4268?vs=10491=10501 REVISION DETAIL

[Differential] [Request, 54 lines] D4268: deprecate the security class

sitter created this revision. sitter added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The Security class is not actually used, hasn't seen any active development in years and uses gpg in a

[Differential] [Updated, 285 lines] D4254: add new test for scalable exposure

sitter updated this revision to Diff 10460. sitter added a comment. warning-- qdebug the limited testing of the test REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4254?vs=10459=10460 BRANCH master REVISION DETAIL

[Differential] [Request, 286 lines] D4254: add new test for scalable exposure

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY the icon themes use SVG but do not want the same icon to be used for small resolutions as to not have high-detail icons at super small

Re: Preferred way for an application to inhibit suspend on KDE

On Fri, Jan 20, 2017 at 4:35 PM, elboulangero wrote: > Thanks for the information. > > I'm running KDE Neon on a virtual machine, downloaded from > , and I can tell you that there's no > 'org.freedesktop.PowerManagement' or

knewstuff's gpg use

Morning, I had the most peculiar incident just now. KNewstuff shouted at me because I have no bin/gpg(2). As it turns out core/security.cpp implements some form of gpg signing verification. Based on the gpg CLI app. Naturally, I am perplexed by this because CMake doesn't actually report gpg as a

Re: Review Request 129517: don't ignore return value, verify it

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 055363fa0899d475487fe13a151d297b38bf66e2 by Harald Sitter to branch master. Repository: syntax-highlighting Description --- if we can't mkdir the output dir all tests will fail on creating

Re: Review Request 129779: Fix oxygen icons duplicates test

to tell Andreas and he's usually happy enough to fix it asap. He just needs to be made aware somehow :) - Harald Sitter On Jan. 8, 2017, 1:34 a.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To rep

Re: What's kde-core-devel for?

On Thu, Dec 15, 2016 at 10:18 PM, Albert Astals Cid wrote: > In the old days it had kdelibs development discussion but not that that has > moved over to kde-frameworks-devel, waht's kde-core-devel for? *cough* http://markmail.org/thread/opcvfo5h7elrvqdl Everyone kinda agrees that

Re: Review Request 126650: [WIP] Add PM/ScreenSaver Inhibition capabilities to KIdleTime

://www.freedesktop.org/wiki/Specifications/power-management-spec/ supposedly in favor of https://www.freedesktop.org/wiki/Software/systemd/inhibit/ which apparently is being ignored to a degree by powerdevil. - Harald Sitter On Jan. 26, 2016, 6:13 p.m., Martin Klapetek wrote

Screenshot hosting repo (e.g. for Appstream)

Hey, We have just finished sorting out a centralized screenshot repo. This repo should be used for promotional screenshots of KDE software. Specifically, when using screenshots for appstream data you should put your screenshots in there and reference them via https://cdn.kde.org/screenshots/ git

Review Request 129517: don't ignore return value, verify it

still Thanks, Harald Sitter

Re: Review Request 129426: refactor gpg finding

/CMakeLists.txt 2f99bc3cca89dd7a194f46cb314d2f7f90f931f3 tests/kwalletd/CMakeLists.txt 1e7c4b77ba478147fae964f61c28a736e32b9ea9 Diff: https://git.reviewboard.kde.org/r/129426/diff/ Testing --- builds and continues to link to gpg Thanks, Harald Sitter

Re: Review Request 129426: refactor gpg finding

r > > the old one to the new one. > > Harald Sitter wrote: > You take offense with an if checking whether we can build with gpg > support? > > Andreas Sturmlechner wrote: > It does the opposite of what you say you want in the description. > Preferring the new lib is t

Re: Review Request 129426: refactor gpg finding

r > > the old one to the new one. > > Harald Sitter wrote: > You take offense with an if checking whether we can build with gpg > support? > > Andreas Sturmlechner wrote: > It does the opposite of what you say you want in the description. > Preferring the new lib is t

Re: Review Request 129426: refactor gpg finding

iewboard.kde.org/r/129426/#review100933 ------- On Nov. 18, 2016, 2 p.m., Harald Sitter wrote: > > --- > This is an automatically generated e-mail. To reply, v

Review Request 129426: refactor gpg finding

://git.reviewboard.kde.org/r/129426/diff/ Testing --- builds and continues to link to gpg Thanks, Harald Sitter

[Differential] [Accepted] D3314: Properly test environment variable

sitter accepted this revision. sitter added a reviewer: sitter. BRANCH master REVISION DETAIL https://phabricator.kde.org/D3314 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #frameworks, sebas, sitter

Re: python binding's __init__.py

On Tue, Nov 15, 2016 at 4:04 PM, Stephen Kelly <steve...@gmail.com> wrote: > Harald Sitter wrote: > >> Alohas >> >> I am currently trying to package kitemmodels' python bindings. The >> module generator installs >> >> -./usr/lib/python2.7/dist-pa

python binding's __init__.py

Alohas I am currently trying to package kitemmodels' python bindings. The module generator installs -./usr/lib/python2.7/dist-packages/PyKF5/__init__.py -./usr/lib/python2.7/dist-packages/PyKF5/KItemModels.so This will cause a fairly shitty problem on packaging level, when a second framework

Re: Review Request 128626: silence contentHash deprecation warnings

9b1cadec2296132c2ec4a7fc8142ec34cb3381f1 src/kpackagetool/kpackagetool.cpp 4f5b78761ced760f081b3449afc67790d25138a2 Diff: https://git.reviewboard.kde.org/r/128626/diff/ Testing --- builds & tests pass (sans appstream, which I guess I didn't break :P) Thanks, Harald Sitter

how to appstream

I couldn't find reasonable documentation on how to best add appstream data to a kde application, so I threw this together here: https://community.kde.org/HowToAppStream HTH HS

Re: Review Request 129273: Remove /KF5 include directory injection

marked as submitted. Review request for KDE Frameworks and Aleix Pol Gonzalez. Changes --- Submitted with commit 55f550ca675d438d27e98b16256b555af8a0e6bd by Harald Sitter to branch master. Repository: kwindowsystem Description --- This is ancient code that is outright wrong most

Review Request 129273: Remove /KF5 include directory injection

/KF5/KWindowSystem;/usr/include;/usr/include;${_IMPORT_PREFIX}/include/KF5" INTERFACE_LINK_LIBRARIES "Qt5::Widgets" ) ``` FTR: the static /usr/include thingies come from manually pulling in X11 paths, which is technically still wrong but out of scope and somewhat harder to resolve correctly. Thanks, Harald Sitter

Re: Review Request 128437: raise to core dump handlers when drkonqi is done

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 85eef3241e45a0f1799069fa687f68ed9f802ef9 by Harald Sitter to branch master. Repository: kcrash Description --- with the rise of useful core dump handlers such as systemd's coredump

Re: Review Request 128437: raise to core dump handlers when drkonqi is done

.org/r/128437/diff/ Testing --- builds and passes Thanks, Harald Sitter

Re: Review Request 129028: introduce dupe test from breeze-icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129028/#review99607 --- Ship it! shipping as part of 129026 - Harald Sitter

Re: Review Request 129028: introduce dupe test from breeze-icons

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 54a388ecb700f9e0030ce66535fe84b0e22276b1 by Harald Sitter to branch master. Repository: oxygen-icons5 Description --- this test uses the external binary fdupes to find duplicated files

Re: Review Request 128115: do not load and debug in the same line

/128115/diff/ Testing --- makes && test passes Thanks, Harald Sitter

Review Request 129028: introduce dupe test from breeze-icons

autotests/dupetest.cpp PRE-CREATION autotests/testdata.h.cmake 476cf9ebf8b45c65e5479e14adcb1ea352e1f24d autotests/testhelpers.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/129028/diff/ Testing --- Thanks, Harald Sitter

Re: Review Request 129024: fail the entire dupe test if fdupes is not present

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 92fda2493cc40fe8a243722f5a6630ae050d4367 by Harald Sitter to branch master. Repository: breeze-icons Description --- ctest doesn't know about skip or anything but fail, so in the interest

Review Request 129024: fail the entire dupe test if fdupes is not present

Description --- ctest doesn't know about skip or anything but fail, so in the interest of getting reports on this fail the test Diffs - autotests/dupetest.cpp bf1a67ccff789b5d3bdbe1c730d8c3441691a025 Diff: https://git.reviewboard.kde.org/r/129024/diff/ Testing --- Thanks, Harald

Re: Review Request 129021: add a test to find duplicated files (inspired by similar test in debian)

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 343b7ecce2c1a7e42a7a913258d65e993b603bce by Harald Sitter to branch master. Repository: breeze-icons Description --- run a duplicate detection program on the icon dir trees to detect

Re: Review Request 129021: add a test to find duplicated files (inspired by similar test in debian)

15047ea72f95cbaa4578668e59ad687faa8ae230 autotests/testdata.h.cmake 476cf9ebf8b45c65e5479e14adcb1ea352e1f24d autotests/testhelpers.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/129021/diff/ Testing --- correctly detects all the nasty dupes Thanks, Harald Sitter

Re: Review Request 129021: add a test to find duplicated files (inspired by similar test in debian)

15047ea72f95cbaa4578668e59ad687faa8ae230 autotests/testdata.h.cmake 476cf9ebf8b45c65e5479e14adcb1ea352e1f24d autotests/testhelpers.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/129021/diff/ Testing --- correctly detects all the nasty dupes Thanks, Harald Sitter

Re: Review Request 129021: add a test to find duplicated files (inspired by similar test in debian)

FAIL unwind the stack? - Harald --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129021/#review99526 --- On Sept. 26, 2016

Review Request 129021: add a test to find duplicated files (inspired by similar test in debian)

/CMakeLists.txt 9e3f841d951afb007cba3da79c217e9c2a3e38da autotests/dupetest.cpp PRE-CREATION autotests/testdata.h.cmake 476cf9ebf8b45c65e5479e14adcb1ea352e1f24d Diff: https://git.reviewboard.kde.org/r/129021/diff/ Testing --- correctly detects all the nasty dupes Thanks, Harald Sitter

Re: Review Request 128913: add a test to prevent file names from having newlines

oard.kde.org/r/128913/#review99187 --- On Sept. 15, 2016, 8:17 a.m., Harald Sitter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: Review Request 128913: add a test to prevent file names from having newlines

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit b92ae8cde0643fe9d77fda8f7470d97bed6f689f by Harald Sitter to branch master. Repository: breeze-icons Description --- there is no reason for why they should. packaging systems take offense. so

Re: Review Request 128913: add a test to prevent file names from having newlines

/CMakeLists.txt 5c561c712322e1b90fdd2806ba4ce4011be2ad14 autotests/newlinetest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/128913/diff/ Testing --- makes and fails current master since it has broken files Thanks, Harald Sitter

Review Request 128913: add a test to prevent file names from having newlines

and fails current master since it has broken files Thanks, Harald Sitter

Review Request 128626: silence contentHash deprecation warnings

4f5b78761ced760f081b3449afc67790d25138a2 Diff: https://git.reviewboard.kde.org/r/128626/diff/ Testing --- builds & tests pass (sans appstream, which I guess I didn't break :P) Thanks, Harald Sitter

Re: Review Request 128533: Create a test that validates projects' appstream information

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128533/#review98097 --- Ship it! Ship It! - Harald Sitter On Aug. 4, 2016, 11

Re: Review Request 128533: Create a test that validates projects' appstream information

somesuch magic If you actually pick up the result of the validation and then `message(STATUS` on ==0 or `message(FATAL_ERROR`, I think usefulness will go up 300% by actually claiming a validation fail when there was a fail :) - Harald Sitter On Aug. 3, 2016, 11:21

Re: Can't release applications

On Wed, Jul 27, 2016 at 12:27 PM, Luigi Toscano wrote: > On Wednesday, 27 July 2016 12:22:45 CEST Aleix Pol wrote: >> Hi, >> There's a major blocker when trying to release applications nowadays. >> To update the stable branch one needs to commit to the >>

Re: License issue with AppImage file in Ark repo

On Wed, Jul 27, 2016 at 12:00 PM, Elvis Angelaccio wrote: > Hi, > we have a an AppImage file [1] used as test data in Ark. This AppImage > contains a copy of the GNU hello [2] binary. > > Jonathan asked us if we could add the source code of this binary, in > order to

Re: Snappy sprint reporty musing

On Tue, Jul 26, 2016 at 1:08 PM, Harald Sitter <sit...@kde.org> wrote: > Snappy right now has limited exposure as it is only available on > Ubuntu (Unity). This is actively being worked on with main blockers > being missing golang stacks (snapd is mostly written in Go), missing >

Re: Snappy sprint reporty musing

On Tue, Jul 26, 2016 at 2:07 PM, Sebastian Kügler <se...@kde.org> wrote: > On Tuesday, July 26, 2016 1:08:28 PM CEST Harald Sitter wrote: >> - a store REST API (of which the reference version is the ubuntu store) > > So something like this exists for flatpaks as well,

Snappy sprint reporty musing

Hello sweeties! Last week Scarlett, Aleix, Matthias and I took to the Snappy sprint in Heidelberg to discuss how to make it the most useful for KDE. I'd like to give you an overview of what was discussed along with some background, so we are all on the same page. If you already know what Snappy

Re: The curious case of stuck systemd poweroff

On Thu, Jul 14, 2016 at 8:06 PM, Andreas Hartmetz <ahartm...@gmail.com> wrote: > On Donnerstag, 14. Juli 2016 16:19:15 CEST Harald Sitter wrote: >> On Thu, Jul 14, 2016 at 3:43 PM, Andreas Hartmetz > <ahartm...@gmail.com> wrote: >> > Hello, >> > >&g

Re: The curious case of stuck systemd poweroff

On Thu, Jul 14, 2016 at 3:43 PM, Andreas Hartmetz <ahartm...@gmail.com> wrote: > Hello, > > Am Donnerstag, 14. Juli 2016, 11:11:26 CEST schrieb Harald Sitter: >> Hola! >> >> ever since systemd and or sddm started not killing all our session >> processes

Re: Review Request 128437: raise to core dump handlers when drkonqi is done

> On July 13, 2016, 12:43 p.m., Kai Uwe Broulik wrote: > > +1 to the idea > > > > However, will this mean we get this awful apport "something crashed, now or > > in the past" tray icon in addition to Drkonqi? > > Harald Sitter wrote: > ye

Re: Review Request 128437: raise to core dump handlers when drkonqi is done

> On July 13, 2016, 12:43 p.m., Kai Uwe Broulik wrote: > > +1 to the idea > > > > However, will this mean we get this awful apport "something crashed, now or > > in the past" tray icon in addition to Drkonqi? > > Harald Sitter wrote: > ye

Re: Review Request 128437: raise to core dump handlers when drkonqi is done

m (e.g. RHEL) already > > explicitly disable DrKonqi. > > Harald Sitter wrote: > That's not what the change does. > > Kevin Kofler wrote: > It raises the crash to the downstream bug handler, which in turn will > unfortunately encourage the users to file the bug in the down

Re: Review Request 128437: raise to core dump handlers when drkonqi is done

> On July 13, 2016, 12:43 p.m., Kai Uwe Broulik wrote: > > +1 to the idea > > > > However, will this mean we get this awful apport "something crashed, now or > > in the past" tray icon in addition to Drkonqi? > > Harald Sitter wrote: > ye

The curious case of stuck systemd poweroff

Hola! ever since systemd and or sddm started not killing all our session processes we have had problems of poweroff/reboot getting hung up waiting for processes to quit. Recently systemd then started sending them TERM by default, which in theory should make things behave as before, but more often

Re: Review Request 128437: raise to core dump handlers when drkonqi is done

e.org/r/128437/#review97363 --- On July 13, 2016, 12:40 p.m., Harald Sitter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128437/ > ---

Re: Review Request 128437: raise to core dump handlers when drkonqi is done

h as their use case is more involved. - Harald --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128437/#review97345 --- On July 13,

Review Request 128437: raise to core dump handlers when drkonqi is done

b8c6477a70291ca9c1f0efef3bba061b6af247b0 Diff: https://git.reviewboard.kde.org/r/128437/diff/ Testing --- builds and passes Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: kded's cmake package

On Fri, Jul 1, 2016 at 1:34 PM, Aleix Pol <aleix...@kde.org> wrote: > On Wed, Jun 29, 2016 at 11:22 AM, Harald Sitter <sit...@kde.org> wrote: >> Hola! >> >> So, I just noticed that KDED's cmake package is inconsistently named. >> >&g

kded's cmake package

Hola! So, I just noticed that KDED's cmake package is inconsistently named. cmake/KF5DocTools/ versus cmake/KDED/ Is there a reason for this? Are we going to change this for KF6? :/ HS ___ Kde-frameworks-devel mailing list

Re: Review Request 128147: isolate autotests from (installed) production data

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 74d8f8ede542a51405f3b3e1d526ca2a93e30a78 by Harald Sitter to branch master. Repository: kemoticons Description --- this means - doesn't depend on Glass theme anymore - doesn't hardcode

<    5   6   7   8   9   10   11   12   13   >