D11716: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa

This revision was automatically updated to reflect the committed changes. Closed by commit R241:f1ab805c4ebc: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa (authored by rominf). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D11716: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa

rominf updated this revision to Diff 30696. rominf added a comment. - Replace #ifdef with #if REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11716?vs=30629=30696 BRANCH fix-ntfs-hidden-files-on-freebsd REVISION DETAIL https://phabricator.kde.org/D11716

D11716: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa

rominf updated this revision to Diff 30629. rominf added a comment. - Consider criticism REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11716?vs=30627=30629 BRANCH fix-ntfs-hidden-files-on-freebsd REVISION DETAIL https://phabricator.kde.org/D11716

D11716: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa

rominf updated this revision to Diff 30627. rominf added a comment. - Add a trailing newline to the end of the file REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11716?vs=30626=30627 BRANCH fix-ntfs-hidden-files-on-freebsd REVISION DETAIL

D11716: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa

rominf updated this revision to Diff 30626. rominf added a comment. - Actualy fixing build REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11716?vs=30625=30626 BRANCH fix-ntfs-hidden-files-on-freebsd REVISION DETAIL https://phabricator.kde.org/D11716

D11204: Support NTFS hidden files

rominf added inline comments. INLINE COMMENTS > kossebau wrote in file_unix.cpp:40 > This unconditional include sadly breaks the build at least on FreeBSD (see > https://build.kde.org/view/Frameworks/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/164/console > ) and other systems where this

D11716: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa

rominf created this revision. rominf added reviewers: Dolphin, kossebau, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. rominf requested review of this revision. REVISION SUMMARY Support hidden NTFS files only on OS that

D11204: Support NTFS hidden files

rominf marked 8 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11204 To: rominf, #dolphin, #frameworks, dfaure Cc: kossebau, dfaure, markg, elvisangelaccio, ltoscano, anthonyfieroni, broulik, #frameworks, #dolphin, michaelh, ngraham

D11204: Support NTFS hidden files

rominf closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11204 To: rominf, #dolphin, #frameworks, dfaure Cc: dfaure, markg, elvisangelaccio, ltoscano, anthonyfieroni, broulik, #frameworks, #dolphin, michaelh, ngraham

D11204: Support NTFS hidden files

rominf edited the summary of this revision. REPOSITORY R241 KIO BRANCH ntfs-hidden (branched from master) REVISION DETAIL https://phabricator.kde.org/D11204 To: rominf, #dolphin, #frameworks, dfaure Cc: dfaure, markg, elvisangelaccio, ltoscano, anthonyfieroni, broulik, #frameworks,

D11204: Support NTFS hidden files

rominf updated this revision to Diff 30474. rominf added a comment. - Consider criticism - Split multiple statements to put one statement on a line REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11204?vs=30468=30474 BRANCH ntfs-hidden (branched from

D11204: Support NTFS hidden files

rominf added inline comments. INLINE COMMENTS > dfaure wrote in file_unix.cpp:422 > Doesn't this need to be static, for the next line to be standards compliant? > Not 100% sure. No, it's enough for array length to be `constexpr`. > dfaure wrote in file_unix.cpp:431 > QVarLengthArray might be

D11204: Support NTFS hidden files

rominf updated this revision to Diff 30468. rominf marked 4 inline comments as done. rominf added a comment. - Consider criticism REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11204?vs=29475=30468 BRANCH ntfs-hidden (branched from master) REVISION DETAIL

D11204: Support NTFS hidden files

rominf added inline comments. INLINE COMMENTS > markg wrote in file_unix.cpp:546-550 > Why here? > This should be done inside the createUDSEntry function (it's in file.cpp). The logic behind this is that `getxattr` exists only on Linux

D11204: Support NTFS hidden files

rominf updated this revision to Diff 29475. rominf added a comment. - Cleanup REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11204?vs=29473=29475 BRANCH ntfs-hidden REVISION DETAIL https://phabricator.kde.org/D11204 AFFECTED FILES

D11318: Support NTFS hidden files

rominf abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11318 To: rominf Cc: #frameworks, michaelh, ngraham

D11204: Support NTFS hidden files

rominf updated this revision to Diff 29473. rominf added a comment. - Move isNtfsHidden to file ioslave REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11204?vs=29141=29473 BRANCH ntfs-hidden REVISION DETAIL https://phabricator.kde.org/D11204 AFFECTED

D11204: Support NTFS hidden files

rominf added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kfileitem.cpp:1116-1136 > Indeed this should be done in different way, about me > > std::uint64_t attr; > length = getxattr(fileName, attrName, , sizeof attr); > if (length <= 0) { > return false; > } I wish

D11204: Support NTFS hidden files

rominf updated this revision to Diff 29141. rominf marked an inline comment as done. rominf added a comment. Use delete[] for array deletion REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11204?vs=29137=29141 BRANCH ntfs-hidden REVISION DETAIL

D11204: Support NTFS hidden files

rominf added a comment. In D11204#222421 , @broulik wrote: > Shouldn't that rather go into the `file` KIO slave so it sets the `UDS_HIDDEN` attribute? I think you are right, but I don't have an idea what "`file` KIO slave" means. Can

D11204: Support NTFS hidden files

rominf edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11204 To: rominf, #dolphin, #frameworks Cc: #frameworks, #dolphin, michaelh

D11204: Support NTFS hidden files

rominf edited the summary of this revision. rominf added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11204 To: rominf, #dolphin, #frameworks Cc: #frameworks, #dolphin, michaelh

D11204: Support NTFS hidden files

rominf created this revision. rominf added a reviewer: Dolphin. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. rominf requested review of this revision. REVISION SUMMARY This patch implements function isHiddenNtfs which checks extended