Hi Everyone,
As discussed by david in his blog post [1], we worked on the component
in question to solve the problem of X11 applications that want to use
the screencasting services on Wayland.
https://invent.kde.org/system/xwaylandvideobridge
While there's some corners to polish here and there,
On Fri, Jun 16, 2023 at 10:31 PM Albert Astals Cid wrote:
>
> El divendres, 16 de juny de 2023, a les 18:43:59 (CEST), Aleix Pol va
> escriure:
> > Hi Everyone,
> > As discussed by david in his blog post [1], we worked on the component
> > in question to solve the
No, it will be the same settings as any other, as it's picked up using
the standard directories. You can probably override XDG_CONFIG_DIRS
for it or something like that.
I recommend using a nested kwin until you're somewhat confident that
the feature works. It makes for an easier experience.
Hi!
It sure looks like an interesting app, looking forward to seeing what
you come up with!
Aleix
On Sun, Jun 9, 2024 at 10:02 PM Гена Черныщук wrote:
>
> Hi KDE Development Team!
>
> We would like to request an incubation for Crow Translate
>
u like to be my incubation sponsor?
>
> ср, 12 июн. 2024 г. в 02:13, Aleix Pol :
>>
>> Hi!
>> It sure looks like an interesting app, looking forward to seeing what
>> you come up with!
>>
>> Aleix
>>
>> On Sun, Jun 9, 2024 at 10:02 PM Гена Черныщук
and KDE Frameworks.
Description
---
Don't use QT_INCLUDES, it's not available for Qt5.
I have no idea why we didn't trigger that before.
Diffs
-
staging/kde4support/src/ConfigureChecks.cmake 578277c
Diff: http://git.reviewboard.kde.org/r/112525/diff/
Testing
---
Thanks,
Aleix
QT_INCLUDES, it's not available for Qt5.
I have no idea why we didn't trigger that before.
Diffs
-
staging/kde4support/src/ConfigureChecks.cmake 578277c
Diff: http://git.reviewboard.kde.org/r/112525/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
:50 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112451/
---
(Updated Sept. 4, 2013, 2:50 p.m
/r/112536/diff/
Testing
---
builds, tests pass.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/src/velocity.h
staging/kunitconversion/src/velocity.cpp
staging/kunitconversion/src/volume.h
staging/kunitconversion/src/volume.cpp
tier2/CMakeLists.txt 1f110e8
Diff: http://git.reviewboard.kde.org/r/112536/diff/
Testing
---
builds, tests pass.
Thanks,
Aleix Pol Gonzalez
staging/kunitconversion/src/volume.h
staging/kunitconversion/src/volume.cpp
tier2/CMakeLists.txt 1f110e8
Diff: http://git.reviewboard.kde.org/r/112536/diff/
Testing
---
builds, tests pass.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel
.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
staging/kcompletion/src/kcompletion.cpp bcd220a
staging/kcompletion/src/khistorycombobox.cpp fe955a2
Diff: http://git.reviewboard.kde.org/r/112560/diff/
Testing
---
builds, tests pass.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel
don't need a ${variable}.
BTW, are you sure that many publicly linked libraries are needed?
- Aleix Pol Gonzalez
On Sept. 7, 2013, 7:45 p.m., David Edmundson wrote:
---
This is an automatically generated e-mail. To reply, visit
/kdoctools/src/CMakeLists.txt 72bb06e
staging/kdoctools/src/meinproc.cpp 5d476f6
staging/kdoctools/src/meinproc_simple.cpp 334f13f
Diff: http://git.reviewboard.kde.org/r/112545/diff/
Testing
---
Builds, both ways.
Thanks,
Aleix Pol Gonzalez
/kcompletion.cpp bcd220a
staging/kcompletion/src/khistorycombobox.cpp fe955a2
Diff: http://git.reviewboard.kde.org/r/112560/diff/
Testing
---
builds, tests pass.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel
://git.reviewboard.kde.org/r/112570/diff/
Testing
---
Builds, although it doesn't change much in linux.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
:D
- Aleix
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112570/#review39569
---
On Sept. 6, 2013, 6:52 p.m., Aleix Pol Gonzalez
---
On Sept. 9, 2013, 2:50 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112545
)
-
staging/kdoctools/src/CMakeLists.txt 72bb06e
staging/kdoctools/src/meinproc.cpp 5d476f6
staging/kdoctools/src/meinproc_simple.cpp 334f13f
Diff: http://git.reviewboard.kde.org/r/112545/diff/
Testing
---
Builds, both ways.
Thanks,
Aleix Pol Gonzalez
)
-
staging/kdoctools/src/CMakeLists.txt 72bb06e
staging/kdoctools/src/meinproc.cpp 5d476f6
staging/kdoctools/src/meinproc_simple.cpp 334f13f
Diff: http://git.reviewboard.kde.org/r/112545/diff/
Testing
---
Builds, both ways.
Thanks,
Aleix Pol Gonzalez
5e8ae19
Diff: http://git.reviewboard.kde.org/r/112643/diff/
Testing
---
Builds, tests pass.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/khistorycombobox.cpp 2e53bd9
staging/kcompletion/src/klineedit.cpp 76ef377
Diff: http://git.reviewboard.kde.org/r/112689/diff/
Testing
---
builds, tests pass.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
Diff: http://git.reviewboard.kde.org/r/112696/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
it to FindKDocTools.cmake?
Diffs
-
staging/kdoctools/CMakeLists.txt 7687f97
staging/kdoctools/src/CMakeLists.txt 6910ef7
Diff: http://git.reviewboard.kde.org/r/112699/diff/
Testing
---
Builds
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel
/CMakeLists.txt b64e2f7
staging/ki18n/KI18nConfig.cmake.in 3e90a9e
Diff: http://git.reviewboard.kde.org/r/112700/diff/
Testing
---
Builds, tests pass.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel
Diff: http://git.reviewboard.kde.org/r/112697/diff/
Testing
---
Still builds.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
. To reply, visit:
http://git.reviewboard.kde.org/r/112697/#review39918
---
On Sept. 12, 2013, 5 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply
ff0feb0
tier2/kauth/src/CMakeLists.txt 31f0f9c
tier2/kcrash/src/CMakeLists.txt f340acd
Diff: http://git.reviewboard.kde.org/r/112697/diff/
Testing
---
Still builds.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde
., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112697/
---
(Updated Sept. 13, 2013, 10:33 a.m
---
builds, tests pass.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/112699/diff/
Testing
---
Builds
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112699/#review39917
---
On Sept. 12, 2013, 5:22 p.m., Aleix Pol Gonzalez wrote
staging/ki18n/src/ktranscript_p.h
staging/ki18n/src/kuitmarkup.h
staging/ki18n/src/kuitmarkup.cpp
staging/ki18n/src/kuitmarkup_p.h
tier2/CMakeLists.txt f88af0c
Diff: http://git.reviewboard.kde.org/r/112715/diff/
Testing
---
Thanks,
Aleix Pol Gonzalez
/CMakeLists.txt ff0feb0
tier2/kauth/src/CMakeLists.txt 31f0f9c
tier2/kcrash/src/CMakeLists.txt f340acd
Diff: http://git.reviewboard.kde.org/r/112697/diff/
Testing
---
Still builds.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing
/kstringhandler.cpp 2f192aa
Diff: http://git.reviewboard.kde.org/r/112717/diff/
Testing
---
Builds, affected tests pass.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman
://git.reviewboard.kde.org/r/112717/#review39986
---
On Sept. 13, 2013, 5:12 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112717/#review40054
---
On Sept. 13, 2013, 5:55 p.m., Aleix Pol Gonzalez wrote
/kcompletionuitest.h
staging/kcompletion/tests/kcompletionuitest.cpp
staging/kcompletion/tests/klineedittest.h
staging/kcompletion/tests/klineedittest.cpp
tier2/CMakeLists.txt 51f093b
Diff: http://git.reviewboard.kde.org/r/112758/diff/
Testing
---
Builds, tests pass.
Thanks,
Aleix Pol
://git.reviewboard.kde.org/r/112759/#comment29689
Seems like you should use ${REQUIRED_QT_VERSION} here too... no?
- Aleix Pol Gonzalez
On Sept. 16, 2013, 5:12 p.m., Michael Palimaka wrote:
---
This is an automatically generated e-mail. To reply
concerns in a
specific use of QCollator in this patch I can leave it out, but I think this
should go in.
Thoughts?
- Aleix Pol Gonzalez
On Sept. 13, 2013, 5:55 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112583/#review40184
---
Ship it!
Looks good to me.
- Aleix Pol Gonzalez
On Sept
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112519/#review40185
---
Bump! what's the status of this?
- Aleix Pol Gonzalez
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112547/
---
(Updated Sept. 17, 2013, 11:14 a.m.)
Status
--
This change has been
://git.reviewboard.kde.org/r/112772/diff/
Testing
---
Ported some tests in KF5, it worked.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
, 12:35 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112772/
---
(Updated Sept. 17, 2013, 12:35
people to upgrade
their Qt repo.
Pushing it now.
- Aleix Pol Gonzalez
On Sept. 18, 2013, 2:50 p.m., Aurélien Gâteau wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112792
On Sept. 18, 2013, 2:58 p.m., Aleix Pol Gonzalez wrote:
I was waiting for alex to send the meeting minutes telling people to
upgrade their Qt repo.
Pushing it now.
It's pushed, sorry for the wait .
- Aleix
, no tests.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/kstringhandler.h 442b97a
tier1/kcoreaddons/src/lib/text/kstringhandler.cpp ea3bbf5
Diff: http://git.reviewboard.kde.org/r/112797/diff/
Testing
---
Builds, tests pass.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel
On Sept. 18, 2013, 3:22 p.m., Mark Gaiser wrote:
How RUDE to just commit this without a addressing the concerns Frank and i
have. That is not appreciated!
Aleix Pol Gonzalez wrote:
Alright, maybe I didn't think this through. I'll un-deprecate and bring
back the KStringHandler
/#review40289
---
On Sept. 18, 2013, 4:55 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112797
to KDNSSD.
Properly look-up Qt and KF5.
After that I'll move it to staging.
Diffs
-
dnssd/CMakeLists.txt 7f2620a
Diff: http://git.reviewboard.kde.org/r/112803/diff/
Testing
---
Builds, there are no tests.
Thanks,
Aleix Pol Gonzalez
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112808/#review40316
---
Ship it!
Looks good to me.
- Aleix Pol Gonzalez
On Sept
CMAKECONFIG_INSTALL_DIR.
- Aleix
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112795/#review40321
---
On Sept. 18, 2013, 3:34 p.m., Aleix Pol
, there are no tests.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112823/#review40350
---
Maybe you should add a note in KDE5Porting.html?
- Aleix Pol
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112823/#review40351
---
Maybe you should add a note in KDE5Porting.html?
- Aleix Pol
dnssd/servicetypebrowser.h
dnssd/settings.kcfgc
dnssd/src/CMakeLists.txt PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/112825/diff/
Testing
---
Builds, there are no tests.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing
the nomenclature we're
using so far in KF5.
Additionally, an executable has many unit tests inside.
- Aleix Pol Gonzalez
On Sept. 19, 2013, 3:57 p.m., Alexander Richardson wrote:
---
This is an automatically generated e-mail. To reply, visit
kutils/CMakeLists.txt 0cb281d
staging/xmlgui/tests/krichtexteditor/CMakeLists.txt 372856b
Diff: http://git.reviewboard.kde.org/r/112830/diff/
Testing
---
Builds
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks
://git.reviewboard.kde.org/r/112840/diff/
Testing
---
Builds, nothing seem to have changed.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
: http://git.reviewboard.kde.org/r/112825/diff/
Testing
---
Builds, there are no tests.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112882/#review40492
---
Ship it!
\o/
- Aleix Pol Gonzalez
On Sept. 22, 2013, 12:32
On Sept. 23, 2013, 11:18 a.m., Kevin Ottens wrote:
staging/kprintutils/KPrintUtilsConfig.cmake.in, line 3
http://git.reviewboard.kde.org/r/112882/diff/1/?file=191209#file191209line3
I surely has other dependencies.
Most things in staging have faulty *Config.cmake.in files, I'd say
9e7806d
kutils/CMakeLists.txt 0cb281d
staging/xmlgui/tests/krichtexteditor/CMakeLists.txt 372856b
Diff: http://git.reviewboard.kde.org/r/112830/diff/
Testing
---
Builds
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde
/112797/diff/
Testing
---
Builds, tests pass.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112897/#review40576
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Sept. 23, 2013
)
Aleix Pol Gonzalez wrote:
Building standalone is not one of the things required by
http://community.kde.org/Frameworks/Epics/Splitting_kdelibs .
Also it's something we probably want to deal with at a later stage, when
we decide how each should be distributed.
Aurélien Gâteau
://git.reviewboard.kde.org/r/112900/diff/
Testing
---
Builds, there are no tests.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
)
Aleix Pol Gonzalez wrote:
Building standalone is not one of the things required by
http://community.kde.org/Frameworks/Epics/Splitting_kdelibs .
Also it's something we probably want to deal with at a later stage, when
we decide how each should be distributed.
Aurélien Gâteau
/CMakeLists.txt 0cb281d
staging/kemoticons/src/core/CMakeLists.txt f7fb463
staging/ktextwidgets/src/CMakeLists.txt 4787c10
Diff: http://git.reviewboard.kde.org/r/112901/diff/
Testing
---
Everything still builds
Thanks,
Aleix Pol Gonzalez
___
Kde
it much easier to read such patches where there are moves and changes.
Also, why did you change from Qt5::Xml to Qt5Xml?
- Aleix Pol Gonzalez
On Sept. 23, 2013, 5:42 p.m., David Gil Oliva wrote:
---
This is an automatically generated e
it much easier to read such patches where there are moves and changes.
Also, why did you change from Qt5::Xml to Qt5Xml?
- Aleix Pol Gonzalez
On Sept. 23, 2013, 5:42 p.m., David Gil Oliva wrote:
---
This is an automatically generated e
---
Builds, there are no tests.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
-publicservice.cpp 119c5a8
dnssd/src/mdnsd-publicservice.cpp 2a775fa
dnssd/src/servicemodel.cpp 348db57
staging/kde4support/CMakeLists.txt 24ee457
Diff: http://git.reviewboard.kde.org/r/112900/diff/
Testing
---
Builds, there are no tests.
Thanks,
Aleix Pol Gonzalez
dnssd/src/mdnsd-publicservice.cpp 2a775fa
dnssd/src/servicemodel.cpp 348db57
Diff: http://git.reviewboard.kde.org/r/112900/diff/
Testing
---
Builds, there are no tests.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde
kparts/statusbarextension.cpp
kparts/textextension.h
kparts/textextension.cpp
staging/kde4support/src/CMakeLists.txt 5dc206d
Diff: http://git.reviewboard.kde.org/r/112919/diff/
Testing
---
builds, tests pass.
Thanks,
Aleix Pol Gonzalez
pass.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/CMakeLists.txt
http://git.reviewboard.kde.org/r/112921/#comment29960
Make it REQUIRED?
find_package(Qt5Xml REQUIRED)
Looks good to me.
- Aleix Pol Gonzalez
On Sept. 24, 2013, 10:09 p.m., David Gil Oliva wrote
://git.reviewboard.kde.org/r/112926/#comment29971
Maybe pass REQUIRED_QT_VERSION?
- Aleix Pol Gonzalez
On Sept. 25, 2013, 9:09 a.m., Martin Klapetek wrote:
---
This is an automatically generated e-mail. To reply, visit:
http
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112927/#review40751
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Sept. 25, 2013
about superbuild.
Why do we need to specify the dependencies from superbuild? Shouldn't they
depend on the Config.cmake files?
- Aleix Pol Gonzalez
On Sept. 25, 2013, 12:54 p.m., David Edmundson wrote:
---
This is an automatically
/servicetypebrowser.h
dnssd/src/settings.kcfgc
staging/kde4support/src/ConfigureChecks.cmake 21cac3f
tier2/CMakeLists.txt 73175b3
Diff: http://git.reviewboard.kde.org/r/112942/diff/
Testing
---
Builds, no tests
Thanks,
Aleix Pol Gonzalez
___
Kde
/plugin_spellcheck.rc
kparts/tests/testmainwindow.h
kparts/tests/testmainwindow.cpp
tier3/CMakeLists.txt 5ac107a
Diff: http://git.reviewboard.kde.org/r/112943/diff/
Testing
---
Builds, tests pass.
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks
/kwebwallet.h
kdewebkit/src/kwebwallet.cpp
staging/kde4support/src/ConfigureChecks.cmake 21cac3f
tier3/CMakeLists.txt 5ac107a
Diff: http://git.reviewboard.kde.org/r/112944/diff/
Testing
---
Builds, there are no tests
Thanks,
Aleix Pol Gonzalez
. 25, 2013, 5:35 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112942/
---
(Updated Sept. 25, 2013
sugguested.
- Aleix Pol Gonzalez
On Sept. 26, 2013, 11:11 a.m., Vishesh Handa wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112957
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112940/#review40879
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Sept. 26, 2013
://git.reviewboard.kde.org/r/112984/#comment30112
Use KEMOTICONS_DEPRECATED
I don't really understand what's better from ::save instead of ::saveTheme. Is
it just the naming? They seem to do the same.
- Aleix Pol Gonzalez
On Sept. 28, 2013, 9:19 p.m., David Gil Oliva wrote
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112942/#review41021
---
ping?
- Aleix Pol Gonzalez
On Sept. 25, 2013, 5:35 p.m
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112901/#review41023
---
ping?
- Aleix Pol Gonzalez
On Sept. 24, 2013, 1:32 p.m
://git.reviewboard.kde.org/r/112964/#comment30118
Only half our modules are like this so far, should we add this as a KF5
module requirement?
staging/kprintutils/CMakeLists.txt
http://git.reviewboard.kde.org/r/112964/#comment30113
Why are you removing these?
- Aleix Pol Gonzalez
On Sept. 27, 2013, 9:15
an improvement.
- Aleix Pol Gonzalez
On Sept. 27, 2013, 9:15 a.m., Martin Klapetek wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112964
Description
---
Makes a bit of sense of the cmake, adds a TODO.
Diffs
-
staging/kwallet/src/CMakeLists.txt 0aaa39e
staging/kwallet/src/kwallet_mac.cpp d5d522b
Diff: http://git.reviewboard.kde.org/r/113008/diff/
Testing
---
Builds, tests pass.
Thanks,
Aleix Pol Gonzalez
://git.reviewboard.kde.org/r/113045/#comment30168
Why removing these?
- Aleix Pol Gonzalez
On Oct. 2, 2013, 8:06 a.m., David Edmundson wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113045
need to get this
going...
- Aleix Pol Gonzalez
On Sept. 19, 2013, 3:57 p.m., Alexander Richardson wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112828
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113048/#review41108
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Oct. 2, 2013, 10
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113046/#review41109
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Oct. 2, 2013, 8
, but isn't this
going to break source compatibility?
- Aleix Pol Gonzalez
On Oct. 2, 2013, 2:43 p.m., Aurélien Gâteau wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113050
801 - 900 of 4752 matches
Mail list logo