Re: KDEReview for Kontrast

2020-08-03 Thread Carl Schwan
I'm not sure this feature would make sense in Kontrast, but maybe this functionality should be integrated into the new color scheme editor Noah is building. The actual logic for calculating the contrast is very small. What do you think? > > Nate > > On 7/30/20 3:16 AM, Carl Schwan wrote: &g

Re: KDEReview for Kontrast

2020-08-03 Thread Carl Schwan
Carl Schwan https://carlschwan.eu ‐‐‐ Original Message ‐‐‐ Le dimanche, août 2, 2020 3:36 PM, Nicolas Fella a écrit  : > Hi Carl, > > a couple of nitpicks, otherwise looks neat. > > - your CMakeLists.txt does not specify a minimum Qt/KF5 version. Also > E

KDEReview for Kontrast

2020-08-02 Thread Carl Schwan
Hi, I would like to move Kontrast, a contrast checker application, to KDEReview. Kontrast can check if two colors pass the WCAG 2.0 specification and save some user's favorite color combinations. Some screenshots of the application and a design review from the VSG is available here:

Re: KDE Developer portal

2020-07-12 Thread Carl Schwan
r solution we choose, you can count on me to help with > the content. And again, thank you so much for working on this! > > Cheers, > Ivana Isadora > > Den sön 12 juli 2020 kl 00:29 skrev Carl Schwan : > > > Hello everyone, > > > > Some of you probabl

KDE Developer portal

2020-07-11 Thread Carl Schwan
Hello everyone, Some of you probably saw the "First-class user & developer documentation centralized on a portal" goal proposal by Isadora one year ago (https://phabricator.kde.org/T11096). I shared Isadora's opinion, of having a good developer portal with all the information on how to use the

Re: Move Koko to KDEReview

2020-06-14 Thread Carl Schwan
Le jeudi, juin 11, 2020 9:43 PM, Albert Astals Cid a écrit : > El dimarts, 9 de juny de 2020, a les 13:30:35 CEST, Carl Schwan va escriure: > > > Hi, > > I would like to move Koko, a convergent image viewer, to KDEReview. > > Koko is already shipped in the base P

Re: Move Koko to KDEReview

2020-06-12 Thread Carl Schwan
Le mercredi, juin 10, 2020 9:01 AM, Yuri Chornoivan a écrit : > > > 10 червня 2020, 11:35:37, від "Carl Schwan"c...@carlschwan.eu: > > > Hi, > > I would like to move Koko, a convergent image viewer, to KDEReview. > > Koko is already shipp

Move Koko to KDEReview

2020-06-10 Thread Carl Schwan
lab-ci.yml file. * There is an AppStream file. * There is some documentation on userbase: https://userbase.kde.org/Koko I plan to also update it before the next release. Carl Schwan https://carlschwan.eu [1]: https://invent.kde.org/plasma-mobile/koko/-/merge_requests/20 [2]: https://carlschwan.eu/2

D29802: Require in-source build

2020-05-16 Thread Carl Schwan
ognarb accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH require-in-source-build (branched from master) REVISION DETAIL https://phabricator.kde.org/D29802 To: ngraham, #frameworks, #vdg, ognarb Cc: kde-frameworks-devel,

D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )

2020-05-16 Thread Carl Schwan
ognarb added a comment. In D29797#672263 , @kossebau wrote: > Thanks for the (first) review :) > > Open questions I have are these: > a) how to properly check for the presence of the yaml.safe_load() method? and whether to support a

D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )

2020-05-16 Thread Carl Schwan
ognarb accepted this revision. ognarb added a comment. This revision is now accepted and ready to land. +1 and also +1 for removing python2 support REPOSITORY R264 KApiDox BRANCH makedepworkwithpython3 REVISION DETAIL https://phabricator.kde.org/D29797 To: kossebau, #frameworks,

Re: Apps Update for May

2020-05-12 Thread Carl Schwan
Hi, I'm not really happy with how the KDE Apps Monthly Update is happening. I understand why we moved away from the KDE Applications brand and announcement but the current monthly update doesn't feel better, at least from a reader perpective. My first complaint with it is that the

D29511: Label: Add ping-pong logic

2020-05-07 Thread Carl Schwan
ognarb requested changes to this revision. ognarb added a comment. This revision now requires changes to proceed. I'm not sure it is a good idea, but at least for me it break the clock in my panel. F8294594: vokoscreenNG-2020-05-07_17-49-49.mkv

Re: Adding the Abstract Games Suite to the KDE Applications

2020-05-05 Thread Carl Schwan
Hi, the developers are both minors but the big brother who is a regular of #kde-chat and #kde-vdg already disclosed his name but he also felt uncomfortable disclosing the name of his little brother without his authorization and I agree with him. We shouldn't ask minors to disclose their names.

Re: quanta is best html editor

2020-04-30 Thread Carl Schwan
Hi, I looked at the quanta repo and it looks unlikely Quanta will be ported to modern system since it doesn't even looks like the Qt4 port was finished. I tried looking for information on the internet but I didn't find anything that made Quanta so special. If you are doing php websites maybe you

Re: Information regarding upcoming Gitlab Migration

2020-04-29 Thread Carl Schwan
Ok after a small chat with the Bhushan I learned that the plan is to use gitlab-triage instead of project labels. This should be way more powerful :D Sorry for the trouble Carl ‐‐‐ Original Message ‐‐‐ Le mercredi, avril 29, 2020 2:37 PM, Carl Schwan a écrit : > Hi Sysadm

Re: Information regarding upcoming Gitlab Migration

2020-04-29 Thread Carl Schwan
Hi Sysadmins, since we are speaking about workboard for groups, what is the plan for groups that don't work on a single project but on all of the KDE projects (e.g. VDG, documentation, localization, websites)? I experimented a bit with project tags

D28811: Add drawer on mobile and clean code

2020-04-23 Thread Carl Schwan
This revision was automatically updated to reflect the committed changes. Closed by commit R264:e7645ba24570: Add drawer on mobile and clean code (authored by ognarb). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28811?vs=80229=81051#toc REPOSITORY R264 KApiDox CHANGES SINCE LAST

D29084: Make the HTML file template more useful

2020-04-22 Thread Carl Schwan
ognarb added a comment. In D29084#654489 , @gszymaszek wrote: > In D29084#654484 , @ognarb wrote: > > > - Don't include

D29084: Make the HTML file template more useful

2020-04-22 Thread Carl Schwan
ognarb accepted this revision. ognarb added a comment. This revision is now accepted and ready to land. Good idea to improve the default HTML file. Improvement ideas: - Don't include

D29049: add telephant icon

2020-04-21 Thread Carl Schwan
ognarb added a reviewer: muesli. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29049 To: mbruchert, muesli Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: I am not able to submit to svn.kde.org.

2020-04-20 Thread Carl Schwan
Did you see these instructions? https://community.kde.org/Infrastructure/Subversion/2020_Changes ‐‐‐ Original Message ‐‐‐ Le lundi, avril 20, 2020 12:02 PM, a écrit : > Hi, > I can't submit changs to / fetch changes from svn.kde.org. Here is the > verbose message: > > `Committing to

Re: Proposal: "Noteworthy" label for Promo application updates

2020-04-20 Thread Carl Schwan
I think the easiest would be to use the GitLab tags. Hopefully, we will soon use Gitlab for everything and then it won't be a problem. For example, promo will just need to go to these two links to find all the information we need: *

D28811: Add drawer on mobile and clean code

2020-04-15 Thread Carl Schwan
ognarb added a comment. I now generate the CSS from aether-sass. The code can be found https://invent.kde.org/websites/aether-sass/-/blob/master/css/aether-sidebar.scss. And all tree wikis are using it. @ochurlaud should I create a sysadmin request for you to get access to the repo in

D28811: Add drawer on mobile and clean code

2020-04-15 Thread Carl Schwan
ognarb updated this revision to Diff 80229. ognarb added a comment. - Fix typo in path - Add information about there to find the source of the css files REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28811?vs=80228=80229 BRANCH flex-grid REVISION

D28811: Add drawer on mobile and clean code

2020-04-15 Thread Carl Schwan
ognarb updated this revision to Diff 80228. ognarb added a comment. This revision is now accepted and ready to land. - Use version from cdn REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28811?vs=80156=80228 BRANCH flex-grid REVISION DETAIL

D28811: Add drawer on mobile and clean code

2020-04-15 Thread Carl Schwan
ognarb added a comment. POC of sharing this code with the wikis: https://wikisandbox.kde.org/Welcome_to_KDE_TechBase REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D28811 To: ognarb, cblack, ochurlaud Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack,

D28811: Add drawer on mobile and clean code

2020-04-15 Thread Carl Schwan
ognarb planned changes to this revision. ognarb added a comment. In D28811#648700 , @ochurlaud wrote: > I really dislike how you close brackets in css : it's more dense and harder to read. > > You indent sometimes with 1,2 or 3 spaces: it

D28811: Add drawer on mobile and clean code

2020-04-14 Thread Carl Schwan
ognarb retitled this revision from "WIP: Use CSS grid to improve layout" to "Add drawer on mobile and clean code". ognarb edited the summary of this revision. ognarb edited the test plan for this revision. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D28811 To:

D28811: WIP: Use CSS grid to improve layout

2020-04-14 Thread Carl Schwan
ognarb edited the summary of this revision. ognarb added reviewers: cblack, ochurlaud. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D28811 To: ognarb, cblack, ochurlaud Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, fbampaloukas, michaelh,

D28811: WIP: Use CSS grid to improve layout

2020-04-14 Thread Carl Schwan
ognarb updated this revision to Diff 80156. ognarb added a comment. Add NoScript support REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28811?vs=80155=80156 BRANCH flex-grid REVISION DETAIL https://phabricator.kde.org/D28811 AFFECTED FILES

D28811: WIP: Use CSS grid to improve layout

2020-04-14 Thread Carl Schwan
ognarb updated this revision to Diff 80155. ognarb added a comment. - Add drawer on mobile (with JS) - Fix some layout issues REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28811?vs=80057=80155 BRANCH flex-grid REVISION DETAIL

D28811: WIP: Use CSS grid to improve layout

2020-04-13 Thread Carl Schwan
ognarb created this revision. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. ognarb requested review of this revision. REPOSITORY R264 KApiDox BRANCH flex-grid REVISION DETAIL https://phabricator.kde.org/D28811 AFFECTED

Re: Update on Status of Gitlab Migration

2020-04-13 Thread Carl Schwan
Hi, I prefer the name invent because I fear that using GitLab will confuse newcomers then you say that they can contribute to GitLab and that they won't find any KDE code in gitlab.com. Also, I quite like the invent name. Carl ‐‐‐ Original Message ‐‐‐ Le lundi, avril 13, 2020 3:40 PM,

D28712: Redo api.kde.org to look more like Aether

2020-04-10 Thread Carl Schwan
ognarb accepted this revision. ognarb added a comment. LGTM REPOSITORY R264 KApiDox BRANCH cblack/aether (branched from master) REVISION DETAIL https://phabricator.kde.org/D28712 To: cblack, #vdg, ognarb, ochurlaud Cc: ngraham, kde-frameworks-devel, kde-doc-english, LeGast00n,

D28712: Redo api.kde.org to look more like Aether

2020-04-09 Thread Carl Schwan
ognarb added a comment. Not tested yet but I like the style :) Though to be more consistent with the style used in other KDE websites, I would change the background color to #fff and use #f8f9fa for the sidebar. I also saw some alignment issues with the method args: F8227657:

D28712: Redo api.kde.org to look more like Aether

2020-04-09 Thread Carl Schwan
ognarb added a reviewer: ochurlaud. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D28712 To: cblack, #vdg, ognarb, ochurlaud Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D27851: Add rss icons in action

2020-03-04 Thread Carl Schwan
This revision was automatically updated to reflect the committed changes. Closed by commit R266:861f6ab52dc3: Add rss icons in action (authored by ognarb). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27851?vs=76976=76979 REVISION DETAIL

D27851: Add rss icons in action

2020-03-04 Thread Carl Schwan
ognarb edited the test plan for this revision. ognarb added a reviewer: ndavis. ognarb added a project: Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27851 To: ognarb, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, fbampaloukas, GB_2, trickyricky26,

D27851: Add rss icons in action

2020-03-04 Thread Carl Schwan
ognarb created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ognarb requested review of this revision. TEST PLAN Soon REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27851 AFFECTED FILES

D27601: KConfig: Convert to SPDX license statements

2020-02-25 Thread Carl Schwan
ognarb added inline comments. INLINE COMMENTS > cordlandwehr wrote in kcfg.xsd:20 > Actually, I though quite a time about this and at the end did a comparison of > the permissions specifically provided by this statement: use, copy and modify > (yet there is no explicit statement of

Re: Fwd: gsoc ktoblzcheck

2020-02-24 Thread Carl Schwan
Hello, You might want to click on the contact Rhabacker link. If you are asked to login and don't have an account yet, you can create an account in identity.kde.org and then log through phabricator.kde.org. I hope it help. Best regards, Carl \ Original Message On 24 Feb

D27223: add kirigami-gallery icon

2020-02-16 Thread Carl Schwan
ognarb added a comment. In D27223#612284 , @mbruchert wrote: > I have no Idea why the diff deletes the ktrip icon. > unfortunately I cant fix that because I have no Idea how to do that with git. You can try to execute this git

D27434: Improve readme

2020-02-16 Thread Carl Schwan
ognarb added a comment. Maybe you could also mention the license and the maintainers in the README? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D27434 To: nicolasfella, #frameworks, broulik Cc: ognarb, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27214: add puremaps icon

2020-02-07 Thread Carl Schwan
ognarb added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27214 To: mbruchert, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

Re: New utility for easier breeze monochrome icon creation

2020-02-03 Thread Carl Schwan
Hi, maybe you want to join the efforts with Ikona since you both have the same goal to improve the icon creation workflow. https://invent.kde.org/kde/ikona Cheers, Carl ‐‐‐ Original Message ‐‐‐ Le lundi, février 3, 2020 2:52 PM, David Hurka a écrit : > Hi everyone, > > as indicated

Re: KDE Developer Documentation

2019-12-27 Thread Carl Schwan
Hi Jucato, Le vendredi, décembre 27, 2019 1:22 PM, Juan Carlos Torres a écrit : > Hi Olivier, > > Thank you for the compliments and the pointers! Having the example code in > the git repo is definitely a great idea to make sure they will always > compile. In line with that, we also need to

Re: KDE Developer Documentation

2019-12-24 Thread Carl Schwan
Salut Olivier, Having the tutorial next to the code and that they break the compilation if they are out of date is an excellent idea. There is already something similar in Rust[1] were the example in the api documentation are compiled and executed as test. This make it quite easy to write

Re: KDE Developer Documentation

2019-12-24 Thread Carl Schwan
Hi, thanks for the report. An issue I see currently is that we have three entries for our KDE frameworks and developer utilities: 1. https://kde.org/develop 2. https://kde.org/products/frameworks/ 3. https://techbase.kde.org/Welcome_to_KDE_TechBase Maybe we could merge some of them. Could it

D25495: Fix Sonnet autodetect failing on Indian langs

2019-12-18 Thread Carl Schwan
ognarb added a reviewer: cullmann. ognarb added a comment. Adding a potential reviewer :) REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25495 To: waqar, mludwig, cullmann Cc: ognarb, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26010: Update the kiten log

2019-12-14 Thread Carl Schwan
ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26010 To: ognarb Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26010: Update the kiten log

2019-12-14 Thread Carl Schwan
ognarb added a reviewer: Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26010 To: ognarb, #breeze Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26010: Update the kiten log

2019-12-14 Thread Carl Schwan
ognarb created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ognarb requested review of this revision. REVISION SUMMARY Mix the labplot icon and the hiraganas for kiten Another possibility would be to use the kile icon with the same

D24443: Add a plugin system

2019-12-07 Thread Carl Schwan
ognarb added inline comments. INLINE COMMENTS > dvratil wrote in calendarentry.h:63 > Use `std::unique_ptr const d` for automatic memory > management. This wasn't done, I still see `CalendarEntryPrivate *d;` > nicolasfella wrote in calendarplugin.h:39 > My idea was to be able to add a d-ptr

Re: (No Subject)

2019-12-04 Thread Carl Schwan
I'm now in contact with Anuj  Carl \ Original Message On 4 Dec 2019, 08:45, Anuj Bansal < bansalan...@gmail.com> wrote: > > > > Hello Everyone! > > I am an aspiring web developer and I would like to participate in Season of > KDE. Can anyone guide me to any Web Development

T11542: Remove KHTML

2019-12-03 Thread Carl Schwan
ognarb added a revision: D25714: Port away from deprecated KHtml. TASK DETAIL https://phabricator.kde.org/T11542 To: ognarb Cc: cordlandwehr, ngraham, #konqueror, #plasma, #okular, #kde_applications, #frameworks, knauss, davidre, GB_2, ahmadsamir, kpiwowarski, asturmlechner, cfeck, cullmann,

Re: Sysadmin Load Reduction: Code Related Services

2019-11-16 Thread Carl Schwan
Hi all, Can the gitlab api be of useful in the future? e.g https://invent.kde.org/api/v4/groups/7 Cheers, Carl ‐‐‐ Original Message ‐‐‐ On Saturday, November 16, 2019 9:51 AM, Ben Cooksley wrote: > On Sat, Nov 16, 2019 at 10:39 PM Albert Astals Cid aa...@kde.org wrote: > > > El

D25149: Add a new Template for KCM's.

2019-11-05 Thread Carl Schwan
ognarb added a comment. Another related todo would be to update/rewrite https://techbase.kde.org/Development/Tutorials/KCM_HowTo after this template is merged and include information about it ;) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D25123: [WIP] New yakuake logo/icon

2019-11-03 Thread Carl Schwan
ognarb added a reviewer: hein. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25123 To: mglb, #vdg, #yakuake, hein Cc: ognarb, ngraham, hein, kde-frameworks-devel, vmarinescu, ryanmccoskrie, LeGast00n, GB_2, michaelh, bruns

Kdenlive mini sprint

2019-11-01 Thread Carl Schwan
Relaying Kdenlive developers :) Hi all On November 1st we'll be having a mini sprint to improve the effects and compositing UI/UX for the 19.12 release. Join us from 9AM till 2PM at kdenlive (IRC or Telegram) to participate in this effort. You can find some issues we'll be focusing on (open

D24672: GIT_SILENT Run uncrustify-kf5 on the whole tree

2019-10-15 Thread Carl Schwan
ognarb added a comment. Instead of using uncrustify-kf5, shouldn't we use the clang-format file from T11214 ? REPOSITORY R374 KolourPaint REVISION DETAIL https://phabricator.kde.org/D24672 To: ahmadsamir, kde-frameworks-devel Cc: ognarb,

Re: Can we agree to change gitlab default behaviour from merge to fast-forward merge for all repos?

2019-10-13 Thread Carl Schwan
+ 1 Commit with the name "Merge branch 'branch-name' into 'master' are not helpful. Cheers, Carl On Sunday, October 13, 2019 10:57:20 PM CEST Albert Astals Cid wrote: > I find the merge behavior to be not what we've been doing in phabricator so > given the idea is to maintain our workflows i'd

D24568: Provide clang-format target with a common KDE style file

2019-10-11 Thread Carl Schwan
ognarb added a comment. There is probably a way to run clang-format only on a patch. See http://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting But should we not prefer running clang format one time, instead of having only some part of the code auto-formatted?

D24568: Provide clang-format target with a common KDE style file

2019-10-11 Thread Carl Schwan
ognarb added inline comments. INLINE COMMENTS > KDEClangFormat.cmake:11 > +# > +# :: > +# need doc REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24568 To: cullmann Cc: ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh,

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

2019-10-08 Thread Carl Schwan
ognarb added inline comments. INLINE COMMENTS > kcategorydrawer.cpp:88 > +textRect.setTop(textRect.top() + 4); > +textRect.setLeft(textRect.left() + 8); > textRect.setHeight(fontMetrics.height()); Instead of using magic number, I would create a constant named padding.

D24390: Add more file and directories to exclude filters

2019-10-03 Thread Carl Schwan
ognarb added inline comments. INLINE COMMENTS > ngraham wrote in fileexcludefilters.cpp:137 > This one makes me a little nervous since it's a not-very-uncommon English > word, not something implicitly technical that we can be safe excluding. > > Is there any other way we could exclude the

D24390: Add more file and directories to exclude filters

2019-10-03 Thread Carl Schwan
ognarb added a reviewer: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24390 To: ognarb, #baloo Cc: kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D24390: Add more file and directories to exclude filters

2019-10-03 Thread Carl Schwan
ognarb created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. ognarb requested review of this revision. TEST PLAN None for the moment REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D24390

D21169: Add app icon for the Kirogi Drone control app

2019-09-21 Thread Carl Schwan
ognarb added a comment. kde.org/applications use the icons from breeze-icons. So I think it's worth adding to breeze-icons or improving how the icon are fetched in kde.org/applications. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21169 To: trickyricky26,

D19620: Use a searchbar similar to the one in okular

2019-09-21 Thread Carl Schwan
ognarb abandoned this revision. ognarb added a comment. I completly forgot about this patch and since KHTML is dead and is getting removed from most of our apps, it doesn't makes sence to land this patch. REPOSITORY R313 KHtml REVISION DETAIL https://phabricator.kde.org/D19620 To:

D24015: Added scripts to create a webfont out of all breeze action icons

2019-09-17 Thread Carl Schwan
ognarb accepted this revision. ognarb added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D24015 To: fabianr, ndavis, ognarb Cc: ognarb, kde-frameworks-devel, LeGast00n, GB_2,

D24015: Added scripts to create a webfont out of all breeze action icons

2019-09-17 Thread Carl Schwan
ognarb added inline comments. INLINE COMMENTS > Gruntfile.js:13 > +types: 'eot,woff2,ttf,svg', > +optimize: false > +} why not true? REPOSITORY R266 Breeze Icons REVISION DETAIL

D22797: Fix typo - GridView -> ScrollView

2019-07-28 Thread Carl Schwan
This revision was automatically updated to reflect the committed changes. Closed by commit R296:2571616ec547: Fix typo - GridView - ScrollView (authored by ognarb). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22797?vs=62705=62708 REVISION DETAIL

D22797: Fix typo - GridView -> ScrollView

2019-07-28 Thread Carl Schwan
ognarb created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ognarb requested review of this revision. REVISION SUMMARY Probably the result of a bad copy pasta ;) TEST PLAN Not tested REPOSITORY R296 KDeclarative BRANCH master

D22797: Fix typo - GridView -> ScrollView

2019-07-28 Thread Carl Schwan
ognarb added a reviewer: Plasma. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22797 To: ognarb, #plasma Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

Re: RFC: Running clang-format across all Plasma (and more?) repos

2019-07-11 Thread Carl Schwan
Hi, I like the idea a lot and I would love to do the same for the websites. Probably using tools like [PHP Coding Standards Fixer](https://cs.symfony.com/). Cheers, Carl ‐‐‐ Original Message ‐‐‐ On Thursday 11 July 2019 16:18, David Edmundson wrote: > One topic discussed at the

D21656: Create a breeze icon for kfourinline

2019-06-13 Thread Carl Schwan
ognarb updated this revision to Diff 59720. ognarb added a comment. Use more round corner. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21656?vs=59707=59720 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21656 AFFECTED FILES

D21656: Create a breeze icon for kfourinline

2019-06-13 Thread Carl Schwan
ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21656 To: ognarb, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

2019-06-13 Thread Carl Schwan
ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21656 To: ognarb, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

2019-06-13 Thread Carl Schwan
ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21656 To: ognarb, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

2019-06-13 Thread Carl Schwan
ognarb updated this revision to Diff 59707. ognarb added a comment. Change color of some points REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21656?vs=59706=59707 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21656 AFFECTED FILES

D21656: Create a breeze icon for kfourinline

2019-06-13 Thread Carl Schwan
ognarb updated this revision to Diff 59706. ognarb added a comment. Still works in progress (need to add the gradiend) but some improvement REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21656?vs=59372=59706 BRANCH master REVISION DETAIL

D21656: Create a breeze icon for kfourinline

2019-06-07 Thread Carl Schwan
ognarb updated this revision to Diff 59372. ognarb added a comment. Crop shadow REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21656?vs=59371=59372 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21656 AFFECTED FILES

D21656: Create a breeze icon for kfourinline

2019-06-07 Thread Carl Schwan
ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21656 To: ognarb, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21656: Create a breeze icon for kfourinline

2019-06-07 Thread Carl Schwan
ognarb edited the test plan for this revision. ognarb added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21656 To: ognarb, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21656: Create a breeze icon for kfourinline

2019-06-07 Thread Carl Schwan
ognarb created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ognarb requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D21656 AFFECTED FILES

D21574: Update KBruch icon

2019-06-05 Thread Carl Schwan
This revision was automatically updated to reflect the committed changes. Closed by commit R266:86d0782cf4e2: Update KBruch icon (authored by ognarb). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21574?vs=59187=59189 REVISION DETAIL

D21574: Update KBruch icon

2019-06-05 Thread Carl Schwan
ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21574 To: ognarb, #vdg, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21574: Update KBruch icon

2019-06-05 Thread Carl Schwan
ognarb updated this revision to Diff 59187. ognarb added a comment. - Optimize icon with scour-icon - Copy icon to breeze-dark - Remove png REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21574?vs=59131=59187 BRANCH kbruch REVISION DETAIL

D21574: Update KBruch icon

2019-06-04 Thread Carl Schwan
ognarb added a comment. In D21574#474171 , @ndavis wrote: > Wait, is this a PNG? This needs to be just an SVG. We don't ship PNGs in breeze-icons. Sorry it arc who also uploaded the png that I created for the review, I will fix it.

D21574: Update KBruch icon

2019-06-04 Thread Carl Schwan
ognarb updated this revision to Diff 59131. ognarb added a comment. Add shadow REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21574?vs=59123=59131 BRANCH kbruch REVISION DETAIL https://phabricator.kde.org/D21574 AFFECTED FILES

D21574: Update KBruch icon

2019-06-04 Thread Carl Schwan
ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21574 To: ognarb, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21574: Update KBruch icon

2019-06-04 Thread Carl Schwan
ognarb edited the test plan for this revision. ognarb added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21574 To: ognarb, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21574: Update KBruch icon

2019-06-04 Thread Carl Schwan
ognarb created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ognarb requested review of this revision. REVISION SUMMARY Inspired from application-edu and cantor icon TEST PLAN Screenshot comming REPOSITORY R266 Breeze Icons BRANCH

D19771: Use placeholder instead of label

2019-06-04 Thread Carl Schwan
ognarb abandoned this revision. ognarb added a comment. I don't have time and the motivation for this revision anymore. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor, #vdg Cc: dhaumann, cullmann, cfeck, loh.tar, ngraham,

D19771: Use placeholder instead of label

2019-05-23 Thread Carl Schwan
ognarb added a comment. Hi, I try to find time to look into it this weekend ;). REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor, #vdg Cc: dhaumann, cullmann, cfeck, loh.tar, ngraham, kwrite-devel, kde-frameworks-devel, domson,

D21218: Use Anjuta's icon for Knights, since it works and Anjuta is abandoned at this point

2019-05-14 Thread Carl Schwan
ognarb added a comment. Why not mirror the Anjuta icon and use the same background color as the original Knights icon? So that it looks closer to the original. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21218 To: ngraham, #vdg Cc: ognarb,

D19895: Use https for links in the UI and documentation

2019-03-19 Thread Carl Schwan
ognarb added a comment. I made sure that all the links are still working. So +1 INLINE COMMENTS > kproxydlg.ui:45 > Automatic detection is performed using the bWeb Proxy Auto-Discovery > Protocol (WPAD)/b.p > -bNOTE:/b This option might not work properly or not work at > all in some

D19771: Use placeholder instead of label

2019-03-16 Thread Carl Schwan
ognarb added a comment. > I'm not aware of why we tend to use three dots instead of the real ellipsis character. Possibly because that character can be challenging to type. Best to follow the existing convention, I think. The advantage of using the unicode ellipsis character, is that

D19771: Use placeholder instead of label

2019-03-14 Thread Carl Schwan
ognarb added a task: T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor, #vdg Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh,

<    1   2   3   >