Re: Ask about new KDE functionnalities.

[Grzegorz Szymaszek]

FWIW:
http://www.alysbrooks.com/gpt-4-is-a-risky-dependency-for-foss-projects.html
(found at
https://ervin.ipsquad.net/blog/2023/04/21/web-review-week-2023-16/).


signature.asc
Description: PGP signature

Re: Can we rename gitklient?

[Grzegorz Szymaszek]

On Thu, Mar 02, 2023 at 10:58:18PM +0300, Gleb Popov wrote:
> I really like "Kommit". It starts with "K" and is just to the point.

FWIW - I do not intend to discourage you from renaming the program
to "Kommit" - there is a Git (and Mercurial) commit message editor
for GNOME called "Commit" (and seems to be actively developed):
https://apps.gnome.org/app/re.sonny.Commit/


signature.asc
Description: PGP signature

Re: build_clazy_clang_tidy job can't find python-yaml

[Grzegorz Szymaszek]

Docker runs the test using a Debian testing‐based image, with both the
testing and the unstable repositories enabled. apt-get fails to install
python-yaml, because it has been removed from both of these
repositories. The Python 3 equivalent is python3-yaml.


signature.asc
Description: PGP signature

D29084: Make the HTML file template more useful

[Grzegorz Szymaszek]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:5adaa7cba102: Make the HTML file template more useful 
(authored by gszymaszek).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29084?vs=80859=81360

REVISION DETAIL
  https://phabricator.kde.org/D29084

AFFECTED FILES
  src/new_file_templates/HTMLFile.html

To: gszymaszek, #frameworks, dfaure, ognarb
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29084: Make the HTML file template more useful

[Grzegorz Szymaszek]

gszymaszek requested review of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29084

To: gszymaszek, #frameworks, dfaure, ognarb
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29084: Make the HTML file template more useful

[Grzegorz Szymaszek]

gszymaszek updated this revision to Diff 80859.
gszymaszek added a comment.


  - Add common HTML elements to the HTML file template

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29084?vs=80853=80859

BRANCH
  html-file-template (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29084

AFFECTED FILES
  src/new_file_templates/HTMLFile.html

To: gszymaszek, #frameworks, dfaure, ognarb
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29084: Make the HTML file template more useful

[Grzegorz Szymaszek]

gszymaszek updated this revision to Diff 80853.
gszymaszek added a comment.


  - Remove stylesheets from the HTML file template

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29084?vs=80839=80853

BRANCH
  html-file-template (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29084

AFFECTED FILES
  src/new_file_templates/HTMLFile.html

To: gszymaszek, #frameworks, dfaure, ognarb
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29084: Make the HTML file template more useful

[Grzegorz Szymaszek]

gszymaszek added a comment.


  In D29084#654484 , @ognarb wrote:
  
  > - Don't include 

D29084: Make the HTML file template more useful

[Grzegorz Szymaszek]

gszymaszek created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
gszymaszek requested review of this revision.

REVISION SUMMARY
  This commit removes the empty meta tag and adds the following:
  
  - a DOCTYPE declaration,
  - an html[lang] attribute,
  - a document charset declaration,
  - a newline at the end of the document.
  
  Adding the DOCTYPE and charset make the template HTML5‐complant.
  
  BUG: 419935

REPOSITORY
  R241 KIO

BRANCH
  html-file-template (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29084

AFFECTED FILES
  src/new_file_templates/HTMLFile.html

To: gszymaszek
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: Polish translation of "Cancel"

[Grzegorz Szymaszek]

Hi,

On Fri, Apr 17, 2020 at 08:31:12PM +0200, Łukasz Wojniłowicz wrote:
> AmigaOS and macOS are both niche OS. The translation was done by
> community. It's just like KDE. It can be considered niche OS and the
> translation is done by community.

But in this case, the community has clearly expressed that’s not the
translation they want.

> The thing is, that some people see this translation as "absurd",
> "invalid", "ancient" and I presume it is so because it's not what
> they've been accustomed to by the mainstream OS, which is Windows.

Again, I feel you are still not convinced that _most_ people see this
translation as “absurd” etc.

New and existing users will complain, they will waste hours reading and
writing new #404286 comments, blog posts, emails, patches, until you
revert the translation. How long are you going to wait?


Regards

-- 
Grzegorz Szymaszek


signature.asc
Description: PGP signature

Re: Polish translation of "Cancel"

[Grzegorz Szymaszek]

On Wed, Apr 15, 2020 at 09:30:34AM -0600, Nate Graham  wrote:
> Shouldn't the mailing list be using standard KDE infrastructure?

Shouldn’t the Polish translation use common vocabulary instead of
reviving words that no one uses in real life? I’m afraid both answers
are “it should”.


-- 
Grzegorz


signature.asc
Description: PGP signature

Re: Polish translation of "Cancel"

[Grzegorz Szymaszek]

Hi,

On Wed, Apr 15, 2020 at 08:45:17AM -0600, Nate Graham  wrote:
> [+ kde-devel mailing list since I don't know if I got the right localization
> mailing list and couldn't find a polish-specific one]

FWIW, there are three mailing lists hosted at SourceForge:
https://sourceforge.net/p/kdei18n-pl/mailman/


Regards

-- 
Grzegorz


signature.asc
Description: PGP signature

D24306: Highlight GeoJSON files as if they were plain JSON

[Grzegorz Szymaszek]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:25b08fe3f4c6: Highlight GeoJSON files as if they were 
plain JSON (authored by gszymaszek).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24306?vs=67059=67061

REVISION DETAIL
  https://phabricator.kde.org/D24306

AFFECTED FILES
  data/syntax/json.xml

To: gszymaszek, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D24306: Highlight GeoJSON files as if they were plain JSON

[Grzegorz Szymaszek]

gszymaszek created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
gszymaszek requested review of this revision.

REVISION SUMMARY
  Currently, GeoJSON files syntax isn’t highlighted in any way.
  GeoJSON is a subset of JSON and, as such, it can be higlighted using
  the same rules as JSON.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  basic-geojson-support (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24306

AFFECTED FILES
  data/syntax/json.xml

To: gszymaszek
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D18148: Use HTTPS, if available, in links visible to users

[Grzegorz Szymaszek]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:b64681408d84: Use HTTPS, if available, in links visible to 
users (authored by gszymaszek).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18148?vs=49138=49140

REVISION DETAIL
  https://phabricator.kde.org/D18148

AFFECTED FILES
  src/document/katedocument.cpp
  src/utils/kateglobal.cpp

To: gszymaszek, #ktexteditor, dhaumann
Cc: lueck, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18148: Use HTTPS, if available, in links visible to users

[Grzegorz Szymaszek]

gszymaszek marked 2 inline comments as done.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18148

To: gszymaszek, #ktexteditor
Cc: lueck, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18148: Use HTTPS, if available, in links visible to users

[Grzegorz Szymaszek]

gszymaszek updated this revision to Diff 49138.
gszymaszek added a comment.


  Fixed two links to docs.kde.org

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18148?vs=49135=49138

BRANCH
  https-in-end-user-links (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18148

AFFECTED FILES
  src/document/katedocument.cpp
  src/utils/kateglobal.cpp

To: gszymaszek, #ktexteditor
Cc: lueck, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18148: Use HTTPS, if available, in links visible to users

[Grzegorz Szymaszek]

gszymaszek retitled this revision from "Use HTTPS, if available, in links 
visible by users" to "Use HTTPS, if available, in links visible to users".
gszymaszek added a reviewer: KTextEditor.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18148

To: gszymaszek, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18148: Use HTTPS, if available, in links visible by users

[Grzegorz Szymaszek]

gszymaszek created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
gszymaszek requested review of this revision.

REPOSITORY
  R39 KTextEditor

BRANCH
  https-in-end-user-links (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18148

AFFECTED FILES
  src/document/katedocument.cpp
  src/utils/kateglobal.cpp

To: gszymaszek
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D7864: Basic support for PHP and Python fenced code blocks in Markdown

[Grzegorz Szymaszek]

gszymaszek updated this revision to Diff 19631.
gszymaszek added a comment.


  - Removed JavaScript code blocks in Markdown support since it didn’t work
  - Added test cases for new code blocks in Markdown

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7864?vs=19622=19631

BRANCH
  markdown-code-blocks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D7864

AFFECTED FILES
  autotests/folding/example.rmd.fold
  autotests/folding/test.markdown.fold
  autotests/html/test.markdown.html
  autotests/input/test.markdown
  autotests/reference/test.markdown.ref
  data/syntax/markdown.xml

To: gszymaszek, #ktexteditor
Cc: dhaumann, cfeck, kwrite-devel, #frameworks

D7864: Basic support for PHP and Python fenced code blocks in Markdown

[Grzegorz Szymaszek]

gszymaszek added a subscriber: cfeck.
gszymaszek added a comment.


  Not ready to land, but uploaded per @cfeck’s suggestion (bug 356974 
).

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D7864

To: gszymaszek, #ktexteditor
Cc: cfeck, kwrite-devel, #frameworks

D7864: Basic support for PHP and Python fenced code blocks in Markdown

[Grzegorz Szymaszek]

gszymaszek created this revision.
gszymaszek added a reviewer: KTextEditor.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  This patch enables syntax highlighting of PHP and Python code blocks in 
Markdown code.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  markdown-code-blocks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D7864

AFFECTED FILES
  data/syntax/markdown.xml

To: gszymaszek, #ktexteditor
Cc: kwrite-devel, #frameworks

D5799: Rebase Less syntax highlighting on SCSS one

[Grzegorz Szymaszek]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:ca846fbda318: Rebased Less syntax highlighting on SCSS 
one (authored by gszymaszek).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5799?vs=18296=18391

REVISION DETAIL
  https://phabricator.kde.org/D5799

AFFECTED FILES
  autotests/input/highlight.less
  data/syntax/less.xml

To: gszymaszek, #framework_syntax_hightlighting, jtamate, dhaumann
Cc: jtamate, dhaumann, #frameworks, cullmann, vkrause

D5799: Rebase Less syntax highlighting on SCSS one

[Grzegorz Szymaszek]

gszymaszek updated this revision to Diff 18296.
gszymaszek added a comment.


  Removed leading and trailing spaces inside XML tags (in `less.xml`), to make 
it possible to build the framework.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5799?vs=15814=18296

REVISION DETAIL
  https://phabricator.kde.org/D5799

AFFECTED FILES
  autotests/input/highlight.less
  data/syntax/less.xml

To: gszymaszek, #framework_syntax_hightlighting, jtamate
Cc: jtamate, dhaumann, #frameworks, cullmann, vkrause

Re: Need HTML/CSS help for Konqueror's about page

[Grzegorz Szymaszek]

Hello,

It seems Chromium interprets the following (lines 23–24):




like this:


  


In HTML, a div must have both opening and closing tags, so you should
change the original code to:




to make it render correctly. You will face the same problem in lines
101 and 104.

Other issues:

1. kde_infopage.css:6: replace `height="100%"; width="100%"` with
`height: 100%; width: 100%`.
2. kde_infopage.css:13: I’m not sure of browser’s behaviour when it
encounters an HTML comment in a CSS file.

Good luck!

W dniu 10.07.2017, pon o godzinie 11∶11 +0200, użytkownik David Faure
napisał:
> Hello there,
> 
> I'm porting the Konqueror about page from KHTML to WebEngine,
> and it turns out that the same CSS/HTML doesn't render the same in
> both 
> engines.
> 
> In WebEngine (and Firefox, for that matter) it's all squished to the
> left of 
> the page.
> 
> Can someone with CSS/HTML knowledge send me a modified version of the
> attached 
> files so that they render correctly in e.g. Chromium ?
> (then it should be fine for konqueror+webengine as well)
> 
> You'll have to adjust the paths to the CSS files in the HTML file of
> course
> (and the paths to the icons, but that's not really the issue).
> 
> Thanks - please CC me, I don't read kde-devel@ or kde-www@.
> 

D5799: Rebase Less syntax highlighting on SCSS one

[Grzegorz Szymaszek]

gszymaszek updated this revision to Diff 15814.
gszymaszek added a comment.


  Added a test file (`autotests/input/highlight.less`).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5799?vs=14376=15814

REVISION DETAIL
  https://phabricator.kde.org/D5799

AFFECTED FILES
  autotests/input/highlight.less
  data/syntax/less.xml

To: gszymaszek, #framework_syntax_hightlighting
Cc: dhaumann, #frameworks, cullmann, vkrause

[Differential] [Commented On] D4537: EditorConfig support

[Grzegorz Szymaszek]

gszymaszek added a comment.


  In https://phabricator.kde.org/D4537#87411, @cullmann wrote:
  
  > Do you have commit rights? If not, paste your mail address and full name 
and I can push your change with you as author.
  
  
  No, I don’t have. Grzegorz Szymaszek, `gszymas...@short.pl`.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4537

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gszymaszek, cullmann, #ktexteditor
Cc: cullmann, dhaumann, kwrite-devel, #frameworks

[Differential] [Updated, 256 lines] D4537: EditorConfig support

[Grzegorz Szymaszek]

gszymaszek updated this revision to Diff 11486.
gszymaszek marked 5 inline comments as done.
gszymaszek added a comment.


  Updated to work with new `cmake/FindEditorConfig.cmake`.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4537?vs=11366=11486

REVISION DETAIL
  https://phabricator.kde.org/D4537

AFFECTED FILES
  src/CMakeLists.txt
  src/document/editorconfig.cpp
  src/document/editorconfig.h
  src/document/katedocument.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gszymaszek, cullmann, #ktexteditor
Cc: cullmann, dhaumann, kwrite-devel, #frameworks

[Differential] [Updated, 259 lines] D4537: EditorConfig support

[Grzegorz Szymaszek]

gszymaszek updated this revision to Diff 11366.
gszymaszek added a comment.


  key and value are const.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4537?vs=11365=11366

REVISION DETAIL
  https://phabricator.kde.org/D4537

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/document/editorconfig.cpp
  src/document/editorconfig.h
  src/document/katedocument.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gszymaszek, #ktexteditor
Cc: cullmann, dhaumann, kwrite-devel, #frameworks

[Differential] [Updated, 259 lines] D4537: EditorConfig support

[Grzegorz Szymaszek]

gszymaszek updated this revision to Diff 11365.
gszymaszek marked 2 inline comments as done.
gszymaszek added a comment.


  Pulled check-variable-functions out of EditorConfig class, moved some 
variable definitions into main loop of parser.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4537?vs=11349=11365

REVISION DETAIL
  https://phabricator.kde.org/D4537

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/document/editorconfig.cpp
  src/document/editorconfig.h
  src/document/katedocument.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gszymaszek, #ktexteditor
Cc: cullmann, dhaumann, kwrite-devel, #frameworks

[Differential] [Updated, 254 lines] D4537: EditorConfig support

[Grzegorz Szymaszek]

gszymaszek updated this revision to Diff 11349.
gszymaszek added a comment.


  Simplified the constructor and reduced parser indentation.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4537?vs=11279=11349

REVISION DETAIL
  https://phabricator.kde.org/D4537

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/document/editorconfig.cpp
  src/document/editorconfig.h
  src/document/katedocument.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gszymaszek, #ktexteditor
Cc: cullmann, dhaumann, kwrite-devel, #frameworks

[Differential] [Commented On] D4537: EditorConfig support

[Grzegorz Szymaszek]

gszymaszek added a comment.


  Yes, it was good when actual parsing was delegated to a separate function, 
but we’ve decided to merge all parsing-related functions.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4537

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gszymaszek, #ktexteditor
Cc: cullmann, dhaumann, kwrite-devel, #frameworks

[Differential] [Commented On] D4537: EditorConfig support

[Grzegorz Szymaszek]

gszymaszek added a comment.


  In https://phabricator.kde.org/D4537#86356, @cullmann wrote:
  
  > On the other side, I see no real copyrightable material beside you are 
using the editor config API.
  
  
  As I’ve written, I used Builder’s source to //learn// that (1) I have to call 
`editorconfig_handle_init` and `editorconfig_parse` at the beginning, (2) I 
have to call `editorconfig_handle_get_name_value` to read EditorConfig’s 
results (and `editorconfig_handle_get_name_value_count` to make reading easier) 
and (3) I have to call `editorconfig_handle_destroy` to “close connection”. 
Implementation details come from API docs and my imagination.
  
  Maybe it isn’t a good idea to include that comment about Builder in this 
patch — the code isn’t a “port” (or copy) of Builder’s solution to KTextEditor, 
while that’s what such comment may wrongly suggest.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4537

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gszymaszek, #ktexteditor
Cc: cullmann, dhaumann, kwrite-devel, #frameworks

[Differential] [Updated, 88 lines] D4589: EditorConfig module

[Grzegorz Szymaszek]

gszymaszek updated this revision to Diff 11329.
gszymaszek added a comment.


  Added description.

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4589?vs=11308=11329

REVISION DETAIL
  https://phabricator.kde.org/D4589

AFFECTED FILES
  find-modules/Findeditorconfig.cmake

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gszymaszek, #build_system, #frameworks, alexmerry
Cc: dhaumann

[Differential] [Updated, 67 lines] D4589: EditorConfig module

[Grzegorz Szymaszek]

gszymaszek updated this revision to Diff 11308.
gszymaszek added a comment.


  Added version checking support.

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4589?vs=11263=11308

REVISION DETAIL
  https://phabricator.kde.org/D4589

AFFECTED FILES
  find-modules/Findeditorconfig.cmake

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gszymaszek, #build_system, #frameworks, alexmerry
Cc: dhaumann

[Differential] [Commented On] D4589: EditorConfig module

[Grzegorz Szymaszek]

gszymaszek added a comment.


  editorconfig-core-lua  
doesn’t check C library version (CMakeLists.txt:49 
).
 Actually I’m not sure if setting oldest acceptable version in KTextEditor is 
really needed.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D4589

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gszymaszek, #build_system, #frameworks, alexmerry
Cc: dhaumann

[Differential] [Commented On] D4589: EditorConfig module

[Grzegorz Szymaszek]

gszymaszek added a comment.


  It seems there isn’t any version string in library headers (editorconfig.h, 
editorconfig_handle.h), is there any other cross-distribution way to obtain 
library version?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D4589

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gszymaszek, #build_system, #frameworks, alexmerry
Cc: dhaumann

[Differential] [Updated, 253 lines] D4537: EditorConfig support

[Grzegorz Szymaszek]

gszymaszek updated this revision to Diff 11279.
gszymaszek added a comment.


  Fixed src/CMakeLists.txt to make EditorConfig support truly optional, removed 
interpret and interpretLine functions (so parsing is back in parse), simplified 
EditorConfig class constructor, fixed memory leak in DocumentPrivate.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4537?vs=11262=11279

REVISION DETAIL
  https://phabricator.kde.org/D4537

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/document/editorconfig.cpp
  src/document/editorconfig.h
  src/document/katedocument.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gszymaszek, #ktexteditor
Cc: dhaumann, kwrite-devel, #frameworks

[Differential] [Updated] D4537: EditorConfig support

[Grzegorz Szymaszek]

gszymaszek marked 6 inline comments as done.
gszymaszek added inline comments.

INLINE COMMENTS

> dhaumann wrote in editorconfig.cpp:23
> Better is to write:
> 
>   EditorConfig::EditorConfig(KTextEditor::DocumentPrivate *document)
>   : m_document(document)
>   , m_handle(0)
>   {
>   // ...
>   }

Is it OK to initialize `m_handle` in the constructor? If so, is `m_handle(0)` 
necessary?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4537

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gszymaszek, #ktexteditor
Cc: dhaumann, kwrite-devel, #frameworks

[Differential] [Commented On] D4537: EditorConfig support

[Grzegorz Szymaszek]

gszymaszek added a comment.


  In https://phabricator.kde.org/D4537#85846, @dhaumann wrote:
  
  > Btw, did you copy some code from another project? If so, we need to be 
careful, since KTextEditor is LGPLv+2.
  
  
  I’ve used mentioned gnome-builder’s file 

 as a guide on how to deal with editorconfig-core-c (which functions should be 
used as a minimum to read .editorconfig file), because I didn’t find such guide 
in their API docs .

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4537

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gszymaszek, #ktexteditor
Cc: dhaumann, kwrite-devel, #frameworks

[Differential] [Request, 41 lines] D4589: EditorConfig module

[Grzegorz Szymaszek]

gszymaszek created this revision.
gszymaszek added reviewers: Build System, Frameworks.
gszymaszek set the repository for this revision to R240 Extra CMake Modules.
gszymaszek added a project: Frameworks.
Restricted Application added a project: Build System.

REVISION SUMMARY
  EditorConfig support is going to be added to KTextEditor (D4537 
), but it needs to make it possible to call 
`find_package(editorconfig)`, similarly as it’s done with LibGit2.
  This diff is a copy of 
https://github.com/editorconfig/editorconfig-core-lua/blob/master/cmake/Modules/FindEditorConfig.cmake.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D4589

AFFECTED FILES
  find-modules/Findeditorconfig.cmake

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gszymaszek, #build_system, #frameworks

[Differential] [Updated, 265 lines] D4537: EditorConfig support

[Grzegorz Szymaszek]

gszymaszek updated this revision to Diff 11262.
gszymaszek added a comment.


  Moved EditorConfig-related logic into a separate class and made it optional 
(no longer a KTextEditor dependency).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4537?vs=11133=11262

REVISION DETAIL
  https://phabricator.kde.org/D4537

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/document/editorconfig.cpp
  src/document/editorconfig.h
  src/document/katedocument.cpp
  src/document/katedocument.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gszymaszek, #ktexteditor
Cc: dhaumann, kwrite-devel, #frameworks

[Differential] [Commented On] D4537: EditorConfig support

[Grzegorz Szymaszek]

gszymaszek added a comment.


  In the new `EditorConfig` class I need to use `DocumentPrivate`’s 
`checkBoolValue` and `checkIntValue` methods, but they’re declared private. I 
think it should be OK to make them public as they’re static anyway, but I’d 
like to hear what’s your opinion. Setting `EditorConfig` as `DocumentPrivate`’s 
friend didn’t help.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4537

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gszymaszek, #ktexteditor
Cc: dhaumann, kwrite-devel, #frameworks

[Differential] [Commented On] D4537: EditorConfig support

[Grzegorz Szymaszek]

gszymaszek added a comment.


  Thanks for your comments. I’ve managed to make editorconfig optional using 
the mentioned `FindEditorConfig.cmake` module (I had to change its name to 
`Findeditorconfig.cmake`). Should I create a new diff in ECM repository to add 
this file?
  Now I’m going to create a separate class for EditorConfig parsing.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4537

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gszymaszek, #ktexteditor
Cc: dhaumann, kwrite-devel, #frameworks

[Differential] [Request, 109 lines] D4537: EditorConfig support

[Grzegorz Szymaszek]

gszymaszek created this revision.
gszymaszek added a reviewer: KTextEditor.
gszymaszek set the repository for this revision to R39 KTextEditor.
Restricted Application added subscribers: Frameworks, kwrite-devel.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  This diff enables support for reading configurations from `.editorconfig` 
files, as an alternative to already supported `.kateconfig`. EditorConfig 
 is supported in many other editors and IDEs. In case 
of KTextEditor it’s done using editorconfig-core-c 
 library that I’ve added 
to `CMakeLists.txt` and `katedocument.h`. A disadvantage of my approach is that 
this library became a KTextEditor’s dependency, maybe it should be made 
optional?
  Fixes bug 330843 .

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4537

AFFECTED FILES
  src/CMakeLists.txt
  src/document/katedocument.cpp
  src/document/katedocument.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gszymaszek, #ktexteditor
Cc: kwrite-devel, #frameworks

[Differential] [Request, 2 lines] D4300: Simpler calculation of longest line limit

[Grzegorz Szymaszek]

gszymaszek created this revision.
gszymaszek added a reviewer: KTextEditor.
gszymaszek set the repository for this revision to R39 KTextEditor.
gszymaszek added a project: KTextEditor.
Restricted Application added subscribers: Frameworks, kwrite-devel.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  As suggested in `TODO`, I’ve replaced two `log()` calls with a single 
`log2()` call.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4300

AFFECTED FILES
  src/document/katedocument.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gszymaszek, #ktexteditor
Cc: kwrite-devel, #frameworks, cullmann, kfunk, sars, dhaumann

[Differential] [Request, 4 lines] D4296: Fixed single line comments in Less starting new regions

[Grzegorz Szymaszek]

gszymaszek created this revision.
gszymaszek added a reviewer: Framework: Syntax Hightlighting.
gszymaszek set the repository for this revision to R216 Syntax Highlighting.
gszymaszek added a project: Framework: Syntax Hightlighting.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  From bug 373002 :
  
  > If you type // in a Less (LESSCSS) file, Kate incorrectly opens a new 
region (it should do it in case of multiline comment, /*…*/). If you try to 
hide that region (using the arrow that's next to line number) it actually hides 
everything in the file starting from the comment.
  > 
  > Fixing this bug requires removing ' beginRegion="lessComment" ' from line 
924 (of less.xml) and incrementing file version number on line 3.
  > 
  > Single line comments are part of Less, as stated here:
  >  http://lesscss.org/features/#features-overview-feature-comments 

  
  This diff fixes the mentioned issue for me.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D4296

AFFECTED FILES
  data/syntax/less.xml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gszymaszek, #framework_syntax_hightlighting
Cc: #frameworks, cullmann, vkrause, dhaumann