D16189: kio_help: Fix crash in QCoreApplication when accessing help://

sitter added a comment. It was fixed in that it doesn't crash anymore. Due to crash handling now going through kcrash you still want to have a coreapp in every slave though. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16189 To: mpyne, #frameworks, sitter, dfaure,

D16299: RFC fallback to dnssd service discovery if smb listDir failed on root

sitter added a comment. It's on my todo, unfortunately I am at a sprint this week so probably nothing much happening on this until next week. Meanwhile I'd still like some comments on the presented diff (: REPOSITORY R320 KIO Extras REVISION DETAIL

D16529: make libssh module default to the "new" libssh config by default

This revision was automatically updated to reflect the committed changes. Closed by commit R320:0e129b10ae30: make libssh module default to the new libssh config by default (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D16529: make libssh module default to the "new" libssh config by default

sitter created this revision. sitter added reviewers: broulik, asn. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY - rename module from LibSSH to libssh so casing is consistent

D16387: [sftp] put request chunk debugging into own category

This revision was automatically updated to reflect the committed changes. Closed by commit R320:bf4563e8d291: [sftp] put request chunk debugging into own category (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16387?vs=44112=44153#toc REPOSITORY R320 KIO Extras

D16385: [sftp] reformat to 4 space indentation

This revision was automatically updated to reflect the committed changes. Closed by commit R320:972b5f5ef074: [sftp] reformat to 4 space indentation (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16385?vs=44109=44144 REVISION DETAIL

D16387: [sftp] put request chunk debugging into own category

sitter created this revision. sitter added reviewers: asn, broulik, ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY it's excessively verbose and not necessarily useful

D16385: [sftp] reformat to 4 space indentation

sitter created this revision. sitter added a reviewer: asn. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY while that generates history noise it's also much easier on the eyes and

D16299: RFC fallback to dnssd service discovery if smb listDir failed on root

sitter added a comment. Yep, so, by default Windows 10 does no service publication. The only way to make a host discoverable is by manually starting a publication service (which the user could switch to autostart, so it starts automatically on subsequent boots). With that service Windows

D16299: RFC fallback to dnssd service discovery if smb listDir failed on root

sitter added a comment. It's available as an API, but it is not used to publish **shares** it seems. In fact, if I am reading Microsoft's arcticle on smb1 correctly then ws-discovery is also not

D16299: RFC fallback to dnssd service discovery if smb listDir failed on root

sitter added a comment. Done some research on ws-discovery. gsoap is the only free c implementation I could find. There are some python, js and java implementations but they'll probably not help us nearly as much (unless someone wants to write a daemon or helper binary to bridge the

D16299: RFC fallback to dnssd service discovery if smb listDir failed on root

sitter added a comment. This diff does somewhat depend on D16298 as currently KDNSSD can easily lock indefinitely on resolving services. We could kinda bypass this with a timeout on service resolution, that would however have the disadvantage of either

D16299: RFC fallback to dnssd service discovery if smb listDir failed on root

sitter created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY This elevates a problem with newer SMB protocol versions and smbclient not supporting

D16298: prevent avahi signal racing

sitter marked 2 inline comments as done. REPOSITORY R272 KDNSSD REVISION DETAIL https://phabricator.kde.org/D16298 To: sitter, mdawson, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16298: prevent avahi signal racing

sitter updated this revision to Diff 43863. sitter added a comment. typo-- && make isOurMsg const REPOSITORY R272 KDNSSD CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16298?vs=43861=43863 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16298 AFFECTED FILES

D16298: prevent avahi signal racing

sitter added inline comments. INLINE COMMENTS > avahi-remoteservice.cpp:104 > + > +new org::freedesktop::Avahi::ServiceResolver( > +s.service(), FTR: this is obviously leaking and was doing so before as well. I'll fix it after this diff. REPOSITORY R272 KDNSSD REVISION

D16298: prevent avahi signal racing

sitter added reviewers: mdawson, broulik. REPOSITORY R272 KDNSSD REVISION DETAIL https://phabricator.kde.org/D16298 To: sitter, mdawson, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16298: prevent avahi signal racing

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY https://github.com/lathiat/avahi/issues/9 Avahi has upstream signal races which can have any number of side effect

D16272: apply eexist workaround from listDir to stat as well

This revision was automatically updated to reflect the committed changes. Closed by commit R320:cf34ba609dc4: apply eexist workaround from listDir to stat as well (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16272?vs=43793=43795

D16272: apply eexist workaround from listDir to stat as well

sitter edited the test plan for this revision. sitter added a reviewer: broulik. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D16272 To: sitter, broulik Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros,

D16272: apply eexist workaround from listDir to stat as well

sitter created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY knetattach stats() without first doing a listDir() so in the event that the url requires

D16221: style++

This revision was automatically updated to reflect the committed changes. Closed by commit R240:72aa6e1bf19c: style++ (authored by sitter). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16221?vs=43649=43650 REVISION DETAIL

D16221: style++

sitter created this revision. sitter added a reviewer: apol. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY easier to read with spaces SCM_SILENT REPOSITORY R240

D16154: fix Service(Type)Browser documentation

This revision was automatically updated to reflect the committed changes. Closed by commit R272:d99ca8a15458: fix Service(Type)Browser documentation (authored by sitter). REPOSITORY R272 KDNSSD CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16154?vs=43468=43634 REVISION DETAIL

D16183: KCrash: fix crash (ironic heh) when used in an app without QCoreApplication

sitter added a comment. KF5 style is to always `{}` single line if-else, no? REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D16183 To: dfaure, heikobecker, aacid, sitter Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16154: fix Service(Type)Browser documentation

sitter updated this revision to Diff 43468. sitter added a comment. use QStringLiteral REPOSITORY R272 KDNSSD CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16154?vs=43465=43468 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16154 AFFECTED FILES

D16154: fix Service(Type)Browser documentation

sitter created this revision. sitter added a reviewer: broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY servicebrowser code sample: - now uses our coding style - correctly references

D15638: force-finish canberra notifications on close()

This revision was automatically updated to reflect the committed changes. Closed by commit R289:d4f51fdc1d53: force-finish canberra notifications on close() (authored by sitter). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15638?vs=42037=43212

D15644: Provide option to hide menu bar for Ksysguard

This revision was automatically updated to reflect the committed changes. Closed by commit R106:3a3220d41ac4: Provide option to hide menu bar for Ksysguard (authored by lsartorelli, committed by sitter). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE

D15644: Provide option to hide menu bar for Ksysguard

sitter accepted this revision. sitter added a comment. It's perfect now! REVISION DETAIL https://phabricator.kde.org/D15644 To: lsartorelli, ngraham, #plasma, #frameworks, sitter Cc: broulik, sitter, acrouthamel, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D15644: Provide option to hide menu bar for Ksysguard

sitter added a subscriber: broulik. sitter added inline comments. INLINE COMMENTS > ksysguard.cpp:148 > + // set up 'Settings' menu > + mShowMenuBarAction = KStandardAction::showMenubar(this, > SLOT(toggleShowMenuBar()), actionCollection()); > @broulik just pointed out that KStandardAction

D15644: Provide option to hide menu bar for Ksysguard

sitter added a comment. Looks almost perfect to me. Only nit-pick I have is the fact that the include is out of order. Other than that it looks awesome  INLINE COMMENTS > ksysguard.cpp:54 > #include > +#include > That should be sorted alphabetically. REVISION DETAIL

D15646: [sftp] Remove unused variable type

sitter added a comment. already landed? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15646 To: asn, sitter, ngraham Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D15638: force-finish canberra notifications on close()

sitter created this revision. sitter added a reviewer: broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY `KNotification::close()` causes the manager to close the plugin for the notification

D15623: Finish the notification before removing it from the hash

sitter added a comment. Don't fret, it was a good idea :) REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D15623 To: jtamate, #frameworks, sitter Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D15623: Finish the notification before removing it from the hash

sitter added a comment. I am not sure I understand this. (admittedly I hadn't had enough coffee yet though) NotifyByAudio doesn't own the `KNotification *`, it gets it form the outside via `::notify()`. Why would removing the entry from the internal "cache" hash m_notifications cause

D15573: replace custom backtracing in SlaveBase with KCrash

This revision was automatically updated to reflect the committed changes. Closed by commit R241:d428fc8e6447: replace custom backtracing in SlaveBase with KCrash (authored by sitter). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15573?vs=41822=41887 REVISION

D15576: kcfg_compiler now documents valid inputs for its 'Color' type

This revision was automatically updated to reflect the committed changes. Closed by commit R237:39cdcdf6c1d5: kcfg_compiler now documents valid inputs for its Color type (authored by sitter). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15576?vs=41837=41849

D15576: kcfg_compiler now documents valid inputs for its 'Color' type

sitter added a subscriber: broulik. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D15576 To: sitter Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15576: kcfg_compiler now documents valid inputs for its 'Color' type

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY it wasn't exactly clear what the inputs for a Color type may be. this is now explained along with special type

D15573: replace custom backtracing in SlaveBase with KCrash

sitter created this revision. sitter added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY as discussed on mailing list. KCrash originally was automatically initialized, but

Re: kio slaves + kcrash + drkonqi

On Sun, Sep 16, 2018 at 10:48 AM David Faure wrote: > How about just killing the KDE_DEBUG check *and* the code that prints out a > backtrace? I'm always in favor of less code, so I'll prepare a diff for this. > > - Possibly KCRASH_AUTO_RESTARTED needs setting by something in KIO. > > From what

Re: network connectivity with proxy

On Mon, Sep 10, 2018 at 10:31 PM Alexander Semke wrote: > > Hi, > > in Knights and in LabPlot I realized recently, while being in a corporate > network behind a proxy, that the connection to public internet servers is not > possible. E.g. in Khights the connection to the FICS-server is done like

Re: Fixing license header

On Tue, Sep 11, 2018 at 5:34 PM Matthieu Gallien wrote: > > Hello, > > I have put a slightly incorrect license header at top of files. It is supposed > to be LGPL v3 or later but contains a few errors and is not matching the one > currently found on FSF site. > > I am not sure if it is necessary

kio slaves + kcrash + drkonqi

Hey I am a bit confused about crash handling in kio slaves. As in: it's not working the way it should be working and I don't know why it is the way it is. The debugging faq [1] suggest that this should behave like KCrash. by default all crashes get drkonqi'd unless you set KDE_DEBUG at which

D12493: Require NetworkManager 1.4.0 and newer

sitter accepted this revision. This revision is now accepted and ready to land. Herald added a subscriber: kde-frameworks-devel. REPOSITORY R282 NetworkManagerQt BRANCH master REVISION DETAIL https://phabricator.kde.org/D12493 To: jgrulich, #frameworks, sitter Cc: kde-frameworks-devel,

os-release parser?

konnichiwa A while ago I wrote a class to parse /etc/os-release. Should we maybe add this functionality to some framework? If so, which? https://cgit.kde.org/kinfocenter.git/tree/Modules/about-distro/src/OSRelease.cpp

Re: Kdiff3 release.

this should help https://community.kde.org/ReleasingSoftware On Thu, Aug 2, 2018 at 9:25 AM Michael Reeves wrote: > > That's what I'm looking at doing. The translation need some minor updating. > In particular the docs were changed to correct some obsolete information > regarding windows and

D14397: Support libcanberra for audio notification

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Well, I still think the result handling is more complicated than it needs to be, but whatever. LGTM for landing after 5.49 tagging (expected August 4th IIRC).

D14397: Support libcanberra for audio notification

sitter requested changes to this revision. sitter added a comment. This revision now requires changes to proceed. Code looks mostly ok. As discussed on IRC my main concern is that the current code ignores the return values of just about every ca_* method. This is a bit problematic from a

D14397: Support libcanberra for audio notification

sitter added a comment. In D14397#299073 , @rjvbb wrote: > > That's reinventing the wheel to a point. > > Creating Qt after Gtk or vice-versa was also reinventing the wheel to a much larger extent - so is adding more and more OS features

D14397: Support libcanberra for audio notification

sitter added a comment. In D14397#298557 , @ngraham wrote: > Impressive work, Kai! However I rather like the idea of improving QTMultiMedia's sound handling features rather than working around the lack of them by using a different library.

D14397: Port audio notification to libcanberra

sitter added a comment. In D14397#298420 , @rjvbb wrote: > > According to its website "It comes with several backends (ALSA, PulseAudio, OSS, GStreamer, null)" > > Which are all either Linux-specific or *nix-desktop oriented with ties to

D14397: Port audio notification to libcanberra

sitter added a comment. In D14397#298420 , @rjvbb wrote: > I didn't think of this before, but do you actually need a 3rd party library for playing alert sounds? In D14397#298350 , @sitter

D14397: Port audio notification to libcanberra

sitter added a comment. Canberra's primary advantage over phonon is that it can directly use pulseaudio/alsa, bypassing the entire sound system middleware madness and leveraging PA's builtin caching mechanism. i.e. if a sound notification is played a bunch of times it will be cached

D11235: [DrKonqi] Request change of ptrace scope from KCrash

sitter added a subscriber: lepagevalleeemmanuel. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D11235 To: croick, #plasma_workspaces, #frameworks Cc: lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D11236: [KCrash] Establish socket to allow change of ptrace scope

sitter added a subscriber: lepagevalleeemmanuel. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D11236 To: croick, #frameworks Cc: lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, ngraham, bruns

D14045: [Containment] Don't load containment actions with plasma/containment_actions KIOSK restriction

sitter added a comment. lgtm. There's a legacy mention of this kiosk key in ContainmentInterface which should be nukable in favor of this change. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14045 To: broulik, #plasma, mart, sitter Cc:

Re: Flatpak/Snap BoF at Akademy

Tuesday works for me. On Thu, Jun 28, 2018 at 7:54 AM Jan Grulich wrote: > > Hi, > > I would like to organize a BoF for Flatpak and Snap related stuff, to discuss > our support of sandboxing, plans for future and so on. I would like to know > whether there is an interest before booking a room for

D10716: handle wrong password when using sudo which asks for another password

sitter requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R299 KDESu REVISION DETAIL https://phabricator.kde.org/D10716 To: jriddell, sitter Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

sitter added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. ping ping ping REPOSITORY R299 KDESu REVISION DETAIL https://phabricator.kde.org/D10716 To: jriddell, sitter Cc: kde-frameworks-devel, michaelh, ngraham, bruns,

D13327: Fix conversion error when compiled against MDNSRESPONDER option

sitter added a comment. `-DQT_NO_CAST_FROM_BYTEARRAY` is a default define from `KDEFrameworkCompilerSettings.cmake`, so kdnssd should be working. The reason it wasn't is likely because most/all distributions build with avahi. Additionally, build.kde.org seems to build without avahi and

bic in kactivities

Salut! https://cgit.kde.org/kactivities.git/commit/?id=47a4055e4d6fbf4eb826f255d040620ef23f11c1 It appears to me that this is a binary incompatible change. https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B > You cannot...For existing functions of any type:change its

D12380: [Containment Interface] Honor plasma/containment_context_menu restriction

sitter requested changes to this revision. sitter added a comment. This revision now requires changes to proceed. quick dump from irc [14:48] kbroulik: hm, doesn't mousePressEvent get called for all clicks? (i.e. original line 1021-2026 are where the call chain goes into

D12216: Don't need to run previous iterations commands again

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Definitely worth a .1 REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D12216 To: apol, #frameworks, arojas, sitter Cc: sitter, heikobecker,

D11236: [KCrash] Establish socket to allow change of ptrace scope

sitter added a comment. Maybe I am missing something here but wouldn't this allow any application to get ptrace access? e.g. if a malicious program watches /tmp/kcrash_*, then writes its own pid to a new socket before kcrash writes the debugger's... now the malicious program has ptrace

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

sitter added subscribers: dfaure, sitter. sitter added a comment. @cgiboudeaux @dfaure I am almost entirely certain this broke building of ki18n itself when *it* contains translations. Neon packs translations into git builds, so here's the failure:

D10776: Make it possible to generate po files in parallel

sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D10776 To: apol, #frameworks, sitter Cc: michaelh

kio-stash bugzilla product?

hi kio-stash is an extragear project but has no bugzilla product. where do I file bug reports? https://cgit.kde.org/kio-stash.git HS

D10776: Make it possible to generate po files in parallel

sitter added inline comments. INLINE COMMENTS > build-tsfiles.cmake:75 > ${pmapc_file} > RESULT_VARIABLE code > ) This doesn't belong here, does it? It's also defined in execute_process() and from looking at the docs it would only be set once. REPOSITORY R249

D10776: Make it possible to generate po files in parallel

sitter added a comment. Ingenious code! You left some debug clutter behind though. Also, the if i statement is inconsistent between the two files `if (i EQUAL ${numberOfProcesses})` vs. `if (i GREATER ${numberOfProcesses})` INLINE COMMENTS > build-pofiles.cmake:45 > +

Re: Fallback Icon Theme

On Sun, Mar 4, 2018 at 7:30 PM, Martin Kostolný wrote: > If there is a better way of solving our situation, please tell us :). Someone needs to file bug reports against adwaita so the missing icons can get added. That is the proper solution to an incomplete icon set. It's

D10776: Make it possible to generate po files in parallel

sitter added a comment. As discussed on telegram: the proposed change makes it a different problem. Now instead of running serial all the time, it'd fork bomb all the time (peaks at 3671 forks for plasma-desktop 5.12 when run on a fairly fast system with SSD). Also, missing adjustment

D10716: handle wrong password when using sudo which asks for another password

sitter added a comment. Ping REPOSITORY R299 KDESu REVISION DETAIL https://phabricator.kde.org/D10716 To: jriddell, sitter Cc: #frameworks, michaelh

D10716: handle wrong password when using sudo which asks for another password

sitter added a comment. In D10716#212174 , @jriddell wrote: > I fear that creating a stub replacement wouldn't be necessarily a reliable recreation. I am not sure what you mean. If you create a stub from what you observe right now then

D10716: handle wrong password when using sudo which asks for another password

sitter added a comment. As mentioned on IRC I think this would benefit greatly from some unit testing as that line check is dangerously close to requiring mental gymnastics to read. AT a glance, all that's needed is writing stub sudo/su helpers and a test asserting outcome of

Re: Dependent review requests

On Thu, Jan 25, 2018 at 3:00 PM, Michael Heidelbach wrote: > Hi! > > When I do > > git checkout -b A origin/master > > (changes) > > git checkout -b B A > > (changes) > > > git checkout A > > arc diff > > git checkout B > > arc diff > > Will phabricator show the relation of A

D10046: unset maintainer

This revision was automatically updated to reflect the committed changes. Closed by commit R245:978676ee9a20: unset maintainer (authored by sitter). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10046?vs=25809=25870 REVISION DETAIL

D10044: actually install the new animations context

This revision was automatically updated to reflect the committed changes. Closed by commit R266:c6fcf84e1ac8: actually install the new animations context (authored by sitter). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10044?vs=25807=25810 REVISION

D10046: unset maintainer

sitter created this revision. sitter added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. sitter requested review of this revision. REVISION SUMMARY Alex isn't really active right now, so untag him as maintainer and

D10044: actually install the new animations context

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. sitter requested review of this revision. REVISION SUMMARY https://phabricator.kde.org/R266:495829b2b0fea458bfa01a996d23181d254e3521 introduced a new

D10020: add a workaround to mark snap bundle mounts as hidden

sitter abandoned this revision. sitter added a comment. Ah. I like his patch better. Thanks REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D10020 To: sitter, apol Cc: bshah, broulik, #frameworks

D10020: add a workaround to mark snap bundle mounts as hidden

sitter created this revision. sitter added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. sitter requested review of this revision. REVISION SUMMARY snap bundles are loop mounted into the file system, the more bundles

D9888: Make kdesu work when PWD is /usr/bin

sitter accepted this revision. sitter added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > suprocess.cpp:122 > > -QByteArray command; > -if (d->superUserCommand == QLatin1String("sudo")) { > -command = __PATH_SUDO; > -} else { > -

D9807: autotests: do not incorrectly split spaces in paths of duplicate results

sitter accepted this revision. This revision is now accepted and ready to land. BRANCH master REVISION DETAIL https://phabricator.kde.org/D9807 To: dfaure, sitter, apol Cc: cfeck, #frameworks

D9781: do not incorrectly split spaces in paths of duplicate results

This revision was automatically updated to reflect the committed changes. Closed by commit R266:08ddec40bf89: do not incorrectly split spaces in paths of duplicate results (authored by sitter). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

Re: duplicate icon in breeze-icons

https://phabricator.kde.org/D9781 On Wed, Jan 10, 2018 at 10:06 AM, Harald Sitter <sit...@kde.org> wrote: > Whatever's going on with that output Oo > > On Fri, Jan 5, 2018 at 10:13 AM, David Faure <fa...@kde.org> wrote: >> Hello Andreas, >> >> I'm emailin

D9781: do not incorrectly split spaces in paths of duplicate results

sitter created this revision. sitter added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. sitter requested review of this revision. REVISION SUMMARY use kcoreaddons to split fdupes output. fdupes outputs `/space\

Re: duplicate icon in breeze-icons

Whatever's going on with that output Oo On Fri, Jan 5, 2018 at 10:13 AM, David Faure wrote: > Hello Andreas, > > I'm emailing you since you committed some gnumeric icons to breeze-icons. > > CI fails because it says that > /icons/actions/24/gnumeric-formulaguru.svg > and >

D7008: Don't export internal helper executables

sitter added a comment. In https://phabricator.kde.org/D7008#185897, @apol wrote: > Or as @dfaure says, don't install at all, because I don't see who uses this. Or remove altogether? The helpers are used by sonnet at build time, so to cross compile sonnet you need the helpers

D9299: Introduce INSTALL_PREFIX_SCRIPT to easily set up prefixes

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. I currently can't do a testbuild, but the code looks good now. If we want to iterate on the concept further I think we should do it separately, no sense holding up this diff from

D9299: Introduce INSTALL_PREFIX_SCRIPT to easily set up prefixes

sitter requested changes to this revision. sitter added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > KDEInstallDirs.cmake:699 > +if(INSTALL_PREFIX_SCRIPT) > +file(WRITE ${CMAKE_BINARY_DIR}/prefix.sh " > +export

D9295: do not treat ts-pmap-compile as exectuable

This revision was automatically updated to reflect the committed changes. Closed by commit R249:54147ad2fc2d: do not treat ts-pmap-compile as exectuable (authored by sitter). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9295?vs=23802=23803 REVISION DETAIL

D9295: do not treat ts-pmap-compile as exectuable

sitter created this revision. sitter added a reviewer: ilic. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY - strip shebang - make -x the script is run through add_custom_command with the explicit python

Re: DragonPlayer

It's maintained just fine https://phabricator.kde.org/R259:b06cd9e1fbacefabdd2c0fa61f9af39cead25d8e. It's not getting better, it's not getting worse it's getting maintained at the level it is at. What Nate is asking for is an active developer... and that is an entirely different problem which

D9240: [RunnerManager] Don't mess with ThreadWeaver thread count

sitter accepted this revision. sitter added a comment. I love it REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D9240 To: broulik, #plasma, #frameworks, davidedmundson, sitter Cc: sitter, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,

D9240: [RunnerManager] Use QThread::idealThreadCount() instead of going through Solid

sitter added a comment. It seems to me the only reason we have custom code to set the max count is because of that `maxThreads` config entry. An entry for which I can't see any UI backing, so it's borderline usless to begin with. The qMin then destroys any remaining use that entry may have

Re: Frameworks and pkgconfig files

On Wed, Nov 29, 2017 at 9:43 AM, Christophe Giboudeaux wrote: > Hello, > > in https://bugs.kde.org/386933, the bug reporter mentions the pkgconfig file > name shall match the library one. I cannot find any such requirement. It is *suggested* to have one config per lib with

D8825: do not show edit bookmarks action if keditbookmarks is not installed

This revision was automatically updated to reflect the committed changes. Closed by commit R294:5dffdee21f20: do not show edit bookmarks action if keditbookmarks is not installed (authored by sitter). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE

releaseme new requirement: non-conflicting files on case-insensitive FS/OS

Guten Abend Everyone! To aid with use of our tarballs on Windows and case-insensitive file systems, releaseme now makes sure [1] that the tarballs it generates are safe to use in such contexts. As this is a major problem for pretty much every source tarball as it prevents people from doing

<    3   4   5   6   7   8   9   10   11   12   >