Re: kdesdk/cmake: in which git repo should utils for cmake end up?

2012-06-21 Thread Nicolás Alvarez
Friedrich W. H. Kossebau wrote: Am Montag, 4. Juni 2012, 14:03:19 schrieb Alexander Neundorf: On Friday, June 01, 2012 06:47:34 PM Friedrich W. H. Kossebau wrote: nightly-support/: this is for files which are useful for running Nightly builds of KDE (and maybe also other cmake-based

Re: Making KDocTools independent of KArchive

2013-09-24 Thread Nicolás Alvarez
On Monday, September 23, 2013, Nicolás Alvarez wrote: On Monday, September 23, 2013, Kevin Ottens wrote: On Saturday 21 September 2013 15:25:27 Albert Astals Cid wrote: El Dissabte, 21 de setembre de 2013, a les 11:15:52, Stephen Kelly va escriure: Albert Astals Cid wrote

Re: Fwd: Reminder: use KF5::foo instead of ${foo_LIBRARIES} in CMakeLists

2013-09-25 Thread Nicolás Alvarez
2013/9/25 Aurélien Gâteau agat...@kde.org: The alternative syntax: ${KConfigCore_LIBRARIES} would work in both cases, but it is more error prone: any typo in the variable name causes the variable to be expanded to an empty string, making it more difficult to debug, whereas using target names

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

2013-09-29 Thread Nicolás Alvarez
think the concept of latched vs locked state would map cleanly to other platforms. What's the use case for distinguishing between them? - Nicolás Alvarez On Sept. 4, 2013, 6:37 a.m., Martin Gräßlin wrote: --- This is an automatically

Switch build.kde.org to Qt stable branch

2013-10-02 Thread Nicolás Alvarez
As you may know, Qt is working to release 5.2. The dev branch has been merged to the stable branch, which means the stable branch is now 5.2, and dev is now 5.3. build.kde.org is compiling Qt from source, but it's using the dev branch. As far as I know, the plan is to release KF5 depending on Qt

Re: Review Request 113067: Fix compilation

2013-10-02 Thread Nicolás Alvarez
building. Go for it. - Nicolás Alvarez On Oct. 2, 2013, 9:12 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113067

Use of the WIN32 executable property

2013-10-02 Thread Nicolás Alvarez
[Background for the blissfully Windows-ignorant devs: On Windows, executable files have a flag saying whether they are GUI or console applications. Running a GUI application from a console will give you the prompt back immediately; I think there's no way to capture stdout. Running a console

Re: Compiling Plasma-Framework with a QT5 compiled with -egl -opengl es2

2013-10-09 Thread Nicolás Alvarez
2013/10/9 nerdopolis bluescreen_aven...@verizon.net: Hi. I am trying to compile plasma-framework against a qt5 that is ready for Wayland, which does not have Desktop GL enabled. However I seem to get an error that seems to be related to opengl in QT. Is this a bug I should file? This

Re: Review Request 113196: kdirwatch: include correct header for time_t and ino_t.

2013-10-11 Thread Nicolás Alvarez
on Windows/MSVC2010 but not for this reason :) Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113196: kdirwatch: include correct header for time_t and ino_t.

2013-10-12 Thread Nicolás Alvarez
/MSVC2010 but not for this reason :) Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Jenkins build became unstable: kdelibs_frameworks_qt5 #1423

2013-10-12 Thread Nicolás Alvarez
2013/10/13 KDE CI System n...@kde.org: See http://build.kde.org/job/kdelibs_frameworks_qt5/1423/changes This is a failure in a KArchive test, regarding the assertion dt.secsTo(creationTime) = 1. The change that triggered this build only added comments in KDirWatch; nowhere near the KArchive

Review Request 113226: Cleanup kdirwatch includes.

2013-10-12 Thread Nicolás Alvarez
3858bfaa68967d29327ca4319ab164af511d3186 Diff: http://git.reviewboard.kde.org/r/113226/diff/ Testing --- Compiles and tests pass on Linux. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Bring kdewin back?

2013-10-14 Thread Nicolás Alvarez
Hi, While trying to get KDE Frameworks to build on Windows, I found the codebase of KDirWatch is full of Unixisms. I did a few improvements towards getting it to build on Windows, but I'm now getting several errors related to the lack of symbolic links (such as no lstat). It's clear this code

Re: Bring kdewin back?

2013-10-14 Thread Nicolás Alvarez
2013/10/14 Aleix Pol aleix...@kde.org: It's good to know that there's somebody out there taking care of kf5 on windows. I'm unsure of what to say, though. Maybe you can come up with a list of issues so that we can fix them? At least some output log could be useful... I'm now working on

Review Request 113297: Remove 'override' from ThreadWeaver::IdDecorator destructor.

2013-10-16 Thread Nicolás Alvarez
://git.reviewboard.kde.org/r/113297/diff/ Testing --- Still builds on Linux, now builds on Windows too. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-16 Thread Nicolás Alvarez
e4f45441d5ed68e3e34ae2bd68e16fd3dc46656a tier1/kcoreaddons/src/lib/io/kdirwatch_p.h 442d6497b704c179adc13dbb25e450554d31554d Diff: http://git.reviewboard.kde.org/r/113298/diff/ Testing --- Still compiles :) Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-16 Thread Nicolás Alvarez
--- Still compiles :) Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113299: KDirWatch code style: braces for one-liner conditionals

2013-10-16 Thread Nicolás Alvarez
/kcoreaddons/src/lib/io/kdirwatch.cpp e4f45441d5ed68e3e34ae2bd68e16fd3dc46656a tier1/kcoreaddons/src/lib/io/kdirwatch_p.h 442d6497b704c179adc13dbb25e450554d31554d Diff: http://git.reviewboard.kde.org/r/113299/diff/ Testing --- It compiles, tests pass. Thanks, Nicolás Alvarez

Re: CMake fails configuring KF5

2013-10-16 Thread Nicolás Alvarez
2013/10/17 David Gil Oliva davidgilol...@gmail.com: Hi! I'm getting this error from CMake while building KF5: -- Found KF5: /home/david/devel/kf5-development/share/ECM/find-modules/FindKF5.cmake (found suitable version 5.0.0, minimum required is 5.0.0) found components: CMake Compiler

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-17 Thread Nicolás Alvarez
/io/kdirwatch_p.h 442d6497b704c179adc13dbb25e450554d31554d Diff: http://git.reviewboard.kde.org/r/113298/diff/ Testing --- Still compiles :) Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-17 Thread Nicolás Alvarez
--- On Oct. 17, 2013, 4 p.m., Nicolás Alvarez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113298

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-17 Thread Nicolás Alvarez
://git.reviewboard.kde.org/r/113298/diff/ Testing --- Still compiles :) Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-17 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113298/#review41907 --- On Oct. 17, 2013, 4:05 p.m., Nicolás Alvarez wrote

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-17 Thread Nicolás Alvarez
--- Still compiles :) Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-21 Thread Nicolás Alvarez
://git.reviewboard.kde.org/r/113298/diff/ Testing --- Still compiles :) Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113299: KDirWatch code style: braces for one-liner conditionals

2013-10-21 Thread Nicolás Alvarez
/ Testing --- It compiles, tests pass. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113297: Remove 'override' from ThreadWeaver::IdDecorator destructor.

2013-10-21 Thread Nicolás Alvarez
/threadweaver/src/Weaver/IdDecorator.h 648d4236cc22015a1d145892daf368084a199053 Diff: http://git.reviewboard.kde.org/r/113297/diff/ Testing --- Still builds on Linux, now builds on Windows too. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing

Re: Review Request 113377: Add KDeclarative to known KF5 tier3 modules

2013-10-21 Thread Nicolás Alvarez
2013/10/21 Sebastian Kügler se...@kde.org This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113377/ Review request for KDE Frameworks and Stephen Kelly. By Sebastian Kügler. Repository: extra-cmake-modules Description Add KDeclarative to known

Review Request 113376: KDirWatch: don't check for symlinks on Windows.

2013-10-21 Thread Nicolás Alvarez
://git.reviewboard.kde.org/r/113376/diff/ Testing --- KDirWatch tests still pass on Linux. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113376: KDirWatch: don't check for symlinks on Windows.

2013-10-23 Thread Nicolás Alvarez
/kcoreaddons/src/lib/io/kdirwatch.cpp 3468529605526c0f02e6350a90d65105b19c4708 Diff: http://git.reviewboard.kde.org/r/113376/diff/ Testing --- KDirWatch tests still pass on Linux. Still doesn't compile on Windows, but getting closer. Thanks, Nicolás Alvarez

Re: Review Request 113424: Use whoami as the command in KDesktopFileTest::testSuccessfulTryExec()

2013-10-24 Thread Nicolás Alvarez
On Oct. 24, 2013, 4:25 p.m., Alex Merry wrote: whoami is part of coreutils, so should be available everywhere. The only possible issue I see is that we've gone from a test that doesn't depend on PATH to one that does. This isn't necessarily a problem, but it will test slightly

Re: Use of the WIN32 executable property

2013-10-25 Thread Nicolás Alvarez
2013/10/25 David Faure fa...@kde.org: On Wednesday 02 October 2013 23:52:08 Nicolás Alvarez wrote: In fact, I wonder if we should make all tests console applications by default (in ecm_mark_as_test?)... All unittests, yes. But interactive test apps are really just normal test apps, there's

Re: cyclic dependency kinit - kservice

2013-10-27 Thread Nicolás Alvarez
El domingo, 27 de octubre de 2013, David Faure escribió: On Friday 25 October 2013 18:27:02 Kevin Ottens wrote: On Friday 25 October 2013 12:21:28 David Narvaez wrote: On Fri, Oct 25, 2013 at 11:37 AM, Kevin Ottens er...@kde.orgjavascript:; wrote: Not that I know of, Alex never

Re: Getting ecm files from the ECM package

2013-11-01 Thread Nicolás Alvarez
2013/11/1 Kevin Ottens er...@kde.org: Hello, On Friday 01 November 2013 11:23:14 Mirko Boehm wrote: On 11/01/2013 10:46 AM, Alexander Neundorf wrote: [1] Why not merge that into CMake ? For quicker releases, and even easier contributing. Also Bill once said that in hindsight he would have

Re: Getting ecm files from the ECM package

2013-11-01 Thread Nicolás Alvarez
2013/11/1 Mirko Boehm mi...@kde.org: I'm also surprised at Almost everybody has internet access for build machines. Is there *any* Linux distro where that's the case?? Pretty strong language. Not much proof. Do you *know* how Red Hat or SuSE build their packages? No I don't. I didn't say no

Re: Review Request 113631: Allow compiling kwindowsystem on Windows

2013-11-05 Thread Nicolás Alvarez
anything wrong; but I'm also not confident enough to give a ship-it. Where are the Windows experts? :) - Nicolás Alvarez On Nov. 4, 2013, 5:33 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 113805: Do not change the build types available with cmake

2013-11-11 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113805/#review43479 --- Ship it! Yes please. - Nicolás Alvarez On Nov. 11, 2013, 7

Re: Review Request 113805: Do not change the build types available with cmake

2013-11-11 Thread Nicolás Alvarez
On Nov. 11, 2013, 9:02 p.m., Aleix Pol Gonzalez wrote: Maybe I've missed something, but I would like to have it explained somehow. Why is it bad to define such values? How will g++ calls compare? In normal CMake, -DCMAKE_BUILD_TYPE=Debug builds without optimization and with debugging

Re: RFC Rules for installation of header files

2013-11-15 Thread Nicolás Alvarez
El viernes, 15 de noviembre de 2013, Kevin Ottens escribió: On Friday 15 November 2013 17:24:00 Aurélien Gâteau wrote: On Thu, 14 Nov 2013 17:55:42 +0100, Kevin Ottens wrote: On Thursday 14 November 2013 18:40:04 Aurélien Gâteau wrote: Looks like we have an agreement then. Let me recap:

Re: Review Request 113805: Do not change the build types available with cmake

2013-11-15 Thread Nicolás Alvarez
On Nov. 12, 2013, 4:24 p.m., Alexander Neundorf wrote: IMO the patch as it is is not good. Several things: 1) This file, is not mandatory at all with KDE frameworks. You can build applications using KDE frameworks libraries without it. You (the developer of the application) simply

Re: Accessing the private of KGlobalShortcut in kglobalaccel

2013-11-22 Thread Nicolás Alvarez
2013/11/22 David Faure fa...@kde.org: On Wednesday 13 November 2013 07:22:18 Martin Gräßlin wrote: Hi, I'm currently trying to port kglobalaccel in kde-runtime to frameworks. I'm facing an issue in the file globalshortcut.cpp: it tries to access the private header of KGlobalShortcutInfo to

Review Request 114050: Add manual test app for enableBlurBehind.

2013-11-22 Thread Nicolás Alvarez
Screenshot http://git.reviewboard.kde.org/media/uploaded/files/2013/11/23/1ef7d9bb-84e4-422c-9782-a63f02021639__blur-behind-test.png Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 114050: Add manual test app for enableBlurBehind.

2013-11-29 Thread Nicolás Alvarez
Screenshot http://git.reviewboard.kde.org/media/uploaded/files/2013/11/23/1ef7d9bb-84e4-422c-9782-a63f02021639__blur-behind-test.png Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Missing FindCarbon.cmake

2013-12-09 Thread Nicolás Alvarez
I'm trying to build KF5 on OS X. KIdleTime, KWindowSystem and KWallet depend on the Carbon library; they have a find_package(Carbon). However, they all fail to find FindCarbon.cmake. It's currently present in kde4support and in the ecm 'attic' directory. Should it be installed by ecm, or copied

Re: Tracking bugs in Frameworks

2013-12-16 Thread Nicolás Alvarez
El lunes, 16 de diciembre de 2013, Martin Klapetek escribió: On Mon, Dec 16, 2013 at 11:58 AM, David Edmundson da...@davidedmundson.co.uk javascript:_e({}, 'cvml', 'da...@davidedmundson.co.uk'); wrote: I think if we did that it would be a good idea to prefix the names with a common

Re: Review Request 114502: KDE4_ENABLE_EXCEPTIONS = KDE_ENABLE_EXCEPTIONS

2013-12-16 Thread Nicolás Alvarez
'-fexceptions' I kept getting when compiling threadweaver with MSVC. - Nicolás Alvarez On Dec. 16, 2013, 2:10 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114502

Re: Framework metadata

2013-12-19 Thread Nicolás Alvarez
2013/12/19 Aurélien Gâteau agat...@kde.org: On Thu, 19 Dec 2013 12:13:08 +0200, Giorgos Tsiapaliokas wrote: I definitely like the idea but I don't like xml/rdf. Why don't we just use json? Because DOAP is an existing format, so it avoids reinventing the wheel. Everyone please keep in mind

Re: KDE-wide Animation settings

2014-01-04 Thread Nicolás Alvarez
2014/1/4 David Faure fa...@kde.org: On Saturday 04 January 2014 23:02:35 Dominik Haumann wrote: What I personally would like more is to always be able to read this. I of course can use a KSharedConfig::openConfig() and then read the config value myself. However, would it be of interest to

Re: kwalletd about to be switched from kde-runtime to kwallet-framework

2014-01-13 Thread Nicolás Alvarez
2014/1/13 David Faure fa...@kde.org: On Sunday 12 January 2014 19:59:26 Valentin Rusu wrote: Hello, Please be informed that I successfully imported the git history of kwalletd from kde-runtime to kwallet-framework, the I ported it to KF5. The code is ready to be pushed, but there are 430

Re: Review Request 115021: Fix build without X

2014-01-15 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115021/#review47457 --- Ship it! Ship It! - Nicolás Alvarez On Jan. 15, 2014, 6

Re: Change the ML default reply-to address

2014-01-28 Thread Nicolás Alvarez
2014-01-28 Martin Klapetek martin.klape...@gmail.com: Hey, would it be possible to change the default reply-to address for this list? It's quite annoying in less-advanced-than-kmail clients always pressing Reply and getting only the sender instead of the whole list. There's a switch for

Re: Review Request 115715: Remove X11 dependency from kprintutils

2014-02-14 Thread Nicolás Alvarez
On Feb. 14, 2014, 10:58 a.m., John Layt wrote: I'd prefer for now that you just replace the HAVE_X11 with #defined Q_OS_UNIX !defined Q_OS_MAC which should produce the same effect. No point in compiling the CUPS code if we're never going to use it. Once Qt feature freeze kicks in

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

2014-02-19 Thread Nicolás Alvarez
On Feb. 19, 2014, 7:06 a.m., Aleix Pol Gonzalez wrote: src/notifybypopupgrowl.h, line 37 https://git.reviewboard.kde.org/r/115695/diff/3/?file=243849#file243849line37 Is growl still the thing for MacOS X? Martin Klapetek wrote: I'm not sure to be honest...I've heard they

Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)

2014-03-18 Thread Nicolás Alvarez
://git.reviewboard.kde.org/r/116866/#comment37532 Do these copyright lines really apply to this new file? I think you should include just your own name (since you created this config file). - Nicolás Alvarez On March 18, 2014, 2:25 p.m., Michael Hansen wrote

Review Request 116879: Fix build of kuser_win.cpp with MSVC2010

2014-03-18 Thread Nicolás Alvarez
, but MSVC2010 doesn't. Diffs - src/lib/util/kuser_win.cpp e7fb5b6 Diff: https://git.reviewboard.kde.org/r/116879/diff/ Testing --- Compiles on MSVC2010 and 2013. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 116879: Fix build of kuser_win.cpp with MSVC2010

2014-03-18 Thread Nicolás Alvarez
. This will change in C++14 (see C++ DR975), and MSVC2013 implements the new behavior, but MSVC2010 doesn't. Diffs - src/lib/util/kuser_win.cpp e7fb5b6 Diff: https://git.reviewboard.kde.org/r/116879/diff/ Testing --- Compiles on MSVC2010 and 2013. Thanks, Nicolás Alvarez

Re: Review Request 116984: Fix configuring of kde5init_win32lib_dummy.cpp.in

2014-03-22 Thread Nicolás Alvarez
of kinit) doesn't compile on Windows. - Nicolás Alvarez On March 22, 2014, 5:46 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116984

Remnants of monolithic kdelibs.git building

2014-03-27 Thread Nicolás Alvarez
Many frameworks' top-level CMakeLists.txt still wrap their find_package calls in: if (${CMAKE_BINARY_DIR} STREQUAL ${CMAKE_CURRENT_BINARY_DIR}) That's left over from when the frameworks had to build both standalone and as part of the large kdelibs.git repository. Should it be removed? --

Review Request 117123: Add manual test for KUser::faceIconPath

2014-03-27 Thread Nicolás Alvarez
://git.reviewboard.kde.org/r/117123/diff/ Testing --- Tested on Windows and Linux. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117123: Add manual test for KUser::faceIconPath

2014-03-27 Thread Nicolás Alvarez
-1f32-468f-a04b-bace6a15c98c__faceicontest.png Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117131: Implement KUser::faceIconPath on Windows.

2014-03-27 Thread Nicolás Alvarez
- src/lib/util/kuser_win.cpp 96cf2f0b89ac18a68783793d3a8b2827b72dd968 Diff: https://git.reviewboard.kde.org/r/117131/diff/ Testing --- Compiled with MSVC2010, tested via the new faceicontest on Windows 7. Thanks, Nicolás Alvarez ___ Kde

Re: Review Request 117131: Implement KUser::faceIconPath on Windows.

2014-03-30 Thread Nicolás Alvarez
. - Nicolás --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117131/#review54437 --- On March 27, 2014, 10:07 p.m., Nicolás Alvarez

Re: Review Request 117131: Implement KUser::faceIconPath on Windows.

2014-03-30 Thread Nicolás Alvarez
the new faceicontest on Windows 7. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Re: Where to put kglobalacceld?

2014-04-04 Thread Nicolás Alvarez
2014-04-04 11:10 GMT-03:00 Martin Gräßlin mgraess...@kde.org: On Friday 04 April 2014 16:06:32 Aleix Pol wrote: On Fri, Apr 4, 2014 at 3:41 PM, Martin Gräßlin mgraess...@kde.org wrote: Hi, similar as to what we already have with DrKonqi moving kglobalacceld from kde- runtime into the

Re: Review Request 117131: Implement KUser::faceIconPath on Windows.

2014-04-04 Thread Nicolás Alvarez
the undocumented API is different, and faceIconPath will just return an empty string. Diffs - src/lib/util/kuser_win.cpp 96cf2f0 Diff: https://git.reviewboard.kde.org/r/117131/diff/ Testing --- Compiled with MSVC2010, tested via the new faceicontest on Windows 7. Thanks, Nicolás

Review Request 117437: KUser: Make guessHomeDir compatible with Windows XP

2014-04-08 Thread Nicolás Alvarez
Diff: https://git.reviewboard.kde.org/r/117437/diff/ Testing --- Ran kusertest on Windows XP. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117454: Implement KUser::faceIconPath for Windows XP

2014-04-11 Thread Nicolás Alvarez
, as otherwise the code became too redundant. Feedback welcome on identifier names, that's a known hard problem :) Diffs - src/lib/util/kuser_win.cpp aa48c04 Diff: https://git.reviewboard.kde.org/r/117454/diff/ Testing --- Ran faceicontest on Windows 7 and on XP. Thanks, Nicolás Alvarez

Review Request 117654: Replace range-based for loop with Qt foreach

2014-04-19 Thread Nicolás Alvarez
#117652 is applied too). Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117652: Rewrite FindLibGcrypt.cmake to not use gcrypt-config

2014-04-19 Thread Nicolás Alvarez
. Also tested on Debian Linux, cmake 2.8.12.1, finding the distro's libgcrypt. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117652: Rewrite FindLibGcrypt.cmake to not use gcrypt-config

2014-04-20 Thread Nicolás Alvarez
/runtime/kwalletd/backend/CMakeLists.txt 4c36767 Diff: https://git.reviewboard.kde.org/r/117652/diff/ Testing --- Tested on Windows with MSVC2010, cmake 2.8.12, finding emerge-built libgcrypt. Also tested on Debian Linux, cmake 2.8.12.1, finding the distro's libgcrypt. Thanks, Nicolás

Re: Review Request 117652: Rewrite FindLibGcrypt.cmake to not use gcrypt-config

2014-04-21 Thread Nicolás Alvarez
/ Testing --- Tested on Windows with MSVC2010, cmake 2.8.12, finding emerge-built libgcrypt. Also tested on Debian Linux, cmake 2.8.12.1, finding the distro's libgcrypt. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Review Request 117654: Replace range-based for loop with Qt foreach

2014-04-21 Thread Nicolás Alvarez
://git.reviewboard.kde.org/r/117654/diff/ Testing --- All of KWallet builds on Windows with MSVC2010 (if review #117652 is applied too). Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Review Request 117680: Fix linker errors with MSVC

2014-04-21 Thread Nicolás Alvarez
the functions private. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117655: Move the libgcrypt search to the backend CMakeLists.txt

2014-04-21 Thread Nicolás Alvarez
/kwalletd/backend/CMakeLists.txt 4c36767 Diff: https://git.reviewboard.kde.org/r/117655/diff/ Testing --- Builds, Linux and Windows. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 117655: Move the libgcrypt search to the backend CMakeLists.txt

2014-04-21 Thread Nicolás Alvarez
is not being built (ie. if BUILD_KWALLETD=OFF). Diffs - CMakeLists.txt 9aad9c0 src/runtime/kwalletd/backend/CMakeLists.txt 4c36767 Diff: https://git.reviewboard.kde.org/r/117655/diff/ Testing --- Builds, Linux and Windows. Thanks, Nicolás Alvarez

Re: Remnants of monolithic kdelibs.git building

2014-04-21 Thread Nicolás Alvarez
2014-03-27 13:18 GMT-03:00 Alex Merry alex.me...@kde.org: On 27/03/14 15:39, Nicolás Alvarez wrote: Many frameworks' top-level CMakeLists.txt still wrap their find_package calls in: if (${CMAKE_BINARY_DIR} STREQUAL ${CMAKE_CURRENT_BINARY_DIR}) That's left over from when the frameworks had

Re: Review Request 117680: Fix linker errors with MSVC

2014-04-21 Thread Nicolás Alvarez
be working even without this patch, as Q_DISABLE_COPY will use =delete instead of declaring the functions private. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Remnants of monolithic kdelibs.git building

2014-04-21 Thread Nicolás Alvarez
2014-04-21 16:53 GMT-03:00 Nicolás Alvarez nicolas.alva...@gmail.com: 2014-03-27 13:18 GMT-03:00 Alex Merry alex.me...@kde.org: On 27/03/14 15:39, Nicolás Alvarez wrote: Many frameworks' top-level CMakeLists.txt still wrap their find_package calls in: if (${CMAKE_BINARY_DIR} STREQUAL

Re: KF5 Update Meeting Minutes 2014-w17

2014-04-22 Thread Nicolás Alvarez
mck182 so can people please please update the list mck182 http://community.kde.org/Frameworks/List mck182 that is, if you're a maintainer and your framework says TBD, please update mck182 also I reset the assignee on some bugs mck182 and did some triaging =Nicolás Alvarez

Re: Review Request 117961: remove several warnings on mingw

2014-05-02 Thread Nicolás Alvarez
/117961/#comment39856 What's the warning here? Is it about signed vs unsigned? If so, change the format specifier to %u instead of casting. - Nicolás Alvarez On May 2, 2014, 6:16 p.m., Patrick Spendrin wrote

Review Request 118077: Fix build of kdelibs4migration.cpp on MSVC2010

2014-05-10 Thread Nicolás Alvarez
--- Compiles, tests pass. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118077: Fix build of kdelibs4migration.cpp on MSVC2010

2014-05-11 Thread Nicolás Alvarez
/kdelibs4migration.cpp 94655d9 Diff: https://git.reviewboard.kde.org/r/118077/diff/ Testing --- Compiles, tests pass. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: KFileAudioPreview

2014-05-12 Thread Nicolás Alvarez
2014-05-12 18:46 GMT-03:00 Alex Merry alex.me...@kde.org: Perhaps it's too late to change this, but it seems to me that this plugin should either be in KIO or kio-extras. The reason it isn't in KIO is that it depends on Phonon. KIO already depends indirectly on KNotifications which depends on

Themed icons on Windows

2014-05-25 Thread Nicolás Alvarez
The QIcon::fromTheme documentation says: By default, only X11 will support themed icons. In order to use themed icons on Mac and Windows, you will have to bundle a compliant theme in one of your themeSearchPaths and set the appropriate themeName. I can confirm this; Okteta5 doesn't show icons on

Re: Review Request 118374: Fix finding of Qt5LinguistTools on some systems

2014-05-28 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118374/#review58677 --- Ship it! Ship It! - Nicolás Alvarez On May 28, 2014, 8:32

Re: git hooks for reviews mandatory?

2014-06-19 Thread Nicolás Alvarez
2014-06-19 18:21 GMT-03:00 Marco Martin notm...@gmail.com: Hi all, I was thinking, since the policy for committing in frameworks is to always asking for a review, what about on repositories under frameworks/* adding an hook that accepts pushes only if the comment has a REVIEW: line? I have

Re: Review Request 118039: Simplify KConfig::readEntry/writeEntry

2014-06-20 Thread Nicolás Alvarez
2014-05-07 14:15 GMT-03:00 Thomas Braxton kde.brax...@gmail.com: This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118039/ Review request for KDE Frameworks and kdewin. By Thomas Braxton. Summary Simplify KConfig::readEntry/writeEntry

Review Request 118852: [kconfig] Fix build on Visual C++ 2010

2014-06-20 Thread Nicolás Alvarez
--- Compiles on MSVC2010, kconfigtest passes (with testEnums skipped). I haven't tried compiling on other compilers. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 118852: [kconfig] Fix build on Visual C++ 2010

2014-06-27 Thread Nicolás Alvarez
generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118852/#review61114 --- On June 20, 2014, 9:20 p.m., Nicolás Alvarez wrote: --- This is an automatically generated e

Re: Issues for Qt5/KF5/KDE/CI system on OSX/MacPorts

2014-06-27 Thread Nicolás Alvarez
2014-06-27 20:59 GMT-03:00 David Faure fa...@kde.org: On Friday 27 June 2014 23:01:33 Marko Käning wrote: I guess I’ve spotted that one of the frameworks obviously messes up when writing to the standard location below “Library/Application Support/“ because it omits the trailing slash leading

Re: Review Request 118852: [kconfig] Fix build on Visual C++ 2010

2014-06-29 Thread Nicolás Alvarez
- autotests/kconfigtest.cpp a8482b7 Diff: https://git.reviewboard.kde.org/r/118852/diff/ Testing --- Compiles on MSVC2010, kconfigtest passes (with testEnums skipped). I haven't tried compiling on other compilers. Thanks, Nicolás Alvarez ___ Kde

Re: OSX/MacPorts KDE CI System: Build failed for framework solid

2014-07-03 Thread Nicolás Alvarez
2014-07-03 3:31 GMT-03:00 Kevin Ottens er...@kde.org: Hello, On Wednesday 02 July 2014 08:33:01 Marko Käning wrote: on OSX solid fails to build because of this: --- /Users/marko/WC/KDECI-builds/solid/src/solid/devices/backends/iokit/iokitdev ice.cpp:227:25: error: allocating an object of

Directory structure under share/

2014-07-03 Thread Nicolás Alvarez
The subdirectories of prefix/share/ that KF5 installs seem inconsistent. For example, KAuth installs some data files in share/kf5/kauth, while KService services go to share/kservices5. Do we prefix things with kf5/ or not? Or is there a reason why some are prefixed and some aren't? -- Nicolás

Re: OSX/CI system: analitza with configure problem on branch master

2014-07-09 Thread Nicolás Alvarez
2014-07-09 19:45 GMT-03:00 Marko Käning mk-li...@email.de: Hi, see below for analitza’s configure problem, which seems to require kde4-config for some reason... I don’t know why this is happening, since it is shown DONE for KF5 on [1]. Greets, Marko [1]

Re: OSX/CI system: analitza build broken on branch frameworks

2014-07-10 Thread Nicolás Alvarez
2014-07-10 6:25 GMT-03:00 Aleix Pol aleix...@kde.org: On Thu, Jul 10, 2014 at 6:48 AM, Marko Käning mk-li...@email.de wrote: Thanks, now it there is more progress, but there’s s till a build failure later on. See below. Greets, Marko ——— 80%] Building CXX object

Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)

2014-07-12 Thread Nicolás Alvarez
longer SIDs to identify users. These are not returned by stat (stat always returns zero in the st_uid member). I would just ifdef away the UDS_USER and UDS_GROUP lines on Windows. - Nicolás Alvarez On Jul. 12, 2014, 11:20 a.m., Cristian Oneț wrote

KDELibs4Support fails to install on Windows if DocBookXML4 absent

2014-07-22 Thread Nicolás Alvarez
Hello, Currently KDELibs4Support fails to install on Windows. It gives the following error: CMake Error at src/cmake_install.cmake:264 (file): file RELATIVE_PATH must be passed a full path to the file: searched_dir-NOTFOUND Call Stack (most recent call first): cmake_install.cmake:115

Re: KDELibs4Support fails to install on Windows if DocBookXML4 absent

2014-07-23 Thread Nicolás Alvarez
El miércoles, 23 de julio de 2014, Luigi Toscano luigi.tosc...@tiscali.it escribió: On Wednesday 23 of July 2014 00:27:18 Nicolás Alvarez wrote: Hello, Currently KDELibs4Support fails to install on Windows. It gives the following error: CMake Error at src/cmake_install.cmake:264

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Nicolás Alvarez
On Aug. 1, 2013, 6:14 p.m., Milian Wolff wrote: staging/kservice/tools/desktoptojson/kconfigtojson.cpp, line 60 http://git.reviewboard.kde.org/r/111689/diff/6/?file=175868#file175868line60 just do return convert(...); No, that would give the opposite return value. To have the same

Re: Review Request 112079: Add utility function to paint icon overlays

2013-08-17 Thread Nicolás Alvarez
://git.reviewboard.kde.org/r/112079/#comment28137 What about calling this one AddOverlays, in plural? - Nicolás Alvarez On Aug. 14, 2013, 10:49 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http

  1   2   3   >