D18878: Force NT1 protocol when listing smb:// network

[Andrew Crouthamel]

acrouthamel added a comment.


  How do dependencies work here? Does this force SMB1 to be installed and 
enabled in Dolphin now? I ask because many companies have disabled and removed 
version 1 due to the security issues.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18878

To: mikhailnov
Cc: acrouthamel, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D18768: Extend Open Document thumbnailer to Office Open XML

[Andrew Crouthamel]

acrouthamel added a comment.


  Thanks for expanding the thumbnailer lately, awesome work with this and the 
eBook one. :)

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18768

To: broulik, #plasma, #vdg, #frameworks
Cc: acrouthamel, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D18563: Don't create directory tree when a new folder has a '/' in the name

[Andrew Crouthamel]

acrouthamel added a comment.


  -1 from me. I would prefer we stick to Unix methodologies.
  
  KDE software is also known to be the more feature-rich and customizable 
options out there, and as mentioned commonly linked to power users. We would be 
wise to not introduce a feature removal/regression such as this.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18563

To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino
Cc: acrouthamel, markg, ndavis, dfaure, elvisangelaccio, pino, 
kde-frameworks-devel, michaelh, ngraham, bruns

D16299: fallback to dnssd service discovery if smb listDir failed on root

[Andrew Crouthamel]

acrouthamel added a comment.


  In D16299#363498 , @sitter wrote:
  
  > If someone has a thought to offer on this please do.
  >  Personally I am somewhat leaning towards assuming that systems should be 
properly configured. The problem with setting the URL to the ip address is that 
it messes with the visual look in the address bar. So, if we want reliable 
resolution and good looks we'd need to resolve each dnssd address (e.g. 
`foobar.local`) to their ip address (e.g. 172.17.0.1) via kdnssd and then 
resolve that back to a hostname via glibc/qhostinfo (e.g. `foobar.sky.net`). 
That way we'd know that the name we have in the end is in fact resolvable by 
the system without aid from dnssd. Speed impact of this aside it also adds 3 
additional points of failure (and KDNSSD currently doesn't implement the 
resolver API it seems).
  
  
  I would recommend assuming DNS and systems are configured properly. I say 
that as someone with ~15 years IT experience. Modern IT networks are so heavily 
reliant on it (ever set up a VMware cluster? phew!), almost nothing works if it 
is not set up properly.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D16299

To: sitter, #frameworks, #dolphin
Cc: acrouthamel, alexde, bcooksley, ngraham, kde-frameworks-devel, kfm-devel, 
sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, 
bruns, emmanuelp, mikesomov

D16852: Add Documents to the default list of Places

[Andrew Crouthamel]

acrouthamel added a comment.


  In D16852#362344 , @ngraham wrote:
  
  > you could tackle the patch to make Dolphin's default window size a tad 
taller.
  
  
  I'll poke around.

REPOSITORY
  R241 KIO

BRANCH
  add-documents (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16852

To: acrouthamel, #frameworks, #dolphin, ngraham
Cc: davidc, elvisangelaccio, kde-frameworks-devel, ngraham, michaelh, bruns

D16852: Add Documents to the default list of Places

[Andrew Crouthamel]

acrouthamel added a comment.


  I had submitted this with the intention of being a follow-up to D15739 
, as that would clear a slot for this. I 
think right now, T9795  is outside my skill 
set. I'd be glad to make D15739  a parent 
to this and wait for that to land.

REPOSITORY
  R241 KIO

BRANCH
  add-documents (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16852

To: acrouthamel, #frameworks, #dolphin, ngraham
Cc: davidc, elvisangelaccio, kde-frameworks-devel, ngraham, michaelh, bruns

D16852: Add Documents to the default list of Places

[Andrew Crouthamel]

acrouthamel added a comment.


  In D16852#360940 , 
@elvisangelaccio wrote:
  
  > @acrouthamel Please open another diff with your patch thats updates the 
dolphin test, so I can try easily try it out
  
  
  Ok, I created D16967 . Thanks!

REPOSITORY
  R241 KIO

BRANCH
  add-documents (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16852

To: acrouthamel, #frameworks, #dolphin, ngraham
Cc: davidc, elvisangelaccio, kde-frameworks-devel, ngraham, michaelh, bruns

D16852: Add Documents to the default list of Places

[Andrew Crouthamel]

acrouthamel added a dependent revision: D16967: Add Documents shortcut 
detection.

REPOSITORY
  R241 KIO

BRANCH
  add-documents (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16852

To: acrouthamel, #frameworks, #dolphin, ngraham
Cc: davidc, elvisangelaccio, kde-frameworks-devel, ngraham, michaelh, bruns

D16852: Add Documents to the default list of Places

[Andrew Crouthamel]

acrouthamel added a comment.


  I checked out the test log and see the following, yet I honestly can't figure 
out why it is off by one, since any line referencing hasDocumentsFolder is a ++ 
line for the count. Do I need to run this test on a new user account or 
something?
  
FAIL!  : PlacesItemModelTest::testDeletePlace() Compared lists differ at 
index 2.
   Actual   (places): "/home/andrew/Desktop"
   Expected (urls): "/home/andrew/Documents"
   Loc: 
[/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(411)]
FAIL!  : PlacesItemModelTest::testPlaceItem(Places - Home) Compared values 
are not the same
   Actual   (m_model->count()): 19
   Expected (m_expectedModelCount): 18
   Loc: 
[/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)]
FAIL!  : PlacesItemModelTest::testPlaceItem(Baloo - Documents) Compared 
values are not the same
   Actual   (m_model->count()): 19
   Expected (m_expectedModelCount): 18
   Loc: 
[/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)]
FAIL!  : PlacesItemModelTest::testPlaceItem(Baloo - Today) Compared values 
are not the same
   Actual   (m_model->count()): 19
   Expected (m_expectedModelCount): 18
   Loc: 
[/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)]
FAIL!  : PlacesItemModelTest::testPlaceItem(Devices - Floppy) Compared 
values are not the same
   Actual   (m_model->count()): 19
   Expected (m_expectedModelCount): 18
   Loc: 
[/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)]
FAIL!  : PlacesItemModelTest::testTearDownDevice() Compared values are not 
the same
   Actual   (m_model->count()): 19
   Expected (m_expectedModelCount): 18
   Loc: 
[/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)]
FAIL!  : PlacesItemModelTest::testDefaultViewProperties(Places - Home) 
Compared values are not the same
   Actual   (m_model->count()): 19
   Expected (m_expectedModelCount): 18
   Loc: 
[/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)]
FAIL!  : PlacesItemModelTest::testDefaultViewProperties(Baloo - Documents) 
Compared values are not the same
   Actual   (m_model->count()): 19
   Expected (m_expectedModelCount): 18
   Loc: 
[/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)]
FAIL!  : PlacesItemModelTest::testDefaultViewProperties(Places - Audio) 
Compared values are not the same
   Actual   (m_model->count()): 19
   Expected (m_expectedModelCount): 18
   Loc: 
[/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)]
FAIL!  : PlacesItemModelTest::testDefaultViewProperties(Baloo - Today) 
Compared values are not the same
   Actual   (m_model->count()): 19
   Expected (m_expectedModelCount): 18
   Loc: 
[/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)]
FAIL!  : PlacesItemModelTest::testDefaultViewProperties(Devices - Floppy) 
Compared values are not the same
   Actual   (m_model->count()): 19
   Expected (m_expectedModelCount): 18
   Loc: 
[/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)]
FAIL!  : PlacesItemModelTest::testClear() Compared values are not the same
   Actual   (m_model->count()): 19
   Expected (m_expectedModelCount): 18
   Loc: 
[/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)]
FAIL!  : PlacesItemModelTest::testHideItem() Compared values are not the 
same
   Actual   (m_model->count()): 19
   Expected (m_expectedModelCount): 18
   Loc: 
[/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)]
FAIL!  : PlacesItemModelTest::testSystemItems() Compared values are not the 
same
   Actual   (m_model->count()): 19
   Expected (m_expectedModelCount): 18
   Loc: 
[/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)]
FAIL!  : PlacesItemModelTest::testEditBookmark() Compared values are not 
the same
   Actual   (m_model->count()): 19
   Expected (m_expectedModelCount): 18
   Loc: 
[/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)]
FAIL!  : PlacesItemModelTest::testEditAfterCreation() Compared values are 
not the same
   Actual   (m_model->count()): 19
   Expected (m_expectedModelCount): 18
   Loc: 
[/home/andrew/kde/src/kde/applications/dolphin/src/tests/placesitemmodeltest.cpp(245)]
FAIL!  : PlacesItemModelTest::testEditMetadata() Compared values are not 
the same
   Actual   (m_model->count()): 19
   Expected (m_expectedModelCount): 18
   

D15739: [Places panel] Don't show Root by default

[Andrew Crouthamel]

acrouthamel added a comment.


  In D15739#331468 , @broulik wrote:
  
  > +1 it's an entry I always hide when I setup someone's computer
  >
  > > you can still get to / on your machine in one click using the appropriate 
disk entry on the bottom of the Places panel.
  >
  > Which I think shouldn't be there, but I'm too afraid of touching Solid's 
ignore rules ever again.
  
  
  You advocate for
  
  In D15739#356313 , @Codezela wrote:
  
  > In D15739#356310 , @ndavis wrote:
  >
  > > In D15739#356309 , @Codezela 
wrote:
  > >
  > > > i know that the icons size is adjustable i mean make the default more 
bigger first time u run dolphin this icons is so small "out of the box 
experience"
  > > >  the other thing  i mean we may keep the root partion icon on the 
devices sections and make it fixed position above all other mounted drives so 
even any hd mounted the root icons still top
  > > >  i hope i explain well
  > > >  sorry i know my English is not so good
  > >
  > >
  > > It's ok, I understand now. Those seem like good ideas.
  >
  >
  > sorry but i added some picture after
  >
  > do u see this is my places section
  >  F6398445: Screenshot_20181108_203553.png 

  >  can u tell me where is my root
  >  and the phone icon is on top
  
  
  It will have a new icon as Nate linked to earlier.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg, tcanabrava
Cc: Codezela, davidc, tcanabrava, ndavis, romangg, bruns, davidedmundson, 
abetts, svenmauch, broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham

D16633: Add root version of drive-harddisk

[Andrew Crouthamel]

acrouthamel added a comment.


  > I did not add drive-harddisk-home in this commit because it was simply too 
difficult to make an easily readable symbol for home on the 16px version.
  
  What about
  
~
  
  or
  
$
  
  ?
  
  Tilde would probably be the best, and you could exaggerate the waviness for 
the 16px version to make it legible.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16633

To: ndavis, #vdg, ngraham
Cc: acrouthamel, ngraham, kde-frameworks-devel, michaelh, bruns

Re: New contributor seeking guidance

[Andrew Crouthamel]

Thanks for wishing to get involved in KDE development!

We have the "junior-jobs" keyword in Bugzilla, which is a good place to start: 
https://bugs.kde.org/buglist.cgi?bug_status=UNCONFIRMED_status=CONFIRMED_status=ASSIGNED_status=REOPENED=junior-jobs%2C%20_type=allwords_id=1560073_format=advanced

The "usability" keyword is also a good option to look at, as a number of them 
are small jobs.

Feel free to respond back with any projects that catch your eye, and I'm sure 
we can help you out.

Andrew Crouthamel

‐‐‐ Original Message ‐‐‐
On Monday, October 29, 2018 9:15 AM, Remya Krishnan  
wrote:

> Hi all,
> I'm Remya, a CS sophomore and I would like to start contributing to KDE 
> projects. I'm a KDE user have been working on projects in C++/Qt for the past 
> few months. I would like to work towards beginner bugs. So, can anyone please 
> suggest me some beginner bugs to start with?
> With Regards,
> Remya Krishnan,
> [GitHub](https://github.com/krishremya)|[FOSS@Amrita](https://amfoss.in/accounts/165/)
> [Amrita University](https://www.amrita.edu/campus/amritapuri)

Re: Getting Started With KDE

[Andrew Crouthamel]

Hi Alex,

Thanks for wishing to get involved in KDE development! It's good to hear you 
read through the Get Involved/Development page, that's a good start. As 
mentioned, we do have the Junior Jobs tag as a good start as well: 
https://bugs.kde.org/buglist.cgi?bug_status=UNCONFIRMED_status=CONFIRMED_status=ASSIGNED_status=REOPENED=junior-jobs%2C%20_type=allwords_id=1560073_format=advanced

The "usability" keyword is also a good option to look at, as a number of them 
are small jobs.

Although I'm a newbie to things, I would be glad to help you get your dev 
environment set up, and point you in the right direction, based on your 
interests. Feel free to respond back with any projects that catch your eye, and 
I'm sure we can help you out.

Andrew Crouthamel

‐‐‐ Original Message ‐‐‐
On Tuesday, October 30, 2018 2:14 AM, 王金鑫  wrote:

> Hello Pranam,
>
> Thanks for the response. I wish I could be a part of the Google Code-In but 
> unfortunately I am too old for this activities.
>
> Actually I am a first-year graduate student in Computer Science. But I 
> started learning Computer Science since the master. So I have only less than 
> one year experience with Computer Science and with programming. Thus I want 
> to find a project not too complicated and still having bugs to start with in 
> KDE. If you know such a project, please inform me. My prior experience was 
> mainly in C and python. And I know the basic of C++ and Java.
>
> I have read the development page thoroughly and it says I can email to 
> current developer to get some guidance. That drives me to send this email. If 
> anyone could give me some guidance to start, I would appreciate it.
>
> Thank you,
> Alex Wang
>
> Pranam Lashkari  于2018年10月29日周一 下午7:05写道：
>
>> Hello,
>> If you are a school student and 13-17 years old right now then there is a 
>> good opportunity for you as Google Code-In is on going right now. Take part 
>> in it if you are eligible. There are byte size tasks for students who want 
>> to get involved in open source.
>>
>> But if you are not eligible then have a look here
>> https://community.kde.org/Get_Involved/development
>>
>> Thank you,
>> Pranam Lashkari
>>
>> On Tue 30 Oct, 2018, 7:30 AM 王金鑫,  wrote:
>>
>>> To whom it may concern,
>>>
>>> Hello, I am a student new to KDE community. I want to get involved with KDE 
>>> development to hone my programming skills and make contribution to KDE. But 
>>> I don't know what work I can do and where do I start. Could anyone give me 
>>> some guidance? It would be better if we can discuss directly. Thank you all!
>>>
>>> Yours,
>>> Alex

D15931: [Places panel] use more appropriate network icon

[Andrew Crouthamel]

acrouthamel added a comment.


  +1 from me, makes sense. I say that as a guy who stares at server racks all 
day.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15931

To: ngraham, #vdg
Cc: acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

[Andrew Crouthamel]

acrouthamel added a comment.


  What are the different possible emblems that can be applied automatically by 
the mount process?
  
  What if for small sizes, we just use simple shapes and colors. Like a green 
circle for mounted, and a yellow triangle for something else, and a red square 
for another state?
  
  I mention combining shapes and colors, for those who are color-blind.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D15866

To: ngraham, #frameworks, #dolphin, #vdg
Cc: acrouthamel, cfeck, broulik, ndavis, kde-frameworks-devel, michaelh, 
ngraham, bruns

D15739: [Places panel] Don't show Root by default

[Andrew Crouthamel]

acrouthamel added a comment.


  +1
  
  Seeing "Root" written as such, also makes me think of `/root`, which makes no 
sense to have there. The odds of needing quick access to `/` via Dolphin are 
extremely rare, and there is already a link anyway. People are used to clicking 
the primary drive to get to root dir.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg
Cc: acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns

D15644: Bug 395349

[Andrew Crouthamel]

acrouthamel added a comment.


  Yeah I think that is a mistake. D42047 which precedes the current diff, makes 
much more sense.

REVISION DETAIL
  https://phabricator.kde.org/D15644

To: lsartorelli, ngraham, #plasma, #frameworks
Cc: acrouthamel, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15406: Manually resize KCMUtilDialog to sizeHint()

[Andrew Crouthamel]

acrouthamel added a comment.


  I've tested this patch on my system. Although it does not resolve the scaling 
issue I experience, it does not cause any regressions I see. Ship it! :)

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15406

To: valeriymalov, #frameworks, ngraham
Cc: davidedmundson, acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns

D15406: Manually resize KCMUtilDialog to sizeHint()

[Andrew Crouthamel]

acrouthamel added a comment.


  In D15406#324063 , @ngraham wrote:
  
  > @acrouthamel, could you test this patch to make sure it doesn't regress 
anything for High DPI users?
  
  
  I can test it out tonight.

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15406

To: valeriymalov, #frameworks, ngraham
Cc: acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns

D15340: Add Solarized Light and Dark themes

[Andrew Crouthamel]

acrouthamel added a comment.


  I just realized the output was HTML. Ok, I can see what is going on now. If 
you could let me know if I am missing the "code-editor" though, that would be 
great!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15340

To: acrouthamel, #kate, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, 
genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars

D15340: Add Solarized Light and Dark themes

[Andrew Crouthamel]

acrouthamel added a comment.


  In D15340#322631 , @dhaumann wrote:
  
  > Sure, please use kdesrc-build as described here:
  >  https://community.kde.org/Guidelines_and_HOWTOs/Build_from_source
  >
  > Once setup, you can build everything by invoking ./kdesrc-build
  >  You can also pass a module to build:
  >
  >   ./kdesrc-build syntax-highlighting
  >   
  >
  > Ideally, you should build with dependencies:
  >
  >   ./kdesrc-build --include-dependencies syntax-highlighting
  >   
  >
  > If you need help, feel free to ask.
  
  
  Thanks for the help! So I have kdesrc-build setup, I pulled and built 
syntax-highlighting. The only bin file is kate-syntax-highlighter. So I checked 
the help on that and tried running:
  
kate-syntax-highlighter ~/Development/kdesrc-build/kdesrc-build-test.pl -t 
'Solarized Dark'
  
  Unfortunately I do not get any colorized output in Konsole. Any tips? Is this 
the new "code-editor" or am I still missing something?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15340

To: acrouthamel, #kate, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, 
genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars

D15340: Add Solarized Light and Dark themes

[Andrew Crouthamel]

acrouthamel added a comment.


  In D15340#322453 , @dhaumann wrote:
  
  > Btw, we forgot to add the themes to the Qt resource file, see also D15358 

  >
  > You can test the theme with the demo app in ksyntaxhighlighting: Go to the 
build-directory, then type ./bin/codeeditor 
  >  Then, you can switch the theme with the context menu.
  
  
  Could you give me a quick tutorial on how to build that? I tried cmake && 
make, but that's about as far as I got.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15340

To: acrouthamel, #kate, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, 
genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars

D15340: Add Solarized Light and Dark themes

[Andrew Crouthamel]

acrouthamel added a comment.


  Thanks, I'll make sure to add to that file if I add more themes.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15340

To: acrouthamel, #kate, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, 
genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars

D15340: Add Solarized Light and Dark themes

[Andrew Crouthamel]

acrouthamel added a comment.


  In D15340#322112 , @dhaumann wrote:
  
  > Looks good to me.
  >
  > Related: in order to have better unit testing, would you be willing to add 
a unit test to 
https://github.com/KDE/syntax-highlighting/blob/master/autotests/theme_test.cpp 
called
  >
  >   void testJsonData() { ... }
  >   
  >
  > This test would iterate over all themes via Qt Resources and check wether 
all 31 default text styles exist, and also check for the existence of the 
editor colors. This would help us to catch theme issues early in the future.
  >
  > Feel free to commit this patch now.
  
  
  Thanks! I would be glad to add that, but I honestly have no idea how to do 
so. I'm just starting out.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15340

To: acrouthamel, #kate, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, 
genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars

D15340: Add Solarized Light and Dark themes

[Andrew Crouthamel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:6d26c25fcfda: Add Solarized Light and Dark themes 
(authored by acrouthamel).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15340?vs=41179=41216

REVISION DETAIL
  https://phabricator.kde.org/D15340

AFFECTED FILES
  data/themes/solarized-dark.theme
  data/themes/solarized-light.theme

To: acrouthamel, #kate, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, 
genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel closed this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15337

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel added a comment.


  Thanks, I can. I'm getting an error in Arcanist, so let me diagnose that and 
I'll land it.

REPOSITORY
  R39 KTextEditor

BRANCH
  fix-solarized-colors

REVISION DETAIL
  https://phabricator.kde.org/D15337

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel added a comment.


  In D15337#322043 , @dhaumann wrote:
  
  > Solarized dark still only has 28 colors, right? Can you add the missing 
ones?
  
  
  Man, I'm looking forward to this JSON system in the future. LOL. Ok, fixed 
again. I counted all of them before commit.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15337

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel updated this revision to Diff 41181.
acrouthamel added a comment.


  - Added three missing definitions

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15337?vs=41177=41181

BRANCH
  fix-solarized-colors

REVISION DETAIL
  https://phabricator.kde.org/D15337

AFFECTED FILES
  src/data/kateschemarc
  src/data/katesyntaxhighlightingrc

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel edited the summary of this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15337

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel added a comment.


  @dhaumann, I've added these colors to KSyntaxHighlighting over here: D15340 


REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15337

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15340: Add Solarized Light and Dark themes

[Andrew Crouthamel]

acrouthamel edited the summary of this revision.
acrouthamel added reviewers: Kate, Framework: Syntax Highlighting.
acrouthamel added a project: Framework: Syntax Highlighting.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15340

To: acrouthamel, #kate, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, genethomas, 
kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D15340: Add Solarized Light and Dark themes

[Andrew Crouthamel]

acrouthamel created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
acrouthamel requested review of this revision.

REVISION SUMMARY
  This adds Solarized Light and Dark themes, with the same color scheme
  selected in Phabricator diff D15337 . 
This includes the themes here in
  KSyntaxHighlighting for when KTextEditor themes are replaced.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  add-solarized-themes

REVISION DETAIL
  https://phabricator.kde.org/D15340

AFFECTED FILES
  data/themes/solarized-dark.theme
  data/themes/solarized-light.theme

To: acrouthamel
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel marked 2 inline comments as done.
acrouthamel added a comment.


  You were right again. For some reason that Others= disappeared from my 
~/.config/katesyntaxhighlightingrc so I didn't notice it. Even though it was 
defined and displaying fine in the GUI. Weird.
  
  I also made a few more adjustments to Markers colors to adhere to the 
Solarized rules for gray colors. I think it is pretty set now, unless something 
else disappeared...

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15337

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel updated this revision to Diff 41177.
acrouthamel added a comment.


  - Fixed Others definition

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15337?vs=41176=41177

BRANCH
  fix-solarized-colors

REVISION DETAIL
  https://phabricator.kde.org/D15337

AFFECTED FILES
  src/data/kateschemarc
  src/data/katesyntaxhighlightingrc

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel updated this revision to Diff 41176.
acrouthamel added a comment.


  - Some Marker color tweaks to ensure Solarized interaction rule adherence

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15337?vs=41172=41176

BRANCH
  fix-solarized-colors

REVISION DETAIL
  https://phabricator.kde.org/D15337

AFFECTED FILES
  src/data/kateschemarc
  src/data/katesyntaxhighlightingrc

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel updated this revision to Diff 41172.
acrouthamel added a comment.


  - Fixed Light scheme Error color

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15337?vs=41171=41172

BRANCH
  fix-solarized-colors

REVISION DETAIL
  https://phabricator.kde.org/D15337

AFFECTED FILES
  src/data/kateschemarc
  src/data/katesyntaxhighlightingrc

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel updated this revision to Diff 41171.
acrouthamel marked an inline comment as done.
acrouthamel added a comment.


  - Solarized Light Region Marker fix and small Dark tweak.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15337?vs=41170=41171

BRANCH
  fix-solarized-colors

REVISION DETAIL
  https://phabricator.kde.org/D15337

AFFECTED FILES
  src/data/kateschemarc
  src/data/katesyntaxhighlightingrc

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel marked an inline comment as done.
acrouthamel added a comment.


  I've fixed the section. I'm actually working on the KSyntaxHighlighting 
themes now, you'll see those in another patch.

INLINE COMMENTS

> dhaumann wrote in katesyntaxhighlightingrc:104
> Am I mistaken, or did you remove the section here?

No, you're right, that's a mistake. I just fixed it.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15337

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel updated this revision to Diff 41170.
acrouthamel added a comment.


  - Fixed section code

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15337?vs=41168=41170

BRANCH
  fix-solarized-colors

REVISION DETAIL
  https://phabricator.kde.org/D15337

AFFECTED FILES
  src/data/kateschemarc
  src/data/katesyntaxhighlightingrc

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel edited the summary of this revision.
acrouthamel edited the test plan for this revision.
acrouthamel added reviewers: Kate, KTextEditor, Framework: Syntax Highlighting.
acrouthamel added a project: KTextEditor.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15337

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
acrouthamel requested review of this revision.

REVISION SUMMARY
  Solarized Light contrast was low. Upon investigation it was determined
  much of the color scheme did not follow Solarized base 16 colors or
  rules. Color scheme for both Dark and Light variants were adjusted to
  match the latest Solarized color scheme release palette and color
  interaction rules. Color schemes were also matched closely to the
  Vim color scheme created by the original Solarized author.

TEST PLAN
  Open Kate with new rc files and inspect the Color settings.

REPOSITORY
  R39 KTextEditor

BRANCH
  fix-solarized-colors

REVISION DETAIL
  https://phabricator.kde.org/D15337

AFFECTED FILES
  src/data/kateschemarc
  src/data/katesyntaxhighlightingrc

To: acrouthamel
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15213: Provide icons for 2x scaling

[Andrew Crouthamel]

acrouthamel added a comment.


  I love all of these HIDPI fixes lately.

REPOSITORY
  R266 Breeze Icons

BRANCH
  2xIcons

REVISION DETAIL
  https://phabricator.kde.org/D15213

To: rizzitello, #vdg, #plasma, broulik, ngraham
Cc: acrouthamel, ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D11768: Add Desktop and Downloads to the default list of Places

[Andrew Crouthamel]

acrouthamel added a comment.
Herald added a subscriber: kde-frameworks-devel.


  Hey Nate, is there a reason why Documents was not added with this patch? I 
always end up adding it. I was reading through D10245#201638 
 and the discussion seemed in favor 
of adding it, along with the Desktop and Downloads.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11768

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg, progwolff
Cc: kde-frameworks-devel, acrouthamel, abetts, huoni, markg, fabiank, 
progwolff, broulik, michaelh, ngraham, bruns

D6313: Support Icon Scale from Icon naming specification 0.13

[Andrew Crouthamel]

acrouthamel added a comment.


  In D6313#239212 , @cfeck wrote:
  
  > In other words, the icon theme designer can now decide if he makes HiDPI 
only bigger or more detailed by symlinking to either the less detailed or the 
more detailed svg, without duplicating the icon files?
  
  
  Exactly, that is correct. They could also make special icons if they desire, 
just like the other folders (32x32, 64x64, etc).

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, #frameworks, ragreen, Pitel, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D6313: Support Icon Scale from Icon naming specification 0.13

[Andrew Crouthamel]

acrouthamel added a comment.


  @ngraham, in the initial description @broulik forced a @2x folder via symlink 
to test. Otherwise no change will be observed. :)

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, #frameworks, ragreen, Pitel, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D6313: Support Icon Scale from Icon naming specification 0.13

[Andrew Crouthamel]

acrouthamel added a comment.


  In D6313#238697 , @rkflx wrote:
  
  > In D6313#238605 , @acrouthamel 
wrote:
  >
  > > @2x-compatible
  >
  >
  > How will this work for 4x / 2.7x / 1.4x / etc. scaling? Of course we could 
define a point where it snaps from 1x to 2x icons, but eventually this approach 
would also need 4x + larger versions…
  
  
  It looks like the freedesktop spec 

 has `Scale` listed only as an integer. So that would need updating first in my 
opinion. So 4x would be possible, but decimal scaling would need to be snapped 
for now.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, #frameworks, ragreen, Pitel, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D6313: Support Icon Scale from Icon naming specification 0.13

[Andrew Crouthamel]

acrouthamel added a comment.


  I think both of us missed this part at the bottom of @broulik's description:
  
  > This way you designers can now create dedicated 2x SVGs for those usecases, 
ie. we can have a 16px icon as well as a 16px@2x icon rather than it just 
taking the 32px icon which might not fit. In case a 16px@2x icon is not present 
it will load the 32px icon instead as it did before. This way one could even 
create a high dpi Oxygen theme.
  
  So #Breeze  will show the hi-res 
icons like it does now since it doesn't have any @2x folders or symlinks (an 
example of that can be found in Papirus 
).
 Moving forward, #Breeze  could create 
these @2x folders, populating them with beautiful Hi-DPI-acceptable icons, or 
whatever they want, to ensure interface consistency.
  
  But for now, it would be status-quo, even with this patch committed. So no 
one will notice, except those of us with @2x-compatible, 3rd party icon themes 
right now.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, #frameworks, ragreen, Pitel, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D6313: Support Icon Scale from Icon naming specification 0.13

[Andrew Crouthamel]

acrouthamel added a comment.


  I'm just saying if you prefer colored over symbolic line art, that is 
something for #Breeze  or #vdg 
 to work out. Not that they are really 
taking advantage of anything.
  
  The bug here is that the system isn't aware of scaling at the moment. So the 
icons it **should** be displaying are the symbolic ones, regardless of whether 
you are running HiDPI or not (and whether you like them or not). That's because 
the menu should be displaying 24x24 or 32x32 icons, or whatever it should be. 
But in HiDPI environments it is doubling that (or whatever scale you have set), 
and displaying icons from high-res folders such as 96x96, where they shouldn't 
be displayed.
  
  This patch fixes that issue and forces the system to load the correct size, 
as originally intended. Menus and stuff shouldn't be loading icons from these 
high-res folders. Symbolic vs. colored is a design thing to work out separately.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, #frameworks, ragreen, Pitel, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D11838: Turn on line numbers by default

[Andrew Crouthamel]

acrouthamel added a comment.


  I wouldn't mind seeing it on in KDevelop. From using it though, I really 
don't need them much in it. Especially since when debugging I can just click on 
an error and it will take me to the line.
  
  Kate would be nice to have it on. KWrite, probably not, since it's supposed 
to be "lighter" like Notepad.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11838

To: ngraham, #kate, #ktexteditor, dhaumann, mludwig
Cc: acrouthamel, brauch, mludwig, kfunk, dhaumann, #frameworks, michaelh, 
kevinapavew, ngraham, demsking, cullmann, sars

D6313: Support Icon Scale from Icon naming specification 0.13

[Andrew Crouthamel]

acrouthamel added a comment.


  @ngraham and @hein, while I agree that in some instances I like the colored 
hi-res icons showing, this issue causes a mixture of icons to be displayed 
depending on the app. The examples here show a nice homogeneous selection of 
icons that change from A to B, so I can see why you like the colored versions 
better. But in diffs such as D11669  and 
D10688 , you can see how there are now 
colored icons where they were once symbolic, mixed within the interface.
  
  This really boils down to an issue with #Breeze 
, as it has special symbolic versions 
in the "low-res" folders, and fancy colored icons in the "hi-res" folders. Some 
other icon themes do not do this, and rather use just one generic icon for all 
sizes, so the issue really is not prevalent there. My opinion is that if you 
prefer the colored icons, you should recommend to #Breeze 
 that they phase out the symbolic 
versions, or create new colored icons for everything, to place into the 
"hi-res" folders, so they all show as colored for those running HiDPI/scaling. 
Otherwise we are left with inconsistent interfaces for users.
  
  This change fixes a legitimate issue with an implemented freedesktop 
standard, so I hope it gets approved and committed.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, #frameworks, ragreen, Pitel, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D11390: new icons for disconnected/disabled devices

[Andrew Crouthamel]

acrouthamel added a comment.


  They look great!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11390

To: mart, #plasma, #vdg, andreask
Cc: acrouthamel, andreask, #frameworks, michaelh, ngraham

D6313: Support Icon Scale from Icon naming specification 0.13

[Andrew Crouthamel]

acrouthamel added a comment.


  Thanks for working on this again, it really helps. :)

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D6313: WIP: Support device pixel ratio in icon loader and engine

[Andrew Crouthamel]

acrouthamel added a comment.


  Hey there, any movement on this? I've been submitting some patches to fix 
icon scaling in apps and have noticed how they switch from monochrome to 
colored (hires) versions when fixed. Getting the underlying issue fixed would 
be great as more people buy HiDPI/Retina displays and run with scaling.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

Re: OneTimePass-Plasma

[Andrew Crouthamel]

Cool idea! I hope some of the experienced devs can check it out. :)


---
Andrew Crouthamel

On Fri, Mar 2, 2018 at 5:24 AM, James Augustus Zuccon <zuc...@gmail.com>
wrote:

> Hi all,
>
> I've been working on a Google Authenticator-like Application for Plasma
> (QML/C++). It also comes with a KRunner that can be triggered with "otp
> searchterm".
>
> It uses KWallet to store passwords and liboath to generate the token (so a
> message is displayed if the KWallet Subsystem is disabled).
>
> So far, I think the build is relatively stable, but would someone be
> willing to view the code and suggest improvements where I've failed to
> follow KDE conventions?
>
> There are quite a few additions I would like to make to this (QR Scanner)
> and quite a few other applications I'd like to work on for KDE in
> anticipation of Plasma Mobile.
>
> https://github.com/jimtendo/onetimepass-plasma
>
> Thank you.
>