D7563: Add privilegeExecution field to file protocol description

[Chinmoy Ranjan Pradhan]

chinmoyr requested changes to this revision.
chinmoyr added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> file_unix.cpp:1331
> +KAuth::Action::DetailsMap details;
> +details.insert(KAuth::Action::AuthDetail::DetailMessage, 
> QStringLiteral("Authentication is required to perform this action."));
> +execAction.setDetailsV2(details);

We need to set a different message for each action.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7563

To: ngraham, #frameworks, dfaure, chinmoyr
Cc: kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, elvisangelaccio, 
LeGast00n, cblack, michaelh, bruns

D7563: Add privilegeExecution field to file protocol description

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 80341.
chinmoyr marked an inline comment as done.
chinmoyr added a comment.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.


  Rebased on master.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7563?vs=18821=80341

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7563

AFFECTED FILES
  src/core/kfileitemlistproperties.cpp
  src/core/kprotocolinfo.cpp
  src/core/kprotocolinfo_p.h
  src/core/kprotocolmanager.cpp
  src/core/kprotocolmanager.h
  src/ioslaves/file/file.json

To: chinmoyr, #frameworks, dfaure
Cc: kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, elvisangelaccio, 
LeGast00n, cblack, michaelh, bruns

D21783: Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  In D21783#581781 , @dfaure wrote:
  
  > @chinmoyr This change also breaks the corresponding unittest in CI, please 
take a look.
  >  
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/368/testReport/junit/projectroot/autotests/kiocore_privilegejobtest/
  
  
  Fixed. https://commits.kde.org/kio/a5b669263573dd7976c14f06b5c13f4da55dc6f0

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: bcooksley, mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D21783: Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:82aae02e2114: Show more details in warning dialog shown 
before starting a privileged operation (authored by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21783?vs=71754=71981

REVISION DETAIL
  https://phabricator.kde.org/D21783

AFFECTED FILES
  autotests/kiotesthelper.h
  src/core/jobuidelegateextension.h
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/core/slaveinterface.cpp
  src/core/slaveinterface_p.h
  src/ioslaves/file/file_unix.cpp
  src/widgets/jobuidelegate.cpp
  src/widgets/jobuidelegate.h

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

chinmoyr added inline comments.

INLINE COMMENTS

> dfaure wrote in slavebase.h:262
> Does this break API docs generation? Suddenly the /** ... */ comment is 
> separated from the enum.

The comment didn't affect the doc generation. But the placement was awkward so 
I changed it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 71754.
chinmoyr added a comment.


  updated kf5 version.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21783?vs=71041=71754

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21783

AFFECTED FILES
  autotests/kiotesthelper.h
  src/core/jobuidelegateextension.h
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/core/slaveinterface.cpp
  src/core/slaveinterface_p.h
  src/ioslaves/file/file_unix.cpp
  src/widgets/jobuidelegate.cpp
  src/widgets/jobuidelegate.h

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 71041.
chinmoyr added a comment.


  Rebased, compiled and tested. Changes work as expected.
  Double checked file_unix.cpp. Would be a shame if it happens yet again.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21783?vs=71025=71041

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21783

AFFECTED FILES
  autotests/kiotesthelper.h
  src/core/jobuidelegateextension.h
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/core/slaveinterface.cpp
  src/core/slaveinterface_p.h
  src/ioslaves/file/file_unix.cpp
  src/widgets/jobuidelegate.cpp
  src/widgets/jobuidelegate.h

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

chinmoyr added inline comments.

INLINE COMMENTS

> dfaure wrote in slaveinterface_p.h:56
> Please explain how, for when the time comes (in case you're not around to do 
> it).

Removing each of its occurence (of which there are 3) and the surrounding `if`. 
 I will add comments where its needed to be removed.

> dfaure wrote in jobuidelegate.h:155
> what would be the proper API you have in mind?

I think adding a QString parameter for operation details should be sufficient. 
Then the API should be kept in sync with SlaveBase, SalveInterface, and 
JobUiDelegateExtension.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 71025.
chinmoyr marked 10 inline comments as done.
chinmoyr added a comment.


  Addressed the issues.
  Annotated code to be removed in KF6.
  My build env is outdated so I couldn't compile the new depracation macro. 
Copied as it is.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21783?vs=70914=71025

BRANCH
  arcpatch-D21783

REVISION DETAIL
  https://phabricator.kde.org/D21783

AFFECTED FILES
  autotests/kiotesthelper.h
  src/core/jobuidelegateextension.h
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/core/slaveinterface.cpp
  src/core/slaveinterface_p.h
  src/ioslaves/file/file_unix.cpp
  src/widgets/jobuidelegate.cpp
  src/widgets/jobuidelegate.h

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

chinmoyr added inline comments.

INLINE COMMENTS

> dfaure wrote in jobuidelegateextension.h:279
> Sorry, you can't add a new virtual method to an exported+installed class.
> 
> BIC rules (where "rules" is a noun, not a verb...) ;-)
> 
> Possible solutions:
> 
> - creating a new, separate, type of extension, say 
> `JobUiDelegatePrivilegeExtension`. This requires adding another defautFoo() 
> and setFoo() method like this file has at the bottom.
> - creating a "JobUiDelegateExtensionV2", derived from JobUiDelegateExtension, 
> with a KF6 TODO to merge it with JobUiDelegateExtension. Then you can 
> dynamic_cast the result of `defaultJobUiDelegateExtension()` to V2 to see if 
> the extension implements V2.

> Sorry, you can't add a new virtual method to an exported+installed class.
> 
> BIC rules (where "rules" is a noun, not a verb...) ;-)

LOL! Either way it's true.

> Possible solutions:
> 
> *creating a new, separate, type of extension, say 
> JobUiDelegatePrivilegeExtension. This requires adding another defautFoo() and 
> setFoo() >method like this file has at the bottom.
> *creating a "JobUiDelegateExtensionV2", derived from JobUiDelegateExtension, 
> with a KF6 TODO to merge it with JobUiDelegateExtension. >Then you can 
> dynamic_cast the result of defaultJobUiDelegateExtension() to V2 to see if 
> the extension implements V2.

IMO trying to pass job details from SlaveBase to KMessageBox without breaking 
compatibility would result in an unnecessarily large patch.
So I went ahead with reusing sslMetaData which was hacky but the resulting 
patch wasn't an eye-sore.  I hope we can keep this and later add proper API in 
KF6.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 70914.
chinmoyr marked 4 inline comments as done.
chinmoyr added a comment.


  Addressed the issues.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21783?vs=67955=70914

BRANCH
  arcpatch-D21783

REVISION DETAIL
  https://phabricator.kde.org/D21783

AFFECTED FILES
  autotests/kiotesthelper.h
  src/core/jobuidelegateextension.h
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/core/slaveinterface.cpp
  src/core/slaveinterface.h
  src/core/slaveinterface_p.h
  src/ioslaves/file/file_unix.cpp
  src/widgets/jobuidelegate.cpp
  src/widgets/jobuidelegate.h

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

chinmoyr added inline comments.

INLINE COMMENTS

> dfaure wrote in slavebase.h:964
> Missing "m" prefix like the other members, but wait isn't this BIC? 
> Adding a new member to an exported class certainly is. This needs to go into 
> the SlaveBasePrivate class instead.

Since we need details from the ioslave somehow, I deprecated 
requestPrivilegeOperation() in favor of an overload that accepts details as 
argument.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 67955.
chinmoyr marked 3 inline comments as done.
chinmoyr added a comment.


  Addressed the comments.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21783?vs=59738=67955

BRANCH
  arcpatch-D21783

REVISION DETAIL
  https://phabricator.kde.org/D21783

AFFECTED FILES
  autotests/kiotesthelper.h
  src/core/jobuidelegateextension.h
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/core/slaveinterface.cpp
  src/core/slaveinterface.h
  src/core/usernotificationhandler.cpp
  src/core/usernotificationhandler_p.h
  src/ioslaves/file/file_unix.cpp
  src/widgets/jobuidelegate.cpp
  src/widgets/jobuidelegate.h

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23194: Making FileJob behave consistently.

[Chinmoy Ranjan Pradhan]

chinmoyr accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  ConsistentRead (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23194

To: feverfew, dfaure, fvogt, chinmoyr, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21795: [KAuth] Add support for action details in Polkit1 backend.

[Chinmoy Ranjan Pradhan]

chinmoyr added inline comments.

INLINE COMMENTS

> sitter wrote in Polkit1Backend.cpp:193
> looks to me this was only added 4 months ago. so this would probably require 
> a version bump. seeing as we are fairly conservative with frameworks' 
> requirements it may be better to `if version>=whatevs` the call.

I am not sure what to do here. The commit didn't really change the version and 
it is not of KF5 either.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D21795

To: chinmoyr, apol, bruns, davidedmundson, #frameworks, dfaure, cfeck, sitter
Cc: ngraham, sitter, mreeves, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D17737: [CopyJob] Create clones in btrf/xfs mount

[Chinmoy Ranjan Pradhan]

chinmoyr edited reviewers, added: thiago, ossi; removed: davidedmundson.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17737

To: chinmoyr, dfaure, #frameworks, thiago, ossi, davidedmundson
Cc: ngraham, bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D21795: [KAuth] Add support for action details in Polkit1 backend.

[Chinmoy Ranjan Pradhan]

chinmoyr added inline comments.

INLINE COMMENTS

> sitter wrote in AuthBackend.h:61
> I didn't check super carefully but at a glance the backend api is not public 
> API so we could probably refactor this right now already.
> 
> Also, shouldn't the callerID be a const ref?

the mac backend modifies `callerID` later on so I think it was deliberately 
kept here.

> sitter wrote in kauthaction.h:246
> Should the old functions maybe be marked deprecated?

I deprecated it. Except the unit tests this isn't used anywhere in the backend.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D21795

To: chinmoyr, apol, bruns, davidedmundson, #frameworks, dfaure, cfeck, sitter
Cc: ngraham, sitter, mreeves, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21795: [KAuth] Add support for action details in Polkit1 backend.

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 63880.
chinmoyr marked 6 inline comments as done.
chinmoyr added a comment.


  Addressed comments.

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21795?vs=59775=63880

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21795

AFFECTED FILES
  autotests/TestBackend.cpp
  autotests/TestBackend.h
  src/AuthBackend.cpp
  src/AuthBackend.h
  src/HelperProxy.h
  src/backends/dbus/DBusHelperProxy.cpp
  src/backends/dbus/DBusHelperProxy.h
  src/backends/dbus/org.kde.kf5auth.xml
  src/backends/fake/FakeBackend.cpp
  src/backends/fake/FakeBackend.h
  src/backends/fakehelper/FakeHelperProxy.cpp
  src/backends/fakehelper/FakeHelperProxy.h
  src/backends/mac/AuthServicesBackend.cpp
  src/backends/mac/AuthServicesBackend.h
  src/backends/policykit/PolicyKitBackend.cpp
  src/backends/policykit/PolicyKitBackend.h
  src/backends/polkit-1/Polkit1Backend.cpp
  src/backends/polkit-1/Polkit1Backend.h
  src/kauthaction.cpp
  src/kauthaction.h
  src/kauthexecutejob.cpp

To: chinmoyr, apol, bruns, davidedmundson, #frameworks, dfaure, cfeck, sitter
Cc: ngraham, sitter, mreeves, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23194: Making FileJob behave consistently.

[Chinmoy Ranjan Pradhan]

chinmoyr requested changes to this revision.
chinmoyr added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> filejob.cpp:181
> +slaveDone();
> +// Scheduler::doJob(this);
> +q->emitResult();

Nitpick; spacing gotcha

> filejob.h:48
>  /**
> - * Read block
> + * This function attempts to read up to \p size bytes from the URL 
> passed to
> + * KIO::open() and returns the bytes received via the data() signal.

Document the methods in SlaveBase as well.

> slavebase.h:107
> + * @see close()
> + */
> +void closed();

@since 5.62

> slaveinterface.h:90
> +MSG_SLAVE_STATUS_V2,
> +MSG_CLOSED
>  // add new ones here once a release is done, to avoid breaking binary 
> compatibility

Nitpick; add a , 
Next time someone adds an enum it will change only one line.

> file.cpp:520
>  
> -if (!res.isEmpty()) {
> -data(res);
> -bytes -= res.size();
> -} else {
> -// empty array designates eof
> -data(QByteArray());
> -if (!mFile->atEnd()) {
> -error(KIO::ERR_CANNOT_READ, mFile->fileName());
> -close();
> -}
> -break;
> -}
> -if (bytes <= 0) {
> -break;
> -}
> +qint64 bytesRead = mFile->read(buffer.data(), bytes);
> +

A loop is required here. The docs don't really specify anything about reading 
data in one go.

> file.cpp:584
> +closeWithoutFinish();
> +closed();
>  }

missing a finished() here

> file.h:117
> +// Close without calling finish(). Use this to close after error.
> +void closeWithoutFinish();
> +

Nitpick; why not just closeFile() ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23194

To: feverfew, dfaure, fvogt, chinmoyr, apol
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23159: Prevent error() being emitted when purposefully reading 0 bytes

[Chinmoy Ranjan Pradhan]

chinmoyr added inline comments.

INLINE COMMENTS

> file.cpp:524
>  while (true) {
>  QByteArray res = mFile->read(bytes);
>  

This doesn't support error reporting. Why not refactor this loop using 
read(char *, qint64)? I believe you can accommodate your changes inside the 
loop cleanly then.

> file.cpp:538
>  }
>  if (bytes <= 0) {
>  break;

here `bytes` being negative should be an error..no?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23159

To: feverfew, dfaure, fvogt, chinmoyr
Cc: apol, kfm-devel, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22708: [WIP] Add a kded module infra for fuse mount services

[Chinmoy Ranjan Pradhan]

chinmoyr abandoned this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22708

To: chinmoyr
Cc: andriusr, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D22708: [WIP] Add a kded module infra for fuse mount services

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 62469.
chinmoyr added a comment.


  Added KRun changes

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22708?vs=62453=62469

BRANCH
  monitorprotocol

REVISION DETAIL
  https://phabricator.kde.org/D22708

AFFECTED FILES
  src/CMakeLists.txt
  src/core/kdiskfreespaceinfo.cpp
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file_unix.cpp
  src/kcms/kio/CMakeLists.txt
  src/kcms/kio/fusemanager.cpp
  src/kcms/kio/fusemanager.desktop
  src/kcms/kio/fusemanager.h
  src/kcms/kio/fusemanager.ui
  src/kcms/kio/fuseserviceselector.ui
  src/kcms/kio/main.cpp
  src/mountserviced/CMakeLists.txt
  src/mountserviced/mountservicemanager.cpp
  src/mountserviced/mountservicemanager.desktop
  src/mountserviced/mountservicemanager.h
  src/mountserviced/org.kde.kio.MountServiceManager.xml
  src/widgets/CMakeLists.txt
  src/widgets/krun.cpp

To: chinmoyr
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22708: [WIP] Add a kded module infra for fuse mount services

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  This module watches the install directories of kded modules and curates a 
list of modules having plugin Category=MountService.
  This list will be used by a kio kcm which will allow users to configure mount 
service for remote protocol.
  Once loaded this module can be used in KIOSlave::listDir to mount the url and 
in KRun::resolveUrls to convert the
  remote URL to local URL.

REPOSITORY
  R241 KIO

BRANCH
  monitorprotocol

REVISION DETAIL
  https://phabricator.kde.org/D22708

AFFECTED FILES
  src/CMakeLists.txt
  src/core/kdiskfreespaceinfo.cpp
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file_unix.cpp
  src/kcms/kio/CMakeLists.txt
  src/kcms/kio/fusemanager.cpp
  src/kcms/kio/fusemanager.desktop
  src/kcms/kio/fusemanager.h
  src/kcms/kio/fusemanager.ui
  src/kcms/kio/fuseserviceselector.ui
  src/kcms/kio/main.cpp
  src/mountserviced/CMakeLists.txt
  src/mountserviced/mountservicemanager.cpp
  src/mountserviced/mountservicemanager.desktop
  src/mountserviced/mountservicemanager.h
  src/mountserviced/org.kde.kio.MountServiceManager.xml

To: chinmoyr
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22555: [RFC] Add a kded module to manage various available fuse mount services

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added a reviewer: fvogt.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  This module watches the install directories of kded modules and curates a 
list of modules having plugin Category=MountService.
  This list will be used by a kio kcm which will allow users to configure mount 
service for remote protocol.
  Once loaded this module can be used in KIOSlave::listDir to mount the url and 
in KRun::resolveUrls to convert the
  remote URL to local URL.

REPOSITORY
  R241 KIO

BRANCH
  monitorprotocol

REVISION DETAIL
  https://phabricator.kde.org/D22555

AFFECTED FILES
  src/CMakeLists.txt
  src/mountserviced/CMakeLists.txt
  src/mountserviced/mountservicemanager.cpp
  src/mountserviced/mountservicemanager.desktop
  src/mountserviced/mountservicemanager.h
  src/mountserviced/org.kde.kio.MountServiceManager.xml

To: chinmoyr, fvogt
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D21782: Add a warning dialog with details, continue, and cancel button

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:653192440bf8: Add a warning dialog with a collapsible 
details section. (authored by chinmoyr).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21782?vs=60264=62033#toc

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21782?vs=60264=62033

REVISION DETAIL
  https://phabricator.kde.org/D21782

AFFECTED FILES
  src/kmessagebox.cpp
  src/kmessagebox.h

To: chinmoyr, #vdg, #frameworks, dfaure, ngraham, apol
Cc: elvisangelaccio, mreeves, ngraham, GB_2, kde-frameworks-devel, LeGast00n, 
sbergeron, michaelh, bruns

D21782: Add a warning dialog with details, continue, and cancel button

[Chinmoy Ranjan Pradhan]

chinmoyr edited the summary of this revision.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21782

To: chinmoyr, #vdg, #frameworks, dfaure, ngraham, apol
Cc: elvisangelaccio, mreeves, ngraham, GB_2, kde-frameworks-devel, LeGast00n, 
sbergeron, michaelh, bruns

D14467: Auth Support: Drop privileges if target is not owned by root

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  In D14467#483848 , @bcooksley 
wrote:
  
  > It would appear that the commit of this change disturbed somethng with 
FreeBSD builds - see 
https://build.kde.org/view/Failing/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/135/
  >
  > Could someone take a look into that please?
  
  
  https://commits.kde.org/kio/91901a64adcaab9e444bb67a75bebd2ea77c3db2 should 
fix this.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14467

To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin, maltek
Cc: bcooksley, maltek, mreeves, mgerstner, fvogt, kde-frameworks-devel, 
LeGast00n, michaelh, ngraham, bruns

D21782: Add a warning dialog with details, continue, and cancel button

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 60264.
chinmoyr added a comment.


  Updated the implementation.

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21782?vs=59735=60264

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21782

AFFECTED FILES
  src/kmessagebox.cpp
  src/kmessagebox.h

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, GB_2, kde-frameworks-devel, LeGast00n, michaelh, bruns

D14467: Auth Support: Drop privileges if target is not owned by root

[Chinmoy Ranjan Pradhan]

chinmoyr edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14467

To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin, maltek
Cc: maltek, mreeves, mgerstner, fvogt, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham, bruns

D14467: Auth Support: Drop privileges if target is not owned by root

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:efeede07c8eb: Auth Support: Drop privileges if target is 
not owned by root (authored by chinmoyr).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D14467?vs=60249=60255#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14467?vs=60249=60255

REVISION DETAIL
  https://phabricator.kde.org/D14467

AFFECTED FILES
  src/ioslaves/file/file_p.h
  src/ioslaves/file/kauth/filehelper.cpp

To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin, maltek
Cc: maltek, mreeves, mgerstner, fvogt, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham, bruns

D14467: Auth Support: Drop privileges if target is not owned by root

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  Thanks for your help!

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D14467

REVISION DETAIL
  https://phabricator.kde.org/D14467

To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin, maltek
Cc: maltek, mreeves, mgerstner, fvogt, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham, bruns

D21953: Replace "Details" button with KCollapsibleGroupBox

[Chinmoy Ranjan Pradhan]

chinmoyr closed this revision.
chinmoyr added a comment.


  
https://commits.kde.org/kwidgetsaddons/89606c1ecb571e3ae9137cab18ceadeff57666e3

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D21953

To: chinmoyr, #vdg, ngraham, GB_2
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21953: Replace "Details" button with KCollapsibleGroupBox

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 60250.
chinmoyr added a comment.


  "More Details" -> "Details"

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21953?vs=60198=60250

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21953

AFFECTED FILES
  src/kmessagebox.cpp

To: chinmoyr, #vdg, ngraham, GB_2
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D14467: Auth Support: Drop privileges if target is not owned by root

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 60249.
chinmoyr added a comment.


  Separated (l)chown since it's to be done with elavated privileges.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14467?vs=60215=60249

BRANCH
  arcpatch-D14467

REVISION DETAIL
  https://phabricator.kde.org/D14467

AFFECTED FILES
  src/ioslaves/file/file_p.h
  src/ioslaves/file/kauth/filehelper.cpp

To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin, maltek
Cc: maltek, mreeves, mgerstner, fvogt, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham, bruns

D14467: Auth Support: Drop privileges if target is not owned by root

[Chinmoy Ranjan Pradhan]

chinmoyr added inline comments.

INLINE COMMENTS

> maltek wrote in filehelper.cpp:133
> For `chown`, dropping privileges here means that the `chown` later can't 
> succeed - it's not possible to 'gift' a file to another user. I think it 
> should be handled more like `DEL/RMDIR/MKDIR` etc.

Ah! Since I was testing inside /opt I didn't notice. I think the order here 
should be: drop privilege -> change grp -> gain privilege -> change user.

> maltek wrote in filehelper.cpp:150
> I just realized that this wouldn't allow changing the owner of symbolic 
> links. The way to go here is `lchown`.

Do you think it'll be a bad idea to skip the case for symlinks in utime, chmod, 
chown, for now? Right now there's no code in KIO that requires these operations 
to be performed on the link itself.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14467

To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin, maltek
Cc: maltek, mreeves, mgerstner, fvogt, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham, bruns

D14467: Auth Support: Drop privileges if target is not owned by root

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 60215.
chinmoyr marked 6 inline comments as done.
chinmoyr added a comment.


  Addresed the issues.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14467?vs=60167=60215

BRANCH
  arcpatch-D14467

REVISION DETAIL
  https://phabricator.kde.org/D14467

AFFECTED FILES
  src/ioslaves/file/file_p.h
  src/ioslaves/file/kauth/filehelper.cpp

To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin, maltek
Cc: maltek, mreeves, mgerstner, fvogt, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham, bruns

D21953: Replace "Details" button with KCollapsibleGroupBox

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added reviewers: VDG, ngraham, GB_2.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  Remove "Details" button and use KCollapsibleGroupBox to display more details.
  
  F6920180: error detailed 
  
  F6920182: warning detailed 
  
  F6920185: warning detailed expanded 

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21953

AFFECTED FILES
  src/kmessagebox.cpp

To: chinmoyr, #vdg, ngraham, GB_2
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D14467: Auth Support: Drop privileges if target is not owned by root

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 60167.
chinmoyr marked 5 inline comments as done.
chinmoyr added a comment.


  Thanks @maltek. I've fixed all the issues.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14467?vs=59319=60167

BRANCH
  arcpatch-D14467

REVISION DETAIL
  https://phabricator.kde.org/D14467

AFFECTED FILES
  src/ioslaves/file/file_p.h
  src/ioslaves/file/kauth/filehelper.cpp

To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin, maltek
Cc: maltek, mreeves, mgerstner, fvogt, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham, bruns

D21882: RFC: [CopyJob] Batch reporting processed amount

[Chinmoy Ranjan Pradhan]

chinmoyr accepted this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21882

To: broulik, #frameworks, dfaure, chinmoyr, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

chinmoyr planned changes to this revision.
chinmoyr added a comment.


  TODO
  
  - Change the UI of the warning dialog
  - We still need more details

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21795: [KAuth] Add support for action details in Polkit1 backend.

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added reviewers: apol, bruns, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  KAuth action has a setDetail method. This can be used to override the message 
shown in the authentication dialog.
  However, until now none of the backends actually used it. So this patch;
  
  - Overloads setDetail method. The overload accepts details in a QMap.
  - Makes use of the details in polkit1 backend.

REPOSITORY
  R283 KAuth

BRANCH
  arcpatch-D18845

REVISION DETAIL
  https://phabricator.kde.org/D21795

AFFECTED FILES
  autotests/TestBackend.cpp
  autotests/TestBackend.h
  src/AuthBackend.h
  src/HelperProxy.h
  src/backends/dbus/DBusHelperProxy.cpp
  src/backends/dbus/DBusHelperProxy.h
  src/backends/dbus/org.kde.kf5auth.xml
  src/backends/fake/FakeBackend.cpp
  src/backends/fake/FakeBackend.h
  src/backends/fakehelper/FakeHelperProxy.cpp
  src/backends/fakehelper/FakeHelperProxy.h
  src/backends/mac/AuthServicesBackend.cpp
  src/backends/mac/AuthServicesBackend.h
  src/backends/policykit/PolicyKitBackend.cpp
  src/backends/policykit/PolicyKitBackend.h
  src/backends/polkit-1/Polkit1Backend.cpp
  src/backends/polkit-1/Polkit1Backend.h
  src/kauthaction.cpp
  src/kauthaction.h
  src/kauthexecutejob.cpp

To: chinmoyr, apol, bruns, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D14464: Cancel privilege operation for read-only target with the current user as owner

[Chinmoy Ranjan Pradhan]

chinmoyr closed this revision.
chinmoyr added a comment.


  https://commits.kde.org/kio/14b29cf64611f91f0bc1f5828e4c86392510f0e6

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14464

To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D14464: Cancel privilege operation for read-only target with the current user as owner

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 59748.
chinmoyr added a comment.


  Updated frameworks version.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14464?vs=38714=59748

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14464

AFFECTED FILES
  src/core/global.h
  src/core/job_error.cpp
  src/ioslaves/file/file_unix.cpp

To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D14467: Auth Support: Drop privileges if target is not owned by root

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  In D14467#479223 , @ngraham wrote:
  
  > @mgerstner How is this looking now? Yea/nay?
  
  
  He is not available for the next couple of weeks. However he did ask one of 
his colleagues to have a look at it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14467

To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin
Cc: mgerstner, fvogt, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21782: Add a warning dialog with details, continue, and cancel button

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  In D21782#479190 , @GB_2 wrote:
  
  > I think a KCollapsibleGroupBox would fit here: 
http://blog.davidedmundson.co.uk/blog/my-new-widget-in-frameworks/
  
  
  Thanks! I'll give it a shot.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D21782

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: ngraham, GB_2, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  In D21783#479187 , @ngraham wrote:
  
  > Thanks! Is this for T8075 ?
  
  
  Yes it is.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 59738.
chinmoyr added a comment.


  Fix typo

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21783?vs=59737=59738

BRANCH
  warn

REVISION DETAIL
  https://phabricator.kde.org/D21783

AFFECTED FILES
  autotests/kiotesthelper.h
  src/core/jobuidelegateextension.h
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/core/slaveinterface.cpp
  src/core/slaveinterface.h
  src/core/usernotificationhandler.cpp
  src/core/usernotificationhandler_p.h
  src/ioslaves/file/file_unix.cpp
  src/widgets/jobuidelegate.cpp
  src/widgets/jobuidelegate.h

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21782: Add a warning dialog with details, continue, and cancel button

[Chinmoy Ranjan Pradhan]

chinmoyr edited the summary of this revision.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D21782

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added reviewers: VDG, Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  Currently it uses the dialog from D21782  
to provide the current action being performed, the source file and any
  action specific detail.
  
  F6887442: warningdialog.png 
  
  The initial plan was to show all the files needing elevated privileges but 
due to KIO jobs processing one file at
  a time only limited info could be provided. There's also the option for 
determing this during the stat phase but it
  caused my VM to slow down to a crawl. Any more ideas here?

REPOSITORY
  R241 KIO

BRANCH
  warn

REVISION DETAIL
  https://phabricator.kde.org/D21783

AFFECTED FILES
  autotests/kiotesthelper.h
  src/core/jobuidelegateextension.h
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/core/slaveinterface.cpp
  src/core/slaveinterface.h
  src/core/usernotificationhandler.cpp
  src/core/usernotificationhandler_p.h
  src/ioslaves/file/file_unix.cpp
  src/widgets/jobuidelegate.cpp
  src/widgets/jobuidelegate.h

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21782: Add a warning dialog with details, continue, and cancel button

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added reviewers: VDG, Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  F6887442: warningdialog.png 

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21782

AFFECTED FILES
  src/kmessagebox.cpp
  src/kmessagebox.h

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D14467: Auth Support: Drop privileges if target is not owned by root

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 59319.
chinmoyr added a comment.


  use seteuid to make the logic for rename work

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14467?vs=59290=59319

BRANCH
  arcpatch-D14467

REVISION DETAIL
  https://phabricator.kde.org/D14467

AFFECTED FILES
  src/ioslaves/file/file_p.h
  src/ioslaves/file/kauth/filehelper.cpp

To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin
Cc: mgerstner, fvogt, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D14467: Auth Support: Drop privileges if target is not owned by root

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 59290.
chinmoyr added a comment.


  - int -> ActionType
  - separated the logic in dropPrivileges() to two parts
  - accepting mode argument in mkdir
  - used *at() functions
  - minor cosmetic changes
  
  @mgerstner In case of rename, when owners are different I am trying to rename 
twice. First after changing euid
  and egid to the owner of src's parent dir and then the owner of dest's parent 
dir, hoping that at least one of 
  them is a privileged user. Do you think it's a good idea?

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14467?vs=38719=59290

BRANCH
  arcpatch-D14467

REVISION DETAIL
  https://phabricator.kde.org/D14467

AFFECTED FILES
  src/ioslaves/file/file_p.h
  src/ioslaves/file/kauth/filehelper.cpp

To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin
Cc: mgerstner, fvogt, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21317: Manipulate bytes instead of characters

[Chinmoy Ranjan Pradhan]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:8e00726eda1f: Manipulate bytes instead of characters 
(authored by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21317?vs=58406=58725

REVISION DETAIL
  https://phabricator.kde.org/D21317

AFFECTED FILES
  src/core/copyjob.cpp

To: chinmoyr, bruns, dfaure, thiago
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D21317: Manipulate bytes instead of characters

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added reviewers: bruns, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  D21155  trucates a QString. Since most 
Linux FS specify filename limits in bytes, convert the url to
  QByteArray and then truncate.
  
  As for truncating a UTF-8 sequence in middle, will it have any noticeable 
impact?
  After truncating, the url loses any meaning it had initially. So IMO a few 
characters
  at the end which were initially not a part of the url don't make any 
difference.

REPOSITORY
  R241 KIO

BRANCH
  link

REVISION DETAIL
  https://phabricator.kde.org/D21317

AFFECTED FILES
  src/core/copyjob.cpp

To: chinmoyr, bruns, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21155: Truncate long filname before creating a link

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:092beaf6fbab: Truncate long filname before creating a 
link (authored by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21155?vs=57929=58069

REVISION DETAIL
  https://phabricator.kde.org/D21155

AFFECTED FILES
  src/core/copyjob.cpp

To: chinmoyr, dfaure, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21197: [KCoreDirLister] Remove assert in reinsert method

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  Here I am trying to fix #405461. We reach this assertion in reinsert() after 
we create a new folder
  in kfilewidget. The code path is triggered by the signal KDirWatch::created 
which is then followed
  by itemsAddedInDirectory(), updateDirectory(), processPendingUpdates() and 
then reinsert().
  
  Now there are two issues with reinsert(). First it asserts that 
DirItem::lstItems (list of KItems)
  must contain a KItem whose url is lexicographically greater than the oldUrl 
we are trying to update.
  But when creating folders from kfilewidget it is almost always not true. In 
fact after creating a
  new folder it is empty.
  
  Other issue is with the behaviour of reinsert(). In case the exact KItem for 
oldUrl doesn't exist,
  it replaces the first greater KItem with the new one. From this method's 
description and from what I
  have observed so far this behaviours is incorrect. So removing the assertion 
seems to be an appropriate 
  way to fix the bug.
  
  PS: Following the code has been difficult so I might have missed a place where
  placing an extra updateDirectory() call would have fixed the issue or I might 
be talking nonsense here.
  Please correct me if this is the case.
  
  BUG: 405461

REPOSITORY
  R241 KIO

BRANCH
  kcoredirlister

REVISION DETAIL
  https://phabricator.kde.org/D21197

AFFECTED FILES
  src/core/kcoredirlister_p.h

To: chinmoyr, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21155: Truncate long filname before creating a link

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  URL of a website can exceed 255 characters. Consequently we cannot create a 
link to such URL.
  In such cases try to truncate the filename to 255 characters.
  
  BUG: 342247

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21155

AFFECTED FILES
  src/core/copyjob.cpp

To: chinmoyr, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20062: [RFC] Add support for changing volume label.

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  The issue here is the placement of code. There are no API for changing any 
volume attributes so adding the changeLabel() method here feels awkward.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20062

To: chinmoyr, #frameworks, bruns, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20062: [RFC] Add support for changing volume label.

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  Is this the right approach to take?

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20062

AFFECTED FILES
  src/solid/devices/backends/fakehw/fakestorageaccess.cpp
  src/solid/devices/backends/fakehw/fakestorageaccess.h
  src/solid/devices/backends/fstab/fstabstorageaccess.cpp
  src/solid/devices/backends/fstab/fstabstorageaccess.h
  src/solid/devices/backends/udisks2/udisksstorageaccess.cpp
  src/solid/devices/backends/udisks2/udisksstorageaccess.h
  src/solid/devices/ifaces/storageaccess.cpp
  src/solid/devices/ifaces/storageaccess.h

To: chinmoyr, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18845: authority: add support for passing details to polkit

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  I would like this patch to land so +1 from me. But I am not familiar with 
this code so I can't give any meaningful feedback. Sorry.

INLINE COMMENTS

> polkitqt1-authority.cpp:336
> +
> +polkit_details_insert(ret, key.toUtf8().data(), 
> value.toUtf8().data());
> +}

Nitpick; constData() because the API seems to take const gchar*

REVISION DETAIL
  https://phabricator.kde.org/D18845

To: mgerstner, #frameworks, chinmoyr, fvogt, bruns
Cc: mati865, kde-frameworks-devel

D19696: Add blender thumbnailer

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R373:2da545defff9: Add blender thumbnailer (authored by 
chinmoyr).

REPOSITORY
  R373 Image Thumbnailers

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19696?vs=53971=54065

REVISION DETAIL
  https://phabricator.kde.org/D19696

AFFECTED FILES
  CMakeLists.txt
  blend/CMakeLists.txt
  blend/blendercreator.cpp
  blend/blendercreator.h
  blend/blenderthumbnail.desktop

To: chinmoyr, #frameworks, bruns
Cc: bruns, ngraham, broulik, ltoscano, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, 
mikesomov

D19696: Add blender thumbnailer

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 53971.
chinmoyr added a comment.


  Removed unused headers.

REPOSITORY
  R373 Image Thumbnailers

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19696?vs=53848=53971

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19696

AFFECTED FILES
  CMakeLists.txt
  blend/CMakeLists.txt
  blend/blendercreator.cpp
  blend/blendercreator.h
  blend/blenderthumbnail.desktop

To: chinmoyr, #frameworks, bruns
Cc: bruns, ngraham, broulik, ltoscano, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, 
mikesomov

D19696: Add blender thumbnailer

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 53848.
chinmoyr marked 3 inline comments as done.
chinmoyr added a comment.


  Issues fixed.

REPOSITORY
  R373 Image Thumbnailers

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19696?vs=53820=53848

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19696

AFFECTED FILES
  CMakeLists.txt
  blend/CMakeLists.txt
  blend/blendercreator.cpp
  blend/blendercreator.h
  blend/blenderthumbnail.desktop

To: chinmoyr, #frameworks, bruns
Cc: bruns, ngraham, broulik, ltoscano, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, 
mikesomov

D19696: Add blender thumbnailer

[Chinmoy Ranjan Pradhan]

chinmoyr added inline comments.

INLINE COMMENTS

> bruns wrote in blendercreator.cpp:134
> So does the code I linked to. No need to cook your own.

Ah, sorry. I misunderstood what was written in doc. It really does swap them.

REPOSITORY
  R373 Image Thumbnailers

REVISION DETAIL
  https://phabricator.kde.org/D19696

To: chinmoyr, #frameworks, bruns
Cc: bruns, ngraham, broulik, ltoscano, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, 
mikesomov

D19696: Add blender thumbnailer

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 53820.
chinmoyr marked 4 inline comments as done.
chinmoyr added a comment.


  Moved to kdegraphics-thumbnailer
  Got rid of operator>>() and fixed other issues.

REPOSITORY
  R373 Image Thumbnailers

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19696?vs=53699=53820

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19696

AFFECTED FILES
  CMakeLists.txt
  blend/CMakeLists.txt
  blend/blendercreator.cpp
  blend/blendercreator.h
  blend/blenderthumbnail.desktop

To: chinmoyr, #frameworks, bruns
Cc: bruns, ngraham, broulik, ltoscano, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, 
mikesomov

D19696: Add blender thumbnailer

[Chinmoy Ranjan Pradhan]

chinmoyr added inline comments.

INLINE COMMENTS

> bruns wrote in blendercreator.cpp:57
> I think this is already done by the calling code - the thumbnailer gets only 
> called when the mimetype matches.

This part is required because blender can save files with gzip compression. 
Examples here :   https://download.blender.org/demo/test/Demo_274.zip. For some 
of them properties dialog shows "Contents: application/gzip".

> bruns wrote in blendercreator.cpp:101
> Does this mean 'size of header fields 1 to 5'?

yes

> bruns wrote in blendercreator.cpp:134
> https://doc.qt.io/qt-5/qimage.html#rgbSwapped-1

I am trying to swap bgr to rgb here.

REPOSITORY
  R373 Image Thumbnailers

REVISION DETAIL
  https://phabricator.kde.org/D19696

To: chinmoyr, #frameworks, bruns
Cc: bruns, ngraham, broulik, ltoscano, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, 
mikesomov

D19696: Add blender thumbnailer

[Chinmoy Ranjan Pradhan]

chinmoyr edited the summary of this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D19696

To: chinmoyr, #frameworks
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D19696: Add blender thumbnailer

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added a reviewer: Frameworks.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  This extracts thumbnail from .blend files.
  
  Before: Default icon.
  After:
  F6685286: Blender thumbnail 

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19696

AFFECTED FILES
  thumbnail/CMakeLists.txt
  thumbnail/blendercreator.cpp
  thumbnail/blendercreator.h
  thumbnail/blenderthumbnail.desktop

To: chinmoyr, #frameworks
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D18904: [FileCopyJob] Clean up after cancelation of file copy operation

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:7a79f1531480: [FileCopyJob] Clean up after cancelation of 
file copy operation (authored by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18904?vs=53605=53606

REVISION DETAIL
  https://phabricator.kde.org/D18904

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/core/filecopyjob.cpp
  src/core/filecopyjob.h

To: chinmoyr, dfaure, dmitrio, ngraham
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D18904: [FileCopyJob] Clean up after cancelation of file copy operation

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 53605.
chinmoyr retitled this revision from "[FileCopyJob] Clean up after file copy 
operation is cancelled" to "[FileCopyJob] Clean up after cancelation of file 
copy operation".
chinmoyr edited the summary of this revision.
chinmoyr added a comment.


  Update summary

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18904?vs=53604=53605

BRANCH
  arcpatch-D18904 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18904

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/core/filecopyjob.cpp
  src/core/filecopyjob.h

To: chinmoyr, dfaure, dmitrio, ngraham
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 53604.
chinmoyr marked an inline comment as done.
chinmoyr added a comment.


  Changed m_bFileWriteInProgress -> m_bFileCopyInProgress

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18904?vs=53297=53604

BRANCH
  arcpatch-D18904 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18904

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/core/filecopyjob.cpp
  src/core/filecopyjob.h

To: chinmoyr, dfaure, dmitrio, ngraham
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  There's free space check in CopyJob. And Dolphin still gives an error in the 
said situation. But if some application decides to directly use FileCopyJob 
then IMO the free space check should be at application's side. Anyway, I tried 
adding it here and it felt awkward to me.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18904

To: chinmoyr, dfaure, dmitrio, ngraham
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D19585: [CopyJob] Report results after finishing copy

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  > Opened Dolphin, Ctrl+C on a file, Ctrl+V it into the same folder, let it 
sit at the "Override?" prompt until the job view in Plasma showed up. >Chose a 
different filename and continued.
  > [...]
  > The URL isn't updated in case of a rename but I bet it just needs a 
m_bURLDirty call somewhere in the conflict handler
  
  I followed the steps for $HOME/foo. 
  Before: notification showed $HOME/foo
  After: notification showed $HOME/foo1
  
  Keeping or removing the line in D19586  
had no effect at all.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19585

To: broulik, dfaure, chinmoyr
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19422: Fix upper/lower case rename on case insensitive fs

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:ef5b9c6991aa: Fix upper/lower case rename on case 
insensitive fs (authored by hoffmannrobert, committed by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19422?vs=53051=53301

REVISION DETAIL
  https://phabricator.kde.org/D19422

AFFECTED FILES
  src/core/copyjob.cpp

To: hoffmannrobert, #frameworks, #dolphin, dfaure, chinmoyr
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 53297.
chinmoyr added a comment.


  Remove unrelated changes commited by mistake.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18904?vs=53291=53297

BRANCH
  arcpatch-D18904 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18904

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/core/filecopyjob.cpp
  src/core/filecopyjob.h

To: chinmoyr, dfaure, dmitrio, ngraham
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 53291.
chinmoyr added a comment.


  Delete .part file when Overwrite flag is set.
  
  @dfaure please have a look at it again.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18904?vs=51383=53291

BRANCH
  arcpatch-D18904_1

REVISION DETAIL
  https://phabricator.kde.org/D18904

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/core/filecopyjob.cpp
  src/ioslaves/file/file_unix.cpp

To: chinmoyr, dfaure, dmitrio, ngraham
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D19422: Fix upper/lower case rename on case insensitive fs

[Chinmoy Ranjan Pradhan]

chinmoyr accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  fix_case_rename

REVISION DETAIL
  https://phabricator.kde.org/D19422

To: hoffmannrobert, #frameworks, #dolphin, dfaure, chinmoyr
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19080: Make file overwrite a bit safer

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:f34c2cf0abf1: Make file overwrite a bit safer (authored 
by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19080?vs=53044=53045

REVISION DETAIL
  https://phabricator.kde.org/D19080

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/ioslaves/file/file_unix.cpp

To: chinmoyr, dfaure, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19080: Make file overwrite a bit safer

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 53044.
chinmoyr retitled this revision from "[WIP] Make file overwrite a bit safer" to 
"Make file overwrite a bit safer".
chinmoyr edited the summary of this revision.
chinmoyr added a comment.


  Print strerror.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19080?vs=51939=53044

BRANCH
  arcpatch-D19080 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19080

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/ioslaves/file/file_unix.cpp

To: chinmoyr, dfaure, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18455: Port to new connect syntax

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:53bba36a78c4: Port to new connect syntax (authored by 
chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18455?vs=53013=53014

REVISION DETAIL
  https://phabricator.kde.org/D18455

AFFECTED FILES
  src/core/copyjob.cpp
  src/core/copyjob.h
  src/core/job_p.h
  src/core/transferjob.cpp
  src/core/transferjob.h

To: chinmoyr, davidedmundson, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D18455: Port to new connect syntax

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 53013.
chinmoyr added a comment.


  Restore sourceStated in CopyJob.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18455?vs=50058=53013

BRANCH
  arcpatch-D18455

REVISION DETAIL
  https://phabricator.kde.org/D18455

AFFECTED FILES
  src/core/copyjob.cpp
  src/core/copyjob.h
  src/core/job_p.h
  src/core/transferjob.cpp
  src/core/transferjob.h

To: chinmoyr, davidedmundson, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19422: Fix upper/lower case rename on case insensitive fs

[Chinmoy Ranjan Pradhan]

chinmoyr requested changes to this revision.
chinmoyr added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> copyjob.cpp:1909
>  const QString srcDir = QFileInfo(_src).absolutePath();
> -QTemporaryFile tmpFile(srcDir + QLatin1String("kio_XX"));
> +QTemporaryFile 
> tmpFile(QDir(srcDir).filePath(QLatin1String("kio_XX")));
>  const bool openOk = tmpFile.open();

IMO QDir isn't required here. QLatin1String("/kio_xx") is sufficient.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19422

To: hoffmannrobert, #frameworks, #dolphin, dfaure, chinmoyr
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19339: Add option to change drive label to places panel context menu

[Chinmoy Ranjan Pradhan]

chinmoyr planned changes to this revision.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D19339

To: chinmoyr, #dolphin, #frameworks
Cc: broulik, ngraham, bruns, kfm-devel, alexde, feverfew, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, mikesomov

D19339: Add option to change drive label to places panel context menu

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added reviewers: Dolphin, Frameworks.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  Uses org.freedesktop.UDisks2 dbus service for changing drive label.

REPOSITORY
  R318 Dolphin

BRANCH
  change-label

REVISION DETAIL
  https://phabricator.kde.org/D19339

AFFECTED FILES
  src/panels/places/placesitemmodel.cpp
  src/panels/places/placesitemmodel.h
  src/panels/places/placespanel.cpp

To: chinmoyr, #dolphin, #frameworks
Cc: kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, 
emmanuelp, mikesomov

D19080: [WIP] Make file overwrite a bit safer

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  @dfaure ping

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19080

To: chinmoyr, dfaure, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19080: [WIP] Make file overwrite a bit safer

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 51939.
chinmoyr marked 2 inline comments as done.
chinmoyr added a comment.


  Update.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19080?vs=51876=51939

BRANCH
  safe-overwrite

REVISION DETAIL
  https://phabricator.kde.org/D19080

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/ioslaves/file/file_unix.cpp

To: chinmoyr, dfaure, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19080: [WIP] Make file overwrite a bit safer

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 51876.
chinmoyr added a comment.


  Skip unit test on windows.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19080?vs=51875=51876

BRANCH
  safe-overwrite

REVISION DETAIL
  https://phabricator.kde.org/D19080

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/ioslaves/file/file_unix.cpp

To: chinmoyr, dfaure, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19080: [WIP] Make file overwrite a bit safer

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 51875.
chinmoyr marked 4 inline comments as done.
chinmoyr added a comment.


  Removed warning message.
  Removed arg().
  Added test cases.
  Used QFile::resize().
  
  Replying to a comment:
  
  > This test is called Overwrite, and passes the Overwrite flag, but it's not 
actually 
  > overwriting anything (destFile doesn't exist).
  
  createTestDirectory() internally calls createTestFile() so both source and 
dest 
  files are created. There, using QFile, I wanted to resize the source file to 
make 
  sure the .part file isn't deleted before the lambda is called.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19080?vs=51859=51875

BRANCH
  safe-overwrite

REVISION DETAIL
  https://phabricator.kde.org/D19080

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/ioslaves/file/file_unix.cpp

To: chinmoyr, dfaure, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19080: [WIP] Make file overwrite a bit safer

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependent revision: D18904: [FileCopyJob] Clean up after file 
copy operation is cancelled.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19080

To: chinmoyr, dfaure, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependency: D19080: [WIP] Make file overwrite a bit safer.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18904

To: chinmoyr, dfaure, dmitrio
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D19080: [WIP] Make file overwrite a bit safer

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added reviewers: dfaure, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  The source is copied to a separate ".part" file, then the original 
destination  
  is replaced.
  
  When disk_full error occurs, file kioslave will ask the user if they wish to 
delete 
  the existing destination to free space and continue copying or cancel the 
copy 
  operation altogether.

TEST PLAN
  Unit testing and manual testing done.

REPOSITORY
  R241 KIO

BRANCH
  safe-overwrite

REVISION DETAIL
  https://phabricator.kde.org/D19080

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/ioslaves/file/file_unix.cpp

To: chinmoyr, dfaure, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18915: Fix batchrename changing extension to lower case

[Chinmoy Ranjan Pradhan]

chinmoyr added inline comments.

INLINE COMMENTS

> abalaji wrote in batchrenamejob.cpp:64
> I wonder if just getting rid of `.toLower()` fixes this bug

I agree with @abalaji here. Modifying the code around this line should fix the 
bug and also address my previous comment.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: chinmoyr, kde-frameworks-devel, michaelh, ngraham, bruns

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 51383.
chinmoyr marked 4 inline comments as done.
chinmoyr added a comment.


  Fixed all issues.
  Added test case for suspend.
  
  > so the user knows that there data is gone
  
  *their

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18904?vs=51332=51383

BRANCH
  arcpatch-D10663

REVISION DETAIL
  https://phabricator.kde.org/D18904

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/core/filecopyjob.cpp
  src/core/filecopyjob.h

To: chinmoyr, dfaure, dmitrio
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D18915: Fix batchrename changing extension to lower case

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  @cfoster Thanks for the patch :)
  
  There's one more mass-rename related bug here:
  
  1. Create two files; one with a known extension (.cpp) and the other with a 
random extension (.xyz, anything not in mime db)
  2. Rename both.
  3. The extension (.xyz) is removed from second file.
  
  It is possible to add code for preserving the unknown extension in this patch 
itself. If not you can always create a new diff :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: chinmoyr, kde-frameworks-devel, michaelh, ngraham, bruns

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  @ngraham The destination file is corrupted as soon as the user clicks 
overwrite. This patch deletes that file. Is that file supposed to be preserved 
(to prevent user panic)? My suggestion is to append ".part" or some similar 
extension when an overwrite starts, so the user knows that there data is gone.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18904

To: chinmoyr, dfaure, dmitrio
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added reviewers: dfaure, dmitrio.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  This patch borrows code from D10663 .
  
  The destination file is deleted if a copy job is in progress and 
  delete job is yet to start (in case of move).
  
  One additional change I made is to exclude put operation as there's
  a possibility that someone might try to resume the partial copy at a 
  later date.

TEST PLAN
  Unit testing and manual testing done.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D10663

REVISION DETAIL
  https://phabricator.kde.org/D18904

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/core/filecopyjob.cpp
  src/core/filecopyjob.h

To: chinmoyr, dfaure, dmitrio
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D18699: [KIO/RenameDialog] Add new apply behaviour

[Chinmoy Ranjan Pradhan]

chinmoyr added a reviewer: VDG.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18699

To: chinmoyr, dfaure, ngraham, #vdg
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D18699: [KIO/RenameDialog] Add new apply behaviour

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 50778.
chinmoyr edited the summary of this revision.
chinmoyr added a comment.


  Add bug id.
  Remove old code.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18699?vs=50777=50778

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18699

AFFECTED FILES
  src/core/copyjob.cpp
  src/core/jobuidelegateextension.h
  src/widgets/renamedialog.cpp
  src/widgets/renamedialog.h

To: chinmoyr, dfaure, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18699: [KIO/RenameDialog] Add new apply behaviour

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added reviewers: dfaure, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  This patch removes "Apply to All" checkbox and adds a combobox with following 
4 apply options:
  
  1. Apply to Current : Same as "Apply to All" unchecked.
  2. Apply to All
  3. Apply to Newer Dest : Applies changes (currently only overwrite) to 
conflicts with a newer version of dest file/dir. And skip the rest.
  4. Apply to Older Dest : Same as above but with older dest.
  
  F6584726: apply options 
  
  In this version of patch when selecting the last two options only 
"Overwrite"/"Write Into" button is enabled.
  
  F6584732: enabled buttons 
  
  As a result this patch also modifies CopyJob to implement the new overwrite 
behaviour.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18699

AFFECTED FILES
  src/core/copyjob.cpp
  src/core/jobuidelegateextension.h
  src/widgets/renamedialog.cpp
  src/widgets/renamedialog.h

To: chinmoyr, dfaure, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17737: [CopyJob] Create clones in btrf/xfs mount

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  @bruns  ping

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17737

To: chinmoyr, dfaure, davidedmundson
Cc: bruns, kde-frameworks-devel, michaelh, ngraham