D25551: Mark KXmlRpcClient as porting aid

dvratil accepted this revision. This revision is now accepted and ready to land. REPOSITORY R312 KXmlRpcClient BRANCH portaid REVISION DETAIL https://phabricator.kde.org/D25551 To: nicolasfella, #frameworks, dvratil Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: kcoreaddons_add_plugin executable/plugin directory conflict

On Tuesday, 12 May 2020 01:20:02 CEST David Faure wrote: > On lundi 11 mai 2020 14:07:28 CEST Friedrich W. H. Kossebau wrote: > > Am Montag, 11. Mai 2020, 10:21:10 CEST schrieb Daniel Vrátil: > > > Hi all, > > > > > > I'm moving some plugins in k

kcoreaddons_add_plugin executable/plugin directory conflict

ename the executable or the plugins namespaces, since having different name for the program and the plugin "namespace" somewhat defeats the purpose of a namespace... /Dan -- Daniel Vrátil www.dvratil.cz | dvra...@kde.org IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde) GPG Key:

D29371: KMainWindow: remove doc paragraph about KGlobal::ref usage

dvratil added a reviewer: Frameworks. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D29371 To: dvratil, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29371: KMainWindow: remove doc paragraph about KGlobal::ref usage

dvratil created this revision. dvratil added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dvratil requested review of this revision. REVISION SUMMARY There's no sign of KGlobal (obviously, it's been moved to kdelibs4support) or any

D24443: Add a plugin system

dvratil added inline comments. INLINE COMMENTS > calendarentry.cpp:36 > + > +CalendarEntry::~CalendarEntry() > +{ ` = default` (instead of empty body) > calendarentry.cpp:57 > +{ > +return ReadWrite; > +} Should that be `d->type`? How can implementations change it? Will implementation

D21902: Calendar: add method to show event details

dvratil added a comment. Ping? :) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21902 To: dvratil, mart, #frameworks, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27671: Dialog: disconnect from QWindow signals in destructor

This revision was automatically updated to reflect the committed changes. Closed by commit R242:b6213cdd59cc: Dialog: disconnect from QWindow signals in destructor (authored by dvratil). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D23339: Fix memory leak in ConfigView and Dialog

dvratil added a comment. Fix for the crash: https://phabricator.kde.org/D27671 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23339 To: dvratil, #plasma, #frameworks, apol, davidedmundson Cc: nicolasfella, kde-frameworks-devel, LeGast00n, cblack,

D23339: Fix memory leak in ConfigView and Dialog

dvratil added a dependent revision: D27671: Dialog: disconnect from QWindow signals in destructor. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23339 To: dvratil, #plasma, #frameworks, apol, davidedmundson Cc: nicolasfella, kde-frameworks-devel,

D27671: Dialog: disconnect from QWindow signals in destructor

dvratil added a dependency: D23339: Fix memory leak in ConfigView and Dialog. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27671 To: dvratil, #plasma, nicolasfella Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27671: Dialog: disconnect from QWindow signals in destructor

dvratil created this revision. dvratil added reviewers: Plasma, nicolasfella. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dvratil requested review of this revision. REVISION SUMMARY When Dialog is being destroyed, its QWindow super-class may still emit

D21902: Calendar: add method to show event details

dvratil updated this revision to Diff 76365. dvratil added a comment. - Rebase to master REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21902?vs=60891=76365 BRANCH arcpatch-D21902 REVISION DETAIL https://phabricator.kde.org/D21902

D21902: Calendar: add method to show event details

dvratil added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21902 To: dvratil, mart, #frameworks, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27627: Fix initialization order

This revision was automatically updated to reflect the committed changes. Closed by commit R242:1e11099c1616: Fix initialization order (authored by dvratil). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27627?vs=76306=76361 REVISION

D23339: Fix memory leak in ConfigView and Dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R242:4b93b71a4924: Fix memory leak in ConfigView and Dialog (authored by dvratil). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D27627: Fix initialization order

dvratil created this revision. dvratil added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dvratil requested review of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL

D23339: Fix memory leak in ConfigView and Dialog

dvratil added reviewers: Plasma, Frameworks. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23339 To: dvratil, #plasma, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D23339: Fix memory leak in ConfigView and Dialog

dvratil updated this revision to Diff 76305. dvratil added a comment. - Rebase on current master REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23339?vs=64284=76305 BRANCH arcpatch-D23339 REVISION DETAIL

D27538: Registry: don't destroy the callback on globalsync

This revision was automatically updated to reflect the committed changes. Closed by commit R127:4ceb35672dfa: Registry: dont destroy the callback on globalsync (authored by dvratil). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27538?vs=76084=76097

D27538: Registry: don't destroy the callback on globalsync

dvratil edited the summary of this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27538 To: dvratil, #kwin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27538: Registry: don't destroy the callback on globalsync

dvratil created this revision. dvratil added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dvratil requested review of this revision. REVISION SUMMARY Instead just unref it, because the wl_display_dispatch_queue_pending will try to

Re: Disabling akonadi test runner infrastructure across all repositories

the correct CMake macro so that the options have an effect. Regards, Dan > > Regards, > Ben -- Daniel Vrátil www.dvratil.cz | dvra...@kde.org IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde) GPG Key: 0x4D69557AECB13683 Fingerprint: 0ABD FA55 A4E6 BEA9 9A83 EA9

D24597: [Konversation] Port from deprecated KTcpSocket to QSslSocket

dvratil accepted this revision. dvratil added a comment. This revision is now accepted and ready to land. Looks good to me, thanks! REPOSITORY R7 Konversation BRANCH ahmad/ktcpsocket-qsslsocket (branched from master) REVISION DETAIL https://phabricator.kde.org/D24597 To: ahmadsamir,

D24443: Add a plugin system

dvratil added a comment. - I would add `name` property to the `CalendarEntry` - I would add `color` property to the `CalendarEntry`, so that calendar that is e.g. green in KOrganizer would show up green in the Plasma applet, too. The Akonadi plugin for this will need to expose a list

D23385: More porting from QRegExp to QRegularExpression

dvratil added inline comments. INLINE COMMENTS > katedocument.cpp:4676 > foreach (const QString , wildcards) { > -QRegExp wildcard(pattern, Qt::CaseSensitive, QRegExp::Wildcard); > +QRegularExpression wildcard(QLatin1Char('^') + >

D23340: Fix memory leak in KConfigWatcher

This revision was automatically updated to reflect the committed changes. Closed by commit R237:b9cf875e2e7d: Fix memory leak in KConfigWatcher (authored by dvratil). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23340?vs=64285=64290 REVISION DETAIL

D23340: Fix memory leak in KConfigWatcher

dvratil created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dvratil requested review of this revision. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D23340 AFFECTED FILES

D23339: Fix memory leak in ConfigView and Dialog

dvratil created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dvratil requested review of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D23339 AFFECTED FILES

Re: KCalendarCore plugins/datasources?

ce of KCalendarCore::Calendar and directly populate it with entities loaded from Akonadi. We don't use the CalStorage interface for that as we don't need that kind of abstraction to integrate between KCalendarCore and Akonadi. Regards, Dan > > > Thanks -- Daniel Vrátil www.dvratil

D21901: Calendar events: allow plugins to show event details

This revision was automatically updated to reflect the committed changes. Closed by commit R296:811e78ef0ee3: Calendar events: allow plugins to show event details (authored by dvratil). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21901?vs=60890=61798#toc REPOSITORY R296

D21902: Calendar: add method to show event details

dvratil added a reviewer: Frameworks. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21902 To: dvratil, mart, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D21902: Calendar: add method to show event details

dvratil added a comment. Ping? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21902 To: dvratil, mart, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D21901: Calendar events: allow plugins to show event details

dvratil added a comment. Ping? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D21901 To: dvratil, #frameworks, mart Cc: ngraham, broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, bruns

D22414: Fix build due to missing QVector include

This revision was automatically updated to reflect the committed changes. Closed by commit R290:886f7f4004e5: Fix build due to missing QVector include (authored by dvratil). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22414?vs=61631=61634 REVISION DETAIL

D22413: Fix build after 0b2fe3cf21

This revision was automatically updated to reflect the committed changes. Closed by commit R244:95e9d5f22ea3: Fix build after 0b2fe3cf21 (authored by dvratil). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22413?vs=61628=61633 REVISION DETAIL

D22414: Fix build due to missing QVector include

dvratil created this revision. dvratil added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dvratil requested review of this revision. REVISION SUMMARY I get 'implicit instantiation of undefined template 'QVector' when building against

D22413: Fix build after 0b2fe3cf21

dvratil created this revision. dvratil added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dvratil requested review of this revision. REVISION SUMMARY QVector is not unused in kstringhandler.cpp TEST PLAN kcoreaddons master builds

D21902: Calendar: add method to show event details

dvratil updated this revision to Diff 60891. dvratil added a comment. Adapt to API changes in D21901 REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21902?vs=60066=60891 BRANCH master REVISION

D21901: Calendar events: allow plugins to show event details

dvratil updated this revision to Diff 60890. dvratil added a comment. Make the change truly API and ABI compatible REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21901?vs=60068=60890 BRANCH master REVISION DETAIL

D21901: Calendar events: allow plugins to show event details

dvratil added a comment. So, we are doomed to `CalendarEventsPluginV2`? *sadpanda* REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D21901 To: dvratil, #frameworks, mart Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21901: Calendar events: allow plugins to show event details

dvratil added a reviewer: mart. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D21901 To: dvratil, #frameworks, mart Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21901: Calendar events: allow plugins to show event details

dvratil added a dependent revision: D21906: Events plugin: implement the new showEvent() API. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D21901 To: dvratil, #frameworks Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21902: Calendar: add method to show event details

dvratil added a dependent revision: D21905: [Digital Clock] Open KOrganizer with event details on click. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21902 To: dvratil, mart Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21901: Calendar events: allow plugins to show event details

dvratil updated this revision to Diff 60068. dvratil added a comment. - Fix ABI compatibility REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21901?vs=60065=60068 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21901 AFFECTED FILES

D21902: Calendar: add method to show event details

dvratil created this revision. dvratil added a reviewer: mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dvratil requested review of this revision. REVISION SUMMARY This extends the API to allow calendar UIs to request opening a detailed view of an

D21902: Calendar: add method to show event details

dvratil added a dependency: D21901: Calendar events: allow plugins to show event details. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21902 To: dvratil, mart Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21901: Calendar events: allow plugins to show event details

dvratil added a dependent revision: D21902: Calendar: add method to show event details. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D21901 To: dvratil, #frameworks Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21901: Calendar events: allow plugins to show event details

dvratil added a reviewer: Frameworks. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D21901 To: dvratil, #frameworks Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21901: Calendar events: allow plugins to show event details

dvratil created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dvratil requested review of this revision. REVISION SUMMARY This adds new method to the plugin API that will allow plugins to show event details when user clicks on the event,

D21314: Don't enable QT_STRICT_ITERATORS on Windows.

dvratil accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D21314 To: dfaure, vkrause, dvratil Cc: apol, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh,

Re: Review Request: plasma-thunderbolt

On Wednesday, 15 May 2019 23:08:57 CEST Albert Astals Cid wrote: > El dimecres, 15 de maig de 2019, a les 15:27:07 CEST, Daniel Vrátil va escriure: > > Hi all, > > > > plasma-thunderbolt is a new repo containing, you guessed it, Thunderbolt > > KCM for Plasma. I i

Re: Review Request: plasma-thunderbolt

On Wednesday, 15 May 2019 15:55:01 CEST Friedrich W. H. Kossebau wrote: > Am Mittwoch, 15. Mai 2019, 15:27:07 CEST schrieb Daniel Vrátil: > > Thus I'd kindly ask you to take one more look at the codebase [1] and let > > me know if there are any more issues to fix, or if

Re: Review Request: plasma-thunderbolt

lease? I think having FindBolt in ECM makes sense if there's a chance that some other components will use it. Right now I don't think anyone else is going to look for the Bolt daemon (as a runtime dependency). Dan > > Nate > > On 5/15/19 7:27 AM, Daniel Vrátil wrote: > > Hi

Review Request: plasma-thunderbolt

://phabricator.kde.org/D19011 [1] https://cgit.kde.org/plasma-thunderbolt.git -- Daniel Vrátil www.dvratil.cz | dvra...@kde.org IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde) GPG Key: 0x4D69557AECB13683 Fingerprint: 0ABD FA55 A4E6 BEA9 9A83 EA97 4D69 557A ECB1 3683 signature.asc

Re: New framework: KCalCore

arIncidences ... not convicing either. > > Maybe KCal is enough? Reminds of iCal. Wasn't KCal the original name of the library from pre-Akonadi times? KCalCore was a fork of KCal with the pre-Akonadi "Resources" system removed... -- Daniel Vrátil www.dvratil.cz | dvra...@kde.org I

Re: CI system maintainability

On Thursday, March 28, 2019 3:39:54 PM CET Friedrich W. H. Kossebau wrote: > Am Donnerstag, 28. März 2019, 11:27:44 CET schrieb Daniel Vrátil: > > I'm completely fine with mandatory code review for everything and I'd be > > happy to have this in PIM. I think the biggest problem in

Re: CI system maintainability

On Thursday, March 28, 2019 3:39:54 PM CET Friedrich W. H. Kossebau wrote: > Am Donnerstag, 28. März 2019, 11:27:44 CET schrieb Daniel Vrátil: > > I'm completely fine with mandatory code review for everything and I'd be > > happy to have this in PIM. I think the biggest problem in

Re: CI system maintainability

On Thursday, March 28, 2019 3:39:54 PM CET Friedrich W. H. Kossebau wrote: > Am Donnerstag, 28. März 2019, 11:27:44 CET schrieb Daniel Vrátil: > > I'm completely fine with mandatory code review for everything and I'd be > > happy to have this in PIM. I think the biggest problem in

Re: CI system maintainability

o truly appreciate it, not only as a huge learning experience but so many times just having a second pair of eyes to glance over my code has revealed issues that sometimes almost make me question my career choice as a programmer :-) I think this is especially important for projects li

Re: CI system maintainability

o truly appreciate it, not only as a huge learning experience but so many times just having a second pair of eyes to glance over my code has revealed issues that sometimes almost make me question my career choice as a programmer :-) I think this is especially important for projects li

Re: CI system maintainability

o truly appreciate it, not only as a huge learning experience but so many times just having a second pair of eyes to glance over my code has revealed issues that sometimes almost make me question my career choice as a programmer :-) I think this is especially important for projects li

Re: Review request: plasma-pass

Hi Albert, thanks for the review! All the issues you mentioned are fixed in master now. Dan On Sunday, 16 December 2018 20:14:37 CET Albert Astals Cid wrote: > El dilluns, 10 de desembre de 2018, a les 14:49:28 CET, Daniel Vrátil va escriure: > > Hi folks, > > > >

Review request: plasma-pass

o your feedback, Dan [0] https://www.passwordstore.org/ [1] https://www.dvratil.cz/2018/05/plasma-pass/ -- Daniel Vrátil www.dvratil.cz | dvra...@kde.org IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde) GPG Key: 0x4D69557AECB13683 Fingerprint: 0ABD FA55 A4E6 BEA9 9A83 EA97

D15851: Fix signals not being emitted when merging two persons

dvratil accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople BRANCH forgotten-signal (branched from master) REVISION DETAIL https://phabricator.kde.org/D15851 To: poboiko, #frameworks, dvratil Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15697: Fix deletion of files from DAV

This revision was automatically updated to reflect the committed changes. Closed by commit R241:7615e3405c30: Fix deletion of files from DAV (authored by dvratil). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15697?vs=42175=42192 REVISION DETAIL

D15697: Fix deletion of files from DAV

dvratil edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15697 To: dvratil, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15697: Fix deletion of files from DAV

dvratil updated this revision to Diff 42175. dvratil added a comment. Improve commit message I thought you were referring to rmdir in the kio slave, but now I realize rmdir() is KIO API, not slave API. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D15697: Fix deletion of files from DAV

dvratil created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dvratil requested review of this revision. REVISION SUMMARY Always assume del() deletes a file, not a directory so don't try to append slash at the end of the path. Some servers

D15697: Fix deletion of files from DAV

dvratil added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15697 To: dvratil, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15497: Fix CMakeLists.txt issues

dvratil accepted this revision. dvratil added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R307 KPeople BRANCH cmake-issues (branched from master) REVISION DETAIL https://phabricator.kde.org/D15497 To: poboiko, #frameworks, dvratil, apol Cc:

D15431: Make PersonPluginManager API public

dvratil accepted this revision. dvratil added a comment. This revision is now accepted and ready to land. Nice, thank you! REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D15431 To: poboiko, #kde_pim, dvratil, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns,

D15497: Fix CMakeLists.txt issues

dvratil requested changes to this revision. dvratil added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > personactionsmodel.cpp:21 > #include > -#include > +#include > #include This looks suspicious. When compiling, you should not need to refer to ``,

D15431: Make PersonPluginManager API public

dvratil requested changes to this revision. dvratil added a comment. This revision now requires changes to proceed. Just some minor details and we are good to go :) INLINE COMMENTS > personpluginmanager.h:34 > class KPEOPLE_EXPORT PersonPluginManager > { Sorry, forgot to mention this in

D15431: Make PersonPluginManager API public

dvratil requested changes to this revision. dvratil added a comment. This revision now requires changes to proceed. Looks good, just some minor nitpicks. - > There some ancient compatibility code inside PersonPluginManagerPrivate::loadDataSourcePlugins(), which was added 3 years

D10040: Add serial number and EISA ID to OutputDevice interface

dvratil added a comment. In D10040#286064 , @davidedmundson wrote: > @dvratil want me to finish this? @davidedmundson Yes, I'd appreciate it. I won't have time to look into this any time soon, sorry :( REPOSITORY R127 KWayland

D10040: Add serial number and EISA ID to OutputDevice interface

dvratil marked 2 inline comments as done. dvratil added inline comments. INLINE COMMENTS > davidedmundson wrote in outputdevice_interface.cpp:450 > You're not actually sending the serial number or eisa anywhere.. > > The others do it in sendGeometry (including the manufacturer) > > When you do

D10040: Add serial number and EISA ID to OutputDevice interface

dvratil updated this revision to Diff 25806. dvratil marked an inline comment as done. dvratil added a comment. Fix versioning REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10040?vs=25802=25806 BRANCH master REVISION DETAIL

D10040: Add serial number and EISA ID to OutputDevice interface

dvratil added a dependent revision: D10042: Parse EDID on the backend side. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10040 To: dvratil, graesslin, sebas Cc: davidedmundson, plasma-devel, #frameworks, schernikov, ZrenBot, ngraham, alexeymin, progwolff,

D10040: Add serial number and EISA ID to OutputDevice interface

dvratil added a dependent revision: D10041: Improve EDID information on Wayland. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10040 To: dvratil, graesslin, sebas Cc: plasma-devel, #frameworks, schernikov, ZrenBot, ngraham, alexeymin, progwolff, lesliezhai,

D10040: Add serial number and EISA ID to OutputDevice interface

dvratil created this revision. dvratil added reviewers: graesslin, sebas. Restricted Application added subscribers: Frameworks, plasma-devel. Restricted Application added projects: Plasma on Wayland, Frameworks. dvratil requested review of this revision. REPOSITORY R127 KWayland BRANCH

D9233: Fix build against older TagLib

This revision was automatically updated to reflect the committed changes. Closed by commit R286:d2d0ae83d2ca: Fix build against TagLib 1.11 (authored by dvratil). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9233?vs=23583=23588 REVISION DETAIL

D9233: Fix build against older TagLib

dvratil created this revision. dvratil added a reviewer: mgallien. dvratil added a project: Frameworks. REVISION SUMMARY Fix build of KFileMetadata against TagLib older than 1.11. Fixes build on Windows where Craft only has Taglib 1.9.2 by default. REPOSITORY R286 KFileMetaData

D6665: Make kssl compile against OpenSSL 1.1.0

This revision was automatically updated to reflect the committed changes. Closed by commit R239:9a990c69c606: Make kssl compile against OpenSSL 1.1.0 (authored by dvratil). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6665?vs=16613=20890#toc REPOSITORY R239 KDELibs4Support CHANGES

D8332: Added baloo urls into places model

dvratil requested changes to this revision. dvratil added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kfileplacesmodel.cpp:151 > > +// if baloo is enabled, add new ulrs even if the bookbark file is not > empty > +if (d->fileIndexingEnabled &&

Re: Build failures in libraries on CI

On Wednesday, 20 September 2017 13:20:22 CEST Ben Cooksley wrote: > On Wed, Sep 20, 2017 at 11:15 PM, Daniel Vrátil <dvra...@kde.org> wrote: > > On Wednesday, 20 September 2017 12:13:45 CEST Ben Cooksley wrote: > >> Hi all, > > > > > > > >&

Re: Build failures in libraries on CI

r failures. Dan > > Can we get these fixed please? > > Cheers, > Ben -- Daniel Vrátil www.dvratil.cz | dvra...@kde.org IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde) GPG Key: 0x4D69557AECB13683 Fingerprint: 0ABD FA55 A4E6 BEA9 9A83 EA97 4D69 557A ECB1 3683 signa

D7043: Fix assert in UrlUtil::firstChildUrl()

This revision was automatically updated to reflect the committed changes. Closed by commit R241:7e03e503b00c: Fix assert in UrlUtil::firstChildUrl() (authored by dvratil). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7043?vs=17511=17540 REVISION DETAIL

D6960: Properly handle org.fd.Notifications service failing to start

dvratil created this revision. dvratil added a project: Frameworks. REVISION SUMMARY Handle the situation when the startServiceByName invoked from the NotifyByPopup plugin fails by setting dbusServiceExists back to false. This forces the plugin to fallback to KPassivePopup instead of putting

D6665: Make kssl compile against OpenSSL 1.1.0

dvratil edited the summary of this revision. REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D6665 To: dvratil, #frameworks, dfaure Cc: rdieter, #frameworks

Re: kdereview: ksmtp

Hi Rolf, thanks for the review, sorry it took me so long to get to you. On Tuesday, May 16, 2017 8:05:17 PM CEST Rolf Eike Beer wrote: > Am Donnerstag, 11. Mai 2017, 17:03:01 schrieb Daniel Vrátil: > > Hi, > > > > please review ksmtp, which is now in kdereview. > &

Re: kdereview: ksmtp

On Thursday, May 11, 2017 11:11:11 PM CEST Albert Astals Cid wrote: > El dijous, 11 de maig de 2017, a les 17:03:01 CEST, Daniel Vrátil va escriure: > > Hi, > > > > please review ksmtp, which is now in kdereview. > > Are tests supposed to pass? > > 2: QFATAL :

Re: kdereview: ksmtp

n > On Thursday, May 11, 2017 11:03:01 AM EDT Daniel Vrátil wrote: > > Hi, > > > > please review ksmtp, which is now in kdereview. > > > > KSMTP is a small simple library with a KJob-based API similar to KIMAP or > > KDAV to send mime messages via SMTP. It

kdereview: ksmtp

is hard to maintain and extend. Having a Job-based library like KSmtp will make it much easier for us to introduce support for example for Google XOAUTH2 authentication mechanism. Thanks, Dan -- Daniel Vrátil www.dvratil.cz | dvra...@kde.org IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora

D5344: Relax constraints for processing QGroupBoxes

dvratil accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D5344 To: vkrause, dvratil, dfaure Cc: #frameworks

[Differential] [Closed] D3811: Use KPlugin for calendar applet plugins

This revision was automatically updated to reflect the committed changes. Closed by commit R242:3aec1bf2d379: Use KPlugin to load Calendar plugins (authored by dvratil). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3811?vs=10022=10101

[Differential] [Updated, 55 lines] D3811: Use KPlugin for calendar applet plugins

dvratil updated this revision to Diff 10022. dvratil added a comment. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. Fix loading of legacy plugins. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

Re: Review Request 128650: [KBookmarks] Port from QRegExp to QRegularExpression

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 68db76e9d8afce989d246768ebed7a12f9414b34 by Daniel Vrátil to branch master. Repository: kbookmarks Description --- Kleopatra was crashing on shutdown during cleanup of global statics

Re: Review Request 128650: [KBookmarks] Port from QRegExp to QRegularExpression

/kbookmarkmanager.cpp dd7a98b Diff: https://git.reviewboard.kde.org/r/128650/diff/ Testing --- Thanks, Daniel Vrátil

Review Request 128650: [KBookmarks] Fix crash on app shutdown due to QRegExp(QStringLiteral())

-crash-exit Diffs - src/kbookmarkimporter_ie.cpp 7dcbfb3 src/kbookmarkmanager.cpp dd7a98b Diff: https://git.reviewboard.kde.org/r/128650/diff/ Testing --- Thanks, Daniel Vrátil

  1   2   3   >