D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D29479: Fix rounded borders

This revision was automatically updated to reflect the committed changes. Closed by commit R242:1bc004e5c65f: Fix rounded borders (authored by niccolove). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29479?vs=82133=82147#toc REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE

D29479: Fix rounded borders

niccolove marked 2 inline comments as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29479 To: niccolove, #plasma, broulik Cc: broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29479: Fix rounded borders

niccolove added inline comments. INLINE COMMENTS > broulik wrote in PlasmoidHeading.qml:74 > Where is `plasmoid` defined? It's not necessary to define it, when you use this in a plasmoid it takes it from the context REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D29479: Fix rounded borders

niccolove marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29479 To: niccolove, #plasma, broulik Cc: broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29479: Fix rounded borders

niccolove updated this revision to Diff 82133. niccolove added a comment. Round things up again REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29479?vs=82131=82133 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29479

D29479: Fix rounded borders

niccolove marked 2 inline comments as done. niccolove added a comment. In D29479#664767 , @broulik wrote: > Notifications don't use `PlasmoidHeading` Heh, it was actually an unrelated mistake: D29490

D29479: Fix rounded borders

niccolove updated this revision to Diff 82131. niccolove added a comment. Address some feedback REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29479?vs=82078=82131 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29479

D29479: Fix rounded borders

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29479 To: niccolove, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29479: Fix rounded borders

niccolove edited the test plan for this revision. niccolove added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29479 To: niccolove, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29479: Fix rounded borders

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY This makes borders of elements using plasmoidHeading rounded again REPOSITORY R242 Plasma Framework (Library)

D29352: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme

niccolove accepted this revision as: niccolove. niccolove added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R242 Plasma Framework (Library) BRANCH heading-only-if-svg-exists (branched from master) REVISION DETAIL https://phabricator.kde.org/D29352 To:

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove added a comment. What do you think of this one? It's slightly less bright than before, but not as much as the first proposal. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham,

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove added a comment. Same. I will try some half-way that works everywhere more consistenly. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n,

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove added a comment. In D28353#655680 , @ngraham wrote: > To be honest, I kinda prefer the befores since the afters are significantly darker. Is there a way to preserve the desired level of translucency without causing the background to

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove added a comment. In D28353#655226 , @ngraham wrote: > It's okay. :) > > This is gonna seem like a really dumb question, but which images are the befores and which are the afters? Not a dumb question! They are all

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. niccolove added a dependency: D28627: Adaptive panel opacity. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel,

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove reclaimed this revision. niccolove added a comment. This should've been "Changes planned", not "Abandoned". I'm really feeling sorry for all of the emails. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg,

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove planned changes to this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the summary of this revision. niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh,

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove abandoned this revision. niccolove added a comment. I've tweaked it so many times that I eventually ended up with something that looks almost identical to default without even noticing. I still think there is margin for improvement over the default, but I need to take some more

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove added a comment. F8248684: Screenshot_20200420_111621.png REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel,

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove updated this revision to Diff 80625. niccolove added a comment. Toned down transparency REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28353?vs=78675=80625 BRANCH contrast_and_transparency (branched from master) REVISION

D28808: [ExpandableListItem] make it touch-friendly

niccolove added a comment. This generically works, except for: would it be possible to make it so that clicking on an empty point will drop the list and button hover status? otherwise, you kind of get stuck to this situation: F8242311: Screenshot_20200416_224831.png

D28808: [ExpandableListItem] make it touch-friendly

niccolove added a reviewer: niccolove. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28808 To: ngraham, #plasma, apol, #vdg, niccolove Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28372: Remove rounded borders to plasmoidHeading

This revision was automatically updated to reflect the committed changes. Closed by commit R242:0f9abc2d403d: Remove rounded borders to plasmoidHeading (authored by niccolove). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D28372: Added a merged look to the plasmoidheading and remove roundedborders

niccolove updated this revision to Diff 79740. niccolove added a comment. Removed merged look, no longer needed, but kept rounded corners change REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28372?vs=78742=79740 BRANCH

D28372: Remove rounded borders to plasmoidHeading

niccolove retitled this revision from "Added a merged look to the plasmoidheading and remove roundedborders" to "Remove rounded borders to plasmoidHeading". niccolove edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. niccolove added a dependency: D27439: Replaced isDock check with !hasDecoration. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack,

D28466: Added Page element

This revision was automatically updated to reflect the committed changes. Closed by commit R242:8b5e09314162: Added Page element (authored by niccolove). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28466?vs=79004=79227 REVISION DETAIL

D28466: Added Page element

niccolove added a comment. In D28466#639011 , @ngraham wrote: > Could you add some explanation regarding what this is for? Ideally, both in the phab patch and also inline, as API docs. > > Also shouldn't this be in PlasmaExtras? I'll

D28466: Added Page element

niccolove marked 2 inline comments as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28466 To: niccolove, #plasma Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28466: Added Page element

niccolove updated this revision to Diff 79004. niccolove added a comment. Used correct year and implicitWidth/Height code REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28466?vs=78994=79004 BRANCH master REVISION DETAIL

D28466: Added Page element

niccolove added a dependent revision: D28467: Converted to Page with a PlasmodHeading in the heading. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28466 To: niccolove, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D28466: Added Page element

niccolove added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28466 To: niccolove, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28466: Added Page element

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY Page element was missing. I added it. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION

D28372: Added a merged look to the plasmoidheading and remove roundedborders

niccolove added a subscriber: manueljlin. niccolove added a comment. Generally speaking, I'd still like for all applets to have a row of plasmoidheading on the bottom of system tray's own because having just system tray plasmoidheading, especially with the new small font, does not feel

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove added a comment. In D28353#636931 , @ngraham wrote: > It would be helpful to remind people of those details in the Test Plan section in the future. :) I will! Sorry. It applied to me without cache clearing, so I assumed it

D28372: Added a merged look to the plasmoidheading and remove roundedborders

niccolove marked an inline comment as done. niccolove added inline comments. INLINE COMMENTS > davidedmundson wrote in PlasmoidHeading.qml:77 > What should happen if this is set to merged and someone uses a theme that > doesn't have a merged- prefix? > > The old SVG or no SVG at all? I'd go

D28372: Added a merged look to the plasmoidheading and remove roundedborders

niccolove updated this revision to Diff 78742. niccolove added a comment. Specified false by default REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28372?vs=78721=78742 BRANCH merged-plasmoidheading (branched from master) REVISION

D28372: Added a merged look to the plasmoidheading and remove roundedborders

niccolove added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28372 To: niccolove, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28372: Added a merged look to the plasmoidheading and remove roundedborders

niccolove retitled this revision from "Added a merged look to the plasmoidheading" to "Added a merged look to the plasmoidheading and remove roundedborders". niccolove edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D28372: Added a merged look to the plasmoidheading

niccolove updated this revision to Diff 78721. niccolove added a comment. Removed rounded borders and thus the enabledBorders check REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28372?vs=78719=78721 BRANCH merged-plasmoidheading

D28372: Added a merged look to the plasmoidheading

niccolove planned changes to this revision. niccolove added a comment. The rounding in the svgs is not necessary. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28372 To: niccolove Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28372: Added a merged look to the plasmoidheading

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY Added a merged look (without a separator) so that multiple plasmoidheadings can be visually merged (e.g.: in

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove added a comment. Cannot reproduce, it looks like what's in the screenshots to me. Just for sure, I also added the dep on Nate's patch as that improves legibility. I totally agree on your points seen what you got, that'd be extreme. With what I'm actually trying to propose (I don't

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack, ngraham Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. niccolove added a dependency: D28317: Adjust default color scheme and titlebar appearance for Tools Area. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack,

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove added a comment. Bug! It should look like this: F8201997: Screenshot_20200327_191850.png Let me check again. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma,

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove added a comment. In D28353#636164 , @cblack wrote: > Looks visually appealing to me, with one question: How does this look on low-end hardware where there's compositing but no blur? Before: F8201840:

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove abandoned this revision. niccolove added a comment. in favor of https://phabricator.kde.org/D28353 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham, cblack Cc: trmdi, cblack, ndavis, filipf, ngraham,

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove added a reviewer: VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove updated this revision to Diff 78675. niccolove added a comment. Fix breeze dark values REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28353?vs=78668=78675 BRANCH contrast_and_transparency (branched from master) REVISION

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the summary of this revision. niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove added inline comments. INLINE COMMENTS > metadata.desktop.cmake:99 > -contrast=0.2 > -#intensity is disabled, in order to auto adjust to the chosen theme color > -#intensity=2.0 I changed this because: simply put, it doesn't work. I opened a bug about it

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY (gimme a sec to edit with screenshots) REPOSITORY R242 Plasma Framework (Library) BRANCH

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. I'll make this patch again, as much has change since then, there are things I'd do differently, and I'm not a fan of rebasing svg files. I will post the progress I did there. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D28033: Create ExpandableListItem

niccolove added a comment. AFAIK, there should be a easy way to add animations to the highlight effect. An example is the print one, where clicking on it will animate the highlight. It should also be possible to make the highlight effect fly over elements instead of always being on the

D27695: WIP: Create a new TopArea element using widgets/toparea svg

This revision was automatically updated to reflect the committed changes. Closed by commit R242:7d80f01c3162: WIP: Create a new TopArea element using widgets/toparea svg (authored by niccolove). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D27444: Added plasmoid heading svg

This revision was automatically updated to reflect the committed changes. Closed by commit R242:f55f1044479a: Added plasmoid heading svg (authored by niccolove). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27444?vs=77625=77626 REVISION

D27444: Added plasmoid heading svg

niccolove updated this revision to Diff 77625. niccolove added a comment. Polish REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27444?vs=77624=77625 BRANCH top_area (branched from master) REVISION DETAIL

D27444: Added plasmoid heading svg

niccolove updated this revision to Diff 77624. niccolove added a comment. Made opacity consistent REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27444?vs=77623=77624 BRANCH top_area (branched from master) REVISION DETAIL

D27444: Added plasmoid heading svg

niccolove updated this revision to Diff 77623. niccolove added a comment. Merge with master pt2 REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27444?vs=77622=77623 BRANCH top_area (branched from master) REVISION DETAIL

D27444: Added plasmoid heading svg

niccolove updated this revision to Diff 77622. niccolove added a comment. - Merge branch 'master' into top_area REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27444?vs=77407=77622 BRANCH top_area (branched from master) REVISION

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove added a comment. Works for me! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart, ngraham Cc: ngraham, davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove updated this revision to Diff 77588. niccolove added a comment. Fixed inset REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=77482=77588 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695 AFFECTED

D28033: Create ExpandableListItem

niccolove added a comment. Strongly agree on having a single component. By the way, all these lists have the issue that the button only appearing on hover is very touch-unfriendly. This does not have to be addressed in this patch, but it having it implemented in only one place makes it much

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove planned changes to this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart, ngraham Cc: ngraham, davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove updated this revision to Diff 77482. niccolove added a comment. Added PlasmoidHeading to qmldir REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=77418=77482 BRANCH master REVISION DETAIL

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove updated this revision to Diff 77418. niccolove added a comment. Trailing spaces REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=77408=77418 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove updated this revision to Diff 77408. niccolove added a comment. use heading instead of header REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=77405=77408 BRANCH master REVISION DETAIL

D27444: Added plasmoid heading svg

niccolove edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27444 To: niccolove, #vdg, ngraham, ndavis Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27444: Added plasmoid heading svg

niccolove retitled this revision from "Added top area" to "Added plasmoid heading svg". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27444 To: niccolove, #vdg, ngraham, ndavis Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D27444: Added top area

niccolove updated this revision to Diff 77407. niccolove added a comment. Changed filename to heading REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27444?vs=77272=77407 BRANCH top_area (branched from master) REVISION DETAIL

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove updated this revision to Diff 77405. niccolove added a comment. bottomPadding rather than bottomMargin REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=77404=77405 BRANCH master REVISION DETAIL

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove updated this revision to Diff 77404. niccolove added a comment. Missed a PlasmoidHeading. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=77402=77404 BRANCH master REVISION DETAIL

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove updated this revision to Diff 77402. niccolove added a comment. Local is not a type REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=77271=77402 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695

D25334: Added transparent blue background to tabbars

niccolove abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25334 To: niccolove, #vdg, ngraham, ndavis Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27445: Move tasks from 3px to 2px

niccolove abandoned this revision. niccolove added a comment. I'd actually prefer to make the task manager extend to panel borders. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27445 To: niccolove, #vdg Cc: ndavis, ngraham,

D27444: Added top area

niccolove updated this revision to Diff 77272. niccolove added a comment. Renamed file as plasmoidheader and used scour REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27444?vs=76562=77272 BRANCH top_area (branched from master)

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove updated this revision to Diff 77271. niccolove added a comment. documentation REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=77266=77271 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695 AFFECTED

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove updated this revision to Diff 77266. niccolove added a comment. using =| REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=77263=77266 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695 AFFECTED FILES

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart Cc: davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove updated this revision to Diff 77263. niccolove added a comment. Correct padding and borders REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=76947=77263 BRANCH master REVISION DETAIL

  1   2   3   >