Re: VDG application design sprint?

2024-04-17 Thread Noah Davis
Any month except for April (too soon) and September (Akademy 2024), up to 1 week in duration On Thu, Apr 11, 2024 at 10:26 AM Nicolas Fella wrote: > > On 1/24/23 00:43, Nicolas Fella wrote: > > Hi, > > > > I think it would make sense for us to have a VDG sprint of sorts in the > > near-ish

Re: Reviewer for Konqueror needed

2022-11-01 Thread Noah Davis
On Tue, Nov 1, 2022 at 7:26 AM Reindl Harald wrote: > Am 01.11.22 um 09:31 schrieb Stefano Crocco: > > Are you sure? On my system it works as expected. Maybe you don't have the > > corresponding option enabled > then some random update disabled it - i use konqueror since 2006 as my > primary file

Re: Sponsor request for Klassy

2022-08-31 Thread Noah Davis
On Wed, Aug 31, 2022 at 5:56 AM Paul A McAuley wrote: > [snip] > I am open to consider being flexible in the direction of the project. For > example, I could make a less customizable build configuration, or change the > name if deemed necessary. That isn't necessarily required for becoming a KDE

Re: Loosening the commit limit for work branches

2022-08-24 Thread Noah Davis
17:26:33 CEST Noah Davis wrote: > > On Wed, Aug 24, 2022 at 5:12 PM Milian Wolff wrote: > > > Without any knowledge of your work on the QML port of Spectacle, I would > > > also claim that there is bound to be a lot of generic work that should be > > > possi

Re: Loosening the commit limit for work branches

2022-08-24 Thread Noah Davis
On Wed, Aug 24, 2022 at 5:12 PM Milian Wolff wrote: > Without any knowledge of your work on the QML port of Spectacle, I would also > claim that there is bound to be a lot of generic work that should be possible > to land directly in the main branch, no? You are probably splitting up the > data

Loosening the commit limit for work branches

2022-08-24 Thread Noah Davis
A week ago, I ran into an unexpected issue while working on a QML port of Spectacle. There is an undocumented pre-receive hook that sets a 100 commit limit for all branches of official repos, including work branches. The error message it gave me told me to file a sysadmin ticket, so I did that.

Re: Introduction of new Nextcloud instance

2021-07-21 Thread Noah Davis
Thank you for doing this! I noticed that new documents created from the new file menu button use Microsoft Office formats (e.g., docx, xlsx). Can you swich the default formats to OpenDocument formats? On Wed, Jul 21, 2021 at 7:36 AM Ben Cooksley wrote: > > Good morning community, > > As some of

qqc2-breeze-stlye in KDE Review

2021-01-07 Thread Noah Davis
https://invent.kde.org/plasma/qqc2-breeze-style/ qqc2-breeze-style is a Qt Quick Controls 2 style made with Qt Quick and Kirigami. It has a visual style that is meant to match the Visual Design Group's vision for Breeze. My motivations for making this include the following reasons. - Creating,

Re: How is that border color defined? (system color schemes)

2020-10-14 Thread Noah Davis
KColorUtils::mix( palette.color( QPalette::Window ), palette.color( QPalette::WindowText ), 0.25 ) On Tue, Oct 13, 2020 at 2:25 PM chiasa.men wrote: > > https://pasteboard.co/JvupDV3.png > > Per trial and error I assumed the line (border of list view (vertical right > under the cursor)) color:

Re: Windows CI Updated to Qt 5.15 - Temporarily KO due to Breeze Icons Breakage

2020-10-09 Thread Noah Davis
It should have already been fixed a few hours ago. On Tue, Oct 6, 2020 at 2:26 PM Nate Graham wrote: > > Noah, could yo take a look? Seems related to porting the autogenerated > 24px icon script to Python. > > Nate > > > On 10/6/20 11:26 AM, Ben Cooksley wrote: > > On Wed, Oct 7, 2020 at 4:49 AM

Re: Windows CI Updated to Qt 5.15 - Temporarily KO due to Breeze Icons Breakage

2020-10-06 Thread Noah Davis
It should have already been fixed a few hours ago. On Tue, Oct 6, 2020 at 2:26 PM Nate Graham wrote: > > Noah, could yo take a look? Seems related to porting the autogenerated > 24px icon script to Python. > > Nate > > > On 10/6/20 11:26 AM, Ben Cooksley wrote: > > On Wed, Oct 7, 2020 at 4:49 AM

D27223: add kirigami-gallery icon

2020-07-29 Thread Noah Davis
ndavis abandoned this revision. ndavis added a comment. I've committed the icon. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27223 To: ndavis, mart, #vdg, ngraham, mbruchert Cc: ngraham, ognarb, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh,

D27223: add kirigami-gallery icon

2020-07-29 Thread Noah Davis
ndavis commandeered this revision. ndavis edited reviewers, added: mbruchert; removed: ndavis. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27223 To: ndavis, mart, #vdg, ngraham, mbruchert Cc: ngraham, ognarb, ndavis, kde-frameworks-devel, LeGast00n, cblack,

D27223: add kirigami-gallery icon

2020-06-08 Thread Noah Davis
ndavis added a comment. I think I'd prefer to keep this similar to the original Kirigami icon. Do you mind if I commandeer this? I've already made the changes. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27223 To: mbruchert, mart, #vdg, ndavis, ngraham Cc:

D27223: add kirigami-gallery icon

2020-06-08 Thread Noah Davis
ndavis added a comment. I noticed that the lighting in this version of the Kirigami is flipped. Is that intentional? I don't think it makes sense for the top of the K popout to be darker than the bottom. Since the light in Breeze icons comes from the top left, the top should be light, like

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

2020-06-01 Thread Noah Davis
ndavis abandoned this revision. ndavis added a comment. will move to invent.kde.org REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19952 To: ndavis, #vdg, arvidhansson Cc: ngraham, t-ask, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D17253: Fix colors for vector image mimetypes

2020-06-01 Thread Noah Davis
ndavis abandoned this revision. ndavis added a comment. will move to invent.kde.org REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17253 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D25814: [KColorScheme] Add SeparatorColor

2020-05-25 Thread Noah Davis
ndavis added a comment. How would we add the separator role to color scheme files if separator color was added to upstream Qt? Wouldn't we still need to add a separator role to KColorScheme so that we could map the color in the color scheme file to the equivalent QPalette ColorRole?

D29232: Introduce the Header color set

2020-05-20 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets BRANCH arcpatch-D29232 REVISION DETAIL https://phabricator.kde.org/D29232 To: mart, #vdg, #plasma, cblack, ndavis Cc: davidre, ndavis, cblack, kde-frameworks-devel, LeGast00n,

D29232: [WIP][RFC]Introduce the Header color set

2020-05-20 Thread Noah Davis
ndavis added a comment. Suggested colors are based on https://invent.kde.org/plasma/breeze/-/merge_requests/2 INLINE COMMENTS > kcolorscheme.cpp:258 > +static const SetDefaultColors defaultHeaderColors = { > +{ 49, 54, 59 }, // Background > +{ 59, 64, 69 }, // Alternate `

D29095: Change mouse icon to have better dark theme contrast

2020-05-19 Thread Noah Davis
ndavis closed this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29095 To: ndavis, #vdg, saligari, ngraham Cc: bruns, ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh

D24975: Change some 32px action icons to color style

2020-05-19 Thread Noah Davis
ndavis abandoned this revision. ndavis added a comment. Saving this for later on invent. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24975 To: ndavis, #vdg, ngraham Cc: ngraham, mglb, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D25814: [KColorScheme] Add SeparatorColor

2020-05-19 Thread Noah Davis
ndavis abandoned this revision. ndavis added a comment. Abandoning this since others would rather have this in QPalette REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25814 To: ndavis, #frameworks, #vdg Cc: ahiemstra, broulik, manueljlin, alexde, ngraham,

D29802: Require out-of-source builds

2020-05-17 Thread Noah Davis
ndavis accepted this revision. REPOSITORY R266 Breeze Icons BRANCH require-in-source-build (branched from master) REVISION DETAIL https://phabricator.kde.org/D29802 To: ngraham, #frameworks, #vdg, ognarb, davidre, apol, nicolasfella, ndavis Cc: ltoscano, davidre, kde-frameworks-devel,

D29739: Add 48px places icons

2020-05-15 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R266 Breeze Icons BRANCH 48px-places (branched from master) REVISION DETAIL https://phabricator.kde.org/D29739 To: manueljlin, #vdg, ngraham, ndavis Cc: ngraham,

D29739: Add 48px places icons

2020-05-14 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. I have to say, I'm very impressed overall. There are a few things I'd like to see changed though: folder-documents should use a single page, not the copy icon F8320517:

D29740: [PC3 Button] Don't remain in a pressed state after press

2020-05-14 Thread Noah Davis
ndavis added a comment. In D29740#671221 , @filipf wrote: > The more I think about this the more it feels like a workaround. Presuming QQC2's behavior of leaving a pressed button focused after press is correct, perhaps we are at fault for

D29739: Add 48px places icons

2020-05-14 Thread Noah Davis
ndavis added inline comments. INLINE COMMENTS > index.theme:477 > > #32x32 - Scalable - For folder icons >!!!ONLY!!!< - Scalable to the > following sizes: 64x64 (default), 32x32, 128x128, 256x256 - > DO_NOT_USE_ANYWHERE_ELSE - Color > [places/32] This and the other comments should

D29739: Add 48px places icons

2020-05-14 Thread Noah Davis
ndavis added a comment. In D29739#671163 , @manueljlin wrote: > should line 495 "## Status" actually be removed? No. Phabricator doesn't keep the original context for those comments if you change the code they were referring to.

D29739: Add 48px places icons

2020-05-14 Thread Noah Davis
ndavis added a comment. I just noticed, the new auto-generated 24px places icons aren't being used because the places/24 folder isn't in the index.theme files, but that's outside the scope of this patch. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29739

D29739: Add 48px places icons

2020-05-14 Thread Noah Davis
ndavis added a comment. comments apply to both files INLINE COMMENTS > index.theme:105 > > >

D29739: Add 48px places icons

2020-05-14 Thread Noah Davis
ndavis added a comment. You'll also need to update the index.theme files to include places/48 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29739 To: manueljlin, #vdg Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29534: Implement scroll and drag adjustment of values for SpinBox control

2020-05-08 Thread Noah Davis
ndavis added a comment. I don't like the look of those +/- buttons. I think this makes it harder to know that you can drag the height up and down. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29534 To: ngraham, #vdg, #plasma Cc: ndavis,

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

2020-05-08 Thread Noah Davis
ndavis added a comment. I generally prefer type 1 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ndavis, filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D29238: Use Standard "Show/Hide Hidden files" shortcuts in directory chooser dialog

2020-05-06 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH use-standard-show-hide-files-shortcuts (branched from master) REVISION DETAIL https://phabricator.kde.org/D29238 To: ngraham, #plasma,

D25814: [KColorScheme] Add SeparatorColor

2020-05-06 Thread Noah Davis
ndavis added a comment. OK, I can agree with contributing upstream. I'll try talking on that bug report. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25814 To: ndavis, #frameworks, #vdg Cc: ahiemstra, broulik, manueljlin, alexde, ngraham, davidedmundson,

D29434: Use small font for ExpandableListItem subtitle

2020-05-05 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH ExpandableListItem-small-subtitle-font (branched from master) REVISION DETAIL https://phabricator.kde.org/D29434 To: ngraham, #plasma, #vdg, broulik, ndavis

D25814: [KColorScheme] Add SeparatorColor

2020-05-05 Thread Noah Davis
ndavis added a comment. In D25814#598380 , @cfeck wrote: > > Why don't focus and hover colors belong? > > Because an application cannot know if and how a style does indicate focus or hovering. I don't understand this objection. What

D29232: [WIP][RFC]Introduce the Header color set

2020-04-27 Thread Noah Davis
ndavis added inline comments. INLINE COMMENTS > davidre wrote in kcolorscheme.cpp:271 > I would have expected at least of one the new colors to have the same value > as this one. Why is that? The only one that might is Active, but that's not really used much right now. REPOSITORY R265

D29095: Change mouse icon to have better dark theme contrast

2020-04-27 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29095 To: ndavis, #vdg, saligari Cc: bruns, ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh

D29095: Change mouse icon to have better dark theme contrast

2020-04-27 Thread Noah Davis
ndavis updated this revision to Diff 81374. ndavis added a comment. - Change kmousetool and preferences-desktop-mouse to symlinks REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29095?vs=81211=81374 BRANCH arcpatch-D29095 REVISION DETAIL

D29095: Change mouse icon to have better dark theme contrast

2020-04-27 Thread Noah Davis
ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29095 To: ndavis, #vdg, saligari Cc: bruns, ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh

D29232: [WIP][RFC]Introduce the Tools color set

2020-04-27 Thread Noah Davis
ndavis added inline comments. INLINE COMMENTS > kcolorscheme.h:133 > * Number of color sets. > + * Note: don't use this > * @since 5.65 I think it would be good to explain the issue about enums being converted into plain integers here so that people know why they

D29232: [WIP][RFC]Introduce the Tools color set

2020-04-27 Thread Noah Davis
ndavis added inline comments. INLINE COMMENTS > kcolorscheme.h:127 > +/** > + * Colors for header areas that thould be used both by the top > toolbar and the titlebar titlebar. > + * @since 5.69 - `thould` - `titlebar titlebar` REPOSITORY R265 KConfigWidgets BRANCH

D29232: [WIP][RFC]Introduce the Tools color set

2020-04-27 Thread Noah Davis
ndavis added a comment. I personally think it should be Header since Tools sound ambiguous and oddly limited to anyone unfamiliar with the context behind this patch REPOSITORY R265 KConfigWidgets BRANCH phab/toolsSet REVISION DETAIL https://phabricator.kde.org/D29232 To: mart, #vdg,

D29095: Change mouse icon to have better dark theme contrast

2020-04-25 Thread Noah Davis
ndavis retitled this revision from "Change mouse icon to have better dark theme contrast." to "Change mouse icon to have better dark theme contrast". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29095 To: ndavis, #vdg, saligari Cc: bruns, ouwerkerk, ndavis,

D29095: Change mouse icon to have better dark theme contrast.

2020-04-25 Thread Noah Davis
ndavis updated this revision to Diff 81211. ndavis added a comment. - Change style REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29095?vs=81156=81211 BRANCH arcpatch-D29095 REVISION DETAIL https://phabricator.kde.org/D29095 AFFECTED FILES

D29095: Change mouse icon to have better dark theme contrast.

2020-04-25 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29095 To: ndavis, #vdg, saligari Cc: bruns, ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh

D29095: Change mouse icon to have better dark theme contrast.

2020-04-25 Thread Noah Davis
ndavis retitled this revision from "New much simpler mouse icon that works in both light and dark breeze" to "Change mouse icon to have better dark theme contrast.". ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-25 Thread Noah Davis
ndavis commandeered this revision. ndavis added a reviewer: saligari. ndavis added a comment. Saligari is Ok with me taking over this patch. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29095 To: ndavis, #vdg, saligari Cc: bruns, ouwerkerk, ndavis, ngraham,

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-25 Thread Noah Davis
ndavis added a comment. In D29095#656819 , @saligari wrote: > Oh the shame! I had forgotten to center it (and I do know how to)! > > One thing I don't know is: since I centered it and used the guidelines my 1px line centered sits on a 0,5 to

D29171: Add 16px konversation icon

2020-04-25 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH konversation16px (branched from master) REVISION DETAIL https://phabricator.kde.org/D29171 To: manueljlin, #vdg, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack,

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-24 Thread Noah Davis
ndavis added a comment. It's a bit off center and I'd prefer if lines were more aligned with pixels. That way the icon doesn't change in how it looks when you scale it up. You may need to lighten the colors of your lines to maintain the original appearance. You see what I'm seeing? Do

D29072: Optimize SVG

2020-04-24 Thread Noah Davis
ndavis added a comment. In D29072#654363 , @guoyunhe wrote: > I do try scour but the result is disappointing. I get 16 times the following error: > > hge difference of 123 in ./icons-dark/apps/48/hwinfo.svg > > > which means 16

D27252: add maui index icon in pm style

2020-04-24 Thread Noah Davis
ndavis added inline comments. INLINE COMMENTS > ndavis wrote in index.svg:35 > This one can't be seen, so get rid of it. Just realized this comment could be easily mistaken for me saying to get rid of the shadow because of how the phabricator UI looks. I'm talking about a blue rectangle.

D27252: add maui index icon in pm style

2020-04-24 Thread Noah Davis
ndavis added a comment. @cblack is right, breeze icons tend to be sharper, but there's no rule requiring sharpness and I've accepted similar icons recently (maybe I should edit those a bit, but they're still good). However, I'm not sure how we'll differentiate this from Dolphin if we make

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Noah Davis
ndavis added a comment. Yes, I agree that the mouse should have fairly realistic and modern proportions. My favorite icons in Breeze are the ones that look pretty realistic while still maintaining the soft gradients and shadows. REPOSITORY R266 Breeze Icons REVISION DETAIL

D29098: Removed kde logo from sd and memory stick (/devices/64)

2020-04-22 Thread Noah Davis
ndavis added a comment. yes, I agree with @ngraham REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29098 To: saligari, #vdg Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Noah Davis
ndavis added a comment. Regarding SVG optimization, the main point of it these days is to make the code easier to read, not to get the smallest size possible. Use the settings on this page for your SVG optimizer: https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips REPOSITORY

D29072: Optimize SVG

2020-04-21 Thread Noah Davis
ndavis added a comment. The Scour settings I recommend are `--set-precision=8 --enable-viewboxing --enable-comment-stripping --remove-descriptive-elements --create-groups --strip-xml-space --strip-xml-prolog --nindent=4` REPOSITORY R266 Breeze Icons REVISION DETAIL

D29070: add alligator icon

2020-04-21 Thread Noah Davis
ndavis accepted this revision. REPOSITORY R266 Breeze Icons BRANCH alligator (branched from master) REVISION DETAIL https://phabricator.kde.org/D29070 To: mbruchert, tfella, #vdg, ndavis Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29072: Optimize SVG

2020-04-21 Thread Noah Davis
ndavis added a comment. If we're going to actually use the optimization script, we should use `scour` instead of SVGO. Scour is the SVG optimizer that is least likely to screw up and SVG. These days, the purpose of SVG optimization is to make the code readable. REPOSITORY R266 Breeze

D29072: Optimize SVG

2020-04-21 Thread Noah Davis
ndavis added a comment. > You can check pixel diff in Git Cola. How do I do this? I was not aware of that feature. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29072 To: guoyunhe, #breeze, ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack,

D29032: Add 16px Vvave icon

2020-04-21 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH vvave16px (branched from master) REVISION DETAIL https://phabricator.kde.org/D29032 To: manueljlin, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack,

D29049: add telephant icon

2020-04-21 Thread Noah Davis
ndavis accepted this revision. REPOSITORY R266 Breeze Icons BRANCH telephant (branched from master) REVISION DETAIL https://phabricator.kde.org/D29049 To: mbruchert, muesli, #vdg, ndavis Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29069: Falkon icon - Removing circle & adding outline

2020-04-21 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. I don't think this is necessary. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29069 To: saligari, #vdg, abetts, #falkon, ndavis Cc: ndavis,

D29032: Add 16px Vvave icon

2020-04-20 Thread Noah Davis
ndavis added a comment. There is already a newer vvave icon with a different style, but not at 16px. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29032 To: manueljlin, #vdg Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29027: Move document corner fold to top right in two icons

2020-04-20 Thread Noah Davis
ndavis accepted this revision. REPOSITORY R266 Breeze Icons BRANCH update-document-close REVISION DETAIL https://phabricator.kde.org/D29027 To: davidhurka, ndavis, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

2020-04-20 Thread Noah Davis
ndavis added a comment. I'm sorry this happened. I was working with what I could see. For what it's worth, I would have accepted it if you said it could not be done well. I know I don't know as much about the technical side of this as you do. REPOSITORY R265 KConfigWidgets REVISION

D27220: add pix icon

2020-04-19 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH pix (branched from master) REVISION DETAIL https://phabricator.kde.org/D27220 To: mbruchert, camiloh, #vdg, ndavis Cc: ngraham, IlyaBizyaev, kde-frameworks-devel,

D28923: Update links in README.md

2020-04-17 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:e5dfa14b64a6: Update links in README.md (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28923?vs=80414=80423 REVISION DETAIL

D28923: Update links in README.md

2020-04-17 Thread Noah Davis
ndavis added a subscriber: alex-l. ndavis added inline comments. INLINE COMMENTS > ngraham wrote in README.md:22 > Should we mention this? Is it still a thing? It hasn't been used much for quite a while, but I don't think @alex-l would like it if we didn't include it. I'm in there, so at least

D28923: Update links in README.md

2020-04-17 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY - Change the HIG link to hig.kde.org - Changed the bugtracker link to include the icons

D28766: Add auth-sim-locked and auth-sim-missing

2020-04-11 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:169b438c9fc1: Add auth-sim-locked and auth-sim-missing (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28766?vs=79895=79896 REVISION

D28766: Add auth-sim-locked and auth-sim-missing

2020-04-11 Thread Noah Davis
ndavis edited the test plan for this revision. ndavis added a project: Plasma: Mobile. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28766 To: ndavis, #vdg Cc: kde-frameworks-devel, salvahg, Orage, LeGast00n, cblack, hannahk, frmdstryr, fbampaloukas, emrek,

D28766: Add auth-sim-locked and auth-sim-missing

2020-04-11 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY For Plasma Mobile REPOSITORY R266 Breeze Icons BRANCH sim-card (branched from master)

D28737: Add sim card device icons

2020-04-11 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:95ebf0c1d3ea: Add sim card device icons (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28737?vs=79800=79839 REVISION DETAIL

D28737: Add sim card device icons

2020-04-10 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28737 To: ndavis, #vdg Cc: kde-frameworks-devel, Orage, LeGast00n, cblack, hannahk, frmdstryr, fbampaloukas, GB_2, emrek, mkraemer, cahfofpai, asghaier, michaelh,

D28737: Add sim card device icons

2020-04-10 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY For Plasma Mobile REPOSITORY R266 Breeze Icons BRANCH sim-card (branched from master)

D28737: Add sim card device icons

2020-04-10 Thread Noah Davis
ndavis added a project: Plasma: Mobile. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28737 To: ndavis, #vdg Cc: kde-frameworks-devel, Orage, LeGast00n, cblack, hannahk, frmdstryr, fbampaloukas, GB_2, emrek, mkraemer, cahfofpai, asghaier, michaelh, tbalzer,

D19736: Add rotation icons

2020-04-10 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:48a112fb64dc: Add rotation icons (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19736?vs=79765=79791 REVISION DETAIL

D19736: Add rotation icons

2020-04-10 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19736 To: ndavis, #vdg, apol Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D19736: Add rotation icons

2020-04-10 Thread Noah Davis
ndavis retitled this revision from "Add view-orientation-auto/landscape/portrait" to "Add rotation icons". ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19736 To: ndavis, #vdg, apol Cc: ngraham, kde-frameworks-devel,

D19736: Add view-orientation-auto/landscape/portrait

2020-04-10 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19736 To: ndavis, #vdg, apol Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D19736: Add view-orientation-auto/landscape/portrait

2020-04-10 Thread Noah Davis
ndavis updated this revision to Diff 79765. ndavis added a comment. - Update style REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19736?vs=55804=79765 BRANCH rotate (branched from master) REVISION DETAIL https://phabricator.kde.org/D19736

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

2020-04-07 Thread Noah Davis
ndavis added a comment. I could probably make the python script instead, but I'm in the same spot when it comes to writing CMake. TASK DETAIL https://phabricator.kde.org/T12855 To: ndavis Cc: ndavis, ngraham, kde-frameworks-devel, davidhurka, dmenig, manueljlin, Orage, LeGast00n, cblack,

D28606: Add iconSize property to PC2 ToolButton

2020-04-06 Thread Noah Davis
ndavis abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28606 To: ndavis, #plasma, mart Cc: davidedmundson, broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28606: Add iconSize property to PC2 ToolButton

2020-04-05 Thread Noah Davis
ndavis added a comment. In D28606#642513 , @ngraham wrote: > Darn. Maybe we should fix the PC3 tooltips though? :) Maybe, but I don't know what that would entail. For more context: I asked Kai about porting notifications to PC3 so that

D28606: Add iconSize property to PC2 ToolButton

2020-04-05 Thread Noah Davis
ndavis added a comment. In D28606#642514 , @ngraham wrote: > Adding Marco as a reviewer since I know he just lves ToolButton sizing. :) This doesn't actually affect toolbutton sizing, just icon sizing. Although, if you

D28606: Add iconSize property to PC2 ToolButton

2020-04-05 Thread Noah Davis
ndavis added a subscriber: broulik. ndavis added a comment. In D28606#642509 , @ngraham wrote: > If the developer has these needs, why not port to the PC3 version, which has this feature already? @broulik said we can't do that for some

D28606: Add iconSize property to PC2 ToolButton

2020-04-05 Thread Noah Davis
ndavis added a comment. I'm getting a binding loop: : QML QQuickLayoutAttached: Binding loop detected for property "minimumWidth" I'm guessing that's `Layout.minimumWidth` inside the `ToolButtonStyle` `IconItem` REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D28606: Add iconSize property to PC2 ToolButton

2020-04-05 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28606 To: ndavis, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28606: Add iconSize to PC2 ToolButton

2020-04-05 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY iconSize sets the size of the ToolButton's icon if it is set to a value. If no value

D28606: Add iconSize property to PC2 ToolButton

2020-04-05 Thread Noah Davis
ndavis retitled this revision from "Add iconSize to PC2 ToolButton" to "Add iconSize property to PC2 ToolButton". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28606 To: ndavis, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28553: Rename stylesheet color ButtonFocus -> Highlight

2020-04-05 Thread Noah Davis
ndavis added a comment. @davidhurka Actually, I'm using Highlight. I still can't get ButtonFocus to work reliably and Highlight in icons now changes to white when a UI element gets highlighted, which is good. BTW, join the VDG chat if you haven't already. REPOSITORY R266 Breeze Icons

D28579: Improve the look of kcachegrind

2020-04-05 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:0e3911c84d37: Improve the look of kcachegrind (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28579?vs=79359=79428 REVISION DETAIL

D28561: Remove border from format-border-set-* icons

2020-04-05 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. LGTM REPOSITORY R266 Breeze Icons BRANCH simplify-format-border REVISION DETAIL https://phabricator.kde.org/D28561 To: davidhurka, #vdg, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28561: Remove border from format-border-set-* icons

2020-04-04 Thread Noah Davis
ndavis added a comment. Remove the border. I don't think it makes any sense to use different styled borders to show a lack of borders in certain places. REPOSITORY R266 Breeze Icons BRANCH simplify-format-border REVISION DETAIL https://phabricator.kde.org/D28561 To: davidhurka,

D28561: Remove border from format-border-set-* icons

2020-04-04 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH simplify-format-border REVISION DETAIL https://phabricator.kde.org/D28561 To: davidhurka, #vdg, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D28573: Add 16px System Settings icon

2020-04-04 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28573 To: manueljlin, #vdg, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

  1   2   3   4   5   6   7   8   9   10   >