D12015: Add docs to the user manual about the terminal key bindings

yurchor requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R319 Konsole REVISION DETAIL https://phabricator.kde.org/D12015 To: ahmadsamir, #konsole, hindenburg, yurchor Cc: ltoscano, kde-doc-english, hindenburg, #konsole, herrold, ngraham

D12015: Add docs to the user manual about the terminal key bindings

yurchor added inline comments. INLINE COMMENTS > index.docbook:1332 > + > + > +How Uses Key Bindings Would it be better to have multiple sect1s (sect2s -> sect1s) in a chapter rather than have just one? > index.docbook:1337 > +Introduction > + uses *.keytab files to translate key

[khelpcenter] [Bug 387891] [suggestion]: add support for compiled Qt help collections (qthelp:)

https://bugs.kde.org/show_bug.cgi?id=387891 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

D12015: Add docs to the user manual about the terminal key bindings

ahmadsamir added a comment. I couldn't find a guide on how to get my name and email added to the docbook entities in KDE, I would appreciate any pointers about that. Also, should I add the docs team on this review or is there another way to notify them about this docbook addition?

D12015: Add docs to the user manual about the terminal key bindings

ahmadsamir added a comment. I totally missed the Newline mode, I'll update the diff (hopefully soon). REPOSITORY R319 Konsole REVISION DETAIL https://phabricator.kde.org/D12015 To: ahmadsamir, #konsole, hindenburg Cc: kde-doc-english, hindenburg, #konsole, herrold, ngraham

D12015: Add docs to the user manual about the terminal key bindings

ahmadsamir created this revision. ahmadsamir added reviewers: Konsole, hindenburg. Restricted Application added a project: Konsole. Restricted Application added a subscriber: kde-doc-english. ahmadsamir requested review of this revision. REVISION SUMMARY Also mention the manual on the Keyboard

D12015: Add docs to the user manual about the terminal key bindings

ltoscano added a comment. The doc team was automatically added as subscriber. Regarding the entity, just expand it inline, or define the entity in this file: we add it for people who have more contributions (and it would introduce a dependency on a new version of Frameworks, so you would

D12015: Add docs to the user manual about the terminal key bindings

ahmadsamir updated this revision to Diff 31622. ahmadsamir edited the summary of this revision. ahmadsamir removed a reviewer: yurchor. ahmadsamir removed a subscriber: ltoscano. ahmadsamir added a comment. I finally found doc/user/README.keyboard which mentioned some more stuff about the key

D12015: Add docs to the user manual about the terminal key bindings

ahmadsamir added reviewers: yurchor, ltoscano. REPOSITORY R319 Konsole BRANCH keybinding-editor-docs (branched from master) REVISION DETAIL https://phabricator.kde.org/D12015 To: ahmadsamir, #konsole, hindenburg, yurchor, ltoscano Cc: kde-doc-english, hindenburg, #konsole, herrold,

[kinit/v5.45.0-rc1] po: GIT_SILENT Commit translations from l10n-kf5 (silent)

Git commit 22c13d123d83856388c4d1f4c1226cc235857f15 by l10n daemon script. Committed on 07/04/2018 at 19:36. Pushed by dfaure into tag 'v5.45.0-rc1'. GIT_SILENT Commit translations from l10n-kf5 A +116 -0po/af/kinit5.po A +131 -0po/ar/kinit5.po A +119 -0po/as/kinit5.po A +112

[kdoctools/v5.45.0-rc1] po: GIT_SILENT Commit translations from l10n-kf5 (silent)

Git commit 9b33693ad0258cffd633ac819005248a1940153a by l10n daemon script. Committed on 07/04/2018 at 19:35. Pushed by dfaure into tag 'v5.45.0-rc1'. GIT_SILENT Commit translations from l10n-kf5 A +37 -0po/af/kdoctools5.po A +39 -0po/ar/kdoctools5.po A +38 -0

[kdelibs4support/v5.45.0-rc1] po: GIT_SILENT Commit translations from l10n-kf5 (silent)

Git commit 257f2735bb8f2d7eeb84ed43839ac798b4d230af by l10n daemon script. Committed on 07/04/2018 at 19:34. Pushed by dfaure into tag 'v5.45.0-rc1'. GIT_SILENT Commit translations from l10n-kf5 A +14167 -0po/af/kdelibs4support.po A +13558 -0po/ar/kdelibs4support.po A +13790 -0

[kconfigwidgets/v5.45.0-rc1] po: GIT_SILENT Commit translations from l10n-kf5 (silent)

Git commit f3da6579282c7ab26f5708ead576254afc311eee by l10n daemon script. Committed on 07/04/2018 at 19:33. Pushed by dfaure into tag 'v5.45.0-rc1'. GIT_SILENT Commit translations from l10n-kf5 A +660 -0po/af/kconfigwidgets5.po A +99 -0po/af/kf5_entry.desktop [TRAILING SPACE] ** A

[kdesignerplugin/v5.45.0-rc1] po: GIT_SILENT Commit translations from l10n-kf5 (silent)

Git commit bb1b2ddd46ee9da3a50a2e8cd0717bbacb5c20b9 by l10n daemon script. Committed on 07/04/2018 at 19:34. Pushed by dfaure into tag 'v5.45.0-rc1'. GIT_SILENT Commit translations from l10n-kf5 A +74 -0po/af/kdesignerplugin5_qt.po A +66 -0po/ar/kdesignerplugin5_qt.po A +85 -0

[kservice/v5.45.0-rc1] po: GIT_SILENT Commit translations from l10n-kf5 (silent)

Git commit 4816d0939680032e35ca7b8ad4075c40ae2c9453 by l10n daemon script. Committed on 07/04/2018 at 19:38. Pushed by dfaure into tag 'v5.45.0-rc1'. GIT_SILENT Commit translations from l10n-kf5 A +213 -0po/af/kservice5.po A +220 -0po/ar/kservice5.po A +224 -0po/as/kservice5.po

[kross/v5.45.0-rc1] po: GIT_SILENT Commit translations from l10n-kf5 (silent)

Git commit 7e009c1afe65d962a146e203d3f04ffd5b1d6884 by l10n daemon script. Committed on 07/04/2018 at 19:38. Pushed by dfaure into tag 'v5.45.0-rc1'. GIT_SILENT Commit translations from l10n-kf5 A +201 -0po/af/kross5.po A +223 -0po/ar/kross5.po A +209 -0po/as/kross5.po A +200

[kwallet/v5.45.0-rc1] po: GIT_SILENT Commit translations from l10n-kf5 (silent)

Git commit 3fdb4062343ecae5f4d2af08c17c49b87976f5c7 by l10n daemon script. Committed on 07/04/2018 at 19:39. Pushed by dfaure into tag 'v5.45.0-rc1'. GIT_SILENT Commit translations from l10n-kf5 A +784 -0po/ar/kwalletd5.po A +135 -0po/ast/kwallet-query.po A +743 -0

[plasma-framework/v5.45.0-rc1] po: GIT_SILENT Commit translations from l10n-kf5 (silent)

Git commit 28e4ecb1acc1d9ddf381ac20cba327214bf80115 by l10n daemon script. Committed on 07/04/2018 at 19:40. Pushed by dfaure into tag 'v5.45.0-rc1'. GIT_SILENT Commit translations from l10n-kf5 A +807 -0po/ar/libplasma5.po A +802 -0po/ast/libplasma5.po A +860 -0

D12015: Add docs to the user manual about the terminal key bindings

ahmadsamir updated this revision to Diff 31609. ahmadsamir added a comment. Add a section about NewLine mode Replace "Return" with Carriage Return in the output field section Change version to 18.08 REPOSITORY R319 Konsole CHANGES SINCE LAST UPDATE

[kjsembed/v5.45.0-rc1] po: GIT_SILENT Commit translations from l10n-kf5 (silent)

Git commit a5f534b7e33c495fedaf7076c1446d0e98fd05c0 by l10n daemon script. Committed on 07/04/2018 at 19:37. Pushed by dfaure into tag 'v5.45.0-rc1'. GIT_SILENT Commit translations from l10n-kf5 A +250 -0po/af/kjsembed5.po A +269 -0po/ar/kjsembed5.po A +249 -0po/as/kjsembed5.po

[kjs/v5.45.0-rc1] po: GIT_SILENT Commit translations from l10n-kf5 (silent)

Git commit 4466638d3196970d44be677f2d57de1e953b by l10n daemon script. Committed on 07/04/2018 at 19:37. Pushed by dfaure into tag 'v5.45.0-rc1'. GIT_SILENT Commit translations from l10n-kf5 A +210 -0po/ca/docs/kjs5/man-kjs5.1.docbook A +210 -0po/de/docs/kjs5/man-kjs5.1.docbook A

[kio/v5.45.0-rc1] po: GIT_SILENT Commit translations from l10n-kf5 (silent)

Git commit 880829041105f68f598c5aa075a60fc5609d7a99 by l10n daemon script. Committed on 07/04/2018 at 19:36. Pushed by dfaure into tag 'v5.45.0-rc1'. GIT_SILENT Commit translations from l10n-kf5 A +9746 -0po/af/kio5.po A +9036 -0po/ar/kio5.po A +8443 -0po/ast/kio5.po A +8882 -0

[kpackage/v5.45.0-rc1] po: GIT_SILENT Commit translations from l10n-kf5 (silent)

Git commit c583ec64d443ece1da6455a5f59ff8243340a293 by l10n daemon script. Committed on 07/04/2018 at 19:37. Pushed by dfaure into tag 'v5.45.0-rc1'. GIT_SILENT Commit translations from l10n-kf5 A +551 -0po/ar/libkpackage5.po A +545 -0po/ast/libkpackage5.po A +586 -0

[kded/v5.45.0-rc1] po: GIT_SILENT Commit translations from l10n-kf5 (silent)

Git commit df6cb415d3e557bbd61f4f404f81f978c9069eb2 by l10n daemon script. Committed on 07/04/2018 at 19:34. Pushed by dfaure into tag 'v5.45.0-rc1'. GIT_SILENT Commit translations from l10n-kf5 A +269 -0po/ca/docs/kded5/man-kded5.8.docbook A +269 -0

D12015: Add docs to the user manual about the terminal key bindings

yurchor added inline comments. INLINE COMMENTS > index.docbook:1363 > + > +A + preceding a Mode name means that mode is > set; for a modifier key, that means it's pressed, > whereas for all other modes it means that particular mode is in effect ( > active). For example +Ctrl means the key

D12015: Add docs to the user manual about the terminal key bindings

hindenburg accepted this revision. hindenburg added a comment. Thanks, LGTM - this is too late for 18.04 so it will go in 18.08 REPOSITORY R319 Konsole BRANCH keybinding-editor-docs (branched from master) REVISION DETAIL https://phabricator.kde.org/D12015 To: ahmadsamir, #konsole,

D12015: Add docs to the user manual about the terminal key bindings

ahmadsamir updated this revision to Diff 31592. ahmadsamir marked an inline comment as done. ahmadsamir added a comment. Update the diff to address some of the issues pointed out in the review request REPOSITORY R319 Konsole CHANGES SINCE LAST UPDATE

D12015: Add docs to the user manual about the terminal key bindings

ahmadsamir marked 7 inline comments as done. ahmadsamir added a comment. In D12015#241801 , @ltoscano wrote: > The doc team was automatically added as subscriber. > Regarding the entity, just expand it inline, or define the entity in this

D12015: Add docs to the user manual about the terminal key bindings

yurchor accepted this revision. This revision is now accepted and ready to land. REPOSITORY R319 Konsole BRANCH keybinding-editor-docs (branched from master) REVISION DETAIL https://phabricator.kde.org/D12015 To: ahmadsamir, #konsole, hindenburg, yurchor Cc: ltoscano, kde-doc-english,