---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117075/
---
Review request for KDE Frameworks.
Repository: khtml
Description
On March 25, 2014, 3:33 p.m., Alex Merry wrote:
The docs need cleaning up, but I'd like to concentrate on the API first.
I'd rather this followed the convention of other file-generating macros in
getting the user to provide a variable name to store the file(s) in, rather
than
On Tuesday 25 March 2014 20:00:51 Albert Astals Cid wrote:
Can you give a rationale of why we're removing the following things?
kfile4
kfile4 is only useful to test a library that is right now on kde4support. Maybe
we can move it there if you want.
kio_cgi
Who needs to execute a cgi script
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117078/
---
Review request for KDE Frameworks.
Repository: kio
Description
---
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117078/
---
(Updated March 26, 2014, 11:50 a.m.)
Review request for KDE Frameworks
On Tuesday 25 March 2014 23:01:39 Luigi Toscano wrote:
Why kreadconfig (which includes kreadconfig and kwriteconfig) is going to be
in plasma-workspace? Isn't it useful for every KConfig-based
component/application? Maybe kde cli tools could be the target...
I thought there was another tool
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117078/
---
(Updated March 26, 2014, 12:16 p.m.)
Review request for KDE Frameworks.
See http://build.kde.org/job/kde4support_master_qt5/93/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
I'd like to move KLibrary to KDE4Support. From my investigations, I
think this will break two things: KWin and Oxygen, both of which use
KLibrary but do not link against KDE4Support.
Those should be ported to QLibrary + KPluginLoader::findPlugin(), which
I'll sort out today.
Any objections?
Hello,
we will have a Qt Contributors' Summit again.
The event is invite only, but I think many people on these lists qualify for
the event. Especially if you have lately been submitting patches through
gerrit or otherwise been involved with Qt developement consider joining.
This is a great
On Monday 17 March 2014 18:15:09 Kevin Ottens wrote:
Hello,
Thanks for the feedback!
Adding kde-promo in CC since it might have implications on future
communication.
Ok, reading the whole thing - it seems a simple dot story would be useful to
explain that we've made some decisions that
Hi!
El 26/03/2014 13:04, Jos Poortvliet jospoortvl...@gmail.com escribió:
On Monday 17 March 2014 18:15:09 Kevin Ottens wrote:
Hello,
Thanks for the feedback!
Adding kde-promo in CC since it might have implications on future
communication.
Ok, reading the whole thing - it seems a
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117080/
---
Review request for KDE Frameworks.
Repository: kio
Description
---
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117080/#review54177
---
autotests/kdirmodeltest.cpp
See http://build.kde.org/job/kcoreaddons_master_qt5/48/changes
Changes:
[agateau] Redefining tr() does *not* work
[agateau] Add Messages.sh
--
Started by remote host 127.0.0.1 with note: Triggered by commit
Building remotely on LinuxSlave - 1 (PACKAGER
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117078/#review54179
---
src/widgets/kpropertiesdialog.cpp
On March 26, 2014, 1:57 p.m., Mark Gaiser wrote:
src/widgets/kpropertiesdialog.cpp, line 1618
https://git.reviewboard.kde.org/r/117078/diff/2/?file=257291#file257291line1618
camelCase.
I would probably just name it as the function is named: isSuperUser
I just kept the
See http://build.kde.org/job/kcoreaddons_master_qt5/49/changes
Changes:
[agateau] Update to latest extract-tr-strings signature
--
Started by remote host 127.0.0.1 with note: Triggered by commit
Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117087/
---
Review request for KDE Frameworks and Chusslove Illich.
Repository:
On March 26, 2014, 12:57 p.m., Mark Gaiser wrote:
src/widgets/kpropertiesdialog.cpp, line 3444
https://git.reviewboard.kde.org/r/117078/diff/2/?file=257291#file257291line3444
If you change it anyway, you might as well go for C++11:
for(const QString userName : userNames) {...}
On March 26, 2014, 12:39 p.m., Mark Gaiser wrote:
autotests/kdirmodeltest.cpp, lines 55-56
https://git.reviewboard.kde.org/r/117080/diff/1/?file=257310#file257310line55
Do you really have to make defines for those signals? Sure, it looks
fancy in the connect lines, but i
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117049/#review54198
---
Looks sensible, but can you re-work the unittest to be
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117040/#review54195
---
Ship it!
Yeah, I don't see what the TODO is complaining
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117058/#review54201
---
Ship it!
Ship It!
- Alex Merry
On March 25, 2014, 3:48
See
http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/194/changes
Changes:
[lueck] move to proper place to get picked up by scripty
[luigi.toscano] Use DocBookXML 4.5 for documentation
[aleixpol] Port the cmake scripts with regards to documentation
[notmart]
See
http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/194/changes
Changes:
[lueck] move to proper place to get picked up by scripty
[luigi.toscano] Use DocBookXML 4.5 for documentation
[aleixpol] Port the cmake scripts with regards to documentation
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117049/
---
(Updated March 26, 2014, 3:35 p.m.)
Review request for KDE Frameworks
See http://build.kde.org/job/kbookmarks_master_qt5/38/changes
Changes:
[agateau] Use Class::tr() where possible
--
Started by remote host 127.0.0.1 with note: Triggered by commit
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace
See http://build.kde.org/job/kdeclarative_master_qt5/42/changes
Changes:
[bhush94] Add KCoreAddons plugin, moved from PlasmaCore
--
Started by remote host 127.0.0.1 with note: Triggered by commit
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER)
See
http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/195/changes
Changes:
[bhush94] Formats are now part of KDeclarative repo
--
Started by upstream project plasma-framework_master_qt5 build number 195
originally caused
See
http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/195/changes
Changes:
[bhush94] Formats are now part of KDeclarative repo
--
Started by upstream project plasma-framework_master_qt5 build number 195
originally
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117049/#review54211
---
Ship it!
Ship It!
- Alex Merry
On March 26, 2014, 2:35
See http://build.kde.org/job/kbookmarks_master_qt5/39/
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
See
http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/196/
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
See
http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/196/
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
See http://build.kde.org/job/kdeclarative_master_qt5/43/
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117089/
---
Review request for KDE Frameworks.
Repository: kservice
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117089/
---
(Updated March 26, 2014, 5:05 p.m.)
Review request for KDE Frameworks.
See http://build.kde.org/job/kio_master_qt5/119/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117089/#review54215
---
Ship it!
I think it makes sense, it's not linking with
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117089/#review54216
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117089/
---
(Updated March 26, 2014, 4:28 p.m.)
Status
--
This change has been
On March 26, 2014, 1:39 p.m., Mark Gaiser wrote:
autotests/kdirmodeltest.cpp, lines 55-56
https://git.reviewboard.kde.org/r/117080/diff/1/?file=257310#file257310line55
Do you really have to make defines for those signals? Sure, it looks
fancy in the connect lines, but i
On Wed, Mar 26, 2014 at 5:14 PM, KDE CI System n...@kde.org wrote:
See http://build.kde.org/job/kio_master_qt5/119/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
On 26/03/14 16:19, Aleix Pol wrote:
On Wed, Mar 26, 2014 at 5:14 PM, KDE CI System n...@kde.org
mailto:n...@kde.org wrote:
See http://build.kde.org/job/kio_master_qt5/119/changes
___
Kde-frameworks-devel mailing list
See http://build.kde.org/job/kio_master_qt5/120/changes
Changes:
[aleixpol] kpasswdserver as KDED module.
[aleixpol] compile fix by Nick Katsamas n...@forthnet.gr
[aleixpol] Shut the compiler up. (DA)
[aleixpol] Make all members protected.
[aleixpol] Change in the sequence number returned.
See http://build.kde.org/job/kio_master_qt5/121/changes
Changes:
[nicolas.alvarez] Fix typos in DESIGN doc for kpasswdserver.
--
Started by remote host 127.0.0.1 with note: Triggered by commit
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in
On 26/03/14 18:50, Aleix Pol wrote:
FWIW, I added the new dependency in dependency-data-kf5-qt5 after
pushing, I don't know how to trigger the build again.
You ask someone with sufficient Jenkins karma :-)
I think the dependency info updates on the hour, so I'll trigger it when
the hour ticks
Hello,
On Tuesday 25 March 2014 16:41:12 Jos Poortvliet wrote:
On Monday 17 March 2014 18:15:09 Kevin Ottens wrote:
Adding kde-promo in CC since it might have implications on future
communication.
Ok, reading the whole thing - it seems a simple dot story would be useful to
explain that
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117042/
---
(Updated March 26, 2014, 9:55 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117042/#review54242
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117037/
---
(Updated March 26, 2014, 10:01 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117037/#review54245
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117040/
---
(Updated March 26, 2014, 10:06 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117040/#review54246
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116969/#review54248
---
Ping?
- David Gil Oliva
On March 24, 2014, 9:45 p.m.,
Hi,
a) In kde4 docbooks usually were located in a top level folder named doc in
each repo, in frameworks this folder is named docs with an additional *s* ,
where as the other repos with a frameworks branch seem to use the name doc
(kate, kde-workspace as of now before the split etc.).
That is
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117103/
---
Review request for KDE Frameworks.
Repository: kde4support
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117102/
---
Review request for KDE Frameworks.
Repository: kwindowsystem
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117102/
---
(Updated March 26, 2014, 10:52 p.m.)
Review request for KDE Frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117102/
---
(Updated March 26, 2014, 10:55 p.m.)
Review request for KDE Frameworks
On March 25, 2014, 2:33 p.m., Alex Merry wrote:
The docs need cleaning up, but I'd like to concentrate on the API first.
I'd rather this followed the convention of other file-generating macros in
getting the user to provide a variable name to store the file(s) in, rather
than
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117104/
---
Review request for KDE Frameworks.
Repository: kcompletion
Description
On Wed, Mar 26, 2014 at 10:02 PM, Albert Astals Cid aa...@kde.org wrote:
El Dimecres, 26 de març de 2014, a les 11:42:01, Àlex Fiestas va escriure:
On Tuesday 25 March 2014 20:00:51 Albert Astals Cid wrote:
Can you give a rationale of why we're removing the following things?
kfile4
On Wed, Mar 26, 2014 at 12:37 PM, Carlos De Maine car...@demaine.orgwrote:
On Wed, 26 Mar 2014 11:28:24 AM Àlex Fiestas wrote:
On Wednesday 26 March 2014 09:52:08 Carlos De Maine wrote:
On Tue, 25 Mar 2014 04:18:22 PM Àlex Fiestas wrote:
Hi there
Today Aleix and I are
On Wed, Mar 26, 2014 at 11:22 PM, Burkhard Lück lu...@hube-lueck.de wrote:
Hi,
a) In kde4 docbooks usually were located in a top level folder named doc
in
each repo, in frameworks this folder is named docs with an additional
*s* ,
where as the other repos with a frameworks branch seem to
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116969/#review54254
---
I like the cleaning up, but maybe you're being too picky for
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117104/#review54255
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On March 26, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117106/
---
Review request for Documentation and KDE Frameworks.
Repository:
On Wed, March 26, 2014 23:22:22 Burkhard Lück wrote:
Hi,
I think we need a similar *consistent* scheme for docbook location in
frameworks repos.
Agreed.
You've mentioned 3 different schemes (application, kioslave, kcm modules). Is
the full list of possible schemes to be used published
70 matches
Mail list logo
