---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117799/#review56944
---
Ping?
I'm not especially impatient, but in case that it had
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117858/#review56955
---
Ship it!
Ship It!
- Aurélien Gâteau
On April 29, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117799/#review56956
---
Ship it!
The change looks reasonable to me. It's a very
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117858/#review56959
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117858/
---
(Updated April 30, 2014, 9:54 a.m.)
Status
--
This change has been
Over at Plasma we'd like to do a release of our RC after the final Frameworks
release. To be able to set a date could I ask for a reasonably firm date for
Frameworks release?
Currently Frameworks release is listed as Thursday June 1st
http://community.kde.org/Frameworks/Epics is that
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117799/#review56963
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On April 26, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117895/
---
Review request for KDE Frameworks and Aurélien Gâteau.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117895/#review56965
---
No need to rename the folder, no?
- Aleix Pol Gonzalez
On
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117895/#review56968
---
You need to change docs/CMakeLists.txt to use kdebugdialog5
On April 30, 2014, 12:44 p.m., Aleix Pol Gonzalez wrote:
No need to rename the folder, no?
the kdoctools macro relies on the folder name, so renaming it is needed.
- Aurélien
---
This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117895/
---
(Updated April 30, 2014, 11:42 a.m.)
Review request for KDE Frameworks
On None, Aurélien Gâteau wrote:
(commenting my own RR to split the discussion from the description)
I expect this function to become the most used one from this CMake module
(together with ecm_create_qm_loader()) and the
ecm_create_qm_from_po_files() to be less relevant. It is odd
On April 12, 2014, 10:48 a.m., Alex Merry wrote:
This is my preferred solution, and is hopefully only a temporary one.
However, I know David Faure doesn't like it, and (I assume) would rather
have a generic LIBEXEC variable.
My view is that libexec should be used for stuff that's
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117895/#review56977
---
Ship it!
Ship It!
- Aurélien Gâteau
On April 30, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117842/#review56978
---
Ship it!
The CMake stuff can wait until the API we are using
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117895/#review56980
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117895/
---
(Updated April 30, 2014, 12:15 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117888/#review56981
---
Well, it looks like nothing that has been ported is using it
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117805/
---
(Updated April 30, 2014, 2:33 p.m.)
Review request for Documentation,
On April 28, 2014, 5:23 p.m., Burkhard Lück wrote:
KF5DocToolsMacros.cmake, lines 220-221
https://git.reviewboard.kde.org/r/117805/diff/1/?file=268668#file268668line220
kio/docs/kioslave/foo/CMakeLists.text have
INSTALL_DESTINATION ${HTML_INSTALL_DIR}/en SUBDIR kioslave5/foo
On April 30, 2014, 2:16 p.m., Alex Merry wrote:
KF5DocToolsMacros.cmake, line 201
https://git.reviewboard.kde.org/r/117805/diff/1/?file=268668#file268668line201
I personally prefer to use lowercase for function names everywhere,
including declarations.
I prefer lowercase as
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117805/
---
(Updated April 30, 2014, 2:44 p.m.)
Review request for Documentation,
On None, Aurélien Gâteau wrote:
(commenting my own RR to split the discussion from the description)
I expect this function to become the most used one from this CMake module
(together with ecm_create_qm_loader()) and the
ecm_create_qm_from_po_files() to be less relevant. It is odd
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117895/#review56991
---
docs/kdebugdialog5/index.docbook
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117905/
---
Review request for Documentation, KDE Frameworks and Burkhard Lück.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117905/#review56997
---
Ship it!
Thanks
- Burkhard Lück
On April 30, 2014, 2:57
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117907/
---
Review request for Build System, Extra Cmake Modules, KDE Frameworks, and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117907/#review57000
---
Ship it!
Maybe we should add documentation for the newly
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117907/#review56999
---
kde-modules/KDEInstallDirs.cmake
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117905/
---
(Updated April 30, 2014, 3:28 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117907/
---
(Updated April 30, 2014, 3:34 p.m.)
Review request for Build System,
On April 29, 2014, 9:22 a.m., Jonathan Riddell wrote:
I disagree, ./src/kdecore/entry.desktop gets renamed to kf5_entry.desktop
on install and installs into /usr/share/locale/en_US/kf5_entry.desktop so
it is the locale entry.desktop file which has been renamed not the country
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117148/#review57006
---
Shouldn't we port this to
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117148/
---
(Updated April 30, 2014, 3:38 p.m.)
Review request for KDE Frameworks,
On April 29, 2014, 9:22 a.m., Jonathan Riddell wrote:
I disagree, ./src/kdecore/entry.desktop gets renamed to kf5_entry.desktop
on install and installs into /usr/share/locale/en_US/kf5_entry.desktop so
it is the locale entry.desktop file which has been renamed not the country
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117907/#review57008
---
Ship it!
Ship It!
- Alex Merry
On April 30, 2014, 3:34
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117907/
---
(Updated April 30, 2014, 3:54 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117823/
---
(Updated April 30, 2014, 6:48 p.m.)
Review request for Build System,
On March 31, 2014, 2:39 p.m., Kevin Ottens wrote:
Ship It!
Kevin Ottens wrote:
Actually scrap that, seeing the confusion around those files I might have
been mistaken myself.
Jonathan Riddell wrote:
This is looking for a language entry.desktop file as installed into
Hey all,
In looking at frameworks e-mail each day I find it would be much
simpler if we would all add the git repo we are submitting the review
request for in the subject. e-mail with subjects like make
documentation match new values in code (not trying to single this one
out, many are not that
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117889/#review57036
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117889/
---
(Updated April 30, 2014, 10:04 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117805/#review57037
---
Ship it!
Looks fine, thanks
- Luigi Toscano
On April 30,
Christoph Feck ha scritto:
On Wednesday 30 April 2014 22:55:55 Jeremy Whiting wrote:
In looking at frameworks e-mail each day I find it would be much
simpler if we would all add the git repo we are submitting the
review request for in the subject.
If you have added yourself as a maintainer
On Wed, April 30, 2014 14:55:55 Jeremy Whiting wrote:
Hey all,
In looking at frameworks e-mail each day I find it would be much
simpler if we would all add the git repo we are submitting the review
request for in the subject. e-mail with subjects like make
documentation match new values in
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117919/
---
Review request for KDE Frameworks.
Repository: kcoreaddons
Description
Ok, Added myself, good to know. That should help a bit.
On Wed, Apr 30, 2014 at 4:39 PM, Christoph Feck christ...@maxiom.de wrote:
On Wednesday 30 April 2014 22:55:55 Jeremy Whiting wrote:
In looking at frameworks e-mail each day I find it would be much
simpler if we would all add the git repo
On Wed, Apr 30, 2014 at 6:08 PM, Michael Pyne mp...@kde.org wrote:
On Wed, April 30, 2014 14:55:55 Jeremy Whiting wrote:
Hey all,
In looking at frameworks e-mail each day I find it would be much
simpler if we would all add the git repo we are submitting the review
request for in the subject.
49 matches
Mail list logo
