Re: Review Request 124878: Cache a KEmoticons instance here, not a KEmoticonsTheme.

2015-08-26 Thread Volker Krause
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124878/ --- (Updated Aug. 26, 2015, 4:11 p.m.) Status -- This change has been

Review Request 124941: Reparse notification config only when actually needed

2015-08-26 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124941/ --- Review request for KDE Frameworks. Repository: knotifications

Review Request 124940: Update config updated signal

2015-08-26 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124940/ --- Review request for KDE Frameworks. Repository: knotifyconfig

Re: Review Request 124940: Update config updated signal

2015-08-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124940/#review84432 --- +1 - David Edmundson On Aug. 26, 2015, 9:02 p.m., Martin

Re: Review Request 124940: Update config updated signal

2015-08-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124940/#review84431 --- +1 - David Edmundson On Aug. 26, 2015, 9:02 p.m., Martin

Re: Review Request 124941: Reparse notification config only when actually needed

2015-08-26 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124941/#review84428 --- src/knotificationmanager.cpp (line 3)

Re: Review Request 124941: Reparse notification config only when actually needed

2015-08-26 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124941/ --- (Updated Aug. 27, 2015, 12:08 a.m.) Review request for KDE Frameworks.

Re: Paths to internal executables (c.f. libexec) hard-coded

2015-08-26 Thread Kevin Funk
On Wednesday 26 August 2015 13:40:20 Volker Krause wrote: On Wednesday 26 August 2015 13:15:15 Kevin Funk wrote: Heya, This is problem on Windows because the *final* installation location is not known at compile-time (obviously software is installed via installers, users can pick up

Re: Review Request 124698: KPasswordDialog: allow the user to show the password

2015-08-26 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124698/#review84390 --- Very cool. But let's wait for Plasma 5.5 to be released then?

QML plugin name resolution WAS Re: Review Request 124916: also make kwindowsystem a module rather than a shared lib

2015-08-26 Thread Harald Sitter
Aloha as we noticed in https://git.reviewboard.kde.org/r/124916/ the qml plugin name resolution is pretty meh and desperately needs improving [1]. Essentially QML plugins on Linux *must* be prefixed with 'lib' e.g. libdragandrop.so If they do not have the prefix they won't get found. This is

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

2015-08-26 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124905/#review84389 --- It sounds to me like ecm_mark_non_gui_executable doesn't do

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-26 Thread David Faure
On Aug. 25, 2015, 1:41 p.m., David Edmundson wrote: I've got both Gentoo and Arch saying this causes a major problem [1]: libdraganddropplugin.so changes to draganddropplugin.so in /usr/lib/qt/qml/org/kde/draganddrop and then they don't get loaded. any ideas? Otherwise I'll

Re: Review Request 124878: Cache a KEmoticons instance here, not a KEmoticonsTheme.

2015-08-26 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124878/#review84391 --- Ship it! Please verify the unittests still pass, too. -

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

2015-08-26 Thread Kevin Funk
On Aug. 26, 2015, 7:24 a.m., David Faure wrote: It sounds to me like ecm_mark_non_gui_executable doesn't do the right thing then, and should be fixed, instead? These are non gui executables, so from an API point of view, using this function is correct. Would we ever want a

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-26 Thread Marco Martin
On Aug. 25, 2015, 2:22 p.m., René J.V. Bertin wrote: When built as SHARED as in the current code, libdraganddropplugin.dylib gets installed to $PREFIX/share/qt5/qml/org/kde/draganddrop, but is given an OS X install_name of $PREFIX/lib/libdraganddropplugin.dylib. This mismatch can

Re: Review Request 124698: KPasswordDialog: allow the user to show the password

2015-08-26 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124698/ --- (Updated Ago. 26, 2015, 10:36 a.m.) Review request for KDE Frameworks

Paths to internal executables (c.f. libexec) hard-coded

2015-08-26 Thread Kevin Funk
Heya, This is problem on Windows because the *final* installation location is not known at compile-time (obviously software is installed via installers, users can pick up the installation prefix). Of course this also limits the relocateability on other platforms, so it's not just a Windows

Re: Paths to internal executables (c.f. libexec) hard-coded

2015-08-26 Thread Volker Krause
On Wednesday 26 August 2015 13:15:15 Kevin Funk wrote: Heya, This is problem on Windows because the *final* installation location is not known at compile-time (obviously software is installed via installers, users can pick up the installation prefix). Of course this also limits the

Re: Accidentally exported private classes

2015-08-26 Thread Friedrich W. H. Kossebau
Hi Volker and all, Am Montag, 10. August 2015, 11:47:43 schrieb Volker Krause: it turns out KF5 (and PIM, which is where I started looking into this) have quite some unintentionally exported private symbols (2000+ for PIM and the KF5 subset used by it, I'd not entirely trust the tool yet

Re: Review Request 124916: also make kwindowsystem a module rather than a shared lib

2015-08-26 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124916/ --- (Updated Aug. 26, 2015, 9:36 a.m.) Status -- This change has been