Re: Review Request 125252: Clean X11/XCB detection

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125252/#review85477 --- can you please ensure whether kwindowsystem can be built that

Re: Review Request 125237: Change KKeyserver (x11) to categorized logging

> On Sept. 15, 2015, 5:35 p.m., Martin Klapetek wrote: > > src/platforms/xcb/kkeyserver.cpp, line 26 > > > > > > If you put into "debug_p.h", then you'll have only one debug > > include instead of two

Re: Building KF in version 5.14 on OSX fails for framework kdesignerplugin

On Tuesday 15 September 2015 22:50:50 Kurt Hindenburg wrote: > > > On Sep 15, 2015, at 2:07 PM, Marko Käning wrote: > > > > Hi kdesignerplugin devs, > > > > On 14 Sep 2015, at 15:00 , Kurt Hindenburg > > wrote: > >> > >> It appears the

Re: Review Request 125226: move EventForge from the desktop containment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125226/ --- (Updated Sept. 16, 2015, 9:12 a.m.) Review request for KDE Frameworks,

Review Request 125253: KSycoca: move all of the kbuildsycoca code into the lib, except for main().

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125253/ --- Review request for KDE Frameworks and Albert Astals Cid. Repository:

Re: Review Request 125226: move EventForge from the desktop containment

> On Sept. 15, 2015, 9:41 p.m., David Edmundson wrote: > > src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp, line 259 > > > > > > This adds the same item multiple times. > > > > If you have

Re: Review Request 124684: Cmake fail to parse proper taglib version - kdelibs4support

> On Aug. 10, 2015, 11:45 p.m., Michael Pyne wrote: > > I'm not the reviewer for kdelibs4support but I have used Taglib; the change > > looks good to me. Please can you submit it, I don't have commit rights. Thank you - Luca --- This

Re: Building KF in version 5.14 on OSX fails for framework kdesignerplugin

> On Sep 16, 2015, at 2:54 AM, David Faure wrote: > > On Tuesday 15 September 2015 22:50:50 Kurt Hindenburg wrote: >> >>> On Sep 15, 2015, at 2:07 PM, Marko Käning wrote: >>> >>> Hi kdesignerplugin devs, >>> >>> On 14 Sep 2015, at 15:00 , Kurt Hindenburg

Re: Building KF in version 5.14 on OSX fails for framework kdesignerplugin

On Wednesday 16 September 2015 08:39:47 Kurt Hindenburg wrote: > > Thanks, that works for Qt 5.4.x; I don’t have a Qt5 install to check that. > Should I commit or do a review-board item? > > -"#if QT_VERSION >= QT_VERSION_CHECK(5, > 5, 0)\n" > +

Review Request 125259: Support multiple X servers in the NETWM classes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125259/ --- Review request for KDE Frameworks and kwin. Repository: kwindowsystem

Re: Review Request 125226: move EventForge from the desktop containment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125226/ --- (Updated Sept. 16, 2015, 4:44 p.m.) Review request for KDE Frameworks,

Review Request 125262: Parse service type files when loading from .desktop

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125262/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Review Request 125261: Add mimeTypes() to KPluginMetaData

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125261/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Re: Review Request 125261: Add mimeTypes() to KPluginMetaData

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125261/ --- (Updated Sept. 16, 2015, 5:50 p.m.) Review request for KDE Frameworks.

Review Request 125263: Adapt KPluginInfo to introduction of KPluginMetaData::mimeTypes()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125263/ --- Review request for KDE Frameworks, David Faure and Sebastian Kügler.

Re: Review Request 125261: Add mimeTypes() to KPluginMetaData

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125261/ --- (Updated Sept. 16, 2015, 5:53 p.m.) Review request for KDE Frameworks,

Re: Review Request 125259: Support multiple X servers in the NETWM classes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125259/#review85501 --- would one want to use the occasion to get rid of the

Re: Review Request 125226: move EventForge from the desktop containment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125226/ --- (Updated Sept. 16, 2015, 6:19 p.m.) Review request for KDE Frameworks,

Re: Review Request 125243: Trivial CMake corrections for Baloo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125243/ --- (Updated Sept. 16, 2015, 6:20 p.m.) Status -- This change has been

Re: Review Request 125253: KSycoca: move all of the kbuildsycoca code into the lib, except for main().

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125253/#review85512 --- Ship it! Ship It! - Albert Astals Cid On set. 16, 2015,

Re: Review Request 125268: Fix signal-slot connections in KNewFileMenuPrivate::confirmCreatingHiddenDir(QString)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125268/#review85514 --- if you're at it you might as well use the new connect syntax,

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 93 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/93/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16 Sep 2015 21:02:06 + Build duration: 12 min CHANGE SET Revision 689fd43ae226ad026dd2fb6e198a5fef40c24b13 by

Review Request 125271: KSycoca: rebuild ksycoca in process rather than executing kbuildsycoca5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125271/ --- Review request for KDE Frameworks, Albert Astals Cid and Boudewijn Rempt.

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 86 - Still unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/86/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16 Sep 2015 22:09:53 + Build duration: 5 min 1 sec CHANGE SET No changes JUNIT RESULTS Name:

Re: Review Request 125271: KSycoca: rebuild ksycoca in process rather than executing kbuildsycoca5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125271/ --- (Updated Sept. 16, 2015, 10:19 p.m.) Review request for KDE Frameworks,

Re: Review Request 125251: KSycoca optimization: only watch the file if the app connects to databaseChanged()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125251/#review85511 --- Ship it! Ok, then, makes sense. - Albert Astals Cid On

Review Request 125268: Fix signal-slot connections in KNewFileMenuPrivate::confirmCreatingHiddenDir(QString)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125268/ --- Review request for KDE Frameworks and David Faure. Bugs: 352770

Re: Review Request 125268: Fix signal-slot connections in KNewFileMenuPrivate::confirmCreatingHiddenDir(QString)

> On Sept. 16, 2015, 8:43 p.m., Kai Uwe Broulik wrote: > > if you're at it you might as well use the new connect syntax, so we could > > spot things like these easier in the future. Actually it wouldn't have caught this particular issue, since both QDBB and QDialog have these signals ;) -

Re: Review Request 125268: Fix signal-slot connections in KNewFileMenuPrivate::confirmCreatingHiddenDir(QString)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125268/#review85515 --- Ship it! Ship It! - David Faure On Sept. 16, 2015, 8:22

Re: Review Request 125251: KSycoca optimization: only watch the file if the app connects to databaseChanged()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125251/ --- (Updated Sept. 16, 2015, 8:59 p.m.) Status -- This change has been

Re: Review Request 125253: KSycoca: move all of the kbuildsycoca code into the lib, except for main().

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125253/ --- (Updated Sept. 16, 2015, 8:59 p.m.) Status -- This change has been

Re: Review Request 125214: Add support for network shares in kio_trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125214/ --- (Updated Sept. 16, 2015, 10:17 p.m.) Status -- This change has been

Re: Review Request 125261: Add mimeTypes() to KPluginMetaData

> On Sept. 16, 2015, 10:44 p.m., Sebastian Kügler wrote: > > autotests/kpluginmetadatatest.cpp, line 110 > > > > > > Should be a list, so enclosed with [ ]. > > > > In the header docs, you also say

Re: Review Request 125268: Fix signal-slot connections in KNewFileMenuPrivate::confirmCreatingHiddenDir(QString)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125268/ --- (Updated Sept. 16, 2015, 9:01 p.m.) Status -- This change has been

Review Request 125270: KBuildSycoca: use qWarning rather than fprintf(stderr, ...)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125270/ --- Review request for KDE Frameworks and Albert Astals Cid. Repository:

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 93 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/93/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16 Sep 2015 21:02:06 + Build duration: 12 min CHANGE SET Revision 689fd43ae226ad026dd2fb6e198a5fef40c24b13 by

Review Request 125272: KSycoca: rebuild sycoca in-process in most unittests as well.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125272/ --- Review request for KDE Frameworks and Albert Astals Cid. Repository:

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 86 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/86/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16 Sep 2015 21:02:06 + Build duration: 5 min 7 sec CHANGE SET Revision

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 86 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/86/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16 Sep 2015 21:02:06 + Build duration: 5 min 7 sec CHANGE SET Revision

Re: Review Request 125261: Add mimeTypes() to KPluginMetaData

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125261/#review85519 --- One issue raised inline, it looks good to me otherwise.

Re: Review Request 125262: Parse service type files when loading from .desktop

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125262/ --- (Updated Sept. 17, 2015, 12:37 a.m.) Review request for KDE Frameworks.

Re: Review Request 125271: KSycoca: rebuild ksycoca in process rather than executing kbuildsycoca5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125271/#review85525 --- Ship it! Ship It! - Albert Astals Cid On set. 16, 2015,

Review Request 125274: KBuildSycoca: remove writing of the ksycoca5stamp file.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125274/ --- Review request for KDE Frameworks and Albert Astals Cid. Repository:

Review Request 125278: KSycoca: add a q pointer to remove more singleton usage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125278/ --- Review request for KDE Frameworks and Albert Astals Cid. Repository:

Re: Review Request 125272: KSycoca: rebuild sycoca in-process in most unittests as well.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125272/#review85530 --- +1 - Aleix Pol Gonzalez On Sept. 17, 2015, 12:04 a.m.,

Re: Review Request 125274: KBuildSycoca: remove writing of the ksycoca5stamp file.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125274/#review85531 --- +1 - Aleix Pol Gonzalez On Sept. 17, 2015, 1:32 a.m.,

Re: Review Request 125278: KSycoca: add a q pointer to remove more singleton usage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125278/#review85533 --- +1 - Aleix Pol Gonzalez On Sept. 17, 2015, 1:28 a.m.,

Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125279/#review85532 --- +1 - Aleix Pol Gonzalez On Sept. 17, 2015, 1:30 a.m.,

Review Request 125275: KSycoca: remove all self() methods for factories, store them in KSycoca instead.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125275/ --- Review request for KDE Frameworks and Albert Astals Cid. Repository:

Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125279/ --- Review request for KDE Frameworks and Albert Astals Cid. Repository:

Re: Review Request 125262: Parse service type files when loading from .desktop

> On Sept. 16, 2015, 6:14 p.m., David Faure wrote: > > KF5CoreAddonsMacros.cmake, line 3 > > > > > > typo: SERIVCE -> SERVICE > > > > Does this break SC, if DEFAULT_SERVICE_TYPE must be specified? It > >

Re: Review Request 125270: KBuildSycoca: use qWarning rather than fprintf(stderr, ...)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125270/#review85529 --- Shouldn't it be qCWarning? - Aleix Pol Gonzalez On Sept.

Re: Review Request 125262: Parse service type files when loading from .desktop

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125262/#review85502 --- KF5CoreAddonsMacros.cmake (line 3)

Re: Review Request 125263: Adapt KPluginInfo to introduction of KPluginMetaData::mimeTypes()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125263/#review85503 --- Ship it! src/services/kplugininfo.cpp (line 335)

Re: Review Request 125226: move EventForge from the desktop containment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125226/ --- (Updated Sept. 16, 2015, 5:40 p.m.) Review request for KDE Frameworks,