Re: Review Request 125325: New widget KCollapsibleGroupBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125325/#review87117 --- Almost there ;) src/kcollapsiblegroupbox.h (line 47)

Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

> On oct. 20, 2015, 2:40 a.m., Michael Pyne wrote: > > Though I made the suggested changes I'm now worried we might need API > > changes in KAboutData to do this properly... it seems to me that > > KAboutData::applicationData() is improperly specified to return a copy of > > KAboutData

Re: Review Request 125705: Use LANG for month names in calendar applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125705/#review87113 --- src/declarativeimports/calendar/calendar.cpp (line 195)

Re: Review Request 125711: Use deleteLater in Part::slotWidgetDestroyed().

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125711/ --- (Updated Oct. 20, 2015, 8:33 a.m.) Status -- This change has been

Re: Frameworks API documentation links to projects.kde.org

On Tue, Oct 20, 2015 at 9:11 AM, Alex Merry wrote: > On 2015-10-19 10:58, Ben Cooksley wrote: >> >> Hi all, >> >> As you probably know, projects.kde.org is on it's way out. >> Can someone please terminate the links from the Frameworks API >> documentation to projects.kde.org,

Review Request 125720: set default theme to breeze rather than oxygen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125720/ --- Review request for KDE Frameworks, Plasma and Christoph Feck. Bugs:

Re: Review Request 125725: Make KCrash optional for kservice

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125725/#review87135 --- src/kbuildsycoca/kbuildsycoca_main.cpp (line 121)

Re: Review Request 125725: Make KCrash optional for kservice

> On Oct. 20, 2015, 1:52 p.m., Aleix Pol Gonzalez wrote: > > src/kbuildsycoca/kbuildsycoca_main.cpp, line 122 > > > > > > Maybe it would make sense to handle it using signal() directly here, > > rather than

Re: Review Request 125725: Make KCrash optional for kservice

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125725/ --- (Updated Oct. 20, 2015, 2 p.m.) Status -- This change has been

Re: Review Request 125725: Make KCrash optional for kservice

> On Oct. 20, 2015, 3:52 p.m., Aleix Pol Gonzalez wrote: > > src/kbuildsycoca/kbuildsycoca_main.cpp, line 122 > > > > > > Maybe it would make sense to handle it using signal() directly here, > > rather than

Re: Review Request 125725: Make KCrash optional for kservice

> On Oct. 20, 2015, 1:52 p.m., Aleix Pol Gonzalez wrote: > > src/kbuildsycoca/kbuildsycoca_main.cpp, line 122 > > > > > > Maybe it would make sense to handle it using signal() directly here, > > rather than

Re: Review Request 125725: Make KCrash optional for kservice

> On Oct. 20, 2015, 1:52 p.m., Aleix Pol Gonzalez wrote: > > src/kbuildsycoca/kbuildsycoca_main.cpp, line 122 > > > > > > Maybe it would make sense to handle it using signal() directly here, > > rather than

Re: Review Request 125725: Make KCrash optional for kservice

> On Oct. 20, 2015, 3:52 p.m., Aleix Pol Gonzalez wrote: > > src/kbuildsycoca/kbuildsycoca_main.cpp, line 122 > > > > > > Maybe it would make sense to handle it using signal() directly here, > > rather than

Re: Question about goal of Windows/Mac frameworks

On Tuesday, October 20, 2015 20:23:00 Christoph Cullmann wrote: > Hi, > > > Christoph. > > > > I have had similar goals for a while, but haven't reached the point > > that I was having much success yet in that regard. One thing to keep > > in mind when developing installers, Qt Installer

Re: Review Request 125720: set default theme to breeze rather than oxygen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125720/#review87155 --- Ship it! src/kicontheme.cpp (line 545)

Re: Question about goal of Windows/Mac frameworks

Hi, > Hi, > With my Android hat on I very much welcome the initiative. Android is > more limited in this regard, as you will mostly always want to have > split packages there and it's how we've been working since the > beginning. > > I think that for us Qt is a safe base in general. relying on

Re: Review Request 125705: Use LANG for month names in calendar applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125705/ --- (Updated Oct. 20, 2015, 9:04 p.m.) Review request for KDE Frameworks and

Re: Review Request 125725: Make KCrash optional for kservice

> On Oct. 20, 2015, 3:52 p.m., Aleix Pol Gonzalez wrote: > > src/kbuildsycoca/kbuildsycoca_main.cpp, line 122 > > > > > > Maybe it would make sense to handle it using signal() directly here, > > rather than

Re: Question about goal of Windows/Mac frameworks

Christoph, I'm not trying to argue against having applications come in complete bundles at all. That is a worthy goal also actually, it's just not the direction I was headed in. You've made a lot more progress in this regard than I had though tbh. I see the kdewin installer as something that went

Re: Question about goal of Windows/Mac frameworks

Christoph. I have had similar goals for a while, but haven't reached the point that I was having much success yet in that regard. One thing to keep in mind when developing installers, Qt Installer Framework. I did a quick test with attica on OS X I can put on reviewboard to see what you think. I

Re: Question about goal of Windows/Mac frameworks

On Tue, Oct 20, 2015 at 4:49 PM, Christoph Cullmann wrote: > Hi, > > after some patching, we got around to a state that allows to e.g. use KWrite > on Windows or Mac with stock frameworks master and stock Qt 5.5, without any > additional > patches and no stuff like dbus

Re: Review Request 125705: Use LANG for month names in calendar applet

> On Oct. 20, 2015, 9:12 a.m., Xuetian Weng wrote: > > src/declarativeimports/calendar/calendar.cpp, line 195 > > > > > > This only checks LANG, meanwhile, LC_ALL and LC_MESSAGES, and maybe > > even LANGUAGE

Re: Review Request 125711: Use deleteLater in Part::slotWidgetDestroyed().

> On Oct. 20, 2015, 2:13 p.m., Allen Winter wrote: > > Does anyone object if I backport this to kdelibs KDE/4.14 ? I certainly don't, and Michael Pyne suggested above that he might do it himself. - Alex --- This is an automatically

Re: Review Request 125705: Use LANG for month names in calendar applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125705/#review87164 --- src/declarativeimports/calendar/calendar.cpp (line 197)

Re: Review Request 125695: Make KAboutData::translators/setTranslators simple

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125695/ --- (Updated Oct. 20, 2015, 9:34 p.m.) Status -- This change has been

Re: [KDE/Mac] Question about goal of Windows/Mac frameworks

Please, hold this poll in the user communities (as far as they exist), and not only among the developers. That is of course if you're doing all this with the requirements of the people who'll end up using your stuff foremost in mind. I think you'll find that many if not most Mac users don't

Re: [KDE/Mac] Question about goal of Windows/Mac frameworks

On Tuesday October 20 2015 13:29:21 Jeremy Whiting wrote: >applications. I can also see the same power users recommending >individual applications to their relatives (moms, grandmothers, etc.) >using single application installers as you described. "Here mom, >download this one bundle to install

Re: Review Request 125711: Use deleteLater in Part::slotWidgetDestroyed().

> On Oct. 20, 2015, 2:13 p.m., Allen Winter wrote: > > Does anyone object if I backport this to kdelibs KDE/4.14 ? > > Alex Merry wrote: > I certainly don't, and Michael Pyne suggested above that he might do it > himself. done, backported to kdelibs KDE/4.14 branch with commit

Re: Policy for Dependencies

Hello, On Thursday 15 October 2015 02:04:45 Aleix Pol wrote: > On Wed, Oct 14, 2015 at 10:28 PM, Kevin Ottens wrote: > > Hello, > > > > On Wednesday 14 October 2015 21:20:33 Christoph Cullmann wrote: > >> Therefore my goal for frameworks is to make them actually as easy usable >

Re: Question about goal of Windows/Mac frameworks

Hello, On Tuesday 20 October 2015 19:49:54 Aleix Pol wrote: > 3) non-existing stuff? really? Let's rephrase it as: "Frameworks will > only be advertised as available on a platform if they are just require > Qt or other available dependencies on the platform". For example, > requiring libssh could

Re: Review Request 125325: New widget KCollapsibleGroupBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125325/ --- (Updated Oct. 20, 2015, 9:20 p.m.) Review request for KDE Frameworks and

Re: Review Request 125705: Use LANG for month names in calendar applet

> On Oct. 20, 2015, 9:30 p.m., Albert Astals Cid wrote: > > src/declarativeimports/calendar/calendar.cpp, line 197 > > > > > > uilanguages is not good for direct inputing into QLocale (yes i know, > > it's

Re: Question about goal of Windows/Mac frameworks

> Aleix Pol hat am 20. Oktober 2015 um 19:49 geschrieben: > Regarding dbus especifically, I see the problem in 2). You can bundle > it, but then if it's already ran by another process the other one will > have to be used, which is where the dbus mess starts. There is work in

Question about goal of Windows/Mac frameworks

Hi, after some patching, we got around to a state that allows to e.g. use KWrite on Windows or Mac with stock frameworks master and stock Qt 5.5, without any additional patches and no stuff like dbus running. (as standalone installer/bundles) To have KIO working, one needs to teach it how to

Re: Review Request 125681: Correctly set the printSetting's parent

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125681/ --- (Updated Oct. 20, 2015, 11:08 p.m.) Status -- This change has been

Re: Question about goal of Windows/Mac frameworks

On Wed, Oct 21, 2015 at 1:12 AM, Ralf Habacker wrote: >> Christoph Cullmann hat am 20. Oktober 2015 um 16:49 >> geschrieben: > >> That works only, if the applications bundle their ui files in resources, >> too, otherwise, they just won't be found >> and the

Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125682/ --- (Updated Oct. 21, 2015, 12:50 a.m.) Review request for KDE Frameworks,

Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

> On Oct. 20, 2015, 2:40 a.m., Michael Pyne wrote: > > Though I made the suggested changes I'm now worried we might need API > > changes in KAboutData to do this properly... it seems to me that > > KAboutData::applicationData() is improperly specified to return a copy of > > KAboutData

Re: Review Request 125717: initialize socket size with correct value

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125717/ --- (Updated Oct. 21, 2015, 5:38 a.m.) Status -- This change has been

Re: Review Request 125720: set default theme to breeze rather than oxygen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125720/#review87132 --- +1 - Martin Klapetek On Oct. 20, 2015, 11:52 a.m., Harald

Review Request 125725: Make KCrash optional for kservice

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125725/ --- Review request for KDE Frameworks and David Faure. Summary (updated)

Re: Review Request 125717: initialize socket size with correct value

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125717/#review87133 --- Ship it! Ship It! - Martin Klapetek On Oct. 20, 2015,