Re: Review Request 127836: kwayland: Initialize Interface factory pointer to fix Coverity warning

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127836/ --- (Updated May 5, 2016, 3:19 a.m.) Status -- This change has been

Re: Review Request 127836: kwayland: Initialize Interface factory pointer to fix Coverity warning

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127836/#review95196 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 5, 2016,

Re: Review Request 127833: KWallet: More Coverity fixes, and include Qt headers for endianness check.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127833/#review95195 --- +1 - Aleix Pol Gonzalez On May 5, 2016, 1:03 a.m.,

Re: Review Request 127813: Process paths just once

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127813/ --- (Updated May 5, 2016, 3:02 a.m.) Review request for KDE Frameworks and

Review Request 127837: oxygen_windeco: Fix potential use-after-free from improper use of QCache

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127837/ --- Review request for KDE Frameworks and Plasma. Repository: oxygen

Review Request 127836: kwayland: Initialize Interface factory pointer to fix Coverity warning

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127836/ --- Review request for KDE Frameworks and kwin. Repository: kwayland

Review Request 127835: KHTML: Try again to fix Coverity memory leak in CSS background property

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127835/ --- Review request for KDE Frameworks. Repository: khtml Description

Review Request 127834: ki18n: Fix theoretically possible use-after-free in gettext when using strict ANSI compilers

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127834/ --- Review request for KDE Frameworks and Localization and Translation (l10n).

Re: Review Request 127813: Process paths just once

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127813/#review95192 --- src/core/kconfiggroup.cpp (line 439)

Jenkins-kde-ci: kpty master stable-kf5-qt5 » Linux,gcc - Build # 25 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kpty%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/25/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 04 May 2016 23:01:45 + Build duration: 59 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Review Request 127833: KWallet: More Coverity fixes, and include Qt headers for endianness check.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127833/ --- Review request for KDE Frameworks. Repository: kwallet Description

Re: Review Request 127655: Fix KAboutData::applicationData() to init from current Q*Application metadata

> On May 4, 2016, 9:48 p.m., Albert Astals Cid wrote: > > src/lib/kaboutdata.cpp, line 46 > > > > > > 5.4 is now the minimum supported version of KDE Frameowkrs 5 Fixed with

Re: Review Request 127813: Process paths just once

> On May 2, 2016, 8:21 p.m., Albert Astals Cid wrote: > > src/core/kconfiggroup.cpp, line 442 > > > > > > Are we sure we want this to be static? > > Aleix Pol Gonzalez wrote: > I'm not sure, my impression

Jenkins-kde-ci: kpty master kf5-qt5 » Linux,gcc - Build # 25 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kpty%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/25/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 04 May 2016 21:50:47 + Build duration: 56 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed:

Jenkins-kde-ci: kpty master kf5-qt5 » Linux,gcc - Build # 25 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kpty%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/25/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 04 May 2016 21:50:47 + Build duration: 56 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed:

Re: Review Request 127655: Fix KAboutData::applicationData() to init from current Q*Application metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127655/#review95189 --- Fix it, then Ship it! src/lib/kaboutdata.cpp (line 46)

Jenkins-kde-ci: kpty master stable-kf5-qt5 » Linux,gcc - Build # 24 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kpty%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/24/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 04 May 2016 21:45:02 + Build duration: 57 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Re: Review Request 127817: Don't make KIconThemes depend on Oxygen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127817/#review95188 --- +1 would i'd like someone else opinion. - Albert Astals Cid

Re: Review Request 127655: Fix KAboutData::applicationData() to init from current Q*Application metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127655/ --- (Updated May 4, 2016, 9:41 p.m.) Status -- This change has been

Re: Review Request 127655: Fix KAboutData::applicationData() to init from current Q*Application metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127655/#review95186 --- Ship it! Ship It! - Michael Pyne On May 4, 2016, 2:47

Re: Review Request 127655: Fix KAboutData::applicationData() to init from current Q*Application metadata

> On May 4, 2016, 11:20 a.m., Friedrich W. H. Kossebau wrote: > > src/lib/kaboutdata.cpp, line 925 > > > > > > Forgot to note the static I am used to write here. But given your > > comment I am now unsure about

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

> On Май 4, 2016, 11:18 преди обяд, Martin Gräßlin wrote: > > src/platforms/xcb/kwindowsystem.cpp, lines 711-717 > > > > > > This changes the behavior of the method. Now always NETWM is preferred, > > even if

Re: Review Request 127795: [DataEngine] Invalidate DataEngine on unknown plugin + detailed test

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127795/ --- (Updated Май 4, 2016, 8:06 след обяд) Review request for KDE Frameworks

Re: Review Request 127829: use QUrl::fromUserInput to construct sound url

> On May 4, 2016, 3:45 p.m., Aleix Pol Gonzalez wrote: > > src/knotifyconfigactionswidget.cpp, line 137 > > > > > > maybe `soundFilename.contains(':')` would do the trick? > > > > This seems to be

Re: Review Request 126285: OS X build and warning fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126285/#review95174 --- Ship it! Looks good to me - though I can not comment on

Re: Review Request 127829: use QUrl::fromUserInput to construct sound url

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127829/#review95167 --- src/knotifyconfigactionswidget.cpp (line 137)

Re: Review Request 127829: use QUrl::fromUserInput to construct sound url

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127829/#review95170 --- Ship it! Ship It! - Martin Klapetek On May 4, 2016,

Re: Review Request 127795: [DataEngine] Invalidate DataEngine on unknown plugin + detailed test

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127795/#review95169 --- src/plasma/dataengine.cpp

Re: Review Request 127655: Fix KAboutData::applicationData() to init from current Q*Application metadata

> On May 4, 2016, 3:40 a.m., Michael Pyne wrote: > > autotests/kaboutdatatest.cpp, line 317 > > > > > > Doesn't this call make the KAboutData::applicationData() call that > > happens later return *this*

Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 53 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/53/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 04 May 2016 14:50:41 + Build duration: 1 min 10 sec CHANGE SET Revision

Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 49 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/49/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 04 May 2016 14:50:41 + Build duration: 4 min 4 sec CHANGE SET Revision

Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 49 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/49/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 04 May 2016 14:50:41 + Build duration: 4 min 4 sec CHANGE SET Revision

Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 53 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/53/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 04 May 2016 14:50:41 + Build duration: 1 min 10 sec CHANGE SET Revision

Re: Review Request 127655: Fix KAboutData::applicationData() to init from current Q*Application metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127655/ --- (Updated May 4, 2016, 2:47 p.m.) Review request for KDE Frameworks, Alex

Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 48 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/48/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 04 May 2016 14:38:20 + Build duration: 2 min 49 sec CHANGE SET Revision

Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 52 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/52/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 04 May 2016 14:38:20 + Build duration: 37 sec CHANGE SET Revision

Re: Review Request 127756: Remove platformtheme plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127756/ --- (Updated May 4, 2016, 2:38 p.m.) Status -- This change has been

Review Request 127829: use QUrl::fromUserInput to construct sound url

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127829/ --- Review request for KDE Frameworks and Martin Klapetek. Bugs: 337276

Review Request 127830: use QUrl::fromUserInput to construct sound url

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127830/ --- Review request for KDE Frameworks and Martin Klapetek. Bugs: 337276

Re: Review Request 127779: use system colors for monochrome icons

> On May 2, 2016, 1:17 p.m., Sebastian Kügler wrote: > > src/kiconloader.cpp, line 869 > > > > > > Where does this one get deleted? > > Marco Martin wrote: > it's a QScopedPointer, so it gets deleted when

Re: Review Request 127655: Fix KAboutData::applicationData() to init from current Q*Application metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127655/#review95158 --- autotests/kaboutdatatest.cpp (line 317)

Re: Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/ --- (Updated May 4, 2016, 9:56 a.m.) Review request for KDE Frameworks and

Re: Review Request 127779: use system colors for monochrome icons

> On May 2, 2016, 1:17 p.m., Sebastian Kügler wrote: > > src/kiconloader.cpp, line 869 > > > > > > Where does this one get deleted? it's a QScopedPointer, so it gets deleted when the function returns - Marco

Re: Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/ --- (Updated May 4, 2016, 9:51 a.m.) Review request for KDE Frameworks and

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127809/#review95152 --- src/platforms/xcb/kwindowsystem.cpp (lines 711 - 716)

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

> On May 2, 2016, 4:02 p.m., Martin Gräßlin wrote: > > What is the "best" size if it's not specified? Why is your change better > > than how it was? > > > > This change adjusts a very important part of the icon lookup functionality > > used by KWin and Plasma. I'm a little bit scared of

Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 51 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/51/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 04 May 2016 07:54:12 + Build duration: 2 min 0 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 45 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/45/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 04 May 2016 07:44:11 + Build duration: 9 min 37 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Re: Review Request 127756: Remove platformtheme plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127756/#review95150 --- Ship it! +1, since it is already moved to

Re: Review Request 127756: Remove platformtheme plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127756/#review95149 --- This has two +1's so it can go in unless anyone has any

Re: Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 50 - Still Unstable!

On Wed, May 4, 2016 at 12:58 PM, Ben Cooksley wrote: > Can someone take a look at this one please? > It seems to die on an assert in the QML runtime, so this could very > well be another defect in Qt. This test is moved to plasma-integration and fixed there, and should be

Re: Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 50 - Still Unstable!

On Wed, May 4, 2016 at 7:26 PM, wrote: > > GENERAL INFO > > BUILD UNSTABLE > Build URL: > https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/50/ > Project: PLATFORM=Linux,compiler=gcc > Date of build: Wed, 04 May 2016 07:23:41 + >

Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 50 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/50/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 04 May 2016 07:23:41 + Build duration: 1 min 48 sec CHANGE SET No changes JUNIT RESULTS

Re: KF5 Tags tag tags, not objects

On Wednesday 27 April 2016 09:45:42 Stephen Kelly wrote: > David Faure wrote: > > > versionfile=$here/versions/$repo > > if [ ! -f $versionfile ]; then echo "$versionfile not found"; exit 1; fi > > b=`sed '2q;d' $versionfile` > > echo $b > > checkout=$(findCheckout $repo) > > cd $checkout || exit

Re: Review Request 127747: Create a new script that generate the documentation for all projects following the syntax I proposed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127747/#review95148 --- Nothing? What should I do? - Olivier Churlaud On avr.