jsalatas retitled this revision from "Reset filetype when opening url" to
"[KTextEditor] Reset filetype when opening url".
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D4699
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To:
jsalatas created this revision.
Restricted Application added a subscriber: kwrite-devel.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Seems reasonable to me that when calling `openUrl` it should be reset to its
original filetype and highlighting mode.
TEST PLAN
none
dfaure closed this revision.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D4604
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: dfaure, mdawson
Cc: #frameworks
mdawson accepted this revision.
mdawson added a comment.
This revision is now accepted and ready to land.
Ship it!
REPOSITORY
R237 KConfig
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4604
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
dfaure updated this revision to Diff 11570.
dfaure added a comment.
Use "#if 0"
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4604?vs=11320=11570
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4604
AFFECTED FILES
cmake/rules_PyKF5.py
mdawson added inline comments.
INLINE COMMENTS
> dfaure wrote in kconfigbackend.h:210
> In general I agree that leaving dead code is bad.
>
> In this particular case, though, the other side of the plugin code is still
> there
> ("#if 0 // TODO port to Qt5 plugin loading" in
jsalatas created this revision.
jsalatas added a project: KTextEditor.
Restricted Application added a subscriber: kwrite-devel.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Just adding the read part of "word-count"which was missing from
KTextEditor::ConfigInterface
dfaure added a comment.
The plan sounds good.
INLINE COMMENTS
> mdawson wrote in kconfigbackend.h:210
> I don't think this is worth saving as a comment, just remove it completely.
> If we decide to undo this, it's in git.
In general I agree that leaving dead code is bad.
In this
mdawson requested changes to this revision.
mdawson added a comment.
This revision now requires changes to proceed.
I agree, this can't be used so removing it from the API can't hurt anything.
Just to be sure, let's take this change for the next release, but not change
KConfigBackend'
atomsymbol added a reviewer: mwolff.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D4619
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: atomsymbol, kfunk, mwolff
Cc: kwrite-devel, #frameworks
davidedmundson added a comment.
Makes sense and the code is fine +1 from me.
I assume you have an intended usage in mind?
INLINE COMMENTS
> iconitem.h:101
> +/**
> + * If set, icon will round the painted size to defined icon sizes
> + */
add the line "the default is true"
elvisangelaccio removed a dependent revision: D3531: Drop remote ioslave, will
be in KIO 5.32.
REVISION DETAIL
https://phabricator.kde.org/D3530
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: elvisangelaccio, #frameworks, #plasma, dfaure
Cc: mart, aacid,
elvisangelaccio added a dependent revision: D3531: Drop remote ioslave, will be
in KIO 5.32.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D4690
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: elvisangelaccio, dfaure, davidedmundson
elvisangelaccio updated this revision to Diff 11560.
elvisangelaccio added a comment.
Drop Messages.sh
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4690?vs=11554=11560
BRANCH
import-remote
REVISION DETAIL
https://phabricator.kde.org/D4690
AFFECTED
elvisangelaccio abandoned this revision.
elvisangelaccio added a comment.
arcanist fuck-up, sorry.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D4691
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: elvisangelaccio
Cc: #frameworks
elvisangelaccio created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
As discussed on plasma-devel, the `remote:/` ioslave is used also by Dolphin,
so this move will allow to drop plasma-workspace as
elvisangelaccio added a comment.
About the co-installability problem: kio 5.32 will install the ioslave plugin
as `$QT_PLUGIN_PATH/kf5/kio/remote.so`, while plasma-workspace 5.9 installs
`$QT_PLUGIN_PATH/kio_remote.so`. So far so good.
The only conflict is on the kded plugin
elvisangelaccio abandoned this revision.
elvisangelaccio added a comment.
I've decided to keep it simple and only move `remote:/` for now. Please
continue in https://phabricator.kde.org/D4690.
REVISION DETAIL
https://phabricator.kde.org/D3530
EMAIL PREFERENCES
elvisangelaccio created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
As discussed on plasma-devel, the `remote:/` ioslave is used also by Dolphin,
so this move will allow to drop plasma-workspace as
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/349/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 20 Feb 2017 16:37:41 +
Build duration: 12 min
CHANGE SET
Revision
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/349/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 20 Feb 2017 16:37:41 +
Build duration: 12 min
CHANGE SET
Revision
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/349/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Mon, 20 Feb 2017 16:37:41 +
Build duration: 2 min 42 sec
CHANGE
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/349/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Mon, 20 Feb 2017 16:37:41 +
Build duration: 2 min 42 sec
CHANGE
winterz closed this revision.
winterz added a comment.
c4b01b015554f52577507506d18c9bcb4e7ac5b6committed in
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4684
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To:
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4684
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: winterz, mart, hein,
dfaure added a comment.
Thanks, this must be the cause for the CI failures at
https://build.kde.org/view/Frameworks%20kf5-qt5/job/plasma-framework%20master%20stable-kf5-qt5/
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4684
EMAIL PREFERENCES
drosca created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Disabling this property makes it possible to show icon of arbitrary size.
TEST PLAN
Test passed
REPOSITORY
R242
drosca added a comment.
Looks fine, but unfortunately it doesn't help with anything, the issue with
networkmanager applet delegates is still there.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4688
EMAIL PREFERENCES
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4688
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma,
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
FrameSvgItem already updates the margins in response to that.
TEST PLAN
`FrameSvgItem` has
connect(m_frameSvg,
winterz added a comment.
btw, not related to this patch but I just noticed..
on line 534 of containmentinterface.cpp, do you want to delete 'choices' or
'choice'?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4684
EMAIL PREFERENCES
winterz created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
in Qt5.6 the QAction creators need a parent object passed as a parameter.
unfortunately they don't have a default for the parent as
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kparts%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/432/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 20 Feb 2017 13:35:29 +
Build duration: 1 min 50 sec
CHANGE SET
No changes
JUNIT RESULTS
Name:
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kparts%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/432/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 20 Feb 2017 13:35:29 +
Build duration: 1 min 50 sec
CHANGE SET
No changes
JUNIT RESULTS
Name:
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/348/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Mon, 20 Feb 2017 13:35:21 +
Build duration: 2 min 9 sec
CHANGE SET
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/348/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 20 Feb 2017 13:35:21 +
Build duration: 5 min 14 sec
CHANGE SET
No
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
TEST PLAN
Placed the following in kdeglobals
[KDE Control Module Restrictions]
kcm_pulseaudio.desktop=false
No longer got
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/kparts%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/431/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 20 Feb 2017 10:32:45 +
Build duration: 1 min 34 sec
CHANGE SET
No changes
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/347/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 20 Feb 2017 10:23:45 +
Build duration: 10 min
CHANGE SET
Revision
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/347/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Mon, 20 Feb 2017 10:23:45 +
Build duration: 10 min
CHANGE SET
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/432/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 20 Feb 2017 10:22:50 +
Build duration: 8 min 19 sec
CHANGE SET
Revision c1bbe00181b02aa11cbf995d41fca4f956f798d4
mart closed this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4576
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma, hein
Cc: plasma-devel, #frameworks, progwolff, lesliezhai,
mart retitled this revision from "[WIP]: integrate drop menu and filecopy drop
menu" to "integrate drop menu and filecopy drop menu".
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
arcpatch-D4576
REVISION DETAIL
https://phabricator.kde.org/D4576
EMAIL PREFERENCES
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:c1bbe00181b0: allow to add application actions on an open
menu (authored by mart).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4620?vs=11521=11522
REVISION DETAIL
mart updated this revision to Diff 11521.
mart added a comment.
don't remove separators
qmenu collpapses them and previous code might have assert
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4620?vs=11402=11521
BRANCH
arcpatch-D4620
REVISION DETAIL
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/253/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 20 Feb 2017 09:41:47 +
Build duration: 11 min
CHANGE SET
No changes
JUNIT RESULTS
Name:
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/253/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 20 Feb 2017 09:41:47 +
Build duration: 11 min
CHANGE SET
No changes
JUNIT RESULTS
Name:
47 matches
Mail list logo
