Jenkins-kde-ci: networkmanager-qt master stable-kf5-qt5 » Linux,gcc - Build # 65 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/networkmanager-qt%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/65/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Mar 2017 05:43:56 + Build duration: 9 min 49 sec CHANGE SET Revision

Jenkins-kde-ci: networkmanager-qt master kf5-qt5 » Linux,gcc - Build # 66 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/networkmanager-qt%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/66/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Mar 2017 05:43:56 + Build duration: 10 min CHANGE SET Revision

D5208: Allow loading i18n catalogs from arbitrary locations

davidedmundson updated this revision to Diff 12892. davidedmundson added a comment. Missed a file REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5208?vs=12890=12892 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5208 AFFECTED FILES

D5209: Load translations from KPackage files if bundled

davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. TEST PLAN Installed battery monitor locally with kpackagetool5 -i moved x-test .po file from being installed systemwide to only

D5208: Allow loading i18n catalogs from arbitrary locations

davidedmundson created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY In KDE4, Plasma used to be able to load bundled translations with any plasmoid downloaded from kde-look. It used added a KGlobal::dirs()->addResourceDir("locale") at runtime when

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 386 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/386/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 28 Mar 2017 02:13:48 + Build duration: 14 min CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 386 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/386/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 28 Mar 2017 02:13:48 + Build duration: 14 min CHANGE SET Revision

D5092: [KMessageWidget] Fix wrong size hint when animatedShow() is called with a hidden parentWidget()

This revision was automatically updated to reflect the committed changes. Closed by commit R236:0cfb788c2e44: Fix wrong size hint when animatedShow is called with hidden parent (authored by cfeck). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

Jenkins-kde-ci: networkmanager-qt master stable-kf5-qt5 » Linux,gcc - Build # 64 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/networkmanager-qt%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/64/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 27 Mar 2017 22:37:10 + Build duration: 8 min 20 sec CHANGE SET Revision

Jenkins-kde-ci: networkmanager-qt master kf5-qt5 » Linux,gcc - Build # 65 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/networkmanager-qt%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/65/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 27 Mar 2017 22:37:10 + Build duration: 2 min 42 sec CHANGE SET Revision

D5185: prevent signals in glib2 be defined by QT

This revision was automatically updated to reflect the committed changes. Closed by commit R282:b08b9c425fb0: prevent signals in glib2 be defined by Qt (authored by RobberPhex, committed by aacid). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE

Test failures with networkmanager-qt

Hi, I try building networkmanager-qt for GNU Guix [1]. Gnu Guix build all software within a container, which does not have any network interface. networkmanager-qt build fine, but one test (ActiveConnectionTest) fails with activeConnectionStateChangedSpy.count()) being 0 instead of 1. There are

D5030: kioexec: delegate upload to a kded module

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kioexecd.cpp:74 > +m_watcher->addFile(path); > +m_watched.insert(path, QUrl::fromUserInput(destUrl)); > +} QUrl(destUrl) would be enough, you use

D5030: kioexec: delegate upload to a kded module

dfaure added a comment. Nice idea. Can you use kiod rather than kded? Same plugin mechanism exactly but this way no dependency on kded. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5030 To: elvisangelaccio, dfaure Cc: #frameworks

D5173: Fix 'Installation of ksendbugmail.exe conflicts with related KDE4 package'.

dfaure added a comment. So bin isn't in %PATH%, but found relatively to the app being run? This makes me wonder if libexec could be bin/libexec/kf5/ on Windows, relative too. Then we could have an ECM-provided string that expands to CMAKE_INSTALL_PREFIX "/" KF5_LIBEXEC_INSTALL_DIR

D5173: Fix 'Installation of ksendbugmail.exe conflicts with related KDE4 package'.

habacker added a comment. In any discussion about libexec related issues we keep hitting the fact that there is no standard env var for it. Maybe we need a custom one (which could then be KF5_LIBEXEC_PATH, so it won't conflict with KF6). Because every KDE application installers bundles a

D5195: don't add the autotests dir when test building is disabled

ilic accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D5195 To: sitter, ilic Cc: #frameworks

D5173: Fix 'Installation of ksendbugmail.exe conflicts with related KDE4 package'.

habacker added a comment. > The question is, can you add libexec to the path (so that findExecutable works) only for kf5-based executables (so that kde4 apps don't break) ? no > If not, then your description of the problem was incorrect and this is not just about dbus-started

D5202: [Default Tooltip] Fix icon size

broulik edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5202 To: broulik, #plasma Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5202: [Default Tooltip] Fix icon size

broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY We overwrite implicit size based on the icon loaded nowadays which breaks this. TEST PLAN No longer get icon sizes

D5200: [Calendar] Shrink and elide week names like is done with day delegate

broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY This ensures week names never exceed their cell's boundaries. BUG: 378020 TEST PLAN `LC_ALL=pt_PT plasmashell`

D5199: Reflect trash state in iconNameForUrl

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Yep it means parsing a file, but that file is exactly 2 lines long and this is only done when asking about trash:/ so I think it's fine. REPOSITORY R241 KIO REVISION DETAIL

D5199: Reflect trash state in iconNameForUrl

markg added a comment. Hmm, i don't know about the performance penalty you get when using KConfig... It "looks" ok, but that's without knowing the above. +1, ship it is for someone else. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5199 To: broulik, hein,

D5199: Reflect trash state in iconNameForUrl

bshah resigned from this revision. This revision now requires review to proceed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5199 To: broulik, hein, dfaure Cc: #frameworks

D5199: Reflect trash state in iconNameForUrl

bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5199 To: broulik, hein, dfaure, bshah Cc: #frameworks

D5199: Reflect trash state in iconNameForUrl

broulik created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY When doing iconNameForUrl("trash:/") reflect the state of the trash (full or empty) TEST PLAN Did KIO::iconNameForUrl("trash:/") with

D5197: Make it possible to use the fetched translations

apol added a comment. In https://phabricator.kde.org/D5197#97986, @ltoscano wrote: > I could not properly review the proposed patches which introduces the new functions (sorry), but do we need the if (EXISTS...) ? Before the changes, ki18n_install worked also when po/ did not exist.

D5197: Make it possible to use the fetched translations

apol updated this revision to Diff 12870. apol added a comment. Just try the directory, no need to make sure it's there REPOSITORY R325 KAlgebra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5197?vs=12869=12870 BRANCH master REVISION DETAIL

D5197: Make it possible to use the fetched translations

ltoscano added a comment. I could not properly review the proposed patches which introduces the new functions (sorry), but do we need the if (EXISTS...) ? Before the changes, ki18n_install worked also when po/ did not exist. REPOSITORY R325 KAlgebra REVISION DETAIL

D5143: Introduce fetch-translations build command

apol added a comment. In https://phabricator.kde.org/D5143#97847, @aacid wrote: > That creates a dependency for ki18n for frameworks that only use .ts files, no? One thing we can do is remove the ki18n_install step from here and move it to each project like this, much like we're

D5197: Make it possible to use the fetched translations

apol created this revision. REVISION SUMMARY Exemplifies how we'll have to change projects to adopt the changes. REPOSITORY R325 KAlgebra BRANCH master REVISION DETAIL https://phabricator.kde.org/D5197 AFFECTED FILES CMakeLists.txt To: apol, #frameworks

D5143: Introduce fetch-translations build command

apol updated this revision to Diff 12868. apol added a comment. Just do the translation fetching Including the po should be done by the project itself REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5143?vs=12776=12868 BRANCH master

D5167: Move .po and .ts files look-up to build-time

apol updated this revision to Diff 12867. apol added a comment. Install in the correct directory REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5167?vs=12862=12867 BRANCH fetchbuildtime REVISION DETAIL https://phabricator.kde.org/D5167 AFFECTED FILES

D5167: Move .po and .ts files look-up to build-time

apol added a comment. This is KAlgebra in catalan with the translations generated with this method: F3317742: Spectacle.jU4256.png If I use `LANGUAGE=sr` it doesn't work, I don't know why though, it doesn't error but it's likely I'm messing up

D5167: Move .po and .ts files look-up to build-time

apol updated this revision to Diff 12862. apol added a comment. Uncomment test, remove unneeded glob REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5167?vs=12772=12862 BRANCH fetchbuildtime REVISION DETAIL https://phabricator.kde.org/D5167 AFFECTED

D5143: Introduce fetch-translations build command

sitter added a comment. The way I understand it the use case here is during development, so I am not sure the ki18n circular dep is particularly concerning. Avoiding it seems fairly difficult as find_package needs to happen at configure-time, fetch-translations at build-time, and so we only

D5088: Generate plugins.qmltypes files for the plugins we install

apol added a comment. Can somebody please help review the ECM side of things? https://phabricator.kde.org/D5087 REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D5088 To: apol, #plasma, #frameworks, davidedmundson Cc:

D5195: don't add the autotests dir when test building is disabled

sitter added a reviewer: ilic. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D5195 To: sitter, ilic Cc: #frameworks

D5195: don't add the autotests dir when test building is disabled

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY autotests need qt5qml which is other than that not needed for ki18n REPOSITORY R249 KI18n BRANCH master REVISION DETAIL

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

> On March 25, 2017, 4:30 p.m., Elvis Angelaccio wrote: > > src/ioslaves/file/file.cpp, line 1428 > > > > > > I tried to delete a folder (`kioclient5 remove /opt/test/`) but I > > didn't get this warning. > >

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129983/ --- (Updated March 27, 2017, noon) Review request for KDE Frameworks, David

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

> On March 22, 2017, 10:08 a.m., Elvis Angelaccio wrote: > > src/ioslaves/file/kauth/file.actions, lines 1-5 > > > > > > I don't see the advantage of using a single kauth action. This way you > > are generating

D5173: Fix 'Installation of ksendbugmail.exe conflicts with related KDE4 package'.

dfaure added inline comments. INLINE COMMENTS > habacker wrote in kbugreport.cpp:527 > BTW: This will not work on Windows because the absolute build time install > path is used which differs in mostly cases from the runtime install path. Which is why this is just a fallback ;) The question

D5173: Fix 'Installation of ksendbugmail.exe conflicts with related KDE4 package'.

dfaure added a comment. Well I would accept a compromise, where dbus-started services get installed in bin on Unix as well. Which means still only two install vars and dirs: bin and libexec. With consistency between Unix and Windows about whether a given executable gets installed into bin