ngraham marked 4 inline comments as done.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D8528
To: ngraham, vhanda, #frameworks
Cc: rkflx, #frameworks
ngraham updated this revision to Diff 21461.
ngraham added a comment.
Only mark multipage DjVu files as documents, and remove crufty old
compatibility mimetype that's probably not relevant at all
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
rkflx added inline comments.
INLINE COMMENTS
> rkflx wrote in basicindexingjob.cpp:219
> Looking at `/usr/share/mime/image`, I see:
>
> - `vnd.djvu.xml`: "DjVu image"
> - `vnd.djvu+multipage.xml`: "DjVu document"
>
> …and that's also what Dolphin shows. Probably best to add `+multipage` here?
ngraham edited the test plan for this revision.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D8528
To: ngraham, vhanda, #frameworks
Cc: rkflx, #frameworks
ngraham updated this revision to Diff 21459.
ngraham marked an inline comment as done.
ngraham added a comment.
Actually we don't need the xml extension here
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8528?vs=21458=21459
BRANCH
ngraham added inline comments.
INLINE COMMENTS
> rkflx wrote in basicindexingjob.cpp:220
> Is `x-djvu` a thing? Not sure, that's why I'm asking.
https://www.cuminas.jp/docs/djvuplugin/en_us/Content/MIME%20Types.htm said that
it was an older one, so I figured I'd add that one for maximum
ngraham updated this revision to Diff 21458.
ngraham added a comment.
Adjusting MIME types to match what's in /usr/share/mime/images
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8528?vs=21455=21458
BRANCH
djvu_files_documents_369195
REVISION DETAIL
smithjd added a comment.
Deep tag copies (to the filesystem and also in the slave) are known to be
broken (1 or more folder deep) because of the preview fix in the first revision.
REPOSITORY
R293 Baloo
BRANCH
master-nestedTags (branched from master)
REVISION DETAIL
rkflx added a comment.
General sentiment makes sense, most DjVu documents I've seen were more like
books. However, see inline comment. (Someone with actual mimetype or baloo
knowledge should approve, though.)
> didn't crash baloo with basic usage
If you don't have a DjVu file,
ngraham edited the summary of this revision.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D8528
To: ngraham, vhanda, #frameworks
Cc: #frameworks
ngraham added reviewers: vhanda, Frameworks.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D8528
To: ngraham, vhanda, #frameworks
Cc: #frameworks
ngraham created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
BUG: 369195
TEST PLAN
Tested in KDE Neon. Compiled and deployed fine; didn't crash baloo with basic
usage. Unable to test beyond that
emateli updated this revision to Diff 21453.
emateli added a comment.
Well, the diff of this patch took a sizeable reduction.
I took a second look at this and here is what happened in the end and what
caused the inconsistency with Dolphin.
The issue was that the `QDialogButtonBox`
ngraham edited the test plan for this revision.
ngraham added reviewers: Dolphin, Frameworks.
ngraham added a project: Dolphin.
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D8527
To: ngraham, #dolphin, #frameworks
Cc: spoorun, navarromorales, firef, ngraham,
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:9afc2c3768e0: more compact password dialog (authored by
rjvbb).
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8437?vs=21340=21445
REVISION DETAIL
graesslin added a comment.
Maybe we can drop the force activate for all hosts? Are there any
implementations left which are on X11? At least Ubuntu is Wayland based.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D8519
To: mkoller, davidedmundson, graesslin
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
I have been using this for weeks without any negative effects. I'm giving
this my blessing, but let's wait for others to weigh in.
REPOSITORY
R293 Baloo
BRANCH
master-nestedTags
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/135/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Fri, 27 Oct 2017 15:31:45 +
Build duration:
1 min 23 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/129/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Fri, 27 Oct 2017 15:31:45 +
Build duration:
58 sec and counting
JUnit Tests
davidedmundson added a comment.
Ah, I 1000% agree it /should/ work like that.
My very first comment on here ended with:
> In an ideal world the original SNI spec would have passed a timestamp...
So bringing discussion back to this patch.
- We need
graesslin added a comment.
In https://phabricator.kde.org/D8519#160909, @davidedmundson wrote:
> In https://phabricator.kde.org/D8519#160879, @graesslin wrote:
>
> > Actually even on X it is quite simple to get it right. We have the window
Id, so the host needs to update the xTime in
mart updated this revision to Diff 21440.
mart added a comment.
- skip widgets that don't accept focus
REPOSITORY
R295 KCMUtils
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8522?vs=21435=21440
BRANCH
phab/keynav
REVISION DETAIL
https://phabricator.kde.org/D8522
AFFECTED
davidedmundson added a comment.
In https://phabricator.kde.org/D8519#160879, @graesslin wrote:
> Actually even on X it is quite simple to get it right. We have the window
Id, so the host needs to update the xTime in the window. The only question is
whether Qt reads it back. With an up
kossebau added a comment.
In https://phabricator.kde.org/D7194#160789, @leinir wrote:
> This already went into one release, and it would be quite useful to get it
sorted before the next one rolls around, and the consensus seems to be
reverting, as leaving kns with this patch in has some
graesslin added a comment.
Actually even on X it is quite simple to get it right. We have the window Id,
so the host needs to update the xTime in the window. The only question is
whether Qt reads it back. With an up to date xTime a simple activate without a
force should work.
REPOSITORY
graesslin added a comment.
In https://phabricator.kde.org/D8519#160813, @davidedmundson wrote:
> > The removal of the force activation is done since according to kwin
maintainer it is wrong and must be done by the SysTray itself.
>
> But according the the status notifier item
mart added a reviewer: Frameworks.
REPOSITORY
R295 KCMUtils
REVISION DETAIL
https://phabricator.kde.org/D8522
To: mart, #plasma, #frameworks
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
QQuickWidget doesn't support keyboard navigation per se,
the widget will gain keyboard
graesslin added a comment.
In https://phabricator.kde.org/D8159#160808, @davidedmundson wrote:
> FYI, I'm deliberately delaying after I heard from Jonas how they might put
it in GTK.
> Technically they could have a v1 here, and we could have v2 with the added
feature set and it would
ngraham added a comment.
Go ahead and land this, @rjvbb! Nice work.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D8437
To: rjvbb, #frameworks, kfunk, ngraham
Cc: cfeck, ngraham
mkoller updated this revision to Diff 21431.
mkoller added a comment.
In https://phabricator.kde.org/D8519#160813, @davidedmundson wrote:
> > The removal of the force activation is done since according to kwin
maintainer it is wrong and must be done by the SysTray itself.
>
> But
davidedmundson added inline comments.
INLINE COMMENTS
> kstatusnotifieritem.cpp:453
> d->menu = menu;
> -d->menu->setParent(nullptr);
> +//d->menu->setParent(nullptr);
> }
make setContextMenu safe against null pointers, prevents creating a dbus menu
exporter when we don't care
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
> The removal of the force activation is done since according to kwin
maintainer it is wrong and must be done by the SysTray itself.
But according the the
davidedmundson added a comment.
FYI, I'm deliberately delaying after I heard from Jonas how they might put it
in GTK.
Technically they could have a v1 here, and we could have v2 with the added
feature set and it would be fine, but I want to see how the discussion plays
out before
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20XenialQt5.7/29/
Project:
Frameworks kservice kf5-qt5 XenialQt5.7
Date of build:
Fri, 27 Oct 2017 11:23:38 +
Build duration:
2 min 16 sec and counting
JUnit Tests
mkoller created this revision.
mkoller added reviewers: davidedmundson, graesslin.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
The setParent() call in this patch was changing the window flags from Popup
to Window,
leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.
Right, yes, i think that was a bit of left over from working on it all. Go
for it.
REPOSITORY
R304 KNewStuff
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8188
To:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/126/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
Date of build:
Fri, 27 Oct 2017 10:48:17 +
Build duration:
21 min and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/125/
Project:
Frameworks kio kf5-qt5 XenialQt5.7
Date of build:
Fri, 27 Oct 2017 10:48:17 +
Build duration:
17 min and counting
JUnit Tests
Name: (root)
simgunz added a comment.
> Can we not just remove the drop down menu and always show the checkbox for
terminal?
Actually I've just changed that behaviour few months ago to follow the
"simple by default, powerful when needed" philosophy. See this review and the
related bug for the
leinir added a comment.
This already went into one release, and it would be quite useful to get it
sorted before the next one rolls around, and the consensus seems to be
reverting, as leaving kns with this patch in has some fairly unfortunate side
effects. Could we get it reverted before
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/124/
Project:
Frameworks kio kf5-qt5 XenialQt5.7
Date of build:
Fri, 27 Oct 2017 10:03:21 +
Build duration:
17 min and counting
JUnit Tests
Name: (root)
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/124/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
Date of build:
Fri, 27 Oct 2017 09:48:41 +
Build duration:
18 min and counting
JUnit Tests
Name: (root)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/123/
Project:
Frameworks kio kf5-qt5 XenialQt5.7
Date of build:
Fri, 27 Oct 2017 09:48:41 +
Build duration:
14 min and counting
JUnit Tests
Name: (root)
subdiff added a comment.
In https://phabricator.kde.org/D8056#159636, @fabianr wrote:
> Not really on topic, but could you change the label for the "Advanced
options" to something more meaningful, eg "Terminal options" ? The HIG
recommends not to use the label "Advanced options", but "
simgunz added a comment.
@ngraham Great! I don't have commit access.
@fabianr I agree on changing that label to "Terminal options". I'll send a
new revision request for that.
REPOSITORY
R241 KIO
BRANCH
openwithdialog-filter-app-tree
REVISION DETAIL
kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.
Looks like it :)
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D8437
To: rjvbb, #frameworks, kfunk, ngraham
Cc: cfeck, ngraham
47 matches
Mail list logo
