Re: Python bindings using cppyy (was: An update on Python bindings)

2018-01-14 Thread Albert Astals Cid
El dissabte, 13 de gener de 2018, a les 18:05:45 CET, Shaheed Haque va escriure: > Thanks to some upstream fixes, I have the cppyy-based bindings for KF5 and > also Qt5 (see below) showing signs of life. > Notes: This is awesome, i'm really happy we're in a point that framework-by-framework is

D9880: Fix build with >=attr-2.4.48

2018-01-14 Thread Andreas Sturmlechner
asturmlechner created this revision. asturmlechner added reviewers: Frameworks, mgallien. Restricted Application added a project: Frameworks. asturmlechner requested review of this revision. REVISION SUMMARY It was looking for long deprecated attr/xattr.h header. TEST PLAN Built fine with

D9871: Add partial busy-widget support

2018-01-14 Thread Aleix Pol Gonzalez
apol added a reviewer: andreask. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D9871 To: Kanedias, apol, colomar, andreask Cc: #frameworks

D9871: Add partial busy-widget support

2018-01-14 Thread Aleix Pol Gonzalez
apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. Please remove the changes in the *.sh files. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D9871 To: Kanedias, apol, colomar Cc: #frameworks

Re: KHolidays as Framework (redux)

2018-01-14 Thread Volker Krause
On Sunday, 14 January 2018 16:50:08 CET Sandro Knauß wrote: > @Volker: Is there a need to rush releasing KHolidays it under frameworks? this request is pending since more than 24 month, not exactly my definition of rushing things ;-) We should do the move reasonably early before the next

Re: KHolidays as Framework (redux)

2018-01-14 Thread Sandro Knauß
Hey, @Volker: Is there a need to rush releasing KHolidays it under frameworks? As far I see it, the include mechanism do not change find_package do not need to change and also the target_libraries do not need to changed also the API is fixed so far -> no changes in kdepim needed. The only

D9793: Fall back to language name for translations lookup if locale name fails

2018-01-14 Thread Albert Astals Cid
aacid added inline comments. INLINE COMMENTS > ECMQmLoader.cpp.in:68 > if (!loadTranslation(locale.name())) { > -loadTranslation(locale.bcp47Name()); > +int i = locale.name().indexOf(QLatin1Char('_')); > +if (i > 0) { I agree that

KDE CI: Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.9 - Build # 11 - Failure!

2018-01-14 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20FreeBSDQt5.9/11/ Project: Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 14 Jan 2018 16:26:33 + Build duration: 58 sec and counting

Re: KHolidays as Framework (redux)

2018-01-14 Thread Allen Winter
I don't object to making KHolidays a framework. I kinda object to the short timeline. I wanted to finish up some BIC cleaning. No API changes planned at this time. I'll try to hurry. On Sunday, January 14, 2018 4:20:38 AM EST Volker Krause wrote: > On Tuesday, 6 September 2016 12:03:15 CET

D9770: Optimization of byteSize(double size)

2018-01-14 Thread Nathaniel Graham
ngraham added a comment. Is anything else needed here before we can land this? REPOSITORY R288 KJobWidgets REVISION DETAIL https://phabricator.kde.org/D9770 To: jtamate, #frameworks, mwolff Cc: ngraham, cfeck, mwolff, broulik

D9275: fix RTL appearance for ComboBox

2018-01-14 Thread Safa Alfulaij
safaalfulaij added inline comments. INLINE COMMENTS > ComboBox.qml:113 > highlightMoveDuration: 0 > +LayoutMirroring.enabled: true > +LayoutMirroring.childrenInherit: true So it is true even for LTR locales? REPOSITORY R242 Plasma Framework (Library)

D9275: fix RTL appearance for ComboBox

2018-01-14 Thread Safa Alfulaij
safaalfulaij added a comment. In https://phabricator.kde.org/D9275#190606, @mvourlakos wrote: > To test it in Latte I added in the head of /shell/package/contents/configuration/AppearanceConfig.qml > > import org.kde.plasma.components 3.0 as PlasmaComponents3 > > > and I set

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 85 - Unstable!

2018-01-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/85/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sun, 14 Jan 2018 12:55:16 + Build duration: 14 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 85 - Unstable!

2018-01-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/85/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Sun, 14 Jan 2018 12:54:37 + Build duration: 11 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 65 - Still Failing!

2018-01-14 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/65/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 14 Jan 2018 12:54:37 + Build duration: 6 min 48 sec and counting CONSOLE OUTPUT

D9844: Don't stat(/etc/localtime) between read() and write() copying files

2018-01-14 Thread Jaime Torres Amate
jtamate marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9844 To: jtamate, #frameworks, dfaure Cc: broulik, ngraham, #dolphin

D9844: Don't stat(/etc/localtime) between read() and write() copying files

2018-01-14 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > jtamate wrote in slavebase.cpp:117 > Could it be done without a review? I was busy doing arc land (with some > problems) and I didn't notice. Sure REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9844 To: jtamate,

D9844: Don't stat(/etc/localtime) between read() and write() copying files

2018-01-14 Thread Jaime Torres Amate
jtamate added inline comments. INLINE COMMENTS > broulik wrote in slavebase.cpp:117 > Init with 0 in the constructor? Could it be done without a review? I was busy doing arc land (with some problems) and I didn't notice. REPOSITORY R241 KIO REVISION DETAIL

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 64 - Failure!

2018-01-14 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/64/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 14 Jan 2018 12:40:12 + Build duration: 2 min 38 sec and counting CONSOLE OUTPUT

D9844: Don't stat(/etc/localtime) between read() and write() copying files

2018-01-14 Thread Jaime Torres Amate
This revision was automatically updated to reflect the committed changes. Closed by commit R241:f7e00b40a6d3: Dont stat(/etc/localtime) between read() and write() copying files (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D9844: Don't stat(/etc/localtime) between read() and write() copying files

2018-01-14 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > slavebase.cpp:117 > +QElapsedTimer nextTimeout; > +qint64 nextTimeoutMsecs; > KIO::filesize_t totalSize; Init with 0 in the constructor? REPOSITORY R241 KIO BRANCH elapsedtimer (branched from master) REVISION DETAIL

D9844: Don't stat(/etc/localtime) between read() and write() copying files

2018-01-14 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Well spotted! REPOSITORY R241 KIO BRANCH elapsedtimer (branched from master) REVISION DETAIL https://phabricator.kde.org/D9844 To: jtamate, #frameworks, dfaure Cc: ngraham,

D9844: Don't stat(/etc/localtime) between read() and write() copying files

2018-01-14 Thread Elvis Angelaccio
elvisangelaccio added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9844 To: jtamate, #frameworks, dfaure Cc: ngraham, #dolphin

D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files

2018-01-14 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. This goes against the whole redesign of ksycoca that I did some time ago. It's supposed to check timestamps on dirs, to rebuild the cache on demand, much like many other caches

Re: Current security issues with KAuth support in KIO

2018-01-14 Thread chinmoy ranjan
> Is someone already working on fixes for the above issues? Currently I am looking into the issues.

Re: KHolidays as Framework (redux)

2018-01-14 Thread David Faure
On dimanche 14 janvier 2018 10:20:38 CET Volker Krause wrote: > On Tuesday, 6 September 2016 12:03:15 CET Volker Krause wrote: > > On Friday 01 January 2016 18:24:17 David Faure wrote: > > > On Thursday 24 December 2015 12:28:13 John Layt wrote: > > > > Hi, > > > > > > > > It's xmas holidays, so

Re: [kio] src/ioslaves/file/kauth: Do not cache root password for the whole session

2018-01-14 Thread Elvis Angelaccio
On venerdì 12 gennaio 2018 17:35:30 CET, chinmoy ranjan wrote: I just tested this in my session: kioclient5 copy /mnt Prompt appears, all OK. Now I do this again in the same session, after removing the file: kioclient5 copy /mnt No password prompt and the file is copied anyway. I

Re: Current security issues with KAuth support in KIO

2018-01-14 Thread Luca Beltrame
Il giorno Sun, 14 Jan 2018 11:12:15 +0100 Elvis Angelaccio ha scritto: > No, it's not. Despite the name, 'Persistence=session' just means the > privilege is kept for a few minutes. As discussed on IRC, this is an "issue" due to the fact that KIO can do much more than

Re: Using KWallet from non-KDE apps (G.Chrome...)

2018-01-14 Thread Valentin Rusu
Hey, Sorry for the apparent late reply - I started to have some spare time so I'm back looking the KDE e-mails :-) * René J.V. Bertin [2017-12-20 10:37:07 +0100]: > Hi, > > Is it still possible to query a KWallet for the existence of specific > credentials without having

D9871: Add partial busy-widget support

2018-01-14 Thread Oleg Chernovskiy
Kanedias created this revision. Kanedias added reviewers: apol, colomar. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. Kanedias requested review of this revision. REVISION SUMMARY - added busy-widget icon 32-px action variant -

D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files

2018-01-14 Thread Elvis Angelaccio
elvisangelaccio added a reviewer: dfaure. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D9840 To: jtamate, #frameworks, dfaure Cc: ngraham, mmustac

Re: [kio] src/ioslaves/file/kauth: Do not cache root password for the whole session

2018-01-14 Thread Elvis Angelaccio
On venerdì 12 gennaio 2018 19:40:50 CET, David Edmundson wrote: Can we keep all messages on the ML. We can only see half a conversation on here. TBH I can't see how any application will bypass the prompt A rogue plugin can call org.kde.kio.file.exec directly with kauth. Or even just use

Re: Current security issues with KAuth support in KIO

2018-01-14 Thread Elvis Angelaccio
On sabato 13 gennaio 2018 23:55:16 CET, Luca Beltrame wrote: (please keep Fabian in CC, he's not subscribed and found out most of the issues reported here) At openSUSE we have to request reviews by the security team before new polkit services get accepted. This is the case for the kio kauth

D9275: fix RTL appearance for ComboBox

2018-01-14 Thread Michail Vourlakos
mvourlakos added a comment. In https://phabricator.kde.org/D9275#190594, @safaalfulaij wrote: > In https://phabricator.kde.org/D9275#190569, @mvourlakos wrote: > > > with your example me I cant reproduce it either... > > I can only reproduce it with Latte Settings window, all other

Re: KHolidays as Framework (redux)

2018-01-14 Thread Volker Krause
On Tuesday, 6 September 2016 12:03:15 CET Volker Krause wrote: > On Friday 01 January 2016 18:24:17 David Faure wrote: > > On Thursday 24 December 2015 12:28:13 John Layt wrote: > > > Hi, > > > > > > It's xmas holidays, so it must be time to poke a stick at KHolidays > > > again > > > for

D9275: fix RTL appearance for ComboBox

2018-01-14 Thread Safa Alfulaij
safaalfulaij added a comment. In https://phabricator.kde.org/D9275#190569, @mvourlakos wrote: > with your example me I cant reproduce it either... > I can only reproduce it with Latte Settings window, all other components are aligned correctly except the PlasmaComponent3.Combobox list

D9275: fix RTL appearance for ComboBox

2018-01-14 Thread Michail Vourlakos
mvourlakos added a comment. In https://phabricator.kde.org/D9275#190547, @safaalfulaij wrote: > In https://phabricator.kde.org/D9275#190497, @mvourlakos wrote: > > > how did you test it? > > > > I tried in an qml app (Latte dock) by passing the parameter "--reverse"... > > If