BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.7/25/
Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.7
Date of build:
Mon, 29 Jan 2018 04:03:10 +
Build duration:
29 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/15/
Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 29 Jan 2018 04:03:30 +
Build duration:
19 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/19/
Project:
Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 29 Jan 2018 04:03:10 +
Build duration:
19 min and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/81/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 29 Jan 2018 04:03:21 +
Build duration:
18 min and counting
JUnit Tests
Name: (root)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/24/
Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.10
Date of build:
Mon, 29 Jan 2018 04:03:10 +
Build duration:
18 min and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.7/21/
Project:
Frameworks kpackage kf5-qt5 SUSEQt5.7
Date of build:
Mon, 29 Jan 2018 04:03:30 +
Build duration:
12 min and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/40/
Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.7
Date of build:
Mon, 29 Jan 2018 04:02:55 +
Build duration:
11 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/29/
Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
Date of build:
Mon, 29 Jan 2018 04:02:50 +
Build duration:
10 min and counting
JUnit Tests
Name: (root)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/21/
Project:
Frameworks kpackage kf5-qt5 SUSEQt5.10
Date of build:
Mon, 29 Jan 2018 04:03:30 +
Build duration:
6 min 54 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/38/
Project:
Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 29 Jan 2018 04:02:55 +
Build duration:
7 min 40 sec and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/30/
Project:
Frameworks baloo kf5-qt5 SUSEQt5.7
Date of build:
Mon, 29 Jan 2018 04:02:50 +
Build duration:
6 min 37 sec and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/40/
Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.10
Date of build:
Mon, 29 Jan 2018 04:02:55 +
Build duration:
2 min 8 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/40/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
Date of build:
Mon, 29 Jan 2018 02:19:04 +
Build duration:
6 min 50 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/35/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.7
Date of build:
Mon, 29 Jan 2018 02:19:04 +
Build duration:
4 min 39 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/24/
Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 29 Jan 2018 02:19:04 +
Build duration:
4 min 4 sec and counting
JUnit
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/12/
Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
Date of build:
Mon, 29 Jan 2018 01:48:08 +
Build duration:
5 min 24 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.9/12/
Project:
Frameworks purpose kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 29 Jan 2018 01:48:08 +
Build duration:
3 min 0 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.7/13/
Project:
Frameworks purpose kf5-qt5 SUSEQt5.7
Date of build:
Mon, 29 Jan 2018 01:48:08 +
Build duration:
2 min 2 sec and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20WindowsMSVCQt5.9/14/
Project:
Frameworks purpose kf5-qt5 WindowsMSVCQt5.9
Date of build:
Mon, 29 Jan 2018 00:16:13 +
Build duration:
24 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.9/11/
Project:
Frameworks purpose kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 29 Jan 2018 00:16:13 +
Build duration:
3 min 44 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/11/
Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
Date of build:
Mon, 29 Jan 2018 00:16:13 +
Build duration:
3 min 25 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.7/12/
Project:
Frameworks purpose kf5-qt5 SUSEQt5.7
Date of build:
Mon, 29 Jan 2018 00:16:18 +
Build duration:
3 min 5 sec and counting
JUnit Tests
Name:
rjvbb added a comment.
> In the code shown by this patch ;) Line 80.
Right. Doh. The line that causes other side-effects when you comment it out :)
> But the test you suggested that I do above is further proof anyhow.
>
> But even without setStyleName call (i.e.
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20WindowsMSVCQt5.9/13/
Project:
Frameworks purpose kf5-qt5 WindowsMSVCQt5.9
Date of build:
Sun, 28 Jan 2018 22:24:47 +
Build duration:
8 min 33 sec and counting
CONSOLE
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/10/
Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
Date of build:
Sun, 28 Jan 2018 22:24:47 +
Build duration:
2 min 19 sec and counting
CONSOLE OUTPUT
dfaure added a comment.
In https://phabricator.kde.org/D9070#197332, @rjvbb wrote:
> What happens when you remove the `,Regular`
That fixes the problem indeed.
>> Workaround: enabling the line that calls
QApplication::setDesktopSettingsAware(false).
>> Proof that this
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.7/11/
Project:
Frameworks purpose kf5-qt5 SUSEQt5.7
Date of build:
Sun, 28 Jan 2018 22:24:47 +
Build duration:
1 min 7 sec and counting
CONSOLE OUTPUT
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.9/10/
Project:
Frameworks purpose kf5-qt5 FreeBSDQt5.9
Date of build:
Sun, 28 Jan 2018 22:24:47 +
Build duration:
1 min 28 sec and counting
CONSOLE OUTPUT
Hi,
KMainWindow takes care of saving/restoring the state of the main window,
menus and toolbars.
Also, the size of the main window is correctly stored and restored.
However, I don't see how
to save and restore the position of the main window. I checked couple of
KDE programs
like dolphin,
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:34babd2ffc86: Dont set the LD_LIBRARY_PATH in
prefix.sh (authored by apol).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9550?vs=24473=26159
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20WindowsMSVCQt5.9/12/
Project:
Frameworks purpose kf5-qt5 WindowsMSVCQt5.9
Date of build:
Sun, 28 Jan 2018 22:15:42 +
Build duration:
5 min 59 sec and counting
CONSOLE
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/9/
Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
Date of build:
Sun, 28 Jan 2018 22:15:42 +
Build duration:
4 min 27 sec and counting
CONSOLE OUTPUT
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.7/10/
Project:
Frameworks purpose kf5-qt5 SUSEQt5.7
Date of build:
Sun, 28 Jan 2018 22:15:42 +
Build duration:
2 min 3 sec and counting
CONSOLE OUTPUT
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.9/9/
Project:
Frameworks purpose kf5-qt5 FreeBSDQt5.9
Date of build:
Sun, 28 Jan 2018 22:15:42 +
Build duration:
1 min 26 sec and counting
CONSOLE OUTPUT
aacid closed this revision.
REPOSITORY
R269 BluezQt
REVISION DETAIL
https://phabricator.kde.org/D10167
To: aacid, dhaumann, drosca
Cc: drosca, #frameworks, michaelh
aacid updated this revision to Diff 26156.
aacid retitled this revision from "Initialize m_usableAdapter with nullptr" to
"No need to initialize m_usableAdapterwith nullptr".
aacid edited the summary of this revision.
aacid removed a subscriber: dhaumann.
aacid added a comment.
update message
drosca accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R269 BluezQt
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10167
To: aacid, dhaumann, drosca
Cc: dhaumann, drosca, #frameworks, michaelh
aacid updated this revision to Diff 26155.
aacid added a comment.
remove the line altogether
REPOSITORY
R269 BluezQt
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10167?vs=26153=26155
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10167
AFFECTED FILES
dhaumann added a comment.
+1, but someone else must approve.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D10166
To: aacid
Cc: dhaumann, #frameworks, #build_system, michaelh
aacid created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
aacid requested review of this revision.
REVISION SUMMARY
I'm a bit unconvinced, wihtout it we get a warning if we enable
-Wzero-as-null-pointer-constant
drosca requested changes to this revision.
drosca added a comment.
This revision now requires changes to proceed.
Since it is a shared pointer then it doesn't need explicit initialization and
this line can just be removed.
REPOSITORY
R269 BluezQt
REVISION DETAIL
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Looks good to me.
REPOSITORY
R269 BluezQt
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10167
To: aacid, dhaumann
Cc: dhaumann, drosca, #frameworks, michaelh
aacid created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
aacid requested review of this revision.
REVISION SUMMARY
instead of 0 since it's a [shared] pointer
REPOSITORY
R269 BluezQt
BRANCH
master
REVISION
aacid created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
aacid requested review of this revision.
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
michaelh updated this revision to Diff 26149.
michaelh added a comment.
Change execution order in setFileItem
REPOSITORY
R824 Baloo Widgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10113?vs=26135=26149
BRANCH
dataavail
REVISION DETAIL
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
I don't feel confident approving the security-related fixes in here. Maybe
Thiago or Oswald could have a look...
INLINE COMMENTS
> fdreceiver.cpp:61
> }
> +
elvisangelaccio accepted this revision as: elvisangelaccio.
elvisangelaccio added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> filemetadataprovider.cpp:106
>
> +
> }
unrelated whitespace change
> filemetadataprovider.h:119
>
> +
> +private:
michaelh updated this revision to Diff 26135.
michaelh added a comment.
Correct yet another update error
REPOSITORY
R824 Baloo Widgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10113?vs=26131=26135
BRANCH
dataavail
REVISION DETAIL
https://phabricator.kde.org/D10113
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/39/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
Date of build:
Sun, 28 Jan 2018 14:51:16 +
Build duration:
8 min 49 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/34/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.7
Date of build:
Sun, 28 Jan 2018 14:51:16 +
Build duration:
8 min 3 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/23/
Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9
Date of build:
Sun, 28 Jan 2018 14:51:16 +
Build duration:
6 min 18 sec and counting
JUnit
michaelh updated this revision to Diff 26134.
michaelh added a comment.
Correct typo
REPOSITORY
R824 Baloo Widgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10105?vs=26132=26134
BRANCH
requestfinished (branched from master)
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R244:e5825110c889: Match also spdx keys LGPL-2.1
LGPL-2.1+ (authored by kossebau).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D10152?vs=26091=26133#toc
REPOSITORY
R244 KCoreAddons
CHANGES
michaelh added a comment.
@elvisangelaccio: Sorry for this updating mess. These nested branches are
just too error-prone for me, because they look so similar. Won't do that again.
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D10105
To: michaelh,
michaelh updated this revision to Diff 26132.
michaelh marked an inline comment as done.
michaelh added a comment.
Add Q_ASSERT
REPOSITORY
R824 Baloo Widgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10105?vs=26079=26132
BRANCH
requestfinished (branched from master)
michaelh updated this revision to Diff 26131.
REPOSITORY
R824 Baloo Widgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10113?vs=26129=26131
BRANCH
dataavail
REVISION DETAIL
https://phabricator.kde.org/D10113
AFFECTED FILES
src/filemetadataprovider.cpp
michaelh updated this revision to Diff 26129.
michaelh added a comment.
Add Q_ASSERT
REPOSITORY
R824 Baloo Widgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10113?vs=26120=26129
BRANCH
dataavail
REVISION DETAIL
https://phabricator.kde.org/D10113
AFFECTED FILES
apol added a comment.
Hi, what happened with this?
@vpinon were you able to look into @cgiboudeaux concerns?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D8281
To: vpinon, dfaure, apol, kfunk, #windows
Cc: cgiboudeaux, #frameworks, #build_system,
elvisangelaccio added inline comments.
INLINE COMMENTS
> michaelh wrote in filemetadataprovider.cpp:141
> I've been thinking about this...
>
> We already have guards against files.isEmpty() in
>
> 355if (!urls.isEmpty()) {
>
> and
>
> 373 } else if (items.size() == 1) {
>
> Unless
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:ddaac7d8c7dc: Highlight Khronos Collada and glTF files
(authored by vkrause).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10159?vs=26118=26124
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:08f85b409b4c: Fix ini highlighting of values containing ;
or # characters (authored by vkrause).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
vonreth added a comment.
yay thanks
REPOSITORY
R216 Syntax Highlighting
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10158
To: vkrause, #framework_syntax_highlighting, vonreth, dhaumann
Cc: #frameworks, michaelh
nibags added a comment.
Thanks!
With (^|\s) I mean that it is not necessarily the first word of a line,
rather after a space.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D10136
To: nibags, #framework_syntax_highlighting, dhaumann
Cc: dhaumann,
michaelh updated this revision to Diff 26120.
michaelh added a comment.
Revert incorrect diff update
REPOSITORY
R824 Baloo Widgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10113?vs=26117=26120
BRANCH
dataavail
REVISION DETAIL
https://phabricator.kde.org/D10113
dhaumann accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10158
To: vkrause, #framework_syntax_highlighting, vonreth, dhaumann
Cc: #frameworks, michaelh
dhaumann accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10159
To: vkrause, #framework_syntax_highlighting, dhaumann
Cc: #frameworks, michaelh
rjvbb added a comment.
> Unfortunately, this patch doesn't fix it. The text still isn't bold.
No, this patch is written to be as transparent as possible. It won't impose a
stylename, but will not remove it either.
What happens when you remove the `,Regular`, i.e.
[General]
michaelh updated this revision to Diff 26117.
michaelh added a comment.
Apply suggested changes
REPOSITORY
R824 Baloo Widgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10113?vs=26071=26117
BRANCH
unittest
REVISION DETAIL
https://phabricator.kde.org/D10113
AFFECTED
vkrause created this revision.
vkrause added a reviewer: Framework: Syntax Highlighting.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
vkrause requested review of this revision.
REVISION SUMMARY
Those are XML and JSON respectively.
dhaumann added a comment.
Ok, I can see that now ;) Thanks.
REPOSITORY
R175 PIM: KHolidays
REVISION DETAIL
https://phabricator.kde.org/D10135
To: vkrause, #frameworks, #kde_pim, mlaurent
Cc: dhaumann, mlaurent, dvasin, winterz, vkrause, knauss, dvratil
vkrause created this revision.
vkrause added reviewers: Framework: Syntax Highlighting, vonreth.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
vkrause requested review of this revision.
REVISION SUMMARY
;/# are part of values, not
michaelh marked 2 inline comments as done.
michaelh added inline comments.
INLINE COMMENTS
> elvisangelaccio wrote in filemetadataprovider.cpp:141
> Why not? `insertEditableData()` just sets some defaults, how is it related to
> `files`?
I've been thinking about this...
We already have guards
vkrause added a comment.
In https://phabricator.kde.org/D10135#197280, @dhaumann wrote:
> - What's missing (or I miss something) is that it could be that entries
exist twice, if in resource and on disk. Since this is not the case right now,
this is probably not an issue.
In that
dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.
@genethomas Unfortunately we are so late with the review that your patch does
not apply cleanly anymore. Could you update your patch?
REPOSITORY
R216 Syntax Highlighting
dhaumann added a comment.
I'm late to the game, but in general looks good.
Minor comments:
- What's missing (or I miss something) is that it could be that entries exist
twice, if in resource and on disk. Since this is not the case right now, this
is probably not an issue.
-
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:c0f5d9ec6eec: AppArmor: new keywords, improvements
fixes (authored by nibags, committed by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/33/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.7
Date of build:
Sun, 28 Jan 2018 11:02:05 +
Build duration:
6 min 42 sec and counting
JUnit Tests
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Looks good and test passes. Just one minor comment that is not really
relevant for now - will push in a second.
INLINE COMMENTS
> apparmor.xml:709
>
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/22/
Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9
Date of build:
Sun, 28 Jan 2018 11:02:05 +
Build duration:
6 min 30 sec and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/38/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
Date of build:
Sun, 28 Jan 2018 11:02:06 +
Build duration:
3 min 49 sec and counting
JUnit Tests
This revision was automatically updated to reflect the committed changes.
Closed by commit R244:18e4d245d3d5: Use the much faster urls() method from
QMimeData (authored by jtamate).
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10155?vs=26110=26113
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R244 KCoreAddons
BRANCH
paste (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D10155
To: jtamate, #frameworks, dfaure
Cc: michaelh
dfaure added a comment.
I've been hitting a very similar bug where a Qt app was trying to use a bold
font, and this had no effect when running in a plasma workspace, because of
this code in kfontsettingsdata.cpp.
Testcase (couldn't be simpler...)
elvisangelaccio added inline comments.
INLINE COMMENTS
> filemetadataprovider.cpp:137
> +
> +if (files.size() == 0) {
> +emit loadingFinished();
`files.isEmpty()`
> michaelh wrote in filemetadataprovider.cpp:141
> We can leave early here, I think.
> Without a file
>
> 149
jtamate updated this revision to Diff 26110.
jtamate added a comment.
- Use the much faster urls() method from QMimeData
Using hasUrls() and fixed a typo in the comment
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10155?vs=26096=26110
BRANCH
jtamate updated this revision to Diff 26109.
jtamate added a comment.
Reverting to first patch.
The lambda syntax has some problems with private d_func pointers under dolphin
Thread 1 "dolphin" received signal SIGSEGV, Segmentation fault.
0x721b5b4c in KJob::d_func
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Ah I guess it's faster because QMimeData skips the encoding/decoding via
QByteArray when both drag and drop are in the same process? That's not
something we can do ourselves (for
davidk updated this revision to Diff 26108.
davidk added a comment.
Update TODO items.
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8532?vs=21469=26108
BRANCH
seccomp
REVISION DETAIL
https://phabricator.kde.org/D8532
AFFECTED FILES
CMakeLists.txt
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Indeed.
Fixed in shared-mime-info 1.10 (commit 009f22a,
https://bugs.freedesktop.org/show_bug.cgi?id=101667)
Fix proposed for Qt: https://codereview.qt-project.org/218155
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:c30802019895: Add FindSeccomp to find-modules (authored
by davidk).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8998?vs=26106=26107
REVISION DETAIL
davidk added a comment.
Thanks for your review.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D8998
To: davidk, graesslin, cgiboudeaux
Cc: cgiboudeaux, #frameworks, #build_system, michaelh
davidk updated this revision to Diff 26106.
davidk added a comment.
Fix version.
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8998?vs=24751=26106
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8998
AFFECTED FILES
cgiboudeaux accepted this revision.
cgiboudeaux added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> FindSeccomp.cmake:21
> +#
> +# Since 5.42.0.
> +
5.44.0
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
davidk added a comment.
@cgiboudeaux is it ready to go now?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D8998
To: davidk, graesslin
Cc: cgiboudeaux, #frameworks, #build_system, michaelh
graesslin updated this revision to Diff 26098.
graesslin added a comment.
Remove the usless assert Roman found
REPOSITORY
R268 KGlobalAccel
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10081?vs=25895=26098
BRANCH
dont-assert-on-dbus-misusage
REVISION DETAIL
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/37/
Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.7
Date of build:
Sun, 28 Jan 2018 08:24:35 +
Build duration:
35 min and counting
JUnit Tests
jtamate created this revision.
jtamate added reviewers: Frameworks, dfaure.
Restricted Application added a project: Frameworks.
jtamate requested review of this revision.
REVISION SUMMARY
When requesting a list of text/uri-list, use the much faster QMimeData
urls() method.
The unittests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/36/
Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
Date of build:
Sun, 28 Jan 2018 08:24:35 +
Build duration:
7 min 42 sec and counting
JUnit Tests
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:2d6a2b517868: improve line heigh computation try to avoid
cutting of parts of glyphs (authored by cullmann).
cullmann added a comment.
Thanks for testing, will apply that then now ;=)
For the vertical lines: yes, that is exactly the same effect you get with
some font sizes horizontally.
Hope they fix that in bug https://bugreports.qt.io/browse/QTBUG-66036
REPOSITORY
R39 KTextEditor
100 matches
Mail list logo
