BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.9/23/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9
Date of build:
Sun, 04 Feb 2018 04:15:55 +
Build duration:
39 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/34/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
Date of build:
Sun, 04 Feb 2018 04:16:09 +
Build duration:
36 min and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/111/
Project:
Frameworks kio kf5-qt5 SUSEQt5.7
Date of build:
Sun, 04 Feb 2018 04:15:36 +
Build duration:
35 min and counting
JUnit Tests
Name: (root)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/37/
Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
Date of build:
Sun, 04 Feb 2018 04:15:55 +
Build duration:
29 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.7/15/
Project:
Frameworks krunner kf5-qt5 SUSEQt5.7
Date of build:
Sun, 04 Feb 2018 04:15:46 +
Build duration:
23 min and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.9/7/
Project:
Frameworks krunner kf5-qt5 FreeBSDQt5.9
Date of build:
Sun, 04 Feb 2018 04:15:46 +
Build duration:
23 min and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/61/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
Date of build:
Sun, 04 Feb 2018 04:16:09 +
Build duration:
21 min and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/92/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
Date of build:
Sun, 04 Feb 2018 04:15:36 +
Build duration:
20 min and counting
JUnit Tests
Name: (root)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/38/
Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.7
Date of build:
Sun, 04 Feb 2018 04:15:55 +
Build duration:
18 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/58/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
Date of build:
Sun, 04 Feb 2018 04:16:09 +
Build duration:
12 min and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.10/15/
Project:
Frameworks krunner kf5-qt5 SUSEQt5.10
Date of build:
Sun, 04 Feb 2018 04:15:46 +
Build duration:
3 min 42 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/41/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
Date of build:
Sun, 04 Feb 2018 02:18:50 +
Build duration:
5 min 15 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/36/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.7
Date of build:
Sun, 04 Feb 2018 02:18:50 +
Build duration:
4 min 25 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/25/
Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9
Date of build:
Sun, 04 Feb 2018 02:18:51 +
Build duration:
3 min 51 sec and counting
JUnit
wesdawg edited the summary of this revision.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D10286
To: wesdawg, #framework_syntax_highlighting
Cc: #frameworks, #framework_syntax_highlighting, michaelh, genethomas, ngraham,
cullmann, vkrause, dhaumann
wesdawg created this revision.
wesdawg added a reviewer: Framework: Syntax Highlighting.
wesdawg created this object with visibility "All Users".
wesdawg added a project: Framework: Syntax Highlighting.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/91/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
Date of build:
Sat, 03 Feb 2018 23:37:15 +
Build duration:
11 min and counting
JUnit Tests
Name: (root)
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:68a832c9e2aa: Use the destination KFileItem object to
figure out of its writable instead of… (authored by markg).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
ngraham accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
kfileitemproperties_optimization
REVISION DETAIL
https://phabricator.kde.org/D10282
To: markg, dfaure, ngraham
Cc: ngraham, #frameworks, michaelh
markg created this revision.
markg added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
markg requested review of this revision.
REVISION SUMMARY
Use KFileItem::isWritable instead of the detour with
ngraham added reviewers: VDG, andreaska.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D10279
To: astippich, #breeze, #vdg, andreaska
Cc: ngraham, #frameworks, michaelh
astippich added a comment.
It just adds a missing link to an already existing icon, is a screenshot
needed?
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D10279
To: astippich, #breeze
Cc: ngraham, #frameworks, michaelh
ngraham accepted this revision as: Baloo, ngraham.
This revision is now accepted and ready to land.
REPOSITORY
R293 Baloo
BRANCH
search (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D10205
To: michaelh, #frameworks, #dolphin, #baloo, mgallien, ngraham
Cc:
ngraham added a comment.
Before-and-after screenshots?
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D10279
To: astippich, #breeze
Cc: ngraham, #frameworks, michaelh
astippich created this revision.
astippich added a reviewer: Breeze.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
astippich requested review of this revision.
REVISION SUMMARY
media-album-cover icon is missing for the 24px size,
ngraham accepted this revision.
REPOSITORY
R824 Baloo Widgets
BRANCH
signalavailable (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D10113
To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin, #frameworks
Cc: dhaumann
wcpan updated this revision to Diff 26460.
wcpan added a comment.
Don't emit error signal before we tried all list commands.
Use a special error code to skip error reporting.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9672?vs=24747=26460
BRANCH
wcpan created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
wcpan requested review of this revision.
REPOSITORY
R241 KIO
BRANCH
fix-ftp-list
REVISION DETAIL
https://phabricator.kde.org/D10278
AFFECTED FILES
chinmoyr added a comment.
In https://phabricator.kde.org/D10273#200254, @thiago wrote:
> That doesn't make sense. There's QFile::encodeName in the code
I was talking talking about FdSender which is used only in kauth helper.
REPOSITORY
R241 KIO
REVISION DETAIL
thiago added a comment.
That doesn't make sense. There's QFile::encodeName in the code.
Is there a section of the library that is used in elevated privilege code,
but not all of it?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10273
To: chinmoyr, #frameworks
elvisangelaccio accepted this revision as: elvisangelaccio.
This revision is now accepted and ready to land.
REPOSITORY
R824 Baloo Widgets
BRANCH
signalavailable (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D10113
To: michaelh, elvisangelaccio, smithjd, vhanda,
chinmoyr added inline comments.
INLINE COMMENTS
> thiago wrote in fdsender.cpp:24
> The problem here is the API. Why is it using std::string in the first place?
The idea was to use std c++ and avoid qt throughout the class because the code
will be executed with elevated privileges.
REPOSITORY
thiago added a comment.
Looks good.
INLINE COMMENTS
> fdsender.cpp:24
>
> FdSender::FdSender(const std::string )
> : m_socketDes(-1)
The problem here is the API. Why is it using std::string in the first place?
REPOSITORY
R241 KIO
REVISION DETAIL
chinmoyr added inline comments.
INLINE COMMENTS
> thiago wrote in fdreceiver.cpp:88
> __APPLE__ is there. My question is about OpenBSD, NetBSD and DragonflyBSD.
> Are you breaking them? You may not know the answer, but you need to document
> the issue if you intentionally cause a Failure To
thiago added a comment.
The patch that I can see accomplishes what the description says it should do.
And I agree with the idea of the patch.
INLINE COMMENTS
> dfaure wrote in fdreceiver.cpp:88
> This is UNIX-only, but indeed OSX is missing. Does that support getpeereid?
__APPLE__ is
ngraham added a comment.
Needs a rebase on top of master, FWIW. Can't wait to have this!
REPOSITORY
R241 KIO
BRANCH
openwithdialog-filter-app-tree
REVISION DETAIL
https://phabricator.kde.org/D8056
To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, romangg, fabianr,
chinmoyr updated this revision to Diff 26451.
chinmoyr added a comment.
Fixed buffer overflow.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10273?vs=26445=26451
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10273
AFFECTED FILES
ossi added inline comments.
INLINE COMMENTS
> sharefd_p.h:61
> +const size_t pathSize = finalPath.size();
> +if (pathSize > 5 && pathSize < sizeof(a.sun_path) - 1) {
> #ifdef __linux__
you now have a buffer overflow on linux. you need to split the conditional.
REPOSITORY
chinmoyr edited the summary of this revision.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9966
To: chinmoyr, #frameworks, thiago, dfaure, ossi
Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh
chinmoyr updated this revision to Diff 26446.
chinmoyr added a comment.
Moved changes related to SocketAddress to https://phabricator.kde.org/D10273.
Changed #error to #warning. So even if an OS does not have getpeereid or
getsockopt compilation will still succeed but copying files will
chinmoyr updated this revision to Diff 26445.
chinmoyr added a comment.
Check for null byte at index 1 in case of returning address length on linux.
Use size of finalPath as pathSize.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10273?vs=26443=26445
chinmoyr updated this revision to Diff 26443.
chinmoyr added a comment.
Fixed typos
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10273?vs=26441=26443
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10273
AFFECTED FILES
chinmoyr updated this revision to Diff 26441.
chinmoyr added a comment.
Used QByteArray in FdSender
Undoed behavioral changes.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10273?vs=26438=26441
BRANCH
master
REVISION DETAIL
ossi added inline comments.
INLINE COMMENTS
> fdsender.cpp:27
> {
> +SocketAddress addr(path.c_str());
> +if (!addr.address()) {
this actually constructs a qbytearray. that should be probably explicit.
a better approach would be moving the class' interface to qbytearray (or
actually
chinmoyr updated this revision to Diff 26438.
chinmoyr added a comment.
Corrected number of bytes to be copied.
Added unlink().
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10273?vs=26436=26438
BRANCH
master
REVISION DETAIL
ossi added inline comments.
INLINE COMMENTS
> chinmoyr wrote in sharefd_p.h:60
> I just feel like the job of SocketAddress should be to create the address
> structure and not perform any file operation. Removal of the socket file
> should be handled by file ioslave or FdReceiver.
that's a
chinmoyr marked 2 inline comments as not done.
chinmoyr added inline comments.
INLINE COMMENTS
> ossi wrote in sharefd_p.h:60
> you still need to address that *somehow* ;)
I just feel like the job of SocketAddress should be to create the address
structure and not perform any file operation.
ossi added inline comments.
INLINE COMMENTS
> sharefd_p.h:60
> -::strcpy(a.sun_path, finalPath.c_str());
> -::unlink(finalPath.c_str());
> -#endif
you still need to address that *somehow* ;)
> sharefd_p.h:61
> +if (pathSize > 0 && pathSize < sizeof(a.sun_path) - 1) {
>
chinmoyr updated this revision to Diff 26436.
chinmoyr marked 3 inline comments as done.
chinmoyr added a comment.
Added space on correct side of & and on either sides of binary operators.
Used memcpy.
Restored original position of data member.
REPOSITORY
R241 KIO
CHANGES SINCE LAST
ossi added inline comments.
INLINE COMMENTS
> fdreceiver.h:45
> +QString m_path;
> +QSocketNotifier *m_readNotifier;
> };
why are you moving the member?
it doesn't matter in this case, but generally it's better to have the bigger
members first, concentrating in particular on equal
chinmoyr created this revision.
chinmoyr added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
chinmoyr requested review of this revision.
REVISION SUMMARY
This patch changes SocketAddress class to create an address structure for
a pathname socket (on all
rkflx added a comment.
In https://phabricator.kde.org/D8056#200013, @simgunz wrote:
> I cannot push so someone needs to do it for me.
No problem, I can do it for you.
REPOSITORY
R241 KIO
BRANCH
openwithdialog-filter-app-tree
REVISION DETAIL
rkflx added a comment.
@spoorun You make it sound like the sidebar is the only way to access those
folders. That's not true: The file dialog opens in "Home" by default, where you
can directly click on Pictures and the other folders anyway.
Regarding not adapting the file dialog to
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.7/23/
Project:
Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.7
Date of build:
Sat, 03 Feb 2018 13:06:20 +
Build duration:
3 min 45 sec and counting
JUnit
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.9/16/
Project:
Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9
Date of build:
Sat, 03 Feb 2018 13:04:43 +
Build duration:
3 min 23 sec and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.7/22/
Project:
Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.7
Date of build:
Sat, 03 Feb 2018 12:59:07 +
Build duration:
7 min 11 sec and counting
JUnit
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.10/24/
Project:
Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10
Date of build:
Sat, 03 Feb 2018 13:03:07 +
Build duration:
2 min 23 sec and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.9/15/
Project:
Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9
Date of build:
Sat, 03 Feb 2018 12:59:07 +
Build duration:
5 min 31 sec and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.10/23/
Project:
Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10
Date of build:
Sat, 03 Feb 2018 12:59:07 +
Build duration:
3 min 59 sec and counting
JUnit
dfaure added a comment.
Right, the port to QByteArray could be splitted out of this socket security
fix commit.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9966
To: chinmoyr, #frameworks, thiago, dfaure, ossi
Cc: ngraham, fvogt, lbeltrame, dfaure,
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:32b3bbcd16fd: Use the KFileItemListProperties copy
constructor instead of the conversion from… (authored by markg).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
jtamate accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
KFileItemListProperties_stage2
REVISION DETAIL
https://phabricator.kde.org/D10261
To: markg, dfaure, jtamate
Cc: #frameworks, michaelh, ngraham
jtamate accepted this revision.
jtamate added a comment.
Looks good (and symmetric).
Is it difficult to create a new test?
REPOSITORY
R244 KCoreAddons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10257
To: dfaure, mwolff, jtamate, markg
Cc: markg, ngraham,
ossi added a comment.
In https://phabricator.kde.org/D9966#199979, @dfaure wrote:
> Thiago: now it's ready for your review ;)
if he wants to look past the already pointed out non-atomicity. i for one
just refuse to look at this mess any further.
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.7/21/
Project:
Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.7
Date of build:
Sat, 03 Feb 2018 11:22:14 +
Build duration:
20 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/25/
Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.10
Date of build:
Sat, 03 Feb 2018 11:12:59 +
Build duration:
28 min and counting
JUnit
simgunz added a comment.
Good!
I cannot push so someone needs to do it for me.
Soon, I'll have more free time, and I'll try to polish the code (remove fetch
more, use Qt 5.10 recursive filtering).
REPOSITORY
R241 KIO
BRANCH
openwithdialog-filter-app-tree
REVISION DETAIL
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.7/26/
Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.7
Date of build:
Sat, 03 Feb 2018 11:12:59 +
Build duration:
18 min and counting
JUnit Tests
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Thanks, looks ok to me now.
Well, all that code about incremental fetching (canFetchMore/fetchMore) only
to then fetch everything upfront, could be simplified to just create the full
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.10/22/
Project:
Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10
Date of build:
Sat, 03 Feb 2018 11:22:14 +
Build duration:
3 min 8 sec and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.9/14/
Project:
Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9
Date of build:
Sat, 03 Feb 2018 11:22:14 +
Build duration:
2 min 56 sec and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/20/
Project:
Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9
Date of build:
Sat, 03 Feb 2018 11:12:59 +
Build duration:
8 min 34 sec and counting
dfaure added a comment.
Thanks, looks ok to me now.
Thiago: now it's ready for your review ;)
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9966
To: chinmoyr, #frameworks, thiago, dfaure, ossi
Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh
chinmoyr updated this revision to Diff 26421.
chinmoyr added a comment.
1. Used QByteArray in SocketAddress.
2. Rearranged members of FdReceiver.
3. Removed changes not directly related to these fixes.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
chinmoyr reopened this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9966
To: chinmoyr, #frameworks, thiago, dfaure, ossi
Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/89/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
Date of build:
Sat, 03 Feb 2018 10:37:13 +
Build duration:
12 min and counting
JUnit Tests
Name: (root)
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/107/
Project:
Frameworks kio kf5-qt5 SUSEQt5.7
Date of build:
Sat, 03 Feb 2018 10:18:43 +
Build duration:
20 min and counting
JUnit Tests
Name: (root)
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:27aa3764c0bf: Improve error handling in file ioslave
(authored by chinmoyr).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10266?vs=26417=26420
REVISION DETAIL
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/108/
Project:
Frameworks kio kf5-qt5 SUSEQt5.10
Date of build:
Sat, 03 Feb 2018 10:18:43 +
Build duration:
17 min and counting
JUnit Tests
Name: (root)
chinmoyr added a comment.
The unittests pass.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10266
To: chinmoyr, dfaure
Cc: #frameworks, michaelh, ngraham
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/88/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
Date of build:
Sat, 03 Feb 2018 10:18:43 +
Build duration:
9 min 4 sec and counting
JUnit Tests
Name:
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Ah OK so it was dead code. Removing dead code is always good.
The patch looks ok to me now -- assuming the unittests still pass, which you
didn't mention in the testing section of this
fvogt added a comment.
In https://phabricator.kde.org/D9966#199916, @dfaure wrote:
> The early push was so we don't release 5.43 (planned for today) without
this security fix at all, in case of no answer...
Timing is not that important. As long as the other issues mentioned in
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/48/
Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.7
Date of build:
Sat, 03 Feb 2018 10:13:48 +
Build duration:
5 min 44 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/48/
Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.10
Date of build:
Sat, 03 Feb 2018 10:13:48 +
Build duration:
2 min 25 sec and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/46/
Project:
Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9
Date of build:
Sat, 03 Feb 2018 10:13:48 +
Build duration:
2 min 47 sec and counting
JUnit
chinmoyr added a comment.
In https://phabricator.kde.org/D10266#199961, @dfaure wrote:
> socketPath() being passed by argument: true for OPEN indeed, but what about
OPENDIR?
No method in FileProtocol calls execWithElevatedPrivilege with OPENDIR
action. If one does in future then
dfaure added a comment.
socketPath() being passed by argument: true for OPEN indeed, but what about
OPENDIR?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10266
To: chinmoyr, dfaure
Cc: #frameworks, michaelh, ngraham
chinmoyr updated this revision to Diff 26417.
chinmoyr added a comment.
errno -> errcode
KIO::ERR_ACCESS_DENIED -> err
socketPath is passed as an argument in line 106
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10266?vs=26415=26417
BRANCH
master
alexeymin added a comment.
+1 very positive! There should be as many default places as possible,
scrollbars are not awful; at least `Desktop`, `Documents`, `Downloads`,
`Pictures`, `Music` fit perfectly fine. User can easily remove unneeded entries
(it's easier to remove than to add I
dfaure added a comment.
In https://phabricator.kde.org/D10233#199851, @chinmoyr wrote:
> Try copying org.kde.kio.file.conf and .service file to dbus-1 directory. It
worked for me.
Ah, systemd stuff, not dbus stuff (which finds files in my custom prefix).
Thanks, that worked, I
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> file_unix.cpp:122
> if (execAction.status() == KAuth::Action::AuthorizedStatus) {
> -return execWithElevatedPrivilege(action, arg1, arg2, arg3);
dfaure added a comment.
Thiago: thanks for the review. You didn't say anything about the
getsockopt/getpeereid usage so I assume this part looks ok? That's mostly what
I wanted you to look at.
The early push was so we don't release 5.43 (planned for today) without this
security fix at
chinmoyr updated this revision to Diff 26415.
chinmoyr added a comment.
Used KIO error codes for windows
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10266?vs=26412=26415
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10266
AFFECTED FILES
chinmoyr created this revision.
chinmoyr added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
chinmoyr requested review of this revision.
REVISION SUMMARY
When executing an action with elevated privileges file
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Minor: now readName() is called 3 times, I think this should go into a local
variable.
I don't understand why the name can be empty in one of the desktop files,
that seems quite
96 matches
Mail list logo
