D17617: Display error instead of silently failing when asked to create folder that already exists

Codezela added a comment. can we change enter different name to just rename for simplicity REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17617 To: ngraham, #dolphin Cc: Codezela, kde-frameworks-devel, michaelh, ngraham, bruns

D17617: Display error instead of silently failing when asked to create folder that already exists

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17617 To: ngraham, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17617: Display error instead of silently failing when asked to create folder that already exists

ngraham created this revision. ngraham added a reviewer: Dolphin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 400423 FIXED-IN: 5.54 TEST PLAN 1. `mkdir ~/test` 2. In Dolphin, try to

D17596: [KDirOperator] Allow renaming files from the context menu

markuss added a comment. In D17596#377668 , @ngraham wrote: > That's currently an option in Dolphin. Maybe we should just read that setting to see if we should do it here too? Sounds like a good idea. REPOSITORY R241 KIO REVISION

D17595: Upstream Dolphin's file rename dialog

pino added inline comments. INLINE COMMENTS > ngraham wrote in renamefiledialog.h:5 > The KIO repo's COPYING.LIB file says LGPL 2.1. Is that a mismatch? > The KIO repo's COPYING.LIB file says LGPL 2.1. Is that a mismatch? Considering this new code is GPL: yes, it's a mismatch, and it would

D17595: Upstream Dolphin's file rename dialog

ngraham added inline comments. INLINE COMMENTS > dhaumann wrote in renamefiledialog.h:5 > Is the rest of KIO LGPL or GPL? If we have a license mismatch, we'd have to > ask the authors for an OK to relicense. The KIO repo's COPYING.LIB file says LGPL 2.1. Is that a mismatch? REPOSITORY R241

D17596: [KDirOperator] Allow renaming files from the context menu

ngraham added a comment. That's currently an option in Dolphin. Maybe we should just read that setting to see if we should do it here too? Either way I'd prefer to do that in a separate patch. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17596 To: ngraham,

D17596: [KDirOperator] Allow renaming files from the context menu

emateli added a comment. IMO it would be great if this would just rename inline rather than opening a dialog. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17596 To: ngraham, #frameworks, #dolphin Cc: emateli, elvisangelaccio, markuss, dhaumann, kde-frameworks-devel,

D17609: KTextEditor: Add action for static word wrap

abetts added a comment. +1 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17609 To: loh.tar, #ktexteditor, #vdg Cc: abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D17609: KTextEditor: Add action for static word wrap

loh.tar created this revision. loh.tar added reviewers: KTextEditor, VDG. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY - Move "Show Static Word Wrap Marker" code some lines up

D17609: KTextEditor: Add action for static word wrap

loh.tar added a comment. - Not well tested - Slot code may not fit coding style but looks not bad to me - No Ampersand & short cut set as done by other actions REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17609 To: loh.tar, #ktexteditor, #vdg Cc:

D17596: [KDirOperator] Allow renaming files from the context menu

elvisangelaccio added inline comments. INLINE COMMENTS > dhaumann wrote in kdiroperator.cpp:907-909 > Does dialog->open() block? If so, do we have to new the dialog at all? (Only > reason I can think of is some DBus crash, see >

D17596: [KDirOperator] Allow renaming files from the context menu

dhaumann added inline comments. INLINE COMMENTS > elvisangelaccio wrote in kdiroperator.cpp:907-909 > I think we should just use `dialog->open()` here. I see you've copied these 3 > lines from Dolphin, but we should also fix it there (the rename dialog should > really be modal). Does

D17596: [KDirOperator] Allow renaming files from the context menu

ngraham added a comment. In D17596#377423 , @markuss wrote: > Before the feature was removed, the window had all file operations, incl. move to trash and IIRC even the ability to cut/copy/paste and move (via D'n'D) files. Move to Trash

D17596: [KDirOperator] Allow renaming files from the context menu

ngraham updated this revision to Diff 47624. ngraham marked 2 inline comments as done. ngraham added a comment. Address review comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17596?vs=47607=47624 BRANCH arcpatch-D17596 REVISION DETAIL

D17596: [KDirOperator] Allow renaming files from the context menu

elvisangelaccio added inline comments. INLINE COMMENTS > kdiroperator.cpp:907-909 > +dialog->show(); > +dialog->raise(); > +dialog->activateWindow(); I think we should just use `dialog->open()` here. I see you've copied these 3 lines from Dolphin, but we should also fix it there

D10446: Add KLanguageName

sitter added a comment. In D10446#377355 , @aacid wrote: > But you end up repeating that in lots of places (which we should there's lots of places that suffer from trying to guess a language name at this point, and all of them went the bad way

D10446: Add KLanguageName

sitter updated this revision to Diff 47623. sitter added a subscriber: hein. sitter added a comment. iterating the diff a bit as mentioned in a comment. - new unit test which covers all likely scenarios (I think). this uses fixtures and doesn't require anything to be installed etc. -

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

elvisangelaccio added a comment. In D10742#377356 , @jtamate wrote: > Let's see if this assert/crash can be avoided without reverting all the patch. Any help is welcome. Does this valgrind log help? Invalid read of size 8

D17596: [KDirOperator] Allow renaming files from the context menu

markuss added a comment. Before the feature was removed, the window had all file operations, incl. move to trash and IIRC even the ability to cut/copy/paste and move (via D'n'D) files. What's that "ShowDeleteCommand", false? Can it be true and file deletion will be possible again as

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

jtamate added a comment. I'm able to reproduce the bug with the following steps: - Create a folder structure X/X1/X2/X3/X4 and add a new empty text file into each folder. - Within Dolphin, open a tab for each folder. - In the tab showing X contents, rename X1 to X1_ and the crash is

Google Summer of Code Ideas

Hi folks, a few teams have added their ideas to https://community.kde.org/GSoC/2019/Ideas but many have not yet done so. Those of you reading this plea have participated in the past but do not have ideas posted yet. PLEASE get this done before the end of the year! We need to submit our

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

jtamate added a comment. I've been able to reproduce the bug: #10 0x7f44d257ae1d in qt_assert (assertion=assertion@entry=0x7f44d456fc43 "it != dirItem->lstItems.end()", file=file@entry=0x7f44d456fc10 "/g/5kde/frameworks/kio/src/core/kcoredirlister_p.h", line=line@entry=308) at

D10446: Add KLanguageName

aacid added a comment. In D10446#376825 , @sitter wrote: > Stacking the functions seems to work fine > > QString KLanguageName::nameForCode(const QString ) > { > const QStringList parts = QLocale().name().split(QChar('_')); >

D17595: Upstream Dolphin's file rename dialog

dhaumann added inline comments. INLINE COMMENTS > renamefiledialog.h:5 > + * This program is free software; you can redistribute it and/or modify * > + * it under the terms of the GNU General Public License as published by * > + * the Free Software Foundation; either version 2 of the

D17595: Upstream Dolphin's file rename dialog

pino added inline comments. INLINE COMMENTS > renamefiledialog.cpp:50-51 > +{ > +const QSize minSize = minimumSize(); > +setMinimumSize(QSize(320, minSize.height())); > + why a minimum size is enforced? > renamefiledialog.cpp:54 > +const int itemCount = items.count(); > +