D21661: add snoretoast backend for KNotifications on Windows

pino added a comment. In D21661#476607 , @sredman wrote: > In D21661#476571 , @pino wrote: > > > It seems the snoretoast library provides a `SnoreToasts` class to do this instead of spawning an

D21661: add snoretoast backend for KNotifications on Windows

vonreth added inline comments. INLINE COMMENTS > notifybysnore.cpp:23 > + > +#include > + Is anything from Windows needed? The header is huge. > vonreth wrote in notifybysnore.cpp:180 > Use proc->deleteLater() which will call the destructor >

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 59574. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=59573=59574 BRANCH win32 (branched from master) REVISION DETAIL https://phabricator.kde.org/D21661 AFFECTED FILES src/CMakeLists.txt

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 59573. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=59572=59573 BRANCH win32 (branched from master) REVISION DETAIL https://phabricator.kde.org/D21661 AFFECTED FILES src/CMakeLists.txt

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 added a comment. Oh! Apologies, Pino. Actually I accidentally referred to you as toscanos from IRC, so I deleted that comment. I'll avoid deleting them from now on. INLINE COMMENTS > pino wrote in notifybysnore.cpp:38 > `QCoreApplication` is enough (see below) Actually, I also

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 59572. brute4s99 added a comment. updated acc to new reviews by Pino and Hannah REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=59425=59572 BRANCH win32 (branched from master) REVISION DETAIL

D20169: Add profile support interface for TerminalInterface

This revision was automatically updated to reflect the committed changes. Closed by commit R306:11547a552d6b: Add profile support interface for TerminalInterface (authored by mschiller, committed by hindenburg). REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE

D20169: Add profile support interface for TerminalInterface

hindenburg accepted this revision. This revision is now accepted and ready to land. REPOSITORY R306 KParts BRANCH terminal-interface-profiles (branched from master) REVISION DETAIL https://phabricator.kde.org/D20169 To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein Cc:

D20169: Add profile support interface for TerminalInterface

hindenburg edited the summary of this revision. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D20169 To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein Cc: dhaumann, pino, LeGast00n, michaelh, ngraham, bruns

D21706: [ModifiedFileIndexer] Use correct mimetype for folders, delay until needed

bruns marked an inline comment as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21706 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 110 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/110/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 10 Jun 2019 23:25:32 + Build duration: 11 min and counting JUnit Tests Name:

D21706: [ModifiedFileIndexer] Use correct mimetype for folders, delay until needed

bruns updated this revision to Diff 59564. bruns marked an inline comment as done. bruns added a comment. update comment REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21706?vs=59470=59564 REVISION DETAIL https://phabricator.kde.org/D21706 AFFECTED FILES

D21731: [NewFileIndexer] Omit symlinks from the index

This revision was automatically updated to reflect the committed changes. Closed by commit R293:7b93ced321fc: [NewFileIndexer] Omit symlinks from the index (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21731?vs=59546=59563 REVISION DETAIL

D21519: Rename ImageMake and ImageModel properties

ngraham added a comment. All right, let's just go with "Manufacturer" and "Model" then. The values for these keys will probably make it clear enough. REPOSITORY R286 KFileMetaData BRANCH euqipment_properties REVISION DETAIL https://phabricator.kde.org/D21519 To: astippich, ngraham,

D21731: [NewFileIndexer] Omit symlinks from the index

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH cleanup REVISION DETAIL https://phabricator.kde.org/D21731 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh,

D20967: [UserMetaData] Add method to query which attributes are set

astippich accepted this revision. astippich added a comment. This revision is now accepted and ready to land. for the linux part REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D20967 To: bruns, #baloo, #frameworks, astippich, ngraham Cc:

D21706: [ModifiedFileIndexer] Use correct mimetype for folders, delay until needed

astippich added inline comments. INLINE COMMENTS > modifiedfileindexer.cpp:82 > +if (fileInfo.isDir()) { > +// The folder ctime changes when the file is created, when the > folder is > +// renamed, or when the xattrs (tags, comments, ...) change "when the folder

D21613: Format focal length as milli meter

astippich marked an inline comment as done. REPOSITORY R286 KFileMetaData BRANCH focal_length REVISION DETAIL https://phabricator.kde.org/D21613 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D21004: [UserMetaData] Shortcut attribute queries for the common case

astippich added a comment. This needs a frameworks version bump REPOSITORY R824 Baloo Widgets BRANCH bulk_query REVISION DETAIL https://phabricator.kde.org/D21004 To: bruns, #baloo, #frameworks, ngraham, astippich, lbeltrame Cc: domson, ashaposhnikov, astippich, spoorun, abrahams

D21519: Rename ImageMake and ImageModel properties

astippich added a comment. In D21519#475829 , @bruns wrote: > In D21519#475821 , @ngraham wrote: > > > "Camera Manufacturer"? > > > Well, no ... also "Scanner, Phone, video digitizer, ..." >

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 102 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/102/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 10 Jun 2019 20:45:17 + Build duration: 4 min 11 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 96 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/96/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 10 Jun 2019 20:45:17 + Build duration: 4 min 7 sec and counting BUILD ARTIFACTS

D21613: Format focal length as milli meter

astippich updated this revision to Diff 59560. astippich added a comment. - test decimal value REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21613?vs=59223=59560 BRANCH focal_length REVISION DETAIL https://phabricator.kde.org/D21613 AFFECTED

D21533: Format photo exposure time as rational when applicable

This revision was automatically updated to reflect the committed changes. Closed by commit R286:2dc250bc9239: Format photo exposure time as rational when applicable (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D21695: Add FindTaglib.cmake

elvisangelaccio added a comment. Where does this FindTaglib.cmake come from? We should probably use the one from kio-extras, which got a bunch of fixes in the last months. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21695 To: heikobecker,

D21695: Add FindTaglib.cmake

elvisangelaccio added a comment. In D21695#476826 , @heikobecker wrote: > I'm not entirely sure about taglib-config on Windows See

D20958: New menu of syntax highlighting in the status bar

cullmann added a comment. Coding style wise, could one change: 1. this->XXX() => XXX() 2. void functions should not have "return;" at the end, we don't do that REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20958 To: nibags, #ktexteditor, #kate, #vdg,

D21660: change audio dep logic wrt win32

brute4s99 retitled this revision from "simplify conditions and remove audio dependency for win32" to "change audio dep logic wrt win32". REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik Cc: apol, nicolasfella, kde-frameworks-devel,

D21660: simplify conditions and remove audio dependency for win32

brute4s99 updated this revision to Diff 59551. brute4s99 added a comment. fixed indentation REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21660?vs=59376=59551 BRANCH simplify (branched from master) REVISION DETAIL

D17241: WIP:Disable highlighting after 512 characters on a line.

cullmann updated this revision to Diff 59550. cullmann added a comment. Remove a MASS of heap allocations. We allocated the range on the heap and then inside we really even allocated all 16 byte KTextEditor::Range objects again on the heap. REPOSITORY R39 KTextEditor CHANGES SINCE LAST

D17241: WIP:Disable highlighting after 512 characters on a line.

cullmann edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17241 To: cullmann, vkrause, dhaumann, mwolff, sars Cc: zetazeta, mwolff, brauch, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking,

D17241: WIP:Disable highlighting after 512 characters on a line.

cullmann marked an inline comment as done. cullmann added a comment. Here is my try on this. Instead of limiting the line length, we just limit the number of attributes we are allowed to display. That only hits stuff != selection. e.g. for the example out of

D17241: WIP:Disable highlighting after 512 characters on a line.

cullmann updated this revision to Diff 59548. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17241?vs=48461=59548 REVISION DETAIL https://phabricator.kde.org/D17241 AFFECTED FILES src/render/katerenderer.cpp To: cullmann, vkrause, dhaumann, mwolff,

D17241: WIP:Disable highlighting after 512 characters on a line.

cullmann commandeered this revision. cullmann edited reviewers, added: sars; removed: cullmann. cullmann added a comment. I have drafted a small limit to attributes like I proposed. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17241 To: cullmann, vkrause,

D21731: [NewFileIndexer] Omit symlinks from the index

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REPOSITORY R293 Baloo BRANCH cleanup REVISION DETAIL

D21708: [ModifiedFileIndexer] Avoid shadowing XAttr changes by content changes

This revision was automatically updated to reflect the committed changes. Closed by commit R293:00c75845ba43: [ModifiedFileIndexer] Avoid shadowing XAttr changes by content changes (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D21705: [NewFileIndexer] Use correct mimetype for folders, check excludeFolders

This revision was automatically updated to reflect the committed changes. Closed by commit R293:287d88c8becf: [NewFileIndexer] Use correct mimetype for folders, check excludeFolders (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D21680: [UnindexedFileIndexer] Pick up comment, tags and rating changes

This revision was automatically updated to reflect the committed changes. Closed by commit R293:0760b1261237: [UnindexedFileIndexer] Pick up comment, tags and rating changes (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D21577: [UnindexedFileIndexer] Skip filetime checks for new files

This revision was automatically updated to reflect the committed changes. Closed by commit R293:ecc28c314e1a: [UnindexedFileIndexer] Skip filetime checks for new files (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21577?vs=59147=59541

D21694: [DocumentUrlDB] Avoid manipulation of the whole tree on trivial rename

This revision was automatically updated to reflect the committed changes. Closed by commit R293:7edec3499cbc: [DocumentUrlDB] Avoid manipulation of the whole tree on trivial rename (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D21693: [DocumentUrlDB] Catch invalid URLs early

This revision was automatically updated to reflect the committed changes. Closed by commit R293:8e7b54c54764: [DocumentUrlDB] Catch invalid URLs early (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21693?vs=59451=59539 REVISION DETAIL

D21692: [DocumentUrlDB] Remove unused 'rename' method

This revision was automatically updated to reflect the committed changes. Closed by commit R293:4883ac516d5f: [DocumentUrlDB] Remove unused rename method (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21692?vs=59448=59538 REVISION DETAIL

D21674: [balooctl] Streamline indexer control commands

This revision was automatically updated to reflect the committed changes. Closed by commit R293:b54f8ec94ac2: [balooctl] Streamline indexer control commands (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21674?vs=59411=59537 REVISION

D21708: [ModifiedFileIndexer] Avoid shadowing XAttr changes by content changes

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Very nice! REPOSITORY R293 Baloo BRANCH fix_races REVISION DETAIL https://phabricator.kde.org/D21708 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel,

D21709: [PendingFileQueue] Avoid delete + create / create + delete race

ngraham added a comment. LGTM, but maybe an autotest might make sense for this case. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21709 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, astippich,

D21680: [UnindexedFileIndexer] Pick up comment, tags and rating changes

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit_unindexed REVISION DETAIL https://phabricator.kde.org/D21680 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov,

D21577: [UnindexedFileIndexer] Skip filetime checks for new files

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D21577 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh,

D21674: [balooctl] Streamline indexer control commands

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +100, this is super duper better now. REPOSITORY R293 Baloo BRANCH balooctl_start_stop REVISION DETAIL https://phabricator.kde.org/D21674 To: bruns, #baloo, ngraham, astippich,

D21694: [DocumentUrlDB] Avoid manipulation of the whole tree on trivial rename

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH documenturldb REVISION DETAIL https://phabricator.kde.org/D21694 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov,

D21692: [DocumentUrlDB] Remove unused 'rename' method

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. bye bye REPOSITORY R293 Baloo BRANCH documenturldb REVISION DETAIL https://phabricator.kde.org/D21692 To: bruns, #baloo, ngraham, astippich, poboiko Cc: shubham,

D21693: [DocumentUrlDB] Catch invalid URLs early

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yikes. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21693 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson,

D21706: [ModifiedFileIndexer] Use correct mimetype for folders, delay until needed

bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > poboiko wrote in modifiedfileindexer.cpp:68 > Does it also changes behavior of ModifiedFileIndexer? What happened to > symlinks before? It depends on the state of the PendingFileQueue: - when an item is not

D21671: [FileIndexScheduler] Stop the indexer when quit() is called via DBus

ngraham added a comment. That's probably fine! REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21671 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21671: [FileIndexScheduler] Stop the indexer when quit() is called via DBus

bruns added a comment. Yes, mostly - the "after the current batch" caveat applies, so there may be still some delay. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21671 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson,

D21671: [FileIndexScheduler] Stop the indexer when quit() is called via DBus

ngraham added a comment. Does this fix https://bugs.kde.org/show_bug.cgi?id=353559? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21671 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, astippich,

D21703: [Transaction] Replace template for functor with std::function

This revision was automatically updated to reflect the committed changes. Closed by commit R293:5b6fd8fe88b7: [Transaction] Replace template for functor with std::function (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21703?vs=59467=59512

D21002: Remove kde4 migration agent completely

ngraham added a comment. Yeah, seems like the existing migration is just broken, so we might as well remove it. :/ REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D21002 To: bruns, #frameworks, cfeck, ngraham Cc: aacid, lbeltrame, kde-frameworks-devel, damjang,

D21703: [Transaction] Replace template for functor with std::function

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yep, seems sensible. REPOSITORY R293 Baloo BRANCH cleanup REVISION DETAIL https://phabricator.kde.org/D21703 To: bruns, #baloo, ngraham, astippich, poboiko Cc:

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

ngraham added a comment. How does one test this? Does it replace the existing one? REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21721 To: leinir Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21703: [Transaction] Replace template for functor with std::function

bruns added a comment. In D21703#477158 , @poboiko wrote: > I thought about it myself. I googled it a bit (i.e. here ) and saw that there might be some quite unwanted runtime

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21721 To: leinir Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY Basic KNewStuffQuick dialog for testing purposes Actually return the number of comments, not the rating Change

D20967: [UserMetaData] Add method to query which attributes are set

bruns marked 6 inline comments as done. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20967 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: arrowd, #freebsd, #windows, kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun,

D20967: [UserMetaData] Add method to query which attributes are set

bruns updated this revision to Diff 59509. bruns added a comment. initialize pos REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20967?vs=59505=59509 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20967 AFFECTED FILES

D21704: [FirstRunIndexer] Use correct mimetype for folders

This revision was automatically updated to reflect the committed changes. Closed by commit R293:cb5621bb0dd7: [FirstRunIndexer] Use correct mimetype for folders (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21704?vs=59468=59508 REVISION

D21660: simplify conditions and remove audio dependency for win32

apol added a comment. I'd say you're not simplifying it, you're changing the logic. This needs to be reflected in the commit message. INLINE COMMENTS > CMakeLists.txt:93 > endif() > endif() > +endif() indentation is wrong. REPOSITORY R289 KNotifications REVISION DETAIL

D21698: Move invariant IndexingLevel out of the loop

This revision was automatically updated to reflect the committed changes. Closed by commit R293:b41afe1dc243: Move invariant IndexingLevel out of the loop (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21698?vs=59455=59507 REVISION DETAIL

D21618: Allow QtQuick applets and wallpapers to defer UiReadyConstraint

apol added a comment. I wonder if that's the right API to use from QML, I guess it's fine but marking something as successful by assigning null could feel odd? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21618 To: davidedmundson, #plasma Cc:

D20967: [UserMetaData] Add method to query which attributes are set

arrowd added a comment. Now the test passes! INLINE COMMENTS > xattr_p.h:194 > +{ > +int pos; > +QList entries; variable 'pos' is uninitialized REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20967 To: bruns, #baloo, #frameworks, astippich, ngraham

D21618: Allow QtQuick applets and wallpapers to defer UiReadyConstraint

apol added a dependent revision: D21619: Wallpaper: delay calling UIReady until the image is actually loaded. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21618 To: davidedmundson, #plasma Cc: apol, kde-frameworks-devel, LeGast00n, michaelh,

D21618: Allow QtQuick applets and wallpapers to defer UiReadyConstraint

apol added a comment. +1 LGTM REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21618 To: davidedmundson, #plasma Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21697: [BasicIndexingJob] Skip lookup of baloo document type for directories

This revision was automatically updated to reflect the committed changes. Closed by commit R293:9283a7e06cae: [BasicIndexingJob] Skip lookup of baloo document type for directories (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D20967: [UserMetaData] Add method to query which attributes are set

bruns updated this revision to Diff 59505. bruns added a comment. add and use split helper for BSD REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20967?vs=59502=59505 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20967 AFFECTED

D21695: Add FindTaglib.cmake

cgiboudeaux added a comment. attic/modules/FindTaglib.cmake shall be deleted. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21695 To: heikobecker, kde-buildsystem, kde-frameworks-devel, dfaure Cc: cgiboudeaux, dfaure, LeGast00n, bencreasy, michaelh,

D21695: Add FindTaglib.cmake

cgiboudeaux added inline comments. INLINE COMMENTS > FindTaglib.cmake:19 > +# > +# If ``Taglib_Found is TRUE, it will also define the following imported > +# target: If ``Taglib_FOUND`` ... > FindTaglib.cmake:22 > +# > +# ``Taglib::Talib`` > +# The Taglib library Typo REPOSITORY R240

D20967: [UserMetaData] Add method to query which attributes are set

bruns added a comment. In D20967#477318 , @arrowd wrote: > PASS : UserMetaDataWriterTest::initTestCase() > QDEBUG : UserMetaDataWriterTest::test() extattr_list size: 14 > QDEBUG : UserMetaDataWriterTest::test() extattr_list size: 14

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 95 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/95/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 10 Jun 2019 11:27:03 + Build duration: 2 min 37 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 101 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/101/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 10 Jun 2019 11:27:03 + Build duration: 2 min 32 sec and counting BUILD ARTIFACTS

D21720: Enable usermetadatawritertest for all UNIXes, not only Linux.

This revision was automatically updated to reflect the committed changes. Closed by commit R286:346918916474: Enable usermetadatawritertest for all UNIXes, not only Linux. (authored by arrowd). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D21720: Enable usermetadatawritertest for all UNIXes, not only Linux.

bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. Also matches Linux REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D21720 To: arrowd, #frameworks, bruns Cc: kde-frameworks-devel, #baloo,

D21720: Enable usermetadatawritertest for all UNIXes, not only Linux.

arrowd created this revision. arrowd added reviewers: Frameworks, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. arrowd requested review of this revision. TEST PLAN The test passes on FreeBSD. REPOSITORY R286 KFileMetaData BRANCH

D20967: [UserMetaData] Add method to query which attributes are set

arrowd added a comment. In D20967#477314 , @bruns wrote: > Apparently, the usermetadatawritertest was not executed on *BSD before, can you check if the test succeeds on the old code? Yep, it works on master. The output with

D20967: [UserMetaData] Add method to query which attributes are set

bruns added inline comments. INLINE COMMENTS > xattr_p.h:206 > +#endif > + > +if (size == 0) { @arrowd - please add a `qDebug() << "extattr_list size:" << size;` here > xattr_p.h:232 > +const ssize_t r = extattr_list_file(encodedPath, > EXTATTR_NAMESPACE_USER, data.data(),

D20967: [UserMetaData] Add method to query which attributes are set

bruns added a comment. Apparently, the usermetadatawritertest was not executed on *BSD before, can you check if the test succeeds on the old code? Please submit a PR with the Linux -> UNIX change, and make this one a dependency of it. REPOSITORY R286 KFileMetaData REVISION DETAIL

D21695: Add FindTaglib.cmake

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Certainly a good idea to have this in ECM, so that this mess can be sorted out once and for all... INLINE COMMENTS > FindTaglib.cmake:56 > +# The minimum version of Taglib we

D20967: [UserMetaData] Add method to query which attributes are set

arrowd added a comment. It compiles now, but the test fails: * Start testing of UserMetaDataWriterTest * Config: Using QtTest library 5.12.2, Qt 5.12.2 (x86_64-little_endian-lp64 shared (dynamic) release build; by Clang 8.0.0 (tags/RELEASE_800/final 356365))

D20967: [UserMetaData] Add method to query which attributes are set

bruns updated this revision to Diff 59502. bruns added a comment. update since REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20967?vs=59500=59502 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20967 AFFECTED FILES

D20967: [UserMetaData] Add method to query which attributes are set

bruns marked 2 inline comments as done. bruns added inline comments. INLINE COMMENTS > arrowd wrote in xattr_p.h:231 > Ditto. > > Also, `size` should be `r`, probably, see below. Why ditto? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20967 To: bruns,

D20967: [UserMetaData] Add method to query which attributes are set

bruns updated this revision to Diff 59500. bruns added a comment. fix BSD code REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20967?vs=57390=59500 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20967 AFFECTED FILES

D21002: Remove kde4 migration agent completely

aacid added a comment. I'm pretty sure there's people there still using KDE4 (real life scenario: my father) (almost real life scenario: i know the Limux people were planning a migration from kde4 to Plasma 5, not sure if it already happened or not though). Eventually he'll move to a

D21673: [FileIndexScheduler] Ensure indexer is not run in suspended state

This revision was automatically updated to reflect the committed changes. Closed by commit R293:dfefd66e6e75: [FileIndexScheduler] Ensure indexer is not run in suspended state (authored by bruns). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21673?vs=59410=59499#toc REPOSITORY R293

D21672: [PowerStateMonitor] Be conservative when determining power state

This revision was automatically updated to reflect the committed changes. Closed by commit R293:0e6f1c923782: [PowerStateMonitor] Be conservative when determining power state (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D21671: [FileIndexScheduler] Stop the indexer when quit() is called via DBus

This revision was automatically updated to reflect the committed changes. Closed by commit R293:d74d1cbb65db: [FileIndexScheduler] Stop the indexer when quit() is called via DBus (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D21673: [FileIndexScheduler] Ensure indexer is not run in suspended state

poboiko accepted this revision. poboiko added a comment. This revision is now accepted and ready to land. Apart from small nitpick, I think it's fine. INLINE COMMENTS > fileindexscheduler.h:131 > bool m_isGoingIdle; > +bool m_isSuspended = false; > }; I think it's inconvenient to

D21711: Julia: update syntax and add constants keywords

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Nice, thanks. REPOSITORY R216 Syntax Highlighting BRANCH update-julia REVISION DETAIL https://phabricator.kde.org/D21711 To: nibags, #framework_syntax_highlighting, dhaumann,

D21713: Fortran: implement free & fixed formats

cullmann added a comment. Nice that you take care to integrate that. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21713 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh,

D21705: [NewFileIndexer] Use correct mimetype for folders, check excludeFolders

poboiko accepted this revision. poboiko added a comment. This revision is now accepted and ready to land. Can we also cover this case with tests? REPOSITORY R293 Baloo BRANCH cleanup REVISION DETAIL https://phabricator.kde.org/D21705 To: bruns, #baloo, ngraham, astippich, poboiko Cc:

D21671: [FileIndexScheduler] Stop the indexer when quit() is called via DBus

poboiko accepted this revision. poboiko added a comment. This revision is now accepted and ready to land. That's a nice catch! REPOSITORY R293 Baloo BRANCH scheduler REVISION DETAIL https://phabricator.kde.org/D21671 To: bruns, #baloo, ngraham, astippich, poboiko Cc:

D21697: [BasicIndexingJob] Skip lookup of baloo document type for directories

poboiko accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH basicindexingjob REVISION DETAIL https://phabricator.kde.org/D21697 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov,

D21704: [FirstRunIndexer] Use correct mimetype for folders

poboiko accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH cleanup REVISION DETAIL https://phabricator.kde.org/D21704 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh,

  1   2   >