D23019: Make notification icons look like bells

ndavis added a dependency: D23018: [notifications] Remove unread counter, use icons instead. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23019 To: ndavis, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23019: Make notification icons look like bells

ndavis removed a dependent revision: D23018: [notifications] Remove unread counter, use icons instead. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23019 To: ndavis, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23019: Make notification icons look like bells

ndavis created this revision. ndavis added reviewers: VDG, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH notification-icons (branched from master)

D23019: Make notification icons look like bells

ndavis added a dependent revision: D23018: [notifications] Remove unread counter, use icons instead. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23019 To: ndavis, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22979: Security: remove support for $(...) in config keys with [$e] marker.

fvogt added a comment. In D22979#508493 , @kives wrote: > Does anyone think this can be easily backported to previous versions of KDE in upstream distros such as Kubuntu, etc.? I backported this down to KConfig 5.20 and KDELibs 4.14.18,

D23008: [baloo_file_extractor] Be more resistant to multiple QSocketNotifier events

anthonyfieroni added inline comments. INLINE COMMENTS > app.cpp:76-81 > +if (m_tr) { > +// Parent proccess yielded us a new batch while previous have not > yet finished > +// This should not happen, but better play safe > +m_tr->commit(); > +delete m_tr; >

D22960: Add handle icons

This revision was automatically updated to reflect the committed changes. Closed by commit R169:29dffaf4cd72: Add handle icons (authored by hein). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22960?vs=63155=63327 REVISION DETAIL

D22979: Security: remove support for $(...) in config keys with [$e] marker.

kives added a comment. Does anyone think this can be easily backported to previous versions of KDE in upstream distros such as Kubuntu, etc.? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D22979 To: dfaure, mdawson, aacid, broulik, davidedmundson, kossebau, apol,

D23008: [baloo_file_extractor] Be more resistant to multiple QSocketNotifier events

bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D23008 To: poboiko, #baloo, bruns, ngraham Cc: broulik, kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, michaelh,

D23008: [baloo_file_extractor] Be more resistant to multiple QSocketNotifier events

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I can't reproduce the issue either, but this doesn't seem to cause any regressions that I can see, and the code makes sense to me. REPOSITORY R293 Baloo BRANCH extractor-transaction

D23015: Highlighting indexer: all warnings are fatal

jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH warning_as_error (branched from master) REVISION DETAIL

D23014: Lua: fix color of end with several levels of condition and function nesting

jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY if x then function foo() if x then end -- control (before:

Re: KCrash crash racing

On Wed, Aug 7, 2019 at 7:17 PM Albert Astals Cid wrote: > > El dimecres, 7 d’agost de 2019, a les 16:36:31 CEST, Harald Sitter va > escriure: > > On Mon, Aug 5, 2019 at 10:58 PM Albert Astals Cid wrote: > > > > I am fairly out of ideas :/ > > > > > > Tried looking at what breakpad does? > > > >

D23013: Latex: several fixes (math mode, nested verbatim, ...)

jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY - nested { and macro identifier with math mode - add shortintertext, Cref, param

D23008: [baloo_file_extractor] Be more resistant to multiple QSocketNotifier events

broulik added inline comments. INLINE COMMENTS > ngraham wrote in app.h:50 > This isn't public to outside users, right? It doens't have an EXPORT macro to it, so I suppose not? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D23008 To: poboiko, #baloo, bruns, ngraham

D22979: Security: remove support for $(...) in config keys with [$e] marker.

dfaure added a comment. Yes. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D22979 To: dfaure, mdawson, aacid, broulik, davidedmundson, kossebau, apol, sitter, security-team Cc: ZaWertun, rikmills, fvogt, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23008: [baloo_file_extractor] Be more resistant to multiple QSocketNotifier events

ngraham added inline comments. INLINE COMMENTS > app.h:50 > public: > -explicit App(QObject* parent = nullptr); > This isn't public to outside users, right? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D23008 To: poboiko, #baloo, bruns, ngraham Cc:

D22942: [kded/baloosearchmodule] Remove useless qDebug messages

poboiko closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D22942 To: poboiko, #baloo, bruns, ngraham Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D23008: [baloo_file_extractor] Be more resistant to multiple QSocketNotifier events

poboiko created this revision. poboiko added reviewers: Baloo, bruns, ngraham. Herald added projects: Frameworks, Baloo. poboiko requested review of this revision. REVISION SUMMARY When a new batch arrives at stdin (as notified by QSocketNotifier), extractor creates a new transaction. If

Re: KCrash crash racing

El dimecres, 7 d’agost de 2019, a les 16:36:31 CEST, Harald Sitter va escriure: > On Mon, Aug 5, 2019 at 10:58 PM Albert Astals Cid wrote: > > > I am fairly out of ideas :/ > > > > Tried looking at what breakpad does? > > Breakpad does mostly what we do, technically, functionally it's not an >

D22979: Security: remove support for $(...) in config keys with [$e] marker.

ngraham added a comment. Is Frameworks 5.61 going to be re-spun to include this? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D22979 To: dfaure, mdawson, aacid, broulik, davidedmundson, kossebau, apol, sitter, security-team Cc: ZaWertun, rikmills, fvogt, ngraham,

Re: KCrash crash racing

On Mon, Aug 5, 2019 at 10:58 PM Albert Astals Cid wrote: > > I am fairly out of ideas :/ > > Tried looking at what breakpad does? Breakpad does mostly what we do, technically, functionally it's not an "interactive" crash report while drkonqi is. Our simplified process: crash -> handler ->

Re: KCrash crash racing

On Mon, Aug 5, 2019 at 4:47 PM Aleix Pol wrote: > My impression is that relying on core handlers makes a lot of sense, > there would be some questions to answer such as "what happens when > running on other systems". Maybe for now we could try doing an > in-between? Handling cores on plasma and

D22979: Security: remove support for $(...) in config keys with [$e] marker.

This revision was automatically updated to reflect the committed changes. Closed by commit R237:5d3e71b1d2ec: Security: remove support for $(...) in config keys with [$e] marker. (authored by dfaure). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/24/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 07 Aug 2019 11:47:07 + Build duration: 1 hr 33 min and counting JUnit Tests Name:

D22979: Security: remove support for $(...) in config keys with [$e] marker.

mdawson accepted this revision. REPOSITORY R237 KConfig BRANCH security_kill_popen REVISION DETAIL https://phabricator.kde.org/D22979 To: dfaure, mdawson, aacid, broulik, davidedmundson, kossebau, apol, sitter, security-team Cc: ZaWertun, rikmills, fvogt, ngraham, kde-frameworks-devel,

D22775: Allow date range filtering of resource events using Date Term

meven added a comment. gentle ping @ivan REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D22775 To: meven, ivan, #frameworks Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22143: Add proper logging using ECMQtDeclareLoggingCategory

meven added a comment. In D22143#502476 , @meven wrote: > In D22143#502336 , @kossebau wrote: > > > In D22143#502314 , @meven wrote: > > > > > >

KDE CI: Frameworks » knotifications » kf5-qt5 SUSEQt5.12 - Build # 49 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20SUSEQt5.12/49/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 07 Aug 2019 07:32:15 + Build duration: 6 min 25 sec and counting BUILD ARTIFACTS

D22979: Security: remove support for $(...) in config keys with [$e] marker.

dfaure updated this revision to Diff 63253. dfaure added a comment. Fix documentation; re-add test for $(hostname) REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22979?vs=63239=63253 BRANCH security_kill_popen REVISION DETAIL

D22979: Security: remove support for $(...) in config keys with [$e] marker.

dfaure marked 2 inline comments as done. dfaure added inline comments. INLINE COMMENTS > mdawson wrote in kconfigtest.cpp:530 > Instead of removing this test, can it instead be switched to verify the > command execution does not occur? Hehe, that's what I did initially, and the value being

D22979: Security: remove support for $(...) in config keys with [$e] marker.

broulik added a comment. +1 I got a valid usecase "Please don't fix this. I use a recursive symlink and a shell script to raise my machine load. The extra heat it produces keeps children warm in the winter." ;) REPOSITORY R237 KConfig BRANCH security_kill_popen REVISION DETAIL

KDE CI: Frameworks » knotifications » kf5-qt5 SUSEQt5.12 - Build # 48 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20SUSEQt5.12/48/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 07 Aug 2019 06:58:22 + Build duration: 2 min 50 sec and counting CONSOLE OUTPUT