D17816: Support for xattrs on kio copy/move

tmarshall marked 4 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: tmarshall, dfaure, chinmoyr, bruns, #frameworks, cochise Cc: tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham,

D17816: Support for xattrs on kio copy/move

tmarshall updated this revision to Diff 72131. tmarshall added a comment. - Addressed comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=49487=72131 BRANCH arcpatch-D17816 REVISION DETAIL https://phabricator.kde.org/D17816 AFFECTED FILES

D17816: Support for xattrs on kio copy/move

tmarshall marked 7 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: tmarshall, dfaure, chinmoyr, bruns, #frameworks, cochise Cc: tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham,

D17816: Support for xattrs on kio copy/move

tmarshall marked 6 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: tmarshall, dfaure, chinmoyr, bruns, #frameworks, cochise Cc: tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham,

D17816: Support for xattrs on kio copy/move

tmarshall marked 9 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: tmarshall, dfaure, chinmoyr, bruns, #frameworks, cochise Cc: tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham,

D17816: Support for xattrs on kio copy/move

tmarshall commandeered this revision. tmarshall added a reviewer: cochise. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: tmarshall, dfaure, chinmoyr, bruns, #frameworks, cochise Cc: tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino,

D26202: WIP: Refactor KConfigXT

ngraham added a comment. > This is really a wip, completely broken. It's just so people can point me to the right direction. Maybe could you clarify which direction you want to be pointed in? What's the goal here? What do you need help with? REPOSITORY R237 KConfig REVISION DETAIL

Re: D26127: Simplify cppType method: Return Early, Use a Map and Assert.

doing that as we speak. On Mon, Dec 23, 2019 at 9:52 PM Kevin Ottens wrote: > ervin added a comment. View Revision > > In D26127#582398 , @tcanabrava > wrote: > > In

D26202: WIP: Refactor KConfigXT

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. REVISION SUMMARY This is really a wip, completely broken. It's just so people can point me to the right direction. Rework

D26130: Simplify return logic

ervin added a comment. In D26130#582465 , @patrickelectric wrote: > In D26130#582447 , @ervin wrote: > > > In D26130#582391 , @tcanabrava wrote: > > >

D26198: Deprecate KCModuleContainer

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Part of T12153 . There

D26130: Simplify return logic

patrickelectric added a comment. In D26130#582447 , @ervin wrote: > In D26130#582391 , @tcanabrava wrote: > > > In D26130#582343 , @ervin wrote: > > >

D26127: Simplify cppType method: Return Early, Use a Map and Assert.

ervin added a comment. In D26127#582398 , @tcanabrava wrote: > In D26127#582296 , @ervin wrote: > > > Those data structure look really similar to the ones you introduced in param() for D26126

D26197: Display fully qualified class/namespace name as page header

davidre edited the summary of this revision. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D26197 To: davidre Cc: jucato, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D26197: Display fully qualified class/namespace name as page header

davidre edited the test plan for this revision. davidre added a subscriber: jucato. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D26197 To: davidre Cc: jucato, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns,

D26197: Display fully qualified class/namespace name as page header

davidre edited the test plan for this revision. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D26197 To: davidre Cc: jucato, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D26128: Simplify defaultValue method: Return Early, Use Default Initialization, and Assert.

ervin added inline comments. INLINE COMMENTS > tcanabrava wrote in kconfig_compiler.cpp:1122 > .contains adds way more readability than > std::find_if(std::begin(temporaryStringVector), > std::end(temporaryStringVector) != std::end(temporaryStringVector), so I > opted for this. You know this

D26129: Remove Iterator based loops for range based loops

ervin added a comment. In D26129#582392 , @tcanabrava wrote: > I didn't blindly change anything, everything I did I tested either by running the unittests or recompilling and testing the settings of applications. Sure I know you did

D26197: Display fully qualified class/namespace name as page header

davidre created this revision. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY It's the most important information to see quickly what the page is about. Using the

D26130: Simplify return logic

ervin added a comment. In D26130#582391 , @tcanabrava wrote: > In D26130#582343 , @ervin wrote: > > > This is pointless, most compilers would do NRVO (+ move assign) here... which would be neatly

D17816: Support for xattrs on kio copy/move

ngraham added a comment. It seems like the original author has disappeared, so if you would like to take over this patch, @tmarshall, please feel free. You would click on the "Add Action" combobox above the comment field and select "Commandeer Revision" Then you can check out the branch

D26191: Add support for FileJob->truncate() in smb/sftp slaves

feverfew added inline comments. INLINE COMMENTS > fvogt wrote in kio_sftp.cpp:1492 > AFAICT, this has to be done in every case. I wasn't too sure if `attr` was needed by libssh if the call succeeded. Looking at the source code it seems that you are probably right and can be freed in all

D26148: Add truncation support to FileJob

feverfew added a comment. In D26148#582365 , @apol wrote: > It would be interesting to explain why it's important or how it's to be used in the commit message. Done REPOSITORY R241 KIO REVISION DETAIL

D26148: Add truncation support to FileJob

feverfew edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26148 To: feverfew, fvogt, dfaure, sitter Cc: apol, ngraham, sitter, dfaure, kde-frameworks-devel, fvogt, LeGast00n, GB_2, michaelh, bruns

D26148: Add truncation support to FileJob

feverfew edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26148 To: feverfew, fvogt, dfaure, sitter Cc: apol, ngraham, sitter, dfaure, kde-frameworks-devel, fvogt, LeGast00n, GB_2, michaelh, bruns

D26191: Add support for FileJob->truncate() in smb/sftp slaves

fvogt requested changes to this revision. fvogt added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kio_sftp.cpp:1480 > +if (!attr) { > +sftp_attributes_free(attr); > +int errorCode = toKIOError(sftp_get_error(mSftp)); This entire block is

D26128: Simplify defaultValue method: Return Early, Use Default Initialization, and Assert.

tcanabrava added inline comments. INLINE COMMENTS > apol wrote in kconfig_compiler.cpp:1122 > If instead of creating a QVector you used an initializer list directly, you > could use std::find_if without having to initialize it entirely. Also you'd > be able to use QLatin1String which would

D26194: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72116. ahmadsamir marked an inline comment as done. ahmadsamir added a comment. More const REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26194?vs=72113=72116 BRANCH l-qregularexpression (branched from master)

D26195: Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, apol, dfaure, vkrause. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest; all unit tests pass except for two tests but the fail on master too. REPOSITORY R236

D26127: Simplify cppType method: Return Early, Use a Map and Assert.

tcanabrava added a comment. In D26127#582296 , @ervin wrote: > Those data structure look really similar to the ones you introduced in param() for D26126 . It looks like we'll end up with a Q_GLOBAL_STATIC or

D26128: Simplify defaultValue method: Return Early, Use Default Initialization, and Assert.

tcanabrava added a comment. In D26128#582304 , @ervin wrote: > This also has similarities with D26126 , has the same defects and missed opportunities for sharing. > > Beside I'm not sure what we're trying

D26194: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72113. ahmadsamir added a comment. use const (QRegularExpressionMatch is an object too) REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26194?vs=72112=72113 BRANCH l-qregularexpression (branched from master)

D26129: Remove Iterator based loops for range based loops

tcanabrava added inline comments. INLINE COMMENTS > ervin wrote in kconfig_compiler.cpp:2119 > This logic is very flawed... instead of comparing positions in the list now > you're comparing actual values. If two different positions in the list would > end up having the same values (for some

D26129: Remove Iterator based loops for range based loops

tcanabrava added a comment. In D26129#582336 , @ervin wrote: > The patch being large I didn't check each one separately but I suspect this patch misses boat loads of qAsConst. Yes, it indeed misses, I'll add the qAsConst. ( I would

D26130: Simplify return logic

tcanabrava added a comment. In D26130#582343 , @ervin wrote: > This is pointless, most compilers would do NRVO (+ move assign) here... which would be neatly obliterated by the ternary operator. This is a pessimisation you're proposing here, not

D26194: Port QRegExp to QRegularExpression

apol added a comment. LGTM otherwise INLINE COMMENTS > runnercontext.cpp:575 > for (const QString& entry : cfgList) { > -r.indexIn(entry); > -int count = r.cap(1).toInt(); > -QString id = r.cap(2); > +QRegularExpressionMatch match = re.match(entry); > +

D26133: Enable Auto Save

apol added inline comments. INLINE COMMENTS > test_signal.h.ref:137 > +/** Triggered whenever a setting changes */ > +void configurationChanged(); > + How about having `isSaveNeededChanged(bool)`? It could be in KCoreConfigSkeleton. > kconfig_compiler.cpp:2121 > } > -

D26194: Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, davidedmundson, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY One instance of QString::remove(QRegExp... was replaced to use the replace overload that takes a

D26133: Enable Auto Save

tcanabrava updated this revision to Diff 72110. tcanabrava added a comment. - Use a timer of 1s to trigger the save REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26133?vs=71920=72110 BRANCH enableAutoSave REVISION DETAIL

D26133: Enable Auto Save

tcanabrava updated this revision to Diff 72111. tcanabrava added a comment. - Emit `configurationChanged()` when any configuration changes REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26133?vs=72110=72111 BRANCH enableAutoSave REVISION DETAIL

D26191: Add support for FileJob->truncate() in smb/sftp slaves

feverfew added a dependency: D26148: Add truncation support to FileJob. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26191 To: feverfew, sitter, dfaure, fvogt Cc: kde-frameworks-devel, kfm-devel, ngraham, pberestov, iasensio, fprice, LeGast00n, MrPepe,

D26148: Add truncation support to FileJob

feverfew added a dependent revision: D26191: Add support for FileJob->truncate() in smb/sftp slaves. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26148 To: feverfew, fvogt, dfaure, sitter Cc: apol, ngraham, sitter, dfaure, kde-frameworks-devel, fvogt, LeGast00n, GB_2,

D26148: Add truncation support to FileJob

apol added a comment. It would be interesting to explain why it's important or how it's to be used in the commit message. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26148 To: feverfew, fvogt, dfaure, sitter Cc: apol, ngraham, sitter, dfaure, kde-frameworks-devel,

D26193: KNotifyConfig: port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN the code compiles... no unit tests. REPOSITORY R305 KNotifyConfig BRANCH master REVISION DETAIL

D26131: Braces around for, break early.

ervin added inline comments. INLINE COMMENTS > patrickelectric wrote in kconfig_compiler.cpp:619 > std::any_of ? Indeed, could be replaced by any_of since we're at it. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26131 To: tcanabrava Cc: ervin, patrickelectric,

D26130: Simplify return logic

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. This is pointless, most compilers would do NRVO (+ move assign) here... which would be neatly obliterated by the ternary operator. This is a pessimisation you're proposing here,

D26129: Remove Iterator based loops for range based loops

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. The patch being large I didn't check each one separately but I suspect this patch misses boat loads of qAsConst. Besides there's at least one case of very flawed logic, it can't be

D26191: Add support for FileJob->truncate() in smb/sftp slaves

feverfew updated this revision to Diff 72104. feverfew added a comment. - Free unneeded struct pointer REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26191?vs=72103=72104 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26191 AFFECTED

D26191: Add support for FileJob->truncate() in smb/sftp slaves

feverfew created this revision. feverfew added reviewers: sitter, dfaure, fvogt. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. feverfew requested review of this revision. REVISION SUMMARY This implements the new method added in D26148

D26128: Simplify defaultValue method: Return Early, Use Default Initialization, and Assert.

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. This also has similarities with D26126 , has the same defects and missed opportunities for sharing. Beside I'm not sure what we're trying to

D26127: Simplify cppType method: Return Early, Use a Map and Assert.

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. Those data structure look really similar to the ones you introduced in param() for D26126 . It looks like we'll end up with a Q_GLOBAL_STATIC or

D26126: Simplify param method: Return Early, Use a Map and Assert.

ervin requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26126 To: tcanabrava, ervin Cc: ervin, GB_2, apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D26126: Simplify param method: Return Early, Use a Map and Assert.

ervin added inline comments. INLINE COMMENTS > kconfig_compiler.cpp:1024 > + > +auto valueMap = std::map { > +{QStringLiteral("string"), QStringLiteral("const QString &")}, std::map looks like a bad idea here, either use QHash (preferred in massively based Qt code) or

D26126: Simplify param method: Return Early, Use a Map and Assert.

ervin added a comment. In D26126#581831 , @tcanabrava wrote: > static will add a Mutex in the generated assembly (as static variables in c++ are now thread safe) and I'm not sure this is a good thing for const - reading variables. I'll try

Re: D26126: Simplify param method: Return Early, Use a Map and Assert.

I’m not. I’m concerned that the introduction of thread safety by adding a static member will make the compiler slower. On Mon, 23 Dec 2019 at 15:42 Aleix Pol Gonzalez wrote: > apol added a comment. View Revision > > Why are you concerned about thread safety

D26126: Simplify param method: Return Early, Use a Map and Assert.

tcanabrava added a subscriber: GB_2. tcanabrava added a comment. I’m not. I’m concerned that the introduction of thread safety by adding a static member will make the compiler slower. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26126 To: tcanabrava Cc: GB_2,

D26188: Port to QRandomGenerator

This revision was automatically updated to reflect the committed changes. Closed by commit R159:2edcd2440f5d: Port to QRandomGenerator (authored by mlaurent). REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26188?vs=72077=72094 REVISION DETAIL

D26187: QMultiHash::insertMulti is deprecated

This revision was automatically updated to reflect the committed changes. Closed by commit R307:6b3b4d4aca10: QMultiHash::insertMulti is deprecated (authored by mlaurent). REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26187?vs=72076=72095 REVISION DETAIL

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven planned changes to this revision. meven added a comment. I have tried adding unit tests. It showed that the old: ` *stat(const QUrl , KIO::StatJob::StatSide side, short int details, JobFlags flags = DefaultFlags);` Takes over the new : `KIO::stat(const QUrl &, KIO::StatSide,

D26167: Update holidays and add flagdays and namedays for Sweden

nicolasfella added reviewers: KDE PIM, winterz. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D26167 To: riiga, #kde_pim, winterz Cc: ltoscano, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26117: [solid] Clarify referencing of DeviceInterface

anthonyfieroni added a comment. Ok, is it clear now? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D26117 To: anthonyfieroni, broulik, bruns Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26175: [plasmashell] Update docs for panelTakesFocus to make it generic

romangg accepted this revision. romangg added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > apol wrote in plasmashell_interface.h:178 > How about we rename now and deprecate this one? Yea, could be better. David should decide on what he prefers. But the

D26047: Expose KConfig settings to allow registration in KCM Notification

ervin added inline comments. INLINE COMMENTS > settings.h:343 > > +QList configSkeletons() const; > + Will need API documentation > broulik wrote in settings.h:343 > Not a fan of this becoming public API @broulik I understand you don't like much this becoming exposed as one could abuse

D26136: Port QRegExp to QRegularExpression

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26136 To: ahmadsamir, #frameworks, apol Cc: apol, kde-frameworks-devel, LeGast00n,

D26188: Port to QRandomGenerator

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R159 KActivities Statistics BRANCH port_to_QRandomGenerator (branched from master) REVISION DETAIL https://phabricator.kde.org/D26188 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n,

D26187: QMultiHash::insertMulti is deprecated

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople BRANCH insertmulti_is_deprecated (branched from master) REVISION DETAIL https://phabricator.kde.org/D26187 To: mlaurent, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D26126: Simplify param method: Return Early, Use a Map and Assert.

apol added a comment. Why are you concerned about thread safety in the kconfig compiler? :/ REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26126 To: tcanabrava Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26175: [plasmashell] Update docs for panelTakesFocus to make it generic

apol added inline comments. INLINE COMMENTS > plasmashell_interface.h:178 > **/ > +//TODO KF6 rename to something generic > bool panelTakesFocus() const; How about we rename now and deprecate this one? REPOSITORY R127 KWayland REVISION DETAIL

D26177: Port QRegExp to QRegularExpression

ervin added a comment. Looks good to me. Not putting the accept flag yet to give more times to others to review those critical bits. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26177 To: ahmadsamir, #frameworks, dfaure, ervin, apol Cc: kde-frameworks-devel,

D26122: Add utility text function KShell::tildeCollapse

meven added a comment. In D26122#581717 , @apol wrote: > I might be missing something, explaining why it's necessary would be useful for the commit log as well as for lost reviewers like me. I replaced my first use case by

D26106: Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R269:85774a83b403: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26106?vs=72042=72084 REVISION DETAIL

D26136: Port QRegExp to QRegularExpression

ahmadsamir added a comment. In D26136#582140 , @ahmadsamir wrote: > Verbatim, take 2, with Summary: added manually In D26136#582140 , @ahmadsamir wrote: > Verbatim, take 2, with

D26136: Port QRegExp to QRegularExpression

ahmadsamir edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D26136 To: ahmadsamir, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26136: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72083. ahmadsamir added a comment. Verbatim, take 2, with Summary: added manually REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26136?vs=72081=72083 BRANCH l-qregularexpression (branched from master)

D26136: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72081. ahmadsamir added a comment. Verbatim REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26136?vs=72035=72081 BRANCH l-qregularexpression (branched from master) REVISION DETAIL

D26156: [KDocTools] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. ahmadsamir marked an inline comment as done. Closed by commit R238:36fae9517502: [KDocTools] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE

D26133: Enable Auto Save

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. In D26133#581832 , @tcanabrava wrote: > Because not all apps that use KConfigXT use a KCM, and I don't want to make > it necessary

D26188: Port to QRandomGenerator

mlaurent added a reviewer: dfaure. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D26188 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26122: Add utility text function KShell::tildeCollapse

ervin accepted this revision. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D26122 To: meven, #frameworks, broulik, ngraham, ervin Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26188: Port to QRandomGenerator

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port to QRandomGenerator TEST PLAN autotest ok REPOSITORY R159 KActivities Statistics BRANCH

D26082: Provide a method to query isImmutable attribute of a setting related to notification.

ervin accepted this revision. ervin added a comment. This revision is now accepted and ready to land. Looks good to me, hoping we don't have two items with the same name in different settings objects. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26082

D26187: QMultiHash::insertMulti is deprecated

mlaurent added a reviewer: apol. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D26187 To: mlaurent, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26187: QMultiHash::insertMulti is deprecated

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port to QMultiHash::insert TEST PLAN autotest ok REPOSITORY R307 KPeople BRANCH insertmulti_is_deprecated

D26106: Port QRegExp to QRegularExpression

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R269 BluezQt BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26106 To: ahmadsamir, drosca, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, GB_2,

D26136: Port QRegExp to QRegularExpression

apol added a comment. It didn't update here? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D26136 To: ahmadsamir, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26156: [KDocTools] Port QRegExp to QRegularExpression

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ahmadsamir wrote in docbookl10nhelper.cpp:184 > I did it that way to indicate match is going to be re-assigned-to later on, > but it does look off a bit. :) The way of

D26182: qsrand is deprecated in qt5.15. I don't know why theses lines were still hereas we don't use qrand

This revision was automatically updated to reflect the committed changes. Closed by commit R278:6e9eb11124f5: qsrand is deprecated in qt5.15. I dont know why theses lines were still hereas… (authored by mlaurent). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE

D26085: KCModuleQml: Ensure defaulted is emitted with the current configModule->representsDefaults on load

ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D26085 To: meven, crossi, mart, #frameworks, ervin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > crossi wrote in managedconfigmodule.cpp:43 > Sort of a guard if one registers manually a KCoreConfigSkeleton and then > deallocate it. > It is not intended to

D26171: Implement wp_viewporter

romangg added inline comments. INLINE COMMENTS > davidedmundson wrote in surface_interface.cpp:485 > We're not testing this error in the case of: > > buffer is set > viewporter.sourceRect is set > > then later > buffer changes > viewporter.sourceRect remains the same > > this should be an

D26182: qsrand is deprecated in qt5.15. I don't know why theses lines were still hereas we don't use qrand

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Indeed qrand() usage was removed in commit 49357d093e8280 REPOSITORY R278 KWindowSystem BRANCH

D26184: QHash::unite is deprecated in qt5.15. We need to port to QMultiHash.But QMultiHash::unite was added in qt5.13

mlaurent retitled this revision from "QHash::unite is deprecated in qt5.15. We need to port to QMultiHash. But QMultiHash::unite was added in qt5.13" to "QHash::unite is deprecated in qt5.15. We need to port to QMultiHash.But QMultiHash::unite was added in qt5.13". mlaurent added a reviewer:

D26184: QHash::unite is deprecated in qt5.15. We need to port to QMultiHash.But QMultiHash::unite was added in qt5.13

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port QHash::unite deprecated method TEST PLAN autotest ok REPOSITORY R276 KItemViews BRANCH

D26182: qsrand is deprecated in qt5.15. I don't know why theses lines were still hereas we don't use qrand

mlaurent retitled this revision from "qsrand is deprecated in qt5.15. I don't know why theses lines were still here as we don't use qrand" to "qsrand is deprecated in qt5.15. I don't know why theses lines were still hereas we don't use qrand". mlaurent added a reviewer: dfaure. REPOSITORY

D26182: qsrand is deprecated in qt5.15. I don't know why theses lines were still hereas we don't use qrand

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Remove unused qsrand TEST PLAN autotest ok REPOSITORY R278 KWindowSystem BRANCH remove_unused_qsrand

D26044: Set breeze as default theme when reading from configuration file

ervin accepted this revision. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D26044 To: bport, #plasma, ervin, crossi, ngraham Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D17816: Support for xattrs on kio copy/move

tmarshall added inline comments. INLINE COMMENTS > copyxattrjob.cpp:67 > + * The CopyXattrJob is a very simple job. Reads the list of keys > + * and copies each attribute. As a fast operation, don' need to > + * be able to suspend. "don'" -> "don't" REPOSITORY R241 KIO REVISION DETAIL

D26177: Port QRegExp to QRegularExpression

ahmadsamir requested review of this revision. ahmadsamir added a comment. IINM, fileNameOnly() can be safely deleted; it's only used once on line 2226: fileNameOnly(baseName) and baseName is initialised on line 1630: QString baseName = QFileInfo(codegenFilename).fileName(); so it's

D26177: Port QRegExp to QRegularExpression

ahmadsamir planned changes to this revision. ahmadsamir added a comment. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26177 To: ahmadsamir, #frameworks, dfaure, ervin, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26177: Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, ervin, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Port QRegExp::exactMatch() by using QRegularExpression::anchoredPattern() to match the entire

  1   2   >