D17816: Support for xattrs on kio copy/move

anthonyfieroni added inline comments. INLINE COMMENTS > copyxattrjob.cpp:98-111 > + const int bsrc_fd = open(m_bsrc, 0); > + if (bsrc_fd < 0) > + { > +q->setErrorText(QLatin1String("failed to obtain file descriptor of > source during xattr copy")); > +

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 81 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/81/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 25 Dec 2019 01:52:04 + Build duration: 2 min 28 sec and counting JUnit Tests Name:

D17816: Support for xattrs on kio copy/move

cochise added a comment. Many thanks to getting this live again, @tmarshall . A year ago my vacations ended and I can't get this ready to ship. > Everything works for me if I replace the exec call with a start call. Currently the result of the exec call is thrown away as the job itself

D26191: Add support for FileJob->truncate() in smb/sftp slaves

feverfew marked 3 inline comments as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26191 To: feverfew, sitter, dfaure, fvogt Cc: kde-frameworks-devel, kfm-devel, ngraham, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela,

D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. @dfaure is this good to go now? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fvogt, davidedmundson, dfaure, ngraham Cc: alexde, broulik, sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh,

D17816: Support for xattrs on kio copy/move

tmarshall added inline comments. INLINE COMMENTS > dfaure wrote in copyjob.cpp:1119 > That sounds racy; the subjob might not be finished by the time the main job > is finished, if you just "start and forget". > > I cannot accept this commit with an exec() in here. The easy and modern way > to

D26191: Add support for FileJob->truncate() in smb/sftp slaves

feverfew updated this revision to Diff 72155. feverfew added a comment. Avoid code duplication REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26191?vs=72154=72155 BRANCH arcpatch-D26191 REVISION DETAIL https://phabricator.kde.org/D26191 AFFECTED

D26191: Add support for FileJob->truncate() in smb/sftp slaves

feverfew updated this revision to Diff 72154. feverfew added a comment. Avoid free(NULL) REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26191?vs=72104=72154 BRANCH arcpatch-D26191 REVISION DETAIL https://phabricator.kde.org/D26191 AFFECTED FILES

D26197: Display fully qualified class/namespace name as page header

elvisangelaccio added a reviewer: ochurlaud. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D26197 To: davidre, ochurlaud Cc: ngraham, aacid, jucato, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, GB_2, michaelh, bruns, skadinna

D26210: [KCoreAddons] Port QRegExp to QRegularExpression

ahmadsamir added inline comments. INLINE COMMENTS > apol wrote in klistopenfilesjob_unix.cpp:69 > splitRef? I didn't even know there was a splitRef... It'll have to be something like: QVector pidList = out.splitRef(QRegularExpression(QStringLiteral("\\s+")), QString::SkipEmptyParts); //

D26211: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72149. ahmadsamir added a comment. Use capturedRef(), cheaper REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26211?vs=72148=72149 BRANCH l-qregularexpression (branched from master) REVISION DETAIL

D26211: Port QRegExp to QRegularExpression

apol added a comment. Looks good otherwise INLINE COMMENTS > parsetrigrams.cpp:59 > +if (match.hasMatch()) { > +models[fname][line.left(3)] = match.captured(2).toInt(); > } capturedRef REPOSITORY R246 Sonnet REVISION DETAIL

D26210: [KCoreAddons] Port QRegExp to QRegularExpression

apol added a comment. Looks good overall INLINE COMMENTS > klistopenfilesjob_unix.cpp:69 > const QString out(QString::fromLocal8Bit(lsofProcess.readAll())); > -QStringList pidList = out.split(QRegExp(QStringLiteral("\\s+")), > QString::SkipEmptyParts); > +

D26197: Display fully qualified class/namespace name as page header

ngraham added a comment. Looks sensible to me too FWIW. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D26197 To: davidre Cc: ngraham, aacid, jucato, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, GB_2, michaelh, bruns, skadinna

D26211: Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: cullmann, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R246 Sonnet BRANCH l-qregularexpression (branched from master) REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 371 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/371/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 24 Dec 2019 12:30:44 + Build duration: 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 238 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/238/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 24 Dec 2019 12:30:45 + Build duration: 9 min 14 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 253 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/253/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 24 Dec 2019 12:30:45 + Build duration: 9 min 56 sec and counting BUILD ARTIFACTS

D21783: Show more details in warning dialog shown before starting a privileged operation

chinmoyr added a comment. In D21783#581781 , @dfaure wrote: > @chinmoyr This change also breaks the corresponding unittest in CI, please take a look. >

Exemptions to try KF "grow" vs. consistent experience (Re: Submitting Grantlee as a KF5 Framework)

Am Montag, 23. Dezember 2019, 09:57:57 CET schrieb Volker Krause: > On Sunday, 22 December 2019 09:46:02 CET Dominik Haumann wrote: > > Hi all, > > > > in any case, maybe the discussed points should go to the KF6 workboard? > > https://phabricator.kde.org/project/view/310/ > > > > I indeed

D26106: Port QRegExp to QRegularExpression

ahmadsamir added a task: T12279: Port frameworks away from QRegExp. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D26106 To: ahmadsamir, drosca, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26099: Port QRegExp to QRegularExpression

ahmadsamir added a task: T12279: Port frameworks away from QRegExp. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26099 To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson,

D26210: [KCoreAddons] Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, mpyne, dfaure, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Port QRegExp::exactMatch() by using QRegularExpression::anchoredPattern() to match the entire

D26205: KWallet: Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R311:bb4eed3bfda0: KWallet: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26205?vs=72132=72146 REVISION

D26205: KWallet: Port QRegExp to QRegularExpression

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R311 KWallet BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26205 To: ahmadsamir, #frameworks, aacid, apol Cc: kde-frameworks-devel, LeGast00n, GB_2,

D26198: Deprecate KCModuleContainer

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH container REVISION DETAIL https://phabricator.kde.org/D26198 To: nicolasfella, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

File missing license header in KCoreAddons

Hi there. While working on KCoreAddons I found that "kcoreaddons/src/autotests/kstringhandlertest.cpp" doesn't have a license header at all; digging around in the old kdelibs git repo history, I found it was initially written by Waldo Bastian, commit 6b1c11fbf708ca6717c1ce2907c9862e6be4ae05.

D26197: Display fully qualified class/namespace name as page header

aacid added a comment. I've no idea about the code, but looks sensible to me, so take this as a +2 if noone reviews in a while i guess :) REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D26197 To: davidre Cc: aacid, jucato, kde-frameworks-devel, kde-doc-english,

Re: D26126: Simplify param method: Return Early, Use a Map and Assert.

David, Thanks for the detailed explanation, I'm currently reworking most of the patches here. About the optimizations - I know the linear search is a bad optimization, but it adds legibility, that's what I tried to do. I tried to emulate the python `if value in vector` that is really easy to

D17816: Support for xattrs on kio copy/move

tmarshall added inline comments. INLINE COMMENTS > tmarshall wrote in copyjob.cpp:1119 > Please help me understand for a moment. I'm not the original author of this > patch and am trying to bring it to completion. I just need to be caught up to > speed. In reading this piece of code over, I

D17816: Support for xattrs on kio copy/move

tmarshall updated this revision to Diff 72144. tmarshall added a comment. - Added helper functions to clean up tests REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=72135=72144 BRANCH arcpatch-D17816 REVISION DETAIL

D17816: Support for xattrs on kio copy/move

tmarshall marked 7 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: tmarshall, dfaure, chinmoyr, bruns, #frameworks, cochise Cc: tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham,

D26195: Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R236:84d17cbde725: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26195?vs=72115=72143 REVISION

D25974: Fix Invalid-enum-value assignment

aacid added a comment. Thanks for taking care of it, i was busy yesterday with pre-xmas stuff REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D25974 To: aacid, dfaure Cc: dfaure, security-team, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26208: [KEmailAddress] Remove redundant bool var

ahmadsamir created this revision. ahmadsamir added a reviewer: dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY It looks like 'bool tooManyAtsFlag' was copied over from isValidAddress() (where it's actually used/useful) to

D26123: Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R270:7310a343212a: Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R270 KCodecs CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26123?vs=72139=72141 REVISION DETAIL

D26123: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72139. ahmadsamir marked an inline comment as done. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Fix coding style REPOSITORY R270 KCodecs CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26123?vs=72045=72139

D26177: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72138. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Ver-blinking-batim REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26177?vs=72137=72138 BRANCH l-qregularexpression (branched from

D26177: Port QRegExp to QRegularExpression

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kconfig_compiler.cpp:646 > I wonder if qMax(path.lastIndexOf('/'), path.lastIndexOf('\\')) wouldn't be > simpler and faster :-) > > But yes you're right, might as well just delete this function. > I bet someone didn't realize,

D26177: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 72137. ahmadsamir marked an inline comment as done. ahmadsamir added a comment. Remove fileNameOnly() as per discussion in the review REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26177?vs=72049=72137 BRANCH

D26202: WIP: Refactor KConfigXT

tcanabrava added a comment. In D26202#582541 , @ngraham wrote: > > This is really a wip, completely broken. It's just so people can point me to the right direction. > > Maybe could you clarify which direction you want to be pointed in?

D17816: Support for xattrs on kio copy/move

tmarshall updated this revision to Diff 72135. tmarshall added a comment. - Addressed comments, changed xattr system calls to use file descriptors where possible REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=72131=72135 BRANCH arcpatch-D17816

D17816: Support for xattrs on kio copy/move

tmarshall added inline comments. INLINE COMMENTS > dfaure wrote in copyjob.cpp:1119 > That sounds racy; the subjob might not be finished by the time the main job > is finished, if you just "start and forget". > > I cannot accept this commit with an exec() in here. The easy and modern way > to

D26195: Port QRegExp to QRegularExpression

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26195 To: ahmadsamir, #frameworks, apol, dfaure, vkrause Cc:

D26207: Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, mlaurent, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY make && ctest REPOSITORY R306 KParts BRANCH l-qregularexpression (branched from master)

D26123: Port QRegExp to QRegularExpression

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks for the extensive research! INLINE COMMENTS > kemailaddress.cpp:608 > > bool tooManyAtsFlag = false; > bool inQuotedString = false; [pre-existing: this bool is never

D26177: Port QRegExp to QRegularExpression

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kconfig_compiler.cpp:646 > { > -int i = path.lastIndexOf(QRegExp(QStringLiteral("[/\\]"))); > +int i =

D26205: KWallet: Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, aacid. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Port QRegExp::exactMatch() with QRegularExpression::anchoredPattern() Port QRegExp::Wildcard with

D17816: Support for xattrs on kio copy/move

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > jobtest.cpp:535 > +xattrwriter.start(command, arguments); > +xattrwriter.waitForFinished(-1); > + QVERIFY() around all calls to

D26126: Simplify param method: Return Early, Use a Map and Assert.

dfaure requested changes to this revision. dfaure added inline comments. INLINE COMMENTS > kconfig_compiler.cpp:1020 > +QLatin1String("double")} > +).contains(type)) { > +return type; This linear search doesn't look like an optimization to me. It would be better to

D17816: Support for xattrs on kio copy/move

tmarshall marked 9 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: tmarshall, dfaure, chinmoyr, bruns, #frameworks, cochise Cc: tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham,

KDE CI: Frameworks » kcodecs » kf5-qt5 SUSEQt5.12 - Build # 65 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcodecs/job/kf5-qt5%20SUSEQt5.12/65/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 24 Dec 2019 08:03:20 + Build duration: 3 min 23 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcodecs » kf5-qt5 SUSEQt5.13 - Build # 37 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcodecs/job/kf5-qt5%20SUSEQt5.13/37/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 24 Dec 2019 08:03:20 + Build duration: 2 min 40 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcodecs » kf5-qt5 FreeBSDQt5.13 - Build # 33 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcodecs/job/kf5-qt5%20FreeBSDQt5.13/33/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 24 Dec 2019 08:03:20 + Build duration: 1 min 44 sec and counting JUnit Tests Name:

D25974: Fix Invalid-enum-value assignment

dfaure added a comment. Fixed in https://commits.kde.org/kcodecs/6fcd8af5b4be2082c4af7d11c18d39151f1e25d0 REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D25974 To: aacid, dfaure Cc: dfaure, security-team, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,